On Thu, 18 Nov 2021 at 17:44, Marek Vasut wrote:
>
> On 11/18/21 6:02 PM, Tim Harvey wrote:
> > On Thu, Nov 18, 2021 at 4:53 AM Marek Vasut wrote:
> >>
> >> On 11/18/21 2:25 AM, Tim Harvey wrote:
> >>> Greetings,
> >>>
> >>> I'm trying to get a RPI 7" touchscreen display working on an IMX8MM
> >>
On Thu, 18 Nov 2021 at 17:36, Tim Harvey wrote:
>
> On Thu, Nov 18, 2021 at 6:28 AM Dave Stevenson
> wrote:
> >
> > Hi Tim
> >
> > On Thu, 18 Nov 2021 at 01:26, Tim Harvey wrote:
> > >
> > > Greetings,
> > >
> > > I'm t
Hi Tim
On Thu, 18 Nov 2021 at 01:26, Tim Harvey wrote:
>
> Greetings,
>
> I'm trying to get a RPI 7" touchscreen display working on an IMX8MM
> board and while I've been able to get the MIPI DSI display and
> backlight working I still can't seem to figure out the touch
> controller.
>
> It's supp
a need to read the DDC, then it should be after HPD (in whatever
form it exists) has been checked.
No need for that to be reinstated at this point, so this patch is fine
as it stands.
Reviewed-by: Dave Stevenson
> ---
> drivers/gpu/drm/vc4/vc4_hdmi.c | 2 --
> 1 file changed, 2 deletions
if viewed necessary.
Otherwise
Reviewed-by: Dave Stevenson
> ---
> drivers/gpu/drm/vc4/vc4_crtc.c | 15 +
> drivers/gpu/drm/vc4/vc4_drv.h | 2 +
> drivers/gpu/drm/vc4/vc4_kms.c | 110 ++---
> 3 files changed, 118 insertions(+), 9 deletions(-)
i_enable_scrambling function
> in the detect callback if there is a mode and it needs the scrambler to
> be enabled.
>
> Fixes: c85695a2016e ("drm/vc4: hdmi: Enable the scrambler")
> Signed-off-by: Maxime Ripard
Reviewed-by: Dave Stevenson
> ---
> driver
ad tracker to do its
> computation, but since we don't have the same limits, don't check them
> against them, and prevent the debugfs file to enable it from being
> created.
>
> Signed-off-by: Maxime Ripard
Reviewed-by: Dave Stevenson
> ---
> drivers/g
occur.
>
> Signed-off-by: Maxime Ripard
Reviewed-by: Dave Stevenson
> ---
> drivers/gpu/drm/vc4/vc4_crtc.c | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c
> index fbc1d4638650..6decaa12a078 10064
to
> directly and without relying on any other state.
>
> Signed-off-by: Maxime Ripard
Reviewed-by: Dave Stevenson
> ---
> drivers/gpu/drm/vc4/vc4_crtc.c | 30 +-
> drivers/gpu/drm/vc4/vc4_drv.h | 4 +---
> 2 files changed, 10 insertions(+)
again.
>
> Signed-off-by: Maxime Ripard
Reviewed-by: Dave Stevenson
> ---
> drivers/gpu/drm/vc4/vc4_crtc.c | 7 +++
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c
> index 7cfd4a09784
On Mon, 25 Oct 2021 at 16:29, Maxime Ripard wrote:
>
> We'll need that function in vc4_kms to compute the core clock rate
> requirements.
>
> Signed-off-by: Maxime Ripard
Reviewed-by: Dave Stevenson
> ---
> drivers/gpu/drm/vc4/vc4_crtc.c | 8
> drive
nnected, and we
> would ignore an HPD pulse.
>
> Fixes: 6800234ceee0 ("drm/vc4: hdmi: Convert to gpiod")
> Signed-off-by: Maxime Ripard
Reviewed-by: Dave Stevenson
> ---
> drivers/gpu/drm/vc4/vc4_hdmi.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
&
On Thu, 7 Oct 2021 at 21:19, Andrzej Hajda wrote:
>
> On 07.10.2021 13:07, Dave Stevenson wrote:
> > On Tue, 5 Oct 2021 at 22:03, Andrzej Hajda wrote:
> >>
> >> On 05.10.2021 17:32, Dave Stevenson wrote:
> >>> Hi Andrzej
> >>>
> >>&g
On Fri, 8 Oct 2021 at 14:37, Laurent Pinchart
wrote:
>
> Hello,
>
> On Fri, Oct 08, 2021 at 03:27:43PM +0200, Andrzej Hajda wrote:
> > Hi,
> >
> > Removed my invalid email (I will update files next week).
> >
> > On 08.10.2021 13:14, Jagan Teki wrote:
> > > Hi,
> > >
> > > I think this seems to be
On Tue, 5 Oct 2021 at 22:03, Andrzej Hajda wrote:
>
> On 05.10.2021 17:32, Dave Stevenson wrote:
> > Hi Andrzej
> >
> > Thanks for joining in the discussion.
> >
> > On Tue, 5 Oct 2021 at 16:08, Andrzej Hajda wrote:
> >>
> >> On 05
Hi Andrzej
Thanks for joining in the discussion.
On Tue, 5 Oct 2021 at 16:08, Andrzej Hajda wrote:
>
> On 05.10.2021 13:23, Dave Stevenson wrote:
> > Hi Laurent
> >
> > On Sun, 3 Oct 2021 at 15:16, Laurent Pinchart
> > wrote:
> >>
> >>
2021 at 11:50:22AM +0200, Maxime Ripard wrote:
> > On Tue, Jul 06, 2021 at 05:44:58PM +0100, Dave Stevenson wrote:
> > > On Tue, 6 Jul 2021 at 16:13, Maxime Ripard wrote:
> > > > > > > On a similar theme, some devices want the clock lane in HS mode
> &
Hi Andrzej
Sorry, I'm just coming back to this. I'd started this reply a while
back, but got sidetracked onto other priorities and not sent it.
On Wed, 8 Sept 2021 at 22:14, Andrzej Hajda wrote:
>
>
> W dniu 08.09.2021 o 13:11, Dave Stevenson pisze:
> > Hi Marek and
> Remove it.
>
> Fixes: c7d30623540b ("drm/vc4: hdmi: Remove unused struct")
> Reported-by: kernel test robot
> Signed-off-by: Maxime Ripard
Reviewed-by: Dave Stevenson
> ---
> drivers/gpu/drm/vc4/vc4_hdmi.c | 8
> 1 file changed, 8 deletions(-)
>
>
Maxime Ripard
Reviewed-by: Dave Stevenson
> ---
> drivers/gpu/drm/vc4/Kconfig| 1 +
> drivers/gpu/drm/vc4/vc4_hdmi.c | 2 --
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/vc4/Kconfig b/drivers/gpu/drm/vc4/Kconfig
> index 118e8a42
On Wed, 8 Sept 2021 at 16:26, Marek Vasut wrote:
>
> On 9/8/21 1:11 PM, Dave Stevenson wrote:
> > Hi Marek and Andrzej
>
> Hello Dave,
>
> skipping the protocol discussion, which I hope Andrej will pick up.
>
> [...]
>
> >>> Usually video transmissio
Hi Marek and Andrzej
On Tue, 7 Sept 2021 at 22:24, Marek Vasut wrote:
>
> On 9/7/21 7:29 PM, Andrzej Hajda wrote:
> >
> > W dniu 07.09.2021 o 16:25, Marek Vasut pisze:
> >> On 9/7/21 9:31 AM, Andrzej Hajda wrote:
> >>> On 07.09.2021 04:39, Marek Vasut wrote:
> In rare cases, the bridge may n
igure error handling
> drm/vc4: hdmi: Split the CEC disable / enable functions in two
> drm/vc4: hdmi: Make sure the device is powered with CEC
> drm/vc4: hdmi: Warn if we access the controller while disabled
Comment made on patch 1.
Patches 2-5:
Reviewed-by: Dave Stevenson
Dave
&g
d suspend functions.
That's possibly a separate issue to the issue that this patch is
addressing, but may explain the test bot's failure. Otherwise
Reviewed-by: Dave Stevenson
> + if (ret)
> + goto err_put_ddc;
> +
> + pm_runti
91e99e113929 ("drm/vc4: hdmi: Register HDMI codec")
> Reported-by: kernel test robot
> Signed-off-by: Maxime Ripard
Reviewed-by: Dave Stevenson
> ---
> drivers/gpu/drm/vc4/vc4_hdmi.c | 12
> 1 file changed, 12 deletions(-)
>
> diff --git a/drivers/gpu/
d by devm
> after the resources it uses have been free'd already.
>
> The last one is there to deal with an interrupt coming in the window between
> the end of the driver's bind and the DRM device registration.
>
> Let me know what you think,
> Maxime
For the series
Review
Hi Maxime
On Tue, 6 Jul 2021 at 16:13, Maxime Ripard wrote:
>
> Hi Dave,
>
> On Mon, Jul 05, 2021 at 04:36:25PM +0100, Dave Stevenson wrote:
> > Hi Laurent.
> >
> > Thanks to you, Jani, and Jagan for your replies.
> > I'm replying to Laurent
Hi Laurent
On Fri, 2 Jul 2021 at 21:19, Laurent Pinchart
wrote:
>
> Hi Dave,
>
> On Fri, Jul 02, 2021 at 06:44:22PM +0100, Dave Stevenson wrote:
> > On Fri, 2 Jul 2021 at 17:47, Laurent Pinchart wrote:
> > > On Mon, Jun 21, 2021 at 04:59:51PM +0300, Laurent Pinchart w
1 at 17:42, Laurent Pinchart
wrote:
>
> Hi Dave,
>
> (Expanding the CC list a bit)
>
> On Fri, Jul 02, 2021 at 12:03:31PM +0100, Dave Stevenson wrote:
> > Hi All
> >
> > I'm trying to get DSI devices working reliably on the Raspberry Pi,
> > but I&#x
300, Laurent Pinchart wrote:
> > > > On Mon, Jun 21, 2021 at 12:49:14PM +0100, Dave Stevenson wrote:
> > > > > On Sun, 20 Jun 2021 at 23:49, Laurent Pinchart wrote:
> > > > > > On Sun, Jun 20, 2021 at 09:42:27PM +0300, Laurent Pinchart wrote:
>
Hi All
I'm trying to get DSI devices working reliably on the Raspberry Pi,
but I'm hitting a number of places where it isn't clear as to the
expected behaviour within DRM.
Power on state. Many devices want the DSI clock and/or data lanes in
LP-11 state when they are powered up. With the normal ca
Hi Maxime
On Mon, 21 Jun 2021 at 17:05, Maxime Ripard wrote:
>
> Hi Laurent,
>
> On Sun, Jun 20, 2021 at 04:44:33AM +0300, Laurent Pinchart wrote:
> > Hi Maxime,
> >
> > I'm testing this, and I'm afraid it causes an issue with all the
> > I2C-controlled bridges. I'm focussing on the newly merged
Hi Laurent
On Sun, 20 Jun 2021 at 23:49, Laurent Pinchart
wrote:
>
> Hi Dave,
>
> On Sun, Jun 20, 2021 at 09:42:27PM +0300, Laurent Pinchart wrote:
> > On Sun, Jun 20, 2021 at 03:29:03PM +0100, Dave Stevenson wrote:
> > > On Sun, 20 Jun 2021 at 04:26, Laurent Pinchar
Hi Laurent
On Sun, 20 Jun 2021 at 04:26, Laurent Pinchart
wrote:
>
> Hi Maxime,
>
> I'm testing this, and I'm afraid it causes an issue with all the
> I2C-controlled bridges. I'm focussing on the newly merged ti-sn65dsi83
> driver at the moment, but other are affected the same way.
>
> With this
powered during the detect cycle to prevent the hang from
> happening.
>
> Fixes: 4f6e3d66ac52 ("drm/vc4: Add runtime PM support to the HDMI encoder
> driver")
> Signed-off-by: Maxime Ripard
Reviewed-by: Dave Stevenson
> ---
> drivers/gpu/drm/vc4/vc4_hdmi.c | 4 ++
crtc_configure when the pixel rate is known.
However the crtc and HDMI blocks won't be actively passing pixels at
that point, so I don't see an issue with changing the rate. The clock
manager block will sort out the rate change happily.
Reviewed-by: Dave Stevenson
> Fixes: 4f6e3d66ac5
>
> Switch the driver to rely on the internal controller logic for the
> BCM2711/RPi4.
Reviewed-by: Dave Stevenson
> Signed-off-by: Maxime Ripard
> ---
> drivers/gpu/drm/vc4/vc4_hdmi.c | 44 ++
> 1 file changed, 44 insertions(+)
>
> dif
clocks at boot if
> the controller is enabled to get the use-count right.
>
> Cc: # v5.10+
> Fixes: 09c438139b8f ("drm/vc4: hdmi: Implement finer-grained hooks")
> Signed-off-by: Maxime Ripard
Reviewed-by: Dave Stevenson
> ---
> drivers/gpu/drm/vc4/vc4_hdmi.c |
ixes: 875a4d536842 ("drm/vc4: drv: Disable the CRTC at boot time")
> Signed-off-by: Maxime Ripard
Reviewed-by: Dave Stevenson
> ---
> drivers/gpu/drm/vc4/vc4_crtc.c | 38 ++
> 1 file changed, 34 insertions(+), 4 deletions(-)
>
> di
o support both the enable and disable path, we can
> support it by passing the state accessor variant as a function pointer,
> together with the atomic state.
>
> Fixes: 792c3132bc1b ("drm/vc4: encoder: Add finer-grained encoder callbacks")
> Signed-off-by: Maxime Ripard
work as expected.
>
> Let's create delayed work queue to periodically look at the display
> scrambling status, and if it's not set yet try to enable it again.
>
> Signed-off-by: Maxime Ripard
Reviewed-by: Dave Stevenson
> ---
> drivers/gpu/drm/vc4/vc4_hdmi.c | 25
Hi Maxime
On Fri, 7 May 2021 at 16:06, Maxime Ripard wrote:
>
> The HDMI controller on the BCM2711 includes a scrambler in order to
> reach the HDMI 2.0 modes that require it. Let's add the support for it.
>
> Acked-by: Thomas Zimmermann
> Signed-off-by: Maxime Rip
gt; Fixes: 792c3132bc1b ("drm/vc4: encoder: Add finer-grained encoder callbacks")
> Signed-off-by: Maxime Ripard
Reviewed-by: Dave Stevenson
> ---
> drivers/gpu/drm/vc4/vc4_crtc.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/d
eam kernel.
Thanks for upstreaming these.
As far as I'm concerned they're all good, but DT bindings aren't an
area of expertise for me.
Patches 1&3:
Reviewed-by: Dave Stevenson
Patches 2&4:
Acked-by: Dave Stevenson
This is going to need firmware from 23rd March 2021 or later in o
On Mon, 10 May 2021 at 12:16, Marek Vasut wrote:
>
> On 5/10/21 11:58 AM, Dave Stevenson wrote:
> > On Sat, 8 May 2021 at 21:26, Marek Vasut wrote:
> >>
> >> On 5/7/21 2:48 PM, Dave Stevenson wrote:
> >>
> >> [...]
> >>
>
On Sat, 8 May 2021 at 21:26, Marek Vasut wrote:
>
> On 5/7/21 2:48 PM, Dave Stevenson wrote:
>
> [...]
>
> >> +static void sn65dsi83_enable(struct drm_bridge *bridge)
> >> +{
> >> + struct sn65dsi83 *ctx = bridge_to_sn65dsi83(bridge);
> >&
On Wed, 5 May 2021 at 11:03, Marek Vasut wrote:
>
> Add driver for TI SN65DSI83 Single-link DSI to Single-link LVDS bridge
> and TI SN65DSI84 Single-link DSI to Dual-link or 2x Single-link LVDS
> bridge. TI SN65DSI85 is unsupported due to lack of hardware to test on,
> but easy to add.
>
> The dri
On Thu, 6 May 2021 at 21:51, Marek Vasut wrote:
>
> On 5/6/21 6:03 PM, Frieder Schrempf wrote:
> > On 06.05.21 17:46, Marek Vasut wrote:
> >> On 5/6/21 5:38 PM, Frieder Schrempf wrote:
> >> [...]
> >>> Works on i.MX8MM with SN65DSI84 and a single link LVDS display (1024x600)
> >>> and from my per
On Thu, 6 May 2021 at 21:49, Marek Vasut wrote:
>
> On 5/6/21 7:03 PM, Dave Stevenson wrote:
> > On Thu, 6 May 2021 at 13:48, Marek Vasut wrote:
> >>
> >> On 5/6/21 11:45 AM, Dave Stevenson wrote:
> >>> Hi Marek
> >>
> >> Hi,
> >
On Thu, 6 May 2021 at 13:48, Marek Vasut wrote:
>
> On 5/6/21 11:45 AM, Dave Stevenson wrote:
> > Hi Marek
>
> Hi,
>
> > I'm taking an interest as there are a number of Raspberry Pi users
> > trying to get this chip up and running (not there quite yet).
Hi Marek
I'm taking an interest as there are a number of Raspberry Pi users
trying to get this chip up and running (not there quite yet).
A couple of fairly minor comments
On Wed, 5 May 2021 at 11:03, Marek Vasut wrote:
>
> Add driver for TI SN65DSI83 Single-link DSI to Single-link LVDS bridge
>
Hi Maxime
On Fri, 9 Apr 2021 at 13:36, Maxime Ripard wrote:
>
> Hi Dave,
>
> On Thu, Apr 01, 2021 at 12:30:45PM +0100, Dave Stevenson wrote:
> > > Signed-off-by: Maxime Ripard
> > > ---
> > > drivers/gpu/drm/vc4/vc4_hdmi.c | 56 +
Hi Maxime
On Thu, 18 Mar 2021 at 09:29, Maxime Ripard wrote:
>
> The HDMI controller on the BCM2711 includes a scrambler in order to
> reach the modes that require it. Let's add the support for it.
Nit pick - it's as part of the HDMI2.0 spec.
> Signed-off-by: Maxime Ripard
> ---
> drivers/gpu
detect it at bind time, warn the user if we can't, and filter out
> the relevant modes.
>
> Signed-off-by: Maxime Ripard
Reviewed-by: Dave Stevenson
> ---
> drivers/gpu/drm/vc4/vc4_hdmi.c | 26 ++
> drivers/gpu/drm/vc4/vc4_hdmi.h | 8
> 2
Hi Maxime
Sorry for the delay in reviewing these patches.
On Thu, 18 Mar 2021 at 09:29, Maxime Ripard wrote:
>
> The BVB clock rate computation doesn't take into account a mode clock of
> 594MHz that we're going to need to support 4k60.
>
> Signed-off-by: Maxime R
On Tue, 2 Mar 2021 at 13:02, Maxime Ripard wrote:
>
> Hi Dave,
>
> Thanks for your review
>
> On Thu, Feb 25, 2021 at 04:38:37PM +0000, Dave Stevenson wrote:
> > On Thu, 25 Feb 2021 at 15:59, Maxime Ripard wrote:
> > >
> > > In order to reach the f
On Thu, 25 Feb 2021 at 16:44, Dave Stevenson
wrote:
>
> Hi Maxime
>
> On Thu, 25 Feb 2021 at 15:59, Maxime Ripard wrote:
> >
> > The BVB clock rate computation doesn't take into account a mode clock of
> > 594MHz that we're going to need to support 4k
of.
>
> Signed-off-by: Maxime Ripard
Based on my understanding of bind ordering this makes sense, but I
don't consider myself an expert there.
Acked-by: Dave Stevenson
> ---
> drivers/gpu/drm/vc4/vc4_drv.c | 11 ++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
On Thu, 25 Feb 2021 at 15:59, Maxime Ripard wrote:
>
> Signed-off-by: Maxime Ripard
Again no commit text body, but possibly not warranted
Reviewed-by: Dave Stevenson
> ---
> drivers/gpu/drm/vc4/vc4_plane.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>
On Thu, 25 Feb 2021 at 15:59, Maxime Ripard wrote:
>
> Signed-off-by: Maxime Ripard
Other than no commit text body (which is hardly needed in this case)
Reviewed-by: Dave Stevenson
> ---
> drivers/gpu/drm/vc4/vc4_plane.c | 1 -
> 1 file changed, 1 deletion(-)
>
> dif
r than what we can provide to support the same
> modes.
>
> Signed-off-by: Maxime Ripard
Reviewed-by: Dave Stevenson
> ---
> drivers/gpu/drm/vc4/vc4_hdmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/g
Hi Maxime
On Thu, 25 Feb 2021 at 15:59, Maxime Ripard wrote:
>
> The BVB clock rate computation doesn't take into account a mode clock of
> 594MHz that we're going to need to support 4k60.
>
> Signed-off-by: Maxime Ripard
> ---
> drivers/gpu/drm/vc4/vc4_hdmi.c | 11 +++
> 1 file changed
Hi Maxime
On Thu, 25 Feb 2021 at 15:59, Maxime Ripard wrote:
>
> In order to reach the frequencies needed to output at 594MHz, the
> firmware needs to be configured with the appropriate parameters in the
> config.txt file (enable_hdmi_4kp60 and force_turbo).
force_turbo isn't the right way to go
Hi Maxime
On Thu, 25 Feb 2021 at 15:59, Maxime Ripard wrote:
>
> The HDMI controller on the BCM2711 includes a scrambler in order to
> reach the modes that require it. Let's add the support for it.
>
> Signed-off-by: Maxime Ripard
> ---
> drivers/gpu/drm/vc4/vc4_hdmi.c | 58 +++
Hi Marc.
On Wed, 10 Feb 2021 at 15:30, Marc Zyngier wrote:
>
> Hi Maxime,
>
> On 2021-02-10 14:40, Maxime Ripard wrote:
> > Hi Dave,
> >
> > On Tue, Feb 09, 2021 at 09:49:05AM +, Dave Stevenson wrote:
> >> On Mon, 11 Jan 2021 at 14:23, Maxime Ripard w
Hi Maxime
On Mon, 11 Jan 2021 at 14:23, Maxime Ripard wrote:
>
> The BSC controllers used for the HDMI DDC have an interrupt controller
> shared between both instances. Let's add it to avoid polling.
This seems to have unintended side effects.
GIC interrupt 117 is shared between the standard I2C
out of vc4_plane_mode_set()")
> Signed-off-by: Maxime Ripard
Looks good.
Reviewed-by: Dave Stevenson
> ---
> drivers/gpu/drm/vc4/vc4_plane.c | 18 ++
> 1 file changed, 14 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/vc4/vc4_plane.c b/driv
x27;m not a DT bindings expert
Acked-by: Dave Stevenson
> ---
> .../bindings/display/brcm,bcm2711-hdmi.yaml | 20 ++-
> 1 file changed, 19 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml
> b/Docume
upt handler and
> deals with the interrupt handler setup, or two interrupt handlers
> relying on an external irqchip.
>
> Signed-off-by: Maxime Ripard
Looks good
Reviewed-by: Dave Stevenson
> ---
> drivers/gpu/drm/vc4/vc4_hdmi.c | 42 ++
> dri
CEC controller is identical though so we need to change
> a bit the code organisation to share the code as much as possible, yet
> still allowing to register independant handlers.
s/independant/independent
>
> Signed-off-by: Maxime Ripard
With that
Reviewed-by: Dave Stevenson
> ---
y: Maxime Ripard
I follow the logic, and trust Dom that it works, but I don't know if
that is the correct thing within CEC.
Ideally Hans will comment as the original author of the CEC code - I
believe he's testing the series anyway.
Acked-by: Dave Stevenson
> ---
> driver
50] 7fc0: 027eb750 befdd870 c03864bc 0036 027e3948 0281a640
> 0281a850 027e3a50
> [ 284.315756] 7fe0: b4b64100 befdd844 b4b5ba2c b49c994c
> [ 284.315762] r10:0036 r9:c3d46000 r8:c0200204 r7:0036 r6:c03864bc
> r5:befdd870
> [ 284.315765] r4:027eb750
>
> Fixes:
of format).
>
> The LBM adress indexes work in units of pixels per clock,
> so for 4 pixels per clock that means we have 32 * 1920 = 60K
>
> Fixes: c54619b0bfb3 ("drm/vc4: Add support for the BCM2711 HVS5")
> Signed-off-by: Dom Cobley
> Signed-off-by: Maxime Ripard
On Fri, 18 Dec 2020 at 14:21, Dave Stevenson
wrote:
>
> Hi Maxime & Dom
>
> On Thu, 10 Dec 2020 at 13:47, Maxime Ripard wrote:
> >
> > From: Dom Cobley
> >
> > Currently we call cec_phys_addr_invalidate on a hotplug deassert.
> > That may be due t
Hi Dom & Maxime
On Thu, 10 Dec 2020 at 13:47, Maxime Ripard wrote:
>
> From: Dom Cobley
>
> Now that our HDMI controller supports CEC for the BCM2711, let's remove
> that flag.
>
> Signed-off-by: Dom Cobley
> Signed-off-by: Maxime Ripard
Reviewed-by: Dave Ste
e CEC setup if the DT doesn't have the
> interrupts property.
>
> Signed-off-by: Maxime Ripard
Reviewed-by: Dave Stevenson
> ---
> drivers/gpu/drm/vc4/vc4_hdmi.c | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/driv
moving code that
was changed in patch 6/15 so it can be called from
vc4_hdmi_encoder_pre_crtc_configure too. Good for confusing me!
Reviewed-by: Dave Stevenson
> ---
> drivers/gpu/drm/vc4/vc4_hdmi.c | 39 +-
> 1 file changed, 29 insertions(+), 10
Hi Maxime & Dom
On Thu, 10 Dec 2020 at 13:47, Maxime Ripard wrote:
>
> From: Dom Cobley
>
> Currently we call cec_phys_addr_invalidate on a hotplug deassert.
> That may be due to a TV power cycling, or an AVR being switched
> on (and switching edid).
>
> This makes CEC unusable since our contro
On Fri, 18 Dec 2020 at 12:23, Maxime Ripard wrote:
>
> Hi Dave,
>
> On Fri, Dec 18, 2020 at 11:37:50AM +, Dave Stevenson wrote:
> > Hi Maxime
> >
> > On Thu, 10 Dec 2020 at 13:47, Maxime Ripard wrote:
> > >
> > > While the BCM2835 h
Hi Maxime
On Thu, 10 Dec 2020 at 13:47, Maxime Ripard wrote:
>
> While the BCM2835 had the CEC clock derived from the HSM clock, the
> BCM2711 has a dedicated parent clock for it.
>
> Let's introduce a separate clock for it so that we can handle both
> cases.
>
> Signed-off-by: Maxime Ripard
> -
> the proper rate.
>
> Fixes: cd4cb49dc5bb ("drm/vc4: hdmi: Adjust HSM clock rate depending on pixel
> rate")
> Signed-off-by: Maxime Ripard
Reviewed-by: Dave Stevenson
(To be a total pedant it's still a fixed frequency on vc4, but it's
configurable via th
e. Fix those mistakes.
>
> Fixes: 311e305fdb4e ("drm/vc4: hdmi: Implement a register layout abstraction")
> Signed-off-by: Dom Cobley
> Signed-off-by: Maxime Ripard
Reviewed-by: Dave Stevenson
> ---
> drivers/gpu/drm/vc4/vc4_hdmi_regs.h | 4 +++-
> 1 file changed, 3 in
re block I don't see it needing to be triggered on every
configure.
> Fixes: 9045e91a476b ("drm/vc4: hdmi: Add reset callback")
> Signed-off-by: Dom Cobley
> Signed-off-by: Maxime Ripard
Reviewed-by: Dave Stevenson
> ---
> drivers/gpu/drm/vc4/vc4_hdmi.c | 6 +++--
Hi Maxime
On Tue, 15 Dec 2020 at 15:43, Maxime Ripard wrote:
>
> The BCM2711 supports higher bpc count than just 8, so let's support it in
> our driver.
>
> Signed-off-by: Maxime Ripard
Reviewed-by: Dave Stevenson
> ---
> drivers/gpu/dr
e
> associated to the state.
>
> Acked-by: Thomas Zimmermann
> Signed-off-by: Maxime Ripard
I'm happy again
Reviewed-by: Dave Stevenson
> ---
> drivers/gpu/drm/vc4/vc4_hdmi.c | 33 ++---
> drivers/gpu/drm/vc4/vc4_hdmi.h | 10 ++
>
Implement a register layout abstraction")
> Signed-off-by: Dom Cobley
> Signed-off-by: Maxime Ripard
Reviewed-by: Dave Stevenson
> ---
> drivers/gpu/drm/vc4/vc4_hdmi.c | 17 +++--
> 1 file changed, 15 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/g
Hi Maxime
On Thu, 10 Dec 2020 at 14:23, Maxime Ripard wrote:
>
> The BCM2711 supports higher bpc count than just 8, so let's support it in
> our driver.
>
> Signed-off-by: Maxime Ripard
Looks good to me, but is impacted by the comment I've just made on 5/9.
Dave
> ---
> drivers/gpu/drm/vc
e
> associated to the state.
>
> Acked-by: Thomas Zimmermann
> Reviewed-by: Dave Stevenson
> Signed-off-by: Maxime Ripard
> ---
> drivers/gpu/drm/vc4/vc4_hdmi.c | 33 ++---
> drivers/gpu/drm/vc4/vc4_hdmi.h | 10 ++
> 2 files change
n the pixel clock at in our custom
> connector state, and compute it in atomic_check.
>
> Signed-off-by: Maxime Ripard
Reviewed-by: Dave Stevenson
> ---
> drivers/gpu/drm/vc4/vc4_hdmi.c | 26 +-
> drivers/gpu/drm/vc4/vc4_hdmi.h | 1 +
> 2 files chang
Hi Maxime
On Mon, 7 Dec 2020 at 15:57, Maxime Ripard wrote:
>
> Reported-by: Thomas Zimmermann
> Fixes: 63495f6b4aed ("drm/vc4: hdmi: Make sure our clock rate is within
> limits")
> Signed-off-by: Maxime Ripard
Reviewed-by: Dave Stevenson
> ---
> dri
Hi Maxime
On Mon, 7 Dec 2020 at 15:57, Maxime Ripard wrote:
>
> The BCM2711 supports higher bpc count than just 8, so let's support it in
> our driver.
>
> Signed-off-by: Maxime Ripard
> ---
> drivers/gpu/drm/vc4/vc4_hdmi.c | 71 -
> drivers/gpu/drm/vc4/vc4_hdmi
>
> Signed-off-by: Maxime Ripard
Reviewed-by: Dave Stevenson
> ---
> drivers/gpu/drm/vc4/vc4_hdmi.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
> index 5310e06efc82..f4ff6b
gt;
> Since the TMDS clock rate is stored in our custom connector state
> already, let's reuse it from there instead of computing it again.
>
> Acked-by: Thomas Zimmermann
> Signed-off-by: Maxime Ripard
Reviewed-by: Dave Stevenson
> ---
> drivers/gpu/drm/vc4/vc4_
t; associated to the state.
>
> Acked-by: Thomas Zimmermann
> Signed-off-by: Maxime Ripard
Reviewed-by: Dave Stevenson
> ---
> drivers/gpu/drm/vc4/vc4_hdmi.c | 27 +--
> drivers/gpu/drm/vc4/vc4_hdmi.h | 10 ++
> 2 files changed, 35 inser
; that will access connector->state without checking if it's a valid
> pointer or not.
>
> Make sure we don't end up accessing a NULL pointer.
>
> Acked-by: Thomas Zimmermann
> Suggested-by: Dave Stevenson
> Signed-off-by: Maxime Ripard
Reviewed-by: Dave Stevenson
&
ince the we can't
> update the packet RAM until it has been sent.
>
> Let's add a boolean flag to tell whether we want to poll or not to
> support both cases.
>
> Suggested-by: Dave Stevenson
> Signed-off-by: Maxime Ripard
That looks like it should do what was intend
Hi Marek
On Wed, 12 Aug 2020 at 21:07, Sam Ravnborg wrote:
>
> Hi Marek.
>
> On Sun, Aug 09, 2020 at 12:57:04PM +0200, Marek Vasut wrote:
> > Add DT bindings for Toshiba TC358762 DSI-to-DPI bridge, this
> > one is used in the Raspberry Pi 7" touchscreen display unit.
> >
> > Signed-off-by: Marek
g a variant structure is much
cleaner than the hack I had.
For those that I didn't author (ie 1, 3, and 4)
Reviewed-by: Dave Stevenson
> Dave Stevenson (5):
> drm/vc4: dsi: Correct DSI register definition
> drm/vc4: dsi: Add support for DSI0
> dt-bindings: Add com
ince the we can't
> update the packet RAM until it has been sent.
>
> Let's add a boolean flag to tell whether we want to poll or not to
> support both cases.
>
> Suggested-by: Dave Stevenson
> Signed-off-by: Maxime Ripard
> ---
> drivers/gpu/drm/vc4/vc4_hdm
that limit,
> but the userspace is still free to try to setup a mode that would.
>
> Implement atomic_check to make sure we check it in that scenario too.
>
> Signed-off-by: Maxime Ripard
Reviewed-by: Dave Stevenson
> ---
>
> Changes from v1:
> - Added that patch to
301 - 400 of 471 matches
Mail list logo
