Re: [PATCH v1] misc: fastrpc: Move fastrpc driver to misc/fastrpc/

2024-06-19 Thread Dmitry Baryshkov
On Wed, 19 Jun 2024 at 10:01, Ekansh Gupta wrote: > > > > On 6/19/2024 12:21 PM, Dmitry Baryshkov wrote: > > On Wed, 19 Jun 2024 at 09:45, Ekansh Gupta > > wrote: > >> > >> > >> On 6/12/2024 11:58 PM, Dmitry Baryshkov wrote: > >>&g

Re: [PATCH v1] misc: fastrpc: Move fastrpc driver to misc/fastrpc/

2024-06-18 Thread Dmitry Baryshkov
On Wed, 19 Jun 2024 at 09:45, Ekansh Gupta wrote: > > > > On 6/12/2024 11:58 PM, Dmitry Baryshkov wrote: > > On Wed, Jun 12, 2024 at 12:17:28PM +0530, Ekansh Gupta wrote: > >> Move fastrpc.c from misc/ to misc/fastrpc/. New C files are planned > >> to be

Re: [PATCH v2] drm/panel: raydium-rm692e5: transition to mipi_dsi wrapped functions

2024-06-18 Thread Dmitry Baryshkov
On Wed, Jun 19, 2024 at 09:03:49AM GMT, Tejas Vipin wrote: > Use functions introduced in commit 966e397e4f60 ("drm/mipi-dsi: Introduce > mipi_dsi_*_write_seq_multi()") and commit f79d6d28d8fe > ("drm/mipi-dsi: wrap more functions for streamline handling") for the > raydium rm692e5 panel. > > Signe

Re: [PATCH v3 02/23] gcc-sdm845: Add rates to the GP clocks

2024-06-18 Thread Dmitry Baryshkov
On Tue, Jun 18, 2024 at 09:11:58PM GMT, Konrad Dybcio wrote: > > > On 6/18/24 20:55, Dmitry Baryshkov wrote: > > On Tue, Jun 18, 2024 at 08:50:52PM GMT, Konrad Dybcio wrote: > > > > > > > > > On 6/18/24 19:50, Dmitry Baryshkov wrote: > > >

Re: [PATCH v3 7/9] drm/msm/dpu: drop _dpu_crtc_check_and_setup_lm_bounds from atomic_begin

2024-06-18 Thread Dmitry Baryshkov
On Wed, 19 Jun 2024 at 01:56, Abhinav Kumar wrote: > On 6/13/2024 4:20 PM, Abhinav Kumar wrote: > > On 6/13/2024 3:36 PM, Dmitry Baryshkov wrote: > >> The dpu_crtc_atomic_check() already calls the function > >> _dpu_crtc_check_and_setup_lm_bounds(). There is no need

Re: [PATCH v3 02/23] gcc-sdm845: Add rates to the GP clocks

2024-06-18 Thread Dmitry Baryshkov
On Tue, Jun 18, 2024 at 08:50:52PM GMT, Konrad Dybcio wrote: > > > On 6/18/24 19:50, Dmitry Baryshkov wrote: > > On Tue, Jun 18, 2024 at 04:59:36PM GMT, Dzmitry Sankouski wrote: > > > sdm845 has "General Purpose" clocks that can be muxed to > > > SoC

Re: [PATCH v3 11/23] drm/panel: Add support for S6E3HA8 panel driver

2024-06-18 Thread Dmitry Baryshkov
On Tue, Jun 18, 2024 at 04:59:45PM GMT, Dzmitry Sankouski wrote: > Add support for MIPI-DSI based S6E3HA8 AMOLED panel > driver. This panel has 1440x2960 resolution, 5.8-inch physical > size, and can be found in starqltechn device. > Brightness regulation is not yet supported. > > Signed-off-by: D

Re: [PATCH] drm: bridge: simple-bridge: use devm_drm_bridge_add in probe

2024-06-18 Thread Dmitry Baryshkov
x.fr > --- > drivers/gpu/drm/bridge/simple-bridge.c | 13 + > 1 file changed, 1 insertion(+), 12 deletions(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v3 02/23] gcc-sdm845: Add rates to the GP clocks

2024-06-18 Thread Dmitry Baryshkov
On Tue, Jun 18, 2024 at 04:59:36PM GMT, Dzmitry Sankouski wrote: > sdm845 has "General Purpose" clocks that can be muxed to > SoC pins. > > Those clocks may be used as e.g. PWM sources for external peripherals. > Add more frequencies to the table for those clocks so it's possible > for arbitrary p

Re: [PATCH v7 2/9] drm: Support per-plane async flip configuration

2024-06-18 Thread Dmitry Baryshkov
On Tue, Jun 18, 2024 at 01:18:10PM GMT, André Almeida wrote: > Em 18/06/2024 07:07, Dmitry Baryshkov escreveu: > > On Tue, 18 Jun 2024 at 12:38, Jani Nikula > > wrote: > > > > > > On Tue, 18 Jun 2024, André Almeida wrote: > > > > Drivers have differ

Re: [PATCH v3 4/5] drm/msm/adreno: Move hwcg table into a6xx specific info

2024-06-18 Thread Dmitry Baryshkov
On Tue, Jun 18, 2024 at 09:33:48AM GMT, Rob Clark wrote: > On Tue, Jun 18, 2024 at 1:30 AM Dmitry Baryshkov > wrote: > > > > On Mon, Jun 17, 2024 at 03:51:14PM GMT, Rob Clark wrote: > > > From: Rob Clark > > > > > > Introduce a6xx_info

Re: [PATCH 4/4] drm: bridge: simple-bridge: add tdp158 support

2024-06-18 Thread Dmitry Baryshkov
On Tue, Jun 18, 2024 at 01:48:48PM GMT, Marc Gonzalez wrote: > On 18/06/2024 00:33, Dmitry Baryshkov wrote: > > > On Mon, Jun 17, 2024 at 06:03:02PM GMT, Marc Gonzalez wrote: > > > >> + if (sbridge->vcc) { > >> + ret = regulator_enable(sb

Re: [PATCH 3/4] drm: bridge: simple-bridge: use only devm* in probe

2024-06-18 Thread Dmitry Baryshkov
On Tue, Jun 18, 2024 at 01:37:15PM GMT, Marc Gonzalez wrote: > On 18/06/2024 00:28, Dmitry Baryshkov wrote: > > > On Mon, Jun 17, 2024 at 06:03:01PM GMT, Marc Gonzalez wrote: > > > >> Once probe uses only devm functions, remove() becomes unnecessary. > > &

Re: [PATCH v2 1/2] drm/bridge: ti-sn65dsi86: Add atomic_check hook for the bridge

2024-06-18 Thread Dmitry Baryshkov
On Tue, 18 Jun 2024 at 12:56, Jayesh Choudhary wrote: > > Hello Dmitry, > > Thanks for the review. > > On 18/06/24 14:29, Dmitry Baryshkov wrote: > > On Tue, Jun 18, 2024 at 01:44:17PM GMT, Jayesh Choudhary wrote: > >> Add the atomic_check hook to ensure t

Re: [PATCH v2 2/2] drm/bridge: ti-sn65dsi86: Fix ti_sn_bridge_set_dsi_rate function

2024-06-18 Thread Dmitry Baryshkov
On Tue, 18 Jun 2024 at 13:05, Jayesh Choudhary wrote: > > Hello Dmitry, > > On 18/06/24 14:33, Dmitry Baryshkov wrote: > > On Tue, Jun 18, 2024 at 01:44:18PM GMT, Jayesh Choudhary wrote: > >> During code inspection, it was found that due to integer calculations, >

Re: [PATCH v7 2/9] drm: Support per-plane async flip configuration

2024-06-18 Thread Dmitry Baryshkov
On Tue, 18 Jun 2024 at 12:38, Jani Nikula wrote: > > On Tue, 18 Jun 2024, André Almeida wrote: > > Drivers have different capabilities on what plane types they can or > > cannot perform async flips. Create a plane::async_flip field so each > > driver can choose which planes they allow doing async

Re: Correct sequencing of usage of DRM writeback connector

2024-06-18 Thread Dmitry Baryshkov
On Tue, 18 Jun 2024 at 12:33, Daniel Vetter wrote: > > On Mon, Jun 17, 2024 at 10:52:27PM +0300, Dmitry Baryshkov wrote: > > On Mon, Jun 17, 2024 at 11:28:35AM GMT, Abhinav Kumar wrote: > > > Hi > > > > > > On 6/17/2024 9:54 AM, Brian Starkey wrote: >

Re: [PATCH RFC 5/5] drm/bridge: lt9611: switch to using the DRM HDMI codec framework

2024-06-18 Thread Dmitry Baryshkov
On Sat, Jun 15, 2024 at 08:53:34PM GMT, Dmitry Baryshkov wrote: > Make the Lontium LT9611 DSI-to-HDMI bridge driver use the DRM HDMI Codec > framework. This enables programming of Audio InfoFrames using the HDMI > Connector interface and also enables support for the missing features, &g

Re: [PATCH v2 2/2] drm/bridge: ti-sn65dsi86: Fix ti_sn_bridge_set_dsi_rate function

2024-06-18 Thread Dmitry Baryshkov
On Tue, Jun 18, 2024 at 01:44:18PM GMT, Jayesh Choudhary wrote: > During code inspection, it was found that due to integer calculations, > the rounding off can cause errors in the final value propagated in the > registers. > Considering the example of 1080p (very common resolution), the mode->clock

Re: [PATCH v2 1/2] drm/bridge: ti-sn65dsi86: Add atomic_check hook for the bridge

2024-06-18 Thread Dmitry Baryshkov
On Tue, Jun 18, 2024 at 01:44:17PM GMT, Jayesh Choudhary wrote: > Add the atomic_check hook to ensure that the parameters are within the > valid range. > As of now, dsi clock freqency is being calculated in bridge_enable but > this needs to be checked in atomic_check which is called before > bridge

Re: [PATCH RESEND] drm/display: Drop obsolete dependency on COMPILE_TEST

2024-06-18 Thread Dmitry Baryshkov
On Mon, Jun 17, 2024 at 07:12:05PM GMT, Doug Anderson wrote: > Hi, > > On Mon, Jun 17, 2024 at 3:26 PM Dmitry Baryshkov > wrote: > > > > On Mon, Jun 17, 2024 at 08:18:14PM GMT, Jean Delvare wrote: > > > On Mon, 17 Jun 2024 14:55:22 +0300, Dmitry Baryshkov wrote

Re: [PATCH v3 4/5] drm/msm/adreno: Move hwcg table into a6xx specific info

2024-06-18 Thread Dmitry Baryshkov
reno/a6xx_catalog.c | 65 +-- > drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 6 +-- > drivers/gpu/drm/msm/adreno/a6xx_gpu.h | 9 > drivers/gpu/drm/msm/adreno/adreno_gpu.h | 6 ++- > 4 files changed, 67 insertions(+), 19 deletions(-) > Reviewed-by: Dmitry Baryshkov

Re: [PATCH v3 5/5] drm/msm/adreno: Move CP_PROTECT settings to hw catalog

2024-06-18 Thread Dmitry Baryshkov
eno/a6xx_gpu.c | 257 +- > drivers/gpu/drm/msm/adreno/a6xx_gpu.h | 2 + > drivers/gpu/drm/msm/adreno/adreno_gpu.h | 13 ++ > 4 files changed, 268 insertions(+), 251 deletions(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v3 3/5] drm/msm/adreno: Move hwcg regs to a6xx hw catalog

2024-06-17 Thread Dmitry Baryshkov
eno/a6xx_gpu.c | 617 - > drivers/gpu/drm/msm/adreno/adreno_gpu.h | 3 - > 3 files changed, 619 insertions(+), 620 deletions(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v3 2/5] drm/msm/adreno: Split catalog into separate files

2024-06-17 Thread Dmitry Baryshkov
drivers/gpu/drm/msm/adreno/a4xx_catalog.c > create mode 100644 drivers/gpu/drm/msm/adreno/a5xx_catalog.c > create mode 100644 drivers/gpu/drm/msm/adreno/a6xx_catalog.c > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v3 1/5] drm/msm/adreno: Split up giant device table

2024-06-17 Thread Dmitry Baryshkov
rm/msm/adreno/adreno_device.c | 67 +- > drivers/gpu/drm/msm/adreno/adreno_gpu.h| 10 > 2 files changed, 63 insertions(+), 14 deletions(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v2 1/5] drm/msm/adreno: Split up giant device table

2024-06-17 Thread Dmitry Baryshkov
rm/msm/adreno/adreno_device.c | 67 +- > drivers/gpu/drm/msm/adreno/adreno_gpu.h| 10 > 2 files changed, 63 insertions(+), 14 deletions(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH 4/4] drm: bridge: simple-bridge: add tdp158 support

2024-06-17 Thread Dmitry Baryshkov
On Mon, Jun 17, 2024 at 06:03:02PM GMT, Marc Gonzalez wrote: > The TI TDP158 is an AC-Coupled HDMI signal to TMDS Redriver supporting > DVI 1.0 and HDMI 1.4b and 2.0b output signals. > > Signed-off-by: Marc Gonzalez > --- > drivers/gpu/drm/bridge/simple-bridge.c | 64 > +

Re: [PATCH 3/4] drm: bridge: simple-bridge: use only devm* in probe

2024-06-17 Thread Dmitry Baryshkov
On Mon, Jun 17, 2024 at 06:03:01PM GMT, Marc Gonzalez wrote: > Once probe uses only devm functions, remove() becomes unnecessary. Breves vibrantesque sententiae With the hope of getting an expanded commit message: Reviewed-by: Dmitry Baryshkov > > Signed-off-by: Marc

Re: [PATCH RESEND] drm/display: Drop obsolete dependency on COMPILE_TEST

2024-06-17 Thread Dmitry Baryshkov
On Mon, Jun 17, 2024 at 08:18:14PM GMT, Jean Delvare wrote: > On Mon, 17 Jun 2024 14:55:22 +0300, Dmitry Baryshkov wrote: > > On Mon, Jun 17, 2024 at 01:23:48PM GMT, Jean Delvare wrote: > > > Hi Dmitry, > > > > > > Thanks for your feedback. > > > >

Re: [PATCH 2/4] drm: bridge: simple-bridge: use dev pointer in probe

2024-06-17 Thread Dmitry Baryshkov
On Mon, Jun 17, 2024 at 06:03:00PM GMT, Marc Gonzalez wrote: > Prepare to factorize probe function. what and why? The patch itself LGTM > > Signed-off-by: Marc Gonzalez > --- > drivers/gpu/drm/bridge/simple-bridge.c | 19 ++- > 1 file changed, 10 insertions(+), 9 deletions(-)

Re: Correct sequencing of usage of DRM writeback connector

2024-06-17 Thread Dmitry Baryshkov
On Mon, Jun 17, 2024 at 11:28:35AM GMT, Abhinav Kumar wrote: > Hi > > On 6/17/2024 9:54 AM, Brian Starkey wrote: > > Hi, > > > > On Mon, Jun 17, 2024 at 05:16:36PM +0200, Daniel Vetter wrote: > > > On Mon, Jun 17, 2024 at 01:41:59PM +, Hoosier, Matt wrote: > > > > Hi, > > > > > > > > There i

Re: Correct sequencing of usage of DRM writeback connector

2024-06-17 Thread Dmitry Baryshkov
On Mon, Jun 17, 2024 at 05:36:34PM GMT, Hoosier, Matt wrote: > >> >> >> There is a discussion ongoing over in the compositor world about the > >> >> >> implication > >> Hi, > >> > >> On Mon, Jun 17, 2024 at 05:16:36PM +0200, Daniel Vetter wrote: > >> >On Mon, Jun 17, 2024 at 01:41:59PM +, Hoo

Re: [PATCH 1/4] dt-bindings: display: simple-bridge: add ti,tdp158

2024-06-17 Thread Dmitry Baryshkov
On Mon, Jun 17, 2024 at 06:02:59PM GMT, Marc Gonzalez wrote: > In default mode, this device works transparently. > > Signed-off-by: Marc Gonzalez > --- > Documentation/devicetree/bindings/display/bridge/simple-bridge.yaml | 4 > 1 file changed, 4 insertions(+) > > diff --git > a/Documenta

Re: [PATCH v3 02/10] drm/bridge: cdns-dsi: Fix the phy_initialized variable

2024-06-17 Thread Dmitry Baryshkov
On Mon, 17 Jun 2024 at 17:16, Aradhya Bhatia wrote: > > Hi Dmitry, > > Thanks for reviewing the patches! > > On 17/06/24 17:29, Dmitry Baryshkov wrote: > > On Mon, Jun 17, 2024 at 04:23:03PM GMT, Aradhya Bhatia wrote: > >> Update the Phy initialized state to

Re: [PATCH v3 06/10] drm/bridge: cdns-dsi: Reset the DCS write FIFO

2024-06-17 Thread Dmitry Baryshkov
On Mon, Jun 17, 2024 at 04:23:07PM GMT, Aradhya Bhatia wrote: > Allow the DCS Write FIFO in the cdns-dsi controller to reset before any > DCS packet is transmitted to the DSI sink device. > > The DCS FIFO reset is optional. Not all panels require it. But at > least one of the DSI based panel that

Re: [PATCH v3 07/10] drm/mipi-dsi: Add helper to find input format

2024-06-17 Thread Dmitry Baryshkov
rm_mipi_dsi.c | 37 ++ > include/drm/drm_mipi_dsi.h | 1 + > 2 files changed, 38 insertions(+) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v3 02/10] drm/bridge: cdns-dsi: Fix the phy_initialized variable

2024-06-17 Thread Dmitry Baryshkov
On Mon, Jun 17, 2024 at 04:23:03PM GMT, Aradhya Bhatia wrote: > Update the Phy initialized state to "not initialized" when the driver > (and the hardware by extension) gets suspended. This will allow the Phy > to get initialized again after resume. > > Fixes: e19233955d9e ("drm/bridge: Add Cadence

Re: [PATCH v3 01/10] drm/bridge: cdns-dsi: Fix OF node pointer

2024-06-17 Thread Dmitry Baryshkov
t;) > Signed-off-by: Aradhya Bhatia > --- > drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Dmitry Baryshkov Nit: consider switching to devm_drm_of_get_bridge(), which does the same. -- With best wishes Dmitry

Re: [PATCH RESEND] drm/display: Drop obsolete dependency on COMPILE_TEST

2024-06-17 Thread Dmitry Baryshkov
On Mon, Jun 17, 2024 at 01:23:48PM GMT, Jean Delvare wrote: > Hi Dmitry, > > Thanks for your feedback. > > On Mon, 17 Jun 2024 12:57:19 +0300, Dmitry Baryshkov wrote: > > On Mon, Jun 17, 2024 at 10:30:30AM GMT, Jean Delvare wrote: > > > Since commit 0166dc11

Re: [PATCH RESEND] drm/logicvc: Drop obsolete dependency on COMPILE_TEST

2024-06-17 Thread Dmitry Baryshkov
On Mon, Jun 17, 2024 at 10:33:36AM GMT, Jean Delvare wrote: > Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it > is possible to test-build any driver which depends on OF on any > architecture by explicitly selecting OF. Therefore depending on > COMPILE_TEST as an alternative is

Re: [PATCH RESEND] drm/display: Drop obsolete dependency on COMPILE_TEST

2024-06-17 Thread Dmitry Baryshkov
On Mon, Jun 17, 2024 at 10:30:30AM GMT, Jean Delvare wrote: > Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it > is possible to test-build any driver which depends on OF on any > architecture by explicitly selecting OF. Therefore depending on > COMPILE_TEST as an alternative is

Re: [PATCH v2 0/2] drm/bridge: tc358767: Fix DRM_BRIDGE_ATTACH_NO_CONNECTOR case

2024-06-17 Thread Dmitry Baryshkov
On Mon, Jun 17, 2024 at 07:40:32AM GMT, Jan Kiszka wrote: > On 16.02.24 15:57, Marek Vasut wrote: > > On 2/16/24 10:10, Tomi Valkeinen wrote: > >> Ok. Does anyone have a worry that these patches make the situation > >> worse for the DSI case than it was before? Afaics, if the DSI lanes > >> are not

Re: [PATCH v2 1/2] drm/bridge: tc358767: Add format negotiation hooks for DPI/DSI to (e)DP

2024-06-17 Thread Dmitry Baryshkov
On Wed, Nov 08, 2023 at 01:27:22PM GMT, Tomi Valkeinen wrote: > From: Aradhya Bhatia > > With new connector model, tc358767 will not create the connector, when > DRM_BRIDGE_ATTACH_NO_CONNECTOR is set and display-controller driver will > rely on format negotiation to setup the encoder format. > >

[PATCH RFC 5/5] drm/bridge: lt9611: switch to using the DRM HDMI codec framework

2024-06-15 Thread Dmitry Baryshkov
Make the Lontium LT9611 DSI-to-HDMI bridge driver use the DRM HDMI Codec framework. This enables programming of Audio InfoFrames using the HDMI Connector interface and also enables support for the missing features, including the ELD retrieval and better hotplug support. Signed-off-by: Dmitry

[PATCH RFC 3/5] drm/connector: implement generic HDMI codec helpers

2024-06-15 Thread Dmitry Baryshkov
dling. The framework is integrated with the DRM HDMI Connector framework, but can be used by DisplayPort drivers. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/drm_connector.c| 8 ++ drivers/gpu/drm/drm_connector_hdmi_codec.c

[PATCH RFC 2/5] ASoC: hdmi-codec: pass data to get_dai_id too

2024-06-15 Thread Dmitry Baryshkov
The upcoming DRM connector HDMI codec implementation is going to use codec-specific data in the .get_dai_id to get drm_connector. Pass data to the callback, as it is done with other hdmi_codec_ops callbacks. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/adv7511/adv7511_audio.c

[PATCH RFC 4/5] drm/bridge: connector: add support for HDMI codec framework

2024-06-15 Thread Dmitry Baryshkov
integrated with the DRM HDMI Connector framework, but can also be used for DisplayPort connectors. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/drm_bridge_connector.c | 130 - include/drm/drm_bridge.h | 46 2 files changed, 174

[PATCH RFC 1/5] drm/bridge: lt9611: use HDMI Connector helper to set InfoFrames

2024-06-15 Thread Dmitry Baryshkov
additional drm_bridge interface changes. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/Kconfig | 2 + drivers/gpu/drm/bridge/lontium-lt9611.c | 173 ++-- 2 files changed, 120 insertions(+), 55 deletions(-) diff --git a/drivers/gpu/drm/bridge/Kconfig

[PATCH RFC 0/5] drm: add DRM HDMI Codec framework

2024-06-15 Thread Dmitry Baryshkov
er the bridge can be removed, while the DRM device is still lingering on its path to destruction. This series is in the RFC stage, so some bits are underdocumented. Signed-off-by: Dmitry Baryshkov --- Dmitry Baryshkov (5): drm/bridge: lt9611: use HDMI Connector helper to set InfoFrames

Re: [PATCH v6 0/8] drm: Support per-plane async flip configuration

2024-06-14 Thread Dmitry Baryshkov
On Fri, Jun 14, 2024 at 12:35:27PM GMT, André Almeida wrote: > AMD hardware can do async flips with overlay planes, but currently there's no > easy way to enable that in DRM. To solve that, this patchset creates a new > drm_plane field, bool async_flip, that allows drivers to choose which plane >

Re: [PATCH v6 2/8] drm: Support per-plane async flip configuration

2024-06-14 Thread Dmitry Baryshkov
On Fri, Jun 14, 2024 at 12:35:29PM GMT, André Almeida wrote: > Drivers have different capabilities on what plane types they can or > cannot perform async flips. Create a plane::async_flip field so each > driver can choose which planes they allow doing async flips. > > Signed-off-by: André Almeida

Re: [PATCH v3 2/2] drm/panel: starry-er88577: add new panel driver

2024-06-14 Thread Dmitry Baryshkov
On Fri, Jun 14, 2024 at 10:56:09PM GMT, Zhaoxiong Lv wrote: > The bias IC of this starry-er88577 panel is placed > on the panel side, so when the panel is powered on, > there is no need to control AVDD and AVEE in the driver, > only 3.3v and reset are needed. > > Signed-off-by: Zhaoxiong Lv > >

Re: [PATCH v3 3/4] drm/panel: jd9365da: Support for kd101ne3-40ti MIPI-DSI panel.

2024-06-14 Thread Dmitry Baryshkov
On Fri, Jun 14, 2024 at 10:55:09PM GMT, Zhaoxiong Lv wrote: > The K&d kd101ne3-40ti is a 10.1" WXGA TFT-LCD panel, use > jd9365da controller,which fits in nicely with the existing > panel-jadard-jd9365da-h3 driver.Hence,we add a new compatible > with panel specific config. > > Although they have t

Re: [PATCH v3 2/4] dt-bindings: display: panel: Add compatible for kingdisplay-kd101ne3

2024-06-14 Thread Dmitry Baryshkov
On Fri, Jun 14, 2024 at 10:55:08PM GMT, Zhaoxiong Lv wrote: > The kingdisplay-kd101ne3 is a 10.1" WXGA TFT-LCD panel with > jadard-jd9365da controller. Hence, we add a new compatible > with panel specific config. > > Signed-off-by: Zhaoxiong Lv > --- > Chage since V3: > > - 1. Abandon the V2 pat

Re: [PATCH v4 0/3] drm/panel-edp: remove several legacy compatibles used by the driver

2024-06-14 Thread Dmitry Baryshkov
On Fri, 14 Jun 2024 03:02:19 +0300, Dmitry Baryshkov wrote: > There are two ways to describe an eDP panel in device tree. The > recommended way is to add a device on the AUX bus, ideally using the > edp-panel compatible. The legacy way is to define a top-level platform > device f

Re: [PATCH v3 1/4] drm/panel: jd9365da: Modify the method of sending commands

2024-06-14 Thread Dmitry Baryshkov
On Fri, Jun 14, 2024 at 10:55:07PM GMT, Zhaoxiong Lv wrote: > Currently, the init_code of the jd9365da driver is placed > in the enable() function and sent, but this seems to take > a long time. It takes 17ms to send each instruction (an init > code consists of about 200 instructions), so it takes

Re: [PATCH v3 5/9] drm/msm/dpu: move dpu_format_populate_plane_sizes to atomic_check

2024-06-14 Thread Dmitry Baryshkov
On Thu, Jun 13, 2024 at 04:19:07PM GMT, Abhinav Kumar wrote: > > > On 6/13/2024 3:36 PM, Dmitry Baryshkov wrote: > > Move a call to dpu_format_populate_plane_sizes() to the atomic_check > > step, so that any issues with the FB layout can be reported as early as > > po

Re: [PATCH v4 4/4] arm64: dts: qcom: add HDMI nodes for msm8998

2024-06-14 Thread Dmitry Baryshkov
On Fri, Jun 14, 2024 at 01:55:46AM GMT, Konrad Dybcio wrote: > > > On 6/13/24 17:15, Marc Gonzalez wrote: > > From: Arnaud Vrac > > > > Port device nodes from vendor code. > > > > Signed-off-by: Arnaud Vrac > > Reviewed-by: Dmitr

[PATCH v4 3/3] drm/panel-edp: drop several legacy panels

2024-06-13 Thread Dmitry Baryshkov
he AUX bus. Reviewed-by: Douglas Anderson Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/panel/panel-edp.c | 173 ++ 1 file changed, 7 insertions(+), 166 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-e

[PATCH v4 1/3] drm/panel-edp: add fat warning against adding new panel compatibles

2024-06-13 Thread Dmitry Baryshkov
tained for backwards compatibility. Suggested-by: Doug Anderson Reviewed-by: Neil Armstrong Reviewed-by: Douglas Anderson Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/panel/panel-edp.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/p

[PATCH v4 2/3] dt-bindings: display: panel-edp-legacy: drop several eDP panels

2024-06-13 Thread Dmitry Baryshkov
he AUX bus. Reviewed-by: Douglas Anderson Signed-off-by: Dmitry Baryshkov --- .../devicetree/bindings/display/panel/panel-edp-legacy.yaml| 10 -- 1 file changed, 10 deletions(-) diff --git a/Documentation/devicetree/bindings/display/panel/panel-edp-legacy.yaml b/Documentation/devicetre

[PATCH v4 0/3] drm/panel-edp: remove several legacy compatibles used by the driver

2024-06-13 Thread Dmitry Baryshkov
rg Cc: linux-rockc...@lists.infradead.org Cc: Jeffrey Hugo Cc: devicet...@vger.kernel.org Signed-off-by: Dmitry Baryshkov Changes in v4: - Rebased on top of drm-misc-next - Added devicetree maintainers to cc list, missed them for v2/v3 - Link to v3: https://lore.kernel.org/r/20240531-edp-panel-drop

[PATCH v3 6/9] drm/msm/dpu: check for the plane pitch overflow

2024-06-13 Thread Dmitry Baryshkov
Check that the plane pitch doesn't overflow the maximum pitch size allowed by the hardware. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 2 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 6 +- 2 files changed, 7 inser

[PATCH v3 7/9] drm/msm/dpu: drop _dpu_crtc_check_and_setup_lm_bounds from atomic_begin

2024-06-13 Thread Dmitry Baryshkov
The dpu_crtc_atomic_check() already calls the function _dpu_crtc_check_and_setup_lm_bounds(). There is no need to call it again from dpu_crtc_atomic_begin(). Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a

[PATCH v3 9/9] drm/msm/dpu: sync mode_config limits to the FB limits in dpu_plane.c

2024-06-13 Thread Dmitry Baryshkov
Lift mode_config limits set by the DPU driver to the actual FB limits as handled by the dpu_plane.c. Move 2*max_lm_width check where it belongs, to the drm_crtc_helper_funcs::mode_valid() callback. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 15

[PATCH v3 3/9] drm/msm/dpu: drop dpu_format_populate_layout from dpu_plane_sspp_atomic_update

2024-06-13 Thread Dmitry Baryshkov
The dpu_plane_prepare_fb() already calls dpu_format_populate_layout(). Store the generated layout in the plane state and drop this call from dpu_plane_sspp_update(). Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 19

[PATCH v3 5/9] drm/msm/dpu: move dpu_format_populate_plane_sizes to atomic_check

2024-06-13 Thread Dmitry Baryshkov
Move a call to dpu_format_populate_plane_sizes() to the atomic_check step, so that any issues with the FB layout can be reported as early as possible. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions

[PATCH v3 8/9] drm/msm/dpu: merge MAX_IMG_WIDTH/HEIGHT with DPU_MAX_IMG_WIDTH/HEIGHT

2024-06-13 Thread Dmitry Baryshkov
dpu_formats.c defines DPU_MAX_IMG_WIDTH and _HEIGHT, while dpu_hw_catalog.h defines just MAX_IMG_WIDTH and _HEIGHT. Merge these constants to remove duplication. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c| 3 --- drivers/gpu

[PATCH v3 4/9] drm/msm/dpu: split dpu_format_populate_layout

2024-06-13 Thread Dmitry Baryshkov
Split dpu_format_populate_layout() into addess-related and pitch/format-related parts. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c| 8 +++- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c| 45

[PATCH v3 0/9] drm/msm/dpu: be more friendly to X.org

2024-06-13 Thread Dmitry Baryshkov
-off-by: Dmitry Baryshkov --- Changes in v3: - Reoder the functions to pull up a fix to the start of the patchset (Abhinav) - Rename the _dpu_crtc_setup_lm_bounds() to _dpu_crtc_check_and_setup_lm_bounds() (Abhinav) - Make dpu_crtc_mode_valid() static. - Link to v2: https://lore.kernel.org/r

[PATCH v3 2/9] drm/msm/dpu: drop dpu_format_check_modified_format

2024-06-13 Thread Dmitry Baryshkov
The msm_kms_funcs::check_modified_format() callback is not used by the driver. Drop it completely. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 43 - drivers/gpu/drm/msm/disp/dpu1/dpu_formats.h | 16 --- drivers/gpu/drm

[PATCH v3 1/9] drm/msm/dpu: check for overflow in _dpu_crtc_setup_lm_bounds()

2024-06-13 Thread Dmitry Baryshkov
Make _dpu_crtc_setup_lm_bounds() check that CRTC width is not overflowing LM requirements. Rename the function accordingly. Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 17 + 1 fi

Re: [PATCH v2 2/8] drm/msm/dpu: convert vsync source defines to the enum

2024-06-13 Thread Dmitry Baryshkov
On Thu, 13 Jun 2024 at 21:17, Marijn Suijten wrote: > > On 2024-06-13 20:05:05, Dmitry Baryshkov wrote: > > Add enum dpu_vsync_source instead of a series of defines. Use this enum > > to pass vsync information. > > > > Reviewed-by: Abhinav Kumar >

Re: [PATCH v2 1/8] dt-bindings: display/msm/dsi: allow specifying TE source

2024-06-13 Thread Dmitry Baryshkov
On Thu, 13 Jun 2024 at 21:16, Marijn Suijten wrote: > > On 2024-06-13 20:05:04, Dmitry Baryshkov wrote: > > Command mode panels provide TE signal back to the DSI host to signal > > that the frame display has completed and update of the image will not > > cause tearing. Us

Re: [PATCH] drm/ci: mark kms_addfb_basic@addfb25-bad-modifier as passing on msm

2024-06-13 Thread Dmitry Baryshkov
On Thu, 13 Jun 2024 at 20:49, Abhinav Kumar wrote: > > > > On 6/13/2024 9:33 AM, Dmitry Baryshkov wrote: > > The commit b228501ff183 ("drm/msm: merge dpu format database to MDP > > formats") made get_format take modifiers into account. This makes > > kms_

[PATCH v2 2/8] drm/msm/dpu: convert vsync source defines to the enum

2024-06-13 Thread Dmitry Baryshkov
Add enum dpu_vsync_source instead of a series of defines. Use this enum to pass vsync information. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 2 +- drivers/gpu/drm/msm/disp

[PATCH v2 3/8] drm/msm/dsi: drop unused GPIOs handling

2024-06-13 Thread Dmitry Baryshkov
Neither disp-enable-gpios nor disp-te-gpios are defined in the schema. None of the board DT files use those GPIO pins. Drop them from the driver. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/dsi_host.c | 37 - 1 file

[PATCH v2 8/8] drm/msm/dpu: rename dpu_hw_setup_vsync_source functions

2024-06-13 Thread Dmitry Baryshkov
Rename dpu_hw_setup_vsync_source functions to make the names match the implementation: on DPU 5.x the TOP only contains timer setup, while 3.x and 4.x used MDP_VSYNC_SEL register to select TE source. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.c | 14

[PATCH v2 1/8] dt-bindings: display/msm/dsi: allow specifying TE source

2024-06-13 Thread Dmitry Baryshkov
: Krzysztof Kozlowski Reviewed-by: Rob Herring (Arm) Signed-off-by: Dmitry Baryshkov --- .../bindings/display/msm/dsi-controller-main.yaml | 17 + 1 file changed, 17 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b

[PATCH v2 0/8] drm/msm/dpu: handle non-default TE source pins

2024-06-13 Thread Dmitry Baryshkov
and DPU drivers. Signed-off-by: Dmitry Baryshkov --- Changes in v2: - In DT bindings renamed mdp_gpioN to mdp_vsync_p/_s/_e per pins name (Abhinav) - Extended bindings to include default: mdp_vsync_p (Rob) - Renamed dpu_hw_setup_vsync_source() and dpu_hw_setup_vsync_source_and_vsync_sel() to

[PATCH v2 7/8] drm/msm/dpu: support setting the TE source

2024-06-13 Thread Dmitry Baryshkov
Make the DPU driver use the TE source specified in the DT. If none is specified, the driver defaults to the first GPIO (mdp_vsync0). Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 44 - 1 file changed, 43 insertions(+), 1 deletion

[PATCH v2 4/8] drm/msm/dpu: pull the is_cmd_mode out of _dpu_encoder_update_vsync_source()

2024-06-13 Thread Dmitry Baryshkov
Setting vsync source makes sense only for DSI CMD panels. Pull the is_cmd_mode condition out of the function into the calling code, so that it becomes more explicit. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 6 +++--- 1 file

[PATCH v2 6/8] drm/msm/dsi: parse vsync source from device tree

2024-06-13 Thread Dmitry Baryshkov
Allow board's device tree to specify the vsync source (aka TE source). If the property is omitted, the display controller driver will use the default setting. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/dsi.h | 1 + drivers/gpu/drm/ms

[PATCH v2 5/8] drm/msm/dpu: rework vsync_source handling

2024-06-13 Thread Dmitry Baryshkov
The struct msm_display_info has is_te_using_watchdog_timer field which is neither used anywhere nor is flexible enough to specify different sources. Replace it with the field specifying the vsync source using enum dpu_vsync_source. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov

[PATCH] drm/ci: mark kms_addfb_basic@addfb25-bad-modifier as passing on msm

2024-06-13 Thread Dmitry Baryshkov
The commit b228501ff183 ("drm/msm: merge dpu format database to MDP formats") made get_format take modifiers into account. This makes kms_addfb_basic@addfb25-bad-modifier pass on MDP4 and MDP5 platforms. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/ci/xfails/msm-apq8016-fai

Re: [PATCH v5 2/3] drm/bridge: sii902x: Support atomic bridge APIs

2024-06-13 Thread Dmitry Baryshkov
> 1 file changed, 6 insertions(+), 4 deletions(-) > Suggested-by: Sam Ravnborg Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v4 10/13] drm/msm/dpu: allow sharing SSPP between planes

2024-06-13 Thread Dmitry Baryshkov
On Wed, Jun 12, 2024 at 06:17:37PM -0700, Abhinav Kumar wrote: > > > On 6/12/2024 2:08 AM, Dmitry Baryshkov wrote: > > On Wed, 12 Jun 2024 at 02:12, Abhinav Kumar > > wrote: > > > > > > > > > > > > On 3/13/2024 5:02 PM, Dmitry B

Re: [PATCH v3 2/4] dt-bindings: display/msm: hdmi: add qcom,hdmi-tx-8998

2024-06-13 Thread Dmitry Baryshkov
On Thu, Jun 13, 2024 at 04:02:24AM +0200, Marc Gonzalez wrote: > On 12/06/2024 19:44, Vinod Koul wrote: > > > On 06-06-24, 18:07, Marc Gonzalez wrote: > > > >> HDMI TX block embedded in the APQ8098. > > > > This one too > > I assume this refers to: > "Why is the patch titled display/msm, this is

[PATCH RFC v2] drm/msm/dpu: Configure DP INTF/PHY selector

2024-06-13 Thread Dmitry Baryshkov
case arrise. Note that e.g. msm-4.14 unconditionally maps INTF 0 to PHY 0 on all rlatforms, so perhaps this is needed in order to get DisplayPort working on some other platforms as well. Signed-off-by: Bjorn Andersson Co-developed-by: Bjorn Andersson Signed-off-by: Dmitry Baryshkov --- Changes

Re: [PATCH v2] drm/bridge: simple-bridge: Add support for TI TDP158

2024-06-13 Thread Dmitry Baryshkov
On Thu, Jun 13, 2024 at 12:29:26PM +0200, Marc Gonzalez wrote: > On 13/06/2024 12:26, Dmitry Baryshkov wrote: > > > On Thu, Jun 13, 2024 at 04:12:22AM +0200, Marc Gonzalez wrote: > > > >> On 28/05/2024 03:13, Dmitry Baryshkov wrote: > >> > >>> Bi

Re: [PATCH v5 3/3] drm/bridge: sii902x: Add pixel clock check in atomic_check

2024-06-13 Thread Dmitry Baryshkov
t; 1 file changed, 4 insertions(+) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v2] drm/bridge: simple-bridge: Add support for TI TDP158

2024-06-13 Thread Dmitry Baryshkov
On Thu, Jun 13, 2024 at 04:12:22AM +0200, Marc Gonzalez wrote: > On 28/05/2024 03:13, Dmitry Baryshkov wrote: > > > Bindings please. Also, note that per the datasheet the bridge uses two > > supplies, Vcc for 3.3V and Vdd for 1.1V, so it doesn't fully fit the > > simp

Re: [PATCH v2] drm/bridge: simple-bridge: Add support for TI TDP158

2024-06-13 Thread Dmitry Baryshkov
On Thu, Jun 13, 2024 at 04:12:22AM +0200, Marc Gonzalez wrote: > On 28/05/2024 03:13, Dmitry Baryshkov wrote: > > > Bindings please. Also, note that per the datasheet the bridge uses two > > supplies, Vcc for 3.3V and Vdd for 1.1V, so it doesn't fully fit the > > simp

Re: [PATCH v2 3/4] dt-bindings: display/msm: Add SM7150 DPU

2024-06-13 Thread Dmitry Baryshkov
On Thu, Jun 13, 2024 at 11:23:50AM +0200, Krzysztof Kozlowski wrote: > On 12/06/2024 20:43, Danila Tikhonov wrote: > > Document the DPU hardware found on the Qualcomm SM7150 platform. > > In general, this should be before MDSS, because it defines fully the > compatibles already used in the MDSS sc

Re: [PATCH v5 2/3] drm: Allow drivers to choose plane types to async flip

2024-06-12 Thread Dmitry Baryshkov
On Wed, Jun 12, 2024 at 04:37:12PM -0300, André Almeida wrote: > Different planes may have different capabilities of doing async flips, > so create a field to let drivers allow async flip per plane type. > > Signed-off-by: André Almeida > --- > drivers/gpu/drm/drm_atomic_uapi.c | 4 ++-- > drive

Re: [PATCH v2 4/4] drm/msm/dpu: Add SM7150 support

2024-06-12 Thread Dmitry Baryshkov
On Wed, Jun 12, 2024 at 09:43:36PM +0300, Danila Tikhonov wrote: > Add definitions for the display hardware used on the Qualcomm SM7150 > platform. > > Signed-off-by: Danila Tikhonov > --- > .../msm/disp/dpu1/catalog/dpu_5_2_sm7150.h| 349 ++ > .../gpu/drm/msm/disp/dpu1/dpu_h

Re: [PATCH v2 2/4] drm/msm: mdss: Add SM7150 support

2024-06-12 Thread Dmitry Baryshkov
On Wed, Jun 12, 2024 at 09:43:34PM +0300, Danila Tikhonov wrote: > Add support for MDSS on SM7150. > > Signed-off-by: Danila Tikhonov > --- > drivers/gpu/drm/msm/msm_mdss.c | 8 > 1 file changed, 8 insertions(+) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v3] drm/panel: truly-nt35521: transition to mipi_dsi wrapped functions

2024-06-12 Thread Dmitry Baryshkov
t; v1: > https://lore.kernel.org/all/485eef24-ddad-466a-a89f-f9f226801...@gmail.com/ > > v2: > https://lore.kernel.org/all/3288287d-8344-4b37-a333-722cf12fe...@gmail.com/ > --- > .../panel/panel-sony-tulip-truly-nt35521.c| 433 +++++- > 1 file changed, 207 insertions(+), 226 deletions(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH 3/3] drm/todo: Add TODO entry for "lints"

2024-06-12 Thread Dmitry Baryshkov
On Wed, Jun 12, 2024 at 04:35:53PM +0200, Maxime Ripard wrote: > Having lints would prove beneficial to prevent the same dark patterns > from reoccuring over and over again in drivers. > > Add a TODO entry for that. > > Signed-off-by: Maxime Ripard > --- > Documentation/gpu/todo.rst | 28 ++

<    1   2   3   4   5   6   7   8   9   10   >