Re: [PATCH RFC] drm/panel-edp: add fat warning against adding new panel compatibles

2024-05-23 Thread Doug Anderson
mpatibles > are either used by the existing DT or were used previously and are > retained for backwards compatibility. > > Suggested-by: Doug Anderson > Signed-off-by: Dmitry Baryshkov > --- > The following compatibles were never used by the devices supported by > the

Re: [PATCH] drm/panel-edp: Add CMN N116BCJ-EAK

2024-05-22 Thread Doug Anderson
Hi, On Wed, May 22, 2024 at 4:39 AM Haikun Zhou wrote: > > Add support for the CMN N116BCJ-EAK, place the raw EDID here for > subsequent reference. > 00 ff ff ff ff ff ff 00 0d ae 60 11 00 00 00 00 > 04 22 01 04 95 1a 0e 78 02 67 75 98 59 53 90 27 > 1c 50 54 00 00 00 01 01 01 01 01 01 01 01 01

Re: [PATCH] drm/msm: remove python 3.9 dependency for compiling msm

2024-05-20 Thread Doug Anderson
Hi, On Tue, May 7, 2024 at 4:05 PM Abhinav Kumar wrote: > > Since commit 5acf49119630 ("drm/msm: import gen_header.py script from Mesa"), > compilation is broken on machines having python versions older than 3.9 > due to dependency on argparse.BooleanOptionalAction. > > Switch to use simple bool

Re: [PATCH 08/11] drm/msm/dp: switch to struct drm_edid

2024-05-20 Thread Doug Anderson
Hi, On Sun, May 19, 2024 at 2:01 AM Dmitry Baryshkov wrote: > > On Tue, May 14, 2024 at 03:55:14PM +0300, Jani Nikula wrote: > > Prefer the struct drm_edid based functions for reading the EDID and > > updating the connector. > > > > Simplify the flow by updating the EDID property when the EDID

Re: [v7 3/7] arm64: defconfig: Enable HIMAX_HX83102 panel

2024-05-16 Thread Doug Anderson
Hi, On Thu, May 16, 2024 at 6:43 AM Doug Anderson wrote: > > Hi, > > On Wed, May 15, 2024 at 11:55 PM wrote: > > > > On 16/05/2024 08:43, cong yang wrote: > > > Hi: > > > > > > If it is determined that a separately patch needs to be sen

Re: [v7 3/7] arm64: defconfig: Enable HIMAX_HX83102 panel

2024-05-16 Thread Doug Anderson
Hi, On Wed, May 15, 2024 at 11:55 PM wrote: > > On 16/05/2024 08:43, cong yang wrote: > > Hi: > > > > If it is determined that a separately patch needs to be sent, then I > > will remove this patch in V8 series? > > > > Doug Anderson 于2024年5月16日周四 0

Re: [PATCH v8 0/6] Break out as separate driver and add BOE nv110wum-l60 IVO t109nw41 MIPI-DSI panel

2024-05-16 Thread Doug Anderson
Hi, On Thu, May 16, 2024 at 12:21 AM Cong Yang wrote: > > Discussion with Doug and Linus in V1, we need a > separate driver to enable the hx83102 controller. > > So this series this series mainly Break out as separate driver > for Starry-himax83102-j02 panels from boe tv101wum driver. > > Then

Re: [v7 3/7] arm64: defconfig: Enable HIMAX_HX83102 panel

2024-05-15 Thread Doug Anderson
Hi, On Wed, May 15, 2024 at 2:16 PM wrote: > > Hi, > > On 15/05/2024 03:46, Cong Yang wrote: > > DRM_PANEL_HIMAX_HX83102 is being split out from DRM_PANEL_BOE_TV101WUM_NL6. > > Since the arm64 defconfig had the BOE panel driver enabled, let's also > > enable the himax driver. > > > >

Re: [v7 2/7] drm/panel: himax-hx83102: Break out as separate driver

2024-05-15 Thread Doug Anderson
Hi, On Tue, May 14, 2024 at 6:47 PM Cong Yang wrote: > > +static int hx83102_prepare(struct drm_panel *panel) > +{ > + struct hx83102 *ctx = panel_to_hx83102(panel); > + struct mipi_dsi_device *dsi = ctx->dsi; > + struct device *dev = >dev; > + int ret; > + > +

Re: [PATCH v2 2/7] drm/mipi-dsi: wrap more functions for streamline handling

2024-05-13 Thread Doug Anderson
Hi, On Sat, May 11, 2024 at 4:00 PM Dmitry Baryshkov wrote: > > Follow the pattern of mipi_dsi_dcs_*_multi() and wrap several existing > MIPI DSI functions to use the context for processing. This simplifies > and streamlines driver code to use simpler code pattern. > > Note, msleep function is

Re: [PATCH v6 5/7] drm/panel: himax-hx83102: Support for BOE nv110wum-l60 MIPI-DSI panel

2024-05-13 Thread Doug Anderson
Hi, On Fri, May 10, 2024 at 7:13 PM Cong Yang wrote: > > The BOE nv110wum-l60 is a 11.0" WUXGA TFT LCD panel, use hx83102 controller > which fits in nicely with the existing panel-himax-hx83102 driver. Hence, > we add a new compatible with panel specific config. > > Signed-off-by: Cong Yang >

Re: [PATCH v6 7/7] drm/panel: himax-hx83102: Support for IVO t109nw41 MIPI-DSI panel

2024-05-13 Thread Doug Anderson
Hi, On Fri, May 10, 2024 at 7:14 PM Cong Yang wrote: > > The IVO t109nw41 is a 11.0" WUXGA TFT LCD panel, use hx83102 controller > which fits in nicely with the existing panel-himax-hx83102 driver. Hence, > we add a new compatible with panel specific config. > > Signed-off-by: Cong Yang > --- >

Re: [PATCH v6 2/7] drm/panel: himax-hx83102: Break out as separate driver

2024-05-13 Thread Doug Anderson
Hi, On Fri, May 10, 2024 at 7:13 PM Cong Yang wrote: > > +static int hx83102_prepare(struct drm_panel *panel) > +{ > + struct hx83102 *ctx = panel_to_hx83102(panel); > + struct mipi_dsi_device *dsi = ctx->dsi; > + struct device *dev = >dev; > + int ret; > + > +

Re: [PATCH v4 4/9] drm/mipi-dsi: Reduce driver bloat of mipi_dsi_*_write_seq()

2024-05-13 Thread Doug Anderson
Hi, On Mon, May 13, 2024 at 2:30 AM Maxime Ripard wrote: > > Hi, > > On Wed, May 08, 2024 at 01:51:46PM -0700, Douglas Anderson wrote: > > Through a cooperative effort between Hsin-Yi Wang and Dmitry > > Baryshkov, we have realized the dev_err() in the > > mipi_dsi_*_write_seq() macros was

Re: [PATCH RFC 6/7] drm/panel: lg-sw43408: add missing error handling

2024-05-10 Thread Doug Anderson
Hi, On Fri, May 10, 2024 at 3:25 PM Dmitry Baryshkov wrote: > > On Fri, May 10, 2024 at 02:47:05PM -0700, Doug Anderson wrote: > > Hi, > > > > On Thu, May 9, 2024 at 3:37 PM Dmitry Baryshkov > > wrote: > > > > > > Add missing error handling for th

Re: [PATCH RFC 7/7] drm/panel: lg-sw43408: use new streamlined MIPI DSI API

2024-05-10 Thread Doug Anderson
Hi, On Thu, May 9, 2024 at 3:37 PM Dmitry Baryshkov wrote: > > Use newer mipi_dsi_*_multi() functions in order to simplify and cleanup > panel's prepare() and unprepare() functions. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/panel/panel-lg-sw43408.c | 95 >

Re: [PATCH RFC 6/7] drm/panel: lg-sw43408: add missing error handling

2024-05-10 Thread Doug Anderson
Hi, On Thu, May 9, 2024 at 3:37 PM Dmitry Baryshkov wrote: > > Add missing error handling for the mipi_dsi_ functions that actually > return error code instead of silently ignoring it. > > Fixes: 069a6c0e94f9 ("drm: panel: Add LG sw43408 panel driver") > Signed-off-by: Dmitry Baryshkov > --- >

Re: [PATCH RFC 5/7] drm/panel: novatek-nt36672e: use wrapped MIPI DCS functions

2024-05-10 Thread Doug Anderson
Hi, On Thu, May 9, 2024 at 3:37 PM Dmitry Baryshkov wrote: > > Remove conditional code and always use mipi_dsi_dcs_*multi() wrappers to > simplify driver's init/exit code. This also includes passing context to > the init_sequence() function instead of passing the DSI device. > > Signed-off-by:

Re: [PATCH RFC 4/7] drm/panel: innolux-p079zca: use mipi_dsi_dcs_nop_multi()

2024-05-10 Thread Doug Anderson
Hi, On Thu, May 9, 2024 at 3:37 PM Dmitry Baryshkov wrote: > > Remove conditional code and use mipi_dsi_dcs_nop_multi() wrapper to > simplify driver code. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/panel/panel-innolux-p079zca.c | 9 + > 1 file changed, 1 insertion(+),

Re: [PATCH RFC 3/7] drm/panel: ilitek-ili9882t: use wrapped MIPI DCS functions

2024-05-10 Thread Doug Anderson
Hi, On Thu, May 9, 2024 at 3:37 PM Dmitry Baryshkov wrote: > > @@ -424,20 +420,14 @@ static inline struct ili9882t *to_ili9882t(struct > drm_panel *panel) > > static int ili9882t_enter_sleep_mode(struct ili9882t *ili) > { > - struct mipi_dsi_device *dsi = ili->dsi; > - int ret; >

Re: [PATCH RFC 2/7] drm/panel: boe-tv101wum-nl6: use wrapped MIPI DCS functions

2024-05-10 Thread Doug Anderson
Hi, On Thu, May 9, 2024 at 3:37 PM Dmitry Baryshkov wrote: > > Remove conditional code and always use mipi_dsi_dcs_*multi() wrappers to > simplify driver's init/exit code. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 73 >

Re: [PATCH RFC 1/7] drm/mipi-dsi: wrap more functions for streamline handling

2024-05-10 Thread Doug Anderson
Hi, On Thu, May 9, 2024 at 3:37 PM Dmitry Baryshkov wrote: > > +/** > + * mipi_dsi_compression_mode_ext() - enable/disable DSC on the peripheral > + * @ctx: Context for multiple DSI transactions > + * @enable: Whether to enable or disable the DSC > + * @algo: Selected compression algorithm > + *

Re: [PATCH v5 7/7] drm/panel: himax-hx83102: Support for IVO t109nw41 MIPI-DSI panel

2024-05-10 Thread Doug Anderson
Hi, On Thu, May 9, 2024 at 11:05 PM cong yang wrote: > > Hi, > > Doug Anderson 于2024年5月10日周五 00:49写道: > > > > Hi, > > > > On Wed, May 8, 2024 at 6:53 PM Cong Yang > > wrote: > > > > > > +static int ivo_t109nw41_init(struct hx8310

Re: [PATCH v5 2/7] drm/panel: himax-hx83102: Break out as separate driver

2024-05-09 Thread Doug Anderson
Hi, On Wed, May 8, 2024 at 6:53 PM Cong Yang wrote: > > +static int hx83102_enable(struct drm_panel *panel) > +{ > + struct hx83102 *ctx = panel_to_hx83102(panel); > + struct mipi_dsi_device *dsi = ctx->dsi; > + struct device *dev = >dev; > + int ret; > + > + ret =

Re: [PATCH v5 7/7] drm/panel: himax-hx83102: Support for IVO t109nw41 MIPI-DSI panel

2024-05-09 Thread Doug Anderson
Hi, On Wed, May 8, 2024 at 6:53 PM Cong Yang wrote: > > +static int ivo_t109nw41_init(struct hx83102 *ctx) > +{ > + struct mipi_dsi_multi_context dsi_ctx = { .dsi = ctx->dsi }; > + > + msleep(60); > + > + hx83102_enable_extended_cmds(_ctx, true); > +

Re: [PATCH v1 2/2] HID: i2c-hid: elan: Add ili2900 timing

2024-05-09 Thread Doug Anderson
Hi, On Wed, May 8, 2024 at 11:43 PM Zhaoxiong Lv wrote: > > From: lvzhaoxiong > > ILI2900 requires reset to pull down time greater than 10ms, > so the configuration post_power_delay_ms is 10, and the chipset > initial time is required to be greater than 100ms, > so the

Re: [PATCH v2 0/2] Add starry bindings and driver

2024-05-09 Thread Doug Anderson
Hi, On Thu, May 9, 2024 at 1:35 AM Zhaoxiong Lv wrote: > > Add bindings and driver for starry. > --- > Modifications between V1 and V2: > Kconfig and Makefile configurations added for starry driver > > --- > > Zhaoxiong Lv (2): > dt-bindings: display: panel: Add Starry-er88577 support >

Re: [PATCH] drm/msm: remove python 3.9 dependency for compiling msm

2024-05-08 Thread Doug Anderson
Hi, On Tue, May 7, 2024 at 4:05 PM Abhinav Kumar wrote: > > Since commit 5acf49119630 ("drm/msm: import gen_header.py script from Mesa"), > compilation is broken on machines having python versions older than 3.9 > due to dependency on argparse.BooleanOptionalAction. > > Switch to use simple bool

Re: [PATCH v2 1/2] drm/msm/gen_header: allow skipping the validation

2024-05-08 Thread Doug Anderson
Hi, On Fri, May 3, 2024 at 11:15 AM Dmitry Baryshkov wrote: > > @@ -941,6 +948,7 @@ def main(): > parser = argparse.ArgumentParser() > parser.add_argument('--rnn', type=str, required=True) > parser.add_argument('--xml', type=str, required=True) > +

Re: [RFT PATCH v2 00/48] drm/panel: Remove most store/double-check of prepared/enabled state

2024-05-08 Thread Doug Anderson
Hi, On Sun, May 5, 2024 at 11:52 PM Linus Walleij wrote: > > On Fri, May 3, 2024 at 11:36 PM Douglas Anderson > wrote: > > > As talked about in commit d2aacaf07395 ("drm/panel: Check for already > > prepared/enabled in drm_panel"), we want to remove needless code from > > panel drivers that

Re: [PATCH v4 2/7] drm/panel: himax-hx83102: Break out as separate driver

2024-05-08 Thread Doug Anderson
Hi, On Wed, May 8, 2024 at 4:52 AM cong yang wrote: > > > > +static int starry_himax83102_j02_init(struct hx83102 *ctx) > > > +{ > > > + struct mipi_dsi_multi_context dsi_ctx = { .dsi = ctx->dsi }; > > > + > > > + hx83102_enable_extended_cmds(ctx, true); > > > +

Re: [PATCH v4 5/7] drm/panel: himax-hx83102: Support for BOE nv110wum-l60 MIPI-DSI panel

2024-05-07 Thread Doug Anderson
Hi, On Tue, May 7, 2024 at 6:53 AM Cong Yang wrote: > > +static int boe_nv110wum_init(struct hx83102 *ctx) > +{ > + struct mipi_dsi_multi_context dsi_ctx = { .dsi = ctx->dsi }; > + > + msleep(60); > + > + hx83102_enable_extended_cmds(ctx, true); > +

Re: [PATCH v4 2/7] drm/panel: himax-hx83102: Break out as separate driver

2024-05-07 Thread Doug Anderson
Hi, On Tue, May 7, 2024 at 6:53 AM Cong Yang wrote: > > +static int hx83102_enable_extended_cmds(struct hx83102 *ctx, bool enable) > +{ > + struct mipi_dsi_multi_context dsi_ctx = { .dsi = ctx->dsi }; > + > + if (enable) > + mipi_dsi_dcs_write_seq_multi(_ctx,

Re: [PATCH v4 1/7] dt-bindings: display: panel: Add himax hx83102 panel bindings

2024-05-07 Thread Doug Anderson
Hi, On Tue, May 7, 2024 at 8:14 AM Rob Herring (Arm) wrote: > > > On Tue, 07 May 2024 21:52:28 +0800, Cong Yang wrote: > > In V1, discussed with Doug and Linus [1], we need break out as separate > > driver for the himax83102-j02 controller. Beacuse "starry,himax83102-j02" > > and in this series

Re: [PATCH v3 2/7] drm/panel: himax-hx83102: Break out as separate driver

2024-05-07 Thread Doug Anderson
Hi, On Tue, May 7, 2024 at 6:44 AM cong yang wrote: > > > Speaking of which, some of the panels that you add to this driver seem > > to disable extended commands at the end of their init sequence, but > > this one doesn't. Should it? > > I have confirmed with himax that disable extended

Re: [PATCH] drm/connector: Add \n to message about demoting connector force-probes

2024-05-07 Thread Doug Anderson
Hi, On Thu, May 2, 2024 at 3:33 PM Douglas Anderson wrote: > > The debug print clearly lacks a \n at the end. Add it. > > Fixes: 8f86c82aba8b ("drm/connector: demote connector force-probes for > non-master clients") > Signed-off-by: Douglas Anderson > --- > > drivers/gpu/drm/drm_connector.c |

Re: [PATCH] drm/panel-edp: Add ID for KD KD116N09-30NH-A016

2024-05-06 Thread Doug Anderson
Hi, On Thu, May 2, 2024 at 4:55 PM Hsin-Yi Wang wrote: > > On Thu, May 2, 2024 at 4:48 PM Douglas Anderson wrote: > > > > As evidenced by in-field reports, this panel shipped on pompom but we > > never added the ID and thus we're stuck w/ conservative timings. The > > panel was part of early

Re: [PATCH] drm/panel-edp: Add panel CSOT MNB601LS1-1

2024-05-06 Thread Doug Anderson
Hi, On Tue, Apr 23, 2024 at 6:55 PM Xuxin Xiong wrote: > > Hi Doug, thank you! > We had reported this info to the CSOT to correct the vendor id. > If they confirm to fix this with the same product ID, we will submit a > patch to fix this. FYI, "top posting" like this is generally frowned upon

Re: [RFT PATCH v2 15/48] drm/panel: ltk050h3146w: Don't call unprepare+disable at shutdown/remove

2024-05-06 Thread Doug Anderson
Hi, On Mon, May 6, 2024 at 7:04 AM Quentin Schulz wrote: > > Hi Douglas, > > On 5/3/24 11:32 PM, Douglas Anderson wrote: > > [You don't often get email from diand...@chromium.org. Learn why this is > > important at https://aka.ms/LearnAboutSenderIdentification ] > > > > It's the responsibility

Re: [PATCH] drm: renesas: shmobile: Call drm_helper_force_disable_all() at shutdown time

2024-05-03 Thread Doug Anderson
Hi, On Tue, Dec 5, 2023 at 9:35 AM Doug Anderson wrote: > > Hi, > > On Tue, Dec 5, 2023 at 5:40 AM Laurent Pinchart > wrote: > > > > On Tue, Dec 05, 2023 at 02:31:24PM +0100, Geert Uytterhoeven wrote: > > > On Tue, Dec 5, 2023 at 1:16 PM Laurent Pinchart

Re: [PATCH 5/6] drm/panel: novatek-nt36672a: stop calling regulator_set_load manually

2024-05-03 Thread Doug Anderson
Hi, On Thu, Apr 4, 2024 at 3:08 AM Dmitry Baryshkov wrote: > > Use .init_load_uA part of the bulk regulator API instead of calling > register_set_load() manually. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/panel/panel-novatek-nt36672a.c | 11 +++ > 1 file changed, 3

Re: [PATCH v3 9/9] drm/panel: innolux-p079zca: Don't use a table for initting panels

2024-05-03 Thread Doug Anderson
Hi, On Wed, May 1, 2024 at 8:43 AM Douglas Anderson wrote: > > @@ -132,33 +125,9 @@ static int innolux_panel_prepare(struct drm_panel *panel) > /* p079zca: t4, p097pfg: t5 */ > usleep_range(2, 21000); > > - if (innolux->desc->init_cmds) { > - const struct

Re: [PATCH v3 4/9] drm/mipi-dsi: Reduce driver bloat of mipi_dsi_*_write_seq()

2024-05-02 Thread Doug Anderson
Hi, On Thu, May 2, 2024 at 1:23 AM Linus Walleij wrote: > > On Wed, May 1, 2024 at 5:43 PM Douglas Anderson wrote: > > > Through a cooperative effort between Hsin-Yi Wang and Dmitry > > Baryshkov, we have realized the dev_err() in the > > mipi_dsi_*_write_seq() macros was causing quite a bit of

Re: [PATCH v3 7/9] drm/panel: boe-tv101wum-nl6: Don't use a table for initting panels

2024-05-02 Thread Doug Anderson
Hi, On Thu, May 2, 2024 at 6:42 AM Linus Walleij wrote: > > On Wed, May 1, 2024 at 5:43 PM Douglas Anderson wrote: > > > Consensus on the mailing lists is that panels shouldn't use a table of > > init commands but should instead use init functions. With the recently > > introduced

Re: [PATCH v3 0/9] drm/mipi-dsi: Reduce bloat and add funcs for cleaner init seqs

2024-05-02 Thread Doug Anderson
Hi, On Thu, May 2, 2024 at 12:48 AM Neil Armstrong wrote: > > Hi, > > On 01/05/2024 17:41, Douglas Anderson wrote: > > The consensus of many DRM folks is that we want to move away from DSI > > drivers defining tables of init commands. Instead, we want to move to > > init functions that can use

Re: [PATCH v2] drm/debugfs: Drop conditionals around of_node pointers

2024-05-01 Thread Doug Anderson
Hi, On Tue, Apr 30, 2024 at 10:13 PM Sui Jingfeng wrote: > > Having conditional around the of_node pointer of the drm_bridge structure > is not necessary anymore, since drm_bridge structure always has the of_node > member since the commit d8dfccde2709 ("drm/bridge: Drop conditionals around >

Re: [PATCH v2 4/8] drm/mipi-dsi: Introduce mipi_dsi_*_write_seq_multi()

2024-05-01 Thread Doug Anderson
Hi, On Mon, Apr 29, 2024 at 8:39 AM Jani Nikula wrote: > > On Mon, 29 Apr 2024, Doug Anderson wrote: > > Hi, > > > > On Mon, Apr 29, 2024 at 2:38 AM Neil Armstrong > > wrote: > >> > >> > +/** > >> > + * struct mipi_dsi_multi_con

Re: Re: drm/debugfs: Drop conditionals around of_node pointers

2024-04-30 Thread Doug Anderson
Hi, On Mon, Apr 29, 2024 at 6:16 PM 隋景峰 wrote: > > Hi, > > > > -原始邮件- > > 发件人: "Maxime Ripard" > > 发送时间: 2024-04-29 19:30:24 (星期一) > > 收件人: "Sui Jingfeng" > > 抄送: "Sui Jingfeng" , "Maarten Lankhorst" > > , "Thomas Zimmermann" > > , "David Airlie" , "Daniel Vetter" > > , "Douglas

Re: [PATCH v3 2/7] drm/panel: himax-hx83102: Break out as separate driver

2024-04-30 Thread Doug Anderson
Hi, On Tue, Apr 23, 2024 at 7:30 PM Cong Yang wrote: > > The Starry HX83102 based mipi panel should never have been part of the boe > tv101wum driver. Discussion with Doug and Linus in V1 [1], we need a > separate driver to enable the hx83102 controller. > > In hx83102 driver, add DSI commands

Re: [PATCH v2 1/8] drm/mipi-dsi: Fix theoretical int overflow in mipi_dsi_dcs_write_seq()

2024-04-29 Thread Doug Anderson
Hi, On Fri, Apr 26, 2024 at 11:22 PM Sam Ravnborg wrote: > > On Sat, Apr 27, 2024 at 04:44:33AM +0300, Dmitry Baryshkov wrote: > > On Sat, 27 Apr 2024 at 02:59, Douglas Anderson > > wrote: > > > > > > The mipi_dsi_dcs_write_seq() macro makes a call to > > > mipi_dsi_dcs_write_buffer() which

Re: [PATCH v2 4/8] drm/mipi-dsi: Introduce mipi_dsi_*_write_seq_multi()

2024-04-29 Thread Doug Anderson
Hi, On Mon, Apr 29, 2024 at 2:38 AM Neil Armstrong wrote: > > > +/** > > + * struct mipi_dsi_multi_context - Context to call multiple MIPI DSI funcs > > in a row > > + * @dsi: Pointer to the MIPI DSI device > > + * @accum_err: Storage for the accumulated error over the multiple calls. > > Init

Re: [PATCH v2 4/8] drm/mipi-dsi: Introduce mipi_dsi_*_write_seq_multi()

2024-04-29 Thread Doug Anderson
Hi, On Fri, Apr 26, 2024 at 11:33 PM Sam Ravnborg wrote: > > > --- > > Right now this patch introduces two new functions in > > drm_mipi_dsi.c. Alternatively we could have changed the prototype of > > the "chatty" functions and made the deprecated macros adapt to the new > > prototype. While

Re: [PATCH] drm/mipi-dsi: Reduce driver bloat of mipi_dsi_*_write_seq()

2024-04-26 Thread Doug Anderson
Hi, On Fri, Apr 26, 2024 at 8:28 AM Doug Anderson wrote: > > > I don't find this unintuitive, but if it helps, you could conceivably > > add a context parameter: > > > > struct mipi_dsi_seq_context context = { >

Re: [PATCH] drm/mipi-dsi: Reduce driver bloat of mipi_dsi_*_write_seq()

2024-04-26 Thread Doug Anderson
Hi, On Thu, Apr 25, 2024 at 8:03 PM Dmitry Baryshkov wrote: > > On Thu, Apr 25, 2024 at 10:04:49AM -0700, Doug Anderson wrote: > > Hi, > > > > On Thu, Apr 25, 2024 at 1:19 AM Jani Nikula > > wrote: > > > > > > > @@ -279,6 +281,8 @@ enu

Re: [PATCH] drm/mipi-dsi: Reduce driver bloat of mipi_dsi_*_write_seq()

2024-04-26 Thread Doug Anderson
Hi, On Fri, Apr 26, 2024 at 3:09 AM Jani Nikula wrote: > > > 2. Accept that a slightly less efficient handling of the error case > > and perhaps a less intuitive API, but avoid the goto. > > > > Essentially you could pass in "ret" and have the function be a no-op > > if an error is already

Re: [PATCH] drm/mipi-dsi: Reduce driver bloat of mipi_dsi_*_write_seq()

2024-04-25 Thread Doug Anderson
Hi, On Thu, Apr 25, 2024 at 1:19 AM Jani Nikula wrote: > > > @@ -279,6 +281,8 @@ enum mipi_dsi_dcs_tear_mode { > > > > ssize_t mipi_dsi_dcs_write_buffer(struct mipi_dsi_device *dsi, > > const void *data, size_t len); > > +ssize_t

Re: [PATCH v1 2/2] drm/panel: kd101ne3: add new panel driver

2024-04-24 Thread Doug Anderson
Hi, On Wed, Apr 24, 2024 at 4:37 PM Dmitry Baryshkov wrote: > > On Thu, 25 Apr 2024 at 02:25, Doug Anderson wrote: > > > > Hi, > > > > On Wed, Apr 24, 2024 at 3:51 PM Dmitry Baryshkov > > wrote: > > > > > > On Thu, 25 Apr 2024 at 01:15, Hsi

Re: [PATCH v1 2/2] drm/panel: kd101ne3: add new panel driver

2024-04-24 Thread Doug Anderson
Hi, On Wed, Apr 24, 2024 at 3:51 PM Dmitry Baryshkov wrote: > > On Thu, 25 Apr 2024 at 01:15, Hsin-Yi Wang wrote: > > > > On Wed, Apr 24, 2024 at 2:49 PM Dmitry Baryshkov > > wrote: > > > > > > On Thu, 25 Apr 2024 at 00:04, Doug Anderson wrote: >

Re: [PATCH v2 2/7] drm/panel: himax-hx83102: Break out as separate driver

2024-04-24 Thread Doug Anderson
Hi, On Tue, Apr 23, 2024 at 7:42 PM cong yang wrote: > > Hi, > Thanks reply. > > Doug Anderson 于2024年4月24日周三 00:26写道: > > > > Hi, > > > > On Tue, Apr 23, 2024 at 2:37 AM cong yang > > wrote: > > > > > > > > +static int starr

Re: [PATCH v1 2/2] drm/panel: kd101ne3: add new panel driver

2024-04-24 Thread Doug Anderson
Hi, On Wed, Apr 24, 2024 at 2:49 PM Dmitry Baryshkov wrote: > > > The problem is that with these panels that need big init sequences the > > code based solution is _a lot_ bigger. If it were a few bytes or a > > 1-2KB then fine, but when Hsin-Yi measured Linus W's attempt to move > > from a

Re: [PATCH v1 2/2] drm/panel: kd101ne3: add new panel driver

2024-04-24 Thread Doug Anderson
Hi, On Tue, Apr 23, 2024 at 2:20 PM Dmitry Baryshkov wrote: > > On Tue, Apr 23, 2024 at 01:41:59PM -0700, Doug Anderson wrote: > > Hi, > > > > On Tue, Apr 23, 2024 at 11:10 AM Hsin-Yi Wang wrote: > > > > > > > > > > +#define _INIT_DCS

Re: [PATCH v1 2/2] drm/panel: kd101ne3: add new panel driver

2024-04-23 Thread Doug Anderson
Hi, On Tue, Apr 23, 2024 at 11:10 AM Hsin-Yi Wang wrote: > > > > > > +#define _INIT_DCS_CMD(...) { \ > > > > > + .type = INIT_DCS_CMD, \ > > > > > + .len = sizeof((char[]){__VA_ARGS__}), \ > > > > > + .data = (char[]){__VA_ARGS__} } > > > > > + > > > > > +#define _INIT_DELAY_CMD(...)

Re: [PATCH] drm/panel-edp: Add panel CSOT MNB601LS1-1

2024-04-23 Thread Doug Anderson
Hi, On Mon, Apr 22, 2024 at 6:28 PM Xuxin Xiong wrote: > > Yes, I read the edid from the panels, one is CSO and the other is CSW. > The details are as follows, please help check. Thank you! > > > 1. MNC207QS1-1 > edid-decode (hex): > 00 ff ff ff ff ff ff 00 0e 6f 00 12 e7 00 00 00 > 1e 21 01 04

Re: [PATCH v2 2/7] drm/panel: himax-hx83102: Break out as separate driver

2024-04-23 Thread Doug Anderson
Hi, On Tue, Apr 23, 2024 at 2:37 AM cong yang wrote: > > > > +static int starry_init_cmd(struct hx83102 *ctx) > > > +{ > > > + struct mipi_dsi_device *dsi = ctx->dsi; > > > + > > > + mipi_dsi_dcs_write_seq(dsi, HX83102_SETEXTC, 0x83, 0x10, 0x21, > > > 0x55, 0x00); > > > + > > > +

Re: [PATCH v2 3/7] arm64: defconfig: Enable HIMAX_HX83102 panel

2024-04-22 Thread Doug Anderson
Hi, On Mon, Apr 22, 2024 at 2:03 AM Cong Yang wrote: > > DRM_PANEL_HIMAX_HX83102 is being split out from DRM_PANEL_BOE_TV101WUM_NL6. > Since the arm64 defconfig had the BOE panel driver enabled, let's also > enable the himax driver. > > Signed-off-by: Cong Yang > --- >

Re: [PATCH v2 2/7] drm/panel: himax-hx83102: Break out as separate driver

2024-04-22 Thread Doug Anderson
Hi, On Mon, Apr 22, 2024 at 2:03 AM Cong Yang wrote: > > The Starry HX83102 based mipi panel should never have been part of the boe > tv101wum driver. Discussion with Doug and Linus in V1 [1], we need a > separate driver to enable the hx83102 controller. > > In hx83102 driver, add DSI commands

Re: [PATCH v2 1/7] dt-bindings: display: panel: Add himax hx83102 panel bindings

2024-04-22 Thread Doug Anderson
Hi, On Mon, Apr 22, 2024 at 8:14 AM Rob Herring wrote: > > > +additionalProperties: false > > Perhaps 'unevaluatedProperties' instead. Don't you want to support > standard properties such as width-mm/height-mm? For at least those two properties, it looks like the answer is "no". >From reading

Re: [PATCH] drm/panel-edp: Add panel CSOT MNB601LS1-1

2024-04-22 Thread Doug Anderson
Hi, On Sun, Apr 21, 2024 at 11:09 PM Xuxin Xiong wrote: > > Add support for the following panel: > CSOT MNB601LS1-1 > > Signed-off-by: Xuxin Xiong > --- > drivers/gpu/drm/panel/panel-edp.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-edp.c >

Re: [PATCH v1 2/2] HID: i2c-hid: elan: Add ili2900 timing

2024-04-19 Thread Doug Anderson
Hi, On Thu, Apr 18, 2024 at 5:48 AM lvzhaoxiong wrote: > > ILI2900 requires reset to pull down time greater than 10ms, > so the configuration post_power_delay_ms is 10, and the chipset > initial time is required to be greater than 100ms, > so the post_gpio_reset_on_delay_ms is set to 100. > >

Re: [PATCH v1 2/4] drm/panel: boe-tv101wum-nl6: Support for BOE nv110wum-l60 MIPI-DSI panel

2024-04-11 Thread Doug Anderson
Hi, On Wed, Apr 10, 2024 at 12:15 AM Cong Yang wrote: > > The BOE nv110wum-l60 is a 11.0" WUXGA TFT LCD panel, which fits in nicely > with the existing panel-boe-tv101wum-nl6 driver. Hence, we add a new > compatible with panel specific config. I guess we have the same question we've had with

Re: [PATCH] drm/bridge: ti-sn65dsi86: Fix ti_sn_bridge_set_dsi_rate function

2024-04-10 Thread Doug Anderson
Hi, On Wed, Apr 10, 2024 at 4:42 AM Jayesh Choudhary wrote: > > Hello Doug, > > Thanks for the review. > > On 08/04/24 14:33, Doug Anderson wrote: > > Hi, > > > > On Mon, Apr 8, 2024 at 12:36 AM Jayesh Choudhary wrote: > >> > >> Due to i

Re: [PATCH v2] dt-bindings: display: bridge: it6505: Add #sound-dai-cells

2024-04-08 Thread Doug Anderson
Hi, On Wed, Mar 27, 2024 at 10:33 AM Rob Herring wrote: > > > On Wed, 27 Mar 2024 16:52:48 +0800, Chen-Yu Tsai wrote: > > The ITE IT6505 display bridge can take one I2S input and transmit it > > over the DisplayPort link. > > > > Add #sound-dai-cells (= 0) to the binding for it. > > > >

Re: [PATCH] drm/bridge: ti-sn65dsi86: Fix ti_sn_bridge_set_dsi_rate function

2024-04-08 Thread Doug Anderson
Hi, On Mon, Apr 8, 2024 at 12:36 AM Jayesh Choudhary wrote: > > Due to integer calculations, the rounding off can cause errors in the final > value propagated in the registers. > Considering the example of 1080p (very common resolution), the mode->clock > is 148500, dsi->lanes = 4, and bpp = 24,

Re: [PATCH 3/3] drm-panel: If drm_panel_dp_aux_backlight() fails, don't fail panel probe

2024-04-08 Thread Doug Anderson
Hi, On Mon, Mar 25, 2024 at 5:07 PM Hsin-Yi Wang wrote: > > On Mon, Mar 25, 2024 at 2:57 PM Douglas Anderson > wrote: > > > > If we're using the AUX channel for eDP backlight and it fails to probe > > for some reason, let's _not_ fail the panel probe. > > > > At least one case where we could

Re: [PATCH 2/3] drm/panel-edp: If we fail to powerup/get EDID, use conservative timings

2024-04-08 Thread Doug Anderson
Hi, On Mon, Mar 25, 2024 at 5:05 PM Hsin-Yi Wang wrote: > > On Mon, Mar 25, 2024 at 2:57 PM Douglas Anderson > wrote: > > > > If at boot we fail to power up the eDP panel (most often happens if > > the eDP panel never asserts HPD to us) or if we are unable to read the > > EDID at bootup to

Re: [PATCH 1/3] drm/panel-edp: Abstract out function to set conservative timings

2024-04-08 Thread Doug Anderson
Hi, On Mon, Mar 25, 2024 at 4:52 PM Hsin-Yi Wang wrote: > > On Mon, Mar 25, 2024 at 2:56 PM Douglas Anderson > wrote: > > > > If we're using the generic "edp-panel" compatible string and we fail > > to detect an eDP panel then we fall back to conservative timings for > > powering up and

Re: [PATCH] drm/msm/dp: allow voltage swing / pre emphasis of 3

2024-03-29 Thread Doug Anderson
Hi, On Sat, Feb 3, 2024 at 5:47 AM Dmitry Baryshkov wrote: > > Both dp_link_adjust_levels() and dp_ctrl_update_vx_px() limit swing and > pre-emphasis to 2, while the real maximum value for the sum of the > voltage swing and pre-emphasis is 3. Fix the DP code to remove this > limitation. > >

Re: [PATCH v2] drm/dp: Clarify that wait_hpd_asserted() is not optional for panels

2024-03-26 Thread Doug Anderson
Hi, On Tue, Mar 19, 2024 at 3:45 PM Dmitry Baryshkov wrote: > > On Tue, 19 Mar 2024 at 22:58, Douglas Anderson wrote: > > > > In response to my patch removing the "wait for HPD" logic at the > > beginning of the MSM DP transfer() callback [1], we had some debate > > about what the "This is an

Re: [PATCH 1/2] drm/panel: Remove redundant checks in multiple panels

2024-03-25 Thread Doug Anderson
Hi, On Sat, Mar 23, 2024 at 7:05 PM Emilio Mendoza Reyes wrote: > > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > From: Emilio Mendoza Reyes > > The patch ("drm/panel: Check for already prepared/enabled in drm_panel") > moved checking for (en/dis)abled and [un]prepared panels before

Re: [PATCH] drm/panel-edp: Add AUO B120XAN01.0

2024-03-25 Thread Doug Anderson
Hi, On Mon, Mar 25, 2024 at 5:59 AM Pin-yen Lin wrote: > > Add support for the AUO B120XAN01.0 panel. > > Signed-off-by: Pin-yen Lin > --- > > drivers/gpu/drm/panel/panel-edp.c | 1 + > 1 file changed, 1 insertion(+) Looks fine. Reviewed-by: Douglas Anderson Applied to drm-misc-next:

Re: [drm-tip:drm-tip 4/11] drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c:105:73: error: '.bin' directive output may be truncated writing 4 bytes into a region of size between 2 and 31

2024-03-25 Thread Doug Anderson
Hi, On Sat, Mar 23, 2024 at 10:15 AM kernel test robot wrote: > > tree: git://anongit.freedesktop.org/drm/drm-tip drm-tip > head: 657dd8fcd2f1d1205c6f98fdb8b60915228991d1 > commit: 0885186926a13c697d78f5af03f32445414b6ad5 [4/11] Merge remote-tracking > branch 'drm-misc/drm-misc-next' into

Re: [PATCH] drm/panel: atna33xc20: Fix unbalanced regulator in the case HPD doesn't assert

2024-03-20 Thread Doug Anderson
Hi, On Thu, Mar 14, 2024 at 3:32 PM Jessica Zhang wrote: > > On 3/13/2024 2:12 PM, Douglas Anderson via B4 Relay wrote: > > From: Douglas Anderson > > > > When the atna33xc20 driver was first written the resume code never > > returned an error. If there was a problem waiting for HPD it just > >

Re: [PATCH] drm/dp: Clarify that wait_hpd_asserted() is not optional for panels

2024-03-19 Thread Doug Anderson
Hi, On Tue, Mar 19, 2024 at 1:55 PM Dmitry Baryshkov wrote: > > > -* panel to finish powering on. This is an optional function. > > +* panel to finish powering on. It is optional for DP AUX > > controllers > > +* to implement this function but

Re: [PATCH v2 3/4] drm/msm/dp: Delete the old 500 ms wait for eDP HPD in aux transfer

2024-03-19 Thread Doug Anderson
Hi, On Tue, Mar 19, 2024 at 10:27 AM Dmitry Baryshkov wrote: > > On Tue, 19 Mar 2024 at 19:13, Abhinav Kumar wrote: > > > > > > > > On 3/18/2024 5:55 PM, Dmitry Baryshkov wrote: > > > On Tue, 19 Mar 2024 at 02:19, Abhinav Kumar > > > wrote: > > >> > > >> +bjorn, johan as fyi for sc8280xp > >

Re: [PATCH v2 4/4] drm/msm/dp: Fix typo in static function (ststus => status)

2024-03-18 Thread Doug Anderson
Hi, On Mon, Mar 18, 2024 at 12:26 PM Stephen Boyd wrote: > > Quoting Douglas Anderson (2024-03-15 14:36:32) > > This is a no-op change to just fix a typo in the name of a static function. > > > > Signed-off-by: Douglas Anderson > > --- > > > > Changes in v2: > > - ("Fix typo in static function

Re: [PATCH 1/3] drm/msm/dp: Avoid a long timeout for AUX transfer if nothing connected

2024-03-14 Thread Doug Anderson
Hi, On Wed, Mar 13, 2024 at 1:41 PM Abhinav Kumar wrote: > > > > On 3/12/2024 5:13 PM, Douglas Anderson wrote: > > As documented in the description of the transfer() function of > > "struct drm_dp_aux", the transfer() function can be called at any time > > regardless of the state of the DP port.

Re: [PATCH v6 0/5] Match panel with identity

2024-03-14 Thread Doug Anderson
Hi, On Thu, Mar 7, 2024 at 3:07 PM Hsin-Yi Wang wrote: > > This series is a follow up for 1a5e81de180e ("Revert "drm/panel-edp: Add > auo_b116xa3_mode""). It's found that 2 different AUO panels use the same > product id. One of them requires an overridden mode, while the other should > use the

Re: [PATCH][next] drm/msm: remove unused variable 'out'

2024-03-14 Thread Doug Anderson
Hi, On Thu, Mar 7, 2024 at 1:37 AM Colin Ian King wrote: > > The variable out is being initialized and incremented but it is never > actually referenced in any other way. The variable is redundant and can > be removed. > > Cleans up clang scan build warning: >

Re: [PATCH 1/3] drm/msm/dp: Avoid a long timeout for AUX transfer if nothing connected

2024-03-12 Thread Doug Anderson
Hi, On Tue, Mar 12, 2024 at 5:47 PM Guenter Roeck wrote: > > On Tue, Mar 12, 2024 at 5:14 PM Douglas Anderson > wrote: > > > > As documented in the description of the transfer() function of > > "struct drm_dp_aux", the transfer() function can be called at any time > > regardless of the state

Re: [V2] drm/panel-edp: Add BOE NT116WHM-N44 and CMN N116BCA-EA1

2024-03-08 Thread Doug Anderson
Hi, On Thu, Mar 7, 2024 at 4:48 PM Xuxin Xiong wrote: > > Add support for the following 2 panels: > 1. BOE NT116WHM-N44 > 2. CMN N116BCA-EA1 > > Signed-off-by: Xuxin Xiong > Reviewed-by: Douglas Anderson It's fine this time, but please be careful in the future. I never actually gave you my

Re: [PATCH v6 2/5] drm/edid: Add a function to match EDID with identity

2024-03-08 Thread Doug Anderson
Hi, On Fri, Mar 8, 2024 at 12:07 AM Jani Nikula wrote: > > On Thu, 07 Mar 2024, Hsin-Yi Wang wrote: > > Create a type drm_edid_ident as the identity of an EDID. Currently it > > contains panel id and monitor name. > > > > Create a function that can match a given EDID and an identity: > > 1.

Re: [PATCH v6 2/5] drm/edid: Add a function to match EDID with identity

2024-03-07 Thread Doug Anderson
Hi, On Thu, Mar 7, 2024 at 3:07 PM Hsin-Yi Wang wrote: > > Create a type drm_edid_ident as the identity of an EDID. Currently it > contains panel id and monitor name. > > Create a function that can match a given EDID and an identity: > 1. Reject if the panel id doesn't match. > 2. If name is not

Re: [PATCH v5 6/6] drm/panel-edp: Fix AUO 0x405c panel naming and add a variant

2024-03-07 Thread Doug Anderson
Hi, On Thu, Mar 7, 2024 at 12:28 PM Jani Nikula wrote: > > On Thu, 07 Mar 2024, Hsin-Yi Wang wrote: > > On Thu, Mar 7, 2024 at 5:28 AM Jani Nikula > > wrote: > >> > >> On Wed, 06 Mar 2024, Doug Anderson wrote: > >> > Hi, > >> >

Re: [PATCH] drm/panel-edp: Add several generic edp panels

2024-03-07 Thread Doug Anderson
Hi, On Thu, Mar 7, 2024 at 1:44 AM Xuxin Xiong wrote: > > Add support for the following 2 panels: > 1. BOE NT116WHM-N44 > 2. CMN N116BCA-EA1 > > Signed-off-by: Xuxin Xiong > --- > drivers/gpu/drm/panel/panel-edp.c | 2 ++ > 1 file changed, 2 insertions(+) The patch looks OK, but please resend

Re: [PATCH v5 3/6] drm/edid: Add a function to match EDID with identity

2024-03-06 Thread Doug Anderson
Hi, On Wed, Mar 6, 2024 at 4:20 PM Hsin-Yi Wang wrote: > > On Wed, Mar 6, 2024 at 3:30 PM Doug Anderson wrote: > > > > Hi, > > > > On Wed, Mar 6, 2024 at 12:04 PM Hsin-Yi Wang wrote: > > > > > > +static void > > > +match_

Re: [PATCH v5 6/6] drm/panel-edp: Fix AUO 0x405c panel naming and add a variant

2024-03-06 Thread Doug Anderson
Hi, On Wed, Mar 6, 2024 at 12:04 PM Hsin-Yi Wang wrote: > > @@ -1009,6 +1009,19 @@ static const struct panel_desc auo_b101ean01 = { > }, > }; > > +static const struct drm_display_mode auo_b116xa3_mode = { > + .clock = 70589, > + .hdisplay = 1366, > + .hsync_start =

Re: [PATCH v5 4/6] drm/edid: Match edid quirks with identity

2024-03-06 Thread Doug Anderson
Hi, On Wed, Mar 6, 2024 at 12:04 PM Hsin-Yi Wang wrote: > > Currently edid quirks are matched by panel id only. > > Modify it to match with identity so it's easier to be extended > for more complex matching if required. > > Suggested-by: Jani Nikula > Signed-off-by: Hsin-Yi Wang > Reviewed-by:

Re: [PATCH v5 5/6] drm/panel-edp: Match edp_panels with panel identity

2024-03-06 Thread Doug Anderson
Hi, On Wed, Mar 6, 2024 at 12:04 PM Hsin-Yi Wang wrote: > > @@ -2111,15 +2113,16 @@ static const struct edp_panel_entry edp_panels[] = { > { /* sentinal */ } > }; > > -static const struct edp_panel_entry *find_edp_panel(u32 panel_id) > +static const struct edp_panel_entry

Re: [PATCH v5 3/6] drm/edid: Add a function to match EDID with identity

2024-03-06 Thread Doug Anderson
Hi, On Wed, Mar 6, 2024 at 12:04 PM Hsin-Yi Wang wrote: > > +static void > +match_identity(const struct detailed_timing *timing, void *data) > +{ > + struct drm_edid_match_closure *closure = data; > + unsigned int i; > + const char *name = closure->ident->name; > +

Re: [PATCH v5 2/6] drm/edid: Clean up drm_edid_get_panel_id()

2024-03-06 Thread Doug Anderson
Hi, On Wed, Mar 6, 2024 at 12:04 PM Hsin-Yi Wang wrote: > > drm_edid_get_panel_id() now just directly call edid_extract_panel_id(). > > Merge them into one function. > > Signed-off-by: Hsin-Yi Wang > --- > v4->v5: new > --- > drivers/gpu/drm/drm_edid.c | 39

  1   2   3   4   5   6   7   8   9   10   >