Re: [PATCH RFC PKS/PMEM 51/58] kernel: Utilize new kmap_thread()

ira.we...@intel.com writes: > From: Ira Weiny > > This kmap() call is localized to a single thread. To avoid the over > head of global PKRS updates use the new kmap_thread() call. Acked-by: "Eric W. Biederman" > > Cc: Eric Biederman > Signed-off-by: Ira Wein

Re: [PATCH] fbdev: potential information leak in do_fb_ioctl()

Joe Perches writes: > On Wed, 2019-10-30 at 21:12 +0100, Andrea Righi wrote: >> Then memset() + memcpy() is probably the best option, >> since copying all those fields one by one looks quite ugly to me... > > A memset of an automatic before a memcpy to the same > automatic is unnecessary. You st

Re: [PATCH] fbdev: potential information leak in do_fb_ioctl()

Andrea Righi writes: > On Tue, Oct 29, 2019 at 02:02:11PM -0500, Eric W. Biederman wrote: >> Dan Carpenter writes: >> >> > The "fix" struct has a 2 byte hole after ->ywrapstep and the >> > "fix = info->fix;" assignment doe

Re: [PATCH] fbdev: potential information leak in do_fb_ioctl()

Dan Carpenter writes: > The "fix" struct has a 2 byte hole after ->ywrapstep and the > "fix = info->fix;" assignment doesn't necessarily clear it. It depends > on the compiler. > > Fixes: 1f5e31d7e55a ("fbmem: don't call copy_from/to_user() with mutex held") > Signed-off-by: Dan Carpenter > ---

Re: [PATCH 2/3] drm/scheduler: Don't call wait_event_killable for signaled process.

Andrey Grodzovsky writes: > On 04/25/2018 11:29 AM, Eric W. Biederman wrote: > >> Another issue is changing wait_event_killable to wait_event_timeout where I >> need >> to understand >> what TO value is acceptable for all the drivers using the scheduler, or &

Re: [PATCH 2/3] drm/scheduler: Don't call wait_event_killable for signaled process.

Andrey Grodzovsky writes: > On 04/25/2018 03:14 AM, Daniel Vetter wrote: >> On Tue, Apr 24, 2018 at 05:37:08PM -0400, Andrey Grodzovsky wrote: >>> >>> On 04/24/2018 05:21 PM, Eric W. Biederman wrote: >>>> Andrey Grodzovsky writes: >>>>

Re: [PATCH 2/3] drm/scheduler: Don't call wait_event_killable for signaled process.

Daniel Vetter writes: > On Tue, Apr 24, 2018 at 05:46:52PM +0200, Michel Dänzer wrote: >> >> Adding the dri-devel list, since this is driver independent code. >> >> >> On 2018-04-24 05:30 PM, Andrey Grodzovsky wrote: >> > Avoid calling wait_event_killable when you are possibly being called >>

Re: [PATCH 2/3] drm/scheduler: Don't call wait_event_killable for signaled process.

Andrey Grodzovsky writes: > On 04/24/2018 05:21 PM, Eric W. Biederman wrote: >> Andrey Grodzovsky writes: >> >>> On 04/24/2018 03:44 PM, Daniel Vetter wrote: >>>> On Tue, Apr 24, 2018 at 05:46:52PM +0200, Michel Dänzer wrote: >>>>> Adding t

Re: [PATCH 2/3] drm/scheduler: Don't call wait_event_killable for signaled process.

Andrey Grodzovsky writes: > On 04/24/2018 03:44 PM, Daniel Vetter wrote: >> On Tue, Apr 24, 2018 at 05:46:52PM +0200, Michel Dänzer wrote: >>> Adding the dri-devel list, since this is driver independent code. >>> >>> >>> On 2018-04-24 05:30 PM, Andrey Grodzovsky wrote: Avoid calling wait_eve

[PATCH] drm/cirrus: Fix NULL pointer dereference when registering the fbdev

fig->funcs as part of the fbdev registration > process. > Make sure dev->mode_config.funcs is properly set to avoid dereferencing > a NULL pointer. That fixes the issues I am seeing. Tested-by: "Eric W. Biederman" > Signed-off-by: Boris Brezillon > Fixes: c61b93f

Re: [PATCH 0/3] drm/radeon kexec fixes

Alex Deucher writes: > On Mon, Sep 9, 2013 at 5:21 AM, Markus Trippelsdorf > wrote: > >> IIRC Alex said the sanity checks are expensive and boot-time could be >> improved by dropping them. Maybe he can chime in? > > They shouldn't be necessary with a proper shutdown, but in this > particular cas

Re: [PATCH 0/3] drm/radeon kexec fixes

Markus Trippelsdorf writes: > Here are a couple of patches that get kexec working with radeon devices. > I've tested this on my RS780. > Comments or flames are welcome. > Thanks. A couple of high level comments. This looks promising for the usual case. Removing the printk at the end of the ke

Re: Commit f5d9b7f0f9 (fix r600_enable_sclk_control()) causes kexec issues

Alex Deucher writes: > On Mon, Jul 29, 2013 at 11:50 AM, Eric W. Biederman > wrote: >> >> >> Alex Deucher wrote: >>>On Mon, Jul 29, 2013 at 10:09 AM, Markus Trippelsdorf >>> wrote: >>>> On 2013.07.29 at 09:58 -0400, Alex Deucher wrote: >

Re: Commit f5d9b7f0f9 (fix r600_enable_sclk_control()) causes kexec issues

Alex Deucher wrote: >On Mon, Jul 29, 2013 at 10:09 AM, Markus Trippelsdorf > wrote: >> On 2013.07.29 at 09:58 -0400, Alex Deucher wrote: >>> On Mon, Jul 29, 2013 at 3:51 AM, Markus Trippelsdorf >>> wrote: >>> > On my test machine Xorg doesn't start anymore when I kexec into a >>> > 3.11.0-rc3 k

Commit f5d9b7f0f9 (fix r600_enable_sclk_control()) causes kexec issues

Alex Deucher writes: > On Mon, Jul 29, 2013 at 11:50 AM, Eric W. Biederman > wrote: >> >> >> Alex Deucher wrote: >>>On Mon, Jul 29, 2013 at 10:09 AM, Markus Trippelsdorf >>> wrote: >>>> On 2013.07.29 at 09:58 -0400, Alex Deucher wrote: >

Commit f5d9b7f0f9 (fix r600_enable_sclk_control()) causes kexec issues

Alex Deucher wrote: >On Mon, Jul 29, 2013 at 10:09 AM, Markus Trippelsdorf > wrote: >> On 2013.07.29 at 09:58 -0400, Alex Deucher wrote: >>> On Mon, Jul 29, 2013 at 3:51 AM, Markus Trippelsdorf >>> wrote: >>> > On my test machine Xorg doesn't start anymore when I kexec into a >>> > 3.11.0-rc3 k

Re: [REVIEW][PATCH 12/15] userns: Convert drm to use kuid and kgid and struct pid where appropriate

Dave Airlie writes: >> Blink Blink this had not been converted to use struct pid ages ago? >> >> - On drm open capture the openers kuid and struct pid. >> - On drm close release the kuid and struct pid >> - When reporting the uid and pid convert the kuid and struct pid >> into values in the app

[REVIEW][PATCH 12/15] userns: Convert drm to use kuid and kgid and struct pid where appropriate

Dave Airlie writes: >> Blink Blink this had not been converted to use struct pid ages ago? >> >> - On drm open capture the openers kuid and struct pid. >> - On drm close release the kuid and struct pid >> - When reporting the uid and pid convert the kuid and struct pid >> into values in the app

[REVIEW][PATCH 12/15] userns: Convert drm to use kuid and kgid and struct pid where appropriate

Cc: dri-devel@lists.freedesktop.org Acked-by: Serge Hallyn Signed-off-by: Eric W. Biederman --- drivers/gpu/drm/drm_fops.c |3 ++- drivers/gpu/drm/drm_info.c |5 +++-- drivers/gpu/drm/drm_ioctl.c |4 ++-- include/drm/drmP.h |4 ++-- init/Kconfig|1

[REVIEW][PATCH 12/15] userns: Convert drm to use kuid and kgid and struct pid where appropriate

Cc: dri-devel at lists.freedesktop.org Acked-by: Serge Hallyn Signed-off-by: Eric W. Biederman --- drivers/gpu/drm/drm_fops.c |3 ++- drivers/gpu/drm/drm_info.c |5 +++-- drivers/gpu/drm/drm_ioctl.c |4 ++-- include/drm/drmP.h |4 ++-- init/Kconfig