Re: [PATCH v9 6/6] drm/dp_mst: Add helpers for MST DSC and virtual DPCD aux

!= DP_DWN_STRM_PORT_TYPE_ANALOG)) >> + return port->mgr->aux; >> + } > >I would've put the quirk definition from patch 5 and the quirk handling >above together into a separate patch. The current patch would be about >how things should work

Re: [PATCH v8 6/6] drm/dp_mst: Add helpers for MST DSC and virtual DPCD aux

Received offline review from AMD MST DSC (Non-Linux) expert Wenjing Liu, giving me permission to mark this patch Reviewed-by: Wenjing Liu From: David Francis Sent: August 26, 2019 2:05 PM To: dri-devel@lists.freedesktop.org Cc: Francis, David; Lyude

Re: [PATCH v8 5/6] drm/dp_mst: Add new quirk for Synaptics MST hubs

_COUNT during detection. >> */ >>DP_DPCD_QUIRK_NO_SINK_COUNT, >> + /** >> + * @DP_DPCD_QUIRK_DSC_WITHOUT_VIRTUAL_DPCD: >> + * >> + * The device supports MST DSC despite not supporting Virtual DPCD. >> + * The DSC caps c

Re: [PATCH v4 0/5] MST DSC support in drm-mst

:03 PM To: Francis, David; dri-devel@lists.freedesktop.org; Manasi Navare Subject: Re: [PATCH v4 0/5] MST DSC support in drm-mst OK-done reviewing, but there's some stuff missing here. The PBN bandwidth checks in https://patchwork.freedesktop.org/patch/325604/?series=65423=3 need to be moved

Re: [PATCH v3 00/16] Display Stream Compression (DSC) for AMD Navi

I was building against amd-staging-drm-next (commit e4a67e6cf14c). v4 will contain just the drm-mst patches and will apply on latest drm-tip/drm-tip (commit 018886de4726) From: Lyude Paul Sent: August 21, 2019 5:20 PM To: Francis, David; dri-devel

Re: [PATCH v3 13/16] drm/amd/display: Validate DSC caps on MST endpoints

Whoops, left in a test print. Ignore this patch From: David Francis Sent: August 21, 2019 4:01 PM To: dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org Cc: Francis, David; Liu, Wenjing; Cornij, Nikola Subject: [PATCH v3 13/16] drm/amd

Re: [PATCH v3 16/16] drm/amd/display: Trigger modesets on MST DSC connectors

it is clear what functionality is common between drivers From: dri-devel on behalf of David Francis Sent: August 21, 2019 4:01 PM To: dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org Cc: Li, Sun peng (Leo); Francis, David; Kazlauskas

Re: [PATCH 14/14] drm/amd/display: Trigger modesets on MST DSC connectors

m_atomic_check(struct drm_device >> *dev, >>goto fail; >>} >> >> +#ifdef CONFIG_DRM_AMD_DC_DSC_SUPPORT >> + for_each_oldnew_crtc_in_state(state, crtc, old_crtc_state, >> new_crtc_state, i) { >> + if

Re: [PATCH 06/14] drm/amd/display: Use dc helpers to compute timeslot distribution

ccount */ >> + pbn = drm_dp_calc_pbn_mode(clock, 1); >> >> - slots = drm_dp_find_vcpi_slots(mst_mgr, pbn); >> + /* Convert kilobits per second / 64 (for 64 timeslots) to pbn >> (54/64 megabytes per second) */ >> + pb