Re: [RESEND v7 15/37] clk: renesas: Add SH7750/7751 CPG Driver

2024-05-21 Thread Geert Uytterhoeven
egister %s pll clock (%d)\n" sounds more suitable to me. > + node, clk_name, ret); > + return ret; > +} Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal con

Re: [RESEND v7 00/37] Device Tree support for SH7751 based board

2024-05-21 Thread Geert Uytterhoeven
way, we can reduce the overall size > of the series a bit. +1 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to j

Re: [PATCH 00/11] drm: Restore helper usability

2024-04-22 Thread Geert Uytterhoeven
for two different things: A. To enable a driver module that can be only built-in, B. To enable an option or feature of a driver or subsystem. Without this distinction, dependencies cannot be auto-propagated 100% correctly. Fixing that would require introducing a third type (and possibly renaming the

Re: [PATCH 00/11] drm: Restore helper usability

2024-04-22 Thread Geert Uytterhoeven
Hi Jani, On Mon, Apr 22, 2024 at 7:15 PM Jani Nikula wrote: > On Mon, 22 Apr 2024, Geert Uytterhoeven wrote: > > On Mon, Apr 22, 2024 at 3:55 PM Arnd Bergmann wrote: > >> I'm not sure where this misunderstanding comes from, as you > >> seem to be repeating the same

Re: [PATCH 00/11] drm: Restore helper usability

2024-04-22 Thread Geert Uytterhoeven
t; There is no end to this, it just goes on and on, as the > > dependencies of the selected symbols change over time. Often the > > selects require unintuitive if patterns that are about the > > implementation details of the symbol being selected. > > Agreed, tha

[PATCH 11/11] Revert "drm/display: Make all helpers visible and switch to depends on"

2024-04-22 Thread Geert Uytterhoeven
is interested in. Making a driver depend on helper code means that the user needs to know which helpers to enable first, which is very user-unfriendly. Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/display/Kconfig | 26 -- 1 file changed, 12 insertions(+), 14 deletions

[PATCH 09/11] Revert "drm: Switch DRM_DISPLAY_HELPER to depends on"

2024-04-22 Thread Geert Uytterhoeven
is interested in. Making a driver depend on helper code means that the user needs to know which helpers to enable first, which is very user-unfriendly. Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/Kconfig | 6 ++ drivers/gpu/drm/amd/amdgpu/Kconfig | 6

[PATCH 04/11] Revert "drm: fix DRM_DISPLAY_DP_HELPER dependencies"

2024-04-22 Thread Geert Uytterhoeven
This reverts commit d1ef8fc18be6adbbffdee06fbb5b33699e2852be, as the commit it fixes will be reverted, too. Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/exynos/Kconfig | 2 +- drivers/gpu/drm/rockchip/Kconfig | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 02/11] Revert "drm/display: Select DRM_KMS_HELPER for DP helpers"

2024-04-22 Thread Geert Uytterhoeven
This reverts commit 7fa678cc0a5648b5ea28629a2d21b9d4b6ac8f56, as the commit it fixes will be reverted, too. Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/display/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/display/Kconfig b/drivers/gpu/drm/display/Kconfig

[PATCH 08/11] Revert "drm: Switch DRM_DISPLAY_DP_AUX_BUS to depends on"

2024-04-22 Thread Geert Uytterhoeven
is interested in. Making a driver depend on helper code means that the user needs to know which helpers to enable first, which is very user-unfriendly. Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/bridge/Kconfig | 6 +++--- drivers/gpu/drm/bridge/analogix/Kconfig | 2 +- drivers/gpu

[PATCH 07/11] Revert "drm: Switch DRM_DISPLAY_DP_HELPER to depends on"

2024-04-22 Thread Geert Uytterhoeven
is interested in. Making a driver depend on helper code means that the user needs to know which helpers to enable first, which is very user-unfriendly. Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/Kconfig | 2 +- drivers/gpu/drm/amd/amdgpu/Kconfig | 2 +- drivers/gpu

[PATCH 03/11] Revert "drm/bridge: dw-hdmi: Make DRM_DW_HDMI selectable"

2024-04-22 Thread Geert Uytterhoeven
This reverts commit 0209df3b4731516fe77638bfc52ba2e9629c67cd, as the commit it fixes (which is BTW not the commit in the Fixes: tag!) will be reverted, too. Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/bridge/synopsys/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 05/11] Revert "drm: Switch DRM_DISPLAY_HDMI_HELPER to depends on"

2024-04-22 Thread Geert Uytterhoeven
is interested in. Making a driver depend on helper code means that the user needs to know which helpers to enable first, which is very user-unfriendly. Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/amd/amdgpu/Kconfig | 2 +- drivers/gpu/drm/bridge/synopsys/Kconfig | 2 +- drivers/gpu/drm

[PATCH 01/11] Revert "drm: fix DRM_DISPLAY_DP_HELPER dependencies, part 2"

2024-04-22 Thread Geert Uytterhoeven
This reverts commit a57e191ebbaa0363dbf352cc37447c2230573e29, as the commits it fixes will be reverted, too. Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/bridge/analogix/Kconfig | 2 +- drivers/gpu/drm/rockchip/Kconfig| 2 +- 2 files changed, 2 insertions(+), 2 deletions

[PATCH 00/11] drm: Restore helper usability

2024-04-22 Thread Geert Uytterhoeven
ean adding dependencies to the source symbol. Thanks for applying! [1] https://lore.kernel.org/r/20240327-kms-kconfig-helpers-v3-0-eafee11b8...@kernel.org/ Geert Uytterhoeven (11): Revert "drm: fix DRM_DISPLAY_DP_HELPER dependencies, part 2" Revert "drm/display: Select DRM_

[PATCH 10/11] Revert "drm: Make drivers depends on DRM_DW_HDMI"

2024-04-22 Thread Geert Uytterhoeven
is interested in. Making a driver depend on helper code means that the user needs to know which helpers to enable first, which is very user-unfriendly. Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/bridge/imx/Kconfig | 4 ++-- drivers/gpu/drm/imx/ipuv3/Kconfig | 5 ++--- drivers

[PATCH 06/11] Revert "drm: Switch DRM_DISPLAY_HDCP_HELPER to depends on"

2024-04-22 Thread Geert Uytterhoeven
is interested in. Making a driver depend on helper code means that the user needs to know which helpers to enable first, which is very user-unfriendly. Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/amd/amdgpu/Kconfig | 2 +- drivers/gpu/drm/bridge/Kconfig | 2 +- drivers/gpu/drm

Re: [PATCH v6 3/5] drm: Add support to get EDID from ACPI

2024-04-17 Thread Geert Uytterhoeven
ructures. > > Thanks! I don't see a __packed attribute on struct drm_connector, but > I'll put it near by other bools in case that changes in the future. FTR, don't add __packed unless you have a very good reason to do so. With __packed, the compiler will emit multiple byte-accesses to a

Re: [PATCH v2 08/43] drm/fbdev: Add fbdev-shmem

2024-04-17 Thread Geert Uytterhoeven
arts are an integral number of pages, based on fix.smem_{start,len} resp. fix.mmio_{start,len}. Old XFree86 used the MMIO part to implement hardware acceleration when running on top of fbdev. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32

Re: [PATCH v3 00/13] drm/display: Convert helpers Kconfig symbols to depends on

2024-04-09 Thread Geert Uytterhoeven
Hi Jani, On Tue, Apr 9, 2024 at 1:13 PM Jani Nikula wrote: > On Tue, 09 Apr 2024, Geert Uytterhoeven wrote: > > On Tue, Apr 9, 2024 at 12:04 PM Jani Nikula > > wrote: > >> On Tue, 09 Apr 2024, Geert Uytterhoeven wrote: > >> > The user should not n

Re: [RESEND v7 08/37] clocksource: sh_tmu: CLOCKSOURCE support.

2024-04-09 Thread Geert Uytterhoeven
mu_device_driver); > #endif [1] "[PATCH] clocksource/drivers/renesas-ostm: Avoid reprobe after successful early probe" https://lore.kernel.org/all/bd027379713cbaafa21ffe9e848ebb7f475ca0e7.1710930542.git.geert+rene...@glider.be/ Gr{oetje,eeting}s, Geert --

Re: [PATCH v3 00/13] drm/display: Convert helpers Kconfig symbols to depends on

2024-04-09 Thread Geert Uytterhoeven
Hi Jani, On Tue, Apr 9, 2024 at 12:04 PM Jani Nikula wrote: > On Tue, 09 Apr 2024, Geert Uytterhoeven wrote: > > The user should not need to know which helpers are needed for the driver > > he is interested in. When a symbol selects another symbol, it should > > just make

Re: [PATCH v3 00/13] drm/display: Convert helpers Kconfig symbols to depends on

2024-04-09 Thread Geert Uytterhoeven
are needed for the driver he is interested in. When a symbol selects another symbol, it should just make sure the dependencies of the target symbol are met. Thanks for reverting ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Li

Re: [PATCH v3 09/13] drm: Switch DRM_DISPLAY_DP_AUX_BUS to depends on

2024-04-09 Thread Geert Uytterhoeven
explicitly. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say

Re: [PATCH 20/21] drm/rcar-du: Allow build with COMPILE_TEST=y

2024-04-09 Thread Geert Uytterhoeven
s-...@vger.kernel.org > Signed-off-by: Ville Syrjälä Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hack

Re: [RESEND v7 21/37] dt-bindings: serial: renesas, scif: Add scif-sh7751.

2024-04-05 Thread Geert Uytterhoeven
Hi Sato-san, On Thu, Apr 4, 2024 at 7:15 AM Yoshinori Sato wrote: > Add Renesas SH7751 SCIF. > > Signed-off-by: Yoshinori Sato > Reviewed-by: Geert Uytterhoeven > --- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml > +++ b/Documentation/devicetree/bindi

Re: [RESEND v7 28/37] dt-bindings: soc: renesas: sh: Add SH7751 based target

2024-04-05 Thread Geert Uytterhoeven
iodata,usl-5p # USL-5P > + - const: renesas,sh7751r Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker.

Re: [RESEND v7 23/37] dt-bindings: display: sm501 register definition helper

2024-04-05 Thread Geert Uytterhoeven
property: ex: $ref: /schemas/types.yaml#/definitions/uint32 description: Extend bus holding time. Please instead use an enum for the actual holding time ([ 0, 16, 32, ...]) in the DT bindings, and convert from actual holding time to register value in the driver. Gr{oetje,eeting

Re: [RESEND v7 14/37] clk: Compatible with narrow registers

2024-04-05 Thread Geert Uytterhoeven
ivider_flags, Likewise. > const struct clk_div_table *table, spinlock_t *lock); > struct clk *clk_register_divider_table(struct device *dev, const char *name, > const char *parent_name, unsigned long flags, > void __iomem *reg, u8 shift, u8 width, &g

Re: [RESEND v7 34/37] sh: Add dtbs target support.

2024-04-05 Thread Geert Uytterhoeven
On Thu, Apr 4, 2024 at 7:16 AM Yoshinori Sato wrote: > Signed-off-by: Yoshinori Sato My Reviewed-by: Geert Uytterhoeven on v6 is still valid. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In perso

Re: [RESEND v7 33/37] sh: j2_mimas_v2.dts update

2024-04-05 Thread Geert Uytterhoeven
Hi Sato-san, On Thu, Apr 4, 2024 at 7:16 AM Yoshinori Sato wrote: > Signed-off-by: Yoshinori Sato >From my comments for v6: Please enhance the one-line summary, e.g. sh: j2_mimas_v2: Update CPU compatible value For the actual changes: Reviewed-by: Geert Uytterhoeven Gr{oetje,ee

Re: [RESEND v7 13/37] dt-bindings: clock: sh7750-cpg: Add renesas,sh7750-cpg header.

2024-04-05 Thread Geert Uytterhoeven
}; Please read https://docs.kernel.org/devicetree/bindings/dts-coding-style.html#order-of-properties-in-device-node Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conve

Re: [RESEND v7 09/37] dt-binding: Add compatible SH7750 SoC

2024-04-05 Thread Geert Uytterhoeven
On Thu, Apr 4, 2024 at 7:15 AM Yoshinori Sato wrote: > Signed-off-by: Yoshinori Sato Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with techni

[PATCH] drm: DRM_DEBUG_MODESET_LOCK should depend on DRM

2024-03-26 Thread Geert Uytterhoeven
There is no point in asking the user about enabling DRM debug tracing when configuring a kernel without DRM support. Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/Kconfig | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm

[PATCH] drm: DRM_WERROR should depend on DRM

2024-03-26 Thread Geert Uytterhoeven
There is no point in asking the user about enforcing the DRM compiler warning policy when configuring a kernel without DRM support. Fixes: f89632a9e5fa6c47 ("drm: Add CONFIG_DRM_WERROR") Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/Kconfig | 2 +- 1 file changed, 1 inser

Re: Build regressions/improvements in v6.9-rc1

2024-03-26 Thread Geert Uytterhoeven
On Mon, 25 Mar 2024, Geert Uytterhoeven wrote: Below is the list of build error/warning regressions/improvements in v6.9-rc1[1] compared to v6.8[2]. Summarized: - build errors: +8/-8 + /kisskb/src/crypto/scompress.c: error: unused variable 'dst_page' [-Werror=unused-variable]: => 174

Re: [PATCH 00/14] Add support for suppressing warning backtraces

2024-03-14 Thread Geert Uytterhoeven
nction names in BUG/WARNING messages). That change, if > desired, can be made later. Unfortunately this also increases kernel size in the CONFIG_KUNIT=m case (ca. 80 KiB for atari_defconfig), making it less attractive to have kunit and all tests enabled as modules in my standard kernel. Gr{oetje,ee

Re: arm: ERROR: modpost: "__aeabi_uldivmod" [drivers/gpu/drm/sun4i/sun4i-drm-hdmi.ko] undefined!

2024-03-14 Thread Geert Uytterhoeven
On Thu, Mar 14, 2024 at 10:27 AM Geert Uytterhoeven wrote: > On Sat, Mar 9, 2024 at 3:34 PM David Laight wrote: > > From: Maxime Ripard > > > Sent: 04 March 2024 11:46 > > > > > > On Mon, Mar 04, 2024 at 12:11:36PM +0100, Arnd Bergmann wrote: > > > &g

Re: arm: ERROR: modpost: "__aeabi_uldivmod" [drivers/gpu/drm/sun4i/sun4i-drm-hdmi.ko] undefined!

2024-03-14 Thread Geert Uytterhoeven
; You could do: > /* The max clock is 5.9GHz, split the divide */ > u32 diff = (u32)(clock / 8) / (200/8); +1, as the issue is still present in current next, as per the recent nagging from the build bots. > The code should really use u32 and u64. > Otherwise the sizes are d

Re: [PATCH 1/6] auxdisplay/ht16k33: Replace use of fb_blank with backlight helper

2024-03-14 Thread Geert Uytterhoeven
On Wed, Mar 13, 2024 at 4:49 PM Thomas Zimmermann wrote: > Replace the use of struct backlight_properties.fb_blank with a > call to backlight_get_brightness(). The helper implement the same > logic as the driver's function. > > Signed-off-by: Thomas Zimmermann Reviewed-by: Gee

Re: [PATCH 11/14] s390: Add support for suppressing warning backtraces

2024-03-14 Thread Geert Uytterhoeven
_), \ > + : : "i" (__BUG_FUNC), \ > + "i" (__LINE__), \ > "i" (x),

Re: [PATCH 08/43] drm/fbdev: Add fbdev-shmem

2024-03-13 Thread Geert Uytterhoeven
Hi Thomas, On Wed, Mar 13, 2024 at 10:24 AM Thomas Zimmermann wrote: > Am 13.03.24 um 10:03 schrieb Geert Uytterhoeven: > > On Wed, Mar 13, 2024 at 9:19 AM Thomas Zimmermann > > wrote: > >> Am 12.03.24 um 17:14 schrieb Geert Uytterhoeven: > >>> On Tue, Mar 1

Re: [PATCH 08/43] drm/fbdev: Add fbdev-shmem

2024-03-13 Thread Geert Uytterhoeven
Hi Thomas, On Wed, Mar 13, 2024 at 9:19 AM Thomas Zimmermann wrote: > Am 12.03.24 um 17:14 schrieb Geert Uytterhoeven: > > On Tue, Mar 12, 2024 at 4:48 PM Thomas Zimmermann > > wrote: > >> Add an fbdev emulation for SHMEM-based memory managers. The code is >

Re: [PATCH 08/43] drm/fbdev: Add fbdev-shmem

2024-03-12 Thread Geert Uytterhoeven
"Failed to register client: %d\n", ret); > + goto err_drm_client_init; > + } > + > + drm_client_register(_helper->client); > + > + return; > + > +err_drm_client_init: > + drm_fb_helper_unprepare(fb_helper); > +

Re: [PATCH 22/22] drm: ensure drm headers are self-contained and pass kernel-doc

2024-03-07 Thread Geert Uytterhoeven
m68k.org Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds

[PATCH] m68k: pgtable: Add missing #include

2024-03-07 Thread Geert Uytterhoeven
@intel.com Signed-off-by: Geert Uytterhoeven --- Jani: Feel free to pick this up as a dependency. Else I will queue this in the m68k tree for v6.10. arch/m68k/include/asm/pgtable.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/m68k/include/asm/pgtable.h b/arch/m68k/include/asm

Re: [PATCH 1/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-03-04 Thread Geert Uytterhoeven
Hi Maxime, On Mon, Mar 4, 2024 at 11:20 AM Maxime Ripard wrote: > On Mon, Mar 04, 2024 at 11:07:22AM +0100, Geert Uytterhoeven wrote: > > On Mon, Mar 4, 2024 at 10:15 AM Maxime Ripard wrote: > > > On Mon, Mar 04, 2024 at 09:12:38AM +0100, Geert Uytterhoeven wrote: > >

[PATCH v2] drm: renesas: shmobile: Call drm_helper_force_disable_all() at shutdown time

2024-03-04 Thread Geert Uytterhoeven
eady calls drm_atomic_helper_shutdown] Signed-off-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart --- v2: - Add Reviewed-by. Tested on Atmark Techno Armadillo-800-EVA. --- drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/d

Re: [PATCH 1/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-03-04 Thread Geert Uytterhoeven
Hi Maxime, On Mon, Mar 4, 2024 at 10:15 AM Maxime Ripard wrote: > On Mon, Mar 04, 2024 at 09:12:38AM +0100, Geert Uytterhoeven wrote: > > On Sun, Mar 3, 2024 at 10:30 AM Geert Uytterhoeven > > wrote: > > > On Sun, Mar 3, 2024 at 3:30 AM Randy Dunlap wrote: > >

Re: [PATCH] drm/sun4i: hdmi: Fix u64 div on 32bit arch

2024-03-04 Thread Geert Uytterhoeven
13a ("drm/sun4i: hdmi: Consolidate atomic_check and > mode_valid") > Reported-by: Geert Uytterhoeven > Reported-by: Naresh Kamboju > Closes: > https://lore.kernel.org/r/CA+G9fYvG9KE15PGNoLu+SBVyShe+u5HBLQ81+kK9Zop6u=y...@mail.gmail.com/ > Reported-by: kernel test robot &

Re: [PATCH 1/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-03-04 Thread Geert Uytterhoeven
On Sun, Mar 3, 2024 at 10:30 AM Geert Uytterhoeven wrote: > On Sun, Mar 3, 2024 at 3:30 AM Randy Dunlap wrote: > > On 3/2/24 14:10, Guenter Roeck wrote: > > > While checkpatch is indeed of arguable value, I think it would help a > > > lot not having to bother a

Re: [PATCH 1/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-03-03 Thread Geert Uytterhoeven
mail when builds get broken, and when they get fixed again. I receive such emails for the m68k builds. I have the feeling this is not used up to its full potential yet. My initial plan with the "Build regressions/improvements in ..." emails [1] was to fully automate this, and enabl

Re: [DO NOT MERGE v6 34/37] sh: Add dtbs target support.

2024-02-27 Thread Geert Uytterhoeven
On Tue, Jan 9, 2024 at 9:24 AM Yoshinori Sato wrote: > Signed-off-by: Yoshinori Sato Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with techni

Re: [DO NOT MERGE v6 13/37] dt-bindings: clock: sh7750-cpg: Add renesas,sh7750-cpg header.

2024-02-27 Thread Geert Uytterhoeven
7750-cpg.h > @@ -0,0 +1,26 @@ > +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > + * > + * Copyright 2023 Yoshinori Sato > + */ > + > +#ifndef __DT_BINDINGS_CLOCK_SH7750_H__ > +#define __DT_BINDINGS_CLOCK_SH7750_H__ > + > +#define SH7750_CPG_PLLOUT 0 >

Re: [DO NOT MERGE v6 15/37] clk: renesas: Add SH7750/7751 CPG Driver

2024-02-27 Thread Geert Uytterhoeven
quot; here, and return an error code instead? ... > + return cpg; > + > +unmap_clkstp00: > + iounmap(cpg->clkstp00); > +unmap_frqcr: > + iounmap(cpg->frqcr); > +cpg_free: > + kfree(cpg); > + return ERR_PTR(ret); > +} > + > +static void __init sh7750_cpg_init(struct device_node *node) > +{ > + cpg_data = sh7750_cpg_setup(node, cpg_feature[CPG_SH7750]); > + if (IS_ERR(cpg_data)) > + cpg_data = NULL; ... then all cpg_data handling can be removed here... > +} > +static int sh7750_cpg_probe(struct platform_device *pdev) > +{ > + u32 feature; > + > + if (cpg_data) > + return 0; > + feature = *(u32 *)of_device_get_match_data(>dev); > + cpg_data = sh7750_cpg_setup(pdev->dev.of_node, feature); > + if (IS_ERR(cpg_data)) > + return PTR_ERR(cpg_data); > + return 0; ... and this can be simplified to return sh7750_cpg_setup(...); > +} Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds

Re: [DO NOT MERGE v6 33/37] sh: j2_mimas_v2.dts update

2024-02-27 Thread Geert Uytterhoeven
Hi Sato-san, On Tue, Jan 9, 2024 at 9:24 AM Yoshinori Sato wrote: > Signed-off-by: Yoshinori Sato Thanks for your patch! Please enhance the one-line summary, e.g. sh: j2_mimas_v2: Update CPU compatible value For the actual changes: Reviewed-by: Geert Uytterhoeven Gr{oetje,eetin

Re: [DO NOT MERGE v6 28/37] dt-bindings: soc: renesas: sh: Add SH7751 based target

2024-02-27 Thread Geert Uytterhoeven
> + > +additionalProperties: true > + > +... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds

Re: [DO NOT MERGE v6 14/37] clk: Compatible with narrow registers

2024-02-27 Thread Geert Uytterhoeven
DIANBIT(2) > +#define CLK_GATE_REG_8BIT BIT(3) > +#define CLK_GATE_REG_16BIT BIT(4) > > extern const struct clk_ops clk_gate_ops; > struct clk_hw *__clk_hw_register_gate(struct device *dev, The rest LGTM. Gr{oetje,eeting}s,

Re: [PATCH 2/6] arm64: dts: renesas: r8a774a1: Enable GPU

2024-02-27 Thread Geert Uytterhoeven
gitlab.freedesktop.org/imagination/linux/-/blob/b3506b8bc45ed6d4005eb32a994df0e33d6613f1/arch/arm64/boot/dts/mediatek/mt8173.dtsi#L993-1006 [2] https://gitlab.freedesktop.org/imagination/linux/-/blob/b3506b8bc45ed6d4005eb32a994df0e33d6613f1/Documentation/devicetree/bindings/gpu/img,powervr.yaml Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds

Re: [PATCH 1/6] dt-bindings: gpu: powervr-rogue: Add PowerVR support for some Renesas GPUs

2024-02-27 Thread Geert Uytterhoeven
On Tue, Feb 27, 2024 at 9:09 AM Geert Uytterhoeven wrote: > On Tue, Feb 27, 2024 at 8:48 AM Geert Uytterhoeven > wrote: > > On Tue, Feb 27, 2024 at 4:46 AM Adam Ford wrote: > > > Update the binding to add support for various Renesas SoC's with PowerVR > > >

Re: [PATCH 6/6] arm64: dts: renesas: r8a77961: Enable GPU

2024-02-27 Thread Geert Uytterhoeven
v1.fw > powervr fd00.gpu: [drm] FW version v1.0 (build 6513336 OS) > > Signed-off-by: Adam Ford Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations

Re: [PATCH 5/6] arm64: dts: renesas: r8a77960: Enable GPU

2024-02-27 Thread Geert Uytterhoeven
nitialized powervr 1.0.0 20230904 for fd00.gpu on minor 1 Reviewed-by: Geert Uytterhoeven Tested-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technic

Re: [PATCH 4/6] arm64: dts: renesas: r8a77951: Enable GPU

2024-02-27 Thread Geert Uytterhoeven
ersion v1.0 (build 6538781 OS) [drm] Initialized powervr 1.0.0 20230904 for fd00.gpu on minor 1 > > Signed-off-by: Adam Ford Tested-by: Geert Uytterhoeven > --- a/arch/arm64/boot/dts/renesas/r8a77951.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77951.dtsi > @@ -2771,6 +277

Re: [PATCH 3/6] arm64: dts: renesas: r8a774e1: Enable GPU

2024-02-27 Thread Geert Uytterhoeven
powervr fd00.gpu: [drm] FW version v1.0 (build 6513336 OS) > > Signed-off-by: Adam Ford Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations

Re: [PATCH 2/6] arm64: dts: renesas: r8a774a1: Enable GPU

2024-02-27 Thread Geert Uytterhoeven
powervr fd00.gpu: [drm] FW version v1.0 (build 6513336 OS) > > Signed-off-by: Adam Ford Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations

Re: [PATCH 1/6] dt-bindings: gpu: powervr-rogue: Add PowerVR support for some Renesas GPUs

2024-02-27 Thread Geert Uytterhoeven
Hi Adam, On Tue, Feb 27, 2024 at 8:48 AM Geert Uytterhoeven wrote: > On Tue, Feb 27, 2024 at 4:46 AM Adam Ford wrote: > > Update the binding to add support for various Renesas SoC's with PowerVR > > Rogue GX6250 and GX6650 GPUs. These devices only need one clock, so updat

Re: [PATCH 1/6] dt-bindings: gpu: powervr-rogue: Add PowerVR support for some Renesas GPUs

2024-02-27 Thread Geert Uytterhoeven
On Tue, Feb 27, 2024 at 8:48 AM Geert Uytterhoeven wrote: > > Hi Adam, > > On Tue, Feb 27, 2024 at 4:46 AM Adam Ford wrote: > > Update the binding to add support for various Renesas SoC's with PowerVR > > Rogue GX6250 and GX6650 GPUs. These devices only need one clock,

Re: [PATCH 1/6] dt-bindings: gpu: powervr-rogue: Add PowerVR support for some Renesas GPUs

2024-02-26 Thread Geert Uytterhoeven
-gpu > + - renesas,r8a77951-gpu > + - renesas,r8a77960-gpu > + - renesas,r8a77961-gpu Please preserve alphabetical sort order. > then: >properties: > clocks: > -- > 2.43.0 Gr{oetje,eeting}s,

Re: [DO NOT MERGE v6 08/37] clocksource: sh_tmu: CLOCKSOURCE support.

2024-02-26 Thread Geert Uytterhoeven
tmu->clk = clk_get(>pdev->dev, "fck"); > + else > + tmu->clk = of_clk_get(np, 0); You can use of_clk_get() unconditionally. > if (IS_ERR(tmu->clk)) { > - dev_err(>pdev->dev, "cannot get clock\n"); > +

Re: [DO NOT MERGE v6 02/37] sh: Kconfig unified OF supported targets.

2024-02-26 Thread Geert Uytterhoeven
; + bool "General Open Firmware boards" > + select SH_DEVICE_TREE > + select CLKSRC_JCORE_PIT if CPU_J2 > + select JCORE_AIC if CPU_J2 Please move these selects to CPU_J2 instead... > + select HAVE_PCI if CPU_SUBTYPE_SH7751R ... and this to CPU_SUBT

Re: [PATCH 1/6] drm/tests/drm_buddy: fix 32b build

2024-02-26 Thread Geert Uytterhoeven
; >>>>>>> Simplest is to just switch over to u32 here. Also make print > >>>>>>> modifiers > >>>>>>> consistent with that. > >>>>>>> > >>>>>>> Fixes: a64056bb5a32 ("drm/te

Re: [PATCH] drm: renesas: rz-du: Fix redefinition errors related to rzg2l_du_vsp_*()

2024-02-22 Thread Geert Uytterhoeven
Hi Biju, On Thu, Feb 22, 2024 at 10:56 AM Biju Das wrote: > Fix the redefinition errors for the below functions on x86 by replacing Not just on x86, I assume? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.

Re: linux-next: build failure after merge of the drm-misc tree

2024-02-22 Thread Geert Uytterhoeven
~~ > > > > Caused by commit > > > > 768e9e61b3b9 ("drm: renesas: Add RZ/G2L DU Support") > > > > I have used the drm-misc tree from next-20240221 for today. > > I will send an incremental patch to fix this build error with x86 on drm-next

Re: Build regressions/improvements in v6.8-rc5

2024-02-19 Thread Geert Uytterhoeven
On Mon, 19 Feb 2024, Geert Uytterhoeven wrote: JFYI, when comparing v6.8-rc5[1] to v6.8-rc4[3], the summaries are: - build errors: +6/-14 + /kisskb/src/arch/arm64/include/asm/jump_label.h: error: invalid 'asm': invalid operand: => 25:2 arm64-gcc5/arm64-allmodconfig + /kisskb/src/a

Re: Re: [PULL] drm-misc-fixes

2024-02-16 Thread Geert Uytterhoeven
Hi Maxime, Dave, On Thu, Feb 15, 2024 at 5:45 PM Geert Uytterhoeven wrote: > On Thu, Feb 15, 2024 at 5:09 PM Maxime Ripard wrote: > On Thu, Feb 15, 2024 at 01:41:24PM +0100, Geert Uytterhoeven wrote: > > > On Thu, 15 Feb 2024, Maxime Ripard wrote: > > > > Matthew

Re: [PATCH v2] drm/imagination: DRM_POWERVR should depend on ARCH_K3

2024-02-15 Thread Geert Uytterhoeven
Hi Maxime, On Thu, Feb 15, 2024 at 5:18 PM Maxime Ripard wrote: > On Thu, Feb 15, 2024 at 01:50:09PM +0100, Geert Uytterhoeven wrote: > > Using the Imagination Technologies PowerVR Series 6 GPU requires a > > proprietary firmware image, which is currently only available for Texas

Re: Re: [PULL] drm-misc-fixes

2024-02-15 Thread Geert Uytterhoeven
Hi Maxime, On Thu, Feb 15, 2024 at 5:09 PM Maxime Ripard wrote: On Thu, Feb 15, 2024 at 01:41:24PM +0100, Geert Uytterhoeven wrote: > > On Thu, 15 Feb 2024, Maxime Ripard wrote: > > > Matthew Auld (1): > > > drm/tests/drm_buddy: add alloc_contiguous test >

[PATCH v2] drm: Spelling s/hardward/hardware/g

2024-02-15 Thread Geert Uytterhoeven
Fix misspellings of "hardware". Signed-off-by: Geert Uytterhoeven Reviewed-by: Neil Armstrong Reviewed-by: Thomas Zimmermann --- v2: - Add Reviewed-by. --- include/drm/drm_bridge.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/drm_bridge.h b/i

[PATCH v2] drm/imagination: DRM_POWERVR should depend on ARCH_K3

2024-02-15 Thread Geert Uytterhoeven
K3 Multicore SoC support. Fixes: 4babef0708656c54 ("drm/imagination: Add skeleton PowerVR driver") Signed-off-by: Geert Uytterhoeven Reviewed-by: Javier Martinez Canillas Reviewed-by: Nishanth Menon --- v2: - Add Reviewed-by, - Clarify the firmware dependency. --- drive

Re: [PULL] drm-misc-fixes

2024-02-15 Thread Geert Uytterhoeven
ndefined! Reverting commit a64056bb5a3215bd ("drm/tests/drm_buddy: add alloc_contiguous test") fixes the issue. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversa

Re: [PATCH] ARM: multi_v7_defconfig: Enable BACKLIGHT_CLASS_DEVICE

2024-02-02 Thread Geert Uytterhoeven
ulti_v7_defconfig. > > Signed-off-by: Marek Szyprowski Sounds like a good interim solution. Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with techn

[PATCH] fbdev: Restrict FB_SH_MOBILE_LCDC to SuperH

2024-01-31 Thread Geert Uytterhoeven
, using DT. Suggested-by: Arnd Bergmann Signed-off-by: Geert Uytterhoeven --- Commit f402f7a02af6956d is in staging-next (next-20240129 and later). --- drivers/video/fbdev/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kco

Re: Build regressions/improvements in v6.8-rc1

2024-01-23 Thread Geert Uytterhoeven
On Tue, 23 Jan 2024, Geert Uytterhoeven wrote: Below is the list of build error/warning regressions/improvements in v6.8-rc1[1] compared to v6.7[2]. Summarized: - build errors: +68/-18 - build warnings: +129/-1487 Happy fixing! ;-) Thanks to the linux-next team for providing the build

[PATCH] fbcon: Fix incorrect printed function name in fbcon_prepare_logo()

2024-01-22 Thread Geert Uytterhoeven
If the boot logo does not fit, a message is printed, including a wrong function name prefix. Instead of correcting the function name (or using __func__), just use "fbcon", like is done in several other messages. While at it, modernize the call by switching to pr_info(). Signed-off

Re: [PATCH 19/45] tty: vt: make init parameter of consw::con_init() a bool

2024-01-18 Thread Geert Uytterhoeven
d vgacon_init(struct vc_data *c, bool init) > { > struct uni_pagedict *p; > Below, there is one more line to update: -/* set dimensions manually if init != 0 since vc_resize() will fail */ +/* set dimensions manually if init is true since vc_resize() will fail */ Wi

Re: [DO NOT MERGE v6 17/37] dt-bindings: interrupt-controller: renesas,sh7751-intc: Add json-schema

2024-01-17 Thread Geert Uytterhoeven
ently, we are targeting only the 7751, but in the future we plan to > handle all SoCs. > Is it better to differentiate SoC only by compatible? Yes, it is better to differentiate SoC only by compatible value. When you describe all differences explicitly using properties, you might discove

Re: [DO NOT MERGE v6 01/37] sh: passing FDT address to kernel startup.

2024-01-15 Thread Geert Uytterhoeven
On Tue, Jan 9, 2024 at 9:23 AM Yoshinori Sato wrote: > R4 is caller saved in SH ABI. > Save it so it doesn't get corrupted until it's needed for initialization. > > Signed-off-by: Yoshinori Sato My Reviewed-by: Geert Uytterhoeven on v3 is still valid. Gr{oe

Re: [DO NOT MERGE v6 25/37] dt-bindings: vendor-prefixes: Add iodata

2024-01-15 Thread Geert Uytterhoeven
On Tue, Jan 9, 2024 at 9:24 AM Yoshinori Sato wrote: > Add IO DATA DEVICE INC. > https://www.iodata.com/ > > Signed-off-by: Yoshinori Sato My Reviewed-by: Geert Uytterhoeven on v3 is still valid. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven --

Re: [DO NOT MERGE v6 09/37] dt-bindings: timer: renesas, tmu: add renesas, tmu-sh7750

2024-01-15 Thread Geert Uytterhoeven
Once that patch has been applied, adding support for sh7751 involves adding just two new lines. [1] "PATCH] dt-bindings: timer: renesas,tmu: Document input capture interrupt" https://lore.kernel.org/r/fb1e38c93e62221f94304edd980a2fb79c1f2995.1705325608.git.

Re: [DO NOT MERGE v6 22/37] dt-bindings: display: smi,sm501: SMI SM501 binding json-schema

2024-01-15 Thread Geert Uytterhoeven
80, 96, 112, 128, 144, 160, 176, 192, 208, > 224, 240] > + > + xc: > +$ref: /schemas/types.yaml#/definitions/string > +description: Xscale clock input select. > + items: > + enum: > +- internal-pll > +- hclk

Re: [DO NOT MERGE v6 21/37] dt-bindings: serial: renesas, scif: Add scif-sh7751.

2024-01-15 Thread Geert Uytterhoeven
On Tue, Jan 9, 2024 at 9:24 AM Yoshinori Sato wrote: > Add Renesas SH7751 SCIF. > > Signed-off-by: Yoshinori Sato Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In

Re: [DO NOT MERGE v6 26/37] dt-bindings: vendor-prefixes: Add smi

2024-01-10 Thread Geert Uytterhoeven
ry here > that I am unaware of. See Documentation/devicetree/bindings/display/sm501fb.txt The stock ticker is "SIMO", though. https://www.nasdaq.com/market-activity/stocks/simo Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -

Re: [PATCH 08/22] [v2] arch: consolidate arch_irq_work_raise prototypes

2024-01-10 Thread Geert Uytterhoeven
> Signed-off-by: Arnd Bergmann Tested-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm tal

Re: [PATCH] vt: remove superfluous CONFIG_HW_CONSOLE

2024-01-08 Thread Geert Uytterhoeven
G_VT and remove > CONFIG_HW_CONSOLE. > > Signed-off-by: Lukas Bulwahn Reviewed-by: Geert Uytterhoeven > arch/m68k/amiga/config.c | 2 +- Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@

Re: [PATCH v15 3/5] drm: renesas: Add RZ/G2L DU Support

2023-12-13 Thread Geert Uytterhoeven
h DRM and the DU. Kieran? > I won't have time soon, and this driver has been blocked for way too > long due to that :-S Indeed... [deleted 278 lines of needlessly quoted text] Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@

Re: [DO NOT MERGE v5 09/37] dt-bindings: timer: renesas, tmu: add renesas, tmu-sh7750

2023-12-05 Thread Geert Uytterhoeven
- renesas,tmu-r8a774b1 # RZ/G2N The rest LGTM. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I

Re: [DO NOT MERGE v5 20/37] serial: sh-sci: fix SH4 OF support.

2023-12-05 Thread Geert Uytterhoeven
Hi Sato-san, Thanks for your patch! On Tue, Dec 5, 2023 at 10:46 AM Yoshinori Sato wrote: > - fix earlycon name. > - fix earlyprintk hung (NULL pointer reference). - fix SERIAL_SH_SCI_EARLYCON enablement > Signed-off-by: Yoshinori Sato Reviewed-by: Geert Uytterhoeven > --- a

Re: [DO NOT MERGE v5 24/37] dt-binding: sh: cpus: Add SH CPUs json-schema

2023-12-05 Thread Geert Uytterhoeven
lt;1>; > +#size-cells = <0>; > + > +cpu: cpu@0 { > +compatible = "renesas,sh4", "renesas,sh2"; > +device_type = "cpu"; > +reg = <0>; > +clocks = < SH7750_CPG_ICK>; > +

Re: [DO NOT MERGE v5 17/37] dt-bindings: interrupt-controller: renesas,sh7751-intc: Add json-schema

2023-12-05 Thread Geert Uytterhoeven
.yaml > +examples: > + - | > +#include make dt_binding_check: fatal error: dt-bindings/interrupt-controller/sh_intc.h: No such file or directory sh7751-intc.h Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

Re: [DO NOT MERGE v5 21/37] dt-bindings: serial: renesas, scif: Add scif-sh7751.

2023-12-05 Thread Geert Uytterhoeven
gt;- const: renesas,scif # generic SCIF compatible UART Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I

  1   2   3   4   5   6   7   8   9   10   >