[PATCH 2/2] drm/panel: panel-simple: add bus_format and connector_type to cdtech_s070wv95_ct16 panel

2021-12-10 Thread Giulio Benetti
Add bus_format and connector_type to cdtech_s070wv95_ct16 panel. Signed-off-by: Giulio Benetti --- drivers/gpu/drm/panel/panel-simple.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index c8ad713865cb

[PATCH 1/2] drm/panel: panel-simple: add bus_format and connector_type to cdtech_s043wq26h_ct7 panel

2021-12-10 Thread Giulio Benetti
Add bus_format and connector_type to cdtech_s043wq26h_ct7 panel. Signed-off-by: Giulio Benetti --- drivers/gpu/drm/panel/panel-simple.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index eb475a3a774b

Re: [PATCH v3 0/9] Add 4 Jenson simple panels

2021-10-05 Thread Giulio Benetti
Hello All, kindly pinging this patchset, I've forgotten to set it Unarchived, now it is: https://patchwork.kernel.org/project/dri-devel/list/?series=459931 Best regards -- Giulio Benetti Benetti Engineering sas On 5/2/21 10:50 PM, Giulio Benetti wrote: Hello Thierry, I've seen

Re: [PATCH v3 0/9] Add 4 Jenson simple panels

2021-05-02 Thread Giulio Benetti
[2]: https://patchwork.kernel.org/project/dri-devel/list/ Best regards -- Giulio Benetti Benetti Engineering sas On 4/2/21 1:17 AM, Giulio Benetti wrote: This patchset introduce Jenson vendor and add 4 of its panels to panel-simple driver. --- V2-V3: * changed my SoB and authorship * added some forgo

[PATCH v3 9/9] drm/panel: simple: add Jenson JT60250-02

2021-04-01 Thread Giulio Benetti
This patch adds support for Jenson JT60250-02 1024x600 10.1" panel to DRM simple panel driver. Signed-off-by: Giulio Benetti --- drivers/gpu/drm/panel/panel-simple.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/dr

[PATCH v3 2/9] dt-bindings: display/panel: add Jenson JT60245-01

2021-04-01 Thread Giulio Benetti
Add DT binding for "jenson,jt60245-01". Signed-off-by: Giulio Benetti --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetre

[PATCH v3 1/9] dt-bindings: Add Jenson Display vendor prefix

2021-04-01 Thread Giulio Benetti
Update Documentation/devicetree/bindings/vendor-prefixes.yaml to include "jenson" as a vendor prefix for "Jenson Display". Company website: http://www.jensondisplay.com/ Signed-off-by: Giulio Benetti Acked-by: Rob Herring --- Documentation/devicetree/bindings/vendor-pre

[PATCH v3 5/9] dt-bindings: display/panel: add Jenson JT60250-02

2021-04-01 Thread Giulio Benetti
Add DT binding for "jenson,jt60250-02". Signed-off-by: Giulio Benetti Acked-by: Rob Herring --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/panel-simp

[PATCH v3 7/9] drm/panel: simple: add Jenson JT60248-01

2021-04-01 Thread Giulio Benetti
This patch adds support for Jenson JT60248-01 480x272 4.3" panel to DRM simple panel driver. Signed-off-by: Giulio Benetti --- drivers/gpu/drm/panel/panel-simple.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/dr

[PATCH v3 8/9] drm/panel: simple: add Jenson JT60249-01

2021-04-01 Thread Giulio Benetti
This patch adds support for Jenson JT60249-01 800x480 5" panel to DRM simple panel driver. Signed-off-by: Giulio Benetti --- drivers/gpu/drm/panel/panel-simple.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/driver

[PATCH v3 0/9] Add 4 Jenson simple panels

2021-04-01 Thread Giulio Benetti
This patchset introduce Jenson vendor and add 4 of its panels to panel-simple driver. --- V2-V3: * changed my SoB and authorship * added some forgotten acked-by * fixed alpha-numeric order on adding bindings --- Giulio Benetti (9): dt-bindings: Add Jenson Display vendor prefix dt-bindings

[PATCH v3 6/9] drm/panel: simple: add Jenson JT60245-01

2021-04-01 Thread Giulio Benetti
This patch adds support for Jenson JT60245-01 800x480 7" panel to DRM simple panel driver. Signed-off-by: Giulio Benetti --- drivers/gpu/drm/panel/panel-simple.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/driver

[PATCH v3 3/9] dt-bindings: display/panel: add Jenson JT60248-01

2021-04-01 Thread Giulio Benetti
Add DT binding for "jenson,jt60248-01". Signed-off-by: Giulio Benetti Acked-by: Rob Herring --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/panel-simp

[PATCH v3 4/9] dt-bindings: display/panel: add Jenson JT60249-01

2021-04-01 Thread Giulio Benetti
Add DT binding for "jenson,jt60249-01". Signed-off-by: Giulio Benetti Acked-by: Rob Herring --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/panel-simp

Re: [PATCH 4/9] dt-bindings: display/panel: add Jenson JT60245-01

2021-03-05 Thread Giulio Benetti
Hi Rob, Il 05/03/2021 23:54, Rob Herring ha scritto: On Thu, Feb 18, 2021 at 11:54:52PM +0100, Giulio Benetti wrote: From: Giulio Benetti Add DT binding for "jenson,jt60245-01". Signed-off-by: Giulio Benetti Signed-off-by: Giulio Benetti --- .../devicetree/bindings/display/p

[PATCH v2 0/9] Add 4 Jenson simple panels

2021-03-05 Thread Giulio Benetti
From: Giulio Benetti This patchset introduce Jenson vendor and add 4 of its panels to panel-simple driver. Giulio Benetti (9): dt-bindings: Add Jenson Display vendor prefix dt-bindings: display/panel: add Jenson JT60245-01 dt-bindings: display/panel: add Jenson JT60248-01 dt-bindings

[PATCH v2 9/9] drm/panel: simple: add Jenson JT60250-02

2021-03-05 Thread Giulio Benetti
From: Giulio Benetti This patch adds support for Jenson JT60250-02 1024x600 10.1" panel to DRM simple panel driver. Signed-off-by: Giulio Benetti --- drivers/gpu/drm/panel/panel-simple.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/drivers/gpu/drm/

[PATCH v2 6/9] drm/panel: simple: add Jenson JT60245-01

2021-03-05 Thread Giulio Benetti
From: Giulio Benetti This patch adds support for Jenson JT60245-01 800x480 7" panel to DRM simple panel driver. Signed-off-by: Giulio Benetti --- drivers/gpu/drm/panel/panel-simple.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/drivers/gpu/drm/panel/

[PATCH v2 3/9] dt-bindings: display/panel: add Jenson JT60248-01

2021-03-05 Thread Giulio Benetti
From: Giulio Benetti Add DT binding for "jenson,jt60248-01". Signed-off-by: Giulio Benetti --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/panel-simp

[PATCH v2 8/9] drm/panel: simple: add Jenson JT60249-01

2021-03-05 Thread Giulio Benetti
From: Giulio Benetti This patch adds support for Jenson JT60249-01 800x480 5" panel to DRM simple panel driver. Signed-off-by: Giulio Benetti --- drivers/gpu/drm/panel/panel-simple.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/drivers/gpu/drm/panel/

[PATCH v2 7/9] drm/panel: simple: add Jenson JT60248-01

2021-03-05 Thread Giulio Benetti
From: Giulio Benetti This patch adds support for Jenson JT60248-01 480x272 4.3" panel to DRM simple panel driver. Signed-off-by: Giulio Benetti --- drivers/gpu/drm/panel/panel-simple.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/drivers/gpu/drm/panel/

[PATCH v2 5/9] dt-bindings: display/panel: add Jenson JT60250-02

2021-03-05 Thread Giulio Benetti
From: Giulio Benetti Add DT binding for "jenson,jt60250-02". Signed-off-by: Giulio Benetti --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/panel-simp

[PATCH v2 4/9] dt-bindings: display/panel: add Jenson JT60249-01

2021-03-05 Thread Giulio Benetti
From: Giulio Benetti Add DT binding for "jenson,jt60249-01". Signed-off-by: Giulio Benetti --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/panel-simp

[PATCH v2 2/9] dt-bindings: display/panel: add Jenson JT60245-01

2021-03-05 Thread Giulio Benetti
From: Giulio Benetti Add DT binding for "jenson,jt60245-01". Signed-off-by: Giulio Benetti --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/panel-simp

[PATCH v2 1/9] dt-bindings: Add Jenson Display vendor prefix

2021-03-05 Thread Giulio Benetti
From: Giulio Benetti Update Documentation/devicetree/bindings/vendor-prefixes.yaml to include "jenson" as a vendor prefix for "Jenson Display". Company website: http://www.jensondisplay.com/ Signed-off-by: Giulio Benetti --- Documentation/devicetree/bindings/vendor-pre

[PATCH 8/9] drm/panel: simple: add Jenson JT60249-01

2021-02-18 Thread Giulio Benetti
From: Giulio Benetti This patch adds support for Jenson JT60249-01 800x480 5" panel to DRM simple panel driver. Signed-off-by: Giulio Benetti Signed-off-by: Giulio Benetti --- drivers/gpu/drm/panel/panel-simple.c | 27 +++ 1 file changed, 27 insertions(+) diff

[PATCH 0/9] Add 4 Jenson simple panels

2021-02-18 Thread Giulio Benetti
This patchset introduce Jenson vendor and add 4 of its panels to panel-simple driver. Giulio Benetti (9): dt-bindings: Add Jenson Display vendor prefix dt-bindings: display/panel: add Jenson JT60248-01 dt-bindings: display/panel: add Jenson JT60249-01 dt-bindings: display/panel: add

[PATCH 9/9] drm/panel: simple: add Jenson JT60250-02

2021-02-18 Thread Giulio Benetti
From: Giulio Benetti This patch adds support for Jenson JT60250-02 1024x600 10.1" panel to DRM simple panel driver. Signed-off-by: Giulio Benetti Signed-off-by: Giulio Benetti --- drivers/gpu/drm/panel/panel-simple.c | 27 +++ 1 file changed, 27 insertions(+)

[PATCH 3/9] dt-bindings: display/panel: add Jenson JT60249-01

2021-02-18 Thread Giulio Benetti
From: Giulio Benetti Add DT binding for "jenson,jt60249-01". Signed-off-by: Giulio Benetti Signed-off-by: Giulio Benetti --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/dis

[PATCH 2/9] dt-bindings: display/panel: add Jenson JT60248-01

2021-02-18 Thread Giulio Benetti
From: Giulio Benetti Add DT binding for "jenson,jt60248-01". Signed-off-by: Giulio Benetti Signed-off-by: Giulio Benetti --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/dis

[PATCH 5/9] dt-bindings: display/panel: add Jenson JT60250-02

2021-02-18 Thread Giulio Benetti
From: Giulio Benetti Add DT binding for "jenson,jt60250-02". Signed-off-by: Giulio Benetti Signed-off-by: Giulio Benetti --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/dis

[PATCH 7/9] drm/panel: simple: add Jenson JT60248-01

2021-02-18 Thread Giulio Benetti
From: Giulio Benetti This patch adds support for Jenson JT60248-01 480x272 4.3" panel to DRM simple panel driver. Signed-off-by: Giulio Benetti Signed-off-by: Giulio Benetti --- drivers/gpu/drm/panel/panel-simple.c | 27 +++ 1 file changed, 27 insertions(+)

[PATCH 6/9] drm/panel: simple: add Jenson JT60245-01

2021-02-18 Thread Giulio Benetti
From: Giulio Benetti This patch adds support for Jenson JT60245-01 800x480 7" panel to DRM simple panel driver. Signed-off-by: Giulio Benetti Signed-off-by: Giulio Benetti --- drivers/gpu/drm/panel/panel-simple.c | 27 +++ 1 file changed, 27 insertions(+) diff

[PATCH 1/9] dt-bindings: Add Jenson Display vendor prefix

2021-02-18 Thread Giulio Benetti
From: Giulio Benetti Update Documentation/devicetree/bindings/vendor-prefixes.yaml to include "jenson" as a vendor prefix for "Jenson Display". Company website: http://www.jensondisplay.com/ Signed-off-by: Giulio Benetti Signed-off-by: Giulio Benetti --- Documentation

[PATCH 4/9] dt-bindings: display/panel: add Jenson JT60245-01

2021-02-18 Thread Giulio Benetti
From: Giulio Benetti Add DT binding for "jenson,jt60245-01". Signed-off-by: Giulio Benetti Signed-off-by: Giulio Benetti --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/dis

Re: [PATCH v3] drm/sun4i: tcon: fix inverted DCLK polarity

2021-01-14 Thread Giulio Benetti
On 1/13/21 10:42 AM, Maxime Ripard wrote: Hi, On Mon, Jan 11, 2021 at 06:46:16PM +0100, Giulio Benetti wrote: From: Giulio Benetti During commit 88bc4178568b ("drm: Use new DRM_BUS_FLAG_*_(DRIVE|SAMPLE)_(POS|NEG)EDGE flags") DRM_BUS_FLAG_* macros have been changed to avoid ambiguit

Re: [PATCH v5] drm/sun4i: tcon: fix inverted DCLK polarity

2021-01-14 Thread Giulio Benetti
Hi Marjan, On 1/14/21 8:58 AM, Marjan Pascolo wrote: Hi Giulio, You did a typo Il 13/01/2021 17:05, Giulio Benetti ha scritto: From: Giulio Benetti During commit 88bc4178568b ("drm: Use new DRM_BUS_FLAG_*_(DRIVE|SAMPLE)_(POS|NEG)EDGE flags") DRM_BUS_FLAG_* macros have been change

[PATCH v6] drm/sun4i: tcon: fix inverted DCLK polarity

2021-01-14 Thread Giulio Benetti
From: Giulio Benetti During commit 88bc4178568b ("drm: Use new DRM_BUS_FLAG_*_(DRIVE|SAMPLE)_(POS|NEG)EDGE flags") DRM_BUS_FLAG_* macros have been changed to avoid ambiguity but just because of this ambiguity previous DRM_BUS_FLAG_PIXDATA_(POS/NEG)EDGE were used meaning _SAMPLE_ n

[PATCH v5] drm/sun4i: tcon: fix inverted DCLK polarity

2021-01-14 Thread Giulio Benetti
From: Giulio Benetti During commit 88bc4178568b ("drm: Use new DRM_BUS_FLAG_*_(DRIVE|SAMPLE)_(POS|NEG)EDGE flags") DRM_BUS_FLAG_* macros have been changed to avoid ambiguity but just because of this ambiguity previous DRM_BUS_FLAG_PIXDATA_(POS/NEG)EDGE were used meaning _SAMPLE_ n

[PATCH v4] drm/sun4i: tcon: fix inverted DCLK polarity

2021-01-14 Thread Giulio Benetti
From: Giulio Benetti During commit 88bc4178568b ("drm: Use new DRM_BUS_FLAG_*_(DRIVE|SAMPLE)_(POS|NEG)EDGE flags") DRM_BUS_FLAG_* macros have been changed to avoid ambiguity but just because of this ambiguity previous DRM_BUS_FLAG_PIXDATA_(POS/NEG)EDGE were used meaning _SAMPLE_ n

[PATCH v3] drm/sun4i: tcon: fix inverted DCLK polarity

2021-01-11 Thread Giulio Benetti
From: Giulio Benetti During commit 88bc4178568b ("drm: Use new DRM_BUS_FLAG_*_(DRIVE|SAMPLE)_(POS|NEG)EDGE flags") DRM_BUS_FLAG_* macros have been changed to avoid ambiguity but just because of this ambiguity previous DRM_BUS_FLAG_PIXDATA_(POS/NEG)EDGE were used meaning _SAMPLE_ n

Re: [PATCH v2 2/2] drm/sun4i: tcon: improve DCLK polarity handling

2021-01-11 Thread Giulio Benetti
On 1/11/21 6:20 PM, Maxime Ripard wrote: On Fri, Jan 08, 2021 at 03:34:52PM +0100, Giulio Benetti wrote: Hi, On 1/8/21 10:23 AM, Maxime Ripard wrote: Hi, Thanks for those patches On Thu, Jan 07, 2021 at 03:30:32AM +0100, Giulio Benetti wrote: From: Giulio Benetti It turned out(Maxime

Re: [PATCH v2 2/2] drm/sun4i: tcon: improve DCLK polarity handling

2021-01-09 Thread Giulio Benetti
Hi, On 1/8/21 10:23 AM, Maxime Ripard wrote: Hi, Thanks for those patches On Thu, Jan 07, 2021 at 03:30:32AM +0100, Giulio Benetti wrote: From: Giulio Benetti It turned out(Maxime suggestion) that bit 26 of SUN4I_TCON0_IO_POL_REG is dedicated to invert DCLK polarity and this makes thing

Re: [PATCH v2 2/2] drm/sun4i: tcon: improve DCLK polarity handling

2021-01-09 Thread Giulio Benetti
rks everything gets easier. Best Regards Giulio Marjan Il 08/01/2021 10:23, Maxime Ripard ha scritto: Hi, Thanks for those patches On Thu, Jan 07, 2021 at 03:30:32AM +0100, Giulio Benetti wrote: From: Giulio Benetti It turned out(Maxime suggestion) that bit 26 of SUN4I_TCON0_IO_POL_REG is

[PATCH v2 2/2] drm/sun4i: tcon: improve DCLK polarity handling

2021-01-07 Thread Giulio Benetti
From: Giulio Benetti It turned out(Maxime suggestion) that bit 26 of SUN4I_TCON0_IO_POL_REG is dedicated to invert DCLK polarity and this makes thing really easier than before. So let's handle DCLK polarity by adding SUN4I_TCON0_IO_POL_DCLK_POSITIVE as bit 26 and activating according

[PATCH v2 0/2] drm/sun4i: fix DCLK and improve its handling

2021-01-07 Thread Giulio Benetti
From: Giulio Benetti First patch is a tested by me fix, while the second need testing to understand if it works correctly with any sunxi SoC with DE peripheral. Already tested SoCs are: - A20 - A33 Need testing: - A10 - A10s - A13 Giulio Benetti (2): drm/sun4i: tcon: fix inverted DCLK

[PATCH v2 1/2] drm/sun4i: tcon: fix inverted DCLK polarity

2021-01-07 Thread Giulio Benetti
From: Giulio Benetti During commit 88bc4178568b ("drm: Use new DRM_BUS_FLAG_*_(DRIVE|SAMPLE)_(POS|NEG)EDGE flags") DRM_BUS_FLAG_* macros have been changed to avoid ambiguity but just because of this ambiguity previous DRM_BUS_FLAG_PIXDATA_(POS/NEG)EDGE were used meaning _SAMPLE_ n

[PATCH 2/2] drm/sun4i: tcon: improve DCLK polarity handling

2021-01-06 Thread Giulio Benetti
for all the other signals. Cc: Maxime Ripard Signed-off-by: Giulio Benetti --- drivers/gpu/drm/sun4i/sun4i_tcon.c | 20 +--- drivers/gpu/drm/sun4i/sun4i_tcon.h | 1 + 2 files changed, 2 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c b/drivers

[PATCH 0/2] drm/sun4i: fix DCLK and improve its handling

2021-01-06 Thread Giulio Benetti
First patch is a tested by me fix, while the second need testing to understand if it works correctly with any sunxi SoC with DE peripheral. Already tested SoCs are: - A20 - A33 Need testing: - A10 - A10s - A13 Giulio Benetti (2): drm/sun4i: tcon: fix inverted DCLK polarity drm/sun4i: tcon

[PATCH 1/2] drm/sun4i: tcon: fix inverted DCLK polarity

2021-01-06 Thread Giulio Benetti
ase to fix it. Signed-off-by: Giulio Benetti --- drivers/gpu/drm/sun4i/sun4i_tcon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c b/drivers/gpu/drm/sun4i/sun4i_tcon.c index eaaf5d70e352..52598bb0fb0b 100644 --- a/drivers/gpu/drm/sun4i/su

Re: [PATCH] drm/sun4i: fix HSYNC and VSYNC polarity

2018-12-13 Thread Giulio Benetti
Il 13/12/2018 12:58, Giulio Benetti ha scritto: Il 13/12/2018 04:08, Jonathan Liu ha scritto: Hi Giulio, On Wed, 12 Dec 2018 at 04:20, Giulio Benetti wrote: Hi Jonathan, Il 11/12/2018 11:49, Jonathan Liu ha scritto: Hi Giulio, On Thu, 6 Dec 2018 at 22:00, Giulio Benetti wrote: Hi

Re: [PATCH] drm/sun4i: fix HSYNC and VSYNC polarity

2018-12-13 Thread Giulio Benetti
Il 13/12/2018 04:08, Jonathan Liu ha scritto: Hi Giulio, On Wed, 12 Dec 2018 at 04:20, Giulio Benetti wrote: Hi Jonathan, Il 11/12/2018 11:49, Jonathan Liu ha scritto: Hi Giulio, On Thu, 6 Dec 2018 at 22:00, Giulio Benetti wrote: Hi Jonathan, Il 06/12/2018 08:29, Jonathan Liu ha

Re: [PATCH] drm/sun4i: fix HSYNC and VSYNC polarity

2018-12-13 Thread Giulio Benetti
ignals using another display: "innolux,at043tn24" that has a more rounded clock frequency, so it's accepted by drm and **signals are correct**. Unfortunately I don't have your same display here to test, so I can't help you about that precise panel. Sorry. Best regards -- Giulio Benett

Re: [PATCH] drm/sun4i: fix HSYNC and VSYNC polarity

2018-12-11 Thread Giulio Benetti
Forgot to ask you, Il 11/12/2018 18:20, Giulio Benetti ha scritto: Hi Jonathan, Il 11/12/2018 11:49, Jonathan Liu ha scritto: Hi Giulio, On Thu, 6 Dec 2018 at 22:00, Giulio Benetti wrote: Hi Jonathan, Il 06/12/2018 08:29, Jonathan Liu ha scritto: Hi Giulio, On Thu, 15 Feb 2018 at 17:54

Re: [PATCH] drm/sun4i: fix HSYNC and VSYNC polarity

2018-12-11 Thread Giulio Benetti
Hi Jonathan, Il 11/12/2018 11:49, Jonathan Liu ha scritto: Hi Giulio, On Thu, 6 Dec 2018 at 22:00, Giulio Benetti wrote: Hi Jonathan, Il 06/12/2018 08:29, Jonathan Liu ha scritto: Hi Giulio, On Thu, 15 Feb 2018 at 17:54, Giulio Benetti wrote: Differently from other Lcd signals, HSYNC

Re: [PATCH] drm/sun4i: fix HSYNC and VSYNC polarity

2018-12-06 Thread Giulio Benetti
Hi Jonathan, Il 06/12/2018 08:29, Jonathan Liu ha scritto: Hi Giulio, On Thu, 15 Feb 2018 at 17:54, Giulio Benetti wrote: Differently from other Lcd signals, HSYNC and VSYNC signals result inverted if their bits are cleared to 0. Invert their settings of IO_POL register. Signed-off

Re: [PATCH 2/2] drm/sun4i: hdmi: Fix double flag assignation

2018-10-24 Thread Giulio Benetti
this. Fixes: 9c5681011a0c ("drm/sun4i: Add HDMI support") Reported-by: Dan Carpenter Signed-off-by: Maxime Ripard Reviewed-by: Giulio Benetti --- drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu

Re: [PATCH 1/2] drm/sun4i: hdmi: Fix unitialized variable

2018-10-24 Thread Giulio Benetti
; - bool is_double; + bool is_double = false; for (m = div_offset ?: 1; m < (16 + div_offset); m++) { u8 d; -- Giulio Benetti CTO MICRONOVA SRL Sede: Via A. Niedda 3 - 35010 Vigonza (PD) Tel. 049/8931563 - Fax 049/8931346 Cod.Fiscale - P.IVA 02663420285 Capit

Re: [bug report] drm/sun4i: Handle DRM_BUS_FLAG_PIXDATA_*EDGE checking if panel is used.

2018-10-11 Thread Giulio Benetti
ers if memory allocations fail but NULL if the hardware isn't there and isn't required. Yes, what you've pointed me helped me a lot to understand it. Thank you again. Best regards -- Giulio Benetti CTO MICRONOVA SRL Sede: Via A. Niedda 3 - 35010 Vigonza (PD) Tel. 049/8931563 - Fax 049/8931

[PATCH v3 2/2] drm/sun4i: tcon: prevent tcon->panel dereference if NULL

2018-10-05 Thread Giulio Benetti
If tcon->panel pointer is NULL, trying to dereference from it (i.e. tcon->panel->connector) will cause a null pointer dereference. Add tcon->panel null pointer check before calling sun4i_tcon0_mode_set_dithering(). Signed-off-by: Giulio Benetti Fixes: f11adcecbd5f ("drm

[PATCH v3 1/2] drm/sun4i: tcon: fix check of tcon->panel null pointer

2018-10-05 Thread Giulio Benetti
Since tcon->panel is a pointer returned by of_drm_find_panel() need to check if it is not NULL, hence a valid pointer. IS_ERR() instead checks return error values, not NULL pointers. Substitute "if (!IS_ERR(tcon->panel))" with "if (tcon->panel)". Signed-off-by: Giuli

Re: [PATCH v2 2/2] drm/sun4i: tcon: prevent tcon->panel dereference if null

2018-10-05 Thread Giulio Benetti
Hi, Il 04/10/2018 21:56, Maxime Ripard ha scritto: On Wed, Oct 03, 2018 at 04:24:58PM +0200, Giulio Benetti wrote: If using tcon with VGA, We don't have support for VGA at the moment. Or are you talking about using a VGA bridge? You're right, in general VGA is not the point. tcon->pa

[PATCH v2 1/2] drm/sun4i: tcon: fix check of tcon->panel null pointer

2018-10-03 Thread Giulio Benetti
panel)" as condition to check if it's a pointer not null. Signed-off-by: Giulio Benetti --- Changes V1->V2: * correct same bug for all same occurences in drm/sun4i folder drivers/gpu/drm/sun4i/sun4i_lvds.c | 4 ++-- drivers/gpu/drm/sun4i/sun4i_rgb.c | 4 ++-- drivers/gpu/drm/sun4i/

[PATCH v2 2/2] drm/sun4i: tcon: prevent tcon->panel dereference if null

2018-10-03 Thread Giulio Benetti
If using tcon with VGA, tcon->panel will be null(0), this will cause segmentation fault when trying to dereference tcon->panel->connector. Add tcon->panel null check before calling sun4i_tcon0_mode_set_dithering(). Signed-off-by: Giulio Benetti Fixes: f11adcecbd5f ("drm

Re: [PATCH 1/2] drm/sun4i: tcon: fix check of tcon->panel null pointer

2018-10-03 Thread Giulio Benetti
Il 03/10/2018 11:43, Chen-Yu Tsai ha scritto: On Wed, Oct 3, 2018 at 5:59 AM Giulio Benetti wrote: At the moment, the check of tcon->panel to be valid is wrong. IS_ERR() has been used, but that macro doesn't check if tcon->panel pointer is null or not, but check if tcon->panel is b

[PATCH 1/2] drm/sun4i: tcon: fix check of tcon->panel null pointer

2018-10-03 Thread Giulio Benetti
panel)" as condition to check if it's a pointer not null. Signed-off-by: Giulio Benetti --- drivers/gpu/drm/sun4i/sun4i_tcon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c b/drivers/gpu/drm/sun4i/sun4i_tcon.c index c78cd35a

Re: [bug report] drm/sun4i: Handle DRM_BUS_FLAG_PIXDATA_*EDGE checking if panel is used.

2018-10-03 Thread Giulio Benetti
Il 01/10/2018 11:36, Dan Carpenter ha scritto: Hello Giulio Benetti, The patch 490cda5a3c82: "drm/sun4i: Handle DRM_BUS_FLAG_PIXDATA_*EDGE checking if panel is used." from Jul 18, 2018, leads to the following static checker warning: drivers/gpu/drm/sun4i/sun4i_

Re: [bug report] drm/sun4i: Handle DRM_BUS_FLAG_PIXDATA_*EDGE checking if panel is used.

2018-10-03 Thread Giulio Benetti
Il 02/10/2018 15:26, Giulio Benetti ha scritto: Il 01/10/2018 11:36, Dan Carpenter ha scritto: Hello Giulio Benetti, The patch 490cda5a3c82: "drm/sun4i: Handle DRM_BUS_FLAG_PIXDATA_*EDGE checking if panel is used." from Jul 18, 2018, leads to the following static check

[PATCH 2/2] drm/sun4i: tcon: prevent tcon->panel dereference if null

2018-10-03 Thread Giulio Benetti
If using tcon with VGA, tcon->panel will be null(0), this will cause segmentation fault when trying to dereference tcon->panel->connector. Add tcon->panel null check before calling sun4i_tcon0_mode_set_dithering(). Signed-off-by: Giulio Benetti --- drivers/gpu/drm/sun4i/sun4i_tcon.

Re: [bug report] drm/sun4i: Handle DRM_BUS_FLAG_PIXDATA_*EDGE checking if panel is used.

2018-10-03 Thread Giulio Benetti
Il 02/10/2018 16:12, Giulio Benetti ha scritto: Il 02/10/2018 15:26, Giulio Benetti ha scritto: Il 01/10/2018 11:36, Dan Carpenter ha scritto: Hello Giulio Benetti, The patch 490cda5a3c82: "drm/sun4i: Handle DRM_BUS_FLAG_PIXDATA_*EDGE checking if panel is used." from Jul 18, 2

Re: [PATCH 1/2] drm/sun4i: tcon: fix check of tcon->panel null pointer

2018-10-02 Thread Giulio Benetti
Sorry for sending twice(and top posting), but I was not subscribed to dri-devel ML, so patchwork was not aware of these 2 patches. Best regards -- Giulio Benetti CTO MICRONOVA SRL Sede: Via A. Niedda 3 - 35010 Vigonza (PD) Tel. 049/8931563 - Fax 049/8931346 Cod.Fiscale - P.IVA 02663420285

[PATCH 1/2] drm/sun4i: tcon: fix check of tcon->panel null pointer

2018-10-02 Thread Giulio Benetti
panel)" as condition to check if it's a pointer not null. Signed-off-by: Giulio Benetti --- drivers/gpu/drm/sun4i/sun4i_tcon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c b/drivers/gpu/drm/sun4i/sun4i_tcon.c index c78cd35a

[PATCH 2/2] drm/sun4i: tcon: prevent tcon->panel dereference if null

2018-10-02 Thread Giulio Benetti
If using tcon with VGA, tcon->panel will be null(0), this will cause segmentation fault when trying to dereference tcon->panel->connector. Add tcon->panel null check before calling sun4i_tcon0_mode_set_dithering(). Signed-off-by: Giulio Benetti --- drivers/gpu/drm/sun4i/sun4i_tcon.

Re: [PATCH 0/5] Add CDTech 4.3" and 7" to panel-simple

2018-09-27 Thread Giulio Benetti
Hello Thierry, Il 27/09/2018 13:59, Thierry Reding ha scritto: On Tue, Jul 31, 2018 at 01:11:12AM +0200, Giulio Benetti wrote: Add CDTech 4.3" S043WQ26H-CT7 support Add CDTech 7" S070WV95-CT16 support Giulio Benetti (5): dt-bindings: Add vendor prefix for CDTech(H.K.) Electroni

[PATCH 2/5] drm/panel: add panel CDTech S070WV95-CT16 to panel-simple

2018-07-31 Thread Giulio Benetti
This patch adds support for CDTech S070WV95-CT16 800x480 7" panel to DRM simple panel driver. Signed-off-by: Giulio Benetti --- drivers/gpu/drm/panel/panel-simple.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/dr

[PATCH 5/5] dt-bindings: Add CDTech S043WQ26H-CT7 panel bindings

2018-07-31 Thread Giulio Benetti
Add documentation for S043WQ26H-CT7 panel Signed-off-by: Giulio Benetti --- .../bindings/display/panel/cdtech,s043wq26h-ct7.txt | 12 1 file changed, 12 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/cdtech,s043wq26h-ct7.txt diff --git

[PATCH 0/5] Add CDTech 4.3" and 7" to panel-simple

2018-07-31 Thread Giulio Benetti
Add CDTech 4.3" S043WQ26H-CT7 support Add CDTech 7" S070WV95-CT16 support Giulio Benetti (5): dt-bindings: Add vendor prefix for CDTech(H.K.) Electronics Limited drm/panel: add panel CDTech S070WV95-CT16 to panel-simple dt-bindings: Add CDTech S070WV95-CT16 panel bindings drm/

[PATCH 4/5] drm/panel: add panel CDTech S043WQ26H-CT7 to panel-simple

2018-07-31 Thread Giulio Benetti
This patch adds support for CDTech S043WQ26H-CT7 480x272 4.3" panel to DRM simple panel driver. Signed-off-by: Giulio Benetti --- drivers/gpu/drm/panel/panel-simple.c | 28 1 file changed, 28 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple

[PATCH 3/5] dt-bindings: Add CDTech S070WV95-CT16 panel bindings

2018-07-31 Thread Giulio Benetti
Add documentation for S070WV95-CT16 panel Signed-off-by: Giulio Benetti --- .../bindings/display/panel/cdtech,s070wv95-ct16.txt | 12 1 file changed, 12 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/cdtech,s070wv95-ct16.txt diff --git

[PATCH 1/5] dt-bindings: Add vendor prefix for CDTech(H.K.) Electronics Limited

2018-07-31 Thread Giulio Benetti
This adds a vendor prefix "cdtech" for CDTech(H.K.) Electronics Limited Website: www.cdtech-lcd.com Signed-off-by: Giulio Benetti --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/vendor-pr

Re: [PATCH] drm/sun4i: Handle DRM_BUS_FLAG_PIXDATA_*EDGE checking if panel is used.

2018-07-19 Thread Giulio Benetti
Hi Paul, can you give a try to this patch on A13 with VGA DAC? Unfortunately I don't have an A13 board to test it. Thanks in advance. Giulio Il 18/07/2018 16:23, Giulio Benetti ha scritto: Handle both positive and negative dclk polarity, according to bus_flags, taking care of this: On A20

[PATCH] drm/sun4i: Handle DRM_BUS_FLAG_PIXDATA_*EDGE checking if panel is used.

2018-07-19 Thread Giulio Benetti
, but it divides also dclk by 2. This patch is a way to avoid quirks all around TCON and DOTCLOCK drivers for using A33 90° phase divided by 2 and consequently increase code complexity. Check if panel is used. TCON can also handle VGA DAC, then panel could be empty. Signed-off-by: Giulio Benetti

Re: [PATCH] Revert "drm/sun4i: Handle DRM_BUS_FLAG_PIXDATA_*EDGE"

2018-06-16 Thread Giulio Benetti
Hi Paul, Il 14/06/2018 09:26, Paul Kocialkowski ha scritto: Hi, On Wed, 2018-06-13 at 23:52 +0200, Giulio Benetti wrote: Hello, sorry for my ignorance. I don't know the right patch workflow in the case of "revert commit". When I fix this bug, should I have to re-submit the prev

Re: [PATCH] Revert "drm/sun4i: Handle DRM_BUS_FLAG_PIXDATA_*EDGE"

2018-06-14 Thread Giulio Benetti
Hello, sorry for my ignorance. I don't know the right patch workflow in the case of "revert commit". When I fix this bug, should I have to re-submit the previous patch entire plus bug-fix? Or do I have to submit patch with bug-fix only? Thanks in advance to everybody -- Giulio B

Re: [PATCH 7/7] ARM: dts: sun7i: Add dts file for the A20-linova1-7 HMI

2018-05-09 Thread Giulio Benetti
Hi, Il 07/05/2018 09:30, Maxime Ripard ha scritto: Otherwise as in-tree dts with make dtbs "-@" argument is not passed. Right? You should use DTC_FLAGS='-@' Thank you, I'm going to use that. -- Giulio Benetti CTO MICRONOVA SRL Sede: Via A. Niedda 3 - 35010 Vigonza (PD) Tel. 0

Re: [PATCH 7/7] ARM: dts: sun7i: Add dts file for the A20-linova1-7 HMI

2018-05-04 Thread Giulio Benetti
Hi Sergey, Il 04/05/2018 23:59, Sergey Suloev ha scritto: Hi, Giulio, On 05/05/2018 12:52 AM, Giulio Benetti wrote: Hi Maxime! Il 04/05/2018 10:06, Maxime Ripard ha scritto: Hi, On Wed, May 02, 2018 at 06:41:34PM +0200, Giulio Benetti wrote: You don't have to handcode the fragments

Re: [PATCH 7/7] ARM: dts: sun7i: Add dts file for the A20-linova1-7 HMI

2018-05-04 Thread Giulio Benetti
Hi Maxime! Il 04/05/2018 10:06, Maxime Ripard ha scritto: Hi, On Wed, May 02, 2018 at 06:41:34PM +0200, Giulio Benetti wrote: You don't have to handcode the fragments anymore with the new syntax, and U-Boot makes it really trivial to use if you use the FIT image format to have multiple

Re: [PATCH 7/7] ARM: dts: sun7i: Add dts file for the A20-linova1-7 HMI

2018-05-02 Thread Giulio Benetti
r depending on hardware. Can you point me to somewhere or something? I don't really know where to beat my head! Thanks in advance. -- Giulio Benetti CTO MICRONOVA SRL Sede: Via A. Niedda 3 - 35010 Vigonza (PD) Tel. 049/8931563 - Fax 049/8931346 Cod.Fiscale - P.IVA 0

Re: [PATCH 7/7] ARM: dts: sun7i: Add dts file for the A20-linova1-7 HMI

2018-04-25 Thread Giulio Benetti
Hi Maxime, Il 25/04/2018 20:40, Maxime Ripard ha scritto: Hi Giulio, On Tue, Apr 24, 2018 at 08:31:44PM +0200, Giulio Benetti wrote: LiNova1 is not a board with various headers to connect other peripherals such display, pcap etc. It's an HMI that I would consider the same as a Tablet, because

Re: [PATCH 7/7] ARM: dts: sun7i: Add dts file for the A20-linova1-7 HMI

2018-04-24 Thread Giulio Benetti
Hi Maxime and all, I resend the e-mail since it was refused by some address(my phone composed it in HTML). Sorry. Il 24/04/2018 10:41, Maxime Ripard ha scritto: Hi, On Mon, Apr 23, 2018 at 04:37:33PM +0200, Giulio Benetti wrote: Il 22/03/2018 19:05, Maxime Ripard ha scritto: On Wed, Mar 21

Re: [PATCH 7/7] ARM: dts: sun7i: Add dts file for the A20-linova1-7 HMI

2018-04-24 Thread Giulio Benetti
Hi Maxime, Il 24 apr 2018 10:41, Maxime Ripard <maxime.rip...@bootlin.com> ha scritto:Hi, On Mon, Apr 23, 2018 at 04:37:33PM +0200, Giulio Benetti wrote: > Il 22/03/2018 19:05, Maxime Ripard ha scritto: > > On Wed, Mar 21, 2018 at 09:03:13PM +0100, Giulio Benetti wrote: > &

Re: [PATCH 7/7] ARM: dts: sun7i: Add dts file for the A20-linova1-7 HMI

2018-04-23 Thread Giulio Benetti
Hi, Il 22/03/2018 19:05, Maxime Ripard ha scritto: On Wed, Mar 21, 2018 at 09:03:13PM +0100, Giulio Benetti wrote: The A20-Linova1-7 HMI, also called Q027_2_F which is printed on production label, is an industrial Human Machine Interface. It features: - 512MB DDR RAM - 1 Sd-card >= 4GB - 1

Re: [v2] drm/sun4i: add lvds mode_valid function

2018-04-19 Thread Giulio Benetti
e, Mar 13, 2018 at 12:20:19PM +0100, Giulio Benetti wrote: mode_valid function is missing for lvds. Add it making it pointed by encoder helper functions. Signed-off-by: Giulio Benetti <giulio.bene...@micronovasrl.com> --- drivers/gpu/drm/sun4i/sun4i

Re: [PATCH 4/6] drm/panel: simple: Add support for Banana Pi 7" S070WV20-CT16 panel

2018-04-19 Thread Giulio Benetti
Hi, Il 19/04/2018 14:45, Chen-Yu Tsai ha scritto: On Thu, Apr 19, 2018 at 8:31 PM, Giulio Benetti <giulio.bene...@micronovasrl.com> wrote: Hi, Il 19/04/2018 11:32, Chen-Yu Tsai ha scritto: This panel is marketed as Banana Pi 7" LCD display. On the back is a sticker denoting the

Re: [PATCH 4/6] drm/panel: simple: Add support for Banana Pi 7" S070WV20-CT16 panel

2018-04-19 Thread Giulio Benetti
I've submitted patches. Micronova srl custom, but vendor is CDTech. What do you think? -- Giulio Benetti CTO MICRONOVA SRL Sede: Via A. Niedda 3 - 35010 Vigonza (PD) Tel. 049/8931563 - Fax 049/8931346 Cod.Fiscale - P.IVA 02663420285 Capitale Sociale € 26.000 i.v. Iscritta al Reg. Imprese di Pad

Re: [linux-sunxi] Re: [PATCH 2/3] ARM: dts: sun7i: Add RGB666 pins definition

2018-04-11 Thread Giulio Benetti
Hi, Il 12/04/2018 01:09, Paul Kocialkowski ha scritto: Hi, Le jeudi 12 avril 2018 à 00:22 +0200, Giulio Benetti a écrit : Hi, Il 10/04/2018 23:31, Paul Kocialkowski ha scritto: This adds the pins definition for RGB666 LCD panels on the A20. It was imported from the A33 definition

Re: [PATCH 2/3] ARM: dts: sun7i: Add RGB666 pins definition

2018-04-11 Thread Giulio Benetti
b666_pins, since this is for LCD0 interface - same as above, call lcd0-rgb666, take care about using "-" instad of "_" that can cause DTC warnings. - remove @0 since only this set can achieve LCD0 RGB666, and I don't think there will be other combinations. Kind regards -- Giulio

Re: [PATCH 1/7] dt-bindings: add cdtech vendor prefix

2018-03-26 Thread Giulio Benetti
Hi, Il 27/03/2018 00:24, Rob Herring ha scritto: On Wed, Mar 21, 2018 at 09:03:07PM +0100, Giulio Benetti wrote: This adds a vendor prefix "cdtech" for CDTech(H.K.) Electronics Limited Would be good to have website and/or info about what this company does. Do you mean to have it

Re: [PATCH 4/7] ARM: dts: sun7i: Add pinmux settings for LCD0 RGB888 output.

2018-03-26 Thread Giulio Benetti
Hi, Il 26/03/2018 12:01, Maxime Ripard ha scritto: Hi, On Sun, Mar 25, 2018 at 04:09:13PM +0200, Paul Kocialkowski wrote: Le mercredi 21 mars 2018 à 21:03 +0100, Giulio Benetti a écrit : The A20 supports RGB888 with H/V sync from LCD0. Add a pinmux setting for the needed pins. Signed-off

[PATCH 1/7] dt-bindings: add cdtech vendor prefix

2018-03-21 Thread Giulio Benetti
This adds a vendor prefix "cdtech" for CDTech(H.K.) Electronics Limited Signed-off-by: Giulio Benetti <giulio.bene...@micronovasrl.com> --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree

  1   2   >