Re: [PATCH] FBTFT: fb_agm1264k: usleep_range is preferred over udelay

2019-09-09 Thread Greg KH
On Sun, Sep 08, 2019 at 08:26:05PM -0500, Sreeram Veluthakkal wrote: > This patch fixes the issue: > FILE: drivers/staging/fbtft/fb_agm1264k-fl.c:88: > CHECK: usleep_range is preferred over udelay; see > Documentation/timers/timers-howto.rst > + udelay(20); > > Signed-off-by: Sreeram Veluth

Re: [PATCH AUTOSEL 4.19 147/167] drm/panel: Add support for Armadeus ST0700 Adapt

2019-09-05 Thread Greg KH
On Thu, Sep 05, 2019 at 09:55:58AM +0100, Rob Herring wrote: > On Tue, Sep 3, 2019 at 5:31 PM Sasha Levin wrote: > > > > From: Sébastien Szymanski > > > > [ Upstream commit c479450f61c7f1f248c9a54aedacd2a6ca521ff8 ] > > > > This patch adds support for the Armadeus ST0700 Adapt. It comes with a >

Re: [BACKPORT 4.14.y 1/8] drm/i915/fbdev: Actually configure untiled displays

2019-09-04 Thread Greg KH
On Tue, Sep 03, 2019 at 02:55:26PM +0800, Baolin Wang wrote: > From: Chris Wilson > > If we skipped all the connectors that were not part of a tile, we would > leave conn_seq=0 and conn_configured=0, convincing ourselves that we > had stagnated in our configuration attempts. Avoid this situation

Re: [PATCH AUTOSEL 4.19 044/167] drm/amdgpu: validate user pitch alignment

2019-09-03 Thread Greg KH
On Tue, Sep 03, 2019 at 06:40:43PM +0200, Michel Dänzer wrote: > On 2019-09-03 6:23 p.m., Sasha Levin wrote: > > From: Yu Zhao > > > > [ Upstream commit 89f23b6efef554766177bf51aa754bce14c3e7da ] > > Hold your horses! > > This commit and c4a32b266da7bb702e60381ca0c35eaddbc89a6c had to be > reve

Re: [PATCH v3 0/7] drivers: Add generic device lookup helpers

2019-07-30 Thread Greg KH
On Tue, Jul 23, 2019 at 11:18:31PM +0100, Suzuki K Poulose wrote: > We have device iterators to find a particular device matching a criteria > for a given bus/class/driver. i.e, {bus,class,driver}_find_device() > APIs. The matching criteria is a function pointer for the APIs. Often the > lookup is

Re: [PATCH v3 2/7] drivers: Introduce device lookup variants by of_node

2019-07-30 Thread Greg KH
On Thu, Jul 25, 2019 at 02:54:02PM +0100, Lee Jones wrote: > On Tue, 23 Jul 2019, Suzuki K Poulose wrote: > > > Introduce wrappers for {bus/driver/class}_find_device() to > > locate devices by its of_node. > > > > Cc: Maarten Lankhorst > > Cc: Maxime Ripard > > Cc: dri-devel@lists.freedesktop.o

Re: [PATCH v3 0/7] drivers: Add generic device lookup helpers

2019-07-25 Thread Greg KH
On Tue, Jul 23, 2019 at 11:18:31PM +0100, Suzuki K Poulose wrote: > We have device iterators to find a particular device matching a criteria > for a given bus/class/driver. i.e, {bus,class,driver}_find_device() > APIs. The matching criteria is a function pointer for the APIs. Often the > lookup is

Re: [PATCH v2] Staging: fbtft: Fix GPIO handling

2019-07-25 Thread Greg KH
On Wed, Jul 17, 2019 at 11:41:37PM +0900, Jan Sebastian Götte wrote: > Commit c440eee1a7a1 ("Staging: fbtft: Switch to the gpio descriptor > interface") breaks GPIO handling. In several places, checks to only set > a GPIO if it was configured ended up backwards. > I have tested this fix. The fixed

Re: [RFC] Staging: fbtft: Typo in

2019-07-25 Thread Greg KH
On Sun, Jul 21, 2019 at 08:54:39PM +0200, Christophe JAILLET wrote: > Hi, > > looking at the code in 'drivers/staging/fbtft/fb_pcd8544.c', there seems to > be some typos. > > At the end of the file, we can find: > > FBTFT_REGISTER_DRIVER(DRVNAME, "philips,pdc8544", &display); > ... > MODULE_ALIA

Re: [PATCH 1/2] staging: android: ion: Remove file ion_carveout_heap.c

2019-07-03 Thread Greg KH
On Wed, Jul 03, 2019 at 07:32:27AM -0400, Laura Abbott wrote: > On 7/3/19 5:50 AM, Daniel Vetter wrote: > > On Wed, Jul 3, 2019 at 10:37 AM Greg KH wrote: > > > > > > On Wed, Jul 03, 2019 at 01:48:41PM +0530, Nishka Dasgupta wrote: > > > > Remove file i

Re: [PATCH 1/2] staging: android: ion: Remove file ion_carveout_heap.c

2019-07-03 Thread Greg KH
On Wed, Jul 03, 2019 at 02:14:21PM +0530, Nishka Dasgupta wrote: > On 03/07/19 2:07 PM, Greg KH wrote: > > On Wed, Jul 03, 2019 at 01:48:41PM +0530, Nishka Dasgupta wrote: > > > Remove file ion_carveout_heap.c as its functions and definitions are not > > > used anywh

Re: [PATCH 1/2] staging: android: ion: Remove file ion_carveout_heap.c

2019-07-03 Thread Greg KH
On Wed, Jul 03, 2019 at 01:48:41PM +0530, Nishka Dasgupta wrote: > Remove file ion_carveout_heap.c as its functions and definitions are not > used anywhere. > Issue found with Coccinelle. > > Signed-off-by: Nishka Dasgupta > --- > drivers/staging/android/ion/Kconfig | 9 -- > drivers

Re: [PATCH] fbtft: Cleanup line over 80 character warnings

2019-06-27 Thread Greg KH
On Thu, Jun 27, 2019 at 02:12:40PM +0200, Lukas Schneider wrote: > Cleanup the line over 80 character warnings, reported by checkpatch > > Signed-off-by: Lukas Schneider > Signed-off-by: Jannik Moritz > Cc: > --- > drivers/staging/fbtft/fbtft-sysfs.c | 3 ++- > drivers/staging/fbtft/fbtft.h

Re: [PATCH v2 00/28] drivers: Consolidate device lookup helpers

2019-06-23 Thread Greg KH
On Fri, Jun 14, 2019 at 06:53:55PM +0100, Suzuki K Poulose wrote: > We have device iterators to find a particular device matching a criteria > for a given bus/class/driver. i.e, {bus,class,driver}_find_device() APIs. > The matching criteria is a function pointer for the APIs. Often the lookup > is

Re: [PATCH v1] staging: android: fix style problem

2019-06-15 Thread Greg KH
On Sun, Jun 16, 2019 at 12:16:05AM +0530, Saiyam Doshi wrote: > checkpatch reported "WARNING: line over 80 characters". > This patch fixes it by aligning function arguments. > > Signed-off-by: Saiyam Doshi > --- > Changes in v1: > * Updated as per review comment. Now function arguments > uses t

Re: [PATCH] staging: android: fix style problem

2019-06-15 Thread Greg KH
On Sat, Jun 15, 2019 at 01:11:56AM +0530, Saiyam Doshi wrote: > checkpatch reported "WARNING: line over 80 characters". This > patch fixes it by aligning function arguments. > > Signed-off-by: Saiyam Doshi > --- > drivers/staging/android/ion/ion_chunk_heap.c | 4 +++- > 1 file changed, 3 inserti

Re: [PATCH 12/16] staging/comedi: mark as broken

2019-06-14 Thread Greg KH
On Fri, Jun 14, 2019 at 04:48:57PM +0200, Christoph Hellwig wrote: > On Fri, Jun 14, 2019 at 04:02:39PM +0200, Greg KH wrote: > > Perhaps a hint as to how we can fix this up? This is the first time > > I've heard of the comedi code not handling dma properly. > > I

Re: [PATCH 12/16] staging/comedi: mark as broken

2019-06-14 Thread Greg KH
On Fri, Jun 14, 2019 at 03:47:22PM +0200, Christoph Hellwig wrote: > comedi_buf.c abuse the DMA API in gravely broken ways, as it assumes it > can call virt_to_page on the result, and the just remap it as uncached > using vmap. Disable the driver until this API abuse has been fixed. > > Signed-of

Re: [PATCH v5] drm/vc4: fix fb references in async update

2019-06-13 Thread Greg KH
On Mon, Jun 10, 2019 at 10:18:59AM -0300, Helen Koike wrote: > commit c16b85559dcfb5a348cc085a7b4c75ed49b05e2c upstream. > > Async update callbacks are expected to set the old_fb in the new_state > so prepare/cleanup framebuffers are balanced. > > Calling drm_atomic_set_fb_for_plane() (which gets

Re: [PATCH] drm: don't block fb changes for async plane updates

2019-06-13 Thread Greg KH
On Mon, Jun 10, 2019 at 10:36:27AM -0300, Helen Koike wrote: > commit 89a4aac0ab0e6f5eea10d7bf4869dd15c3de2cd4 upstream. > > In the case of a normal sync update, the preparation of framebuffers (be > it calling drm_atomic_helper_prepare_planes() or doing setups with > drm_framebuffer_get()) are pe

Re: [PATCH 32/33] staging/olpc_dcon: Add drm conversion to TODO

2019-05-27 Thread Greg KH
On Mon, May 27, 2019 at 09:11:26AM +0200, Daniel Vetter wrote: > On Fri, May 24, 2019 at 10:53:53AM +0200, Daniel Vetter wrote: > > this driver is pretty horrible from a design pov, and needs a complete > > overhaul. Concrete thing that annoys me is that it looks at > > registered_fb, which is an i

Re: [PATCH 14/33] staging/olpc: lock_fb_info can't fail

2019-05-27 Thread Greg KH
On Mon, May 27, 2019 at 09:10:10AM +0200, Daniel Vetter wrote: > On Fri, May 24, 2019 at 10:53:35AM +0200, Daniel Vetter wrote: > > Simply because olpc never unregisters the damn thing. It also > > registers the framebuffer directly by poking around in fbdev > > core internals, so it's all around r

Re: [PATCH 03/16] lib,treewide: add new match_string() helper/macro

2019-05-08 Thread Greg KH
On Wed, May 08, 2019 at 04:11:28PM +0300, Andy Shevchenko wrote: > On Wed, May 08, 2019 at 02:28:29PM +0300, Alexandru Ardelean wrote: > > This change re-introduces `match_string()` as a macro that uses > > ARRAY_SIZE() to compute the size of the array. > > The macro is added in all the places that

Re: [PATCH v2 00/17] kunit: introduce KUnit, the Linux kernel unit testing framework

2019-05-07 Thread Greg KH
On Mon, May 06, 2019 at 08:14:12PM -0700, Frank Rowand wrote: > On 5/1/19 4:01 PM, Brendan Higgins wrote: > > ## TLDR > > > > I rebased the last patchset on 5.1-rc7 in hopes that we can get this in > > 5.2. > > > > Shuah, I think you, Greg KH, and myself

Re: [PATCH v2 12/17] kunit: tool: add Python wrappers for running KUnit tests

2019-05-04 Thread Greg KH
On Fri, May 03, 2019 at 04:14:49PM -0700, Brendan Higgins wrote: > In any case, it sounds like you and Greg are in agreement on the core > libraries generating the output in TAP13, so I won't argue that point > further. Great! > ## Analysis of using TAP13 > > One of my earlier concerns was that

Re: [PATCH v2 16/17] kernel/sysctl-test: Add null pointer test for sysctl.c:proc_dointvec()

2019-05-04 Thread Greg KH
On Fri, May 03, 2019 at 04:41:10PM -0700, Brendan Higgins wrote: > > On Thu, May 02, 2019 at 11:45:43AM -0700, Brendan Higgins wrote: > > > On Thu, May 2, 2019 at 11:15 AM wrote: > > > > > > > > > > > > > > > > > -Original Me

Re: [PATCH v2 16/17] kernel/sysctl-test: Add null pointer test for sysctl.c:proc_dointvec()

2019-05-02 Thread Greg KH
On Thu, May 02, 2019 at 11:45:43AM -0700, Brendan Higgins wrote: > On Thu, May 2, 2019 at 11:15 AM wrote: > > > > > > > > > -Original Message- > > > From: Greg KH > > > > > > On Wed, May 01, 2019 at 04:01:25PM -0700, Brendan Higgins

Re: [PATCH v2 12/17] kunit: tool: add Python wrappers for running KUnit tests

2019-05-02 Thread Greg KH
On Thu, May 02, 2019 at 04:45:29PM -0700, Brendan Higgins wrote: > On Thu, May 2, 2019 at 2:16 PM Frank Rowand wrote: > > > > On 5/2/19 11:07 AM, Brendan Higgins wrote: > > > On Thu, May 2, 2019 at 4:02 AM Greg KH wrote: > > >> > > >> On Wed, M

Re: [PATCH v2 00/17] kunit: introduce KUnit, the Linux kernel unit testing framework

2019-05-02 Thread Greg KH
On Thu, May 02, 2019 at 12:50:53PM +0200, Greg KH wrote: > On Wed, May 01, 2019 at 04:01:09PM -0700, Brendan Higgins wrote: > > ## TLDR > > > > I rebased the last patchset on 5.1-rc7 in hopes that we can get this in > > 5.2. > > That might be rushing it, normally

Re: [PATCH v2 16/17] kernel/sysctl-test: Add null pointer test for sysctl.c:proc_dointvec()

2019-05-02 Thread Greg KH
On Wed, May 01, 2019 at 04:01:25PM -0700, Brendan Higgins wrote: > From: Iurii Zaikin > > KUnit tests for initialized data behavior of proc_dointvec that is > explicitly checked in the code. Includes basic parsing tests including > int min/max overflow. > > Signed-off-by: Iurii Zaikin > Signed-

Re: [PATCH v2 12/17] kunit: tool: add Python wrappers for running KUnit tests

2019-05-02 Thread Greg KH
On Wed, May 01, 2019 at 04:01:21PM -0700, Brendan Higgins wrote: > From: Felix Guo > > The ultimate goal is to create minimal isolated test binaries; in the > meantime we are using UML to provide the infrastructure to run tests, so > define an abstract way to configure and run tests that allow us

Re: [PATCH v2 04/17] kunit: test: add kunit_stream a std::stream like logger

2019-05-02 Thread Greg KH
On Wed, May 01, 2019 at 04:01:13PM -0700, Brendan Higgins wrote: > A lot of the expectation and assertion infrastructure prints out fairly > complicated test failure messages, so add a C++ style log library for > for logging test results. Ideally we would always use a standard logging format, like

Re: [PATCH v2 07/17] kunit: test: add initial tests

2019-05-02 Thread Greg KH
On Wed, May 01, 2019 at 04:01:16PM -0700, Brendan Higgins wrote: > Add a test for string stream along with a simpler example. > > Signed-off-by: Brendan Higgins > --- > kunit/Kconfig | 12 ++ > kunit/Makefile | 4 ++ > kunit/example-test.c | 88 +++

Re: [PATCH v2 00/17] kunit: introduce KUnit, the Linux kernel unit testing framework

2019-05-02 Thread Greg KH
ah, I think you, Greg KH, and myself talked off thread, and we agreed > we would merge through your tree when the time came? Am I remembering > correctly? No objection from me. Let me go review the latest round of patches now. thanks, greg k-h ___ d

Re: [PATCH v2] driver : staging : ion: optimization for decreasing memory fragmentaion

2019-03-27 Thread Greg KH
On Wed, Mar 20, 2019 at 02:38:23PM +0800, Zhaoyang Huang wrote: > From: Zhaoyang Huang > > Two action for this patch: > 1. set a batch size for system heap's shrinker, which can have it buffer > reasonable page blocks in pool for future allocation. > 2. reverse the order sequence when free page b

Re: [RFC][PATCH 1/5 v2] dma-buf: Add dma-buf heaps framework

2019-03-27 Thread Greg KH
On Tue, Mar 05, 2019 at 12:54:29PM -0800, John Stultz wrote: > From: "Andrew F. Davis" > > This framework allows a unified userspace interface for dma-buf > exporters, allowing userland to allocate specific types of > memory for use in dma-buf sharing. > > Each heap is given its own device node,

Re: [PULL] topic/mei-hdcp for char-misc-next

2019-02-28 Thread Greg KH
On Tue, Feb 26, 2019 at 10:17:10PM +0100, Daniel Vetter wrote: > Hi Greg&Arnd > > topic/mei-hdcp-2019-02-26: > mei-hdcp driver > > mei driver for the me hdcp client, for use by drm/i915. > > Including the following prep work: > - whitelist hdcp client in mei bus > - merge to include char-misc-ne

Re: [PULL] topic/mei-hdcp

2019-02-19 Thread Greg KH
On Tue, Feb 19, 2019 at 08:55:27AM +0100, Daniel Vetter wrote: > Hi all, > > topic/mei-hdcp-2019-02-19: > Prep patches + headers for the mei-hdcp/i915 component interfaces > > Also contains the prep work in the component helpers plus adjustements > for the snd-hda/i915 component interface. > > P

Re: [PULL] topic/component-typed

2019-02-11 Thread Greg KH
On Mon, Feb 11, 2019 at 08:18:04PM +0100, Daniel Vetter wrote: > On Mon, Feb 11, 2019 at 7:57 PM Takashi Iwai wrote: > > > > On Mon, 11 Feb 2019 19:25:12 +0100, > > Sam Ravnborg wrote: > > > > > > Hi Daniel. > > > > > > On Mon, Feb 11, 2019 at 06:15:20PM +0100, Daniel Vetter wrote: > > > > Hi all,

Re: [PATCH v12 21/38] mei: me: add ice lake point device id.

2019-02-08 Thread Greg KH
On Sat, Feb 09, 2019 at 12:42:50PM +0530, Ramalingam C wrote: > From: Tomas Winkler > > Add icelake mei device id. > > Cc: > Signed-off-by: Tomas Winkler > Signed-off-by: Greg Kroah-Hartman > Cherry-picked from > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git > char-mis

Re: devm actions and hw clenaup (was Re: [PATCH 01/11] drm: Add devm_drm_dev_init/register)

2019-01-29 Thread Greg KH
On Wed, Jan 30, 2019 at 12:14:46AM +0100, Daniel Vetter wrote: > On Tue, Jan 29, 2019 at 8:27 PM Greg KH wrote: > > On Tue, Jan 29, 2019 at 07:10:55PM +0100, Daniel Vetter wrote: > > > The problem is when drivers use devm_ not to allocate hw resources and > > > related

Re: devm actions and hw clenaup (was Re: [PATCH 01/11] drm: Add devm_drm_dev_init/register)

2019-01-29 Thread Greg KH
On Tue, Jan 29, 2019 at 07:10:55PM +0100, Daniel Vetter wrote: > On Tue, Jan 29, 2019 at 6:36 PM Greg KH wrote: > > > > On Tue, Jan 29, 2019 at 05:50:05PM +0100, Daniel Vetter wrote: > > > On Tue, Jan 29, 2019 at 03:34:46PM +0100, Noralf Trønnes wrote: > > > >

Re: devm actions and hw clenaup (was Re: [PATCH 01/11] drm: Add devm_drm_dev_init/register)

2019-01-29 Thread Greg KH
On Tue, Jan 29, 2019 at 05:50:05PM +0100, Daniel Vetter wrote: > On Tue, Jan 29, 2019 at 03:34:46PM +0100, Noralf Trønnes wrote: > > > > > > Den 24.01.2019 18.57, skrev Daniel Vetter: > > > On Thu, Jan 24, 2019 at 6:46 PM Greg KH > > > wrote: > >

Re: devm actions and hw clenaup (was Re: [PATCH 01/11] drm: Add devm_drm_dev_init/register)

2019-01-29 Thread Greg KH
On Tue, Jan 29, 2019 at 03:34:46PM +0100, Noralf Trønnes wrote: > > > Den 24.01.2019 18.57, skrev Daniel Vetter: > > On Thu, Jan 24, 2019 at 6:46 PM Greg KH wrote: > >> > >> On Thu, Jan 24, 2019 at 11:43:12AM +0100, Daniel Vetter wrote: > >>> On

Re: [PATCH v2] drm/meson: Fix atomic mode switching regression

2019-01-28 Thread Greg KH
On Mon, Jan 28, 2019 at 05:21:12PM +0100, Neil Armstrong wrote: > Hi Stable kernel team, > > On 14/01/2019 16:31, Neil Armstrong wrote: > > Since commit 2bcd3ecab773 when switching mode from X11 (ubuntu mate for > > example) the display gets blurry, looking like an invalid framebuffer width. > >

Re: devm actions and hw clenaup (was Re: [PATCH 01/11] drm: Add devm_drm_dev_init/register)

2019-01-24 Thread Greg KH
On Thu, Jan 24, 2019 at 11:43:12AM +0100, Daniel Vetter wrote: > On Wed, Jan 23, 2019 at 11:54:07AM +0100, Noralf Trønnes wrote: > > > > > > Den 22.01.2019 20.30, skrev Daniel Vetter: > > > On Tue, Jan 22, 2019 at 8:07 PM Noralf Trønnes wrote: > > >> > > >> > > >> > > >> Den 22.01.2019 10.32, sk

Re: [Intel-gfx] [PATCH 1/3] treewide: Lift switch variables out of switches

2019-01-24 Thread Greg KH
On Thu, Jan 24, 2019 at 07:55:51AM +1300, Kees Cook wrote: > On Thu, Jan 24, 2019 at 4:44 AM Jani Nikula > wrote: > > > > On Wed, 23 Jan 2019, Edwin Zimmerman wrote: > > > On Wed, 23 Jan 2019, Jani Nikula wrote: > > >> On Wed, 23 Jan 2019, Greg KH wrote:

Re: [PATCH 1/3] treewide: Lift switch variables out of switches

2019-01-23 Thread Greg KH
On Wed, Jan 23, 2019 at 03:03:47AM -0800, Kees Cook wrote: > Variables declared in a switch statement before any case statements > cannot be initialized, so move all instances out of the switches. > After this, future always-initialized stack variables will work > and not throw warnings like this:

Re: [PATCH] drm/vkms: Fix license inconsistent

2019-01-21 Thread Greg KH
On Mon, Jan 21, 2019 at 06:58:57PM -0200, Rodrigo Siqueira wrote: > Fixes license inconsistent related to the VKMS driver and remove the > redundant boilerplate comment. > > Fixes: 854502fa0a38 ("drm/vkms: Add basic CRTC initialization") > > Signed-off-by: Rodrigo Siqueira > --- > drivers/gpu/d

Re: [PATCH -stable] drm/fb_helper: Allow leaking fbdev smem_start

2019-01-15 Thread Greg KH
On Fri, Jan 11, 2019 at 04:06:38PM +0100, Maxime Ripard wrote: > From: Neil Armstrong > > commit 4be9bd10e22dfc7fc101c5cf5969ef2d3a042d8a upstream. > > Since "drm/fb: Stop leaking physical address", the default behaviour of > the DRM fbdev emulation is to set the smem_base to 0 and pass the new

Re: [PATCH v1 2/2] drm/fb-helper: Ignore the value of fb_var_screeninfo.pixclock

2019-01-07 Thread Greg KH
On Sat, Jan 05, 2019 at 09:21:21PM +0500, Ivan Mironov wrote: > On Fri, 2018-12-28 at 13:06 +0100, Daniel Vetter wrote: > > On Fri, Dec 28, 2018 at 04:13:08AM +0500, Ivan Mironov wrote: > > > Strict requirement of pixclock to be zero breaks support of SDL 1.2 > > > which contains hardcoded table of

Re: [PATCH v3] Return only active connectors for get_resources ioctl

2018-11-29 Thread Greg KH
On Thu, Nov 29, 2018 at 01:09:21PM +0200, Stanislav Lisovskiy wrote: > Currently kernel might allocate different connector ids > for the same outputs in case of DP MST, which seems to > confuse userspace. There are can be different connector > ids in the list, which could be assigned to the same >

Re: linux-next: manual merge of the staging tree with the drm tree

2018-11-20 Thread Greg KH
On Tue, Nov 20, 2018 at 01:16:16PM +1100, Stephen Rothwell wrote: > Hi Greg, > > Today's linux-next merge of the staging tree got a conflict in: > > drivers/staging/vboxvideo/vbox_ttm.c > > between commits: > > a64f784bb14a ("drm/ttm: initialize globals during device init (v2)") > > from t

Re: [PATCH v2] drm/msm: Move fence put to where failure occurs

2018-11-02 Thread Greg KH
On Fri, Nov 02, 2018 at 01:29:25PM +0100, Robert Foss wrote: > +stable This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly. _

Re: linux-next: manual merge of the char-misc tree with the drm tree

2018-10-16 Thread Greg KH
On Wed, Oct 17, 2018 at 02:22:57PM +1100, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the char-misc tree got a conflict in: > > MAINTAINERS > > between commit: > > fbb0de795078 ("Add udmabuf misc device") > > from the drm tree and commit: > > 9793c1fd1775 ("MAINTAI

Re: [PATCH] gpu: do not double put device node in zx_drm_probe

2018-09-18 Thread Greg KH
On Tue, Sep 18, 2018 at 10:59:08PM +0800, zhong jiang wrote: > Hi, Greg > > Can you pick up the patch? Nope: $ ./scripts/get_maintainer.pl --file drivers/gpu/drm/zte/zx_drm_drv.c Shawn Guo (maintainer:DRM DRIVERS FOR ZTE ZX) David Airlie (maintainer:DRM DRIVERS) dri-devel@lists.freedesktop.or

Re: [PATCH] staging/vboxvideo: Replace ttm_bo_unref with ttm_bo_put

2018-09-10 Thread Greg KH
On Mon, Sep 10, 2018 at 10:39:57AM +0200, Thomas Zimmermann wrote: > Hi Greg > > Am 02.08.2018 um 09:29 schrieb Greg KH: > > On Tue, Jul 31, 2018 at 08:37:35AM +0200, Thomas Zimmermann wrote: > >> The function ttm_bo_put releases a reference to a TTM buffer object. The

Re: [RFC] UAPI: Check headers by compiling all together as C++

2018-09-05 Thread Greg KH
On Wed, Sep 05, 2018 at 04:54:27PM +0100, David Howells wrote: > > Here's a set of patches that inserts a step into the build process to make > sure that the UAPI headers can all be built together with C++ (if the > compiler being used supports C++). All but the final patch perform fixups, > incl

Re: [PATCH] staging/vboxvideo: Replace ttm_bo_unref with ttm_bo_put

2018-08-02 Thread Greg KH
On Tue, Jul 31, 2018 at 08:37:35AM +0200, Thomas Zimmermann wrote: > The function ttm_bo_put releases a reference to a TTM buffer object. The > function's name is more aligned to the Linux kernel convention of naming > ref-counting function _get and _put. > > A call to ttm_bo_unref takes the addre

Re: [PATCH] drm/nouveau: Set DRIVER_ATOMIC cap earlier to fix debugfs

2018-07-26 Thread Greg KH
On Mon, Jul 23, 2018 at 01:13:20PM -0400, Lyude Paul wrote: > commit eb493fbc150f4a28151ae1ee84f24395989f3600 upstream > > Currently nouveau doesn't actually expose the state debugfs file that's > usually provided for any modesetting driver that supports atomic, even > if nouveau is loaded with at

Re: [PATCH resend] drivers: dma-buf: Change %p to %pK in debug messages

2018-06-06 Thread Greg KH
On Tue, Jun 05, 2018 at 04:40:41PM -0700, Daniel Rosenberg wrote: > The format specifier %p can leak kernel addresses > while not valuing the kptr_restrict system settings. > Use %pK instead of %p, which also evaluates whether > kptr_restrict is set. > > Signed-off-by: Divya Ponnusamy > Signed-of

Re: [PATCH] drm/bridge: dw-hdmi: Switch to SPDX identifier

2018-05-23 Thread Greg KH
On Wed, May 23, 2018 at 06:07:49PM +0300, Laurent Pinchart wrote: > Hi Lucas, > > (CC'ing Greg) > > On Wednesday, 23 May 2018 18:02:23 EEST Lucas Stach wrote: > > Am Dienstag, den 22.05.2018, 13:37 +0300 schrieb Laurent Pinchart: > > > On Tuesday, 22 May 2018 12:29:21 EEST Lucas Stach wrote: > >

Re: [PATCH 4/6] staging/fbtft: Stop using BL_CORE_DRIVER1

2018-04-30 Thread Greg KH
On Mon, Apr 30, 2018 at 10:54:15AM +0100, Lee Jones wrote: > Greg, Thomas, > > On Wed, 25 Apr 2018, Daniel Vetter wrote: > > Leaking driver internal tracking into the already massively confusing > > backlight power tracking is really confusing. > > > > Luckily we have already a drvdata structure,

Re: [PATCH] drm: bridge: dw-hdmi: Fix overflow workaround for Amlogic Meson GX SoCs

2018-04-26 Thread Greg KH
On Thu, Apr 26, 2018 at 10:38:08AM +0200, Neil Armstrong wrote: > Hi Greg, > > On 19/04/2018 10:27, Greg KH wrote: > > On Thu, Apr 19, 2018 at 10:18:35AM +0200, Neil Armstrong wrote: > >> Hi Greg, > >> > >> On 23/02/2018 12:44, Neil Armstrong wrote: >

Re: [PATCH] drm: bridge: dw-hdmi: Fix overflow workaround for Amlogic Meson GX SoCs

2018-04-19 Thread Greg KH
On Thu, Apr 19, 2018 at 10:18:35AM +0200, Neil Armstrong wrote: > Hi Greg, > > On 23/02/2018 12:44, Neil Armstrong wrote: > > The Amlogic Meson GX SoCs, embedded the v2.01a controller, has been also > > identified needing this workaround. > > This patch adds the corresponding version to enable a s

Re: [PATCH] drm/syncobj: Stop reusing the same struct file for all syncobj -> fd

2018-03-27 Thread Greg KH
On Mon, Mar 26, 2018 at 12:00:37PM -0700, Jason Ekstrand wrote: > From: Chris Wilson > > The vk cts test: > dEQP-VK.api.external.semaphore.opaque_fd.export_multiple_times_temporary > > triggers a lot of > VFS: Close: file count is 0 > > Dave pointed out that clearing the syncobj->file from > dr

Re: [PATCH v2 2/2] drivers: remove force dma flag from buses

2018-03-21 Thread Greg KH
On Wed, Mar 21, 2018 at 04:28:46PM +, Nipun Gupta wrote: > > > > -Original Message- > > From: Greg KH [mailto:gre...@linuxfoundation.org] > > Sent: Wednesday, March 21, 2018 15:05 > > To: Nipun Gupta > > Cc: robin.mur...@arm.com; h...@lst.de;

Re: [PATCH v2 2/2] drivers: remove force dma flag from buses

2018-03-21 Thread Greg KH
On Wed, Mar 21, 2018 at 12:25:23PM +0530, Nipun Gupta wrote: > With each bus implementing its own DMA configuration callback, > there is no need for bus to explicitly have force_dma in its > global structure. This patch modifies of_dma_configure API to > accept an input parameter which specifies if

Re: [PATCH v2 1/2] dma-mapping: move dma configuration to bus infrastructure

2018-03-21 Thread Greg KH
On Wed, Mar 21, 2018 at 12:25:22PM +0530, Nipun Gupta wrote: > It's bus specific aspect to map a given device on the bus and > relevant firmware description of its DMA configuration. > So, this change introduces '/dma_configure/' as bus callback > giving flexibility to busses for implementing its o

Re: [PATCH v2] Add udmabuf misc device

2018-03-16 Thread Greg KH
On Fri, Mar 16, 2018 at 08:46:49AM +0100, Gerd Hoffmann wrote: > --- /dev/null > +++ b/tools/testing/selftests/drivers/dma-buf/udmabuf.c > @@ -0,0 +1,69 @@ > +#include > +#include > +#include > +#include > +#include > +#include > +#include No license text at all? Come on, I already made on

Re: [PATCH v2] Add udmabuf misc device

2018-03-16 Thread Greg KH
On Fri, Mar 16, 2018 at 08:46:49AM +0100, Gerd Hoffmann wrote: > --- /dev/null > +++ b/drivers/dma-buf/udmabuf.c > @@ -0,0 +1,261 @@ > +/* > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * publish

Re: clang warning: implicit conversion in intel_ddi.c:1481

2018-02-02 Thread Greg KH
On Fri, Feb 02, 2018 at 04:37:55PM +0200, Jani Nikula wrote: > On Fri, 02 Feb 2018, Greg KH wrote: > > On Fri, Feb 02, 2018 at 12:44:38PM +0200, Jani Nikula wrote: > >> > >> +Knut, Fengguang > >> > >> On Fri, 02 Feb 2018, Greg KH wrote: > >&

Re: clang warning: implicit conversion in intel_ddi.c:1481

2018-02-02 Thread Greg KH
On Fri, Feb 02, 2018 at 12:44:38PM +0200, Jani Nikula wrote: > > +Knut, Fengguang > > On Fri, 02 Feb 2018, Greg KH wrote: > > - If clang now builds the kernel "cleanly", yes, I want to take > > warning fixes in the stable tree. And even better yet

Re: clang warning: implicit conversion in intel_ddi.c:1481

2018-02-02 Thread Greg KH
On Fri, Feb 02, 2018 at 10:56:36AM +0100, Lukas Bulwahn wrote: > On Fri, 2 Feb 2018, Jani Nikula wrote: > > > Being brutally honest, please write shorter reports and shorter emails > > to the lists. > > > > The static analysis reports are welcome, but only when 1) we didn't > > already fix it in

Re: clang warning: implicit conversion in intel_ddi.c:1481

2018-02-01 Thread Greg KH
On Thu, Feb 01, 2018 at 06:33:30PM +0100, Ozan Alpay wrote: > Dear Rodrigo Vivi, Ville Syrjälä, > > My name is Ozan Alpay, and I am a student mentored by Lukas Bulwahn. We > intend to use static analysis tools on the kernel source to identify, > analyze and report issues. As a very first step, w

Re: [PATCH v3 00/27] kill devm_ioremap_nocache

2017-12-23 Thread Greg KH
On Sat, Dec 23, 2017 at 06:55:25PM +0800, Yisheng Xie wrote: > Hi all, > > When I tried to use devm_ioremap function and review related code, I found > devm_ioremap and devm_ioremap_nocache is almost the same with each other, > except one use ioremap while the other use ioremap_nocache. For all a

Re: [PATCH v3 27/27] devres: kill devm_ioremap_nocache

2017-12-23 Thread Greg KH
On Sat, Dec 23, 2017 at 07:02:59PM +0800, Yisheng Xie wrote: > --- a/lib/devres.c > +++ b/lib/devres.c > @@ -44,35 +44,6 @@ void __iomem *devm_ioremap(struct device *dev, > resource_size_t offset, > EXPORT_SYMBOL(devm_ioremap); > > /** > - * devm_ioremap_nocache - Managed ioremap_nocache() > -

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

2017-12-05 Thread Greg KH
On Tue, Dec 05, 2017 at 03:01:42PM -0800, Laura Abbott wrote: > On 12/02/2017 07:53 AM, Greg KH wrote: > > > This is one of the item in the TODO list before been able to unstage ION > > > which is my real need. > > Why does it matter where in the tree this code is? Don

Re: [PATCH 0/4] Backported amdgpu ttm deadlock fixes for 4.14

2017-12-04 Thread Greg KH
On Thu, Nov 30, 2017 at 07:23:02PM -0500, Lyude Paul wrote: > I haven't gone to see where it started, but as of late a good number of > pretty nasty deadlock issues have appeared with the kernel. Easy > reproduction recipe on a laptop with i915/amdgpu prime with lockdep enabled: > > DRI_PRIME=1 gl

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

2017-12-02 Thread Greg KH
On Wed, Nov 29, 2017 at 03:00:56PM +0100, Benjamin Gaignard wrote: > 2017-11-28 14:32 GMT+01:00 Greg KH : > > On Mon, Nov 06, 2017 at 04:59:45PM +0100, Benjamin Gaignard wrote: > >> Instead a getting only one common device "/dev/ion" for > >> all the heaps

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

2017-11-28 Thread Greg KH
On Tue, Nov 28, 2017 at 05:37:53PM +, Mark Brown wrote: > On Tue, Nov 28, 2017 at 06:28:38PM +0100, Greg KH wrote: > > On Tue, Nov 28, 2017 at 05:12:23PM +, Mark Brown wrote: > > > > I think it's reasonable to ask for userspace, I'm querying why it needs &

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

2017-11-28 Thread Greg KH
On Tue, Nov 28, 2017 at 05:12:23PM +, Mark Brown wrote: > On Tue, Nov 28, 2017 at 06:08:22PM +0100, Greg KH wrote: > > On Tue, Nov 28, 2017 at 04:26:20PM +, Mark Brown wrote: > > > On Tue, Nov 28, 2017 at 02:32:17PM +0100, Greg KH wrote: > > > > > call yo

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

2017-11-28 Thread Greg KH
On Tue, Nov 28, 2017 at 04:26:20PM +, Mark Brown wrote: > On Tue, Nov 28, 2017 at 02:32:17PM +0100, Greg KH wrote: > > > Where is the documentation for the new sysfs files and the new ioctl > > Didn't see any sysfs files in there? New struct devices were created and

Re: [PATCH v6 1/2] staging: ion: reorder include

2017-11-28 Thread Greg KH
On Tue, Nov 28, 2017 at 02:34:00PM +0100, Benjamin Gaignard wrote: > 2017-11-28 14:20 GMT+01:00 Greg KH : > > On Mon, Nov 06, 2017 at 04:59:44PM +0100, Benjamin Gaignard wrote: > >> Put include in alphabetic order > > > > Why??? > > Mainly because the next p

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

2017-11-28 Thread Greg KH
On Mon, Nov 06, 2017 at 04:59:45PM +0100, Benjamin Gaignard wrote: > Instead a getting only one common device "/dev/ion" for > all the heaps this patch allow to create one device > entry ("/dev/ionX") per heap. > Getting an entry per heap could allow to set security rules > per heap and global ones

Re: [PATCH v6 1/2] staging: ion: reorder include

2017-11-28 Thread Greg KH
On Mon, Nov 06, 2017 at 04:59:44PM +0100, Benjamin Gaignard wrote: > Put include in alphabetic order Why??? That should not matter at all. I'll take this, but really, ick ick ick ick ick. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http

Re: [PATCH 02/13] fbdev: add remove_conflicting_pci_framebuffers()

2017-11-28 Thread Greg KH
On Tue, Nov 28, 2017 at 12:30:30PM +, Sudip Mukherjee wrote: > On Tue, Nov 28, 2017 at 12:32:38PM +0100, Greg KH wrote: > > On Tue, Nov 28, 2017 at 11:22:17AM +0100, Daniel Vetter wrote: > > > On Mon, Nov 27, 2017 at 08:52:19PM +, Sudip Mukherjee wrote: > > > &

Re: [PATCH 02/13] fbdev: add remove_conflicting_pci_framebuffers()

2017-11-28 Thread Greg KH
On Tue, Nov 28, 2017 at 11:22:17AM +0100, Daniel Vetter wrote: > On Mon, Nov 27, 2017 at 08:52:19PM +, Sudip Mukherjee wrote: > > On Mon, Nov 27, 2017 at 11:27:59AM +0100, Daniel Vetter wrote: > > > On Fri, Nov 24, 2017 at 06:53:31PM +0100, Michał Mirosław wrote: > > > > Almost all drivers usin

Re: 4.9.62: intermittent flicker after upgrade from 4.9.61

2017-11-28 Thread Greg KH
On Fri, Nov 24, 2017 at 07:48:22AM +0100, Greg KH wrote: > On Thu, Nov 23, 2017 at 10:09:25PM +0100, Rainer Fiebig wrote: > > Rainer Fiebig wrote: > > > Maarten Lankhorst wrote: > > >> Op 20-11-17 om 09:51 schreef Rainer Fiebig: > > >>> Jani Nikula

Re: [PATCH] staging: vboxvideo: adapt to new TTM interface

2017-11-24 Thread Greg KH
On Fri, Nov 24, 2017 at 01:53:16PM +0100, Christian König wrote: > Am 24.11.2017 um 11:37 schrieb Greg KH: > > On Fri, Nov 24, 2017 at 11:32:59AM +0100, Christian König wrote: > > > Fixes interface changes done in the following commits: > > > drm/ttm: add operatio

Re: [PATCH] staging: vboxvideo: adapt to new TTM interface

2017-11-24 Thread Greg KH
On Fri, Nov 24, 2017 at 11:32:59AM +0100, Christian König wrote: > Fixes interface changes done in the following commits: > drm/ttm: add operation ctx to ttm_bo_validate v2 > drm/ttm: add context to driver move callback as well Any hints on the git commit ids in Linus's tree? And does this mean t

Re: [PATCH] staging: vboxvideo: adapt to new TTM interface

2017-11-24 Thread Greg KH
On Fri, Nov 24, 2017 at 11:29:27AM +0100, Christian König wrote: > I missed this driver because it is in the staging area. What does this changelog text mean??? > Signed-off-by: Christian König > Reviewed-by: Hans de Goede > --- > drivers/staging/vboxvideo/vbox_ttm.c | 17 ++--- >

Re: 4.9.62: intermittent flicker after upgrade from 4.9.61

2017-11-23 Thread Greg KH
On Thu, Nov 23, 2017 at 10:09:25PM +0100, Rainer Fiebig wrote: > Rainer Fiebig wrote: > > Maarten Lankhorst wrote: > >> Op 20-11-17 om 09:51 schreef Rainer Fiebig: > >>> Jani Nikula wrote: > >>>> On Sun, 19 Nov 2017, Greg KH wrote: > >>>&

Re: Autoselect patches for stable (Was: Re: [PATCH AUTOSEL for 4.9 36/56] drm/i915: Fix the level 0 max_wm hack on VLV/CHV)

2017-11-21 Thread Greg KH
On Tue, Nov 21, 2017 at 12:09:33PM -0500, Josh Boyer wrote: > On Tue, Nov 21, 2017 at 10:07 AM, wrote: > > On Mon, Nov 20, 2017 at 11:21:52AM +, Emil Velikov wrote: > >> - Document the autoselect process > >>Information about about What, Why, and [ideally] How - analogous to > >>the normal st

Re: Autoselect patches for stable (Was: Re: [PATCH AUTOSEL for 4.9 36/56] drm/i915: Fix the level 0 max_wm hack on VLV/CHV)

2017-11-20 Thread Greg KH
On Mon, Nov 20, 2017 at 01:39:31PM +0100, Daniel Vetter wrote: > Of course our CI is open, so if someone is supremely bored and wants to > backport more stuff for drm/i915, they could do that. But atm it doesn't > happen, and then having to deal with the fallout is not really great (like > I said,

Re: 4.9.62: intermittent flicker after upgrade from 4.9.61

2017-11-19 Thread Greg KH
On Sun, Nov 19, 2017 at 01:44:06PM +0100, Rainer Fiebig wrote: > Greg KH wrote: > > On Sun, Nov 19, 2017 at 12:56:26PM +0100, Rainer Fiebig wrote: > >> Greg KH wrote: > >>> On Sat, Nov 18, 2017 at 05:08:20PM +0100, Rainer Fiebig wrote: > >>>> Greg KH

Re: 4.9.62: intermittent flicker after upgrade from 4.9.61

2017-11-19 Thread Greg KH
On Sun, Nov 19, 2017 at 12:56:26PM +0100, Rainer Fiebig wrote: > Greg KH wrote: > > On Sat, Nov 18, 2017 at 05:08:20PM +0100, Rainer Fiebig wrote: > >> Greg KH wrote: > >>> On Sat, Nov 18, 2017 at 01:47:32PM +0100, Rainer Fiebig wrote: > >>>> Hi

Re: [Intel-gfx] [PATCH AUTOSEL for 4.9 36/56] drm/i915: Fix the level 0 max_wm hack on VLV/CHV

2017-11-17 Thread Greg KH
On Fri, Nov 17, 2017 at 01:13:27PM +, Emil Velikov wrote: > Hi Greg, all, > > Pardon for the silly question, but I'm struggling to find > documentation about this new 'autoselection' process? > Where can one read up on it - be that about the tooling or the heuristics > used? > > I think the

Re: [PATCH AUTOSEL for 4.9 36/56] drm/i915: Fix the level 0 max_wm hack on VLV/CHV

2017-11-17 Thread Greg KH
On Fri, Nov 17, 2017 at 03:01:08PM +0200, Jani Nikula wrote: > On Fri, 17 Nov 2017, Greg KH wrote: > > On Fri, Nov 17, 2017 at 01:28:05PM +0200, Jani Nikula wrote: > >> > >> Cc: Greg > >> > >> On Wed, 15 Nov 2017, Ville Syrjälä wrote: &g

Re: [PATCH AUTOSEL for 4.9 36/56] drm/i915: Fix the level 0 max_wm hack on VLV/CHV

2017-11-17 Thread Greg KH
On Fri, Nov 17, 2017 at 02:53:43PM +0200, Ville Syrjälä wrote: > On Fri, Nov 17, 2017 at 01:41:23PM +0100, Greg KH wrote: > > On Fri, Nov 17, 2017 at 01:28:05PM +0200, Jani Nikula wrote: > > > > > > Cc: Greg > > > > > > On Wed, 15 Nov 2017, Ville Sy

<    1   2   3   4   5   6   7   8   >