Re: [PATCH] drm/panel: st7703: use DEFINE_DEBUGFS_ATTRIBUTE with debugfs_create_file_unsafe()

2020-11-01 Thread Guido Günther
dditional > details here: https://lists.archive.carbon60.com/linux/kernel/2369498 > > Issue reported by Coccinelle script: > scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci > > Signed-off-by: Deepak R Varma Reviewed-by: Guido Günther Cheers, -- Guido > --- > Pl

Re: [RFC PATCH 2/2] drm: etnaviv: Unmap gems on gem_close

2020-10-30 Thread Guido Günther
Hi, On Fri, Oct 30, 2020 at 10:19:54AM +0100, Lucas Stach wrote: > Am Donnerstag, den 29.10.2020, 19:20 +0100 schrieb Daniel Vetter: > > On Thu, Oct 29, 2020 at 03:38:21PM +0100, Lucas Stach wrote: > > > Hi Guido, > > > > > > Am Donnerstag, den 29.10.202

[RFC PATCH 2/2] drm: etnaviv: Unmap gems on gem_close

2020-10-29 Thread Guido Günther
) (etna_cmd_stream_flush:244) Fix this by unmapping the memory via the .gem_close_object callback. Signed-off-by: Guido Günther --- drivers/gpu/drm/etnaviv/etnaviv_drv.c | 1 + drivers/gpu/drm/etnaviv/etnaviv_drv.h | 1 + drivers/gpu/drm/etnaviv/etnaviv_gem.c | 32 +++ 3 files changed, 34

[RFC PATCH 0/2] drm: etnaviv: Unmap gems on gem_close

2020-10-29 Thread Guido Günther
ock in etnaviv_iommu_insert_exact and etnaviv_iommu_remove_mapping too to make it match etnaviv_iommu_find_iova. To: Lucas Stach ,Russell King ,Christian Gmeiner ,David Airlie ,Daniel Vetter ,etna...@lists.freedesktop.org, dri-devel@lists.freedesktop.org Guido Günther (2): drm: etnaviv: Add lockdep annotati

[RFC PATCH 1/2] drm: etnaviv: Add lockdep annotations for context lock

2020-10-29 Thread Guido Günther
etnaviv_iommu_find_iova has it so etnaviv_iommu_insert_exact and lockdep_assert_held should have it as well. Signed-off-by: Guido Günther --- drivers/gpu/drm/etnaviv/etnaviv_mmu.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_mmu.c b/drivers/gpu/drm

Re: [PATCH] Implement .format_mod_supported in mxsfb

2020-10-25 Thread Guido Günther
Hi Daniel, On Sat, Oct 24, 2020 at 04:59:16PM +, Daniel Abrecht wrote: > This will make sure applications which use the IN_FORMATS blob > to figure out which modifiers they can use will pick up the > linear modifier which is needed by mxsfb. Such applications > will not work otherwise if an

Re: [PATCH v2 0/3] drm/panel: mantix panel reset fixes

2020-10-23 Thread Guido Günther
Hi Sam, On Thu, Oct 22, 2020 at 06:59:29AM +0200, Sam Ravnborg wrote: > Hi Guido. > > On Tue, Oct 20, 2020 at 01:57:11PM +0200, Guido Günther wrote: > > Hi Daniel, Sam, > > On Mon, Oct 19, 2020 at 05:44:37PM +0200, Daniel Vetter wrote: > > > On Sat, Oct 17, 2020 at

Re: [PATCH v2 0/3] drm/panel: mantix panel reset fixes

2020-10-21 Thread Guido Günther
Hi Daniel, Sam, On Mon, Oct 19, 2020 at 05:44:37PM +0200, Daniel Vetter wrote: > On Sat, Oct 17, 2020 at 12:47:36PM +0200, Sam Ravnborg wrote: > > Hi Guido. > > > > On Sat, Oct 17, 2020 at 11:13:07AM +0200, Guido Günther wrote: > > > Hi Sam, > > > On Fri

Re: [PATCH v2 0/3] drm/panel: mantix panel reset fixes

2020-10-19 Thread Guido Günther
Hi, On Sun, Oct 18, 2020 at 03:38:45PM +0200, Sam Ravnborg wrote: > Hi Guido > > On Sun, Oct 18, 2020 at 03:01:22PM +0200, Guido Günther wrote: > > Hi Sam, > > On Sat, Oct 17, 2020 at 12:47:36PM +0200, Sam Ravnborg wrote: > > > Hi Guido. > > > > &g

Re: [PATCH v2 0/3] drm/panel: mantix panel reset fixes

2020-10-18 Thread Guido Günther
Hi Sam, On Sat, Oct 17, 2020 at 12:47:36PM +0200, Sam Ravnborg wrote: > Hi Guido. > > On Sat, Oct 17, 2020 at 11:13:07AM +0200, Guido Günther wrote: > > Hi Sam, > > On Fri, Oct 16, 2020 at 04:29:16PM +0200, Sam Ravnborg wrote: > > > Hi Guido. > > > On Tue,

Re: [PATCH v2 0/3] drm/panel: mantix panel reset fixes

2020-10-17 Thread Guido Günther
Hi Sam, On Fri, Oct 16, 2020 at 04:29:16PM +0200, Sam Ravnborg wrote: > Hi Guido. > On Tue, Oct 13, 2020 at 12:32:45PM +0200, Guido Günther wrote: [..snip..] > > > > Changes from v1: > > - As per review comments by Fabio Estevam > > > > https://lore.kern

[PATCH v2 3/3] dt-binding: display: Require two resets on mantix panel

2020-10-13 Thread Guido Günther
We need to reset both for the panel to show an image. Signed-off-by: Guido Günther --- .../bindings/display/panel/mantix,mlaf057we51-x.yaml | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml b

[PATCH v2 1/3] drm/panel: mantix: Don't dereference NULL mode

2020-10-13 Thread Guido Günther
Don't dereference mode which was just NULL checked. Signed-off-by: Guido Günther Reported-by: Dan Carpenter --- drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c b/drivers/gpu

[PATCH v2 2/3] drm/panel: mantix: Fix panel reset

2020-10-13 Thread Guido Günther
The mantix panel needs two reset lines (RESX and TP_RSTN) deasserted to output an image. Only deasserting RESX is not enough and the display will stay blank. Deassert in prepare() and assert in unprepare() to keep device held in reset when off. Signed-off-by: Guido Günther --- .../gpu/drm/panel

[PATCH v2 0/3] drm/panel: mantix panel reset fixes

2020-10-13 Thread Guido Günther
by Rob Herring https://lore.kernel.org/dri-devel/20200929174624.GA832332@bogus/ - Don't use an array of reset lines Guido Günther (3): drm/panel: mantix: Don't dereference NULL mode drm/panel: mantix: Fix panel reset dt-binding: display: Require two resets on mantix panel .../display

Re: [PATCH] dt-bindings: display: Add dsi-controller.yaml in DSI controller schemas

2020-10-03 Thread Guido Günther
Hi, On Fri, Oct 02, 2020 at 05:59:24PM -0500, Rob Herring wrote: > Some DSI controllers are missing a reference to the recently added > dsi-controller.yaml schema. Add it and we can drop the duplicate > parts. For the NWL part: Reviewed-by: Guido Günther > > Cc: Maxime Ripard

Re: [RFC PATCH v1 3/3] dt-binding: display: Require two rests on mantix panel

2020-09-28 Thread Guido Günther
Hi Thierry, On Mon, Sep 28, 2020 at 08:50:39AM +0200, Thierry Reding wrote: > On Thu, Sep 24, 2020 at 09:38:07PM +0200, Sam Ravnborg wrote: > > Hi Guido. > > > > On Mon, Sep 21, 2020 at 06:55:52PM +0200, Guido Günther wrote: > > > We need to reset both

Re: [RFC PATCH v1 3/3] dt-binding: display: Require two rests on mantix panel

2020-09-22 Thread Guido Günther
Hi, On Mon, Sep 21, 2020 at 02:05:55PM -0300, Fabio Estevam wrote: > Hi Guido, > > On Mon, Sep 21, 2020 at 1:56 PM Guido Günther wrote: > > > > We need to reset both for the panel to show an image. > > There is a typo in "resets" in the Subject line.

[RFC PATCH v1 1/3] drm/panel: mantix: Don't dereference NULL mode

2020-09-21 Thread Guido Günther
Don't dereference mode which was just NULL checked. Signed-off-by: Guido Günther Reported-by: Dan Carpenter --- drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c b/drivers/gpu

[RFC PATCH v1 3/3] dt-binding: display: Require two rests on mantix panel

2020-09-21 Thread Guido Günther
We need to reset both for the panel to show an image. Signed-off-by: Guido Günther --- .../bindings/display/panel/mantix,mlaf057we51-x.yaml | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml

[RFC PATCH v1 2/3] drm/panel: mantix: Fix panel reset

2020-09-21 Thread Guido Günther
The mantix panel needs two reset lines (RESX and TP_RSTN) deasserted to output an image. Only deasserting RESX is not enough and the display will stay blank. Deassert in prepare() and assert in unprepare() to keep device held in reset when off. Signed-off-by: Guido Günther --- .../gpu/drm/panel

[RFC PATCH v1 0/3] drm/panel: mantix panel reset fixes

2020-09-21 Thread Guido Günther
or using enable-gpios for one of them or forcing everyone else to set `maxItems: 1`? The binding were not part of a stable kernel so I hope it's okay to not worry about backward compatibility. Guido Günther (3): drm/panel: mantix: Don't dereference NULL mode drm/panel: mantix: Fix panel reset

Re: [PATCH][next] drm/panel: fix null pointer dereference on pointer mode

2020-09-18 Thread Guido Günther
Hi, On Fri, Sep 18, 2020 at 04:51:36PM +0100, Colin King wrote: > From: Colin Ian King > > Currently a null pointer check on pointer mode is passing mode to > function drm_mode_vrefresh and this causes a null pointer dereference > on mode. Fix this by not calling drm_mode_vrefresh since the

Re: [PATCH] drm/panel: st7703: Make jh057n00900_panel_desc static

2020-09-13 Thread Guido Günther
c jh057n00900_panel_desc = { > +static struct st7703_panel_desc jh057n00900_panel_desc = { Can we even make it `static const`? With that Reviewed-by: Guido Günther Cheers, -- Guido > .mode = _mode, > .lanes = 4, > .mode_flags = MIPI_DSI_MODE_VIDEO | > -- > 2.2

Re: [PATCH 3/5] drm/bridge: nwl-dsi: Add support for clock-drop-level

2020-09-06 Thread Guido Günther
Hi Robert, On Fri, Aug 28, 2020 at 02:13:30PM +0300, Robert Chiras (OSS) wrote: > From: Robert Chiras > > The clock-drop-level is needed in order to add more blanking space needed > by DSI panels when sending DSI commands. One level is the equivalent of > phy_ref rate from the PLL rate. Since

Re: [PATCH v9 0/5] Add support for iMX8MQ Display Controller Subsystem

2020-09-05 Thread Guido Günther
Hi Laurentiu, On Fri, Jul 31, 2020 at 10:54:29AM +0200, Guido Günther wrote: > Hi, > On Fri, Jul 31, 2020 at 11:18:28AM +0300, Laurentiu Palcu wrote: > > From: Laurentiu Palcu > > > > Hi, > > > > This patchset adds initial DCSS support for iMX8MQ chip. Initia

Re: [PATCH 0/5] Add new features to nwl-dsi driver

2020-09-04 Thread Guido Günther
-level part with mxsfb on a Librem 5 devkit and it removes the slight flickering we've seen before (and which could be worked around by reducing the input pixel clock so 1 and 3 are Tested-by: Guido Günther I've have added some comments to the individual patches and try to get around to check out th

Re: [PATCH 4/5] dt-bindings: display/bridge: nwl-dsi: Document fsl,clock-drop-level property

2020-09-04 Thread Guido Günther
Hi, On Fri, Aug 28, 2020 at 02:13:31PM +0300, Robert Chiras (OSS) wrote: > From: Robert Chiras > > Add documentation for a new property: 'fsl,clock-drop-level'. > > Signed-off-by: Robert Chiras > --- > Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml | 4 > 1 file changed, 4

Re: [PATCH 1/5] drm/bridge: nwl-dsi: Add support for video_pll

2020-09-04 Thread Guido Günther
Hi Robert, On Fri, Aug 28, 2020 at 02:13:28PM +0300, Robert Chiras (OSS) wrote: > From: Robert Chiras > > This patch adds support for a new clock 'video_pll' in order to better > set the video_pll clock to a clock-rate that satisfies a mode's clock. > The video PLL, on i.MX8MQ, can drive both DC

Re: [PATCH 5/5] drm/bridge: nwl-dsi: add support for DCSS

2020-09-04 Thread Guido Günther
Hi, On Fri, Aug 28, 2020 at 02:13:32PM +0300, Robert Chiras (OSS) wrote: > From: Laurentiu Palcu > > DCSS needs active low VSYNC and HSYNC. Also, move the input selection in > the probe function, as this will not change at runtime. > > Signed-off-by: Laurentiu Palcu > Signed-off-by: Robert

Re: [bug report] drm/panel: Add panel driver for the Mantix MLAF057WE51-X DSI panel

2020-09-04 Thread Guido Günther
Hi, On Mon, Aug 31, 2020 at 02:29:24PM +0300, Dan Carpenter wrote: > Hello Guido Günther, > > The patch 72967d5616d3: "drm/panel: Add panel driver for the Mantix > MLAF057WE51-X DSI panel" from Aug 17, 2020, leads to the following > static checker warning: > >

Re: [PATCH v8 0/3] drm: Add support for Cadence MHDP DPI/DP bridge and J721E wrapper.

2020-08-25 Thread Guido Günther
Hi Swapnil, On Mon, Aug 24, 2020 at 07:16:31AM +, Swapnil Kashinath Jakhade wrote: [..snip..] > Following are the differences between MHDP IPs from Cadence for Rockchip, TI > and NxP: > > The Rockchip and NXP MHDP Core shares the same part (IP8501) which is DP v1.3 > SST > Controller with

Re: [PATCH v3 0/3] drm/panel: Add panel driver for the Mantix MLAF057WE51-X DSI panel

2020-08-18 Thread Guido Günther
Hi Sam, On Tue, Aug 18, 2020 at 07:05:56PM +0200, Sam Ravnborg wrote: > Hi Guido. > > On Mon, Aug 17, 2020 at 10:14:33AM +0200, Guido Günther wrote: > > > > The panel uses a Focaltech FT8006p, the touch part is handled by the already > > existing edt-ft5x06. It can be

Re: [PATCH v2 3/3] drm/panel: Add panel driver for the Mantix MLAF057WE51-X DSI panel

2020-08-17 Thread Guido Günther
Hi Sam, On Sun, Aug 16, 2020 at 09:04:17PM +0200, Sam Ravnborg wrote: > On Sun, Aug 16, 2020 at 07:55:21PM +0200, Guido Günther wrote: > > Hi Sam, > > thanks for having a look! > > > > On Sat, Aug 15, 2020 at 11:27:27PM +0200, Sam Ravnborg wrote: > > > Hi Guid

Re: [PATCH 0/2] Modernize rocktech,jh057n00900 bindings a bit

2020-08-17 Thread Guido Günther
Hi, On Sun, Aug 16, 2020 at 05:25:34PM +0200, Sam Ravnborg wrote: > Hi Guido. > > On Sun, Aug 16, 2020 at 09:13:41AM +0200, Guido Günther wrote: > > This was prompted by Sam's review in > > https://lore.kernel.org/dri-devel/20200815210802.ga1242...@ravnborg.org/ > >

[PATCH v3 2/3] dt-bindings: Add Mantix MLAF057WE51-X panel bindings

2020-08-17 Thread Guido Günther
The panel uses a Focaltech FT8006p, the touch part is handled by the already existing edt-ft5x06. Signed-off-by: Guido Günther Reviewed-by: Sam Ravnborg --- .../display/panel/mantix,mlaf057we51-x.yaml | 70 +++ 1 file changed, 70 insertions(+) create mode 100644

[PATCH v3 1/3] dt-bindings: vendor-prefixes: Add mantix vendor prefix

2020-08-17 Thread Guido Günther
Add prefix for Mantix Display Technology Co.,Ltd. Signed-off-by: Guido Günther Acked-by: Sam Ravnborg --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation

[PATCH v3 3/3] drm/panel: Add panel driver for the Mantix MLAF057WE51-X DSI panel

2020-08-17 Thread Guido Günther
The panel uses a Focaltech FT8006p, the touch part is handled by the already existing edt-ft5x06. Signed-off-by: Guido Günther Reviewed-by: Sam Ravnborg --- MAINTAINERS | 7 + drivers/gpu/drm/panel/Kconfig | 11 + drivers/gpu/drm/panel

[PATCH v3 0/3] drm/panel: Add panel driver for the Mantix MLAF057WE51-X DSI panel

2020-08-17 Thread Guido Günther
/20200815100230.ga1002...@ravnborg.org/ - Use dev_err_probe() - Add delays when turning off panel as suggested by the data sheet This series is against next-20200814. Guido Günther (3): dt-bindings: vendor-prefixes: Add mantix vendor prefix dt-bindings: Add Mantix MLAF057WE51-X panel bindings drm

Re: [PATCH v2 3/3] drm/panel: Add panel driver for the Mantix MLAF057WE51-X DSI panel

2020-08-16 Thread Guido Günther
Hi Sam, thanks for having a look! On Sat, Aug 15, 2020 at 11:27:27PM +0200, Sam Ravnborg wrote: > Hi Guido. > > On Sat, Aug 15, 2020 at 11:16:22PM +0200, Guido Günther wrote: > > The panel uses a Focaltech FT8006p, the touch part is handled by the > > already existing edt-ft

[PATCH 0/2] Modernize rocktech,jh057n00900 bindings a bit

2020-08-16 Thread Guido Günther
This was prompted by Sam's review in https://lore.kernel.org/dri-devel/20200815210802.ga1242...@ravnborg.org/ and yamllint. I also added myself as maintainer, hope that's o.k. Guido Günther (2): dt-bindings: panel: rocktech,jh057n00900: Modernize dt-bindings: panel: rocktech,jh057n00900: Add

[PATCH 2/2] dt-bindings: panel: rocktech, jh057n00900: Add myself as maintainer

2020-08-16 Thread Guido Günther
I maintained the txt based bindings before yaml conversion and care about the driver. Signed-off-by: Guido Günther --- .../devicetree/bindings/display/panel/rocktech,jh057n00900.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/panel/rocktech

[PATCH 1/2] dt-bindings: panel: rocktech,jh057n00900: Modernize

2020-08-16 Thread Guido Günther
- Use common properties from panel-common.yaml - Indent comment like content - Don't preserve newlines in description - Indent example by four spaces Signed-off-by: Guido Günther --- .../display/panel/rocktech,jh057n00900.yaml | 39 +-- 1 file changed, 18 insertions(+), 21

Re: [PATCH 3/3] drm/panel: Add panel driver for the Mantix MLAF057WE51-X DSI panel

2020-08-15 Thread Guido Günther
Hi Sam, On Sat, Aug 15, 2020 at 11:32:26AM +0200, Sam Ravnborg wrote: > Hi Guido. > > On Fri, Aug 14, 2020 at 03:36:23PM +0200, Guido Günther wrote: > > The panel uses a Focaltech FT8006p, the touch part is handled by the > > already existing edt-ft5x06. > > >

Re: [PATCH 3/8] dt-bindings: display: mxsfb: Add a bus-width endpoint property

2020-08-15 Thread Guido Günther
Hi Laurent, On Thu, Aug 13, 2020 at 04:29:05AM +0300, Laurent Pinchart wrote: > When the PCB routes the display data signals in an unconventional way, > the output bus width may differ from the bus width of the connected > panel or encoder. For instance, when a 18-bit RGB panel has its R[5:0], >

Re: [PATCH v1 0/5] drm/panel: Use dev_ based logging

2020-08-15 Thread Guido Günther
here is no dependencies > between the patches. > > Copied a few people that may have input to the move away from DRM_ based > logging (Daniel (presumeably on vacation), Jani). Looks good to me and after applying to next-20200824 i couldn't spot any DRM_ style logging leftovers: R

[PATCH v2 2/3] dt-bindings: Add Mantix MLAF057WE51-X panel bindings

2020-08-15 Thread Guido Günther
The panel uses a Focaltech FT8006p, the touch part is handled by the already existing edt-ft5x06. Signed-off-by: Guido Günther --- .../display/panel/mantix,mlaf057we51-x.yaml | 70 +++ 1 file changed, 70 insertions(+) create mode 100644 Documentation/devicetree/bindings

[PATCH v2 1/3] dt-bindings: vendor-prefixes: Add mantix vendor prefix

2020-08-15 Thread Guido Günther
Add prefix for Mantix Display Technology Co.,Ltd. Signed-off-by: Guido Günther --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor

[PATCH v2 0/3] drm/panel: Add panel driver for the Mantix MLAF057WE51-X DSI panel

2020-08-15 Thread Guido Günther
-20200814. Guido Günther (3): dt-bindings: vendor-prefixes: Add mantix vendor prefix dt-bindings: Add Mantix MLAF057WE51-X panel bindings drm/panel: Add panel driver for the Mantix MLAF057WE51-X DSI panel .../display/panel/mantix,mlaf057we51-x.yaml | 70 .../devicetree/bindings

[PATCH v2 3/3] drm/panel: Add panel driver for the Mantix MLAF057WE51-X DSI panel

2020-08-15 Thread Guido Günther
The panel uses a Focaltech FT8006p, the touch part is handled by the already existing edt-ft5x06. Signed-off-by: Guido Günther --- MAINTAINERS | 7 + drivers/gpu/drm/panel/Kconfig | 11 + drivers/gpu/drm/panel/Makefile| 1

Re: [PATCH 2/3] dt-bindings: Add Mantix MLAF057WE51-X panel bindings

2020-08-15 Thread Guido Günther
Hi Sam, On Sat, Aug 15, 2020 at 10:39:17AM +0200, Sam Ravnborg wrote: > Hi Guido. > > On Fri, Aug 14, 2020 at 03:36:22PM +0200, Guido Günther wrote: > > The panel uses a Focaltech FT8006p, the touch part is handled by the > > already existing edt-ft5x06. > > >

Re: [PATCH 3/3] drm/panel: Add panel driver for the Mantix MLAF057WE51-X DSI panel

2020-08-15 Thread Guido Günther
Hi, On Sat, Aug 15, 2020 at 12:46:51PM +0200, Sam Ravnborg wrote: > On Sat, Aug 15, 2020 at 12:40:22PM +0200, Guido Günther wrote: > > Hi Sam, > > On Sat, Aug 15, 2020 at 12:02:30PM +0200, Sam Ravnborg wrote: > > > Hi Guido. > > > > > > > +static

Re: [PATCH 3/3] drm/panel: Add panel driver for the Mantix MLAF057WE51-X DSI panel

2020-08-15 Thread Guido Günther
truct mipi_dsi_device *dsi) > > +{ > > + struct mantix *ctx = mipi_dsi_get_drvdata(dsi); > > + int ret; > > + > > + mantix_shutdown(dsi); > > + > > + ret = mipi_dsi_detach(dsi); > > + if (ret < 0) > > + DRM_DEV_

[PATCH 0/3] drm/panel: Add panel driver for the Mantix MLAF057WE51-X DSI panel

2020-08-14 Thread Guido Günther
The panel uses a Focaltech FT8006p, the touch part is handled by the already existing edt-ft5x06. It can be found in e.g. the Librem 5. This series is against next-20200814. Guido Günther (3): dt-bindings: vendor-prefixes: Add mantix vendor prefix dt-bindings: Add Mantix MLAF057WE51-X panel

[PATCH 3/3] drm/panel: Add panel driver for the Mantix MLAF057WE51-X DSI panel

2020-08-14 Thread Guido Günther
The panel uses a Focaltech FT8006p, the touch part is handled by the already existing edt-ft5x06. Signed-off-by: Guido Günther --- MAINTAINERS | 7 + drivers/gpu/drm/panel/Kconfig | 11 + drivers/gpu/drm/panel/Makefile| 1

[PATCH 1/3] dt-bindings: vendor-prefixes: Add mantix vendor prefix

2020-08-14 Thread Guido Günther
Add prefix for Mantix Display Technology Co.,Ltd. Signed-off-by: Guido Günther --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor

[PATCH 2/3] dt-bindings: Add Mantix MLAF057WE51-X panel bindings

2020-08-14 Thread Guido Günther
The panel uses a Focaltech FT8006p, the touch part is handled by the already existing edt-ft5x06. Signed-off-by: Guido Günther --- .../display/panel/mantix,mlaf057we51-x.yaml | 73 +++ 1 file changed, 73 insertions(+) create mode 100644 Documentation/devicetree/bindings

Re: [PATCH v8 0/3] drm: Add support for Cadence MHDP DPI/DP bridge and J721E wrapper.

2020-08-12 Thread Guido Günther
Hi, On Wed, Aug 12, 2020 at 01:47:42PM +0300, Tomi Valkeinen wrote: > Hi Guido, > > On 12/08/2020 11:39, Guido Günther wrote: > > Hi, > > On Thu, Aug 06, 2020 at 01:34:29PM +0200, Swapnil Jakhade wrote: > >> This patch series adds new DRM bridge driver for C

Re: [PATCH v8 0/3] drm: Add support for Cadence MHDP DPI/DP bridge and J721E wrapper.

2020-08-12 Thread Guido Günther
Hi, On Thu, Aug 06, 2020 at 01:34:29PM +0200, Swapnil Jakhade wrote: > This patch series adds new DRM bridge driver for Cadence MHDP DPI/DP > bridge. The Cadence Display Port IP is also referred as MHDP (Mobile High > Definition Link, High-Definition Multimedia Interface, Display Port). > Cadence

Re: [PATCH 0/2] Fix st7703 panel initialization failures

2020-08-01 Thread Guido Günther
Hi Ondřej, On Thu, Jul 30, 2020 at 03:41:11PM +0200, Ondřej Jirman wrote: > Hello, > > On Wed, Jul 29, 2020 at 05:48:09PM +0200, Guido Günther wrote: > > Hi, > > On Sat, Jul 18, 2020 at 07:42:15PM +0200, Ondřej Jirman wrote: > > > Hello, > > > > &g

Re: [PATCH v9 2/5] drm/imx: Add initial support for DCSS on iMX8MQ

2020-07-31 Thread Guido Günther
d super-tiled buffers support (no graphics > decompression yet), no HDR10 and no video planes. > > Video planes support and HDR10 will be added in subsequent patches once > per-plane de-gamma/CSC/gamma support is in. > > Signed-off-by: Laurentiu Palcu > Reviewed-by: Lucas

Re: [PATCH v9 0/5] Add support for iMX8MQ Display Controller Subsystem

2020-07-31 Thread Guido Günther
Hi, On Fri, Jul 31, 2020 at 11:18:28AM +0300, Laurentiu Palcu wrote: > From: Laurentiu Palcu > > Hi, > > This patchset adds initial DCSS support for iMX8MQ chip. Initial support > includes only graphics plane support (no video planes), no HDR10 capabilities, > no graphics decompression (only

Re: [PATCH v9 5/5] dt-bindings: display: imx: add bindings for DCSS

2020-07-31 Thread Guido Günther
clock names >instead of their values; Reviewed-by: Guido Günther (and passed DT bindings check for me) -- Guido > > .../bindings/display/imx/nxp,imx8mq-dcss.yaml | 108 ++ > 1 file changed, 108 insertions(+) > create mode 100644 > Documentation/devicetree

Re: [PATCH v9 4/5] MAINTAINERS: Add entry for i.MX 8MQ DCSS driver

2020-07-31 Thread Guido Günther
Hi, On Fri, Jul 31, 2020 at 11:18:32AM +0300, Laurentiu Palcu wrote: > From: Laurentiu Palcu > > The driver is part of DRM subsystem and is located in > drivers/gpu/drm/imx/dcss. > > Signed-off-by: Laurentiu Palcu Reviewed-by: Guido Günther > --- > MAINTAINER

Re: [PATCH v9 1/5] drm/imx: compile imx directory by default

2020-07-31 Thread Guido Günther
IPUv3 core driver... > > The current patch would allow adding new IPs in the imx/ directory without > needing > to set DRM_IMX. Reviewed-by: Guido Günther > > Signed-off-by: Laurentiu Palcu > Reviewed-by: Lucas Stach > --- > drivers/gpu/drm/Makefile | 2 +-

Re: [PATCH v8 0/5] Add support for iMX8MQ Display Controller Subsystem

2020-07-30 Thread Guido Günther
Hi Laurentiu, On Thu, Jul 30, 2020 at 12:10:55PM +0300, Laurentiu Palcu wrote: > Hi Guido, > > On Wed, Jul 29, 2020 at 05:09:52PM +0200, Guido Günther wrote: > > Hi, > > On Wed, Jul 29, 2020 at 05:16:47PM +0300, Laurentiu Palcu wrote: > > > Hi Guido, > > &g

Re: [PATCH 0/2] Fix st7703 panel initialization failures

2020-07-29 Thread Guido Günther
Hi, On Sat, Jul 18, 2020 at 07:42:15PM +0200, Ondřej Jirman wrote: > Hello, > > On Sat, Jul 18, 2020 at 07:31:24PM +0200, Guido Günther wrote: > > Hi, > > On Thu, Jul 16, 2020 at 04:32:09PM +0200, Ondřej Jirman wrote: > > > Hi Guido, > > > > > >

Re: [PATCH v8 0/5] Add support for iMX8MQ Display Controller Subsystem

2020-07-29 Thread Guido Günther
Hi, On Wed, Jul 29, 2020 at 05:16:47PM +0300, Laurentiu Palcu wrote: > Hi Guido, > > On Wed, Jul 29, 2020 at 03:59:48PM +0200, Guido Günther wrote: > > Hi, > > On Fri, Jul 24, 2020 at 12:07:29PM +0300, Laurentiu Palcu wrote: > > > From: Laurentiu Palcu > > >

Re: [PATCH v8 0/5] Add support for iMX8MQ Display Controller Subsystem

2020-07-29 Thread Guido Günther
Hi, On Fri, Jul 24, 2020 at 12:07:29PM +0300, Laurentiu Palcu wrote: > From: Laurentiu Palcu > > Hi, > > This patchset adds initial DCSS support for iMX8MQ chip. Initial support > includes only graphics plane support (no video planes), no HDR10 capabilities, > no graphics decompression (only

Re: [PATCH v8 5/5] dt-bindings: display: imx: add bindings for DCSS

2020-07-29 Thread Guido Günther
Hi, On Fri, Jul 24, 2020 at 12:07:34PM +0300, Laurentiu Palcu wrote: > From: Laurentiu Palcu > > Add bindings for iMX8MQ Display Controller Subsystem. > > Signed-off-by: Laurentiu Palcu > Reviewed-by: Rob Herring > --- > .../bindings/display/imx/nxp,imx8mq-dcss.yaml | 104 ++

Re: [PATCH v8 2/5] drm/imx: Add initial support for DCSS on iMX8MQ

2020-07-29 Thread Guido Günther
Hi Laurentiu, On Fri, Jul 24, 2020 at 12:07:31PM +0300, Laurentiu Palcu wrote: > From: Laurentiu Palcu > > This adds initial support for iMX8MQ's Display Controller Subsystem (DCSS). > Some of its capabilities include: > * 4K@60fps; > * HDR10; > * one graphics and 2 video pipelines; > *

Re: [PATCH] drm/mxsfb: Make supported modifiers explicit

2020-07-20 Thread Guido Günther
Hi, On Mon, Jul 20, 2020 at 11:03:04AM +0200, Stefan Agner wrote: > On 2020-07-18 19:14, Guido Günther wrote: > > Hi, > > On Mon, Mar 23, 2020 at 04:51:05PM +0100, Lucas Stach wrote: > >> Am Montag, den 23.03.2020, 15:52 +0100 schrieb Guido Günther: > >> > In c

[PATCH v1 0/1] drm/bridge: nwl-dsi: Drop DRM_BRIDGE_ATTACH_NO_CONNECTOR check.

2020-07-18 Thread Guido Günther
We don't create a connector but let panel_bridge handle that so there's no point in rejecting DRM_BRIDGE_ATTACH_NO_CONNECTOR. This was prompted by Sam in https://lore.kernel.org/dri-devel/20200718115734.ga2989...@ravnborg.org/ Signed-off-by: Guido Günther Guido Günther (1): drm/bridge: nwl

[PATCH v1 1/1] drm/bridge: nwl-dsi: Drop DRM_BRIDGE_ATTACH_NO_CONNECTOR check.

2020-07-18 Thread Guido Günther
We don't create a connector but let panel_bridge handle that so there's no point in rejecting DRM_BRIDGE_ATTACH_NO_CONNECTOR. Signed-off-by: Guido Günther --- drivers/gpu/drm/bridge/nwl-dsi.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/bridge/nwl-dsi.c b/drivers/gpu

Re: [PATCH 0/2] Fix st7703 panel initialization failures

2020-07-18 Thread Guido Günther
Hi, On Thu, Jul 16, 2020 at 04:32:09PM +0200, Ondřej Jirman wrote: > Hi Guido, > > On Thu, Jul 16, 2020 at 04:08:43PM +0200, Guido Günther wrote: > > Hi Ondrej, > > On Thu, Jul 16, 2020 at 02:37:51PM +0200, Ondrej Jirman wrote: > > > When extending the driver fo

Re: [PATCH] drm/mxsfb: Make supported modifiers explicit

2020-07-18 Thread Guido Günther
Hi, On Mon, Mar 23, 2020 at 04:51:05PM +0100, Lucas Stach wrote: > Am Montag, den 23.03.2020, 15:52 +0100 schrieb Guido Günther: > > In contrast to other display controllers on imx like DCSS and ipuv3 > > lcdif/mxsfb does not support detiling e.g. vivante tiled layouts. > > Si

Re: [PATCH 2/2] dt-binding: display: Allow a single port node on rocktech,jh057n00900

2020-07-18 Thread Guido Günther
057n00900.yaml > +++ > b/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml > @@ -24,6 +24,7 @@ properties: > # Xingbangda XBD599 5.99" 720x1440 TFT LCD panel >- xingbangda,xbd599 > > + port: true >reg: > maxItems

Re: [PATCH 1/2] dt-bindings: display: Fix example in nwl-dsi.yaml

2020-07-18 Thread Guido Günther
port@0 { > - reg = <0>; > + vcc-supply = <_2v8_p>; > + iovcc-supply = <_1v8_p>; > + reset-gpios = < 13 GPIO_ACTIVE_LOW>; > + port { &

Re: [PATCH v6 2/4] drm/imx: Add initial support for DCSS on iMX8MQ

2020-07-18 Thread Guido Günther
Hi, On Fri, Jul 17, 2020 at 09:48:49PM +0200, Sam Ravnborg wrote: > Hi Laurentiu. > > On Fri, Jul 17, 2020 at 05:41:27PM +0300, Laurentiu Palcu wrote: > > From: Laurentiu Palcu > > > > This adds initial support for iMX8MQ's Display Controller Subsystem (DCSS). > > Some of its capabilities

Re: [PATCH 0/2] Fix st7703 panel initialization failures

2020-07-16 Thread Guido Günther
Hi Ondrej, On Thu, Jul 16, 2020 at 02:37:51PM +0200, Ondrej Jirman wrote: > When extending the driver for xbd599 panel support I tried to do minimal > changes and keep the existing initialization timing. > > It turned out that it's not good enough and the existing init sequence > is too

Re: [PATCH] MAINTAINERS: Update entry for st7703 driver after the rename

2020-07-02 Thread Guido Günther
m-rm67191.c > > -DRM DRIVER FOR ROCKTECH JH057N00900 PANELS > +DRM DRIVER FOR SITRONIX ST7703 PANELS > M: Guido Günther > R: Purism Kernel Team > +R: Ondrej Jirman > S: Maintained > -F: Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.t

Re: [PATCH v6 10/13] drm/panel: st7703: Enter sleep after display off

2020-07-01 Thread Guido Günther
Hi, On Wed, Jul 01, 2020 at 12:31:23PM +0200, Ondrej Jirman wrote: > The datasheet suggests to issue sleep in after display off > as a part of the panel's shutdown sequence. Out of curiosity: which exact datasheet did you use? Reviewed-by: Guido Günther > > Signed-off-by: O

Re: [PATCH v6 11/13] drm/panel: st7703: Assert reset prior to powering down the regulators

2020-07-01 Thread Guido Günther
Hi, On Wed, Jul 01, 2020 at 12:31:24PM +0200, Ondrej Jirman wrote: > The reset pin is inverted, so if we don't assert reset, the actual gpio > will be high and may keep driving the IO port of the panel. Reviewed-by: Guido Günther > > Signed-off-by: Ondrej Jirman > Reviewed-by

Re: [PATCH v6 09/13] drm/panel: st7703: Add support for Xingbangda XBD599

2020-07-01 Thread Guido Günther
Hi, On Wed, Jul 01, 2020 at 12:31:22PM +0200, Ondrej Jirman wrote: > Xingbangda XBD599 is a 5.99" 720x1440 MIPI-DSI LCD panel used in > PinePhone. Add support for it. Reviewed-by: Guido Günther > > Signed-off-by: Icenowy Zheng > Signed-off-by: Ondrej Jirman > Rev

Re: [PATCH v6 08/13] drm/panel: st7703: Move generic part of init sequence to enable callback

2020-07-01 Thread Guido Günther
Hi, On Wed, Jul 01, 2020 at 12:31:21PM +0200, Ondrej Jirman wrote: > Calling sleep out and display on is a controller specific part > of the initialization process. Move it out of the panel specific > initialization function to the enable callback. Reviewed-by: Guido Günther >

Re: [PATCH v6 07/13] drm/panel: st7703: Move code specific to jh057n closer together

2020-07-01 Thread Guido Günther
Hi, On Wed, Jul 01, 2020 at 12:31:20PM +0200, Ondrej Jirman wrote: > It's better than having it spread around the driver. Reviewed-by: Guido Günther > > Signed-off-by: Ondrej Jirman > Reviewed-by: Linus Walleij > --- > drivers/gpu/drm/panel/panel-sitr

Re: [PATCH v6 06/13] drm/panel: st7703: Prepare for supporting multiple panels

2020-07-01 Thread Guido Günther
Hi, On Wed, Jul 01, 2020 at 12:31:19PM +0200, Ondrej Jirman wrote: > Parametrize the driver so that it can support more panels based > on st7703 controller. Reviewed-by: Guido Günther > > Signed-off-by: Ondrej Jirman > Reviewed-by: Linus Walleij > --- > drivers/gpu/drm

Re: [PATCH v6 05/13] drm/panel: st7703: Rename functions from jh057n prefix to st7703

2020-07-01 Thread Guido Günther
Hi, On Wed, Jul 01, 2020 at 12:31:18PM +0200, Ondrej Jirman wrote: > This is done so that code that's not specific to a particular > jh057n panel is named after the controller. Functions specific > to the panel are kept named after the panel. Reviewed-by: Guido Günther >

Re: [PATCH v6 04/13] drm/panel: rocktech-jh057n00900: Rename the driver to st7703

2020-07-01 Thread Guido Günther
nges. Reviewed-by: Guido Günther > > Signed-off-by: Ondrej Jirman > Reviewed-by: Linus Walleij > --- > drivers/gpu/drm/panel/Kconfig | 26 +-- > drivers/gpu/drm/panel/Makefile| 2 +- > ...-jh057n00900.c => panel-sitroni

Re: [PATCH v6 02/13] dt-bindings: panel: Convert rocktech,jh057n00900 to yaml

2020-07-01 Thread Guido Günther
Hi Ondrej, On Wed, Jul 01, 2020 at 12:31:15PM +0200, Ondrej Jirman wrote: > Convert Rocktech MIPI DSI panel driver from txt to yaml bindings. > > Signed-off-by: Ondrej Jirman > --- > .../display/panel/rocktech,jh057n00900.txt| 23 --- > .../display/panel/rocktech,jh057n00900.yaml | 66

Re: [PATCH v6 00/13] Add support for PinePhone LCD panel

2020-07-01 Thread Guido Günther
Hi, On Wed, Jul 01, 2020 at 12:31:13PM +0200, Ondrej Jirman wrote: > This patchset adds support for the LCD panel of PinePhone. I gave this a quick spin on the Librem5 devkit so Tested-by: Guido Günther but please also adjust MAINTAINERS so we stay in the loop on driver changes. Che

Re: [PATCH 0/5] drm/etnaviv: Ignore MC bit when checking for runtime suspend

2020-06-25 Thread Guido Günther
Hi, On Tue, Mar 03, 2020 at 12:55:04PM +0100, Lucas Stach wrote: > On Mo, 2020-03-02 at 20:13 +0100, Guido Günther wrote: > > At least GC7000 fails to enter runtime suspend for long periods of time > > since > > the MC becomes busy again even when the FE is idle. The rest of

Re: [RFC PATCH 1/6] dt-bindings: display/bridge: Add binding for input mux bridge

2020-05-30 Thread Guido Günther
Hi Rob, On Thu, May 28, 2020 at 01:48:04PM -0600, Rob Herring wrote: > On Fri, May 15, 2020 at 03:12:10PM +0200, Guido Günther wrote: > > The bridge allows to select the input source via a mux controller. > > > > Signed-off-by: Guido Günther > > --- > > .../dis

Re: [RFC PATCH 3/6] dt-bindings: display/bridge/nwl-dsi: Drop mux handling

2020-05-28 Thread Guido Günther
Hi Rob, On Thu, May 28, 2020 at 01:59:14PM -0600, Rob Herring wrote: > On Fri, May 15, 2020 at 03:12:12PM +0200, Guido Günther wrote: > > No need to encode the SoC specifics in the bridge driver. For the > > imx8mq we can use the mux-input-bridge. > > You can't just

Re: [PATCH 10/27] drm: bridge: Pass drm_display_info to drm_bridge_funcs .mode_valid()

2020-05-26 Thread Guido Günther
drm_display_info *info, > const struct drm_display_mode *mode) > { > switch (venc_get_videomode(mode)) { > diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h > index ea2aa5ebae34..e3d7f36d8c39 100644 > --- a/include/drm/drm_br

[RFC PATCH 4/6] drm/bridge/nwl-dsi: Drop mux handling

2020-05-15 Thread Guido Günther
This will be handled via the mux-input-bridge. Signed-off-by: Guido Günther --- drivers/gpu/drm/bridge/Kconfig | 1 - drivers/gpu/drm/bridge/nwl-dsi.c | 61 2 files changed, 62 deletions(-) diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge

[RFC PATCH 2/6] drm/bridge: Add mux-input bridge

2020-05-15 Thread Guido Günther
This bridge allows to select the input source via a mux controller. The input source is determined via DT but it could become rutime selectable in the future. Signed-off-by: Guido Günther --- drivers/gpu/drm/bridge/Kconfig | 9 ++ drivers/gpu/drm/bridge/Makefile| 1 + drivers/gpu

[RFC PATCH 1/6] dt-bindings: display/bridge: Add binding for input mux bridge

2020-05-15 Thread Guido Günther
The bridge allows to select the input source via a mux controller. Signed-off-by: Guido Günther --- .../display/bridge/mux-input-bridge.yaml | 123 ++ 1 file changed, 123 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/bridge/mux-input

[RFC PATCH 5/6] arm64: dts: imx8mq: Add NWL dsi controller

2020-05-15 Thread Guido Günther
Add a node for the Northwestlogic MIPI DSI IP core, "disabled" by default. Signed-off-by: Guido Günther --- arch/arm64/boot/dts/freescale/imx8mq.dtsi | 31 +++ 1 file changed, 31 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm6

[RFC PATCH 3/6] dt-bindings: display/bridge/nwl-dsi: Drop mux handling

2020-05-15 Thread Guido Günther
No need to encode the SoC specifics in the bridge driver. For the imx8mq we can use the mux-input-bridge. Signed-off-by: Guido Günther --- .../devicetree/bindings/display/bridge/nwl-dsi.yaml | 6 -- 1 file changed, 6 deletions(-) diff --git a/Documentation/devicetree/bindings

<    1   2   3   4   5   >