Re: [gpu-drm-radeon] question about potential dead code in vce_v2_0_enable_mgcg()

2017-06-28 Thread Gustavo A. R. Silva
Hi Alex, Quoting "Deucher, Alexander" <alexander.deuc...@amd.com>: -Original Message----- From: Gustavo A. R. Silva [mailto:garsi...@embeddedor.com] Sent: Wednesday, June 28, 2017 10:22 AM To: Deucher, Alexander; Koenig, Christian; David Airlie Cc: amd-...@lists.freedeskto

[PATCH] gpu: drm: mgag200: remove unnecessary variable in mga_crtc_mode_set

2017-06-15 Thread Gustavo A. R. Silva
other operation. Addresses-Coverity-ID: 1397681 Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/gpu/drm/mgag200/mgag200_mode.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/g

[PATCH] drm/radeon: remove unnecessary variable in si_enable_smc_cac

2017-06-15 Thread Gustavo A. R. Silva
a value in it (lines of code 2833 and 2838). Besides, by removing this variable the logic can be simplified and the number of nested IF statements reduced. Addresses-Coverity-ID: 1226969 Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/gpu/drm/radeon/si_dpm.

Re: [PATCH] gpu: drm: gma500: remove two more dead variable

2017-05-22 Thread Gustavo A. R. Silva
*mode; - struct drm_psb_private *dev_priv = dev->dev_private; - struct oaktrail_timing_info *ti = _priv->gct_data.DTD; mode = kzalloc(sizeof(*mode), GFP_KERNEL); if (!mode) -- 2.9.0 Thank you! -- Gustavo A. R. Silva ___ dri-

[PATCH] gpu: drm: nouveau: add null check before pointer dereference

2017-05-22 Thread Gustavo A. R. Silva
Add null check before dereferencing pointer asyc Addresses-Coverity-ID: 1397932 Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/gpu/drm/nouveau/nv50_display.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nv50_displa

[PATCH v2] gpu: drm: gma500: remove dead code

2017-05-19 Thread Gustavo A. R. Silva
Local variable use_gct is assigned to a constant value and it is never updated again. Remove this variable and the dead code it guards. Addresses-Coverity-ID: 145690 Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- Changes in v2: Remove variables ti and dev_priv,

[PATCH] gpu: drm: radeon: refactor code

2017-05-17 Thread Gustavo A. R. Silva
Local variable _color_ is assigned to a constant value and it is never updated again. Remove this variable and refactor the code it affects. Addresses-Coverity-ID: 1226745 Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/gpu/drm/radeon/radeon_legacy_encoders

[PATCH 2/2] gpu: drm: i915: compress logic into one line

2017-05-15 Thread Gustavo A. R. Silva
Simplify logic to avoid unnecessary variable declaration and assignment. Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/gpu/drm/i915/intel_display.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/d

[PATCH 1/2] gpu: drm: i915: remove dead code

2017-05-15 Thread Gustavo A. R. Silva
Local variable has_reduced_clock is assigned to a constant value and it is never updated again. Remove this variable and the dead code it guards. Addresses-Coverity-ID: 1362230 Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/gpu/drm/i915/intel_display.c | 9 +-

[PATCH] gpu: drm: gma500: remove dead code

2017-05-09 Thread Gustavo A. R. Silva
Local variable use_gct is assigned to a constant value and it is never updated again. Remove this variable and the dead code it guards. Addresses-Coverity-ID: 145690 Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/gpu/drm/gma500/mdfld_tpo_vid.

[PATCH] gpu: drm: gma500: remove dead code

2017-05-09 Thread Gustavo A. R. Silva
Local variable pipe is assigned to a constant value and it is never updated again. Remove this variable and the dead code it guards. Addresses-Coverity-ID: 201351 Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/gpu/drm/gma500/oaktrail_hdmi.c | 21 ++

[PATCH] gpu: drm: amd: amdgpu: remove dead code

2017-05-08 Thread Gustavo A. R. Silva
Local variable use_doorbell is assigned to a constant value and it is never updated again. Remove this variable and the dead code it guards. Addresses-Coverity-ID: 1401837 Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/gpu/drm/amd/amdgpu/gfx_v7_0.

[PATCH] gpu: drm: amd: amdgpu: remove dead code

2017-05-08 Thread Gustavo A. R. Silva
Local variable use_doorbell is assigned to a constant value and it is never updated again. Remove this variable and the dead code it guards. Addresses-Coverity-ID: 1401828 Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> --- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.

<    1   2   3   4   5