Re: [PATCH RFC v2 04/11] ARM: dts: omap4: Add device tree entry for SGX GPU

2024-01-15 Thread H. Nikolaus Schaller
Hi, > Am 15.01.2024 um 09:25 schrieb Maxime Ripard : > > Hi, > > On Fri, Jan 12, 2024 at 06:33:58PM +0100, H. Nikolaus Schaller wrote: >>> Am 08.01.2024 um 19:32 schrieb Andrew Davis : >>> >>> Add SGX GPU device entry to base OMAP4 dtsi

Re: [PATCH RFC v2 04/11] ARM: dts: omap4: Add device tree entry for SGX GPU

2024-01-12 Thread H . Nikolaus Schaller
Hi, I just comment on this example, but it applies almost the same for all other .dtsi changes. > Am 08.01.2024 um 19:32 schrieb Andrew Davis : > > Add SGX GPU device entry to base OMAP4 dtsi file. > > Signed-off-by: Andrew Davis > --- > arch/arm/boot/dts/ti/omap/omap4.dtsi | 9 + > 1

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-21 Thread H. Nikolaus Schaller
> Am 21.12.2023 um 09:58 schrieb Maxime Ripard : > > Cool, so what you're saying is that your plan is to support those GPUs > upstream in the imagination driver? Yes, I would like to see PowerVR Series 5 SGX supported upstream since there are still so many devices in the wild which could use

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-18 Thread H. Nikolaus Schaller
> Am 18.12.2023 um 11:14 schrieb Maxime Ripard : > > On Mon, Dec 18, 2023 at 10:28:09AM +0100, H. Nikolaus Schaller wrote: >> Hi Maxime, >> >>> Am 15.12.2023 um 14:33 schrieb Maxime Ripard : >>> >>>>> >>>>> It'

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-18 Thread H . Nikolaus Schaller
Hi Maxime, > Am 15.12.2023 um 14:33 schrieb Maxime Ripard : > >>> >>> It's for a separate architecture, with a separate driver, maintained out >>> of tree by a separate community, with a separate set of requirements as >>> evidenced by the other thread. And that's all fine in itself, but >>>

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-07 Thread H. Nikolaus Schaller
Hi Maxime, > Am 07.12.2023 um 10:20 schrieb Maxime Ripard : > > On Tue, Dec 05, 2023 at 02:50:08PM +0100, H. Nikolaus Schaller wrote: >> Hi, >> >>> Am 05.12.2023 um 14:29 schrieb Maxime Ripard : >>> >>> Hi, >>> >>> On Tue, Dec

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-06 Thread H . Nikolaus Schaller
(non-html) > Am 06.12.2023 um 17:15 schrieb Andrew Davis : > > On 12/6/23 10:02 AM, Conor Dooley wrote: >> On Tue, Dec 05, 2023 at 07:04:05PM +0100, H. Nikolaus Schaller wrote: >>>> Am 05.12.2023 um 18:33 schrieb Andrew Davis : >>>> >>>

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-06 Thread H. Nikolaus Schaller
> Am 06.12.2023 um 17:15 schrieb Andrew Davis : > > On 12/6/23 10:02 AM, Conor Dooley wrote: >> On Tue, Dec 05, 2023 at 07:04:05PM +0100, H. Nikolaus Schaller wrote: >>>> Am 05.12.2023 um 18:33 schrieb Andrew Davis : >>>> >>>

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-06 Thread H. Nikolaus Schaller
> Am 06.12.2023 um 17:02 schrieb Conor Dooley : > > On Tue, Dec 05, 2023 at 07:04:05PM +0100, H. Nikolaus Schaller wrote: >>> Am 05.12.2023 um 18:33 schrieb Andrew Davis : >>> >>> On 12/5/23 2:17 AM, H. Nikolaus Schaller wrote: >>>>> +

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-05 Thread H. Nikolaus Schaller
> Am 05.12.2023 um 18:33 schrieb Andrew Davis : > > On 12/5/23 2:17 AM, H. Nikolaus Schaller wrote: >>> + - enum: >>> + - ti,omap3430-gpu # Rev 121 >>> + - ti,omap3630-gpu # Rev 125 >> Is the "Rev 121&q

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-05 Thread H. Nikolaus Schaller
Hi, > Am 05.12.2023 um 14:29 schrieb Maxime Ripard : > > Hi, > > On Tue, Dec 05, 2023 at 09:18:58AM +0100, H. Nikolaus Schaller wrote: >>> Am 05.12.2023 um 07:57 schrieb Maxime Ripard : >>> >>> On Mon, Dec 04, 2023 at 12:22:36PM -0600, Andrew Davis w

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-05 Thread H. Nikolaus Schaller
> Am 05.12.2023 um 07:57 schrieb Maxime Ripard : > > On Mon, Dec 04, 2023 at 12:22:36PM -0600, Andrew Davis wrote: >> The Imagination PowerVR Series5 "SGX" GPU is part of several SoCs from >> multiple vendors. Describe how the SGX GPU is integrated in these SoC, >> including register space and

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-05 Thread H. Nikolaus Schaller
Hi Andrew, > Am 04.12.2023 um 19:22 schrieb Andrew Davis : > > The Imagination PowerVR Series5 "SGX" GPU is part of several SoCs from > multiple vendors. Great and thanks for the new attempt to get at least the Device Tree side upstream. Really appreciated! > Describe how the SGX GPU is

Re: [PATCH v9 00/20] Imagination Technologies PowerVR DRM driver

2023-11-23 Thread H. Nikolaus Schaller
> Am 22.11.2023 um 20:34 schrieb Maxime Ripard : > > Hi, > > On Wed, Nov 22, 2023 at 04:34:21PM +, Donald Robson wrote: >> This patch series adds the initial DRM driver for Imagination Technologies >> PowerVR >> GPUs, starting with those based on our Rogue architecture. It's worth >>

Re: [PATCH] drm/mipi-dsi: Fix detach call without attach

2023-09-22 Thread H. Nikolaus Schaller
> This patch works equally well as my proposal and is indeed a better solution (solving the issue and not just suppressing a warning). Tested-by: H. Nikolaus Schaller BR and thanks, Nikolaus

[PATCH] omap: dsi: do not WARN on detach if dsidev was never attached

2023-09-19 Thread H. Nikolaus Schaller
fa0: [7.682435] 5fc0: [7.691038] 5fe0: 0013 Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/

Re: [PATCH] drm/omap: dsi: Fix deferred probe warnings

2023-09-16 Thread H. Nikolaus Schaller
Hi Tomi and Tony, > Am 13.09.2023 um 13:59 schrieb Tomi Valkeinen > : > > On 12/04/2023 10:39, Tony Lindgren wrote: >> We may not have dsi->dsidev initialized during probe, and that can >> lead into various dsi related warnings as omap_dsi_host_detach() gets >> called with dsi->dsidev set to

Re: [PATCH v3 00/17] Imagination Technologies PowerVR DRM driver

2023-06-26 Thread H. Nikolaus Schaller
Hi Frank, I have added Merlijn who is doing a lot with PVRSGX for Maemo-Leste and the phone-devel list since most SoC we find using a PVRSGX are smartphone processors. > Am 26.06.2023 um 15:45 schrieb Frank Binns : > > Hi Nikolaus, > >> >> Some questions to the author of the new driver: >> -

Re: [PATCH v3 00/17] Imagination Technologies PowerVR DRM driver

2023-06-16 Thread H . Nikolaus Schaller
Hi Linus, thanks for sharing this conversation with me. > Am 16.06.2023 um 14:29 schrieb Linus Walleij : > > Hi Sarah, > > thanks for starting this long awaited work! > > On Tue, Jun 13, 2023 at 5:20 PM Sarah Walker wrote: > >> This patch series adds the initial DRM driver for Imagination

Re: [PATCH v3 00/17] Imagination Technologies PowerVR DRM driver

2023-06-16 Thread H. Nikolaus Schaller
Hi Linus, thanks for sharing this conversation with me. > Am 16.06.2023 um 14:29 schrieb Linus Walleij : > > Hi Sarah, > > thanks for starting this long awaited work! > > On Tue, Jun 13, 2023 at 5:20 PM Sarah Walker wrote: > >> This patch series adds the initial DRM driver for Imagination

Re: [PATCH] drm/omap: dsi: Fix deferred probe warnings

2023-04-12 Thread H. Nikolaus Schaller
> Am 12.04.2023 um 10:50 schrieb Laurent Pinchart > : > > Hi Tony, > > Thank you for the patch. > > On Wed, Apr 12, 2023 at 10:39:53AM +0300, Tony Lindgren wrote: >> We may not have dsi->dsidev initialized during probe, and that can >> lead into various dsi related warnings as

Re: [PATCH 3/3] drm: omapdrm: Do no allocate non-scanout GEMs through DMM/TILER

2022-10-31 Thread H. Nikolaus Schaller
Hi Ivaylo, > Am 31.10.2022 um 10:58 schrieb Ivaylo Dimitrov : > > > > On 31.10.22 г. 9:57 ч., H. Nikolaus Schaller wrote: >>> Am 31.10.2022 um 08:44 schrieb H. Nikolaus Schaller : >>> >>> Hi Ivaylo, >>> >>>> Am 31.10.2022

Re: [PATCH 3/3] drm: omapdrm: Do no allocate non-scanout GEMs through DMM/TILER

2022-10-31 Thread H. Nikolaus Schaller
> Am 31.10.2022 um 08:44 schrieb H. Nikolaus Schaller : > > Hi Ivaylo, > >> Am 31.10.2022 um 08:05 schrieb Ivaylo Dimitrov : >> >> HI Nikolaus, >> >> On 31.10.22 г. 0:08 ч., H. Nikolaus Schaller wrote: >>> Hi Ivaylo, >>> it too

Re: [PATCH 3/3] drm: omapdrm: Do no allocate non-scanout GEMs through DMM/TILER

2022-10-31 Thread H. Nikolaus Schaller
Hi Ivaylo, > Am 31.10.2022 um 08:05 schrieb Ivaylo Dimitrov : > > HI Nikolaus, > > On 31.10.22 г. 0:08 ч., H. Nikolaus Schaller wrote: >> Hi Ivaylo, >> it took a while until I found time to test newer kernels (mainline + Letux >> additions) >> on the OMA

Re: [PATCH 3/3] drm: omapdrm: Do no allocate non-scanout GEMs through DMM/TILER

2022-10-30 Thread H. Nikolaus Schaller
Hi Ivaylo, it took a while until I found time to test newer kernels (mainline + Letux additions) on the OMAP5 Pyra but unfortunately I did not get screen display for v6.1. Even worse, the console was flooded by [ 39.419846] WARNING: CPU: 0 PID: 3673 at drivers/bus/omap_l3_noc.c:139

[PATCH v18 2/3] drm/ingenic: Implement proper .atomic_get_input_bus_fmts

2022-04-07 Thread H. Nikolaus Schaller
that the encoder does not support. Signed-off-by: Paul Cercueil Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 28 ++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c b/drivers/gpu/drm

[PATCH v18 3/3] drm/ingenic: Add dw-hdmi driver specialization for jz4780

2022-04-07 Thread H. Nikolaus Schaller
drm_kms_helper_hotplug_event() introduced before. Also note that we disable Color Space Conversion since it is not working on jz4780. Signed-off-by: Paul Boddie Signed-off-by: Ezequiel Garcia Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/ingenic/Kconfig | 9 ++ drivers/gpu/drm

[PATCH v18 1/3] drm/bridge: display-connector: add ddc-en gpio support

2022-04-07 Thread H. Nikolaus Schaller
I20 board work. Now, the driver activates the ddc gpio after probe and deactivates after remove so it is "almost on". But only if this driver is loaded (and not e.g. blacklisted as module). Signed-off-by: H. Nikolaus Schaller Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/b

[PATCH v18 0/3] MIPS: JZ4780 and CI20 HDMI

2022-04-07 Thread H. Nikolaus Schaller
(suggested by laurent.pinch...@ideasonboard.com and p...@crapouillou.net) PATCH V2 2021-08-05 16:08:05: - code and commit messages revisited for checkpatch warnings - rebased on v5.14-rc4 - include (failed, hence RFC 8/8) attempt to convert to component framework (was suggested by Paul Cercue

Re: [PATCH v17 5/6] drm/bridge: dw-hdmi: add YCBCR formats only if CSC is available

2022-04-07 Thread H. Nikolaus Schaller
> Am 07.04.2022 um 10:29 schrieb Neil Armstrong : > > On 06/04/2022 18:26, H. Nikolaus Schaller wrote: >> otherwise they will produce a black HDMI screen. >> Signed-off-by: H. Nikolaus Schaller >> --- >> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 6 --

Re: [PATCH v17 6/6] drm/bridge: display-connector: add ddc-en gpio support

2022-04-07 Thread H. Nikolaus Schaller
Hi Laurent, > Am 07.04.2022 um 09:30 schrieb Laurent Pinchart > : > > Hi Nikolaus, > > Thank you for the patch. > > On Wed, Apr 06, 2022 at 06:26:08PM +0200, H. Nikolaus Schaller wrote: >> "hdmi-connector.yaml" bindings defines an optional prop

Re: [PATCH v17 4/6] drm/bridge: dw-hdmi: handle unusable or non-configured CSC module

2022-04-07 Thread H. Nikolaus Schaller
Hi Neil, > Am 07.04.2022 um 10:28 schrieb Neil Armstrong : > > Hi, > > On 06/04/2022 18:26, H. Nikolaus Schaller wrote: >> From: Neil Armstrong >> The dw-hdmi integrates an optional Color Space Conversion feature used >> to handle color-space conversions. &g

[PATCH v17 2/6] drm/ingenic: Add dw-hdmi driver specialization for jz4780

2022-04-06 Thread H. Nikolaus Schaller
drm_kms_helper_hotplug_event() introduced before. Also note that we disable Color Space Conversion since it is not working on jz4780. Signed-off-by: Paul Boddie Signed-off-by: Ezequiel Garcia Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/ingenic/Kconfig | 9 ++ drivers/gpu/drm

[PATCH v17 4/6] drm/bridge: dw-hdmi: handle unusable or non-configured CSC module

2022-04-06 Thread H. Nikolaus Schaller
to force using the same input bus format as the output bus format. Signed-off-by: Neil Armstrong Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 100 +++--- drivers/gpu/drm/bridge/synopsys/dw-hdmi.h | 1 + include/drm/bridge/dw_hdmi.h

[PATCH v17 3/6] drm/bridge: dw-hdmi: filter out YUV output formats when DVI

2022-04-06 Thread H. Nikolaus Schaller
-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index a563460f8d209..f50af40e10340 100644 --- a/drive

[PATCH v17 0/6] MIPS: JZ4780 and CI20 HDMI

2022-04-06 Thread H. Nikolaus Schaller
PU into separate patch - use FIELD_PREP() - [patch 8/8] conversion to component framework dropped (suggested by laurent.pinch...@ideasonboard.com and p...@crapouillou.net) PATCH V2 2021-08-05 16:08:05: - code and commit messages revisited for checkpatch warnings - rebased on v5.14-rc4 - incl

[PATCH v17 6/6] drm/bridge: display-connector: add ddc-en gpio support

2022-04-06 Thread H. Nikolaus Schaller
I20 board work. Now, the driver activates the ddc gpio after probe and deactivates after remove so it is "almost on". But only if this driver is loaded (and not e.g. blacklisted as module). Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/bridge/display-connector.c | 15 +

[PATCH v17 5/6] drm/bridge: dw-hdmi: add YCBCR formats only if CSC is available

2022-04-06 Thread H. Nikolaus Schaller
otherwise they will produce a black HDMI screen. Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c

[PATCH v17 1/6] drm/ingenic: Implement proper .atomic_get_input_bus_fmts

2022-04-06 Thread H. Nikolaus Schaller
that the encoder does not support. Signed-off-by: Paul Cercueil Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 28 ++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c b/drivers/gpu/drm

Re: [Letux-kernel] [PATCH v16 1/4] drm/bridge: dw-hdmi: introduce dw_hdmi_enable_poll()

2022-03-04 Thread H. Nikolaus Schaller
Hi Paul, > Am 04.03.2022 um 19:41 schrieb H. Nikolaus Schaller : > > > >> Am 04.03.2022 um 19:33 schrieb Paul Cercueil : >> >> >> >> Le ven., mars 4 2022 at 19:15:13 +0100, H. Nikolaus Schaller >> a écrit : >>> Hi Paul, >&g

Re: [Letux-kernel] [PATCH v16 1/4] drm/bridge: dw-hdmi: introduce dw_hdmi_enable_poll()

2022-03-04 Thread H. Nikolaus Schaller
> Am 04.03.2022 um 19:33 schrieb Paul Cercueil : > > > > Le ven., mars 4 2022 at 19:15:13 +0100, H. Nikolaus Schaller > a écrit : >> Hi Paul, >>> Am 04.03.2022 um 19:04 schrieb Paul Cercueil : >>> Le ven., mars 4 2022 at 18:51:14 +0100, H. Niko

Re: [Letux-kernel] [PATCH v16 1/4] drm/bridge: dw-hdmi: introduce dw_hdmi_enable_poll()

2022-03-04 Thread H. Nikolaus Schaller
Hi Paul, > Am 04.03.2022 um 19:04 schrieb Paul Cercueil : > > > > Le ven., mars 4 2022 at 18:51:14 +0100, H. Nikolaus Schaller > a écrit : >> Hi Paul, Neil, >>> Am 04.03.2022 um 17:47 schrieb Paul Cercueil : >>> From what I understood in Nikola

Re: [Letux-kernel] [PATCH v16 1/4] drm/bridge: dw-hdmi: introduce dw_hdmi_enable_poll()

2022-03-04 Thread H. Nikolaus Schaller
Hi Paul, Neil, > Am 04.03.2022 um 17:47 schrieb Paul Cercueil : > > From what I understood in Nikolaus' last message, HDMI hotplug is actually > correctly detected, so there's no need for polling. What is missing is the > call to drm_kms_helper_hotplug_event *somewhere*, so that the

Re: [Letux-kernel] [PATCH v16 1/4] drm/bridge: dw-hdmi: introduce dw_hdmi_enable_poll()

2022-03-03 Thread H. Nikolaus Schaller
Hi Paul, Neil, > Am 03.03.2022 um 18:20 schrieb Paul Cercueil : > > Hi Nikolaus, > > [snip] > >>> Well he said "the Ingenic DRM core" aka ingenic-drm-drv.c. You do have >>> access to the main drm_device in the ingenic_drm_bind() function, so you >>> can add it there (with a cleanup function

Re: [Letux-kernel] [PATCH v16 1/4] drm/bridge: dw-hdmi: introduce dw_hdmi_enable_poll()

2022-03-03 Thread H. Nikolaus Schaller
Hi Paul, > Am 03.03.2022 um 17:51 schrieb Paul Cercueil : > > Hi Nikolaus, > > Le jeu., mars 3 2022 at 17:43:05 +0100, H. Nikolaus Schaller > a écrit : >> Hi Neil, >>> Am 03.03.2022 um 17:30 schrieb H. Nikolaus Schaller : >>> Hi Neil, >>

Re: [PATCH v16 1/4] drm/bridge: dw-hdmi: introduce dw_hdmi_enable_poll()

2022-03-03 Thread H. Nikolaus Schaller
Hi Paul and Neil, > Am 03.03.2022 um 17:46 schrieb Paul Cercueil : > > Hi Neil, > > Le jeu., mars 3 2022 at 17:23:02 +0100, Neil Armstrong > a écrit : >> Hi, >> On 26/02/2022 18:12, H. Nikolaus Schaller wrote: >>> so that specialization drivers

Re: [Letux-kernel] [PATCH v16 1/4] drm/bridge: dw-hdmi: introduce dw_hdmi_enable_poll()

2022-03-03 Thread H. Nikolaus Schaller
Hi Neil, > Am 03.03.2022 um 17:30 schrieb H. Nikolaus Schaller : > > Hi Neil, > >> Am 03.03.2022 um 17:23 schrieb Neil Armstrong : >> >> Hi, >> >> On 26/02/2022 18:12, H. Nikolaus Schaller wrote: >>> so that specialization drivers like ingen

Re: [PATCH v16 1/4] drm/bridge: dw-hdmi: introduce dw_hdmi_enable_poll()

2022-03-03 Thread H. Nikolaus Schaller
Hi Neil, > Am 03.03.2022 um 17:23 schrieb Neil Armstrong : > > Hi, > > On 26/02/2022 18:12, H. Nikolaus Schaller wrote: >> so that specialization drivers like ingenic-dw-hdmi can enable polling. >> Signed-off-by: H. Nikolaus Schaller >> --- >> driver

Re: [PATCH v16 4/4] drm/bridge: dw-hdmi: fix bus formats negotiation for 8 bit modes

2022-03-03 Thread H. Nikolaus Schaller
Hi Neil, > Am 03.03.2022 um 12:45 schrieb H. Nikolaus Schaller : > > Hi Neil, > >> Am 03.03.2022 um 12:42 schrieb Neil Armstrong : >> >>> So how can we get that merged? IMHO your proposal should be before we add >>> ingenic-dw-hdmi. >>> If

Re: [PATCH v16 4/4] drm/bridge: dw-hdmi: fix bus formats negotiation for 8 bit modes

2022-03-03 Thread H. Nikolaus Schaller
Hi Neil, > Am 03.03.2022 um 12:42 schrieb Neil Armstrong : > >> So how can we get that merged? IMHO your proposal should be before we add >> ingenic-dw-hdmi. >> If you have a version with proper commit message I can add it to the >> beginning of my >> seried and include it in a v17. Or if you

Re: [PATCH v16 4/4] drm/bridge: dw-hdmi: fix bus formats negotiation for 8 bit modes

2022-03-03 Thread H. Nikolaus Schaller
Hi Neil, > Am 03.03.2022 um 09:35 schrieb Neil Armstrong : > > Hi, > > On 02/03/2022 23:24, H. Nikolaus Schaller wrote: >> Hi Neil, >>> Am 02.03.2022 um 15:34 schrieb Neil Armstrong : >>> >>> Hi, >>> >>>> (cross-checked: R

Re: [PATCH v16 4/4] drm/bridge: dw-hdmi: fix bus formats negotiation for 8 bit modes

2022-03-02 Thread H. Nikolaus Schaller
Hi Neil, > Am 02.03.2022 um 15:34 schrieb Neil Armstrong : > > Hi, > >> (cross-checked: RGB mode still works if I force hdmi->sink_is_hdmi = false) > > I don't understand what's wrong, can you try to make the logic select > MEDIA_BUS_FMT_YUV8_1X24 instead of DRM_COLOR_FORMAT_YCBCR422 ? I

Re: [PATCH v16 4/4] drm/bridge: dw-hdmi: fix bus formats negotiation for 8 bit modes

2022-03-02 Thread H. Nikolaus Schaller
Hi Neil, > Am 02.03.2022 um 11:25 schrieb Neil Armstrong : > >> I added a printk for hdmi->sink_is_hdmi. This returns 1. Which IMHO is to be >> expected >> since I am using a HDMI connector and panel... So your patch will still add >> the UYVY formats. >> Either the synposys module inside the

Re: [PATCH v16 4/4] drm/bridge: dw-hdmi: fix bus formats negotiation for 8 bit modes

2022-03-01 Thread H. Nikolaus Schaller
Hi Neil, > Am 01.03.2022 um 10:18 schrieb Neil Armstrong : > > Hi, > > On 26/02/2022 18:13, H. Nikolaus Schaller wrote: >> Commit 7cd70656d1285b ("drm/bridge: display-connector: implement bus fmts >> callbacks") >> introduced a new mechanism to ne

[PATCH v16 2/4] drm/ingenic: Add dw-hdmi driver specialization for jz4780

2022-02-26 Thread H. Nikolaus Schaller
drm_kms_helper_hotplug_event() introduced before. Signed-off-by: Paul Boddie Signed-off-by: Ezequiel Garcia Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/ingenic/Kconfig | 9 ++ drivers/gpu/drm/ingenic/Makefile | 1 + drivers/gpu/drm/ingenic/ingenic-dw-hdmi.c | 105

[PATCH v16 1/4] drm/bridge: dw-hdmi: introduce dw_hdmi_enable_poll()

2022-02-26 Thread H. Nikolaus Schaller
so that specialization drivers like ingenic-dw-hdmi can enable polling. Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 9 + include/drm/bridge/dw_hdmi.h | 1 + 2 files changed, 10 insertions(+) diff --git a/drivers/gpu/drm/bridge

[PATCH v16 4/4] drm/bridge: dw-hdmi: fix bus formats negotiation for 8 bit modes

2022-02-26 Thread H. Nikolaus Schaller
display-connector: implement bus fmts callbacks") Fixes: 6c3c719936dafe ("drm/bridge: synopsys: dw-hdmi: add bus format negociation") Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 10 ++ 1 file changed, 6 insertions(+), 4 deleti

[PATCH v16 3/4] drm/bridge: display-connector: add ddc-en gpio support

2022-02-26 Thread H. Nikolaus Schaller
ddc gpio after probe and deactivates after remove so it is "almost on". But only if this driver is loaded (and not e.g. blacklisted as module). Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/bridge/display-connector.c | 15 +++ 1 file changed, 15 insertions(+) diff

[PATCH v16 0/4] MIPS: JZ4780 and CI20 HDMI

2022-02-26 Thread H. Nikolaus Schaller
ent framework dropped (suggested by laurent.pinch...@ideasonboard.com and p...@crapouillou.net) PATCH V2 2021-08-05 16:08:05: - code and commit messages revisited for checkpatch warnings - rebased on v5.14-rc4 - include (failed, hence RFC 8/8) attempt to convert to component framework (was

Re: [PATCH v15 4/7] drm/bridge: dw-hdmi: repair interworking with hdmi-connector for jz4780

2022-02-26 Thread H. Nikolaus Schaller
Hi Neil, > Am 21.02.2022 um 09:11 schrieb Neil Armstrong : > > Hi, > > On 12/02/2022 16:50, H. Nikolaus Schaller wrote: >> Commit 7cd70656d1285b ("drm/bridge: display-connector: implement bus fmts >> callbacks") >> introduced a new mechanism to n

Re: [PATCH v15 1/7] drm/ingenic: Fix support for JZ4780 HDMI output

2022-02-14 Thread H. Nikolaus Schaller
> Am 14.02.2022 um 13:36 schrieb Paul Cercueil : > > Hi, > > Le lun., févr. 14 2022 at 13:33:25 +0100, H. Nikolaus Schaller > a écrit : >> Hi Paul, >>> Am 14.02.2022 um 13:29 schrieb Paul Cercueil : >>> Hi, >>> Le lun., févr. 14 2022 at

Re: [PATCH v15 1/7] drm/ingenic: Fix support for JZ4780 HDMI output

2022-02-14 Thread H. Nikolaus Schaller
Hi Paul, > Am 14.02.2022 um 13:29 schrieb Paul Cercueil : > > Hi, > > Le lun., févr. 14 2022 at 11:19:40 +0100, H. Nikolaus Schaller > a écrit : >> Hi Paul, >>> Am 14.02.2022 um 11:13 schrieb Paul Cercueil : >>> Hi, >>> Le sam., fé

Re: [PATCH v15 2/7] drm/ingenic: Add dw-hdmi driver specialization for jz4780

2022-02-14 Thread H. Nikolaus Schaller
Hi Paul, > Am 14.02.2022 um 11:24 schrieb Paul Cercueil : > > Hi, > > Le sam., févr. 12 2022 at 16:50:50 +0100, H. Nikolaus Schaller > a écrit : >> +static void ingenic_dw_hdmi_cleanup(void *data) >> +{ >> +struct dw_hdmi *hdmi = (struct dw_hdmi *)da

Re: [PATCH v15 1/7] drm/ingenic: Fix support for JZ4780 HDMI output

2022-02-14 Thread H. Nikolaus Schaller
Hi Paul, > Am 14.02.2022 um 11:13 schrieb Paul Cercueil : > > Hi, > > Le sam., févr. 12 2022 at 16:50:49 +0100, H. Nikolaus Schaller > a écrit : >> From: Paul Boddie >> We have to make sure that >> - JZ_LCD_OSDC_ALPHAEN is set >> - plane f

[PATCH v15 1/7] drm/ingenic: Fix support for JZ4780 HDMI output

2022-02-12 Thread H. Nikolaus Schaller
From: Paul Boddie We have to make sure that - JZ_LCD_OSDC_ALPHAEN is set - plane f0 is disabled and not seen from user-space Tested on MIPS Creator CI20 board. Signed-off-by: Paul Boddie Signed-off-by: Ezequiel Garcia Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/ingenic/ingenic

[PATCH v15 4/7] drm/bridge: dw-hdmi: repair interworking with hdmi-connector for jz4780

2022-02-12 Thread H. Nikolaus Schaller
backs") Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index b0d8110dd412c..826a055a7a273 100644 --- a/dr

[PATCH v15 3/7] drm/bridge: display-connector: add ddc-en gpio support

2022-02-12 Thread H. Nikolaus Schaller
ddc gpio after probe and deactivates after remove so it is "almost on". But only if this driver is loaded (and not e.g. blacklisted as module). Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/bridge/display-connector.c | 15 +++ 1 file changed, 15 insertions(+) diff

[PATCH v15 7/7] [RFC] drm/ingenic: add some more features specific to jz4780

2022-02-12 Thread H. Nikolaus Schaller
From: Paul Boddie The jz4780 has some more features which should be initialized according to the vendor kernel. Signed-off-by: Paul Boddie Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 34 +++ 1 file changed, 34 insertions(+) diff

[PATCH v15 5/7] drm/bridge: dw-hdmi: introduce dw_hdmi_enable_poll()

2022-02-12 Thread H. Nikolaus Schaller
so that specialization drivers like ingenic-dw-hdmi can enable polling. Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 9 + include/drm/bridge/dw_hdmi.h | 1 + 2 files changed, 10 insertions(+) diff --git a/drivers/gpu/drm/bridge

[PATCH v15 2/7] drm/ingenic: Add dw-hdmi driver specialization for jz4780

2022-02-12 Thread H. Nikolaus Schaller
-by: Ezequiel Garcia Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/ingenic/Kconfig | 9 ++ drivers/gpu/drm/ingenic/Makefile | 1 + drivers/gpu/drm/ingenic/ingenic-dw-hdmi.c | 104 ++ 3 files changed, 114 insertions(+) create mode 100644 drivers

[PATCH v15 6/7] drm/ingenic: dw-hdmi: make hot plug detection work for CI20

2022-02-12 Thread H. Nikolaus Schaller
setter function drm_kms_helper_hotplug_event(). Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/ingenic/ingenic-dw-hdmi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/ingenic/ingenic-dw-hdmi.c b/drivers/gpu/drm/ingenic/ingenic-dw-hdmi.c index 34e986dd606cf

[PATCH v15 0/7] MIPS: JZ4780 and CI20 HDMI

2022-02-12 Thread H. Nikolaus Schaller
work dropped (suggested by laurent.pinch...@ideasonboard.com and p...@crapouillou.net) PATCH V2 2021-08-05 16:08:05: - code and commit messages revisited for checkpatch warnings - rebased on v5.14-rc4 - include (failed, hence RFC 8/8) attempt to convert to component framework (was suggested

Re: [PATCH v14 8/9] [already applied to mips-fixes] MIPS: DTS: CI20: fix how ddc power is enabled

2022-02-12 Thread H. Nikolaus Schaller
> Am 12.02.2022 um 15:58 schrieb Paul Cercueil : > > Hi, > > Le sam., févr. 12 2022 at 15:19:26 +0100, H. Nikolaus Schaller > a écrit : >> Originally we proposed a new hdmi-5v-supply regulator reference >> for CI20 device tree but that was superseded by a bet

Re: [PATCH v14 5/9] drm/bridge: dw-hdmi: repair interworking with hdmi-connector for jz4780

2022-02-12 Thread H. Nikolaus Schaller
> Am 12.02.2022 um 16:06 schrieb Paul Cercueil : > > Hi Nikolaus, > > > Le sam., févr. 12 2022 at 15:19:23 +0100, H. Nikolaus Schaller > a écrit : >> Commit 7cd70656d1285b ("drm/bridge: display-connector: implement bus fmts >> callbacks") >

Re: [PATCH v14 1/9] drm/ingenic: Add support for JZ4780 and HDMI output

2022-02-12 Thread H. Nikolaus Schaller
Hi Paul, > Am 12.02.2022 um 15:44 schrieb Paul Cercueil : > > Hi Nikolaus, > > Le sam., févr. 12 2022 at 15:19:19 +0100, H. Nikolaus Schaller > a écrit : >> From: Paul Boddie >> Add support for the LCD controller present on JZ4780 SoCs. >> This SoC

[PATCH v14 9/9] [RFC] drm/ingenic: add some more features specific to jz4780

2022-02-12 Thread H. Nikolaus Schaller
From: Paul Boddie The jz4780 has some more features which should be initialized according to the vendor kernel. Signed-off-by: Paul Boddie Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 34 +++ 1 file changed, 34 insertions(+) diff

[PATCH v14 7/9] drm/ingenic: dw-hdmi: make hot plug detection work for CI20

2022-02-12 Thread H. Nikolaus Schaller
setter function drm_kms_helper_hotplug_event(). Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/ingenic/ingenic-dw-hdmi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/ingenic/ingenic-dw-hdmi.c b/drivers/gpu/drm/ingenic/ingenic-dw-hdmi.c index 34e986dd606cf

[PATCH v14 8/9] [already applied to mips-fixes] MIPS: DTS: CI20: fix how ddc power is enabled

2022-02-12 Thread H. Nikolaus Schaller
been applied to v5.17-rc1, we add this on top. Fixes: ae1b8d2c2de9 ("MIPS: DTS: CI20: Add DT nodes for HDMI setup") Signed-off-by: H. Nikolaus Schaller Reviewed-by: Paul Cercueil --- arch/mips/boot/dts/ingenic/ci20.dts | 15 ++- 1 file changed, 2 insertions(+), 13 delet

[PATCH v14 5/9] drm/bridge: dw-hdmi: repair interworking with hdmi-connector for jz4780

2022-02-12 Thread H. Nikolaus Schaller
backs") Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index b0d8110dd412c..826a055a7a273 100644 --- a/dr

[PATCH v14 4/9] drm/bridge: display-connector: add ddc-en gpio support

2022-02-12 Thread H. Nikolaus Schaller
ddc gpio after probe and deactivates after remove so it is "almost on". But only if this driver is loaded (and not e.g. blacklisted as module). Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/bridge/display-connector.c | 15 +++ 1 file changed, 15 insertions(+) diff

[PATCH v14 6/9] drm/bridge: dw-hdmi: introduce dw_hdmi_enable_poll()

2022-02-12 Thread H. Nikolaus Schaller
so that specialization drivers like ingenic-dw-hdmi can enable polling. Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 9 + include/drm/bridge/dw_hdmi.h | 1 + 2 files changed, 10 insertions(+) diff --git a/drivers/gpu/drm/bridge

[PATCH v14 1/9] drm/ingenic: Add support for JZ4780 and HDMI output

2022-02-12 Thread H. Nikolaus Schaller
. Signed-off-by: Paul Boddie Signed-off-by: Ezequiel Garcia Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c b/drivers/gpu/drm/ingenic

[PATCH v14 2/9] dt-bindings: display: Add ingenic, jz4780-dw-hdmi DT Schema

2022-02-12 Thread H. Nikolaus Schaller
From: Sam Ravnborg Add DT bindings for the hdmi driver for the Ingenic JZ4780 SoC. Based on .txt binding from Zubair Lutfullah Kakakhel Signed-off-by: Sam Ravnborg Signed-off-by: H. Nikolaus Schaller Cc: Rob Herring Cc: devicet...@vger.kernel.org Reviewed-by: Rob Herring --- .../display

[PATCH v14 3/9] drm/ingenic: Add dw-hdmi driver specialization for jz4780

2022-02-12 Thread H. Nikolaus Schaller
-by: Ezequiel Garcia Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/ingenic/Kconfig | 9 ++ drivers/gpu/drm/ingenic/Makefile | 1 + drivers/gpu/drm/ingenic/ingenic-dw-hdmi.c | 104 ++ 3 files changed, 114 insertions(+) create mode 100644 drivers

[PATCH v14 0/9] MIPS: JZ4780 and CI20 HDMI

2022-02-12 Thread H. Nikolaus Schaller
on v5.14-rc4 - include (failed, hence RFC 8/8) attempt to convert to component framework (was suggested by Paul Cercueil a while ago) This series adds HDMI support for JZ4780 and CI20 board H. Nikolaus Schaller (5): drm/bridge: display-connector: add ddc-en gpio support drm/bridge: d

Re: [PATCH v13 0/9] MIPS: JZ4780 and CI20 HDMI

2022-02-12 Thread H. Nikolaus Schaller
Hi, > Am 09.02.2022 um 15:02 schrieb Paul Cercueil : > > Hi, > > Le mer., févr. 9 2022 at 14:51:12 +0100, H. Nikolaus Schaller > a écrit : >> Paul, >>> Am 09.02.2022 um 12:52 schrieb Paul Cercueil : >>> Hi Nikolaus, >>> I tried applyi

Re: [PATCH v13 5/9] drm/synopsys+ingenic: repair hot plug detection

2022-02-09 Thread H. Nikolaus Schaller
Hi Paul, > Am 09.02.2022 um 13:01 schrieb Paul Cercueil : > > Hi Nikolaus, > > Le mer., févr. 2 2022 at 17:31:19 +0100, H. Nikolaus Schaller > a écrit : >> so that it calls drm_kms_helper_hotplug_event(). >> We need to set .poll_enabled but that struct com

Re: [PATCH v13 6/9] dw-hdmi/ingenic-dw-hdmi: repair interworking with hdmi-connector

2022-02-09 Thread H. Nikolaus Schaller
Hi Paul, > Am 09.02.2022 um 13:18 schrieb Paul Cercueil : > > Hi Nikolaus, > > Le mer., févr. 2 2022 at 17:31:20 +0100, H. Nikolaus Schaller > a écrit : >> Commit 7cd70656d1285b ("drm/bridge: display-connector: implement bus fmts >> callbacks") >&g

Re: [PATCH v13 0/9] MIPS: JZ4780 and CI20 HDMI

2022-02-09 Thread H. Nikolaus Schaller
Paul, > Am 09.02.2022 um 12:52 schrieb Paul Cercueil : > > Hi Nikolaus, > > I tried applying patches 1-2, but they don't apply cleanly on top of > drm-misc/drm-misc-next. Ok I had rebased to linux-next some days ago and it appears that patch 1/9 has now arrived in drm-misc/drm-misc-next. So

[PATCH v13 8/9] MIPS: DTS: CI20: fix how ddc power is enabled

2022-02-02 Thread H. Nikolaus Schaller
been applied to v5.17-rc1, we add this on top. Fixes: ae1b8d2c2de9 ("MIPS: DTS: CI20: Add DT nodes for HDMI setup") Signed-off-by: H. Nikolaus Schaller Reviewed-by: Paul Cercueil --- arch/mips/boot/dts/ingenic/ci20.dts | 15 ++- 1 file changed, 2 insertions(+), 13 delet

[PATCH v13 5/9] drm/synopsys+ingenic: repair hot plug detection

2022-02-02 Thread H. Nikolaus Schaller
so that it calls drm_kms_helper_hotplug_event(). We need to set .poll_enabled but that struct component can only be accessed in the core code. Hence we add a public setter function. Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 9 + drivers/gpu/drm

[PATCH v13 6/9] dw-hdmi/ingenic-dw-hdmi: repair interworking with hdmi-connector

2022-02-02 Thread H. Nikolaus Schaller
backs") Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index 52e7cd2e020d3..34703a15ee4ff 100644 --- a/dr

[PATCH v13 4/9] drm/ingenic: Add dw-hdmi driver specialization for jz4780

2022-02-02 Thread H. Nikolaus Schaller
-by: Ezequiel Garcia Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/ingenic/Kconfig | 9 ++ drivers/gpu/drm/ingenic/Makefile | 1 + drivers/gpu/drm/ingenic/ingenic-dw-hdmi.c | 104 ++ 3 files changed, 114 insertions(+) create mode 100644 drivers

[PATCH v13 7/9] drm/bridge: display-connector: add ddc-en gpio support

2022-02-02 Thread H. Nikolaus Schaller
ddc gpio after probe and deactivates after remove so it is "almost on". But only if this driver is loaded (and not e.g. blacklisted as module). Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/bridge/display-connector.c | 15 +++ 1 file changed, 15 insertions(+) diff

[PATCH v13 2/9] drm/ingenic: Add support for JZ4780 and HDMI output

2022-02-02 Thread H. Nikolaus Schaller
. Nikolaus Schaller --- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 63 ++- drivers/gpu/drm/ingenic/ingenic-drm.h | 38 ++ 2 files changed, 100 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c b/drivers/gpu/drm/ingenic

[PATCH v13 3/9] dt-bindings: display: Add ingenic, jz4780-dw-hdmi DT Schema

2022-02-02 Thread H. Nikolaus Schaller
From: Sam Ravnborg Add DT bindings for the hdmi driver for the Ingenic JZ4780 SoC. Based on .txt binding from Zubair Lutfullah Kakakhel Signed-off-by: Sam Ravnborg Signed-off-by: H. Nikolaus Schaller Cc: Rob Herring Cc: devicet...@vger.kernel.org Reviewed-by: Rob Herring --- .../display

[PATCH v13 1/9] drm/ingenic: prepare ingenic drm for later addition of JZ4780

2022-02-02 Thread H. Nikolaus Schaller
This changes the way the regmap is allocated to prepare for the later addition of the JZ4780 which has more registers and bits than the others. Therefore we make the regmap as big as the reg property in the device tree tells. Suggested-by: Paul Cercueil Signed-off-by: H. Nikolaus Schaller

[PATCH v13 0/9] MIPS: JZ4780 and CI20 HDMI

2022-02-02 Thread H. Nikolaus Schaller
2 2021-08-05 16:08:05: - code and commit messages revisited for checkpatch warnings - rebased on v5.14-rc4 - include (failed, hence RFC 8/8) attempt to convert to component framework (was suggested by Paul Cercueil a while ago) This series adds HDMI support for JZ4780 and CI20 board H. Nik

Re: [PATCH v12 2/9] drm/ingenic: Add support for JZ4780 and HDMI output

2022-02-02 Thread H. Nikolaus Schaller
> Am 02.02.2022 um 13:41 schrieb Paul Cercueil : > > > > Le mer., févr. 2 2022 at 13:33:15 +0100, H. Nikolaus Schaller > a écrit : >>> Am 02.02.2022 um 13:28 schrieb Paul Cercueil : >>> Le mer., févr. 2 2022 at 13:17:14 +0100, H. Nikolaus Schaller &

Re: [PATCH v12 2/9] drm/ingenic: Add support for JZ4780 and HDMI output

2022-02-02 Thread H. Nikolaus Schaller
> Am 02.02.2022 um 13:28 schrieb Paul Cercueil : > > > > Le mer., févr. 2 2022 at 13:17:14 +0100, H. Nikolaus Schaller > a écrit : >> Hi Paul, >>> Am 02.02.2022 um 13:06 schrieb Paul Cercueil : >>> Hi Nikolaus, >>>>>> @@ -446,

  1   2   3   4   5   6   >