Hi,
On 3/8/23 22:58, Hans de Goede wrote:
> The parent for the backlight device should be the drm-connector object,
> not the PCI device.
>
> Userspace relies on this to be able to detect which backlight class device
> to use on hybrid gfx devices where there may be multi
w and review it. If the review leads to
changes being requested then I'll prepare a new version and Cc you.
Regards,
Hans
1) Next time mayvw read the entire thread before replying ?
> On 3/8/23 14:58, Hans de Goede wrote:
>> Hi All,
>>
>> Here is version 2 of my patch series
Hi all,
On 3/8/23 23:10, Hans de Goede wrote:
> Hi,
>
> On 3/8/23 22:58, Hans de Goede wrote:
>> Hi All,
>>
>> Here is version 2 of my patch series to pass the proper parent device
>> to backlight_device_register().
>>
>> New in version 2 is delay
Hi,
On 3/8/23 22:58, Hans de Goede wrote:
> Hi All,
>
> Here is version 2 of my patch series to pass the proper parent device
> to backlight_device_register().
>
> New in version 2 is delaying the registering of the backlight_dev till
> after the drm_connector is regist
-by: Hans de Goede
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 24 +--
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 757202af2eec..038bf897cc28
;backlight_dev[i] also checks it is not NULL.
Link: https://gitlab.gnome.org/GNOME/gnome-settings-daemon/-/issues/730
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/amd/dis
reworking update_connector_ext_caps() also remove the aconnector
and aconnector->dc_link NULL checks in this function. These are both
never NULL and are unconditionally derefed in its callers.
Signed-off-by: Hans de Goede
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 42 +++
.../gpu/drm/amd/displ
backlight class device.
This is a preparation patch for moving the actual backlight class device
registering to drm_connector_funcs.late_register.
Signed-off-by: Hans de Goede
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 17 -
1 file changed, 8 insertions(+), 9 deletions
dps])"
check will thus always succeed and can be removed.
4) Add a bl_idx local variable to use as array index, rather then
using dm->num_of_edps to improve the code readability.
Signed-off-by: Hans de Goede
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 28 ++-
ed-off-by: Hans de Goede
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 009ef917dad4..42b88ab5552d
reworking the code a bit to allow delaying
the registering, so this has turned from a single patch into
a 6 patch set.
Regards,
Hans
Hans de Goede (6):
drm/amd/display/amdgpu_dm: Fix backlight_device_register() error
handling
drm/amd/display/amdgpu_dm: Refactor register_backlight_device
Hi,
On 2/15/23 12:38, Hans de Goede wrote:
> The parent for the backlight device should be the drm-connector object,
> not the PCI device.
>
> Userspace relies on this to be able to detect which backlight class device
> to use on hybrid gfx devices where there may be multi
Hi,
On 3/7/23 13:27, Andy Shevchenko wrote:
> On Tue, Mar 07, 2023 at 01:05:40PM +0100, Hans de Goede wrote:
>> On some MacBooks both the apple_bl and the apple-gmux backlight drivers
>> may be able to export a /sys/class/backlight device.
>>
>> To avoid having 2 ba
) This allows user to switch between the drivers by passing
acpi_backlight=apple_gmux or acpi_backlight=vendor on the kernel
commandline.
Signed-off-by: Hans de Goede
---
A note to the backlight class / subsystem maintainers, this change
applies on top of a similar patch for drivers/platform/x86
version of the Yoga Book uses completely different DMI strings.
Also adjust the X91F/L quirk to reflect that it only applies to
the X91F/L models.
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/drm_panel_orientation_quirks.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff
great.
Link: https://gitlab.gnome.org/GNOME/gnome-settings-daemon/-/issues/730
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b
Hi,
On 2/14/23 17:46, Darrell Kavanagh wrote:
> Another Lenovo convertable where the panel is installed landscape but is
> reported to the kernel as portrait.
>
> Signed-off-by: Darrell Kavanagh
Thanks, I have pushed this to drm-misc-next-fixes now, so it should
get merged upstream as part of
Hi,
On 2/14/23 17:46, Darrell Kavanagh wrote:
> Another Lenovo convertable where the panel is installed landscape but is
> reported to the kernel as portrait.
>
> Signed-off-by: Darrell Kavanagh
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede
Note for other developer
Hi,
On 2/9/23 16:36, Maxime Ripard wrote:
> Hi,
>
> On Wed, Feb 08, 2023 at 07:04:58PM +, Darrell Kavanagh wrote:
>> I've resolved this by adding a matching quirk in
>> drivers/firmware/efi/sysfb_efi.c - see below.
Right, this is a known issue on Lenovo 2-in-1s with
the panel mounted 90
Hi Darrell,
On 2/3/23 19:32, Darrell Kavanagh wrote:
> Hi,
>
> This is another Lenovo with detachable keyboard and 1200x1920 screen
> mounted sideways.
>
> The following has been tested with 6.2.0-rc6.
>
> Thanks,
> Darrell
Thank you for your patch. Note that instead of "Hi, ... Thanks,
Hi,
On 1/22/23 16:36, Rob Herring wrote:
> On Sat, Jan 21, 2023 at 9:36 AM Rayyan Ansari wrote:
>>
>
> Why do you need this change?
>
> The 'simple-framebuffer' contains data on how the bootloader
> configured the display. The bootloader doesn't configure the display
> size, so this
userspace would use that.
Add a backlight=native DMI quirk for this special laptop to restore
the old (and working) behavior of the intel_backlight device registering.
Fixes: fb1836c91317 ("ACPI: video: Prefer native over vendor")
Signed-off-by: Hans de Goede
---
drivers/acpi/video_detect.c |
The HP Pavilion g6-1d80nr predates Windows 8, so it defaults to using
acpi_video# for backlight control, but this is non functional on
this model.
Add a DMI quirk to use the native backlight interface which does
work properly.
Signed-off-by: Hans de Goede
---
drivers/acpi/video_detect.c | 9
on the EliteBook 8460p to fix this.
Fixes: fb1836c91317 ("ACPI: video: Prefer native over vendor")
Link: https://bugzilla.redhat.com/show_bug.cgi?id=2161428
Signed-off-by: Hans de Goede
---
drivers/acpi/video_detect.c | 8
1 file changed, 8 insertions(+)
diff --git a/dr
s somewhat different, see the commit msg.
Regards,
Hans
Hans de Goede (2):
ACPI: video: Add backlight=native DMI quirk for HP Pavilion g6-1d80nr
ACPI: video: Add backlight=native DMI quirk for HP EliteBook 8460p
drivers/acpi/video_detect.c | 17 +
1 file changed, 17 insertions(+)
--
2.39.0
The Acer Aspire 4810T predates Windows 8, so it defaults to using
acpi_video# for backlight control, but this is non functional on
this model.
Add a DMI quirk to use the native backlight interface which does
work properly.
Signed-off-by: Hans de Goede
---
drivers/acpi/video_detect.c | 8
Hi,
On 1/11/23 21:16, Rafael J. Wysocki wrote:
> On Tue, Jan 10, 2023 at 4:30 PM Hans de Goede wrote:
>>
>> The Dell Latitude E6430 both with and without the optional NVidia dGPU
>> has a bug in its ACPI tables which is causing Linux to assign the wrong
>&
gher score for children with this flag set,
so that it picks the right companion-device.
Co-developed-by: Rafael J. Wysocki
Signed-off-by: Hans de Goede
---
Changes in v2:
- Switch to Rafael's suggested implementation using a type.backlight flag
and only make find_child_checks() return a higher
Hi Rafael,
On 1/10/23 14:33, Rafael J. Wysocki wrote:
> On Monday, January 9, 2023 9:57:21 PM CET Hans de Goede wrote:
>> The Dell Latitude E6430 both with and without the optional NVidia dGPU
>> has a bug in its ACPI tables which is causing Linux to assign the wrong
>> AC
p.s.
This fixes a regression in 6.1, adding the regressions list to the Cc.
Once we figure out the best way to fix this (this patch is more of a proposal
how to fix this rather then a definitive fix), we should also backport
the fix to 6.1.y.
On 1/9/23 21:57, Hans de Goede wrote:
> The D
every time it is called.
Fixes: 63f534b8bad9 ("ACPI: PCI: Rework acpi_get_pci_dev()")
Signed-off-by: Hans de Goede
---
drivers/acpi/glue.c | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/glue.c b/drivers/acpi/glue.c
index 204fe94c7e45.
;
> Signed-off-by: Allen Ballway
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede
I've pushed this to drm-misc-next now.
Regards,
Hans
> ---
>
> .../gpu/drm/drm_panel_orientation_quirks.c| 20 ---
> 1 file changed, 13 insertions(+), 7 deletion
Hi,
On 11/30/22 08:43, Javier Martinez Canillas wrote:
> Hello Hans,
>
> On 11/27/22 19:15, Hans de Goede wrote:
>> The Lenovo Yoga Tab 3 X90F has a portrait 1600x2560 LCD used in
>> landscape mode, add a quirk for this.
>>
>> Signed-off-by: Hans de Go
The Lenovo Yoga Tab 3 X90F has a portrait 1600x2560 LCD used in
landscape mode, add a quirk for this.
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/drm_panel_orientation_quirks.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c
Hi,
On 11/14/22 11:10, Jani Nikula wrote:
> On Mon, 14 Nov 2022, Hans de Goede wrote:
>> Hi,
>>
>> On 11/14/22 00:23, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Today's linux-next merge of the drm-intel tree got a conflict in:
>>
Hi,
On 11/14/22 00:23, Stephen Rothwell wrote:
> Hi all,
>
> Today's linux-next merge of the drm-intel tree got a conflict in:
>
> drivers/gpu/drm/i915/display/intel_backlight.c
>
> between commit:
>
> b1d36e73cc1c ("drm/i915: Don't register backlight when another backlight
> should be
Hi Alex, et al.,
I just pushed 2 simple DMI quirk patches
(for drivers/gpu/drm/drm_panel_orientation_quirks.c)
to drm-misc-fixes.
At the end of the dim push-branch I noticed that
rebuilding drm-tip failed due to a merge error
when merging in drm-next .
Looking at the 3-way diff of the conflict,
Hi,
On 11/7/22 17:25, Simon Ser wrote:
> Acked-by: Simon Ser
Thank you. I've pushed both patches to drm-misc-fixes now.
Regards,
Hans
use #ifdef guards.
>
> This has the advantage of always compiling these functions in,
> independently of any Kconfig option. Thanks to that, bugs and other
> regressions are subsequently easier to catch. It also allows to drop the
> __maybe_unused tags.
>
> Signed-off-by: P
e #ifdef guards.
>
> This has the advantage of always compiling these functions in,
> independently of any Kconfig option. Thanks to that, bugs and other
> regressions are subsequently easier to catch.
>
> Signed-off-by: Paul Cercueil
> ---
> Cc: Hans de Goede
Thanks, patch
Like the Acer Switch One 10 S1003, for which there already is a quirk,
the Acer Switch V 10 (SW5-017) has a 800x1280 portrait screen mounted
in the tablet part of a landscape oriented 2-in-1. Add a quirk for this.
Cc: Rudolf Polzer
Signed-off-by: Hans de Goede
---
drivers/gpu/drm
Hi Matthew, Rafael,
On 10/27/22 14:09, Rafael J. Wysocki wrote:
> On Thu, Oct 27, 2022 at 12:37 PM Hans de Goede wrote:
>>
>> Hi,
>>
>> On 10/27/22 11:52, Matthew Garrett wrote:
>>> On Thu, Oct 27, 2022 at 11:39:38AM +0200, Hans de Goede wrote:
>>>
&
Hi,
On 10/27/22 14:09, Rafael J. Wysocki wrote:
> On Thu, Oct 27, 2022 at 12:37 PM Hans de Goede wrote:
>>
>> Hi,
>>
>> On 10/27/22 11:52, Matthew Garrett wrote:
>>> On Thu, Oct 27, 2022 at 11:39:38AM +0200, Hans de Goede wrote:
>>>
>>
Hi,
On 10/27/22 11:52, Matthew Garrett wrote:
> On Thu, Oct 27, 2022 at 11:39:38AM +0200, Hans de Goede wrote:
>
>> The *only* behavior which actually is new in 6.1 is the native GPU
>> drivers now doing the equivalent of:
>>
>> if (acpi_video_get_backlight_t
Hi Matthew,
On 10/27/22 11:11, Matthew Garrett wrote:
> On Thu, Oct 27, 2022 at 10:51:45AM +0200, Hans de Goede wrote:
>
>> In their backlight register paths and this has been present since
>> circa 2015.
>>
>> So both before and after my 6.1 refactor vendor is only
Hi,
On 10/26/22 22:49, Matthew Garrett wrote:
> On Wed, Oct 26, 2022 at 11:59:28AM +0200, Hans de Goede wrote:
>
>> Ok, so this is a local customization to what is already a custom BIOS
>> for a custom motherboard. There is a lot of custom in that sentence and
>> TBH at
Hi,
On 10/26/22 01:40, Matthew Garrett wrote:
> On Wed, Oct 26, 2022 at 01:27:25AM +0200, Hans de Goede wrote:
>
>> this code should actually set the ACPI_VIDEO_BACKLIGHT flag:
>> drivers/acpi/scan.c:
>>
>> static acpi_status
>> acpi_backlight_cap_match
Hi,
On 10/25/22 22:40, Matthew Garrett wrote:
> On Tue, Oct 25, 2022 at 10:25:33PM +0200, Hans de Goede wrote:
>
>> Having the native driver come and then go and be replaced
>> with the vendor driver would also be quite inconvenient
>> for these planned changes.
>
&
Hi (again),
On 10/25/22 22:25, Hans de Goede wrote:
> Hi Matthew,
>
> On 10/25/22 21:32, Matthew Garrett wrote:
>> On Tue, Oct 25, 2022 at 08:50:54PM +0200, Hans de Goede wrote:
>>
>>> That is a valid point, but keep in mind that this is only used on ACPI
>>
Hi Matthew,
On 10/25/22 21:32, Matthew Garrett wrote:
> On Tue, Oct 25, 2022 at 08:50:54PM +0200, Hans de Goede wrote:
>
>> That is a valid point, but keep in mind that this is only used on ACPI
>> platforms and then only on devices with a builtin LCD panel and then
>> o
Hi,
On 10/24/22 22:30, Matthew Garrett wrote:
> On Tue, Sep 27, 2022 at 01:04:52PM +0200, Hans de Goede wrote:
>
>> So to fix this we need to make acpi_video_get_backlight_type()
>> return native on the Acer Chromebook Spin 713.
>
> Isn't the issue broader than t
Hi,
On 10/24/22 16:45, Rafael J. Wysocki wrote:
> On Mon, Oct 24, 2022 at 4:32 PM Hans de Goede wrote:
>>
>> Hi,
>>
>> On 10/24/22 16:12, Dmitry Osipenko wrote:
>>> Chromebooks don't have backlight in ACPI table, they suppose to use
>>> native backl
ative backlight if EC found.
>>
>> Suggested-by: Hans de Goede
>> Fixes: 2600bfa3df99 ("ACPI: video: Add acpi_video_backlight_use_native()
>> helper")
>> Signed-off-by: Dmitry Osipenko
>> ---
>>
>> Changelog:
>>
>> v2: - Added
Hi,
On 10/24/22 16:31, Akihiko Odaki wrote:
> On 2022/10/24 23:06, Akihiko Odaki wrote:
>> On 2022/10/24 22:21, Hans de Goede wrote:
>>> Hi,
>>>
>>> On 10/24/22 14:58, Akihiko Odaki wrote:
>>>> On 2022/10/24 20:53, Hans de Goede wrote:
>>
Hi,
On 10/24/22 16:12, Dmitry Osipenko wrote:
> Chromebooks don't have backlight in ACPI table, they suppose to use
> native backlight in this case. Check presence of the CrOS embedded
> controller ACPI device and prefer the native backlight if EC found.
>
> Suggested-by: Hans de
t; Suggested-by: Hans de Goede
> Fixes: b1d36e73cc1c ("drm/i915: Don't register backlight when another
> backlight should be used (v2)")
> Signed-off-by: Dmitry Osipenko
> ---
> drivers/acpi/video_detect.c | 8
> 1 file changed, 8 insertions(+)
>
> diff
Hi,
On 10/24/22 15:14, Pali Rohár wrote:
> On Monday 24 October 2022 21:58:57 Akihiko Odaki wrote:
>> Regarding the second limitation, I don't even understand the difference
>> between vendor and native. My guess is that a vendor backlight device uses
>> vendor-specific ACPI interface, and a
Hi,
On 10/24/22 14:58, Akihiko Odaki wrote:
> On 2022/10/24 20:53, Hans de Goede wrote:
>> Hi Akihiko,
>>
>> On 10/24/22 13:34, Akihiko Odaki wrote:
>>> Commit 2600bfa3df99 ("ACPI: video: Add acpi_video_backlight_use_native()
>>> helper") and fo
Hi,
On 10/24/22 13:56, Akihiko Odaki wrote:
> On 2022/10/24 20:48, Jani Nikula wrote:
>> On Mon, 24 Oct 2022, Akihiko Odaki wrote:
>>> Commit 2600bfa3df99 ("ACPI: video: Add acpi_video_backlight_use_native()
>>> helper") and following commits made native backlight unavailable if
>>>
Hi Akihiko,
On 10/24/22 13:34, Akihiko Odaki wrote:
> Commit 2600bfa3df99 ("ACPI: video: Add acpi_video_backlight_use_native()
> helper") and following commits made native backlight unavailable if
> CONFIG_ACPI_VIDEO is set and the backlight feature of ACPI video is
> unavailable, which broke the
Hi,
On 10/3/22 12:32, Pekka Paalanen wrote:
> On Mon, 3 Oct 2022 11:44:56 +0200
> Hans de Goede wrote:
>
>> One example mentioned here is that laptops with Intel integrated
>> graphics may have some "perceived brightness" mapping table
>> in their Video BIOS
Hi,
On 9/30/22 18:17, Sebastian Wick wrote:
> On Fri, Sep 30, 2022 at 5:27 PM Pekka Paalanen wrote:
>>
>> On Fri, 30 Sep 2022 17:44:17 +0300
>> Ville Syrjälä wrote:
>>
>>> On Fri, Sep 30, 2022 at 04:20:29PM +0200, Sebastian Wick wrote:
On Fri, Sep 30, 2022 at 9:40 AM Pekka Paalanen wrote:
Hi,
On 9/28/22 12:57, Ville Syrjälä wrote:
> On Wed, Sep 28, 2022 at 01:04:01PM +0300, Jani Nikula wrote:
>> On Fri, 09 Sep 2022, Hans de Goede wrote:
>>> Hi all,
>>>
>>> Here is v2 of my "drm/kms: control display brightness through drm_connector
Hi,
On 9/28/22 12:04, Jani Nikula wrote:
> On Fri, 09 Sep 2022, Hans de Goede wrote:
>> Hi all,
>>
>> Here is v2 of my "drm/kms: control display brightness through drm_connector
>> properties" RFC:
>>
>> Changes from version 1:
>> -
Hi Dmitry,
On 9/26/22 01:39, Dmitry Osipenko wrote:
> 25.08.2022 17:36, Hans de Goede пишет:
>> Before this commit when we want userspace to use the acpi_video backlight
>> device we register both the GPU's native backlight device and acpi_video's
>> firmware acpi_vi
The Nanote UMPC-01 is a mini laptop with a 1200x1920 portrait screen
mounted in a landscape oriented clamshell case. Add a quirk for this.
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm
Hi Patrik,
On 9/18/22 20:45, Patrik Jakobsson wrote:
> On Sat, Sep 17, 2022 at 2:31 PM Hans de Goede wrote:
>>
>> Hi Patrik,
>>
>> On 9/14/22 09:50, Patrik Jakobsson wrote:
>>> On Fri, Sep 9, 2022 at 1:56 PM Hans de Goede wrote:
>>>>
>>>&
Hi Sam,
On 9/18/22 20:51, Sam Ravnborg wrote:
> Hi Hans,
>
>>> Changes in v3:
>>> - Fix unused variable warnings when CONFIG_BACKLIGHT is not selected by
>>> marking the 2 variables as __maybe_unused.
>>
>> This looks good to me. I don't have access to my DIM setup in a couple
>> of days so
Hi Patrik,
On 9/18/22 20:22, Patrik Jakobsson wrote:
> On Sat, Sep 17, 2022 at 10:59 PM Hans de Goede wrote:
>>
>> Hi All,
>>
>> Here is a patch-series changing gma500's backlight handling to match
>> the changes done to the other major x86 GPU drivers in the j
Hi,
On 9/17/22 22:46, Sam Ravnborg wrote:
> On Sat, Sep 17, 2022 at 04:03:50PM +0200, Hans de Goede wrote:
>> Use backlight_get_brightness() instead of directly referencing
>> bd->props.brightness. This will take backlight_is_blank() into account,
>> properly setting bri
org
Signed-off-by: Hans de Goede
---
Changes in v2 of the patch-set:
- New patch in v2 of the patch-set
---
drivers/gpu/drm/gma500/backlight.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/gma500/backlight.c
b/drivers/gpu/drm/gma500/backlight.c
in
devices for a single display really is
undesirable, don't register the GPU's native backlight device when
another backlight device should be used.
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/gma500/backlight.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/drm
native backlight device.
Add a call to the new acpi_video_register_backlight() function after
setting up the gma500's native backlight, so that the acpi_video backlight
device gets registered on systems where the gma500's native backlight
device is not registered.
Signed-off-by: Hans de Goede
d Bell Dot SC (Intel Atom N2600, cedarview)
and a Sony Vaio vpc-x11s1e (Intel N540, poulsbo) laptop.
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/gma500/backlight.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/gma500/backlight.c
b/drivers/gpu/drm/
tel N540, poulsbo) laptop.
Changes in v2:
- Fix unused variable warnings when CONFIG_BACKLIGHT is not selected by
marking the 2 variables as __maybe_unused.
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/gma500/backlight.c | 94 +++-
drivers/gpu/drm/gma500/cdv_devic
.com/
Changes in v2:
- Add "Use backlight_get_brightness() to get the brightness" patch
Changes in v3:
- Fix unused variable warnings when CONFIG_BACKLIGHT is not selected by
marking the 2 variables as __maybe_unused.
Regards,
Hans
Hans de Goede (5):
drm/gma500: Refactor backlight sup
kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url:
> https://github.com/intel-lab-lkp/linux/commits/Hans-de-Goede/drm-gma500-Backlight-handling-c
Hi,
On 8/25/22 21:19, Maccraft123 wrote:
> From: Maya Matuszczyk
>
> Yet another x86 gaming handheld.
>
> This one has many SKUs with quite a few of DMI strings,
> so let's just use a catchall, just as with Aya Neo Next.
>
> Signed-off-by: Maya Matuszczyk
Thanks, I have pushed this out to
d Bell Dot SC (Intel Atom N2600, cedarview)
and a Sony Vaio vpc-x11s1e (Intel N540, poulsbo) laptop.
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/gma500/backlight.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/gma500/backlight.c
b/drivers/gpu/drm/
Use backlight_get_brightness() instead of directly referencing
bd->props.brightness. This will take backlight_is_blank() into account,
properly setting brightness to 0 when screen-blanking has been requested
through the backlight sysfs interface.
Suggested-by: Sam Ravnborg
Signed-off-by: Hans
native backlight device.
Add a call to the new acpi_video_register_backlight() function after
setting up the gma500's native backlight, so that the acpi_video backlight
device gets registered on systems where the gma500's native backlight
device is not registered.
Signed-off-by: Hans de Goede
.com/
Changes in v2:
- Add "Use backlight_get_brightness() to get the brightness" patch
Regards,
Hans
Hans de Goede (5):
drm/gma500: Refactor backlight support
drm/gma500: Change registered backlight device type to raw/native
drm/gma500: Use backlight_get_brightness() to get the
devices for a single display really is
undesirable, don't register the GPU's native backlight device when
another backlight device should be used.
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/gma500/backlight.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/drm
tel N540, poulsbo) laptop.
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/gma500/backlight.c | 94 +++-
drivers/gpu/drm/gma500/cdv_device.c | 50 +++--
drivers/gpu/drm/gma500/oaktrail_device.c | 65 ++--
drivers/gpu/drm/gma500/opregion.c|
Hi,
On 8/3/22 20:24, Maccraft123 wrote:
> From: Maya Matuszczyk
>
> This device is another x86 gaming handheld, and as (hopefully) there is
> only one set of DMI IDs it's using DMI_EXACT_MATCH
>
> Signed-off-by: Maya Matuszczyk
Thanks I have added this patch to my local drm-misc-next branch.
Hi,
On 8/24/22 15:02, Jilin Yuan wrote:
> Delete the redundant word 'the'.
>
> Signed-off-by: Jilin Yuan
Thanks I have added this patch to my local drm-misc-next branch.
I will push this out to the official drm-misc-next branch after
running some local tests.
Regards,
Hans
> ---
>
Hi Patrik,
On 9/14/22 09:50, Patrik Jakobsson wrote:
> On Fri, Sep 9, 2022 at 1:56 PM Hans de Goede wrote:
>>
>> Hi Patrik,
>>
>> Here is another gma500 patch-series with one more bugfix and a bunch
>> of other cleanups of stuff which I noticed while doin
Hi,
On 9/14/22 12:29, Maxime Ripard wrote:
> Hi Hans,
>
> On Mon, Sep 05, 2022 at 10:35:47AM +0200, Hans de Goede wrote:
>> Hi All,
>>
>> Now that all patches have been reviewed/acked here is an immutable
>> backlight-detect-refactor
>> branch with
Hi,
On 9/14/22 08:50, Patrik Jakobsson wrote:
> On Fri, Sep 9, 2022 at 1:56 PM Hans de Goede wrote:
>>
>> Hi Patrik,
>>
>> Here is another gma500 patch-series with one more bugfix and a bunch
>> of other cleanups of stuff which I noticed while doing the previo
Hi Sam,
On 9/11/22 13:48, Sam Ravnborg wrote:
> Hi Hans,
>
> just a few minor things. See comments.
> I like the diff - removes much more than it adds.
I'm glad you like it and thank you for the review.
> On Sat, Sep 10, 2022 at 10:50:58PM +0200, Hans de Goede wrote:
>&g
Hi All,
On 9/9/22 12:23, Hans de Goede wrote:
> Hi All,
>
> I will be at Plumbers Dublin next week and I was wondering if
> anyone interested in this wants to get together for a quick
> discussion / birds of a feather session about this?
>
> I have just posted version
tel N540, poulsbo) laptop.
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/gma500/backlight.c | 94 +++-
drivers/gpu/drm/gma500/cdv_device.c | 50 +++--
drivers/gpu/drm/gma500/oaktrail_device.c | 65 ++--
drivers/gpu/drm/gma500/opregion.c|
native backlight device.
Add a call to the new acpi_video_register_backlight() function after
setting up the gma500's native backlight, so that the acpi_video backlight
device gets registered on systems where the gma500's native backlight
device is not registered.
Signed-off-by: Hans de Goede
devices for a single display really is
undesirable, don't register the GPU's native backlight device when
another backlight device should be used.
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/gma500/backlight.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/drm
d Bell Dot SC (Intel Atom N2600, cedarview)
and a Sony Vaio vpc-x11s1e (Intel N540, poulsbo) laptop.
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/gma500/backlight.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/gma500/backlight.c
b/drivers/gpu/drm/
com/
Regards,
Hans
Hans de Goede (4):
drm/gma500: Refactor backlight support
drm/gma500: Change registered backlight device type to raw/native
drm/gma500: Don't register backlight when another backlight should be
used
drm/gma500: Call acpi_video_register_backlight()
drivers/gpu/dr
Hi Patrik,
On 9/9/22 10:45, Hans de Goede wrote:
> Hi,
>
> On 9/9/22 09:34, Patrik Jakobsson wrote:
>> On Thu, Sep 8, 2022 at 3:39 PM Hans de Goede
>> wrote:
>>>
>>> Hi,
>>>
>>> On 9/8/22 15:26, Patrik Jakobsson wrote:
>>>
Hi,
On 9/9/22 15:39, Simon Ser wrote:
> On Friday, September 9th, 2022 at 12:12, Hans de Goede
> wrote:
>
>> Phase 3: Deprecate /sys/class/backlight uAPI
>>
>>
>> Once most userspace has moved over to using the new
The gma_crtc_set_config() and psb_unlocked_ioctl() functions are 1:1
wrappers for drm_helpers. Drop these wrappers.
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/gma500/gma_display.c | 8 +---
drivers/gpu/drm/gma500/gma_display.h | 2 --
drivers/gpu/drm/gma500/psb_drv.c | 8
(and therefor has no pm_runtime_foo() equivalent).
The 2 code paths which were using gma_power_is_on() are actually both
guaranteed to only run when the device is powered-on so the 2 checks
can simply be dropped.
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/gma500/oaktrail_lvds.c | 1 -
drivers
101 - 200 of 1992 matches
Mail list logo
