Re: [PATCH v3 4/6] amdgpu: use drm_kms_helper_connector_hotplug_event

2021-10-15 Thread Harry Wentland
On 2021-10-15 12:33, Simon Ser wrote: > When updating a single connector, use > drm_kms_helper_connector_hotplug_event instead of > drm_kms_helper_hotplug_event. > > Signed-off-by: Simon Ser Reviewed-by: Harry Wentland Patches 1-3 are also Acked-by: Harry Wentland Harry &

Re: [PATCH 02/15] drm/amdgpu: use drm_* functions instead of duplicated code in amdgpu driver

2021-10-15 Thread Harry Wentland
parating the functional bits from the straight refactor will help with bisection if this leads to a regression. All changes look reasonable to me, though. With this patch split into three patches in the sequence (b), (c), then (a) this is Reviewed-by: Harry Wentland Harry > Signed-off-by: Cl

Re: [PATCH v3] drm/dp: Add Additional DP2 Headers

2021-10-08 Thread Harry Wentland
; > Etc.. > Fixed by https://patchwork.freedesktop.org/patch/456190/?series=95166&rev=2 but looks like it's not in drm-misc-next. Siqueira, do you have bandwidth to pull that patch into drm-misc-next? Harry > Regards, > > Tvrtko > > > On 30/09/2021 22:21,

Re: connector_bad_edid() is broken (was: Re: [PATCH] drm/edid: Fix crash with zero/invalid EDID)

2021-10-05 Thread Harry Wentland
On 2021-10-05 11:25, Zuo, Jerry wrote: > [AMD Official Use Only] > >> -Original Message- >> From: Doug Anderson >> Sent: October 5, 2021 11:14 AM >> To: Zuo, Jerry >> Cc: Ville Syrjälä ; dri- >> de...@lists.freedesktop.org; ge...@linux-m68k.org; oliver.s...@intel.com; >> Daniel Vetter

Re: [PATCH 2/2] amd/amdgpu_dm: Verify Gamma and Degamma LUT sizes using DRM Core check

2021-10-04 Thread Harry Wentland
On 2021-10-01 15:56, Sean Paul wrote: > On Wed, Sep 29, 2021 at 03:39:26PM -0400, Mark Yacoub wrote: >> From: Mark Yacoub >> >> [Why] >> drm_atomic_helper_check_crtc now verifies both legacy and non-legacy LUT >> sizes. There is no need to check it within amdgpu_dm_atomic_check. >> >> [How] >>

Re: [PATCH v2] drm/amd/display: Only define DP 2.0 symbols if not already defined

2021-09-29 Thread Harry Wentland
> already defined > > [AMD Official Use Only] > >> -Original Message- >> From: Harry Wentland >> Sent: September 28, 2021 1:08 PM >> To: Deucher, Alexander ; amd- >> g...@lists.freedesktop.org; Zuo, Jerry >> Cc: jani.nik...@intel.com; L

[PATCH v3] drm/amd/display: Only define DP 2.0 symbols if not already defined

2021-09-28 Thread Harry Wentland
ollow-up header updates for any addition DP 2.0 definitions required by our driver. We also ensure drm_dp_helper.h is included before dc_dp_types.h. v3: Ensure drm_dp_helper.h is included before dc_dp_types.h v2: Add one missing endif Signed-off-by: Harry Wentland Reviewed-by: Fangzhi Zuo ---

[PATCH v2] drm/amd/display: Only define DP 2.0 symbols if not already defined

2021-09-28 Thread Harry Wentland
our driver and provide follow-up header updates for any addition DP 2.0 definitions required by our driver. Signed-off-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dc_dp_types.h | 54 ++-- 1 file changed, 49 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm

Re: [PATCH v3] drm/dp: Add Additional DP2 Headers

2021-09-28 Thread Harry Wentland
On 2021-09-27 15:23, Fangzhi Zuo wrote: > Include FEC, DSC, Link Training related headers. > > Change since v2 > - Align with the spec for DP_DSC_SUPPORT_AND_DSC_DECODER_COUNT > > Signed-off-by: Fangzhi Zuo Reviewed-by: Harry Wentland Harry > --- > This patch is b

Re: [RFC PATCH v3 1/6] drm/doc: Color Management and HDR10 RFC

2021-09-23 Thread Harry Wentland
On 2021-09-23 04:01, Pekka Paalanen wrote: > On Wed, 22 Sep 2021 11:06:53 -0400 > Harry Wentland wrote: > >> On 2021-09-20 20:14, Harry Wentland wrote: >>> On 2021-09-15 10:01, Pekka Paalanen wrote:> On Fri, 30 Jul 2021 16:41:29 >>>

[PATCH] drm/amd/display: Only define DP 2.0 symbols if not already defined

2021-09-22 Thread Harry Wentland
ollow-up header updates for any addition DP 2.0 definitions required by our driver. Signed-off-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dc_dp_types.h | 53 ++-- 1 file changed, 48 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc_dp_types.h b/

Re: [RFC PATCH v3 1/6] drm/doc: Color Management and HDR10 RFC

2021-09-22 Thread Harry Wentland
On 2021-09-22 04:31, Pekka Paalanen wrote: > On Tue, 21 Sep 2021 14:05:05 -0400 > Harry Wentland wrote: > >> On 2021-09-21 09:31, Pekka Paalanen wrote: >>> On Mon, 20 Sep 2021 20:14:50 -0400 >>> Harry Wentland wrote: >>> ... > >>

Re: [RFC PATCH v3 1/6] drm/doc: Color Management and HDR10 RFC

2021-09-22 Thread Harry Wentland
On 2021-09-20 20:14, Harry Wentland wrote: > On 2021-09-15 10:01, Pekka Paalanen wrote:> On Fri, 30 Jul 2021 16:41:29 -0400 >> Harry Wentland wrote: >> >>> +If a display's maximum HDR white level is correctly reported it is trivial >>> +to convert be

Re: [RFC PATCH v3 1/6] drm/doc: Color Management and HDR10 RFC

2021-09-21 Thread Harry Wentland
On 2021-09-21 09:31, Pekka Paalanen wrote: > On Mon, 20 Sep 2021 20:14:50 -0400 > Harry Wentland wrote: > >> On 2021-09-15 10:01, Pekka Paalanen wrote:> On Fri, 30 Jul 2021 16:41:29 >> -0400 >>> Harry Wentland wrote: >>> >>>> Use the

Re: [RFC PATCH v3 1/6] drm/doc: Color Management and HDR10 RFC

2021-09-20 Thread Harry Wentland
On 2021-09-15 10:36, Pekka Paalanen wrote: > On Mon, 16 Aug 2021 15:37:23 +0200 > sebast...@sebastianwick.net wrote: > >> On 2021-08-16 14:40, Harry Wentland wrote: >>> On 2021-08-16 7:10 a.m., Brian Starkey wrote: >>>> On Fri, Aug 13, 2021 at 10:4

Re: [RFC PATCH v3 1/6] drm/doc: Color Management and HDR10 RFC

2021-09-20 Thread Harry Wentland
On 2021-09-15 10:01, Pekka Paalanen wrote:> On Fri, 30 Jul 2021 16:41:29 -0400 > Harry Wentland wrote: > >> Use the new DRM RFC doc section to capture the RFC previously only >> described in the cover letter at >> https://patchwork.freedesktop.org/series/89506/ >

Re: amdgpu: atomic API and cursor/overlay planes

2021-09-14 Thread Harry Wentland
On 2021-09-07 10:03, Simon Ser wrote: > Hi all, > > Recently I've been discussing with various people [1] [2] about amdgpu's > handling of KMS planes. AMD hardware is a bit special when it comes to > the cursor plane, and it's not always 100% clear how that maps with the > KMS API. > > Up until n

Re: [PATCH 00/14] drm/hdcp: Pull HDCP auth/exchange/check into

2021-09-13 Thread Harry Wentland
On 2021-09-13 3:26 p.m., Sean Paul wrote: > On Mon, Sep 13, 2021 at 2:05 PM Alex Deucher wrote: >> >> On Mon, Sep 13, 2021 at 1:57 PM Sean Paul wrote: >>> >>> From: Sean Paul >>> >>> Hello, >>> This patchset pulls the HDCP protocol auth/exchange/check logic out from >>> i915 into a HDCP helpe

Re: [PATCH][next] drm/amd/display: fix spelling mistake "alidation" -> "validation"

2021-08-25 Thread Harry Wentland
On 2021-08-25 7:36 a.m., Colin King wrote: > From: Colin Ian King > > There is a spelling mistake in a DC_LOG_WARNING message. Fix it. > > Signed-off-by: Colin Ian King Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c | 2

Re: [RFC PATCH v3 1/6] drm/doc: Color Management and HDR10 RFC

2021-08-16 Thread Harry Wentland
On 2021-08-16 7:10 a.m., Brian Starkey wrote: > On Fri, Aug 13, 2021 at 10:42:12AM +0530, Sharma, Shashank wrote: >> Hello Brian, >> (+Uma in cc) >> >> Thanks for your comments, Let me try to fill-in for Harry to keep the design >> discussion going. Please find my comments inline. >> Thanks, Sh

[RFC PATCH v3 2/6] drm/color: Add transfer functions for HDR/SDR on drm_plane

2021-07-30 Thread Harry Wentland
quot; from transfer function name (Harry) - add DRM_TF_UNDEFINED enum as legacy default (Harry) Signed-off-by: Bhawanpreet Lakha Signed-off-by: Harry Wentland --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 +- .../gpu/drm/arm/display/komeda/komeda_plane.c | 4 +- drivers/g

[RFC PATCH v3 4/6] drm/color: Add sdr boost property

2021-07-30 Thread Harry Wentland
imum white level for the SDR plane. v2: - fix type in description Signed-off-by: Bhawanpreet Lakha Signed-off-by: Harry Wentland --- drivers/gpu/drm/drm_atomic_uapi.c | 4 drivers/gpu/drm/drm_color_mgmt.c | 17 + include/drm/drm_color_mgmt.h | 6 ++ i

[RFC PATCH v3 6/6] drm/amd/display: reformat YCbCr-RGB conversion matrix

2021-07-30 Thread Harry Wentland
Show the CSC matrixes in a 4x3 format. Signed-off-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/inc/hw/dpp.h | 28 + 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/inc/hw/dpp.h b/drivers/gpu/drm/amd/display/dc/inc/hw

[RFC PATCH v3 5/6] drm/color: Add color space plane property

2021-07-30 Thread Harry Wentland
From: Bhawanpreet Lakha Add color space definitions for BT601, BT709, BT2020, and DCI-P3. Default to BT709, the sRGB color space. Signed-off-by: Bhawanpreet Lakha Signed-off-by: Harry Wentland --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 + .../gpu/drm/arm/display/komeda

[RFC PATCH v3 3/6] drm/color: Add output transfer function to crtc

2021-07-30 Thread Harry Wentland
ucing named transfer functions. The original LUT behavior is preserved with the default "1D LUT" transfer function. Signed-off-by: Harry Wentland --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 11 +++- .../gpu/drm/arm/display/komeda/komeda_crtc.c | 7 ++- drivers/gpu/drm/ar

[RFC PATCH v3 1/6] drm/doc: Color Management and HDR10 RFC

2021-07-30 Thread Harry Wentland
Cline's excellent HDR summaries * Outline intention behind overly verbose doc * Describe FP16 use-case * Clean up links v2: create this doc v1: n/a Signed-off-by: Harry Wentland --- Documentation/gpu/rfc/color_intentions.drawio | 1 + Documentation/gpu/rfc/color_intentions.svg

[RFC PATCH v3 0/6] A drm_plane API to support HDR planes

2021-07-30 Thread Harry Wentland
plane property Harry Wentland (3): drm/doc: Color Management and HDR10 RFC drm/color: Add output transfer function to crtc drm/amd/display: reformat YCbCr-RGB conversion matrix Documentation/gpu/rfc/color_intentions.drawio | 1 + Documentation/gpu/rfc/color_intentions.svg| 3 + Docume

Re: [PATCH] drm/nouveau/kms/nv50-: fix build failure with CONFIG_BACKLIGHT=n

2021-07-23 Thread Harry Wentland
On 2021-07-23 3:14 p.m., Cornij, Nikola wrote: > [AMD Official Use Only] > > +Harry > > -Original Message- > From: Daniel Vetter > Sent: Friday, July 23, 2021 11:23 AM > To: Arnd Bergmann > Cc: Daniel Vetter ; Ben Skeggs ; David > Airlie ; Lyude Paul ; Arnd Bergmann > ; Ville Syrjä

Re: [PATCH] drm/amd/display: Fix 10bit 4K display on CIK GPUs

2021-07-15 Thread Harry Wentland
z MBP Retina eDP panel with DCE-11.2. These are the > highest resolution/framerate monitors I have atm.I don't have access > to any 4k monitors, so maybe the problem is somehow specific to such > high resolutions? Maybe somewhere else in the code something would > need to be adapted? La

Re: [PATCH 1/2] drm: add crtc background color property

2021-07-15 Thread Harry Wentland
On 2021-07-15 5:34 a.m., Pekka Paalanen wrote: > On Wed, 14 Jul 2021 12:13:58 -0400 > Harry Wentland wrote: > >> On 2021-07-14 3:35 a.m., Pekka Paalanen wrote: >>> On Tue, 13 Jul 2021 09:54:35 -0400 >>> Harry Wentland wrote: >>> >>

Re: [PATCH 1/2] drm: add crtc background color property

2021-07-14 Thread Harry Wentland
On 2021-07-14 3:35 a.m., Pekka Paalanen wrote: > On Tue, 13 Jul 2021 09:54:35 -0400 > Harry Wentland wrote: > >> On 2021-07-13 3:52 a.m., Pekka Paalanen wrote: >>> On Mon, 12 Jul 2021 12:15:59 -0400 >>> Harry Wentland wrote: >>> >>

Re: [PATCH 1/2] drm: add crtc background color property

2021-07-13 Thread Harry Wentland
On 2021-07-13 3:52 a.m., Pekka Paalanen wrote: > On Mon, 12 Jul 2021 12:15:59 -0400 > Harry Wentland wrote: > >> On 2021-07-12 4:03 a.m., Pekka Paalanen wrote: >>> On Fri, 9 Jul 2021 18:23:26 +0200 >>> Raphael Gallais-Pou wrote: >>> >

Re: [PATCH 1/2] drm: add crtc background color property

2021-07-12 Thread Harry Wentland
On 2021-07-12 4:03 a.m., Pekka Paalanen wrote: > On Fri, 9 Jul 2021 18:23:26 +0200 > Raphael Gallais-Pou wrote: > >> On 7/9/21 10:04 AM, Pekka Paalanen wrote: >>> On Wed, 7 Jul 2021 08:48:47 + >>> Raphael GALLAIS-POU - foss wrote: >>> Some display controllers can be programmed to p

Re: [PATCH] drm/amd/display: Respect CONFIG_FRAME_WARN=0 in dml Makefile

2021-06-29 Thread Harry Wentland
/../display/dc/dml/dcn31/display_mode_vba_31.c:3957:6: > warning: stack frame size of 2568 bytes in function > 'dml31_ModeSupportAndSystemConfigurationFull' [-Wframe-larger-than=] > > Signed-off-by: Reka Norman Reviewed-by: Harry Wentland Harry > --- > > driv

Re: [PATCH 04/21] drm/i915/xelpd: Define Degamma Lut range struct for HDR planes

2021-06-28 Thread Harry Wentland
On 2021-06-01 6:52 a.m., Uma Shankar wrote: > Define the structure with XE_LPD degamma lut ranges. HDR and SDR > planes have different capabilities, implemented respective > structure for the HDR planes. > > Signed-off-by: Uma Shankar > --- > drivers/gpu/drm/i915/display/intel_color.c | 52 +

Re: [PATCH] drm/amdgpu/dc: Really fix DCN3.1 Makefile for PPC64

2021-06-25 Thread Harry Wentland
e") > Signed-off-by: Michal Suchanek Reviewed-by: Harry Wentland Harry > --- > The fact that the old gcc handling triggers on gcc 10 and 11 is another > story I don't want to delve into. > --- > drivers/gpu/drm/amd/display/dc/dcn31/Makefile | 2 ++ > 1 file chan

Re: [PATCH] drm/display: Fix duplicated argument

2021-06-18 Thread Harry Wentland
On 2021-06-16 10:40 a.m., Wan Jiabing wrote: > Fix coccicheck warning: > > ./drivers/gpu/drm/amd/display/dc/dml/dcn31/display_rq_dlg_calc_31.c: > 55:12-42: duplicated argument to && or || > > Signed-off-by: Wan Jiabing Reviewed-by: Harry Wentland Harry > ---

Re: [PATCH] drm/amd/display: Remove the repeated dpp1_full_bypass declaration

2021-06-18 Thread Harry Wentland
On 2021-06-17 9:23 p.m., Shaokun Zhang wrote: > Function 'dpp1_full_bypass' is declared twice, so remove the repeated > declaration and unnessary blank line. > > Cc: Harry Wentland > Cc: Leo Li > Cc: Alex Deucher > Signed-off-by: Shaokun Zhang Revi

Re: [PATCH][next] drm/amd/display: Fix fall-through warning for Clang

2021-06-17 Thread Harry Wentland
implicit fall-through markings, so in order to globally enable > -Wimplicit-fallthrough for Clang, these comments need to be > replaced with fallthrough; in the whole codebase. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Harr

Re: [PATCH -next] drm/amd/display: remove unused variable 'dc'

2021-06-17 Thread Harry Wentland
ruct dc *dc = NULL; >| ^~ > > This variable is not used in function, this commit remove it to > fix the warning. > > Signed-off-by: Pu Lehui Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c | 2 -- > 1 file changed, 2 delet

Re: [PATCH -next] drm/amd/display: Fix gcc unused variable warning

2021-06-17 Thread Harry Wentland
C_ERROR_UNEXPECTED; >| ^~ > > The variable should be used for error check, let's fix it. > > Signed-off-by: Pu Lehui Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 4 > 1 file changed, 4

Re: [PATCH v2 1/2] drm/dp_mst: Do not set proposed vcpi directly

2021-06-16 Thread Harry Wentland
On 2021-06-15 11:55 p.m., Wayne Lin wrote: > [Why] > When we receive CSN message to notify one port is disconnected, we will > implicitly set its corresponding num_slots to 0. Later on, we will > eventually call drm_dp_update_payload_part1() to arrange down streams. > > In drm_dp_update_payload

Re: [PATCH] drm/amd/display: Verify Gamma & Degamma LUT sizes in amdgpu_dm_atomic_check

2021-06-10 Thread Harry Wentland
On 2021-06-07 10:53 a.m., Mark Yacoub wrote: > On Fri, Jun 4, 2021 at 4:17 PM Harry Wentland wrote: >> >> >> >> On 2021-06-04 1:01 p.m., Mark Yacoub wrote: >>> From: Mark Yacoub >>> >>> For each CRTC state, check the size of Gamma and Deg

Re: [PATCH] drm/amd/display: Fix error code on failure to set brightness

2021-06-08 Thread Harry Wentland
On 2021-06-08 12:32 a.m., Anand K Mistry wrote: > The backlight_ops.update_status function is required to return a > negative error code on failure. Returning a positive code may be > interpreted as a success. This is true for the 'brightness' sysfs file, > which passes through a non-zero value as

Re: [PATCH 0/9] Enhance pipe color support for multi segmented luts

2021-06-07 Thread Harry Wentland
On 2021-06-07 2:01 p.m., Shankar, Uma wrote: > > >> -Original Message----- >> From: Harry Wentland >> Sent: Saturday, June 5, 2021 12:21 AM >> To: Shankar, Uma ; intel-...@lists.freedesktop.org; >> dri- >> de...@lists.freedesktop.org >> Cc

Re: [PATCH] drm/amd/display: Verify Gamma & Degamma LUT sizes in amdgpu_dm_atomic_check

2021-06-04 Thread Harry Wentland
On 2021-06-04 1:01 p.m., Mark Yacoub wrote: > From: Mark Yacoub > > For each CRTC state, check the size of Gamma and Degamma LUTs so > unexpected and larger sizes wouldn't slip through. > > TEST: IGT:kms_color::pipe-invalid-gamma-lut-sizes > > Signed-off-by: Mark Yacoub > Change-Id: I9d513

Re: [PATCH 0/9] Enhance pipe color support for multi segmented luts

2021-06-04 Thread Harry Wentland
On 2021-06-01 6:41 a.m., Uma Shankar wrote: > Modern hardwares have multi segmented lut approach to prioritize > the darker regions of the spectrum. This series introduces a new > UAPI to define the lut ranges supported by the respective hardware. > > This also enables Pipe Color Management Suppor

Re: [PATCH 02/21] drm: Add Plane Degamma Mode property

2021-06-04 Thread Harry Wentland
On 2021-06-01 6:51 a.m., Uma Shankar wrote: > Add Plane Degamma Mode as an enum property. Create a helper > function for all plane color management features. > > This is an enum property with values as blob_id's and exposes > the various gamma modes supported and the lut ranges. Getting > the blob

Re: [PATCH 01/21] drm: Add Enhanced Gamma and color lut range attributes

2021-06-04 Thread Harry Wentland
On 2021-06-02 4:26 p.m., Shankar, Uma wrote: > > >> -Original Message- >> From: Pekka Paalanen >> Sent: Wednesday, June 2, 2021 3:04 PM >> To: Shankar, Uma >> Cc: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Modem, >> Bhanuprakash >> Subject: Re: [PATCH 01/21] drm:

Re: [PATCH 1/1] drm/amd/display: Add missing cases convert_dc_color_depth_into_bpc

2021-06-04 Thread Harry Wentland
On 2021-06-04 9:16 a.m., Werner Sembach wrote: > convert_dc_color_depth_into_bpc() that converts the enum dc_color_depth to an > integer had the cases for COLOR_DEPTH_999 and COLOR_DEPTH_11 missing. > > Signed-off-by: Werner Sembach > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |

Re: [PATCH 00/21] Add Support for Plane Color Lut and CSC features

2021-06-02 Thread Harry Wentland
On 2021-06-02 4:22 p.m., Shankar, Uma wrote: > > >> -Original Message- >> From: Pekka Paalanen >> Sent: Wednesday, June 2, 2021 2:59 PM >> To: Shankar, Uma >> Cc: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Modem, >> Bh

Re: [RESEND 16/26] drm/amd/display/dc/dce/dce_transform: Remove superfluous re-initialisation of DCFE_MEM_LIGHT_SLEEP_CNTL,

2021-06-02 Thread Harry Wentland
splay/dc/dce60/dce60_resource.c:183:3: note: > in expansion of macro ‘XFM_COMMON_REG_LIST_DCE60’ > drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:187:3: note: > in expansion of macro ‘transform_regs’ > drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_6_0_d.h:645:43: &

Re: [RFC PATCH 1/3] drm/color: Add RGB Color encodings

2021-05-18 Thread Harry Wentland
On 2021-05-17 4:34 a.m., Pekka Paalanen wrote: > On Fri, 14 May 2021 17:04:51 -0400 > Harry Wentland wrote: > >> On 2021-04-30 8:53 p.m., Sebastian Wick wrote: >>> On 2021-04-26 20:56, Harry Wentland wrote: > > ... > >>>> Another reason I'm

Re: [RFC PATCH 0/3] A drm_plane API to support HDR planes

2021-05-18 Thread Harry Wentland
On 2021-05-18 3:56 a.m., Pekka Paalanen wrote: > On Mon, 17 May 2021 15:39:03 -0400 > Vitaly Prosyak wrote: > >> On 2021-05-17 12:48 p.m., Sebastian Wick wrote: >>> On 2021-05-17 10:57, Pekka Paalanen wrote: >>>> On Fri, 14 May 2021 17:05:11 -0400 >>

[RFC PATCH v2 5/6] drm/color: Add color space plane property

2021-05-14 Thread Harry Wentland
From: Bhawanpreet Lakha Add color space definitions for BT601, BT709, BT2020, and DCI-P3. Default to BT709, the sRGB color space. Signed-off-by: Bhawanpreet Lakha Signed-off-by: Harry Wentland --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 + .../gpu/drm/arm/display/komeda

[RFC PATCH v2 3/6] drm/color: Add output transfer function to crtc

2021-05-14 Thread Harry Wentland
ucing named transfer functions. The original LUT behavior is preserved with the default "1D LUT" transfer function. Signed-off-by: Harry Wentland --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 11 +++- .../gpu/drm/arm/display/komeda/komeda_crtc.c | 7 ++- drivers/gpu/drm/ar

[RFC PATCH v2 6/6] drm/amd/display: reformat YCbCr-RGB conversion matrix

2021-05-14 Thread Harry Wentland
Show the CSC matrixes in a 4x3 format. Signed-off-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/inc/hw/dpp.h | 28 + 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/inc/hw/dpp.h b/drivers/gpu/drm/amd/display/dc/inc/hw

[RFC PATCH v2 2/6] drm/color: Add transfer functions for HDR/SDR on drm_plane

2021-05-14 Thread Harry Wentland
quot; from transfer function name (Harry) - add DRM_TF_UNDEFINED enum as legacy default (Harry) Signed-off-by: Bhawanpreet Lakha Signed-off-by: Harry Wentland --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 +- .../gpu/drm/arm/display/komeda/komeda_plane.c | 4 +- drivers/g

[RFC PATCH v2 4/6] drm/color: Add sdr boost property

2021-05-14 Thread Harry Wentland
imum white level for the SDR plane. v2: - fix type in description Signed-off-by: Bhawanpreet Lakha Signed-off-by: Harry Wentland --- drivers/gpu/drm/drm_atomic_uapi.c | 4 drivers/gpu/drm/drm_color_mgmt.c | 17 + include/drm/drm_color_mgmt.h | 6 ++ i

[RFC PATCH v2 1/6] drm/doc: Color Management and HDR10 RFC

2021-05-14 Thread Harry Wentland
nance definition * define input/output transfer functions for luminance space transforms, rather than defining the luminance space of an input directly Signed-off-by: Harry Wentland --- Documentation/gpu/rfc/hdr-wide-gamut.rst | 416 +++ Documentation/gpu/rfc/index.rst

[RFC PATCH v2 0/6] A drm_plane API to support HDR planes

2021-05-14 Thread Harry Wentland
on on crtc Bhawanpreet Lakha (3): drm/color: Add transfer functions for HDR/SDR on drm_plane drm/color: Add sdr boost property drm/color: Add color space plane property Harry Wentland (3): drm/doc: Color Management and HDR10 RFC drm/color: Add output transfer function to crtc drm/amd/display

Re: [RFC PATCH 0/3] A drm_plane API to support HDR planes

2021-05-14 Thread Harry Wentland
On 2021-04-27 10:50 a.m., Pekka Paalanen wrote: > On Mon, 26 Apr 2021 13:38:49 -0400 > Harry Wentland wrote: > >> ## Introduction >> >> We are looking to enable HDR support for a couple of single-plane and >> multi-plane scenarios. To do this effectively

Re: [RFC PATCH 1/3] drm/color: Add RGB Color encodings

2021-05-14 Thread Harry Wentland
On 2021-04-30 8:53 p.m., Sebastian Wick wrote: > On 2021-04-26 20:56, Harry Wentland wrote: >> On 2021-04-26 2:07 p.m., Ville Syrjälä wrote: >>> On Mon, Apr 26, 2021 at 01:38:50PM -0400, Harry Wentland wrote: >>>> From: Bhawanpreet Lakha >>>> >>

Re: [RFC PATCH 0/3] A drm_plane API to support HDR planes

2021-05-14 Thread Harry Wentland
On 2021-04-30 6:39 a.m., Shashank Sharma wrote: > Hello Pekka, > > On 30/04/21 15:13, Pekka Paalanen wrote: >> On Wed, 28 Apr 2021 13:24:27 +0530 >> Shashank Sharma wrote: >> >>> Assuming these details, A compositor will look for DRM color properties >>> like these: >>> >>> 1. Degamma plane p

Re: [RFC PATCH 1/3] drm/color: Add RGB Color encodings

2021-04-26 Thread Harry Wentland
On 2021-04-26 2:07 p.m., Ville Syrjälä wrote: On Mon, Apr 26, 2021 at 01:38:50PM -0400, Harry Wentland wrote: From: Bhawanpreet Lakha Add the following color encodings - RGB versions for BT601, BT709, BT2020 - DCI-P3: Used for digital movies Signed-off-by: Bhawanpreet Lakha Signed-off-by

[RFC PATCH 2/3] drm/color: Add Color transfer functions for HDR/SDR

2021-04-26 Thread Harry Wentland
nits The usage is similar to color_encoding and color_range where the driver can specify the default and supported tfs and pass it into drm_plane_create_color_properties(). Signed-off-by: Bhawanpreet Lakha Signed-off-by: Harry Wentland --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4

[RFC PATCH 3/3] drm/color: Add sdr boost property

2021-04-26 Thread Harry Wentland
imum white level for the SDR plane. Signed-off-by: Bhawanpreet Lakha Signed-off-by: Harry Wentland --- drivers/gpu/drm/drm_atomic_uapi.c | 4 drivers/gpu/drm/drm_color_mgmt.c | 17 + include/drm/drm_color_mgmt.h | 6 ++ include/drm/drm_plane.h

[RFC PATCH 1/3] drm/color: Add RGB Color encodings

2021-04-26 Thread Harry Wentland
From: Bhawanpreet Lakha Add the following color encodings - RGB versions for BT601, BT709, BT2020 - DCI-P3: Used for digital movies Signed-off-by: Bhawanpreet Lakha Signed-off-by: Harry Wentland --- drivers/gpu/drm/drm_color_mgmt.c | 4 include/drm/drm_color_mgmt.h | 4 2 files

[RFC PATCH 0/3] A drm_plane API to support HDR planes

2021-04-26 Thread Harry Wentland
## Introduction We are looking to enable HDR support for a couple of single-plane and multi-plane scenarios. To do this effectively we recommend new interfaces to drm_plane. Below I'll give a bit of background on HDR and why we propose these interfaces. ## Defining a pixel's luminance Curr

Re: [PATCH -next] drm/amd/display: Fix the Wunused-function warning

2021-04-08 Thread Harry Wentland
) | ^~ Fixes: 83b39e1fc3ea ("drm/amd/display: Log DMCUB trace buffer events") Cc: Leo (Hanghong) Ma Cc: Daniel Wheeler Cc: Harry Wentland Cc: Solomon Chiu Cc: Alex Deucher Signed-off-by: Shaokun Zhang Reviewed-by: Harry Wentland Harry --- drivers/gpu/drm/amd/display

Re: [PATCH] drm/amd/display: dual cursors are seen if scaling is enabled

2021-03-29 Thread Harry Wentland
On 2021-03-29 3:54 a.m., Louis Li wrote: [Why] This issue is found when scaling is not equal to one from src to dest. When issue happens, there are offsets in both axis x and y between two cursors. Users cannot control APP under such a condition. What's the use case? I don't think we support t

Re: [PATCH] drm/amd/display: Try YCbCr420 color when YCbCr444 fails

2021-03-26 Thread Harry Wentland
: Harry Wentland Harry Alex --- From c9398160caf4ff20e63b8ba3a4366d6ef95c4ac3 Mon Sep 17 00:00:00 2001 From: Werner Sembach Date: Wed, 17 Mar 2021 12:52:22 +0100 Subject: [PATCH] Retry forcing YCbCr420 color on failed encoder validation --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

Re: [PATCH 2/3] drm/connector: Add helper to compare HDR metadata

2021-03-19 Thread Harry Wentland
rn it into an helper that can be shared across those drivers. Signed-off-by: Maxime Ripard Patches 1 & 2 are Reviewed-by: Harry Wentland Harry --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 21 +- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 17 +-- driver

Re: [PATCH 06/19] drm/amd/display/dc/calcs/dce_calcs: Move some large variables from the stack to the heap

2021-03-19 Thread Harry Wentland
/../display/dc/calcs/dce_calcs.c:2016:1: warning: the frame size of 1216 bytes is larger than 1024 bytes [-Wframe-larger-than=] Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Colin Ian King Cc: amd-...@lists.freedesktop.org Cc:

Re: [PATCH 08/19] drm/amd/display/dc/dce80/dce80_resource: Make local functions static

2021-03-19 Thread Harry Wentland
’ [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/dc/dce80/dce80_resource.c:913:16: warning: no previous prototype for ‘dce80_validate_global’ [-Wmissing-prototypes] Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: A

Re: [PATCH] drm/amd/display: Set AMDGPU_DM_DEFAULT_MIN_BACKLIGHT to 0

2021-03-19 Thread Harry Wentland
On 2021-03-19 10:22 a.m., Alex Deucher wrote: On Fri, Mar 19, 2021 at 3:23 AM Evan Benn wrote: AMDGPU_DM_DEFAULT_MIN_BACKLIGHT was set to the value of 12 to ensure no display backlight will flicker at low user brightness settings. However this value is quite bright, so for devices that do n

Re: 2021 X.Org Foundation Election Candidates

2021-03-16 Thread Harry Wentland
is it less. NTL what is important is the application. I would like to see more training material and more X11 applications especially for remote access. But i was never involved in the xorg organisation. So i see myself more as an apprentice. We will see if i can help. Thanks, Harry Wentland, on b

2021 X.Org Foundation Election Candidates

2021-03-15 Thread Harry Wentland
4th April anywhere on earth ** Election Committee ** * Eric Anholt * Mark Filion * Keith Packard * Harry Wentland Thanks, Harry Wentland, on behalf of the X.Org elections committee ** Nominees ** ## Samuel Iglesias Gonsálvez __Current Affiliation:__ Igalia __Personal Statement:__ I

2021 X.Org Foundation Membership renewal period extended to Mar 18

2021-03-11 Thread Harry Wentland
date QA: Mon 15th March Deadline of X.Org membership application or renewal: Thu 18th March Election Planned Start: Mon 22nd March anywhere on earth Election Planned End: Sun 4th April anywhere on earth ** Election Committee ** * Eric Anholt * Mark Filion * Keith Packard * Harry Wentland Th

2021 X.Org Foundation Membership renewal ENDS on THURSDAY Mar 11

2021-03-08 Thread Harry Wentland
Election Planned End: Sun 4th April anywhere on earth ** Election Committee ** * Eric Anholt * Mark Filion * Keith Packard * Harry Wentland Thanks, Harry Wentland, on behalf of the X.Org elections committee ___ dri-devel mailing list

Re: [PATCH][next] drm/amd/display: fix the return of the uninitialized value in ret

2021-03-02 Thread Harry Wentland
elieve setting it to zero is a correct default. Addresses-Coverity: ("Uninitialized scalar variable") Fixes: bd0c064c161c ("drm/amd/display: Add return code instead of boolean for future use") Signed-off-by: Colin Ian King Reviewed-by: Harry Wentland Harry --- drivers/gpu

2021 X.Org Board of Directions Nomination period ends next Sunday

2021-03-01 Thread Harry Wentland
Eric Anholt * Mark Filion * Keith Packard * Harry Wentland Cheers, Harry Wentland, on behalf of the X.Org elections committee ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

2021 X.Org Board of Directors Elections Nomination period is NOW

2021-02-22 Thread Harry Wentland
Filion, Keith Packard, and Harry Wentland. They will continue to serve until their term ends in 2022. Current directors whose term expires in 2021 are Samuel Iglesias Gonsálvez, Manasi D Navare, Lyude Paul, and Daniel Vetter. A director is expected to participate in the fortnightly IRC meeting

2021 X.Org Foundation Membership renewal and election schedule

2021-02-11 Thread Harry Wentland
Sun 4th April anywhere on earth ** Election Committee ** * Eric Anholt * Mark Filion * Keith Packard * Harry Wentland Thanks, Harry Wentland, on behalf of the X.Org elections committee ___ dri-devel mailing list dri-devel@lists.freedes

Re: [PATCH] drm/amd/display: fix unused variable warning

2021-01-25 Thread Harry Wentland
27;dm' [-Werror,-Wunused-variable] Add another such #ifdef. Fixes: 98ab5f3513f9 ("drm/amd/display: Fix deadlock during gpu reset v3") Signed-off-by: Arnd Bergmann Reviewed-by: Harry Wentland Harry --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 ++ 1 file changed,

Re: [PATCH] drm/amdgpu: Assign boolean values to a bool variable

2021-01-20 Thread Harry Wentland
: WARNING: Assignment of 0/1 to bool variable. Reported-by: Abaci Robot Signed-off-by: Jiapeng Zhong Reviewed-by: Harry Wentland Harry --- .../display/dc/dml/dcn30/display_rq_dlg_calc_30.c | 32 +++--- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/gpu

Re: [PATCH][next] drm/amd/display: Fix spelling mistake of function name

2021-01-20 Thread Harry Wentland
On 2021-01-20 4:26 a.m., Colin King wrote: From: Colin Ian King Reviewed-by: Harry Wentland Harry There are two spelling mistakes of the function name, fix this by using __func__ instead of a hard coded name string. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/display/dc

Re: [PATCH] amd/display/amdgpu_dm: delete same check in if condition

2020-11-10 Thread Harry Wentland
On 2020-11-10 3:03 a.m., Bernard Zhao wrote: In function amdgpu_dm_connector_get_modes, drm_edid_is_valid will check weather (!edid), no need to check again in the if branch. Signed-off-by: Bernard Zhao Reviewed-by: Harry Wentland Harry --- drivers/gpu/drm/amd/display/amdgpu_dm

Re: [PATCH] drm: Pass the full state to connectors atomic functions

2020-11-05 Thread Harry Wentland
CRTCs have been converted, let's move forward with the connectors to provide a consistent interface. The conversion was done using the coccinelle script below, and built tested on all the drivers. Did you forget the coccinelle script? Cc: Harry Wentland Cc: Leo Li Cc: Alex Deuche

Re: [PATCH 4/5] drm/amdgpu: fix build_coefficients() argument

2020-10-30 Thread Harry Wentland
at a patch was added using the old calling conventions after the type was changed, and the value should actually be 0 (TRANSFER_FUNCTION_SRGB) here instead of 1 (true). This looks correct to me. Harry, Leo? Confirmed with Kruno, this is correct. Reviewed-by: Harry Wentland Harry Alex

Re: [PATCH] drm/amdgpu: remove unneeded break

2020-10-19 Thread Harry Wentland
On 2020-10-19 10:55 a.m., Christian König wrote: Am 19.10.20 um 16:43 schrieb t...@redhat.com: From: Tom Rix A break is not needed if it is preceded by a return or break Signed-off-by: Tom Rix Acked-by: Christian König Reviewed-by: Harry Wentland Harry ---   drivers/gpu/drm/amd

Re: [PATCH] drm/amd/display: Fix incorrect dsc force enable logic

2020-10-15 Thread Harry Wentland
On 2020-10-15 3:40 p.m., Eryk Brol wrote: [Why] Missed removing a '!' which results in incorrect behavior [How] Remove the offending '!' Signed-off-by: Eryk Brol Reviewed-by: Harry Wentland Harry --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2

Re: [PATCH] drm/amd/display: add debugfs entry for trigger_hotplug

2020-09-28 Thread Harry Wentland
ebugfs entry. Fixes: 6f77b2ac6280 ("drm/amd/display: Add connector HPD trigger debugfs entry") Reviewed-by: Harry Wentland Signed-off-by: YueHaibing Signed-off-by: Alex Deucher Harry > 在 2020/9/12 10:22, Jason Yan 写道: >> The 'trigger_hotplug' entry in

Re: [PATCH] drm/amd/display: make get_color_space_type() static

2020-09-28 Thread Harry Wentland
all patches I feel these are needlessly small. > Reported-by: Hulk Robot > Signed-off-by: Jason Yan Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/driv

Re: [PATCH] drm/amd/display: make two symbols static

2020-09-28 Thread Harry Wentland
; drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:2785:6: > warning: symbol 'dce110_set_cursor_attribute' was not declared. Should > it be static? > > Reported-by: Hulk Robot > Signed-off-by: Jason Yan Reviewed-by: Harry Wentland Harry > --- > driv

Re: [PATCH -next] drm/amd/display: Create trigger_hotplug entry

2020-09-10 Thread Harry Wentland
On 2020-09-09 11:13 p.m., YueHaibing wrote: Add trigger_hotplug debugfs entry. Fixes: 6f77b2ac6280 ("drm/amd/display: Add connector HPD trigger debugfs entry") Signed-off-by: YueHaibing Reviewed-by: Harry Wentland Harry --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_deb

Re: [PATCH -next] drm/amd/display: Fix possible memleak in dp_trigger_hotplug()

2020-09-10 Thread Harry Wentland
On 2020-09-09 11:26 p.m., YueHaibing wrote: If parse_write_buffer_into_params() fails, we should free wr_buf before return. Fixes: 6f77b2ac6280 ("drm/amd/display: Add connector HPD trigger debugfs entry") Signed-off-by: YueHaibing Reviewed-by: Harry Wentland Harry --- drive

Re: [PATCH] drm/amdgpu/dc: Require primary plane to be enabled whenever the CRTC is

2020-09-01 Thread Harry Wentland
On 2020-09-01 3:54 a.m., Daniel Vetter wrote: > On Wed, Aug 26, 2020 at 11:24:23AM +0300, Pekka Paalanen wrote: >> On Tue, 25 Aug 2020 12:58:19 -0400 >> "Kazlauskas, Nicholas" wrote: >> >>> On 2020-08-22 5:59 a.m., Michel Dänzer wrote: On 2020-08-21 8:07 p.m., Kazlauskas, Nicholas wrote:

Re: [PATCH 2/8] drm/amdgpu: Use __drm_atomic_helper_crtc_reset

2020-06-12 Thread Harry Wentland
Cc: Alex Deucher > Cc: Nicholas Kazlauskas > Cc: Harry Wentland > Cc: Rodrigo Siqueira > Cc: Bhawanpreet Lakha > Cc: Roman Li > Cc: Mikita Lipski > Cc: Stylon Wang Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 +

Re: [PATCH 2/2] drm/amd/display: Enable fp16 also on DCE-11.0 - DCE-12.

2020-05-20 Thread Harry Wentland
On 2020-05-15 1:19 a.m., Mario Kleiner wrote: > Testing on a Polaris11 gpu with DCE-11.2 suggests that it > seems to work fine there, so optimistically enable it for > DCE-11 and later. > > Signed-off-by: Mario Kleiner > --- > drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 2 +- > dri

<    2   3   4   5   6   7   8   9   10   11   >