Re: [PATCH] drm/amd/amdgpu: correct length misspelling

ch. You can do that by providing a range to "git format-patch". I usually call git format-patch with the -o parameter to put all my patches in a directory. Then I can send it with "git send-email *" in that directory. Reviewed-by: Harry Wentland This won't apply cleanly witho

Re: [PATCH] dc.c:use kzalloc without test

On 2019-10-23 4:32 a.m., zhongshiqi wrote: > dc.c:583:null check is needed after using kzalloc function > > Signed-off-by: zhongshiqi Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/dc/core/dc.c | 4 > 1 file changed, 4 insertions(+) > >

Re: [PATCH 1/3] drm: Introduce scaling filter mode property

On 2019-10-22 8:20 a.m., Ville Syrjälä wrote: > On Tue, Oct 22, 2019 at 03:29:44PM +0530, Shashank Sharma wrote: >> This patch adds a scaling filter mode porperty >> to allow: >> - A driver/HW to showcase it's scaling filter capabilities. >> - A userspace to pick a desired effect while scaling.

Re: [PATCH] drm: Fix DSC throughput mode 0 mask definition

fication. > > Cc: Harry Wentland > Cc: Leo Li > Cc: Alex Deucher > Cc: Nikola Cornij > Cc: Jani Nikula > Cc: Manasi Navare > Cc: Ville Syrjälä > Fixes: d7cd0e053b1 (drm/amd/display: Add 170Mpix/sec DSC throughput support) > Signed-off-by: Rodrigo Siqueira Rev

Re: [PATCH] drm: Add LT-tunable PHY repeater mode operations

definitions. > > Cc: Abdoulaye Berthe > Cc: Harry Wentland > Cc: Leo Li > Cc: Jani Nikula > Cc: Manasi Navare > Cc: Ville Syrjälä > Signed-off-by: Abdoulaye Berthe > Signed-off-by: Rodrigo Siqueira Reviewed-by: Harry Wentland Harry > --- > include/drm/

Re: [PATCH 0/3] drm/amd/display/dc/dce: remove some not used variables

Thanks for the patches. I think for all of them we should just drop the REG_READ calls completely. They look like leftovers from when we had a different register update scheme that would read the register, then update or get the field value. Now we just use the REG_ macros that will combine the

Re: [PATCH] drm/amdgpu/display: make various arrays static, makes object smaller

On 2019-10-08 10:00 a.m., Joe Perches wrote: > On Tue, 2019-10-08 at 13:56 +0000, Harry Wentland wrote: > [] >>> diff --git a/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c >>> b/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c >> [] >>> @@ -

Re: [PATCH] drm/amdgpu/display: make various arrays static, makes object smaller

On 2019-10-07 5:58 p.m., Colin King wrote: > From: Colin Ian King > > Don't populate the arrays on the stack but instead make them > static. Makes the object code smaller by 158 bytes. > > Before: >text data bss dec hex filename > 32468 2072 0 34540

Re: [PATCH 0/5] drm/amd/display: some fixes for gcc warning

Series is Reviewed-by: Harry Wentland Harry On 2019-10-04 10:44 p.m., zhengbin wrote: > zhengbin (5): > drm/amd/display: Make function wait_for_alt_mode static > drm/amd/display: Remove set but not used variable 'source_bpp' > drm/amd/display: Remove set but not us

Re: [PATCH] drm/amd/display: Fix typo in some comments

On 2019-10-05 7:32 a.m., Christophe JAILLET wrote: > p and g are switched in 'amdpgu_dm' > > Signed-off-by: Christophe JAILLET Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 dele

Re: [PATCH -next] drm/amd/display: remove set but not used variable 'core_freesync'

:24: > warning: variable core_freesync set but not used [-Wunused-but-set-variable] > > It is not used since commit 98e6436d3af5 ("drm/amd/display: Refactor FreeSync > module") > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing Reviewed-by: Harry Wentland Harry

Re: [PATCH 3/6] drm/amdgpu/dm/mst: Use ->atomic_best_encoder

On 2019-09-26 6:51 p.m., Lyude Paul wrote: > We are supposed to be atomic after all. We'll need this in a moment for > the next commit. > > Signed-off-by: Lyude Paul Reviewed-by: Harry Wentland Harry > --- > .../drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c| 10 ++

Re: [PATCH 1/6] drm/amdgpu/dm/mst: Don't create MST topology managers for eDP ports

On 2019-09-26 6:51 p.m., Lyude Paul wrote: > Signed-off-by: Lyude Paul Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/amd

Re: [PATCH] drm/amd/display: prevent memory leak

On 2019-09-25 12:23 a.m., Navid Emamdoost wrote: > In dcn*_create_resource_pool the allocated memory should be released if > construct pool fails. > > Signed-off-by: Navid Emamdoost Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/dc/dce100/dce

Re: [PATCH] drm/amd/display: hide an unused variable

in an #ifdef like its only users. > > Fixes: 14b2584636c6 ("drm/amd/display: add functionality to grab DPRX CRC > entries.") > Signed-off-by: Arnd Bergmann Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 ++ &

Re: HDCP Content Type Interface

On 2019-09-12 10:57 a.m., Jani Nikula wrote: > On Thu, 12 Sep 2019, Harry Wentland wrote: >> On 2019-09-12 3:47 a.m., Ramalingam C wrote: >>> On 2019-09-09 at 15:54:50 +, Lakha, Bhawanpreet wrote: >>>> Hi all, >>>> >>>> This is regard

Re: HDCP Content Type Interface

On 2019-09-12 10:49 a.m., Ramalingam C wrote: > On 2019-09-12 at 14:23:05 +0000, Harry Wentland wrote: >> On 2019-09-12 3:47 a.m., Ramalingam C wrote: >>> On 2019-09-09 at 15:54:50 +, Lakha, Bhawanpreet wrote: >>>> Hi all, >>>> >>>>

Re: [PATCH v7 04/11] drm: revocation check at drm subsystem

On 2019-09-12 2:54 a.m., Ramalingam C wrote: > On 2019-09-12 at 00:15:32 +0000, Harry Wentland wrote: >> Adding a couple AMD guys. >> >> I know this is already merged but I have a few questions after some >> internal discussions. >> >> On 2019-05-07 12:27

Re: HDCP Content Type Interface

On 2019-09-12 3:47 a.m., Ramalingam C wrote: > On 2019-09-09 at 15:54:50 +, Lakha, Bhawanpreet wrote: >> Hi all, >> >> This is regarding the recent hdcp content type patch that was merged into >> drm-misc. >> (https://patchwork.freedesktop.org/patch/320958/?series=57233=11) >> >> There are

Re: [PATCH v7 04/11] drm: revocation check at drm subsystem

Adding a couple AMD guys. I know this is already merged but I have a few questions after some internal discussions. On 2019-05-07 12:27 p.m., Ramalingam C wrote: > On every hdcp revocation check request SRM is read from fw file > /lib/firmware/display_hdcp_srm.bin > According to section 5 of

Re: [PATCH] drm: fix warnings in DSC

On 2019-09-11 4:47 a.m., Benjamin Gaignard wrote: > Remove always false comparisons due to limited range of nfl_bpg_offset > and scale_increment_interval fields. > Warnings detected when compiling with W=1. > > Signed-off-by: Benjamin Gaignard Reviewed-by: Harry W

Re: [PATCH] drm: include: fix W=1 warnings in struct drm_dsc_config

+Manasi, Gaurav On 2019-09-09 9:52 a.m., Benjamin Gaignard wrote: > Change scale_increment_interval and nfl_bpg_offset fields to > u32 to avoid W=1 warnings because we are testing them against > 65535. > > Signed-off-by: Benjamin Gaignard > --- > include/drm/drm_dsc.h | 6 -- > 1 file

Re: [PATCH] drm/amd/display: Move static keyword to the front of declaration

/core/dc.c:75:1: warning: > ‘static’ is not at beginning of declaration [-Wold-style-declaration] > > Signed-off-by: Krzysztof Wilczynski Reviewed-by: Harry Wentland Harry > --- > Related: https://lore.kernel.org/r/20190827233017.gk9...@google.com > > drivers/gpu/drm/amd/d

Re: [PATCH V4] drm: Add LTTPR defines for DP 1.4a

V2: >> - Drop the kernel-doc comment >> - Reorder LTTPR according to register offset >> Changes since V1: >> - Adjusts registers names to be aligned with spec and the rest of the >> file >> - Update spec comment from 1.4 to 1.4a >> >> Cc: Abdou

Re: linux-next: Tree for Sep 4 (amd/display/)

On 2019-09-04 4:58 p.m., Randy Dunlap wrote: > On 9/4/19 6:34 AM, Stephen Rothwell wrote: >> Hi all, >> >> News: this will be the last linux-next I will release until Sept 30. >> >> Changes since 20190903: >> > > on x86_64: > > In file included from >

Re: [PATCH v2 1/3] drm/amd: be quiet when no SAD block is found

_bug.cgi?id=107825 > > Signed-off-by: Jean Delvare > Cc: Alex Deucher > Cc: "Christian König" > Cc: "David (ChunMing) Zhou" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Harry Wentland > Cc: Leo Li Reviewed-by: Harry Wentland Harry > --

Re: [PATCH V3] drm: Add LTTPR defines for DP 1.4a

> - Reorder LTTPR according to register offset > Changes since V1: > - Adjusts registers names to be aligned with spec and the rest of the > file > - Update spec comment from 1.4 to 1.4a > > Cc: Abdoulaye Berthe > Cc: Harry Wentland > Cc: Leo Li > Cc: Jani Nikula

Re: [PATCH RESEND 03/14] drm/amdgpu: Provide ddc symlink in dm connector's sysfs directory

On 2019-08-26 3:25 p.m., Andrzej Pietrasiewicz wrote: > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 5 +++-- > 1 file changed,

Re: [PATCH 2/3] drm/amd/display: remove unused function setFieldWithMask

On 2019-08-27 3:09 a.m., YueHaibing wrote: > After commit a9f54ce3c603 ("drm/amd/display: Refactoring VTEM"), > there is no caller in tree. > > Reported-by: Hulk Robot Signed-off-by: YueHaibing > Reviewed-by: Harry Wentland Harry > --- > .../drm/

Re: [PATCH v4 0/5] MST DSC support in drm-mst

On 2019-08-26 3:50 p.m., Dave Airlie wrote: > On Sat, 24 Aug 2019 at 06:24, Francis, David wrote: >> >> Adding DSC functionality to drm_dp_mst_atomic_check() is a good idea. >> However, until amdgpu switches over to that system, I wouldn't be able >> to test those changes. Making that switch is

Re: [PATCH v8 5/6] drm/dp_mst: Add new quirk for Synaptics MST hubs

every > device we care about and none we don't > - If a future Synaptics device supports virtual DPCD properly, we will check > for that first and never resort to the workaround (see patch 6/6) > - We don't know any of the properties of any hypothetical future Synaptics > hardware,

Re: [PATCH v8 6/6] drm/dp_mst: Add helpers for MST DSC and virtual DPCD aux

On 2019-08-26 2:05 p.m., David Francis wrote: > Add drm_dp_mst_dsc_aux_for_port. To enable DSC, the DSC_ENABLED > register might have to be written on the leaf port's DPCD, > its parent's DPCD, or the MST manager's DPCD. This function > finds the correct aux for the job. > > As part of this, add

Re: [PATCH v8 5/6] drm/dp_mst: Add new quirk for Synaptics MST hubs

On 2019-08-26 2:05 p.m., David Francis wrote: > Synaptics DP1.4 hubs (BRANCH_ID 0x90CC24) do not > support virtual DPCD registers, but do support DSC. > The DSC caps can be read from the physical aux, > like in SST DSC. These hubs have many different > DEVICE_IDs. Add a new quirk to detect this

Re: [PATCH v8 4/6] drm/dp_mst: Fill branch->num_ports

t; > v2: remember to decrement on port removal > v3: don't explicitly init to 0 > > Signed-off-by: David Francis > Reviewed-by: Lyude Paul Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/drm_dp_mst_topology.c | 2 ++ > 1 file changed, 2 inser

Re: [PATCH v8 3/6] drm/dp_mst: Add MST support to DP DPCD R/W functions

ix spacing > v3: Dump dpcd access on MST read/writes > > Reviewed-by: Lyude Paul Reviewed-by: Harry Wentland Harry > Signed-off-by: David Francis > --- > drivers/gpu/drm/drm_dp_aux_dev.c | 12 ++-- > drivers/gpu/drm/drm_dp_helper.c | 30 --

Re: [PATCH v8 1/6] drm/dp_mst: Add PBN calculation for DSC modes

xel, but > 1/16 of a bit per pixel > > v2: Don't add separate function for this > > Cc: amd-...@lists.freedesktop.org > Cc: nouv...@lists.freedesktop.org > Cc: intel-...@lists.freedesktop.org > Reviewed-by: Manasi Navare > Reviewed-by: Lyude Paul Reviewed-by: Harry Wentla

Re: [PATCH v8 2/6] drm/dp_mst: Parse FEC capability on MST ports

2.11.9.4 of DP standard, > v1.4) > > That value is needed for FEC and DSC support > > Store it on drm_dp_mst_port > > Signed-off-by: David Francis > Reviewed-by: Lyude Paul Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/drm_dp_mst_topology.c | 2 ++

Re: [PATCH V2] drm: Add LTTPR defines for DP 1.4a

ts registers names to be aligned with spec and the rest of the > file > - Update spec comment from 1.4 to 1.4a > > Cc: Abdoulaye Berthe > Cc: Harry Wentland > Cc: Leo Li > Signed-off-by: Rodrigo Siqueira > Signed-off-by: Abdoulaye Berthe Reviewed-by: Harry Wentland Harry

Re: [PATCH -next] drm/amdgpu/display: fix build error without CONFIG_DRM_AMD_DC_DSC_SUPPORT

> Use CONFIG_DRM_AMD_DC_DSC_SUPPORT to guard this. > > Reported-by: Hulk Robot > Fixes: 8a31820b1218 ("drm/amd/display: Make init_hw and init_pipes generic > for seamless boot") > Signed-off-by: YueHaibing Reviewed-by: Harry Wentland Harry > --- > drivers/gp

Re: [PATCH] drm/drm_connector: add additional aspect ratio values

rm_aspect_ratio_enum_list. > Thereafter, one can specify the aspect ratio to "64:27" or "256:135" > after creating aspect ratio property.> > Change-Id: Ifc9df54e8e8f78e70960fcd737a3a57e49c81152 > Signed-off-by: Wayne Lin Drop the Change-Id. With that

Re: [PATCH] drm: Add LTTPR defines for DP 1.4

On 2019-08-22 6:46 p.m., Siqueira, Rodrigo wrote: > DP 1.4 specification defines Link Training Tunable PHY Repeater (LTTPR) > which is required to add support for systems with Thunderbolt or other > repeater devices. > > Cc: Abdoulaye Berthe > Cc: Harry Wentland > Cc:

Re: [PATCH][drm-next] drm/amd/display: fix a potential null pointer dereference

orming dereference after it is null checked. > > Addresses-Coverity: ("Dereference before null check") > Fixes: 9adc8050bf3c ("drm/amd/display: make firmware info only load once > during dc_bios create") > Signed-off-by: Colin Ian King Reviewed-by: Harry Went

Re: [PATCH] drm/amd/display: Fix 32-bit divide error in wait_for_alt_mode

> Fixes: b5b1f4554904 ("drm/amd/display: Enable type C hotplug") > Reported-by: Randy Dunlap > Signed-off-by: Nathan Chancellor Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/dc/core/dc_link.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deleti

[PATCH] drm/amd/display: Add number of slices per line to DSC parameter validation

From: Nikola Cornij [why] Number of slices per line was mistakenly left out Cc: Hariprasad Kelam Signed-off-by: Nikola Cornij Signed-off-by: Harry Wentland Reviewed-by: Harry Wentland --- Thanks, Hariprasad, for your patch. The second condition should actually check for num_slices_h

[PATCH] drm/amd/display: Use msleep instead of udelay for 8ms wait

arm32's udelay only allows values up to 2000 microseconds. msleep does the trick for us here as there is no problem if this isn't microsecond accurate and takes a tad longer. Signed-off-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 2 +- 1 file changed, 1 insertion

Re: [PATCH 2/2] drm: Set crc->opened = false before setting crc source to NULL.

blems for Rockchip with the Analogix bridge. Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/drm_debugfs_crc.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/gpu/drm/drm_debugfs_crc.c > b/drivers/gpu/drm/drm_debugfs_crc.c > index e20adef9d6

Re: [PATCH] drm: actually remove the newline for CRC source name.

chen Zhang wrote: > 'n-1' is the index to replace the newline character of CRC source name. > Add here: v2: Update patch subject (Sam) > Cc: Leo Li > Cc: Harry Wentland > Signed-off-by: Dingchen Zhang > --- > drivers/gpu/drm/drm_debugfs_crc.c | 4 ++-- > 1 file cha

Re: [PATCH][next] drm/amd/display: remove redundant assignment to status

On 2019-05-30 12:12 p.m., Colin King wrote: > From: Colin Ian King > > The variable status is initialized with a value that is never read > and status is reassigned several statements later. This initialization > is redundant and can be removed. > > Addresses-Coverity: ("Unused value") >

Re: [PATCH 0/2] drm/amd/display: Add HDR output metadata support for amdgpu

ince that's all the > DRM interface supports. It requires a modeset for entering and exiting HDR > but the metadata can be changed without one. > > Cc: Harry Wentland > Series is Reviewed-by: Harry Wentland Harry > Nicholas Kazlauskas (2): > drm/amd/display: Expo

[PATCH] drm/connector: Add doc for content_protection tri-state

It was there all along in the patch description when this change was introduced but it would be helpful to have the same documented in the code. Signed-off-by: Harry Wentland Cc: Sean Paul Cc: Sean Paul Cc: Bhawanpreet Lakha --- drivers/gpu/drm/drm_connector.c | 9 + 1 file changed

Re: [PATCH] drm/amd/display: Allow faking displays as VRR capable.

On 2019-04-30 3:56 p.m., Mario Kleiner wrote: > [CAUTION: External Email] > > On Tue, Apr 30, 2019 at 2:22 PM Kazlauskas, Nicholas > wrote: >> >> On 4/30/19 3:44 AM, Michel Dänzer wrote: >>> [CAUTION: External Email] >>> >>> On 2019-04-30 9:37 a.m., Mario Kleiner wrote: Allow to detect

2019 Xorg Election Results

this into account and forced voters to rank every candidate. Due to the lack of controversy about the candidates we don't expect this to have had any impact on the final results. Thanks, Harry Wentland, On behalf of the Xorg Elections Committee

[PATCH v3] Allow fd.o to join forces with X.Org

The leadership of freedesktop.org (fd.o) has recently expressed interest in having an elected governing body. Given the tight connection between fd.o and X.Org and the fact that X.Org has such a governing body it seemed obvious to consider extending X.Org's mandate to fd.o. Quite a bit of

[RFC] Allow fd.o to join forces with X.Org

The leadership of freedesktop.org (fd.o) has recently expressed interest in having an elected governing body. Given the tight connection between fd.o and X.Org and the fact that X.Org has such a governing body it seemed obvious to consider extending X.Org's mandate to fd.o. Quite a bit of

Re: [PATCH v4 4/4] drm/amd/display: Set FreeSync state using drm VRR properties

On 2018-10-11 04:56 PM, Kazlauskas, Nicholas wrote: > On 10/11/2018 04:39 PM, Harry Wentland wrote: >> On 2018-10-11 12:39 PM, Nicholas Kazlauskas wrote: >>> Support for AMDGPU specific FreeSync properties and ioctls are dropped >>> from amdgpu_dm in favor of supportin

Re: [PATCH v4 4/4] drm/amd/display: Set FreeSync state using drm VRR properties

On 2018-10-11 12:39 PM, Nicholas Kazlauskas wrote: > Support for AMDGPU specific FreeSync properties and ioctls are dropped > from amdgpu_dm in favor of supporting drm variable refresh rate > properties. > > The drm vrr_capable property is now attached to any DP/HDMI connector. > Its value is

Re: [PATCH v2 0/3] A DRM API for adaptive sync and variable refresh rate support

On 2018-10-03 04:25 AM, Mike Lothian wrote: > Hi > > I'm curious to know whether this will/could work over PRIME > I don't see why this shouldn't work over PRIME as long as the presenting GPU supports the new variable refresh rate API, but I know very little about prime, so maybe someone else

Re: [PATCH v2 0/3] A DRM API for adaptive sync and variable refresh rate support

On 2018-10-03 04:41 AM, Daniel Vetter wrote: > On Tue, Oct 02, 2018 at 10:49:17AM -0400, Harry Wentland wrote: >> >> >> On 2018-10-01 03:15 AM, Daniel Vetter wrote: >>> On Mon, Sep 24, 2018 at 02:15:34PM -0400, Nicholas Kazlauskas wrote: >>>> These pa

Re: [PATCH v2 0/3] A DRM API for adaptive sync and variable refresh rate support

On 2018-10-03 02:35 PM, Manasi Navare wrote: > On Wed, Oct 03, 2018 at 10:41:20AM +0200, Daniel Vetter wrote: >> On Tue, Oct 02, 2018 at 10:49:17AM -0400, Harry Wentland wrote: >>> >>> >>> On 2018-10-01 03:15 AM, Daniel Vetter wrote: >>>> On

Re: [PATCH 20/21] drm/todo: Add some cleanup tasks

On 2018-10-04 04:24 PM, Daniel Vetter wrote: > Motivated by review comments from Ville > > Cc: Ville Syrjälä > Cc: Sean Paul > Signed-off-by: Daniel Vetter Acked-by: Harry Wentland Harry > --- > Documentation/gpu/todo.rst | 10 ++ > 1 file changed, 10 inser

Re: [PATCH 01/21] drm/amdgpu: Remove default best_encoder hook from DC

1a6481 ("drm/amd/display: Use DRM helper for > best_encoder"). > > Cc: Ville Syrjälä > Signed-off-by: Daniel Vetter > Cc: Alex Deucher > Cc: Harry Wentland > Cc: Andrey Grodzovsky > Cc: Tony Cheng > Cc: "Leo (Sunpeng) Li" > Cc: Shirish S

Re: [PATCH v2] drm/amd/display: Use proper enums in process_channel_reply

~ ^~~ >>> >>> The current enum is incorrect, it should be from aux_transaction_reply, >>> so use AUX_TRANSACTION_REPLY_HPD_DISCON. >>> >>> Reported-by: Nick Desaulniers >>> Suggested-by: Nick Desaulniers >>&g

Re: [PATCH v2 0/3] A DRM API for adaptive sync and variable refresh rate support

On 2018-10-01 03:15 AM, Daniel Vetter wrote: > On Mon, Sep 24, 2018 at 02:15:34PM -0400, Nicholas Kazlauskas wrote: >> These patches are part of a proposed new interface for supporting variable >> refresh rate via DRM properties. >> >> === Changes from v1 === >> >> For drm: >> >> * The

Re: [PATCH] drm/amd/display: Change status's type in aux_reply_transaction_data

On 2018-09-24 06:22 PM, Nathan Chancellor wrote: > On Mon, Sep 24, 2018 at 03:07:16PM -0700, Nick Desaulniers wrote: >> On Fri, Sep 21, 2018 at 2:55 PM Nathan Chancellor >> wrote: >>> >>> Clang warns when one enumerated type is implicitly converted to another. >>> >>>

Re: [PATCH v2 1/6] drm/dp_mst: Introduce drm_dp_mst_connector_atomic_check()

function that DRM drivers can call in order to have CRTC enabling > commits fail automatically if the MST port driving the connector no > longer exists. We'll also be able to expand upon this later as well once > we add MST fallback retraining support. > > Changes since v1: >

Re: [PATCH 6/6] drm/amdgpu/dm/mst: Use drm_dp_mst_connector_atomic_check()

only atomic DRM driver without the > ->best_encoder() bug is amdgpu. Congrats AMD! > > Signed-off-by: Lyude Paul Reviewed-by: Harry Wentland Harry > --- > .../drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 12 > 1 file changed, 12 insertions(+) > >

Re: [PATCH 1/6] drm/dp_mst: Introduce drm_dp_mst_connector_atomic_check()

gt; Cc: sta...@vger.kernel.org This does seem like a saner way to handle the case when the MST connector is gone. As this doesn't currently seem to affect amdgpu directly and I therefore might miss something I'll leave the RB to someone else, but you have my Acked-by: Harry Wentland Harry > -

Re: [PATCH 2/2] drm/amdgpu: Use per-device driver_features to disable atomic

On 2018-09-13 12:31 PM, Ville Syrjala wrote: > From: Ville Syrjälä > > Disable atomic on a per-device basis instead of for all devices. > Made possible by the new device.driver_features thing. > > Cc: Alex Deucher > Cc: "Christian König" > Cc: "David

Re: EVoC Program

Adding e...@foundation.x.org and Trevor. He or someone else on the evoc list can probably point you in the right direction. Harry On 2018-09-20 03:06 AM, Sidharth Bansal wrote: > Hi > I want to contribute towards XOrg for EVoC. Can anyone guide me? > Thanks > Sidharth Bansal > > >

Re: [PATCH 1/9] drm: Add variable refresh rate properties to DRM connector

On 2018-09-11 01:56 PM, Ville Syrjälä wrote: > On Tue, Sep 11, 2018 at 01:36:01PM -0400, Kazlauskas, Nicholas wrote: >> On 09/11/2018 12:31 PM, Ville Syrjälä wrote: >>> On Tue, Sep 11, 2018 at 07:22:43PM +0300, Ville Syrjälä wrote: On Tue, Sep 11, 2018 at 12:13:25PM -0400, Nicholas Kazlauskas

Re: [PATCH v2 08/23] drm/dsc: Define VESA Display Stream Compression Capabilities

gt; * Define DSC 1.2 parameters (Manasi) > * Use DSC_NUM_BUF_RANGES (Manasi) > * Call it drm_dsc_config (Manasi) > > Cc: dri-devel@lists.freedesktop.org > Cc: Jani Nikula > Cc: Ville Syrjala > Cc: Anusha Srivatsa > Cc: Harry Wentland > Signed-off-by: Manasi

Re: [PATCH v2 10/23] drm/dsc: Add helpers for DSC picture parameter set infoframes

ence to added kernel-docs in Documentation/gpu/drm-kms-helpers.rst > (Daniel Vetter) > > v2: > * Add EXPORT_SYMBOL for the drm functions (Manasi) > > Cc: dri-devel@lists.freedesktop.org > Cc: Jani Nikula > Cc: Ville Syrjala > Cc: Anusha Srivatsa > Cc: Harry Wen

Re: [PATCH v2 07/23] drm/dsc: Define Display Stream Compression PPS infoframe

frame syntax elements are taken from DSC 1.2 specification > from VESA. > > Cc: Gaurav K Singh > Cc: dri-devel@lists.freedesktop.org > Cc: Jani Nikula > Cc: Ville Syrjala > Cc: Anusha Srivatsa > Cc: Harry Wentland > Signed-off-by: Manasi Navare Looks like this

Re: [PATCH (repost) 5/5] drm/amdgpu: add DisplayPort CEC-Tunneling-over-AUX support

gt; drm_kms_helper_hotplug_event(dev); > } > } > + > if ((dc_link->cur_link_settings.lane_count != LANE_COUNT_UNKNOWN) || > - (dc_link->type == dc_connection_mst_branch)) > + (dc_link->type == dc_connection_mst_branch)) { >

Re: [PATCH] drm/amd/display: add missing void parameter to dc_create_transfer_func

On 2018-07-31 06:42 AM, Colin King wrote: > From: Colin Ian King > > Add a missing void parameter to function dc_create_transfer_func, fixes > sparse warning: > > warning: non-ANSI function declaration of function 'dc_create_transfer_func' > > Signed-off-by: Colin Ian K

Re: [PATCH 00/10] Add helper for plane reset

ble a core property and > observe it doesn't have a proper default value. > > Tested with mali-dp the other drivers are just built-tested. > For some reason I lost 02/10 hence I'm replying to the cover letter. Patches 1 & 2 are Reviewed-by: Harry Wentland Harry

Re: 答复: 答复: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

On 2018-07-15 10:36 AM, Alex Deucher wrote: > On Sat, Jul 14, 2018 at 12:31 PM, Takashi Iwai wrote: >> On Sat, 14 Jul 2018 14:03:26 +0200, >> jimqu wrote: >>> >>> >>> >>> 在 2018/7/13 23:07, Takashi Iwai 写道: On Wed, 11 Jul 2018 13:12:01 +0200, Takashi Iwai wrote: > And the forced

Re: [PATCH] drm/amd/display/dc/dce: Fix multiple potential integer overflows

On 2018-07-04 01:54 PM, Gustavo A. R. Silva wrote: > > > On 07/04/2018 12:51 PM, Harry Wentland wrote: > [..] >>>> >>>> @@ -145,8 +145,8 @@ static bool calculate_fb_and_fractional_fb_divider( >>>> * of fractional feedback decimal poi

Re: [PATCH] drm/amd/display: Use 2-factor allocator calls

On 2018-07-04 01:27 PM, Kees Cook wrote: > As already done treewide, switch from open-coded multiplication to > 2-factor allocation helper. > > Signed-off-by: Kees Cook Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/modules/color/color_gamma.c | 8

Re: [PATCH] drm/amd/display/dc/dce: Fix multiple potential integer overflows

calc_pll_cs->fract_fb_divider_precision_factor; > > This should be 5ULL, as the commit log says, otherwise it's still only > 32 bits on 32-bit platforms. > Agreed. Otherwise this looks good. With that fixed this patch is Reviewed-by: Harry Wentland Harry > ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/amd/display: off by one in find_irq_source_info()

r (v2)") > Signed-off-by: Dan Carpenter Reviewed-by: Harry Wentland Harry > > diff --git a/drivers/gpu/drm/amd/display/dc/irq/irq_service.c > b/drivers/gpu/drm/amd/display/dc/irq/irq_service.c > index dcdfa0f01551..604bea01fc13 100644 > --- a/drivers/gpu/drm/amd/disp

Re: [PATCH] drm: Pass crtc to .best_encoder()

On 2018-06-26 11:01 AM, Harry Wentland wrote: > On 2018-06-15 03:52 PM, Ville Syrjala wrote: >> From: Ville Syrjälä >> >> To pick the correct MST encoder i915 wants to know which crtc is going >> to be feeding us. To that end let's pass the crtc to the .best_encoder()

Re: [PATCH] drm: Pass crtc to .best_encoder()

n the amdgpu/radeon drivers. None of > the other drivers have such internal uses. The other callers > (crtc_helper, atomic_helper, fb_helper) will pass in the proper crtc. > but no one besides i915 will currently look at it. > > Cc: Alex Deucher > Cc: "Christian

Re: [PATCH] drm/amd/display: don't initialize result

; initialization. > > Signed-off-by: Stefan Agner Thanks for the patch. Reviewed-by: Harry Wentland Ill merge this today. Harry > --- > drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm

Re: [PATCH] drm/amdgpu: Count disabled CRTCs in commit tail earlier

> > So, we fix this by counting the number of CRTCs this atomic commit disabled > early on in the function before their atomic states have been freed, then use > that count later to do the appropriate number of RPM puts at the end of the > function. > > Fixes: 970

Re: [PATCH 1/2] amdgpu: display: use modern ktime accessors

On 2018-06-18 11:35 AM, Arnd Bergmann wrote: > getrawmonotonic64() is deprecated because of the nonstandard naming. > > The replacement functions ktime_get_raw_ns() also simplifies the callers. > > Signed-off-by: Arnd Bergmann Reviewed-by: Harry Wentland Harry > --- >

Re: [PATCH 2/3] drm: Print bad user modes

On 2018-06-11 03:34 PM, Ville Syrjala wrote: > From: Ville Syrjälä > > Print out the modeline when we reject a bad user mode. Avoids having to > guess why it was rejected. > > Signed-off-by: Ville Syrjälä Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/

Re: [PATCH 1/3] drm/atomic: Improve debug messages

On 2018-06-11 03:34 PM, Ville Syrjala wrote: > From: Ville Syrjälä > > Print the id/name of the object we're dealing with. Makes it easier to > figure out what's going on. Also toss in a few extra debug prints that > might be useful. > > Signed-off-by: Ville Syrjälä

Re: [PATCH] drm/amdgpu: Grab/put runtime PM references in atomic_commit_tail()

is painfully obvious from the fact that we missed that with the DC driver. That said, from a cursory look at runtime_pm.txt, this looks right. Reviewed-by: Harry Wentland I'll pull this in through the amd-stg tree. > --- > As a note, I'm not entirely happy with this fix and I wouldn'

Re: [PATCH v2 0/4] DRM helpers for Display Stream Compression PPS infoframes

l@lists.freedesktop.org > Cc: Jani Nikula <jani.nik...@linux.intel.com> > Cc: Ville Syrjala <ville.syrj...@linux.intel.com> > Cc: Anusha Srivatsa <anusha.sriva...@intel.com> With my comments for patch 2 and 3 addressed patches 1-3 are Reviewed-by: Harry Wentland <har

Re: [PATCH v2 3/4] drm/dsc: Define VESA Display Stream Compression Capabilities

On 2018-05-14 10:05 PM, Manasi Navare wrote: > From: Gaurav K Singh > > This defines all the DSC parameters as per the VESA DSC spec > that will be required for DSC encoder/decoder > > v2: Define this struct in DRM (From Manasi) > * Changed the data types to u8/u16

Re: [PATCH v2 2/4] drm/dsc: Define Display Stream Compression PPS infoframe

On 2018-05-14 10:05 PM, Manasi Navare wrote: > This patch defines a new header file for all the DSC 1.2 structures > and creates a structure for PPS infoframe which will be used to send > picture parameter set secondary data packet for display stream compression. > All the PPS infoframe syntax

Re: [PATCH 1/3] drm/connector: Add generic underscan properties

On 2018-05-07 12:19 PM, Boris Brezillon wrote: > On Mon, 7 May 2018 18:01:44 +0300 > Ville Syrjälä wrote: > >> On Mon, May 07, 2018 at 04:44:32PM +0200, Boris Brezillon wrote: >>> We have 3 drivers defining the "underscan", "underscan hborder" and >>> "underscan

Re: [PATCH] drm/amd/display: clean up assignment of amdgpu_crtc

order violation") > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Looks like i goofed. Thanks for fixing this. Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- > 1 file cha

Re: [REGRESSION] drm/amd/dc: Add dc display driver (v2)

it was found the following commit introduced the bug: > > > commit 4562236b3bc0a28aeb6ee93b2d8a849a4c4e1c7c > Author: Harry Wentland <harry.wentl...@amd.com> > Date:   Tue Sep 12 15:58:20 2017 -0400 > >     drm/amd/dc: Add dc display driver (v2) > > > The regression

Re: [PATCH] drm/amd/display: Remove erroneous if statement in gamma set

619aa9176aeb05ad630013429b4 > Author: Leo (Sunpeng) Li <sunpeng...@amd.com> > Date: Fri Feb 2 10:18:56 2018 -0500 > > drm/amd/display: Hookup color management functions Missing SOB? With that fixed this is Reviewed-by: Harry Wentland <harry.wentl...@amd

Re: RFC for a render API to support adaptive sync and VRR

On 2018-04-24 08:09 AM, Daniel Vetter wrote: > On Mon, Apr 23, 2018 at 02:19:44PM -0700, Manasi Navare wrote: >> On Mon, Apr 23, 2018 at 10:40:06AM -0400, Harry Wentland wrote: >>> On 2018-04-20 04:32 PM, Manasi Navare wrote: >>>> On Wed, Apr 18, 2018 at 09:39:0

Re: [PATCH] drm/admgpu: fix mode_valid's return type

the driver too. > > Signed-off-by: Luc Van Oostenryck <luc.vanoostenr...@gmail.com> amd-gfx mailing list should be sufficient for changes like these. Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c| 8

Re: RFC for a render API to support adaptive sync and VRR

On 2018-04-20 04:32 PM, Manasi Navare wrote: > On Wed, Apr 18, 2018 at 09:39:02AM +0200, Daniel Vetter wrote: >> On Wed, Apr 18, 2018 at 5:58 AM, Keith Packard wrote: >>> Michel Dänzer writes: Time-based presentation seems to be the right approach for

Re: [PATCH] drm/amd/display: Disallow enabling CRTC without primary plane with FB

On 2018-04-19 03:43 AM, Michel Dänzer wrote: > > [ Dropping stable@ (fixes with Cc: stable are picked up for stable > branches once they land in Linus' tree, there's no point sending them to > stable@ during review), adding dri-devel ] > > On 2018-04-18 10:26 PM, Ha

<    3   4   5   6   7   8   9   10   11   >