Clarify the procedure developer must follow to request privileges to
run tests on Freedesktop gitlab CI.
This measure was added to avoid untrusted people to misuse the
infrastructure.
Signed-off-by: Helen Koike
Reviewed-by: David Heidelberg
---
v2:
- fix typo in commit message
Since the kernel doesn't use a bot like Mesa that requires tests to pass
in order to merge the patches, leave it to developers and/or maintainers
to manually retry.
Suggested-by: Rob Clark
Signed-off-by: Helen Koike
Reviewed-by: David Heidelberg
---
v2:
- no changes
---
drivers/gpu/drm/ci
Export the resultant kernel config, making it easier to verify if the
resultant config was correctly generated.
Suggested-by: Rob Clark
Signed-off-by: Helen Koike
Acked-by: Dmitry Baryshkov
Reviewed-by: David Heidelberg
---
v2:
- no changes
---
drivers/gpu/drm/ci/build.sh | 1
developers
from getting their patches merged.
Signed-off-by: Helen Koike
Reviewed-by: David Heidelberg
---
v2:
- add subset-1-gfx tag to LAVA_TAGS
- update commit message
---
drivers/gpu/drm/ci/gitlab-ci.yml | 2 +-
drivers/gpu/drm/ci/test.yml | 23 ++-
2 files changed, 15
Since the script that collected the list of the expectation files was
bogus and placing test to the flakes list incorrectly, restart the
expectation files with the correct script.
This reduces a lot the number of tests in the flakes list.
Signed-off-by: Helen Koike
Reviewed-by: David Heidelberg
was ok.
Uprev IGT to include this modification and include core_getversion test
in all the shards.
Signed-off-by: Helen Koike
Reviewed-by: David Heidelberg
---
v2:
- fixed typo in the commit message
---
drivers/gpu/drm/ci/gitlab-ci.yml | 2 +-
drivers/gpu/drm/ci/igt_runner.sh | 31
with the same name or if they are flakes) and execute:
update-xfails.py
https://gitlab.freedesktop.org/helen.fornazier/linux/-/pipelines/970661
git diff should show you that it updated files in xfails folder.
Signed-off-by: Helen Koike
Tested-by: Vignesh Raman
Reviewed-by: David Heidelberg
---
Hello
amdgpu driver wasn't loading because amdgpu firmware wasn't being
installed in the rootfs due to the wrong DEBIAN_ARCH variable.
rename ARCH to DEBIAN_ARCH also, so we don't have the confusing
DEBIAN_ARCH, KERNEL_ARCH and ARCH.
Signed-off-by: Helen Koike
Reviewed-by: David Heidelberg
---
v2
-by: Helen Koike
[crosvm mesa update]
Co-Developed-by: Vignesh Raman
Signed-off-by: Vignesh Raman
[v1 container build uprev]
Tested-by: Jessica Zhang
Acked-by: Jessica Zhang
Reviewed-by: David Heidelberg
---
v2:
- update to an even newer version of mesa to integrate crosvm uprev
---
drivers/gpu
...@linaro.org/
[PATCH] drm/ci: Enable CONFIG_BACKLIGHT_CLASS_DEVICE
https://patchwork.kernel.org/project/dri-devel/patch/20231002164715.157298-1-robdcl...@gmail.com/
Helen Koike (9):
drm/ci: uprev mesa version: fix container build & crosvm
drm/ci: fix DEBIAN_ARCH and get amdgpu probing
drm/ci:
for testing, before pushing them to the drm/drm
repo. Thus, if the CI run was triggered by merge request, also pick up
the -external fixes basing on the the CI_MERGE target repo / and branch.
Signed-off-by: Dmitry Baryshkov
Acked-by: Helen Koike
Thanks!
---
drivers/gpu/drm/ci/build.sh | 5 +
1
On 19/10/2023 06:46, Maxime Ripard wrote:
Flaky tests can be very difficult to reproduce after the facts, which
will make it even harder to ever fix.
Let's document the metadata we agreed on to provide more context to
anyone trying to address these fixes.
Link:
On 19/10/2023 13:42, Helen Koike wrote:
On 19/10/2023 04:06, Vignesh Raman wrote:
Update msm-apq8016-fails, mediatek-mt8173-fails and
virtio_gpu-none-fails to include the tests which fail.
Update mediatek-mt8173-flakes to include the tests which flakes.
Update virtio_gpu-none-skips
On 19/10/2023 04:06, Vignesh Raman wrote:
Update msm-apq8016-fails, mediatek-mt8173-fails and
virtio_gpu-none-fails to include the tests which fail.
Update mediatek-mt8173-flakes to include the tests which flakes.
Update virtio_gpu-none-skips to include the tests that need to be skipped.
On 17/10/2023 06:28, André Almeida wrote:
Hi,
This work from me and Simon adds support for DRM_MODE_PAGE_FLIP_ASYNC through
the atomic API. This feature is already available via the legacy API. The use
case is to be able to present a new frame immediately (or as soon as
possible), even if
cc +guilherme
On 06/10/2023 14:32, Rob Clark wrote:
From: Rob Clark
ssh logging is the default for mesa, as it is generally more reliable.
But if there are kernel issues, especially at boot, UART logging is
infinitely more useful.
Signed-off-by: Rob Clark
---
On 20/09/2023 20:22, Helen Koike wrote:
On 20/09/2023 16:44, Rob Clark wrote:
On Wed, Sep 20, 2023 at 11:53 AM Helen Koike
wrote:
Hi Rob,
Thanks for the patch.
On 20/09/2023 15:10, Rob Clark wrote:
On Wed, Sep 20, 2023 at 11:06 AM Rob Clark wrote:
From: Rob Clark
There have been
On 27/09/2023 17:52, Jessica Zhang wrote:
On 9/22/2023 10:12 AM, Helen Koike wrote:
Add job that runs igt on top of vkms.
Signed-off-by: Helen Koike
Tested-by: Jessica Zhang
Acked-by: Jessica Zhang
Thanks for the tests and reviews.
For some reason this is broken with the latest
Dear maintainers,
Do not pick this patch, I re-sent it as part of the series
[PATCH 0/9] drm/ci: fixes and improvements
https://lists.freedesktop.org/archives/dri-devel/2023-October/425909.html
Thanks
Regards,
Helen
On 22/09/2023 14:12, Helen Koike wrote:
When building containers
/20231008132320.762542-2-dmitry.barysh...@linaro.org/
[PATCH] drm/ci: Enable CONFIG_BACKLIGHT_CLASS_DEVICE
https://patchwork.kernel.org/project/dri-devel/patch/20231002164715.157298-1-robdcl...@gmail.com/
Helen Koike (9):
drm/ci: uprev mesa version - fix container build
drm/ci: fix DEBIAN_ARCH and get amdgpu
Since the kernel doesn't use a bot like Mesa that requires tests to pass
in order to merge the patches, leave it to developers and/or maintainers
to manually retry.
Suggested-by: Rob Clark
Signed-off-by: Helen Koike
---
drivers/gpu/drm/ci/gitlab-ci.yml | 14 --
1 file changed, 14
Clarify the procedure developer must follow to request privileges to
run tests on Freedesktop gitlab CI.
This measure was added to avoid untrusted people to misuse the
infrastructure.
Signed-off-by: Helen Koike
---
Documentation/gpu/automated_testing.rst | 7 +--
1 file changed, 5
Export the resultant kernel config, making it easier to verify if the
resultant config was correctly generated.
Suggested-by: Rob Clark
Signed-off-by: Helen Koike
---
drivers/gpu/drm/ci/build.sh | 1 +
drivers/gpu/drm/ci/image-tags.yml | 2 +-
2 files changed, 2 insertions(+), 1 deletion
Adjust the number of shards to the number of available devices in the
farm.
Signed-off-by: Helen Koike
---
drivers/gpu/drm/ci/test.yml | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/ci/test.yml b/drivers/gpu/drm/ci/test.yml
index 3479d2a0108d
Since the script that collected the list of the expectation files was
bogus and placing test to the flakes list incorrectly, restart the
expectation files with the correct script.
This reduces a lot the number of tests in the flakes list.
Signed-off-by: Helen Koike
---
.../gpu/drm/ci/xfails
amdgpu driver wasn't loading because amdgpu firmware wasn't being
installed in the rootfs due to the wrong DEBIAN_ARCH variable.
rename ARCH to DEBIAN_ARCH also, so we don't have the confusing
DEBIAN_ARCH, KERNEL_ARCH and ARCH.
Signed-off-by: Helen Koike
---
drivers/gpu/drm/ci/build.sh
was ok.
Uprev IGT to include this modification and include core_getversion test
in all the shards.
Signed-off-by: Helen Koike
---
drivers/gpu/drm/ci/gitlab-ci.yml | 2 +-
drivers/gpu/drm/ci/igt_runner.sh | 31 ---
drivers/gpu/drm/ci/image-tags.yml | 2 +-
3 files
with the same name or if they are flakes) and execute:
update-xfails.py
https://gitlab.freedesktop.org/helen.fornazier/linux/-/pipelines/970661
git diff should show you that it updated files in xfails folder.
Signed-off-by: Helen Koike
---
Hello,
This script is being very handy for me, so I suppose
v0.38.13` cannot be built because it requires rustc 1.63 or
newer, while the currently active rustc version is 1.60.0
A patch to Mesa was recently added fixing this error, so update it.
Signed-off-by: Helen Koike
---
Derived work from RFC:
https://patchwork.kernel.org/project/dri-devel/patch
On 08/10/2023 10:23, Dmitry Baryshkov wrote:
Enable CONFIG_MSM_MMCC_8996, the multimedia clock controller on Qualcomm
MSM8996 to prevent the the board from hitting the probe deferral
timeouts in CI run.
Signed-off-by: Dmitry Baryshkov
Tested-by: Helen Koike
Pipeline:
https
On 08/10/2023 16:59, Dmitry Baryshkov wrote:
On Sun, 8 Oct 2023 at 20:56, Rob Clark wrote:
From: Rob Clark
i-g-t expects the CRC to reflect any applied CTM. But the layer mixer
source is upstream of the DSPP, so it is before the CTM is applied.
Switch the default source to 'encoder'
On 02/10/2023 13:47, Rob Clark wrote:
From: Rob Clark
Dependency for CONFIG_DRM_PANEL_EDP. Missing this was causing the drm
driver to not probe on devices that use panel-edp.
Signed-off-by: Rob Clark
Thank you a lot!
Now sc7180, apq8096 and sdm845 are probing!
Tested-by: Helen Koike
Hi Sergi,
Thanks for your comments.
On 27/09/2023 05:58, Sergi Blanch Torne wrote:
Hi Helen,
On Mon, 2023-09-25 at 16:55 -0300, Helen Koike wrote:
Hello,
This script is being very handy for me, so I suppose it could be
handy
to others, since I'm publishing it in the xfails folder.
Let
On 26/09/2023 11:15, Carlos Eduardo Gallo Filho wrote:
There's duplicated functions on drm that do the same job of calculating
the size of planes from a drm_format_info and the size of its first
plane. So this patchset throw away the more specific version intended
to be used from a given
with the same name or if they are flakes) and execute:
update-xfails.py
https://gitlab.freedesktop.org/helen.fornazier/linux/-/pipelines/970661
git diff should show you that it updated files in xfails folder.
Signed-off-by: Helen Koike
---
Hello,
This script is being very handy for me, so I suppose
Add job that runs igt on top of vkms.
Signed-off-by: Helen Koike
---
See pipeline:
https://gitlab.freedesktop.org/helen.fornazier/linux/-/pipelines/990494
v2:
- do not mv modules to /lib/modules in the job definition, leave it to
crosvm-runner.sh
---
MAINTAINERS
v0.38.13` cannot be built because it requires rustc 1.63 or
newer, while the currently active rustc version is 1.60.0
A patch to Mesa was recently added fixing this error, so update it.
Signed-off-by: Helen Koike
---
v2:
- point to upstream mesa/mesa (solved the TODO and removed RFC tag
and removed RFC tag)
- vkms jov: do not mv modules to /lib/modules in the job definition, leave it to
crosvm-runner.sh
Helen Koike (2):
drm/ci: uprev mesa version - fix container build
drm/ci: add tests on vkms
MAINTAINERS | 1 +
drivers/gpu/drm/ci/build.sh
into the *-flakes file and tests
that are failing into the *-fails file.
Signed-off-by: Helen Koike
Signed-off-by: Vignesh Raman
---
v2:
- No changes
v3:
- No changes
v4:
- No changes
---
.../gpu/drm/ci/xfails/amdgpu-stoney-fails.txt| 1 -
drivers/gpu/drm/ci/xfails/i915-cml-fails.txt
On 14/09/2023 05:54, Vignesh Raman wrote:
The patch series contains improvements, enabling new ci jobs which
enables testing for Mediatek MT8173, Qualcomm APQ 8016 and VirtIO GPU,
fixing issues with the ci jobs and updating the expectation files.
This series is intended for drm branch
On 21/09/2023 15:12, Helen Koike wrote:
Hi,
On 19/09/2023 10:12, Maxime Ripard wrote:
We've had a number of times when a patch slipped through and we couldn't
pick them up either because our MAINTAINERS entry only covers the
framework and thus we weren't Cc'd.
Let's take another approach
Hi,
On 19/09/2023 10:12, Maxime Ripard wrote:
We've had a number of times when a patch slipped through and we couldn't
pick them up either because our MAINTAINERS entry only covers the
framework and thus we weren't Cc'd.
Let's take another approach where we match everything, and remove all
the
On 20/09/2023 16:44, Rob Clark wrote:
On Wed, Sep 20, 2023 at 11:53 AM Helen Koike wrote:
Hi Rob,
Thanks for the patch.
On 20/09/2023 15:10, Rob Clark wrote:
On Wed, Sep 20, 2023 at 11:06 AM Rob Clark wrote:
From: Rob Clark
There have been a few igt test fixes compared
Hi Rob,
Thanks for the patch.
On 20/09/2023 15:10, Rob Clark wrote:
On Wed, Sep 20, 2023 at 11:06 AM Rob Clark wrote:
From: Rob Clark
There have been a few igt test fixes compared to the commit that we were
currently using. Pull in a newer igt and update expectations.
Signed-off-by: Rob
Hello!
Thanks for the patch.
On 29/08/2023 02:30, Brandon Pollack wrote:
This change adds the ability to read or write a "1" or a "0" to the
newly added "connected" attribute of a connector in the vkms entry in
configfs.
A write will trigger a call to drm_kms_helper_hotplug_event, causing a
Add job that runs igt on top of vkms.
Signed-off-by: Helen Koike
---
See pipeline:
https://gitlab.freedesktop.org/helen.fornazier/linux/-/pipelines/990494
---
MAINTAINERS | 1 +
drivers/gpu/drm/ci/build.sh | 1 -
drivers/gpu/drm/ci/gitlab
v0.38.13` cannot be built because it requires rustc 1.63 or
newer, while the currently active rustc version is 1.60.0
A patch to Mesa was recently added fixing this error, so update it.
Signed-off-by: Helen Koike
---
I'm submitting this to make it available for other to run and test. I'd
like
list that were found during the tests.
Helen Koike (2):
drm/ci: uprev mesa version - fix container build
drm: ci: add tests on vkms
MAINTAINERS | 1 +
drivers/gpu/drm/ci/build.sh | 1 -
drivers/gpu/drm/ci/gitlab-ci.yml | 20
DRM CI keeps track of which tests are failing, flaking or being skipped
by the ci in the expectations files. Add entries for those files to the
corresponding driver maintainer, so they can be notified when they
change.
Signed-off-by: Helen Koike
---
For reference:
https://www.mail-archive.com
On 14/09/2023 05:12, Daniel Vetter wrote:
On Thu, Sep 14, 2023 at 03:33:41PM +0900, Tetsuo Handa wrote:
On 2023/09/14 6:08, Thomas Gleixner wrote:
Maybe the VKMS people need to understand locking in the first place. The
first thing I saw in this code is:
static enum hrtimer_restart
On 15/09/2023 12:08, Daniel Stone wrote:
Hey,
On Thu, 14 Sept 2023 at 10:54, Maxime Ripard wrote:
On Tue, Sep 12, 2023 at 02:16:41PM +0100, Daniel Stone wrote:
Hopefully less mangled formatting this time: turns out Thunderbird +
plain text is utterly unreadable, so that's one less MUA
On 08/09/2023 12:22, Vignesh Raman wrote:
Instead of modifying files in git to enable/disable
configs, use scripts/config on the .config file which
will be used for building the kernel.
Suggested-by: Jani Nikula
Signed-off-by: Vignesh Raman
Acked-by: Helen Koike
---
v2:
- Added
and remove this rule.
mediatek:mt8173:
TODO: current issue: device is hanging. Fix and remove this rule.
virtio_gpu:none:
TODO: current issue: malloc(): corrupted top size. Fix and remove this rule.
Signed-off-by: Vignesh Raman
Acked-by: Helen Koike
---
v2:
- Reworded the commit
an initrd, not
sure if it solves for kernel-ci.
Suggested-by: AngeloGioacchino Del Regno
Signed-off-by: Vignesh Raman
In any case:
Acked-by: Helen Koike
---
v3:
- New patch in the series to enable CONFIG_REGULATOR_DA9211 in defconfig
---
arch/arm64/configs/defconfig | 1 +
1 file
On 08/09/2023 12:22, Vignesh Raman wrote:
Enable CONFIG_REGULATOR_DA9211=y to fix mt8173 boot issue.
Signed-off-by: Vignesh Raman
Acked-by: Helen Koike
---
v2:
- No changes
v3:
- Remove CONFIG_RTC_DRV_MT6397=y as it is already enabled in defconfig
---
drivers/gpu/drm/ci
Acked-by: Helen Koike
---
v2:
- No changes
v3:
- No changes
---
drivers/gpu/drm/ci/test.yml | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/ci/test.yml b/drivers/gpu/drm/ci/test.yml
index 6473cddaa7a9..d85add39f425 100644
--- a/drivers/gpu/drm/ci
and use fdtoverlay
command to merge base device tree with an overlay which contains the
fix for USB controllers to work in host mode. [suggested by Maxime Ripard]
Suggested-by: Maxime Ripard
Signed-off-by: Vignesh Raman
Acked-by: Helen Koike
---
v2:
- Use fdtoverlay command to merge overlay
that sets the dr_mode to host, allowing
the USB controllers to work in host mode. This dtso file will be used
in drm-ci, mesa-ci.
Overlay DT file uses the sugar syntax [suggested by Dmitry Baryshkov and Maxime
Ripard]
Suggested-by: Dmitry Baryshkov
Suggested-by: Maxime Ripard
Signed-off-by: Helen Koike
On 08/09/2023 12:22, Vignesh Raman wrote:
/sys/kernel/debug/dri/*/state exist for every atomic KMS driver.
We do not test non-atomic drivers, so remove the todo.
Signed-off-by: Vignesh Raman
Acked-by: Helen Koike
---
v2:
- No changes
v3:
- No changes
---
drivers/gpu/drm
Hi Vinayak,
Thanks for you patch
On 06/09/2023 13:51, Vinayak Hegde wrote:
I encountered a warning during kernel documentation compilation
Usually we write the commit message in imperative mood, please check:
Hi!
On 04/09/2023 13:15, Vignesh Raman wrote:
Force db410c to host mode to fix network issue which results in failure
to mount root fs via NFS.
See
https://gitlab.freedesktop.org/gfx-ci/linux/-/commit/cb72a629b8c15c80a54dda510743cefd1c4b65b8
Use fdtoverlay command to merge base device tree
Hi André,
Thanks for your patches.
On 30/08/2023 19:08, André Almeida wrote:
As suggested by Christian at [0], this patchset merges all debug modules
parameters and creates a new one for disabling soft recovery:
Maybe we can overload the amdgpu_gpu_recovery module option with this.
Or even
On 30/08/2023 11:57, Maxime Ripard wrote:
On Wed, Aug 30, 2023 at 10:24:49AM -0300, Helen Koike wrote:
Hi all,
Thanks for you comments.
On 30/08/2023 08:37, Maxime Ripard wrote:
On Wed, Aug 30, 2023 at 01:58:31PM +0300, Jani Nikula wrote:
On Wed, 30 Aug 2023, Maxime Ripard wrote
the driver on several
generations of the hardware.
Signed-off-by: Tomeu Vizoso
Signed-off-by: Helen Koike
Acked-by: Daniel Stone
Acked-by: Rob Clark
Tested-by: Rob Clark
Ok I pushed this into a topic/drm-ci branch in drm.git and asked sfr to
include that branch in linux-next.
But also I'd
On 29/08/2023 14:57, Daniel Vetter wrote:
On Thu, Aug 24, 2023 at 01:42:30PM -0300, Helen Koike wrote:
Fix the following warning:
Documentation/gpu/automated_testing.rst:55: WARNING: Inline emphasis
start-string without end-string.
Reported-by: Stephen Rothwell
Signed-off-by: Helen Koike
On 28/08/2023 17:14, Yadav, Arvind wrote:
On 8/28/2023 9:13 PM, Helen Mae Koike Fornazier wrote:
On Monday, August 28, 2023 09:26 -03, Arvind Yadav
wrote:
AMDGPU SOCs supports dynamic workload based power profiles, which can
provide fine-tuned performance for a particular type of
Fix the following warning:
Documentation/gpu/automated_testing.rst:55: WARNING: Inline emphasis
start-string without end-string.
Reported-by: Stephen Rothwell
Signed-off-by: Helen Koike
---
Patch for topic/drm-ci
V2:
- Fix typo s/scape/escape
---
Documentation/gpu/automated_testing.rst
Fix the following warning:
Documentation/gpu/automated_testing.rst:55: WARNING: Inline emphasis
start-string without end-string.
Reported-by: Stephen Rothwell
Signed-off-by: Helen Koike
---
Patch for topic/drm-ci
---
Documentation/gpu/automated_testing.rst | 2 +-
1 file changed, 1
and tested by others.
Signed-off-by: Helen Koike
Tomeu Vizoso (1):
drm: Add initial ci/ subdirectory
Documentation/gpu/automated_testing.rst| 144 +
Documentation/gpu/index.rst|1
and tested by others.
Signed-off-by: Helen Koike
Tomeu Vizoso (1):
drm: Add initial ci/ subdirectory
Documentation/gpu/automated_testing.rst| 144 +
Documentation/gpu/index.rst|1
hy_config = *config;
+ dsi->lane_mbps = div_u64(config->hs_clk_rate, 1000 * 1000 * 1);
+
+ return 0;
+}
+
+static int dw_mipi_dsi_dphy_power_on(struct phy *phy)
+{
+ struct dw_mipi_dsi_rockchip *dsi = phy_get_drvdata(phy);
+ int i, ret;
It seems "i" coul
From: Gustavo Padovan
Add implementation for async plane update callbacks
Signed-off-by: Gustavo Padovan
Signed-off-by: Enric Balletbo i Serra
Signed-off-by: Tina Zhang
Signed-off-by: Helen Koike
Tested-by: Tina Zhang
---
Hi,
I ran the following tests and no regressions were found
From: Gustavo Padovan
Replace the legacy cursor implementation by the async callbacks
Signed-off-by: Gustavo Padovan
Signed-off-by: Enric Balletbo i Serra
Signed-off-by: Helen Koike
---
Changes in v11: None
Changes in v10: None
Changes in v9:
- v8: https://patchwork.kernel.org/patch
From: Gustavo Padovan
Replace the legacy cursor implementation by the async callbacks
Signed-off-by: Gustavo Padovan
Signed-off-by: Enric Balletbo i Serra
Signed-off-by: Helen Koike
---
Changes in v10: None
Changes in v9:
- v8: https://patchwork.kernel.org/patch/10843397/
- rebased
From: Gustavo Padovan
Add implementation for async plane update callbacks
Signed-off-by: Gustavo Padovan
Signed-off-by: Enric Balletbo i Serra
Signed-off-by: Tina Zhang
Signed-off-by: Helen Koike
Tested-by: Tina Zhang
---
Hi,
This is v10, I just fixed the order in how the commit_ready
From: Gustavo Padovan
Replace the legacy cursor implementation by the async callbacks
Signed-off-by: Gustavo Padovan
Signed-off-by: Enric Balletbo i Serra
Signed-off-by: Helen Koike
---
Changes in v9:
- v8: https://patchwork.kernel.org/patch/10843397/
- rebased and fixed conflicts on top
From: Gustavo Padovan
Add implementation for async plane update callbacks
Signed-off-by: Gustavo Padovan
Signed-off-by: Enric Balletbo i Serra
Signed-off-by: Tina Zhang
Signed-off-by: Helen Koike
Tested-by: Tina Zhang
---
Hi,
I tested this patch set with igt (ksm_cursor_legacy
Hi,
Correcting the tag, just for the record, is v5 of the patch.
On 6/10/19 10:36 AM, Helen Koike wrote:
> commit 89a4aac0ab0e6f5eea10d7bf4869dd15c3de2cd4 upstream.
>
> In the case of a normal sync update, the preparation of framebuffers (be
> it calling drm_atomic_helper_pr
On 6/10/19 10:18 AM, Helen Koike wrote:
> commit c16b85559dcfb5a348cc085a7b4c75ed49b05e2c upstream.
>
> Async update callbacks are expected to set the old_fb in the new_state
> so prepare/cleanup framebuffers are balanced.
>
> Calling drm_atomic_set_fb_for_plane() (whic
c plane updates")
Suggested-by: Boris Brezillon
Signed-off-by: Helen Koike
Reviewed-by: Boris Brezillon
Reviewed-by: Nicholas Kazlauskas
Signed-off-by: Boris Brezillon
Link:
https://patchwork.freedesktop.org/patch/msgid/20190603165610.24614-6-helen.ko...@collabora.com
---
Hi,
This p
taken care by
drm_mode_cursor_universal() when calling drm_atomic_helper_update_plane().
Cc: # v4.19+
Fixes: 539c320bfa97 ("drm/vc4: update cursors asynchronously through atomic")
Suggested-by: Boris Brezillon
Signed-off-by: Helen Koike
Reviewed-by: Boris Brezillon
Signed-off
On 6/3/19 1:56 PM, Helen Koike wrote:
> Async update callbacks are expected to set the old_fb in the new_state
> so prepare/cleanup framebuffers are balanced.
>
> Calling drm_atomic_set_fb_for_plane() (which gets a reference of the new
> fb and put the old fb) is not required
On 6/3/19 1:56 PM, Helen Koike wrote:
> In the case of async update, modifications are done in place, i.e. in the
> current plane state, so the new_state is prepared and the new_state is
> cleaned up (instead of the old_state, unlike what happens in a
> normal sync update).
Async update callbacks are expected to set the old_fb in the new_state
so prepare/cleanup framebuffers are balanced.
Cc: # v4.14+
Fixes: 224a4c970987 ("drm/msm: update cursors asynchronously through atomic")
Suggested-by: Boris Brezillon
Signed-off-by: Helen Koike
Acked-by:
drm_atomic_helper_update_plane().
Cc: # v4.19+
Fixes: 539c320bfa97 ("drm/vc4: update cursors asynchronously through atomic")
Suggested-by: Boris Brezillon
Signed-off-by: Helen Koike
Reviewed-by: Boris Brezillon
---
Hello,
I tested on a Raspberry Pi model B rev2 with igt plane_cur
drm_atomic_helper_update_plane().
Suggested-by: Boris Brezillon
Signed-off-by: Helen Koike
Reviewed-by: Nicholas Kazlauskas
---
Changes in v4: None
Changes in v3: None
Changes in v2:
- added reviewed-by tag
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +--
1 file changed, 1 insertion
ldfb = fb1, newfb = fb2, prepare fb2, cleanup fb1
- Non-async commit, oldfb = fb2, newfb = fb1, prepare fb1, cleanup fb2
Where calls to prepare/cleanup are balanced.
Cc: # v4.14+
Fixes: 25dc194b34dd ("drm: Block fb changes for async plane updates")
Suggested-by: Boris Brezillon
Signed
- Add TODO in drm_atomic_helper_async_commit()
Changes in v2:
- added reviewed-by tag
- update CC stable and Fixes tag
- Added reviewed-by tag
- updated CC stable and Fixes tag
- Change the order of the patch in the series, add this as the last one.
- Add documentation
- s/ballanced/balanced
Helen
t has no effect and
trows a WARN_ON().
Calling drm_atomic_set_fb_for_plane() (which get a referent of the new
fb and pus the old fb) is not required, as it is taken care by
drm_mode_cursor_universal() when calling
drm_atomic_helper_update_plane().
Signed-off-by: Helen Koike
---
Hello,
I tested o
On 5/7/19 5:18 PM, Sean Paul wrote:
> On Wed, Mar 13, 2019 at 09:20:26PM -0300, Helen Koike wrote:
>> In the case of a normal sync update, the preparation of framebuffers (be
>> it calling drm_atomic_helper_prepare_planes() or doing setups with
>> drm_framebuffer
Hello,
On 3/13/19 9:20 PM, Helen Koike wrote:
> Async update callbacks are expected to set the old_fb in the new_state
> so prepare/cleanup framebuffers are balanced.
>
> Cc: # v4.14+
> Fixes: 224a4c970987 ("drm/msm: update cursors asynchronously through atomic")
> S
Hi Boris,
On 4/12/19 10:49 AM, Boris Brezillon wrote:
> Hi Helen,
>
> On Fri, 12 Apr 2019 09:58:25 -0300
> Helen Koike wrote:
>
>> Asynchronous update is the ability change the hw state at any time, not
>> only during vblank.
>>
>> Amend mode
On 4/12/19 9:58 AM, Helen Koike wrote:
> Add atomic_async_{check,update} hooks in drm_plane_helper_funcs.
> These hooks are called when userspace requests asyncronous page flip in
> the atomic api through the flag DRM_MODE_PAGE_FLIP_ASYNC.
>
> Update those hooks in the drivers
add a brief description of the flags used in an atomic commit
Signed-off-by: Helen Koike
---
Changes in v3: None
Changes in v2: None
Changes in v1: None
include/uapi/drm/drm_mode.h | 18 +-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/include/uapi/drm
ing commit to amend
Changes in v1:
- https://patchwork.freedesktop.org/patch/243088/
- Only enable it if userspace requests it.
- Only allow async update for cursor type planes.
- Rename ASYNC_UPDATE for ATOMIC_AMEND.
Helen Koike (4):
drm/uapi: add documentation for atomic flags
drm/atomic: ren
Padovan
Signed-off-by: Enric Balletbo i Serra
[updated for upstream]
Signed-off-by: Helen Koike
---
Hi,
This is the third attempt to introduce the new ATOMIC_AMEND flag for atomic
operations, see the commit message for a more detailed description.
I am sending this patch in the series as an RFC as I
the flag in the normal path, and rockchip who
doesn't support async page flip.
Signed-off-by: Helen Koike
---
Hi,
This patch is an attempt to expose the implementation that already exist
for true async page flips updates through atomic api when the
DRM_MODE_PAGE_FLIP_ASYNC is used.
In this commit I'm
.
_plane_helper_funcs.atomic_async_{update,check}() was being used by
drivers to implement amend and not async. So rename them to amend.
Also improve docs explaining the difference.
If asynchronous is required, normal page flip can be performed using
DRM_MODE_PAGE_FLIP_ASYNC flag.
Signed-off-by: Helen Koike
Hi Rob,
On 3/27/19 11:52 AM, Rob Clark wrote:
> On Wed, Mar 13, 2019 at 8:21 PM Helen Koike wrote:
>>
>> Async update callbacks are expected to set the old_fb in the new_state
>> so prepare/cleanup framebuffers are balanced.
>>
>> Cc: # v4.14+
>> Fixes:
On 3/15/19 8:29 AM, Michel Dänzer wrote:
> On 2019-03-15 11:25 a.m., Boris Brezillon wrote:
>> On Fri, 15 Mar 2019 11:11:36 +0100
>> Michel Dänzer wrote:
>>
>>> On 2019-03-14 6:51 p.m., Helen Koike wrote:
>>>> On 3/14/19 6:15 AM, Michel Dänzer wrote:
101 - 200 of 241 matches
Mail list logo
