On Fri, Feb 26, 2021 at 12:08 AM James Park wrote:
>
> On Thu, Feb 4, 2021 at 1:07 PM Emil Velikov wrote:
> >
> > Do send a patch, unless someone shouts against it, I'll be happy to
> > push it and churn the whole copy to drm/mesa game.
> >
> > Thanks
>
On Thu, Feb 4, 2021 at 1:07 PM Emil Velikov wrote:
>
> Do send a patch, unless someone shouts against it, I'll be happy to
> push it and churn the whole copy to drm/mesa game.
>
> Thanks
> Emil
Hi Emil,
Were you still planning on pushing the patch? I sent a v2 on Feb 8.
Thanks,
James
Use DRM_FOURCC_STANDALONE to include drm_fourcc.h without drm.h.
Copy type definitions from drm.h to drm_fourcc.h, and wrap with
DRM_BASIC_TYPED_DEFINED to avoid redundant inclusion.
This will allow code to avoid unnecessary definitions.
Signed-off-by: James Park
Acked-by: Simon Ser
---
Add
On Thu, Feb 4, 2021 at 6:55 PM James Park wrote:
>
> Use DRM_FOURCC_STANDALONE to include drm_fourcc.h without drm.h.
>
> Copy type definitions from drm.h to drm_fourcc.h, and wrap with
> DRM_BASIC_TYPED_DEFINED to avoid redundant inclusion.
>
> This will allow code
Use DRM_FOURCC_STANDALONE to include drm_fourcc.h without drm.h.
Copy type definitions from drm.h to drm_fourcc.h, and wrap with
DRM_BASIC_TYPED_DEFINED to avoid redundant inclusion.
This will allow code to avoid unnecessary definitions.
Signed-off-by: James Park
---
include/uapi/drm/drm.h
On Thu, Feb 4, 2021 at 1:07 PM Emil Velikov wrote:
>
> On Thu, 4 Feb 2021 at 18:17, James Park wrote:
> >
> > On Thu, Feb 4, 2021 at 9:37 AM James Park
> > wrote:
> > >
> > > On Thu, Feb 4, 2021 at 3:37 AM Emil Velikov
> > > wrote:
> &g
On Thu, Feb 4, 2021 at 9:37 AM James Park wrote:
>
> On Thu, Feb 4, 2021 at 3:37 AM Emil Velikov wrote:
> >
> > Currently, the drm_fourcc.h header depends on drm.h for __u32 and __u64.
> > At the same time drm.h pulls a lot of unneeded symbols.
> >
> > Add ne
gt;
> v2:
> - Add corner-case handling, based on popular demand.
>
> Cc: James Park
> Cc: Pekka Paalanen
> Cc: Simon Ser
> Signed-off-by: Emil Velikov
> ---
> include/uapi/drm/drm.h| 10 ++
> include/uapi/drm/drm_fourcc.h | 29 +
On Wed, Feb 3, 2021 at 8:24 PM James Park wrote:
>
> Apologies for anything I've said so far that has been harsh. I'd like
> this discussion to be civil.
>
> I'm not sure if Simon is still on board with a patch given his thumbs
> up to Erik's comment on the Mesa merge request
Apologies for anything I've said so far that has been harsh. I'd like
this discussion to be civil.
I'm not sure if Simon is still on board with a patch given his thumbs
up to Erik's comment on the Mesa merge request (which I responded to),
but I would also like to know why adding another header
symbols.
>
> When used on linux - this is a trivial but only when building in strict c99
> mode. One is welcome to ignore the warning, silence it or use c11. If neither
> of the three is an option, then do _not_ set the new guard.
>
> Cc: James Park
> Cc: Pekka Paalanen
appreciate the feedback though.
- James
On Tue, Feb 2, 2021 at 9:28 AM Emil Velikov
wrote:
> Hi James,
>
> On Tue, 2 Feb 2021 at 08:27, James Park
> wrote:
> >
> > Hello,
> >
> > Is there something I can do to help move this patch along?
> >
> > Tha
On Tue, Feb 2, 2021 at 4:57 PM Emil Velikov
wrote:
> On Tue, 2 Feb 2021 at 23:25, James Park
> wrote:
> >
> > On Tue, Feb 2, 2021 at 2:47 PM Emil Velikov
> wrote:
> > >
> > > Currently, the drm_fourcc.h header depends on drm.h for __u32 and
> __u64
Hello,
Is there something I can do to help move this patch along?
Thanks,
James Park
On Thu, Dec 10, 2020 at 1:13 AM James Park wrote:
> Create drm_basic_types.h to define types previously defined by drm.h.
>
> Use DRM_FOURCC_STANDALONE to include drm_fourcc.h with
Create drm_basic_types.h to define types previously defined by drm.h.
Use DRM_FOURCC_STANDALONE to include drm_fourcc.h without drm.h.
This will allow Mesa to port code to Windows more easily.
Signed-off-by: James Park
Acked-by: Simon Ser
Reviewed-by: Pekka Paalanen
---
include/uapi/drm
Create drm_basic_types.h to define types previously defined by drm.h.
Use DRM_FOURCC_STANDALONE to include drm_fourcc.h without drm.h.
This will allow Mesa to port code to Windows more easily.
Signed-off-by: James Park
Acked-by: Simon Ser
Reviewed-by: Pekka Paalanen
James Park (1):
drm
Create drm_basic_types.h to define types previously defined by drm.h.
Use DRM_FOURCC_STANDALONE to include drm_fourcc.h without drm.h.
This will allow Mesa to port code to Windows more easily.
Signed-off-by: James Park
Acked-by: Simon Ser
---
include/uapi/drm/drm.h | 12
Create drm_basic_types.h to define types previously defined by drm.h.
Use DRM_FOURCC_STANDALONE to include drm_fourcc.h without drm.h.
This will allow Mesa to port code to Windows more easily.
Signed-off-by: James Park
Acked-by: Simon Ser
James Park (1):
drm: drm_basic_types.h
This was the message from kernel test robot.
>> usr/include/linux/kfd_ioctl.h:37: found __[us]{8,16,32,64} type without
#include
On Tue, Dec 8, 2020 at 4:31 AM Simon Ser wrote:
> May I ask what exactly fails when you drop #include
> from drm.h?
>
n Mon, 07 Dec 2020 10:53:49 +
> Simon Ser wrote:
>
> > On Monday, December 7th, 2020 at 11:49 AM, James Park <
> james.p...@lagfreegames.com> wrote:
> >
> > > That would work, but that's kind of an annoying requirement. I would
> > > prefer the
Create drm_basic_types.h to define types previously defined by drm.h.
Use DRM_FOURCC_STANDALONE to include drm_fourcc.h without drm.h.
This will allow Mesa to port code to Windows more easily.
Signed-off-by: James Park
James Park (1):
drm: drm_basic_types.h, DRM_FOURCC_STANDALONE
include
Create drm_basic_types.h to define types previously defined by drm.h.
Use DRM_FOURCC_STANDALONE to include drm_fourcc.h without drm.h.
This will allow Mesa to port code to Windows more easily.
Signed-off-by: James Park
---
include/uapi/drm/drm.h | 12 ++---
include/uapi/drm
gt; On Monday, December 7th, 2020 at 11:49 AM, James Park <
> james.p...@lagfreegames.com> wrote:
>
> > That would work, but that's kind of an annoying requirement. I would
> > prefer the header to be self-sufficient.
>
> I don't want to make it more confusing than b
Ser wrote:
> On Monday, December 7th, 2020 at 10:55 AM, James Park <
> james.p...@lagfreegames.com> wrote:
>
> > I'd noticed the #if could be combined, but they weren't in drm,h when
> > they could have been, so I didn't want to depart from the existing
> > pattern.
with the
other DRM_FOURCC_STANDALONE solution that pulls the basic types into a
common header.
Thanks,
James
On Mon, Dec 7, 2020 at 1:49 AM Simon Ser wrote:
> On Monday, December 7th, 2020 at 9:57 AM, James Park <
> james.p...@lagfreegames.com> wrote:
>
> > I could adjust t
robust to
Windows, I don't think we want to imply compatibility that isn't there.
Thanks,
James
On Mon, Dec 7, 2020 at 1:45 AM Simon Ser wrote:
> On Sunday, December 6th, 2020 at 1:39 AM, James Park <
> jpar...@lagfreegames.com> wrote:
>
> > Create drm_basic_types.h to
7, 2020 at 12:51 AM Pekka Paalanen wrote:
> On Fri, 4 Dec 2020 11:07:41 -0800
> James Park wrote:
>
> > I could adjust the block to look like this:
> >
> > #ifdef DRM_FOURCC_STANDALONE
> > #if defined(__linux__)
> > #include
> > #else
> >
That would work, but that's kind of an annoying requirement. I would prefer
the header to be self-sufficient.
Thanks,
James
On Mon, Dec 7, 2020 at 2:47 AM Simon Ser wrote:
> On Monday, December 7th, 2020 at 11:44 AM, Pekka Paalanen <
> ppaala...@gmail.com> wrote:
>
> > But then, the code in
Create drm_basic_types.h to define types previously defined by drm.h.
Use DRM_FOURCC_STANDALONE to include drm_fourcc.h, replacing drm.h
dependency with drm_basic_types.h.
This will allow Mesa to port code to Windows more easily.
Signed-off-by: James Park
---
include/uapi/drm/drm.h
Create drm_basic_types.h to define types previously defined by drm.h.
Use DRM_FOURCC_STANDALONE to include drm_fourcc.h, replacing drm.h
dependency with drm_basic_types.h.
This will allow Mesa to port code to Windows more easily.
Signed-off-by: James Park
James Park (1):
drm
;
> > On Thu, 3 Dec 2020 21:45:14 +0100
> > Daniel Vetter wrote:
> >
> > > On Thu, Dec 3, 2020 at 7:55 PM James Park
> wrote:
> > > >
> > > > The trailing underscore for DRM_FOURCC_STANDALONE_ isn't
> > > > intentional, right?
ec 4, 2020 at 1:47 AM James Park
wrote:
> The typedefs might also conflict on Linux if DRM_FOURCC_STANDALONE is
> enabled with whatever LInux declared __u32/__u64 as, but I think the
> implication is that once DRM_FOURCC_STANDALONE has been declared, that's
> kind of a promise not to
to it if someone has a problem
where they want to define DRM_FOURCC_STANDALONE, but also can't avoid
including drm.h for some reason.
On Fri, Dec 4, 2020 at 12:53 AM Simon Ser wrote:
> On Friday, December 4, 2020 5:53 AM, James Park
> wrote:
>
> > +#ifdef DRM_FOURCC_STANDALON
Add DRM_FOURCC_STANDALONE guard to skip drm.h dependency.
This will allow Mesa to port code to Windows more easily.
Signed-off-by: James Park
---
include/uapi/drm/drm_fourcc.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm
Add DRM_FOURCC_STANDALONE guard to skip drm.h dependency.
This will allow Mesa to port code to Windows more easily.
Signed-off-by: James Park
James Park (1):
drm: Allow drm_fourcc.h without including drm.h
include/uapi/drm/drm_fourcc.h | 6 ++
1 file changed, 6 insertions(+)
--
2.7.4
ote:
> >
> > On 2020-12-02 8:47 p.m., James Park wrote:
> > >
> > > If we're trying to cut ties with the drm-uapi folder entirely, the
> stuff
> > > ac_surface.c need includes the AMD_FMT_MOD stuff in drm_fourcc.h,
> > > and AMDGPU_TILING_* under amdgpu_drm.h
doesn't change very much. It might be easier
to read here:
https://github.com/jpark37/linux/commit/648e9281824ddc943c3ea6b34d6d6c154717a0a3
Thanks,
James
On Wed, Dec 2, 2020 at 2:26 PM Daniel Vetter wrote:
> On Wed, Dec 2, 2020 at 8:48 PM James Park
> wrote:
> >
> > I can avo
This will allow Mesa to port code to Windows more easily.
Hide BSD header and drm_handle_t behind _WIN32 check.
Change __volatile__ to volatile, which is standard.
Signed-off-by: James Park
---
include/uapi/drm/drm.h | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff
or these
definitions?
Thanks,
James
On Wed, Dec 2, 2020 at 10:06 AM Michel Dänzer wrote:
> On 2020-12-02 1:46 p.m., Daniel Vetter wrote:
> > On Wed, Dec 2, 2020 at 12:43 PM Michel Dänzer
> wrote:
> >>
> >> On 2020-12-01 11:01 a.m., James Park wrote:
> >>
-by: James Park
James Park (1):
drm: Fix drm.h uapi header for Windows
include/uapi/drm/drm.h | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
--
2.7.4
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https
This will allow Mesa to port code to Windows more easily.
Hide BSD header and drm_handle_t behind _WIN32 check.
Change __volatile__ to volatile, which is standard.
---
include/uapi/drm/drm.h | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/include/uapi/drm/drm.h
Attempting to submit patch in response to
https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6162#note_712454
This will allow Mesa to port code to Windows more easily.
Hide BSD header and drm_handle_t behind _WIN32 check.
Change __volatile__ to volatile, which is standard.
James Park
42 matches
Mail list logo
