Re: [PATCH] drm: apple: mark local functions static

2024-01-23 Thread Janne Grunau
Hej Arnd, On Tue, Jan 23, 2024, at 08:34, Arnd Bergmann wrote: > On Mon, Jan 22, 2024, at 21:50, Janne Grunau wrote: >> On Wed, Jan 17, 2024, at 11:44, Arnd Bergmann wrote: >>> >>> -int parse_sample_rate_bit(struct dcp_parse_ctx *handle, unsigned int &g

Re: [PATCH] drm: apple: use strscpy() in place of strlcpy()

2024-01-22 Thread Janne Grunau
Hej, On Mon, Jan 22, 2024, at 17:11, Arnd Bergmann wrote: > From: Arnd Bergmann > > Since commit d26270061ae6 ("string: Remove strlcpy()"), the strlcpy() > function causes a build failure. > > Since the return value is ignored, changing it to the strscpy() > causes no change in behavior but

Re: [PATCH] drm: apple: mark local functions static

2024-01-22 Thread Janne Grunau
Hej, On Wed, Jan 17, 2024, at 11:44, Arnd Bergmann wrote: > From: Arnd Bergmann > > With linux-6.8, the kernel warns about functions that have no > extern declaration, so mark both of these static. > > Fixes: 2d782b0d007d ("gpu: drm: apple: Add sound mode parsing") > Signed-off-by: Arnd Bergmann

[PATCH v2] drm/simpledrm: Add support for multiple "power-domains"

2023-09-12 Thread Janne Grunau via B4 Relay
From: Janne Grunau Multiple power domains need to be handled explicitly in each driver. The driver core can not handle it automatically since it is not aware of power sequencing requirements the hardware might have. This is not a problem for simpledrm since everything is expected to be powered

Re: [PATCH] drm/simpledrm: Add support for multiple "power-domains"

2023-09-12 Thread Janne Grunau
On 2023-09-11 14:26:10 +0200, Thomas Zimmermann wrote: > Hi > > Am 10.09.23 um 18:39 schrieb Janne Grunau via B4 Relay: > > From: Janne Grunau > > > > Multiple power domains need to be handled explicitly in each driver. The > > driver core can not handle it au

Re: [PATCH] drm/simpledrm: Add support for multiple "power-domains"

2023-09-12 Thread Janne Grunau
On 2023-09-10 22:16:05 +0200, Christophe JAILLET wrote: > Le 10/09/2023 à 18:39, Janne Grunau via B4 Relay a écrit : > > From: Janne Grunau > > > > Multiple power domains need to be handled explicitly in each driver. The > > driver core can not handle it automati

Re: [PATCH] drm/simpledrm: Add support for multiple "power-domains"

2023-09-10 Thread Janne Grunau
On 2023-09-10 18:39:39 +0200, Janne Grunau via B4 Relay wrote: > From: Janne Grunau > > Multiple power domains need to be handled explicitly in each driver. The > driver core can not handle it automatically since it is not aware of > power sequencing requirements the hard

[PATCH] drm/simpledrm: Add support for multiple "power-domains"

2023-09-10 Thread Janne Grunau via B4 Relay
From: Janne Grunau Multiple power domains need to be handled explicitly in each driver. The driver core can not handle it automatically since it is not aware of power sequencing requirements the hardware might have. This is not a problem for simpledrm since everything is expected to be powered

Re: [PATCH v6 3/3] drm/bridge_connector: implement oob_hotplug_event

2023-07-29 Thread Janne Grunau
On 2023-07-09 23:25:11 +0300, Dmitry Baryshkov wrote: > Implement the oob_hotplug_event() callback. Translate it to the HPD > notification sent to the HPD bridge in the chain. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Janne Grunau > --- > drivers/gpu/drm/drm_bridg

Re: [PATCH v6 2/3] drm/bridge_connector: stop filtering events in drm_bridge_connector_hpd_cb()

2023-07-28 Thread Janne Grunau
dmi.c will do unnecessary work when called repeatedly with status connected. Not sure if it is worth adressing since I don't expect multiple calls with connector_status_connected to occur for this particular bridge. Reviewed-By: Janne Grunau > Signed-off-by: Dmitry Baryshk

Re: [PATCH] drm/probe_helper: fix the warning reported when calling drm_kms_helper_poll_disable during suspend

2023-04-23 Thread Janne Grunau
On 2023-04-20 23:07:01 +0300, Dmitry Baryshkov wrote: > On Thu, 20 Apr 2023 at 23:01, Janne Grunau wrote: > > > > On 2023-03-28 10:31:29 +0800, Zongmin Zhou wrote: > > > When drivers call drm_kms_helper_poll_disable from > > > their device suspend implementati

Re: [PATCH] drm/probe_helper: fix the warning reported when calling drm_kms_helper_poll_disable during suspend

2023-04-20 Thread Janne Grunau
le(struct drm_device *dev) > if (dev->mode_config.poll_running) > drm_kms_helper_disable_hpd(dev); > > - cancel_delayed_work_sync(>mode_config.output_poll_work); > + if (dev->mode_config.poll_enabled) > + cancel_delayed_work_sync(>mode_config.output_poll_work); Checking for dev->mode_config.poll_enabled at the start of the function and return early if it is not true looks more in style with the rest of drm_probe_helper.c. No difference functionally of course. Tested with the apple kms driver. Reviewed-by: Janne Grunau ciao Janne

Re: [RFC PATCH] drm/simpledrm: Allow physical width and height configuration via DT

2023-01-20 Thread Janne Grunau
Hej, adding devicet...@vger.kernel.org and as...@lists.linux.dev to cc:, the former for the obvious devictree/bindings related questions, asahi for the prospect of supporting high DPI displays during early boot and in u-boot. On 2023-01-18 18:48:17 +, Rayyan Ansari wrote: > Hello, > The

Re: [PATCH v2 1/5] dt-bindings: reserved-memory: Document memory region specifier

2022-04-01 Thread Janne Grunau
On 2022-03-31 18:25:05 +0200, Thierry Reding wrote: > On Fri, Feb 11, 2022 at 12:15:44AM +0100, Janne Grunau wrote: > > On 2022-02-09 17:31:16 +0100, Thierry Reding wrote: > > > On Sun, Feb 06, 2022 at 11:27:00PM +0100, Janne Grunau wrote: > > > > On 2021-09-15 17:19:

Re: [PATCH v2 1/5] dt-bindings: reserved-memory: Document memory region specifier

2022-02-10 Thread Janne Grunau
On 2022-02-09 17:31:16 +0100, Thierry Reding wrote: > On Sun, Feb 06, 2022 at 11:27:00PM +0100, Janne Grunau wrote: > > On 2021-09-15 17:19:39 +0200, Thierry Reding wrote: > > > On Tue, Sep 07, 2021 at 07:44:44PM +0200, Thierry Reding wrote: > > > > On Tue, Sep 07,

Re: [PATCH v2 1/5] dt-bindings: reserved-memory: Document memory region specifier

2022-02-07 Thread Janne Grunau
On 2021-09-15 17:19:39 +0200, Thierry Reding wrote: > On Tue, Sep 07, 2021 at 07:44:44PM +0200, Thierry Reding wrote: > > On Tue, Sep 07, 2021 at 10:33:24AM -0500, Rob Herring wrote: > > > On Fri, Sep 3, 2021 at 10:36 AM Thierry Reding > > > wrote: > > > > > > > > On Fri, Sep 03, 2021 at