[PATCH 10/11] drm/i915: clamp sprite to viewable area

2011-10-25 Thread Jesse Barnes
If we try to scan a sprite outside of the parent CRTC area, the display engine will underflow and potentially blank the framebuffer. So clamp the position + size to the viewable area. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/intel_overlay2.c | 12 +++- 1 files changed, 11

[PATCH 09/11] drm/i915: fix overlay fb object handling

2011-10-25 Thread Jesse Barnes
To avoid the object being destroyed before our disable hook is called, take a private reference on it. This will guarantee that we can still access the object at disable time. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/intel_overlay2.c | 27 ++- 1 files

[PATCH 08/11] drm/i915: overlay watermark hack

2011-10-25 Thread Jesse Barnes
--- drivers/gpu/drm/i915/intel_display.c | 11 --- 1 files changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 4f599ce..cd7e04d 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++

[PATCH 07/11] drm/i915: enable new overlay code on IVB too

2011-10-25 Thread Jesse Barnes
Split things out a little and add the IVB reg definitions. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/i915_reg.h | 59 drivers/gpu/drm/i915/intel_overlay2.c | 168 ++-- 2 files changed, 216 insertions(+), 11 deletions(-) diff --git

[PATCH 06/11] drm/i915: plane teardown fixes

2011-10-25 Thread Jesse Barnes
Make sure the object exists (it may not if the plane was previously disabled) and make sure we zero it out in the disable path to avoid trouble later. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/intel_overlay2.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff

[PATCH 05/11] drm/i915: move pin & fence for plane past potential error paths

2011-10-25 Thread Jesse Barnes
This avoids the need to unpin on the error path. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/intel_overlay2.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_overlay2.c b/drivers/gpu/drm/i915/intel_overlay2.c index 2e38b15

[PATCH 04/11] drm/i915: add SNB video sprite support

2011-10-25 Thread Jesse Barnes
The video sprites support various video surface formats natively and can handle scaling as well. So add support for them using the new DRM core overlay support functions. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/Makefile |1 + drivers/gpu/drm/i915/i915_reg.h

[PATCH 03/11] drm/i915: rename existing overlay support to "legacy"

2011-10-25 Thread Jesse Barnes
The old overlay block has all sorts of quirks and is very different than ILK+ video sprites. So rename it to legacy to make that clear and clash less with core overlay support. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/i915_debugfs.c |2 +- drivers/gpu/drm/i915/i915_drv.h

[PATCH 02/11] drm: add an fb creation ioctl that takes a pixel format

2011-10-25 Thread Jesse Barnes
To properly support the various plane formats supported by different hardware, the kernel must know the pixel format of a framebuffer object. So add a new ioctl taking a format argument corresponding to a fourcc name from videodev2.h. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/drm_crtc.c

[PATCH 01/11] drm: add plane support

2011-10-25 Thread Jesse Barnes
Planes are a bit like half-CRTCs. They have a location and fb, but don't drive outputs directly. Add support for handling them to the core KMS code. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/drm_crtc.c | 236 +++- drivers/gpu/drm/drm_drv.c

DRM planes and new fb creation ioctl

2011-10-25 Thread Jesse Barnes
I've given up waiting for someone to implement support for these ioctls on another platform before they're merged, but I have received a lot of feedback on the interfaces, and it sounds like they're ok. I've also fixed all the remaining issues I'm aware of on SNB platforms and things are working

DRM planes and new fb creation ioctl

2011-10-25 Thread Jesse Barnes
I've given up waiting for someone to implement support for these ioctls on another platform before they're merged, but I have received a lot of feedback on the interfaces, and it sounds like they're ok. I've also fixed all the remaining issues I'm aware of on SNB platforms and things are working

[PATCH 01/11] drm: add plane support

2011-10-25 Thread Jesse Barnes
Planes are a bit like half-CRTCs. They have a location and fb, but don't drive outputs directly. Add support for handling them to the core KMS code. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/drm_crtc.c | 236 +++- drivers

[PATCH 02/11] drm: add an fb creation ioctl that takes a pixel format

2011-10-25 Thread Jesse Barnes
To properly support the various plane formats supported by different hardware, the kernel must know the pixel format of a framebuffer object. So add a new ioctl taking a format argument corresponding to a fourcc name from videodev2.h. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org

[PATCH 05/11] drm/i915: move pin fence for plane past potential error paths

2011-10-25 Thread Jesse Barnes
This avoids the need to unpin on the error path. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/intel_overlay2.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_overlay2.c b/drivers/gpu/drm/i915

[PATCH 03/11] drm/i915: rename existing overlay support to legacy

2011-10-25 Thread Jesse Barnes
The old overlay block has all sorts of quirks and is very different than ILK+ video sprites. So rename it to legacy to make that clear and clash less with core overlay support. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/i915_debugfs.c |2 +- drivers/gpu

[PATCH 04/11] drm/i915: add SNB video sprite support

2011-10-25 Thread Jesse Barnes
The video sprites support various video surface formats natively and can handle scaling as well. So add support for them using the new DRM core overlay support functions. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/Makefile |1 + drivers/gpu/drm

[PATCH 06/11] drm/i915: plane teardown fixes

2011-10-25 Thread Jesse Barnes
Make sure the object exists (it may not if the plane was previously disabled) and make sure we zero it out in the disable path to avoid trouble later. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/intel_overlay2.c |6 ++ 1 files changed, 6 insertions(+), 0

[PATCH 07/11] drm/i915: enable new overlay code on IVB too

2011-10-25 Thread Jesse Barnes
Split things out a little and add the IVB reg definitions. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/i915_reg.h | 59 drivers/gpu/drm/i915/intel_overlay2.c | 168 ++-- 2 files changed, 216 insertions(+), 11

[PATCH 09/11] drm/i915: fix overlay fb object handling

2011-10-25 Thread Jesse Barnes
To avoid the object being destroyed before our disable hook is called, take a private reference on it. This will guarantee that we can still access the object at disable time. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/intel_overlay2.c | 27

[PATCH 11/11] drm/i915: add sprite scaling support

2011-10-25 Thread Jesse Barnes
If the source and destination size are different, try to scale the sprite on the corresponding CRTC. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/i915_reg.h |5 + drivers/gpu/drm/i915/intel_overlay2.c | 14 -- 2 files changed, 17

[PATCH 10/11] drm/i915: clamp sprite to viewable area

2011-10-25 Thread Jesse Barnes
If we try to scan a sprite outside of the parent CRTC area, the display engine will underflow and potentially blank the framebuffer. So clamp the position + size to the viewable area. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/intel_overlay2.c | 12

Re: DRM planes and new fb creation ioctl

2011-10-25 Thread Jesse Barnes
On Tue, 25 Oct 2011 19:47:13 +0900 Joonyoung Shim jy0922.s...@samsung.com wrote: 10/25/2011 06:46 PM, Jesse Barnes 쓴 글: I've given up waiting for someone to implement support for these ioctls on another platform before they're merged, but I have received a lot of feedback on the interfaces

Re: [Intel-gfx] DRM planes and new fb creation ioctl

2011-10-25 Thread Jesse Barnes
On Tue, 25 Oct 2011 11:46:55 +0200 Jesse Barnes jbar...@virtuousgeek.org wrote: I've given up waiting for someone to implement support for these ioctls on another platform before they're merged, but I have received a lot of feedback on the interfaces, and it sounds like they're ok. I've also

[PATCH] drm/i915: add SNB video sprite support

2011-10-25 Thread Jesse Barnes
The video sprites support various video surface formats natively and can handle scaling as well. So add support for them using the new DRM core overlay support functions. v2: collapse patches and fix plane disable vs unpin ordering bug Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org

[PATCH] drm/i915: add SNB video sprite support

2011-10-25 Thread Jesse Barnes
From 13efc0a405d522aad8250fce2dbd05fefb8b8ab0 Mon Sep 17 00:00:00 2001 From: Jesse Barnes jbar...@virtuousgeek.org Date: Fri, 22 Apr 2011 14:55:33 -0700 Subject: [PATCH] drm/i915: add SNB video sprite support The video sprites support various video surface formats natively and can handle scaling

Re: [PATCH 01/11] drm: add plane support

2011-10-25 Thread Jesse Barnes
On Tue, 25 Oct 2011 13:58:55 +0200 Daniel Vetter dan...@ffwll.ch wrote: On Tue, Oct 25, 2011 at 11:46:56AM +0200, Jesse Barnes wrote: Planes are a bit like half-CRTCs. They have a location and fb, but don't drive outputs directly. Add support for handling them to the core KMS code

Re: [PATCH 01/11] drm: add plane support

2011-10-25 Thread Jesse Barnes
On Tue, 25 Oct 2011 14:26:07 +0100 Alan Cox a...@lxorguk.ukuu.org.uk wrote: As discussed with Jesse on irc, drm fb handling is fragile. Current rules: - fbs are not reference counted, hence when destroying we need to disable all crtcs (and now also planes) that use them.

Re: [PATCH 01/11] drm: add plane support

2011-10-25 Thread Jesse Barnes
Here's a diff I can roll in if it looks ok. It adds the ability to specify multiple handles for a single fb to better accommodate planar configs. I think Rob has convinced me that this is a good idea... comments appreciated. Thanks, Jesse diff --git a/drivers/gpu/drm/drm_crtc.c

[PATCH v2 4/5] DRI2: Expose API to set drawable swap limit.

2011-10-06 Thread Jesse Barnes
On Thu, 15 Sep 2011 01:31:00 +0200 Mario Kleiner wrote: > On Sep 15, 2011, at 12:54 AM, Francisco Jerez wrote: > > > Mario Kleiner writes: > > > >> On Sep 14, 2011, at 6:02 PM, Keith Packard wrote: > >> > >>> On Wed, 14 Sep 2011 10:05:29 -0500, J

Re: [PATCH v2 4/5] DRI2: Expose API to set drawable swap limit.

2011-10-06 Thread Jesse Barnes
into this. cc'ing dri-devel, all that was said is in this mail. What's the latest here? I still think we need the swap limit API... -- Jesse Barnes, Intel Open Source Technology Center signature.asc Description: PGP signature ___ dri-devel mailing list dri-devel

[Intel-gfx] PCH reference clock cleanups

2011-10-03 Thread Jesse Barnes
On Mon, 03 Oct 2011 16:18:48 -0700 Keith Packard wrote: > On Mon, 3 Oct 2011 14:14:23 -0700, Jesse Barnes > wrote: > > > Now... is keeping the various refclks enabled costing us any power? > > IOW, should we be trying to disable them when everything has been > >

[Intel-gfx] PCH reference clock cleanups

2011-10-03 Thread Jesse Barnes
ning things, but I believe patch 7 > includes whitespace errors. Yay excellent. Now... is keeping the various refclks enabled costing us any power? IOW, should we be trying to disable them when everything has been DPMS'd off too? -- Jesse Barnes, Intel Open Source Technology Center

[Intel-gfx] [PATCH 9/9] drm/i915: Initialize PCH refclks at modeset init time

2011-10-03 Thread Jesse Barnes
id you get confirmation that the "wavy VGA" bug was fixed with this series? Overall seems like a good improvement over our old PCH refclk code... -- Jesse Barnes, Intel Open Source Technology Center

[Intel-gfx] [PATCH 00/24] MacBook Air patch sequence (v2)

2011-10-03 Thread Jesse Barnes
s pretty much the > same as people are getting under Mac OS. As long as you enable RC6. :) -- Jesse Barnes, Intel Open Source Technology Center

[Intel-gfx] [PATCH 16/21] drm/i915: edp_panel_on does not need to return a bool

2011-10-03 Thread Jesse Barnes
> /* Returns true if the panel was already on when called */ > -static bool ironlake_edp_panel_on (struct intel_dp *intel_dp) > +static void ironlake_edp_panel_on (struct intel_dp *intel_dp) > { Remove the comment too? -- Jesse Barnes, Intel Open Source Technology Center

[Intel-gfx] [PATCH 10/21] drm/i915: Wrap DP EDID fetch functions to enable eDP panel power

2011-10-03 Thread Jesse Barnes
On Thu, 29 Sep 2011 18:09:42 -0700 Keith Packard wrote: > Talking to the eDP DDC channel requires that the panel be powered > up. Wrap both the EDID and modes fetch code with calls to turn the vdd > power on and back off. > These VDD AUX changes look good, ack on all of them. --

[Intel-gfx] [PATCH 05/21] drm/i915: Check eDP power when doing aux channel communications

2011-10-03 Thread Jesse Barnes
pp_status, > + I915_READ(PCH_PP_CONTROL)); > + } > +} I'd call it "intel_dp_assert_dp_power" or something more descriptive (or just assert_panel_power to match the other asserts in intel_display.c), but other than that this is a nice sanity check. -- Jesse Barnes, Intel Open Source Technology Center

[Intel-gfx] [PATCH 04/21] drm/i915: Only use VBT panel mode on eDP if no EDID is found

2011-10-03 Thread Jesse Barnes
tarts and use that if present. But, that might mean that > you'd get different modes depending on whether the machine booted with > the lid closed or open, which seems like a bad plan. More than that, I think eDP *requires* an EDID, and it sounds like even the Air has one (and if any machine didn

[Intel-gfx] [PATCH 01/21] drm/i915: Enable digital port hotplug on PCH systems

2011-10-03 Thread Jesse Barnes
dresses > for PCH regs ... > Reviewed-by: Daniel Vetter Yep, I like it too: Reviewed-by: Jesse Barnes -- Jesse Barnes, Intel Open Source Technology Center

Re: [Intel-gfx] [PATCH 01/21] drm/i915: Enable digital port hotplug on PCH systems

2011-10-03 Thread Jesse Barnes
... Reviewed-by: Daniel Vetter daniel.vet...@ffwll.ch Yep, I like it too: Reviewed-by: Jesse Barnes jbar...@virtuousgeek.org -- Jesse Barnes, Intel Open Source Technology Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org http

Re: [Intel-gfx] [PATCH 04/21] drm/i915: Only use VBT panel mode on eDP if no EDID is found

2011-10-03 Thread Jesse Barnes
. -- Jesse Barnes, Intel Open Source Technology Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Intel-gfx] [PATCH 05/21] drm/i915: Check eDP power when doing aux channel communications

2011-10-03 Thread Jesse Barnes
(or just assert_panel_power to match the other asserts in intel_display.c), but other than that this is a nice sanity check. -- Jesse Barnes, Intel Open Source Technology Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org http

[Intel-gfx] [PATCH 9/9] drm/i915: Disable eDP VDD in a delayed work proc instead of synchronously

2011-09-23 Thread Jesse Barnes
On Tue, 20 Sep 2011 21:51:33 -0700 Keith Packard wrote: > Yes, making it cleaner would help a ton. There are some basic problems > with the DRM API that make this hard though -- intel_dp_prepare may > not ever be followed by a call to intel_dp_commit. That's why I had > the VDD AUX stuff get

[Intel-gfx] [PATCH 6/9] drm/i915: Make sure eDP power is on before using aux channel

2011-09-23 Thread Jesse Barnes
On Tue, 20 Sep 2011 21:45:54 -0700 Keith Packard wrote: > On Wed, 21 Sep 2011 09:20:01 +0530, Jesse Barnes > wrote: > > > This one mixes up lots of cleanups plus the EDID read with the power > > changes. > > I think the cleanups are; > > 1) edp checks

Re: [Intel-gfx] [PATCH 6/9] drm/i915: Make sure eDP power is on before using aux channel

2011-09-22 Thread Jesse Barnes
On Tue, 20 Sep 2011 21:45:54 -0700 Keith Packard kei...@keithp.com wrote: On Wed, 21 Sep 2011 09:20:01 +0530, Jesse Barnes jbar...@virtuousgeek.org wrote: This one mixes up lots of cleanups plus the EDID read with the power changes. I think the cleanups are; 1) edp checks inside

Re: [Intel-gfx] [PATCH 9/9] drm/i915: Disable eDP VDD in a delayed work proc instead of synchronously

2011-09-22 Thread Jesse Barnes
On Tue, 20 Sep 2011 21:51:33 -0700 Keith Packard kei...@keithp.com wrote: Yes, making it cleaner would help a ton. There are some basic problems with the DRM API that make this hard though -- intel_dp_prepare may not ever be followed by a call to intel_dp_commit. That's why I had the VDD AUX

[Intel-gfx] [PATCH 9/9] drm/i915: Disable eDP VDD in a delayed work proc instead of synchronously

2011-09-21 Thread Jesse Barnes
On Mon, 19 Sep 2011 15:22:03 -0700 Keith Packard wrote: > There's no good reason to turn off the eDP force VDD bit synchronously > while probing devices; that just sticks a huge delay into all mode > setting paths. Instead, queue a delayed work proc to disable the VDD > force bit and then

[Intel-gfx] [PATCH 6/9] drm/i915: Make sure eDP power is on before using aux channel

2011-09-21 Thread Jesse Barnes
On Mon, 19 Sep 2011 15:22:00 -0700 Keith Packard wrote: > The eDP panel may not be able to respond to aux channel communications > unless it has power supplied. During mode setting, power may be > cut-off during panel power sequencing. Make sure that any aux channel > communications will work by

Re: [Intel-gfx] [PATCH 6/9] drm/i915: Make sure eDP power is on before using aux channel

2011-09-20 Thread Jesse Barnes
On Mon, 19 Sep 2011 15:22:00 -0700 Keith Packard kei...@keithp.com wrote: The eDP panel may not be able to respond to aux channel communications unless it has power supplied. During mode setting, power may be cut-off during panel power sequencing. Make sure that any aux channel communications

Re: [Intel-gfx] [PATCH 9/9] drm/i915: Disable eDP VDD in a delayed work proc instead of synchronously

2011-09-20 Thread Jesse Barnes
On Mon, 19 Sep 2011 15:22:03 -0700 Keith Packard kei...@keithp.com wrote: There's no good reason to turn off the eDP force VDD bit synchronously while probing devices; that just sticks a huge delay into all mode setting paths. Instead, queue a delayed work proc to disable the VDD force bit

[PATCH] Fix wrong initializer for "locked" variable

2011-08-25 Thread Jesse Barnes
NTROL; Hah yeah that's a good one, thanks for the fix. Reviewed-by: Jesse Barnes -- Jesse Barnes, Intel Open Source Technology Center

Re: [PATCH] Fix wrong initializer for locked variable

2011-08-25 Thread Jesse Barnes
for the fix. Reviewed-by: Jesse Barnes jbar...@virtuousgeek.org -- Jesse Barnes, Intel Open Source Technology Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Intel-gfx] [PATCH 2/4] drm/i915: Leave LVDS registers unlocked

2011-08-08 Thread Jesse Barnes
On Mon, 08 Aug 2011 13:24:12 -0700 Keith Packard wrote: > On Mon, 8 Aug 2011 13:01:28 -0700, Jesse Barnes > wrote: > > On Mon, 08 Aug 2011 12:53:31 -0700 > > Keith Packard wrote: > > > > > On Mon, 8 Aug 2011 11:49:54 -0700, Jesse Barnes > > virtuousge

[Intel-gfx] [PATCH 2/4] drm/i915: Leave LVDS registers unlocked

2011-08-08 Thread Jesse Barnes
On Mon, 08 Aug 2011 12:53:31 -0700 Keith Packard wrote: > On Mon, 8 Aug 2011 11:49:54 -0700, Jesse Barnes > wrote: > > > Yep, it's safe and possible to do on pre-PCH as well. For panel > > fitting we do need to do an actual power cycle when going from > > non

[Intel-gfx] [PATCH 1/4] drm/i915: Wait for LVDS panel power sequence

2011-08-08 Thread Jesse Barnes
On Mon, 08 Aug 2011 11:40:06 -0700 Keith Packard wrote: > On Mon, 8 Aug 2011 09:27:19 -0700, Jesse Barnes > wrote: > > > ...to catch places like this where the wrong register gets used. :) > > Ouch! There are only two places we *should* have these loops, one when >

[Intel-gfx] [PATCH 2/4] drm/i915: Leave LVDS registers unlocked

2011-08-08 Thread Jesse Barnes
On Mon, 08 Aug 2011 11:42:56 -0700 Keith Packard wrote: > On Mon, 8 Aug 2011 09:30:10 -0700, Jesse Barnes > wrote: > > > Yep, looks fine. The only think we might want to sprinkle about are > > checks for panel off so we can avoid visible corruption if we whack > &g

[Intel-gfx] [PATCH 4/4] drm/i915: Remove unused 'reg' argument to dp_pipe_enabled

2011-08-08 Thread Jesse Barnes
On Sat, 6 Aug 2011 10:54:08 -0700 Keith Packard wrote: > Just an extra parameter which isn't actually needed. > > Signed-off-by: Keith Packard > --- Reviewed-by: Jesse Barnes -- Jesse Barnes, Intel Open Source Technology Center

[Intel-gfx] [PATCH 3/4] drm/i915: Fix PCH port pipe select in CPT disable paths

2011-08-08 Thread Jesse Barnes
rd > --- > drivers/gpu/drm/i915/i915_reg.h | 13 ++- > drivers/gpu/drm/i915/intel_display.c | 60 ++--- > 2 files changed, 58 insertions(+), 15 deletions(-) > Reviewed-by: Jesse Barnes -- Jesse Barnes, Intel Open Source Technology Center

[Intel-gfx] [PATCH 2/4] drm/i915: Leave LVDS registers unlocked

2011-08-08 Thread Jesse Barnes
think we might want to sprinkle about are checks for panel off so we can avoid visible corruption if we whack timing or fb stuff while the panel is on. Reviewed-by: Jesse Barnes -- Jesse Barnes, Intel Open Source Technology Center

[Intel-gfx] [PATCH 1/4] drm/i915: Wait for LVDS panel power sequence

2011-08-08 Thread Jesse Barnes
r this... > I915_WRITE(ctl_reg, I915_READ(ctl_reg) & ~POWER_TARGET_ON); > + if (wait_for((I915_READ(stat_reg) & PP_ON) == 0, 1000)) > + DRM_ERROR("timed out waiting for panel to power off status > 0x%08x control 0x%08x\n", > +

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Wait for LVDS panel power sequence

2011-08-08 Thread Jesse Barnes
)) + DRM_ERROR(timed out waiting for panel to power off status 0x%08x control 0x%08x\n, + I915_READ(PCH_PP_STATUS), I915_READ(PCH_PP_CONTROL)); ...to catch places like this where the wrong register gets used. :) -- Jesse Barnes, Intel Open Source Technology Center

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Leave LVDS registers unlocked

2011-08-08 Thread Jesse Barnes
fine. The only think we might want to sprinkle about are checks for panel off so we can avoid visible corruption if we whack timing or fb stuff while the panel is on. Reviewed-by: Jesse Barnes jbar...@virtuousgeek.org -- Jesse Barnes, Intel Open Source Technology Center

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Fix PCH port pipe select in CPT disable paths

2011-08-08 Thread Jesse Barnes
/gpu/drm/i915/i915_reg.h | 13 ++- drivers/gpu/drm/i915/intel_display.c | 60 ++--- 2 files changed, 58 insertions(+), 15 deletions(-) Reviewed-by: Jesse Barnes jbar...@virtuousgeek.org -- Jesse Barnes, Intel Open Source Technology Center

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Remove unused 'reg' argument to dp_pipe_enabled

2011-08-08 Thread Jesse Barnes
On Sat, 6 Aug 2011 10:54:08 -0700 Keith Packard kei...@keithp.com wrote: Just an extra parameter which isn't actually needed. Signed-off-by: Keith Packard kei...@keithp.com --- Reviewed-by: Jesse Barnes jbar...@virtuousgeek.org -- Jesse Barnes, Intel Open Source Technology Center

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Wait for LVDS panel power sequence

2011-08-08 Thread Jesse Barnes
On Mon, 08 Aug 2011 11:40:06 -0700 Keith Packard kei...@keithp.com wrote: On Mon, 8 Aug 2011 09:27:19 -0700, Jesse Barnes jbar...@virtuousgeek.org wrote: ...to catch places like this where the wrong register gets used. :) Ouch! There are only two places we *should* have these loops, one

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Leave LVDS registers unlocked

2011-08-08 Thread Jesse Barnes
On Mon, 08 Aug 2011 12:53:31 -0700 Keith Packard kei...@keithp.com wrote: On Mon, 8 Aug 2011 11:49:54 -0700, Jesse Barnes jbar...@virtuousgeek.org wrote: Yep, it's safe and possible to do on pre-PCH as well. For panel fitting we do need to do an actual power cycle when going from non

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Leave LVDS registers unlocked

2011-08-08 Thread Jesse Barnes
On Mon, 08 Aug 2011 13:24:12 -0700 Keith Packard kei...@keithp.com wrote: On Mon, 8 Aug 2011 13:01:28 -0700, Jesse Barnes jbar...@virtuousgeek.org wrote: On Mon, 08 Aug 2011 12:53:31 -0700 Keith Packard kei...@keithp.com wrote: On Mon, 8 Aug 2011 11:49:54 -0700, Jesse Barnes jbar

[PATCH v2] pass ELD to HDMI/DP audio driver

2011-07-29 Thread Jesse Barnes
gle to my HDMI TV. Does the HDMI HDA codec need any special parameters to work? Thanks, -- Jesse Barnes, Intel Open Source Technology Center

Re: [PATCH v2] pass ELD to HDMI/DP audio driver

2011-07-29 Thread Jesse Barnes
HDMI TV. Does the HDMI HDA codec need any special parameters to work? Thanks, -- Jesse Barnes, Intel Open Source Technology Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Intel-gfx] [PATCH] drm/i915: Hold struct_mutex during hotplug processing

2011-07-27 Thread Jesse Barnes
On Wed, 27 Jul 2011 02:21:24 -0700 Keith Packard wrote: > On Tue, 26 Jul 2011 12:12:25 -0700, Jesse Barnes virtuousgeek.org> wrote: > > > I'd like to amend my reviewed by and say the lock shouldn't be held > > around the call to the drm helper function. It queues some wor

Re: [Intel-gfx] [PATCH] drm/i915: Hold struct_mutex during hotplug processing

2011-07-27 Thread Jesse Barnes
On Wed, 27 Jul 2011 02:21:24 -0700 Keith Packard kei...@keithp.com wrote: On Tue, 26 Jul 2011 12:12:25 -0700, Jesse Barnes jbar...@virtuousgeek.org wrote: I'd like to amend my reviewed by and say the lock shouldn't be held around the call to the drm helper function. It queues some work

[Intel-gfx] [PATCH] drm/i915: Hold struct_mutex during hotplug processing

2011-07-26 Thread Jesse Barnes
internal driver callbacks but missed that the lock was held across the helper too. -- Jesse Barnes, Intel Open Source Technology Center

[Intel-gfx] [PATCH 5/5] drm/i915: DP_PIPE_ENABLED must check transcoder on CPT

2011-07-26 Thread Jesse Barnes
t interference from other outputs > connected to that pch port > > Signed-off-by: Keith Packard > --- Ah nice catch. I expect one day we'll have all the chipset and PCH differences coded... Reviewed-by: Jesse Barnes -- Jesse Barnes, Intel Open Source Technology Center

[Intel-gfx] [PATCH 3/5] drm/i915: In intel_dp_init, replace read of DPCD with intel_dp_get_dpcd

2011-07-26 Thread Jesse Barnes
p->dpcd)) { > + if (ret) { > if (intel_dp->dpcd[DP_DPCD_REV] >= 0x11) > dev_priv->no_aux_handshake = > intel_dp->dpcd[DP_MAX_DOWNSPREAD] & Reviewed-by: Jesse Barnes

[Intel-gfx] [PATCH 2/5] drm/i915: Rename i915_dp_detect_common to intel_dp_get_dpcd

2011-07-26 Thread Jesse Barnes
On Mon, 25 Jul 2011 23:36:31 -0700 Keith Packard wrote: > This describes the function better, allowing it to be used where the > DPCD value is relevant. > > Signed-off-by: Keith Packard > --- Ah I see you've addressed my previous comment already. :) You can add my Reviewed-b

[Intel-gfx] [PATCH 1/5] drm/i915: Use dp_detect_common in hotplug helper function

2011-07-26 Thread Jesse Barnes
output_reg); > } > > +static enum drm_connector_status > +i915_dp_detect_common(struct intel_dp *intel_dp) Maybe you can fix the prefix of this function while you're at it since it's not i915 or even i9xx specific? -- Jesse Barnes, Intel Open Source Technology Center

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Rename i915_dp_detect_common to intel_dp_get_dpcd

2011-07-26 Thread Jesse Barnes
my Reviewed-by: Jesse Barnes jbar...@virtuousgeek.org to 1/5 and 2/5. -- Jesse Barnes, Intel Open Source Technology Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Intel-gfx] [PATCH 3/5] drm/i915: In intel_dp_init, replace read of DPCD with intel_dp_get_dpcd

2011-07-26 Thread Jesse Barnes
) dev_priv-no_aux_handshake = intel_dp-dpcd[DP_MAX_DOWNSPREAD] Reviewed-by: Jesse Barnes jbar...@virtuousgeek.org Now we just have to enable fast link training in the eDP case (and optionally when we know the DP monitor hasn't changed, just

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Use dp_detect_common in hotplug helper function

2011-07-26 Thread Jesse Barnes
drm_connector_status +i915_dp_detect_common(struct intel_dp *intel_dp) Maybe you can fix the prefix of this function while you're at it since it's not i915 or even i9xx specific? -- Jesse Barnes, Intel Open Source Technology Center ___ dri-devel mailing list dri

Re: [Intel-gfx] [PATCH 5/5] drm/i915: DP_PIPE_ENABLED must check transcoder on CPT

2011-07-26 Thread Jesse Barnes
to that pch port Signed-off-by: Keith Packard kei...@keithp.com --- Ah nice catch. I expect one day we'll have all the chipset and PCH differences coded... Reviewed-by: Jesse Barnes jbar...@virtuousgeek.org -- Jesse Barnes, Intel Open Source Technology Center

Re: [Intel-gfx] [PATCH] drm/i915: Hold struct_mutex during hotplug processing

2011-07-26 Thread Jesse Barnes
was held across the helper too. -- Jesse Barnes, Intel Open Source Technology Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Intel-gfx] [PATCH] drm/i915: Hold struct_mutex during hotplug processing

2011-07-25 Thread Jesse Barnes
ce tell us what to do */ > drm_helper_hpd_irq_event(dev); > } yay, sounds like this will fix Andrew's problem and probably lots of other random DP related failures. Looks like the ->detect function is similarly protected at the call site (though one level up in ->fill_modes),

Re: [Intel-gfx] [PATCH] drm/i915: Hold struct_mutex during hotplug processing

2011-07-25 Thread Jesse Barnes
and probably lots of other random DP related failures. Looks like the -detect function is similarly protected at the call site (though one level up in -fill_modes), so it should be safe. Looks like all the call sites in the link_status function are safe too. Reviewed-by: Jesse Barnes jbar...@virtuousgeek.org

Erroneous package power limit notification since kernel 2.6.39

2011-07-22 Thread Jesse Barnes
On Thu, 30 Jun 2011 08:37:09 +0200 Olaf Freyer wrote: > Am 29.06.2011 00:06, schrieb Jesse Barnes: > > On Wed, 29 Jun 2011 00:01:58 +0200 > > Olaf Freyer wrote: > > > >> Am 28.06.2011 23:18, schrieb Jesse Barnes: > >>> Ok interesting, did

[PATCH 1/4] drm: add plane support

2011-07-22 Thread Jesse Barnes
On Fri, 22 Jul 2011 08:52:52 -0500 Rob Clark wrote: > On Mon, Jun 20, 2011 at 3:11 PM, Jesse Barnes > wrote: > > ?/** > > + * drm_plane_funcs - driver plane control functions > > + * @update_plane: update the plane configuration > > + */ > > +stru

Re: [PATCH 1/4] drm: add plane support

2011-07-22 Thread Jesse Barnes
On Fri, 22 Jul 2011 08:52:52 -0500 Rob Clark robdcl...@gmail.com wrote: On Mon, Jun 20, 2011 at 3:11 PM, Jesse Barnes jbar...@virtuousgeek.org wrote:  /** + * drm_plane_funcs - driver plane control functions + * @update_plane: update the plane configuration + */ +struct

Re: Erroneous package power limit notification since kernel 2.6.39

2011-07-22 Thread Jesse Barnes
On Thu, 30 Jun 2011 08:37:09 +0200 Olaf Freyer aaron...@gmx.net wrote: Am 29.06.2011 00:06, schrieb Jesse Barnes: On Wed, 29 Jun 2011 00:01:58 +0200 Olaf Freyer aaron...@gmx.net wrote: Am 28.06.2011 23:18, schrieb Jesse Barnes: Ok interesting, didn't realize X startup was so GPU

[RFC] Updated DRM plane handling patches

2011-07-21 Thread Jesse Barnes
On Thu, 21 Jul 2011 19:15:24 +0900 Joonyoung Shim wrote: > Hi, > > 2011/6/16 Jesse Barnes : > > On Tue, ?7 Jun 2011 13:07:38 -0700 > > Jesse Barnes wrote: > > > >> This patchset updates the previous one, incorporating the feedback I > >>

[PATCH 1/4] drm: add plane support

2011-07-21 Thread Jesse Barnes
On Thu, 21 Jul 2011 19:30:00 +0900 Joonyoung Shim wrote: > Hi, > > simple questions :) > > 2011/6/21 Jesse Barnes : > > Planes are a bit like half-CRTCs. ?They have a location and fb, but > > don't drive outputs directly. ?Add support for handling them to the core &

Re: [PATCH 1/4] drm: add plane support

2011-07-21 Thread Jesse Barnes
On Thu, 21 Jul 2011 19:30:00 +0900 Joonyoung Shim dofm...@gmail.com wrote: Hi, simple questions :) 2011/6/21 Jesse Barnes jbar...@virtuousgeek.org: Planes are a bit like half-CRTCs.  They have a location and fb, but don't drive outputs directly.  Add support for handling them

Re: [RFC] Updated DRM plane handling patches

2011-07-21 Thread Jesse Barnes
On Thu, 21 Jul 2011 19:15:24 +0900 Joonyoung Shim dofm...@gmail.com wrote: Hi, 2011/6/16 Jesse Barnes jbar...@virtuousgeek.org: On Tue,  7 Jun 2011 13:07:38 -0700 Jesse Barnes jbar...@virtuousgeek.org wrote: This patchset updates the previous one, incorporating the feedback I

[PATCH V2] drm/i915: gracefully bail out when init_clock_gating-pointer is not set

2011-07-02 Thread Jesse Barnes
On Sat, 2 Jul 2011 17:55:53 +0200 Wolfram Sang wrote: > On Mon, Jun 20, 2011 at 10:38:54AM -0700, Jesse Barnes wrote: > > On Mon, 20 Jun 2011 19:36:11 +0200 > > Wolfram Sang wrote: > > > > > Commit 6067aa (drm/i915: split clock gating init into per-chips

Re: [PATCH V2] drm/i915: gracefully bail out when init_clock_gating-pointer is not set

2011-07-02 Thread Jesse Barnes
On Sat, 2 Jul 2011 17:55:53 +0200 Wolfram Sang w.s...@pengutronix.de wrote: On Mon, Jun 20, 2011 at 10:38:54AM -0700, Jesse Barnes wrote: On Mon, 20 Jun 2011 19:36:11 +0200 Wolfram Sang w.s...@pengutronix.de wrote: Commit 6067aa (drm/i915: split clock gating init into per-chipset

[ANNOUNCE] dri2proto 2.6

2011-06-29 Thread Jesse Barnes
Chad Versace (1): Add attachment token DRI2BufferHiz Jesse Barnes (2): Revert "dri2proto: make DRI2 swap event match GLX spec" dri2proto: add a new DRI2BufferSwapComplete struct that matches the spec git tag: dri2proto-2.6 http://xorg.freedesktop.org/archive/indivi

[ANNOUNCE] dri2proto 2.6

2011-06-29 Thread Jesse Barnes
Chad Versace (1): Add attachment token DRI2BufferHiz Jesse Barnes (2): Revert dri2proto: make DRI2 swap event match GLX spec dri2proto: add a new DRI2BufferSwapComplete struct that matches the spec git tag: dri2proto-2.6 http://xorg.freedesktop.org/archive/individual/proto

Erroneous package power limit notification since kernel 2.6.39

2011-06-28 Thread Jesse Barnes
On Wed, 29 Jun 2011 00:01:58 +0200 Olaf Freyer wrote: > Am 28.06.2011 23:18, schrieb Jesse Barnes: > > On Tue, 28 Jun 2011 23:09:45 +0200 > > Olaf Freyer wrote: > >>>>> I'd guess ccab5c82759e2ace74b2e84f82d1e0eedd932571 could be the > >>>&

Erroneous package power limit notification since kernel 2.6.39

2011-06-28 Thread Jesse Barnes
resting, didn't realize X startup was so GPU intensive. :) The patch you reverted will definitely cause the GPU to ramp up its frequency much faster than before, but it sounds like on your system you might also see it with the revert if you run something GPU intensive like nexuiz. The CPU (and by ex

Erroneous package power limit notification since kernel 2.6.39

2011-06-28 Thread Jesse Barnes
6b690f2a > > bdd92c9ad287e03a2ec52f5a89c470cd5caae1c2 > > > > > > > > I'd guess ccab5c82759e2ace74b2e84f82d1e0eedd932571 could be the > > cause. Can you check if the appended revert of that commit makes > > things disappear? > It seems like you guessed perfectly correct - reverting the commit makes > those notifications go away at once. > Without this reverted you see messages? I missed the earlier stuff, what message are you seeing? -- Jesse Barnes, Intel Open Source Technology Center

Re: Erroneous package power limit notification since kernel 2.6.39

2011-06-28 Thread Jesse Barnes
the commit makes those notifications go away at once. Without this reverted you see messages? I missed the earlier stuff, what message are you seeing? -- Jesse Barnes, Intel Open Source Technology Center ___ dri-devel mailing list dri-devel

<    1   2   3   4   5   6   7   8   9   >