Re: [RFC PATCH v2 2/3] accel: add dedicated minor for accelerator devices

2022-11-02 Thread Jiho Chu
stub_open(struct inode *inode, struct file *filp) > { > - DRM_DEBUG("Operation not supported"); > + const struct file_operations *new_fops; > + struct drm_minor *minor; > + int err; > + > + DRM_DEBUG("\n"); It seems useless. Thanks. Jiho Chu

Re: [RFC PATCH 3/3] drm: add dedicated minor for accelerator devices

2022-10-28 Thread Jiho Chu
On Wed, 26 Oct 2022 09:38:13 +0300 Oded Gabbay wrote: > On Tue, Oct 25, 2022 at 9:43 AM Jiho Chu wrote: > > > > > > On Sun, 23 Oct 2022 00:46:22 +0300 > > Oded Gabbay wrote: > > > > > diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_dr

Re: [RFC PATCH 3/3] drm: add dedicated minor for accelerator devices

2022-10-25 Thread Jiho Chu
*/ > dev->driver_features = ~0u; > > + if (drm_core_check_feature(dev, DRIVER_COMPUTE_ACCEL) && > + (drm_core_check_feature(dev, DRIVER_RENDER) || > + drm_core_check_feature(dev, DRIVER_MODESET))) { > + > + DRM_ERROR("DRM driver can't be both a compute acceleration and > graphics driver\n"); > + return -EINVAL; > + } > + It's fine for the device only for acceleration, but can't graphic devices have acceleration feature? Thanks, Jiho Chu

Re: New subsystem for acceleration devices

2022-08-11 Thread Jiho Chu
e once we know where things are heading. As I said, I > imagine it can take a few weeks. > > Thanks, > Oded > Hi Oded, Thanks for sharing your code, it looks good start from basic drm code. I hope the discussion makes better result. Thanks, Jiho Chu