On 1/13/21, 9:50 AM, Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/video/fbdev/s3c-fb.c: In function ‘s3c_fb_probe_win’:
> drivers/video/fbdev/s3c-fb.c:1176:28: warning: variable ‘var’ set but not
> used [-Wunused-but-set-variable]
>
>
fbdev/s3c-fb.c:1142: warning: Function parameter or member
> 'sfb' not described in 's3c_fb_release_win'
> drivers/video/fbdev/s3c-fb.c:1172: warning: Function parameter or member
> 'win_no' not described in 's3c_fb_probe_win'
>
> Cc: Jingoo Han
Acked-by: Jingoo Han
Thank you.
>
> - TI LP8727 charger driver,
> - TI LP8788 MFD (ADC, LEDs, charger and regulator) drivers.
>
> Signed-off-by: Krzysztof Kozlowski
> Cc: Dan Murphy
> Acked-by: Dan Murphy
> Acked-by: Jonathan Cameron
> Acked-by: Sebastian Reichel
Acked-by
ewed-by: Emil Velikov
> Cc: Lee Jones
> Cc: Daniel Thompson
> Cc: Jingoo Han
It looks good!
Reviewed-by: Jingoo Han
For the rebase, if you don't know which branch of maintainer's git can be used,
linux-next tree [1] is useful. The linux-next git collects all next branches
from
ot
pson
> Cc: Jingoo Han
Acked-by: Jingoo Han
Best regards,
Jingoo Han
> Reviewed-by: Sam Ravnborg
> Reviewed-by: Daniel Thompson
> Acked-by: Lee Jones
> Signed-off-by: Noralf Trønnes
> ---
> drivers/video/backlight/backlight.c | 21 +
> include/lin
creens. :(
> >
> > I guess... although the Thinkpad code hasn't added any standard
> > interfaces (no other laptop should be placing controls for a privacy
> > screen in /proc/acpi/ibm/... ). Maybe its not too late.
>
> There's new interface for controlling privac
On 9/4/19, 7:57 AM, YueHaibing wrote:
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
>
> Reported-by: Hulk Robot
> Signed-off-by: YueHaibing
>
Acked-by: Jingoo Han
>
> ---
> drivers/video/fbdev/s3c-fb.c |
On 6/27/19, 9:58 PM, Bartlomiej Zolnierkiewicz wrote:
>
> Use ->screen_buffer instead of ->screen_base to fix sparse warnings.
>
> [ Please see commit 17a7b0b4d974 ("fb.h: Provide alternate screen_base
> pointer") for details. ]
>
> Reported-by: kbuild
On 6/14/19, 11:47 PM, Bartlomiej Zolnierkiewicz wrote:
>
> Fix error code from -ENOENT to -ENOMEM.
>
> Cc: Jingoo Han
Acked-by: Jingoo Han
Best regards,
Jingoo Han
> Signed-off-by: Bartlomiej Zolnierkiewicz
> ---
> drivers/video/fbdev/s3c-fb.c |2 +-
> 1 file ch
On 6/14/19, 11:46 PM, Bartlomiej Zolnierkiewicz wrote:
>
> Add COMPILE_TEST support to s3c-fb driver for better compile
> testing coverage.
>
> Cc: Jingoo Han
Acked-by: Jingoo Han
> Signed-off-by: Bartlomiej Zolnierkiewicz
> ---
> drivers/video/fbdev/Kconfig |3
person who have
an experience to send patches to Linux mailing-list.
Best regards,
Jingoo Han
>
> pm8941-wled.c driver is supporting the WLED peripheral
> on pm8941. Rename it to qcom-wled.c so that it can support
> WLED on multiple PMICs.
>
> Signed-off-by: Kiran Gunda <
> -Original Message-
> From: Krzysztof Kozlowski <k...@kernel.org>
> Sent: Monday, April 30, 2018 1:30 PM
> To: Lee Jones <lee.jo...@linaro.org>; Daniel Thompson
> <daniel.thomp...@linaro.org>; Jingoo Han <jingooh...@gmail.com>;
> Bartlomie
Makefile| 1 -
> drivers/video/backlight/s6e63m0.c | 857
>
Acked-by: Jingoo Han <jingooh...@gmail.com>
Best regards,
Jingoo Han
[.]
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
gned. And total activity in the backlight subsystem is miniscule
> compared to drm overall.
>
> Cc: Lee Jones <lee.jo...@linaro.org>
> Cc: Daniel Thompson <daniel.thomp...@linaro.org>
> Cc: Jingoo Han <jingooh...@gmail.com>
> Acked-by: Daniel Thompson <danie
s.
>
> Cc: Lee Jones <lee.jo...@linaro.org>
> Cc: Daniel Thompson <daniel.thomp...@linaro.org>
> Cc: Jingoo Han <jingooh...@gmail.com>
> Cc: Meghana Madhyastha <meghana.madhyas...@gmail.com>
> Acked-by: Daniel Thompson <daniel.thomp...@linaro.org>
&g
com>
> Tested-by: Marek Szyprowski <m.szyprow...@samsung.com>
> Reviewed-by: Archit Taneja <arch...@codeaurora.org>
Acked-by: Jingoo Han <jingooh...@gmail.com>
Best regards,
Jingoo Han
> ---
>
> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 7 ++
y: Enric Balletbo i Serra <enric.balle...@collabora.com>
> Tested-by: Marek Szyprowski <m.szyprow...@samsung.com>
> Reviewed-by: Heiko Stuebner <he...@sntech.de>
> Reviewed-by: Archit Taneja <arch...@codeaurora.org>
Acked-by: Jingoo Han <jingooh...@gmail.com
> Signed-off-by: Enric Balletbo i Serra <enric.balle...@collabora.com>
> Tested-by: Marek Szyprowski <m.szyprow...@samsung.com>
> Reviewed-by: Archit Taneja <arch...@codeaurora.org>
Acked-by: Jingoo Han <jingooh...@gmail.com>
Best regards,
Jingoo Han
> ---
>
>
@collabora.com>
> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com>
> Signed-off-by: Enric Balletbo i Serra <enric.balle...@collabora.com>
> Tested-by: Marek Szyprowski <m.szyprow...@samsung.com>
> Reviewed-by: Archit Taneja <arch...@codeaurora.org>
Acked-by: J
o i Serra <enric.balle...@collabora.com>
> Tested-by: Marek Szyprowski <m.szyprow...@samsung.com>
> Reviewed-by: Archit Taneja <arch...@codeaurora.org>
Acked-by: Jingoo Han <jingooh...@gmail.com>
Best regards,
Jingoo Han
> ---
>
> .../gpu/drm/bridge/a
ajda <a.ha...@samsung.com>
> Signed-off-by: Enric Balletbo i Serra <enric.balle...@collabora.com>
> Tested-by: Marek Szyprowski <m.szyprow...@samsung.com>
> Reviewed-by: Archit Taneja <arch...@codeaurora.org>
Acked-by: Jingoo Han <jingooh...@gmail.com>
Best reg
On Wednesday, February 14, 2018 7:01 AM wrote:
>
> Exynos5, Exynos4 and S5PV210 platforms have been converted to
> use Device Tree and Exynos DRM driver long time ago. Remove
> dead platform code for these platforms and update Kconfig
> s3c-fb entry accordingly.
>
> Cc
makes sense to cross-post patches and keep
> > aligned. And total activity in the backlight subsystem is miniscule
> > compared to drm overall.
> >
> > Cc: Lee Jones <lee.jo...@linaro.org>
> > Cc: Daniel Thompson <daniel.thomp...@linaro.org>
> > C
perator "sizeof" to make the corresponding size
> determination a bit safer according to the Linux coding style convention.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
Acked-by: Jing
ted by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
Acked-by: Jingoo Han <jingooh...@gmail.com>
Best regards,
Jingoo Han
> ---
> drivers/video/fbdev/s3c-fb.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
&g
76:2: warning: Value stored to 'len'
> is never read
>
> Signed-off-by: Colin Ian King <colin.k...@canonical.com>
Acked-by: Jingoo Han <jingooh...@gmail.com>
Thank you for sending the patch.
It looks good.
Best regards,
Jingoo Han
> ---
> drivers/video/backlight/
e struct pointer, adjusting their users at the same
> time to avoid breaking the compilation.
>
> Signed-off-by: Tomasz Figa <tf...@chromium.org>
> Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com>
Acked-by: Jingoo
e struct pointer, adjusting their users at the same
> time to avoid breaking the compilation.
>
> Signed-off-by: Tomasz Figa <tf...@chromium.org>
> Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com>
> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com>
Acked-by: Jingoo
d
link count
drm: bridge: analogix/dp: dynamic parse sync_pol & interlace & dynamic_range
ARM: dts: exynos/dp: remove some properties that deprecated by analogix_dp
driver
drm: bridge: analogix/dp: add max link rate and lane count limit for RK3288
drm: bridge: analog
On Thursday, December 24, 2015 10:23 AM, Yakir Yang wrote:
>
> Hi Jingoo,
>
> Okay, fine, I would drop this patch, until I found the the root cause.
OK, I see.
Best regards,
Jingoo Han
>
> - Yakir
>
> On 12/23/2015 11:10 PM, Jingoo Han wrote:
> > On Wednes
On Wednesday, December 23, 2015 3:01 PM, Yakir Yang wrote:
>
> Hi Jingoo,
>
> On 12/23/2015 12:24 PM, Yakir Yang wrote:
> > Hi Jingoo,
> >
> > On 12/22/2015 08:26 PM, Jingoo Han wrote:
> >> On Wednesday, December 16, 2015 12:58 PM, Yakir Yang wrote:
&g
10;
> usleep_range(10, 11);
If there is NO new wait time value from DT file, the default value '10' is
used for sleep.
But, if there is new wait time value from DT file, new wait time value
can be used for sleep.
usleep_range(dp->wait_time_aux, dp->wait_time_aux + 1);
What I want to say is that there should be NO effect on Exynos platform,
because of the hardware bug of Rockchip platform.
Best regards,
Jingoo Han
> }
>
> --
> 1.9.1
out_loop++;
> - if (DP_TIMEOUT_LOOP_COUNT < timeout_loop) {
> + if (DP_TIMEOUT_LOOP_COUNT * 10 < timeout_loop) {
No, I hate this coding.
analogix_dp_reg.c is the common code that can be shared by various SoCs.
Please, find another way.
bf8
> --- /dev/null
> +++ b/drivers/phy/phy-rockchip-dp.c
> @@ -0,0 +1,151 @@
> +/*
> + * Rockchip DP PHY driver
> + *
> + * Copyright (C) 2015 FuZhou Rockchip Co., Ltd.
> + * Author: Yakir Yang <ykk@@rock-chips.com>
> + *
> + * This program is free soft
Javier Martinez Canillas
Reviewed-by: Jingoo Han < jingoohan1 at gmail.com >
Best regards,
Jingoo Han
> ---
> Changes in v11: None
> Changes in v10: None
> Changes in v9: None
> Changes in v8: None
> Changes in v7: None
> Changes in v6:
> - Fix Peach Pit hpd pro
gt; @@ -21,8 +21,9 @@
> #define MAX_EQ_LOOP 5
>
> enum link_rate_type {
> - LINK_RATE_1_62GBPS = 0x06,
> - LINK_RATE_2_70GBPS = 0x0a
> + LINK_RATE_1_62GBPS = DP_LINK_BW_1_62,
> + LINK_RATE_2_70GBPS = DP_LINK_BW_2_7,
> + LINK_RATE_5_40GBPS = DP_LINK_BW_5_4,
Then, how about removing 'enum link_rate_type'?
If DP_LINK_BW_* are used, LINK_RATE_* are not necessary.
Best regards,
Jingoo Han
> };
>
> enum link_lane_count_type {
> --
> 1.9.1
sted-by: Javier Martinez Canillas
Acked-by: Jingoo Han
Best regards,
Jingoo Han
> ---
> Changes in v11: None
> Changes in v10: None
> Changes in v9: None
> Changes in v8: None
> Changes in v7: None
> Changes in v6: None
> Changes in v5:
> - Resequence this patch after an
CC list. I don't understand
why you removed them from CC list.
Kukjin Kim
Krzysztof Kozlowski
Without their Ack, you will not change the codes of ARM Exynos Architecture.
Best regards,
Jingoo Han
>
> Best regards,
> Krzysztof
>
>
>>
>>
>>> Signed-off-by: Y
On 2015. 8. 21., at PM 7:01, Yakir Yang wrote:
>
> Hi Jingoo,
>
>> å¨ 2015/8/21 16:20, Jingoo Han åé:
>>> On 2015. 8. 19., at PM 11:48, Yakir Yang wrote:
>>
>> .
>>
>>> .../bindings/video/analogix_dp-rockchip.txt| 83
kefile|2 +-
> drivers/gpu/drm/exynos/analogix_dp-exynos.c| 347 +
Would you change this file name to "exynos_dp.c"?
Best regards,
Jingoo Han
> drivers/gpu/drm/exynos/exynos_dp_core.c| 1416
> drivers/
On 2015. 8. 19., at PM 11:52, Yakir Yang wrote:
>
What is the reason to make this patch?
Please make commit message including the reason.
Best regards,
Jingoo Han
> Signed-off-by: Yakir Yang
> ---
> Changes in v3:
> - move dp hpd detect to connector detect function.
>
guration of link rate and link
count
Best regards,
Jingoo Han
> so we don't need to config those repeatly after training finished, just
> remove them out.
>
> Beside Display Port 1.2 already support 5.4Gbps link rate, the maximum sets
> would change from {1.62Gbps, 2.7Gbps}
On 2015. 8. 20., at PM 3:23, Yakir Yang wrote:
>
> Hi Jingoo & Archit,
>
>
>> On 08/20/2015 12:54 AM, Jingoo Han wrote:
>>> On 2015. 8. 20., at PM 1:29, Archit Taneja
>>> wrote:
>>> Hi,
>>>
>>>> On 08/19/2015 08:18 P
uld not be harmful effect on the existing
Exynos boards, due to unrelated reasons.
Best regards,
Jingoo Han
> Signed-off-by: Yakir Yang
> ---
> Changes in v3: None
> Changes in v2: None
>
> drivers/gpu/drm/bridge/analogix_dp_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deleti
get panel node.
>> - Add the new function point analogix_dp_platdata.get_modes init.
>> - Take Heiko suggest, add rockchip dp phy driver,
>> collect the phy clocks and power control.
>> - Add "analogix,need-force-hpd" to indicate whether driver need foce
>> hpd when h
ve to review the code carefully, as others did.
I also cannot find the exact IP name. The "analogix" may be the vendor name
of this IP.
Best regards,
Jingoo Han
>
> Beyond that, there are three light registers setting differents bewteen
> exynos and rk3288.
> 1. RK3288 have fi
vers/gpu/drm/bridge/analogix_dp_core.c
> @@ -1,7 +1,8 @@
> /*
> - * Samsung SoC DP (Display Port) interface driver.
> + * Analogix Core DP (Display Port) interface driver.
> *
> * Copyright (C) 2012 Samsung Electronics Co., Ltd.
> + * Copyright (C) FuZhou Rockchip Electron
ynos_dp_core.c
> b/drivers/gpu/drm/exynos/exynos_dp_core.c
> index a8097a4..aa99e23 100644
> --- a/drivers/gpu/drm/exynos/exynos_dp_core.c
> +++ b/drivers/gpu/drm/exynos/exynos_dp_core.c
> @@ -3,6 +3,7 @@
> *
> * Copyright (C) 2012 Samsung Electronics Co., Ltd.
> * Author:
> Don't pollute the dmesg with EDID read success message as an error.
> Printing as debug should be fine.
>
> Signed-off-by: Krzysztof Kozlowski
Right, dev_err() is not right.
Thank you for sending the patch.
Acked-by: Jingoo Han
Best regards,
Jingoo Han
> ---
> driv
may now be changed to depend on
> CONFIG_PM.
>
> Replace CONFIG_PM_RUNTIME with CONFIG_PM in 4 files under
> gpu/drm/exynos/.
>
> Signed-off-by: Rafael J. Wysocki
Reviewed-by: Jingoo Han
Best regards,
Jingoo Han
> ---
>
> Note: This depends on commit b2b49ccbdd
the same to dp-phy
> > node.
> >
> > Signed-off-by: Vivek Gautam
> > Reviewed-by: Jingoo Han
> > Tested-by: Javier Martinez Canillas
> > Cc: Kukjin Kim
>
> Any opinions about $subject?
>
> This patch is -rc material since is needed after commit a5e
nt exynos_dp_probe(struct platform_device
> > *pdev)
> > exynos_drm_component_del(>dev,
> >
> > EXYNOS_DEVICE_TYPE_CONNECTOR);
> >
> > +free_dp:
> > + devm_kfree(dev, dp);
&
autam
> Cc: Inki Dae
> Cc: Jingoo Han
Acked-by: Jingoo Han
Best regards,
Jingoo Han
> ---
>
> Changes from V2:
> - Moved devm_phy_get() call out of exynos_dp_dt_parse_phydata() to
>exynos_dp_bind() function and,
>removed exynos_dp_dt_parse_phydata() fun
On Thursday, October 30, 2014 10:24 PM, Vivek Gautam wrote:
>
> DP PHY now require pmu-system-controller to handle PMU register
> to control PHY's power isolation. Adding the same to dp-phy
> node.
>
> Signed-off-by: Vivek Gautam
> Cc: Jingoo Han
Reviewed-by: Jingoo Han
d long time ago.
However, it was not removed for DT compatibility.
I think that now these old DT properties can be removed.
I added some comments below.
>
> Signed-off-by: Vivek Gautam
> Cc: Inki Dae
> Cc: Jingoo Han
> ---
>
> Changes from V1:
> - Reworked error
On Thursday, August 28, 2014 1:33 PM, Sonika Sonika wrote:
> On 8/28/2014 6:25 AM, Jingoo Han wrote:
> > On Friday, August 08, 2014 7:54 PM, Sonika Jindal wrote:
> >>
> >> From: Sonika Jindal
> >>
> >> Rename the defines to have levels instead
s a rule when submitting patches.
Please, fix it as follows.
+ buf[lane] = DP_TRAIN_PRE_EMPHASIS_LEVEL_0|
+ DP_TRAIN_VOLTAGE_SWING_LEVEL_0;
Best regards,
Jingoo Han
>
> retval = exynos_dp_write_bytes_to_dpcd(dp, DP_TRAINING_LANE0_SET,
> lane_count, buf);
> --
> 1.7.10.4
acros for each value seems isn't either.
> >
> I feel _LEVEL_* makes it more readable and since there are only 4 values
> possible, it is ok to have 4 different macros for readability purpose.
> What do you think?
(+cc Damien Lespiau)
Personally, I al
]
Signed-off-by: Jingoo Han
---
drivers/gpu/drm/sti/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/sti/Kconfig b/drivers/gpu/drm/sti/Kconfig
index 2d9d4252d598..bc7d9347ac89 100644
--- a/drivers/gpu/drm/sti/Kconfig
+++ b/drivers/gpu/drm/sti/Kconfig
@@ -1,6 +1,7 @@
config
as you said at '[PATCH 0/6] Rename DP
training vswing/pre-emph defines'.
Best regards.
Jingoo Han
>
> Signed-off-by: Sonika Jindal
> ---
> include/drm/drm_dp_helper.h | 16
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/include/
N update can be performed after VIDCON0 update. If yes the
> > solution of the whole problem
> I will check this.
>
> > seems to be simple:
> > - fimd should provide function fimd_set_dp_clk_gate or sth similar,
> > - this function should be called in exynos_dp_poweron/exynos_dp_poweroff.
> > I hope I have not missed anything this time.
> But, it won't look good to export a FIMD function which sets a FIMD register,
> and call it in DP driver!
> What does Inki/Jingoo have to say about this?
I agree with Ajay Kumar's opinion.
It doesn't look good to export the function to set FIMD register
and call it by DP driver.
Best regards,
Jingoo Han
>
> Regards,
> Ajay
>
[]
On Friday, June 27, 2014 7:12 PM, Ajay Kumar wrote:
>
> Add the missing setting for DP CLKCON register.
>
> This register is present on Exynos5 based FIMD controllers,
> and needs to be set if we are using DP.
>
> Signed-off-by: Ajay Kumar
Reviewed-by: Jingoo Han
Bes
n V1 patch.
Reviewed-by: Jingoo Han
Best regards,
Jingoo Han
> ---
> Changes since V1:
> - Remove usage of driver_data to configure DP CLKCON register
> drivers/gpu/drm/exynos/exynos_dp_core.c | 2 ++
> drivers/gpu/drm/exynos/exynos_drm_drv.h | 8
> drivers/gpu/drm/exynos
xynos5 should be fine.
No, it should be selectable. Even some exynos5 based boards use MIPI LCD.
>
> Arndale and Arndale-Octa have MIPI/DSI interface with MIPI/LVDS bridge.
>
> >
> > Inki/Andrej - Shall I add it as an optional DT property?
>
> No, property is redundant.
/lkml/2014/6/11/26
[2] https://lkml.org/lkml/2014/6/11/649
Best regards,
Jingoo Han
>
>Wolfram
>
>
> Tushar Behera (2):
> DRM: Armada: Use devm_ioremap_resource
> lib: devres: Remove deprecated devm_request_and_ioremap
>
> Wolfram Sang (1):
lper_hpd_irq_event() is called, which in turns calls
> exynos_dpi_detect(), which dereferences ctx->panel without a check,
> causing a NULL pointer derefrence.
>
> This patch fixes the issue by adding necessary NULL pointer check.
>
> Signed-off-by: Tomasz Figa
(+cc Inki Dae)
On Sunday, June 15, 2014 9:11 AM, Martin Kepplinger wrote:
>
> Fix a sparse warning: ttm_bo_reserve()'s last argument is a
> pointer to a struct, so use NULL as nullpointer.
>
> Signed-off-by: Martin Kepplinger
Reviewed-by: Jingoo Han
Best regards,
Jingoo Han
> ---
>
According to the header comment in the source file, the driver is
licensed under GPL v2, so update MODULE_LICENSE() to match that.
Signed-off-by: Jingoo Han
---
drivers/gpu/drm/exynos/exynos_dp_core.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos
The exynos_hdmi.h has been used for the dedicated i2c drivers
that were already removed. Thus, the unnecessary exynos_hdmi.h
should be removed.
Signed-off-by: Jingoo Han
---
drivers/gpu/drm/exynos/exynos_hdmi.h | 23 ---
1 file changed, 23 deletions(-)
delete mode 100644
drivers/gpu/drm/exynos/exynos_hdmi.h' was not
removed yet. Thus, additional patch to remove this
'exynos_hdmi.h' should be submitted. Thank you.
[1]
http://git.kernel.org/cgit/linux/kernel/git/daeinki/drm-exynos.git/commit/?h=exynos-drm-next=73c0a75ca9919c12525fd02eb49f9c3a34e0
d
On Thursday, May 29, 2014 2:56 PM, Sachin Kamat wrote:
>
> PTR_ERR_OR_ZERO simplifies the code.
>
> Signed-off-by: Sachin Kamat
Acked-by: Jingoo Han
Best regards,
Jingoo Han
> ---
> drivers/gpu/drm/exynos/exynos_dp_core.c |5 +
> 1 file changed, 1 inse
Use devm_ioremap_resource() because devm_request_and_ioremap() is
obsoleted by devm_ioremap_resource().
Signed-off-by: Jingoo Han
---
drivers/gpu/drm/armada/armada_crtc.c |8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/armada/armada_crtc.c
b
ers
> > directly on both postings.
> >
> > What may be helpful for them is to hear from you if you're ok with the
> > acpi-video bits which are actually going to use this, since those will
> > be the only user of the new backlight api (for now).
>
> I'm happy to app
Thank you.
Reviewed-by: Jingoo Han
Best regards,
Jingoo Han
> ---
> include/drm/drm_dp_helper.h | 78
> +
> 1 file changed, 78 insertions(+)
>
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index c
On Thursday, May 22, 2014 1:59 PM, Sachin Kamat wrote:
>
> Silences the following warning:
> WARNING: space prohibited before semicolon
>
> Signed-off-by: Sachin Kamat
Acked-by: Jingoo Han
Best regards,
Jingoo Han
> ---
> drivers/gpu/drm/exynos/exynos_dp_reg.c |2
nd removed. Actually, marking it as deprecated looks more urgent.
Thanks.
Best regards,
Jingoo Han
>
> Thierry
en 'DP MST' and '1.2 MST'?
If there is no difference, would you use the same comment
as below?
+# define DP_DOWN_REP_MSG_RDY (1 << 4) /* 1.2 MST */
+# define DP_UP_REQ_MSG_RDY (1 << 5) /* 1.2 MST */
Best regards,
Jingoo Han
[.]
On Tuesday, April 22, 2014 4:14 PM, Jingoo Han wrote:
> On Tuesday, April 22, 2014 7:39 AM, Ajay Kumar wrote:
> >
> > From: Andrew Bresticker
> >
> > Certain bridge chips use a GPIO to indicate the cable status instead
> > of the I_DP_HPD pin. This adds
On Wednesday, May 07, 2014 8:46 PM, Jingoo Han wrote:
>
> drm_crtc.h is already included by exynos_dp_core.h.
Please ignore this patch.
I think that it looks good to include this header directly,
even though exynos_dp_core.h includes this header.
It is not sure that drm_crtc.h header inc
drm_crtc.h is already included by exynos_dp_core.h.
Signed-off-by: Jingoo Han
---
drivers/gpu/drm/exynos/exynos_dp_core.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c
b/drivers/gpu/drm/exynos/exynos_dp_core.c
index 92cfbb3..3c15e89 100644
Use DPCD defines of drm_dp_helper.h; thus, duplicated DPCD defines
of exynos_dp_core.h can be removed. Also, DP_TEST_EDID_CHECKSUM
define is added to drm_dp_helper.h. There is no functional change.
Signed-off-by: Jingoo Han
---
drivers/gpu/drm/exynos/exynos_dp_core.c | 98
ert the slp gpio
> + * to lower power.
> + */
> + if (gpio_is_valid(ps_bridge->gpio_slp_n))
> + gpio_set_value(ps_bridge->gpio_slp_n, 0);
> +
> + drm_panel_post_disable(ps_bridge->panel);
> + if (ps_bridge->v12)
> + regulator_disable(ps_bridge->v12);
> +
> + /*
> + * Sleep for at least the amount of time that it takes the power rail to
> + * fall to prevent asserting the rst gpio from doing anything.
> + */
> + usleep_range(PS8622_POWER_FALL_T16_MAX_US,
> + 2 * PS8622_POWER_FALL_T16_MAX_US);
> + if (gpio_is_valid(ps_bridge->gpio_rst_n))
> + gpio_set_value(ps_bridge->gpio_rst_n, 0);
> +
> + msleep(PS8622_POWER_OFF_T17_MS);
> +
> +out:
> + mutex_unlock(_bridge->enable_mutex);
> +}
> +
> +static void ps8622_post_disable(struct drm_bridge *bridge)
> +{
> +}
How about just removing this empty function?
[.]
Best regards,
Jingoo Han
ig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -30,4 +30,13 @@ config DRM_PANEL_S6E8AA0
> select DRM_MIPI_DSI
> select VIDEOMODE_HELPERS
>
> +config DRM_PANEL_EXYNOS_DP
> + tristate "support for DP panels"
It looks very general. Please fix it as be
ed-off-by: Rahul Sharma
> Signed-off-by: Ajay Kumar
Acked-by: Jingoo Han
Best regards,
Jingoo Han
> ---
> Changes since V1:
> Address reiew comments from Jingoo Han
>
> .../devicetree/bindings/video/exynos_dp.txt|4 ++
> drivers/gpu/drm/exynos/exynos_d
Use %pad for dma_addr_t, because a dma_addr_t type can vary
based on build options. So, it prevents possible build warnings
in printks.
Signed-off-by: Jingoo Han
---
drivers/gpu/drm/exynos/exynos_drm_dmabuf.c |2 +-
drivers/gpu/drm/exynos/exynos_drm_vidi.c |2 +-
2 files changed, 2
On Saturday, April 19, 2014 4:43 AM, Ajay kumar wrote:
> On Fri, Apr 18, 2014 at 2:17 PM, Jingoo Han wrote:
> > On Wednesday, April 16, 2014 11:33 PM, Ajay Kumar wrote:
[.]
> > > +struct panel_exynos_dp {
> > > + struct drm_panelbase;
> > > +
On Saturday, April 19, 2014 4:51 AM, Ajay Kumar wrote:
> On Fri, Apr 18, 2014 at 2:27 PM, Jingoo Han wrote:
> > On Wednesday, April 16, 2014 11:33 PM, Ajay Kumar wrote:
[.]
> > > +#ifdef CONFIG_DRM_PANEL_EXYNOS_DP
> > > + platform_driver_
;drm_dev, encoder, dp->drm_panel);
> + if (ret) {
> + /* Also set "dp->drm_panel = NULL" so that we don't end up
> + * controlling panel power both in exynos_dp and bridge
> + * DPMS routines.
> + */
Please fix
"samsung,exynos-dp-panel");
> + if (panel_node) {
> + dp->drm_panel = of_drm_find_panel(panel_node);
> + if (!dp->drm_panel) {
> + of_node_put(panel_node);
> + return -ENODEV;
> +
gt; +#endif
Please add platform_driver_unregister() to exynos_drm_platform_remove(),
as well as exynos_drm_platform_probe().
Best regards,
Jingoo Han
> +
> #ifdef CONFIG_DRM_EXYNOS_IPP
> exynos_platform_device_ipp_unregister();
> err_unregister_ipp:
> diff --git a/drivers/gp
gt; + if (!IS_ERR_OR_NULL(dp_panel->lcd_fet)) {
> + regulator_disable(dp_panel->lcd_fet);
> + enable_delay = true;
> + }
> +
> + if (enable_delay)
> + msleep(dp_panel->power_down_delay);
> +
> + dp_panel->enabled = fa
eg & PLUG)
+ return DP_IRQ_TYPE_HP_CABLE_IN;
+
+ if (reg & HPD_LOST)
+ return DP_IRQ_TYPE_HP_CABLE_OUT;
+
+ if (reg & HOTPLUG_CHG)
+ return DP_IRQ_TYPE_HP_CHANGE;
+ }
return DP_IRQ_T
In the case of that only one branch of a conditional statement is
a single statement, braces are added to both branches.
Signed-off-by: Jingoo Han
---
drivers/gpu/drm/exynos/exynos_drm_rotator.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos
devm_ioremap_resource() retunrs an error pointer, not NULL. Thus,
the result should be checked with IS_ERR().
Signed-off-by: Jingoo Han
---
drivers/gpu/drm/exynos/exynos_drm_dsi.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han
---
drivers/gpu/drm/exynos/exynos_dp_core.c |8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/exynos
Make local symbols static, because these are used only in this
file.
Signed-off-by: Jingoo Han
---
drivers/gpu/drm/exynos/exynos_hdmi.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c
b/drivers/gpu/drm/exynos/exynos_hdmi.c
index
Make local symbole static, because this is used only in this file.
Signed-off-by: Jingoo Han
---
drivers/gpu/drm/exynos/exynos_drm_fbdev.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
b/drivers/gpu/drm/exynos
Make local symbol static, because this is used only in this file.
Signed-off-by: Jingoo Han
---
drivers/gpu/drm/exynos/exynos_drm_dpi.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_dpi.c
b/drivers/gpu/drm/exynos/exynos_drm_dpi.c
index
This patches fix Exynos DRM for minor cleanup. This series is based
on exynos-drm-next-todo branch of Inki Dae's tree. [1]
[1] git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git
Jingoo Han (6):
drm/exynos: dpi: make local symbol static
drm/exynos: fb: make local
Recently, Exynos DP driver was moved from drivers/video/exynos/
directory to drivers/gpu/drm/exynos/ directory. So, I update
and add maintainer entry for Exynos DP driver.
Signed-off-by: Jingoo Han
---
MAINTAINERS |6 ++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b
1 - 100 of 152 matches
Mail list logo
