est that the xrgb to rgb565 conversion
is working.
IMX/IPUV3 support is not complete, I wasn't able to have etnaviv working on my
board.
But it shows that it can still work on ARM with DMA buffer in this case.
Best regards,
Jocelyn Falempe (6):
drm/format-helper: Add drm_fb_blit_from
()
error: uninitialized symbol 'crtc_state'.
That looks trivial, so you can add:
Acked-by: Jocelyn Falempe
Fixes: fdd591e00a9c ("drm/ssd130x: Add support for the SSD132x OLED controller
family")
Reported-by: Dan Carpenter
Closes:
https://lore.kernel.org/dri-devel/7dd6ca45-8263
On 20/10/2023 14:06, Thomas Zimmermann wrote:
(cc'ing lkml for feedback)
Hi Jocelyn
Am 19.10.23 um 15:55 schrieb Jocelyn Falempe:
We found a regression in v5.10 on real-time server, using the
rt-kernel and the mgag200 driver. It's some really specialized
workload, with <10us late
;)
Fixes: 4862ffaec523 ("drm/mgag200: Move vmap out of commit tail")
Signed-off-by: Jocelyn Falempe
---
drivers/gpu/drm/mgag200/mgag200_mode.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c
b/drivers/gpu/drm/mgag200/mgag200_mode.c
index a
the one from the
documentation. But I agree it's better to match the documentation.
For the whole series:
Reviewed-by: Jocelyn Falempe
--
Jocelyn
Thomas Zimmermann (12):
drm/ast: Rename AST_IO_AR_PORT_WRITE to AST_IO_VGAARI_W
drm/ast: Rename AST_IO_MISC_PORT_WRITE to AST_IO_VGAMR_W
drm
On 16/10/2023 12:47, Thomas Zimmermann wrote:
Hi
Am 03.10.23 um 16:22 schrieb Jocelyn Falempe:
drm_panic will need the low-level drm_fb__line functions.
It seems like premature optimization to not use drm_fb_blit();
especially since drm_panic is not performance critical.
Also add
On 10/10/2023 15:05, Thomas Zimmermann wrote:
Hi
Am 10.10.23 um 11:33 schrieb Maxime Ripard:
[...]
We also have discussions about kexec/kdump support. Here we'd need to
retrieve the scanout address, forward it to the kexec kernel and put
simpledrm onto that framebuffer until the regular driver
On 10/10/2023 14:59, Daniel Vetter wrote:
On Tue, Oct 10, 2023 at 02:15:47PM +0200, Maxime Ripard wrote:
On Tue, Oct 10, 2023 at 01:29:52PM +0200, Noralf Trønnes wrote:
On 10/10/23 11:25, Maxime Ripard wrote:
On Tue, Oct 10, 2023 at 10:55:09AM +0200, Thomas Zimmermann wrote:
So if I
On 09/10/2023 18:07, Maxime Ripard wrote:
On Mon, Oct 09, 2023 at 04:05:19PM +0200, Jocelyn Falempe wrote:
- I find it risky to completely reconfigure the hardware in a panic handler.
I would expect to only change the format and base address of the
framebuffer. I guess it can fail
On 09/10/2023 13:33, Maxime Ripard wrote:
On Mon, Oct 09, 2023 at 11:48:29AM +0200, Jocelyn Falempe wrote:
On 09/10/2023 10:28, Maxime Ripard wrote:
Hi,
On Mon, Oct 09, 2023 at 09:47:49AM +0200, Jocelyn Falempe wrote:
On 06/10/2023 18:54, Noralf Trønnes wrote:
On 10/6/23 16:35, Maxime
On 07/10/2023 16:30, Noralf Trønnes wrote:
On 10/3/23 16:22, Jocelyn Falempe wrote:
Add support for the drm_panic module, which displays a message to
the screen when a kernel panic occurs.
Signed-off-by: Jocelyn Falempe
---
drivers/gpu/drm/mgag200/mgag200_drv.c | 24
On 09/10/2023 10:28, Maxime Ripard wrote:
Hi,
On Mon, Oct 09, 2023 at 09:47:49AM +0200, Jocelyn Falempe wrote:
On 06/10/2023 18:54, Noralf Trønnes wrote:
On 10/6/23 16:35, Maxime Ripard wrote:
Hi Jocelyn,
On Thu, Oct 05, 2023 at 11:16:15AM +0200, Jocelyn Falempe wrote:
On 05/10/2023 10
On 07/10/2023 14:38, Noralf Trønnes wrote:
On 10/3/23 16:22, Jocelyn Falempe wrote:
This module displays a user friendly message when a kernel panic
occurs. It currently doesn't contain any debug information,
but that can be added later.
v2
* Use get_scanout_buffer() instead of the drm
On 06/10/2023 18:54, Noralf Trønnes wrote:
On 10/6/23 16:35, Maxime Ripard wrote:
Hi Jocelyn,
On Thu, Oct 05, 2023 at 11:16:15AM +0200, Jocelyn Falempe wrote:
On 05/10/2023 10:18, Maxime Ripard wrote:
Hi,
On Tue, Oct 03, 2023 at 04:22:45PM +0200, Jocelyn Falempe wrote:
diff --git
On 05/10/2023 10:18, Maxime Ripard wrote:
Hi,
On Tue, Oct 03, 2023 at 04:22:45PM +0200, Jocelyn Falempe wrote:
diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h
index 89e2706cac56..e538c87116d3 100644
--- a/include/drm/drm_drv.h
+++ b/include/drm/drm_drv.h
@@ -43,6 +43,7 @@ struct
On 04/10/2023 03:45, nerdopolis wrote:
On Tuesday, October 3, 2023 10:22:44 AM EDT Jocelyn Falempe wrote:
drm_panic will need the low-level drm_fb__line functions.
Also add drm_fb_r1_to_xrgb to render the fonts.
Signed-off-by: Jocelyn Falempe
---
drivers/gpu/drm/drm_format_helper.c
Add support for the drm_panic module, which displays a message to
the screen when a kernel panic occurs.
Signed-off-by: Jocelyn Falempe
---
drivers/gpu/drm/mgag200/mgag200_drv.c | 24
1 file changed, 24 insertions(+)
diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.c
Add support for the drm_panic module, which displays a user-friendly
message to the screen when a kernel panic occurs.
Signed-off-by: Jocelyn Falempe
---
drivers/gpu/drm/tiny/simpledrm.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers/gpu/drm/tiny/simpledrm.c b
)
Signed-off-by: Jocelyn Falempe
---
drivers/gpu/drm/Kconfig | 22 ++
drivers/gpu/drm/Makefile| 1 +
drivers/gpu/drm/drm_drv.c | 8 +
drivers/gpu/drm/drm_panic.c | 413
include/drm/drm_drv.h | 14 ++
include/drm/drm_panic.h | 41
6
drm_panic will need the low-level drm_fb__line functions.
Also add drm_fb_r1_to_xrgb to render the fonts.
Signed-off-by: Jocelyn Falempe
---
drivers/gpu/drm/drm_format_helper.c | 88 ++---
include/drm/drm_format_helper.h | 9 +++
2 files changed, 89
GPU drivers, there might need a flush_scanout_buffer()
function, that should be called after the scanout buffer has been filled ?
Best regards,
Jocelyn Falempe (4):
drm/format-helper: Export line conversion helper for drm_panic
drm/panic: Add a drm panic handler
drm/simpledrm: Add drm_pa
On 28/09/2023 11:30, Thomas Zimmermann wrote:
Am 27.09.23 um 19:22 schrieb Jocelyn Falempe:
This module displays a user friendly message when a kernel panic
occurs. It currently doesn't contain any debug information,
but that can be added later.
v2
* Use get_scanout_buffer() instead
drm_panic will need the low-level drm_fb__line functions.
Signed-off-by: Jocelyn Falempe
---
drivers/gpu/drm/drm_format_helper.c | 3 ++-
include/drm/drm_format_helper.h | 2 ++
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_format_helper.c
b/drivers
Add support for the drm_panic module, which displays a user-friendly
message to the screen when a kernel panic occurs.
Signed-off-by: Jocelyn Falempe
---
drivers/gpu/drm/tiny/simpledrm.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/drivers/gpu/drm/tiny/simpledrm.c b
)
* Add an exclamation mark (Nerdopolis)
v3
* Rework the drawing functions, to write the pixels line by line and
to use the drm conversion helper to support other formats.
(Thomas Zimmermann)
Signed-off-by: Jocelyn Falempe
---
drivers/gpu/drm/Kconfig | 11 ++
drivers/gpu/drm/Makefile
led after the scanout buffer has been filled ?
Best regards,
Jocelyn Falempe (3):
drm/format-helper: Export drm_fb_xrgb_to_rgb565_line
drm/panic: Add a drm panic handler
drm/simpledrm: Add drm_panic support
drivers/gpu/drm/Kconfig | 11 +
drivers/gpu/drm/Makefile|
On 20/09/2023 16:24, Thomas Zimmermann wrote:
Store and instance of struct drm_xfrm_buf in struct simpledrm_device
and keep the allocated memory allocated across display updates. Avoid
possibly reallocating temporary memory on each display update. Instead
preallocate temporary memory during
On 20/09/2023 16:24, Thomas Zimmermann wrote:
DRM's format-conversion helpers require temporary memory. Pass the
buffer from the caller and keep it allocated over several calls. Allow
the caller to preallocate the buffer memory.
The motivation for this patchset is the recent work on a DRM panic
On 19/09/2023 01:19, Noralf Trønnes wrote:
Hi,
On 9/15/23 10:28, Jocelyn Falempe wrote:
This introduces a new drm panic handler, which displays a message when a panic
occurs.
So when fbcon is disabled, you can still see a kernel panic.
This is one of the missing feature, when disabling VT
On 16/09/2023 15:09, nerdopolis wrote:
On Friday, September 15, 2023 4:28:20 AM EDT Jocelyn Falempe wrote:
This introduces a new drm panic handler, which displays a message when a panic
occurs.
So when fbcon is disabled, you can still see a kernel panic.
This is one of the missing feature
)
* Add an exclamation mark (Nerdopolis)
Signed-off-by: Jocelyn Falempe
---
drivers/gpu/drm/Kconfig | 11 ++
drivers/gpu/drm/Makefile| 1 +
drivers/gpu/drm/drm_drv.c | 3 +
drivers/gpu/drm/drm_panic.c | 270
include/drm/drm_drv.h | 14
Add support for the drm_panic module, which displays a user-friendly
message to the screen when a kernel panic occurs.
Signed-off-by: Jocelyn Falempe
---
drivers/gpu/drm/tiny/simpledrm.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/drivers/gpu/drm/tiny/simpledrm.c b
fer()
function, that should be called after the scanout buffer has been filled ?
Best regards,
Jocelyn Falempe (2):
drm/panic: Add a drm panic handler
drm/simpledrm: Add drm_panic support
drivers/gpu/drm/Kconfig | 11 ++
drivers/gpu/drm/Makefile | 1 +
drivers/gpu/
On 12/09/2023 17:57, Michel Dänzer wrote:
On 9/11/23 10:38, Pekka Paalanen wrote:
On Fri, 8 Sep 2023 17:10:46 +0200
Thomas Zimmermann wrote:
Am 08.09.23 um 16:41 schrieb Pekka Paalanen:
On Fri, 8 Sep 2023 15:56:51 +0200
Thomas Zimmermann wrote:
I have a number of concerns. My point it not
On 08/09/2023 17:37, Thomas Zimmermann wrote:
Hi
Am 08.09.23 um 16:48 schrieb Jocelyn Falempe:
On 08/09/2023 15:56, Thomas Zimmermann wrote:
Hi
Am 08.09.23 um 13:16 schrieb Pekka Paalanen:
On Fri, 8 Sep 2023 11:21:51 +0200
Thomas Zimmermann wrote:
Hi
Am 25.08.23 um 16:04 schrieb Jocelyn
On 08/09/2023 15:56, Thomas Zimmermann wrote:
Hi
Am 08.09.23 um 13:16 schrieb Pekka Paalanen:
On Fri, 8 Sep 2023 11:21:51 +0200
Thomas Zimmermann wrote:
Hi
Am 25.08.23 um 16:04 schrieb Jocelyn Falempe:
[...]
+ *
+ * But there are two exceptions only for dumb buffers
On 08/09/2023 15:46, Javier Martinez Canillas wrote:
Thomas Zimmermann writes:
Hello Thomas,
Hi Maxime
Am 08.09.23 um 12:58 schrieb Maxime Ripard:
Hi,
On Fri, Sep 08, 2023 at 11:21:51AM +0200, Thomas Zimmermann wrote:
Am 25.08.23 um 16:04 schrieb Jocelyn Falempe
On 04/09/2023 16:29, Thomas Zimmermann wrote:
Hi Jocelyn,
thanks for moving this effort forward. It's much appreciated. I looked
through the patches and tried the patchset on my test machine.
Thanks for taking the time to review and test it.
Am 09.08.23 um 21:17 schrieb Jocelyn Falempe
After discussions on IRC, the consensus is that the DRM drivers should
avoid software color conversion, and only advertise the formats supported
by hardware.
Update the doc accordingly so that the rule and exceptions are clear for
everyone.
Acked-by: Simon Ser
Signed-off-by: Jocelyn Falempe
On 25/08/2023 14:03, Pekka Paalanen wrote:
On Fri, 25 Aug 2023 10:55:35 +0200
Jocelyn Falempe wrote:
After discussions on IRC, the consensus is that the DRM drivers should
avoid software color conversion, and only advertise the formats supported
by hardware.
Update the doc accordingly so
After discussions on IRC, the consensus is that the DRM drivers should
avoid software color conversion, and only advertise the formats supported
by hardware.
Update the doc accordingly so that the rule and exceptions are clear for
everyone.
Signed-off-by: Jocelyn Falempe
---
drivers/gpu/drm
On 23/08/2023 10:11, Pekka Paalanen wrote:
On Tue, 22 Aug 2023 17:49:08 +0200
Jocelyn Falempe wrote:
On 22/08/2023 10:20, Pekka Paalanen wrote:
On Mon, 21 Aug 2023 17:55:33 +0200
Maxime Ripard wrote:
Hi Pekka,
Thanks for answering
On Fri, Aug 18, 2023 at 04:24:15PM +0300, Pekka
+0200, Jocelyn Falempe wrote:
After discussions on IRC, the consensus is that the DRM drivers should
not do software color conversion, and only advertise the supported formats.
Update the doc accordingly so that the rule and exceptions are clear for
everyone.
Signed-off-by: Jocelyn Falempe
On 13/08/2023 04:20, nerdopolis wrote:
On Wednesday, August 9, 2023 3:17:27 PM EDT Jocelyn Falempe wrote:
This introduces a new drm panic handler, which displays a message when a panic
occurs.
So when fbcon is disabled, you can still see a kernel panic.
This is one of the missing feature
On 10/08/2023 09:45, Maxime Ripard wrote:
Hi
On Mon, Aug 07, 2023 at 03:45:15PM +0200, Jocelyn Falempe wrote:
After discussions on IRC, the consensus is that the DRM drivers should
not do software color conversion, and only advertise the supported formats.
Update the doc accordingly so
On 09/08/2023 18:29, Simon Ser wrote:
Looks good to me.
Thanks for reviewing it.
Maybe the IN_FORMATS prop docs is a better place for this?
you mean to move it here ?:
https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/drm_plane.c#L132
I don't have a preference since it's my
This module displays a user friendly message when a kernel panic
occurs. It currently doesn't contain any debug information,
but that can be added later.
Signed-off-by: Jocelyn Falempe
---
drivers/gpu/drm/Kconfig | 11 ++
drivers/gpu/drm/Makefile| 1 +
drivers/gpu/drm/drm_drv.c
Add support for the drm_panic module, which displays a user-friendly
message to the screen when a kernel panic occurs.
Signed-off-by: Jocelyn Falempe
---
drivers/gpu/drm/tiny/simpledrm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/tiny/simpledrm.c b/drivers/gpu/drm
u think about it.
Best regards,
Jocelyn Falempe (2):
drm/panic: Add a drm panic handler
drm/simpledrm: Add drm_panic support
drivers/gpu/drm/Kconfig | 11 ++
drivers/gpu/drm/Makefile | 1 +
drivers/gpu/drm/drm_drv.c| 3 +
drivers/gpu/drm/drm_panic
After discussions on IRC, the consensus is that the DRM drivers should
not do software color conversion, and only advertise the supported formats.
Update the doc accordingly so that the rule and exceptions are clear for
everyone.
Signed-off-by: Jocelyn Falempe
---
include/uapi/drm/drm_fourcc.h
, and feel free to correct me
if I'm wrong, I may have missed some conversations.
Best regards,
Jocelyn Falempe (1):
drm/fourcc: Add documentation about software color conversion.
include/uapi/drm/drm_fourcc.h | 7 +++
1 file changed, 7 insertions(+)
base-commit
On 01/08/2023 12:25, Thomas Zimmermann wrote:
Hi
Am 01.08.23 um 12:11 schrieb Jocelyn Falempe:
On 28/07/2023 14:12, Roger Sewell wrote:
Thomas, Jocelyn,
JF> I think the culprit is probably this patch:
JF> https://patchwork.freedesktop.org/patch/486242/
JF>
JF> before th
he bandwidth check back
to the connector callback.
Best regards,
--
Jocelyn
Thanks,
Roger.
From f134c822b11f8e8d16c7f72fe8077c58f9ebb1fd Mon Sep 17 00:00:00 2001
From: Jocelyn Falempe
Date: Tue, 1 Aug 2023 11:49:14 +0200
Subject: [PATCH] drm/mgag200: move the memory bandwidth check to
On 28/07/2023 09:45, Thomas Zimmermann wrote:
Hi
Am 27.07.23 um 23:34 schrieb Roger Sewell:
Thomas, Jocelyn,
As a result of the collection of the Xorg logs requested by Thomas, I've
realised that at some long-past point upgrade the 1440x900@60 mode
disappeared, and in order to get it back I
On 27/07/2023 19:24, Roger Sewell wrote:
Thomas,
Could you provide us with the Xorg logs from /var/log/Xorg.0.log ,
please?
Specifically, I'd be interested in different logs from combinations of
the old and new kernel and the old and new userspace.
I've managed to do six of the eight
On 26/07/2023 17:46, Thomas Zimmermann wrote:
Hi
Am 26.07.23 um 10:41 schrieb Jocelyn Falempe:
On 13/07/2023 15:41, Jocelyn Falempe wrote:
Most aspeed devices have a BMC, which allows to remotely see the screen.
Also in the common use case, those servers don't have a display
connected.
So
On 26/07/2023 12:11, Roger Sewell wrote:
Jocelyn,
How can I check for sure whether I am using 24 or 32 bits per pixel
?
The easiest solution if you already rebuilt your kernel is to print
the variable bpp here:
On 13/07/2023 15:41, Jocelyn Falempe wrote:
Most aspeed devices have a BMC, which allows to remotely see the screen.
Also in the common use case, those servers don't have a display connected.
So add a Virtual connector, to reflect that even if no display is
connected, the framebuffer can still
On 25/07/2023 23:31, Roger Sewell wrote:
Thomas,
Thank you for your reply.
Table 10 in the following document says that 1440x900@60Hz is
supported:
https://www.intel.com/content/dam/support/us/en/documents/motherboards/server/s5520ur/sb/e44031012_s5520ur_s5520urt_tps_r1_9.pdf
That manual
On 25/07/2023 21:37, Thomas Zimmermann wrote:
Hi Roger,
thanks for all the information.
Am 24.07.23 um 22:57 schrieb Roger Sewell:
Thomas,
Hello, I'm the user who reported the issue. Definitely happy to help you
sort this out if I can, though my response speed will decrease when term
it.
In mgag200_calculate_mode_bandwidth(), the bandwidth for 1440x900@60 is
30318019, while 24400 * 1024 = 24985600 and 30100 * 1024 = 30822400.
Raising the bandwidth from 24400 to 30100 is enough to allow this mode.
Reported-by: Roger Sewell
Tested-by: Roger Sewell
Signed-off-by: Jocelyn Falempe
---
drivers/gpu
On 11/07/2023 11:20, Jocelyn Falempe wrote:
Jocelyn Falempe (2):
drm/client: Fix memory leak in drm_client_target_cloned
drm/client: Fix memory leak in drm_client_modeset_probe
I just pushed the two patches to drm-misc-fixes, after removing the
useless NULL check of the second patch
: Change check order in ast_astdp_is_connected (Jammy Huang)
Fixes: fae7d186403e ("drm/probe-helper: Default to 640x480 if no EDID on DP")
Signed-off-by: Jocelyn Falempe
Reviewed-by: Thomas Zimmermann
---
drivers/gpu/drm/ast/ast_dp.c| 11 ++
driver
)
Fixes: fae7d186403e ("drm/probe-helper: Default to 640x480 if no EDID on DP")
Signed-off-by: Jocelyn Falempe
---
drivers/gpu/drm/ast/ast_drv.h | 4 +++
drivers/gpu/drm/ast/ast_mode.c | 58 ++
2 files changed, 62 insertions(+)
diff --git a/drivers/g
On 13/07/2023 11:31, Jocelyn Falempe wrote:
On 13/07/2023 11:12, Thomas Zimmermann wrote:
Hi
Am 13.07.23 um 11:05 schrieb Jammy Huang:
[...]
For the BMC connector patch, you know if there is a register setting
I can check to see if a BMC is present or not ?
I think you can use VGA CRD0[7
On 13/07/2023 11:12, Thomas Zimmermann wrote:
Hi
Am 13.07.23 um 11:05 schrieb Jammy Huang:
[...]
For the BMC connector patch, you know if there is a register setting
I can check to see if a BMC is present or not ?
I think you can use VGA CRD0[7] whose definition is as below:
DRAM Initial
On 13/07/2023 10:17, Jocelyn Falempe wrote:
On 13/07/2023 09:00, Jammy Huang wrote:
Hi Jocelyn,
Thanks for your work.
On 2023/7/13 下午 02:40, Jocelyn Falempe wrote:
Aspeed always report the display port as "connected", because it
doesn't set a .detect_ctx callback.
Fix this by
On 13/07/2023 10:32, Michel Dänzer wrote:
On 7/12/23 17:25, Jocelyn Falempe wrote:
On 12/07/2023 17:05, Sui Jingfeng wrote:
On 2023/7/10 16:07, Jocelyn Falempe wrote:
On the other hand, are there any drawback to present a BMC connector even when
the hardware doesn't have
On 13/07/2023 09:00, Jammy Huang wrote:
Hi Jocelyn,
Thanks for your work.
On 2023/7/13 下午 02:40, Jocelyn Falempe wrote:
Aspeed always report the display port as "connected", because it
doesn't set a .detect_ctx callback.
Fix this by providing the proper detect callback for astdp
changed, 21 deletions(-)
looks good to me.
indeed pcim_enable_device() call pci_enable_resources() which set
PCI_COMMAND_MEMORY and PCI_COMMAND_IO flags.
Reviewed-by: Jocelyn Falempe
Best regards,
--
Jocelyn
diff --git a/drivers/gpu/drm/ast/ast_main.c b/drivers/gpu/drm/ast/ast_main.c
)
Fixes: fae7d186403e ("drm/probe-helper: Default to 640x480 if no EDID on DP")
Signed-off-by: Jocelyn Falempe
---
drivers/gpu/drm/ast/ast_drv.h | 4 +++
drivers/gpu/drm/ast/ast_mode.c | 58 ++
2 files changed, 62 insertions(+)
diff --git a/drivers/g
d186403e ("drm/probe-helper: Default to 640x480 if no EDID on DP")
Signed-off-by: Jocelyn Falempe
Reviewed-by: Thomas Zimmermann
---
drivers/gpu/drm/ast/ast_dp.c| 11 ++
drivers/gpu/drm/ast/ast_dp501.c | 37 ++---
drivers/gpu/drm/ast/ast_drv.h
It looks like my SMTP server has lost the second patch, so I'm
re-sending the series.
--
Jocelyn
On 12/07/2023 17:17, Jocelyn Falempe wrote:
Most aspeed devices have a BMC, which allows to remotely see the screen.
Also in the common use case, those servers don't have a display connected
On 12/07/2023 17:05, Sui Jingfeng wrote:
Hi,
I'm here join to the discussion. Because I know a little about aspeed BMC.
On 2023/7/10 16:07, Jocelyn Falempe wrote:
On 07/07/2023 09:30, Thomas Zimmermann wrote:
Hi
Am 06.07.23 um 18:37 schrieb Jocelyn Falempe:
[...]
You could out-comment
)
Fixes: fae7d186403e ("drm/probe-helper: Default to 640x480 if no EDID on DP")
Signed-off-by: Jocelyn Falempe
---
drivers/gpu/drm/ast/ast_drv.h | 4 +++
drivers/gpu/drm/ast/ast_mode.c | 58 ++
2 files changed, 62 insertions(+)
diff --git a/drivers/g
On 12/07/2023 15:55, Thomas Zimmermann wrote:
Hi
Am 12.07.23 um 15:27 schrieb Jocelyn Falempe:
Aspeed always report the display port as "connected", because it
doesn't set a .detect callback.
Fix this by providing the proper detect callback for astdp and dp501.
This also fixes the
)
Fixes: fae7d186403e ("drm/probe-helper: Default to 640x480 if no EDID on DP")
Signed-off-by: Jocelyn Falempe
---
drivers/gpu/drm/ast/ast_drv.h | 4 +++
drivers/gpu/drm/ast/ast_mode.c | 58 ++
2 files changed, 62 insertions(+)
diff --git a/drivers/g
back to the dp/dp501 connector (Jani Nikula)
v3: Use .detect_ctx callback, and refactors (Thomas Zimmermann)
Add a BMC virtual connector
v4: Better indent detect_ctx() functions (Thomas Zimmermann)
Fixes: fae7d186403e ("drm/probe-helper: Default to 640x480 if no EDID on DP")
Signed-off
On 12/07/2023 12:44, Thomas Zimmermann wrote:
Hi,
thanks for this patch.
Am 12.07.23 um 10:35 schrieb Jocelyn Falempe:
Most aspeed devices have a BMC, which allows to remotely see the screen.
Also in the common use case, those servers don't have a display
connected.
So add a Virtual
back to the dp/dp501 connector (Jani Nikula)
v3: Use .detect_ctx callback, and refactors (Thomas Zimmermann)
Add a BMC virtual connector
Fixes: fae7d186403e ("drm/probe-helper: Default to 640x480 if no EDID on DP")
Signed-off-by: Jocelyn Falempe
---
drivers/gpu/drm/ast/ast_dp.c|
to implement a detect_ctx() for the Display port
connector.
Fixes: fae7d186403e ("drm/probe-helper: Default to 640x480 if no EDID on DP")
Signed-off-by: Jocelyn Falempe
---
drivers/gpu/drm/ast/ast_drv.h | 4 ++
drivers/gpu/drm/ast/ast_mode.c | 67 ++
2 fil
2bc/0x4d0 [drm_kms_helper]
drm_client_register+0x169/0x240 [drm]
ast_pci_probe+0x142/0x190 [ast]
local_pci_probe+0xdc/0x180
work_for_cpu_fn+0x4e/0xa0
process_one_work+0x8b7/0x1540
worker_thread+0x70a/0xed0
kthread+0x29f/0x340
ret_from_fork+0x1f/0x30
cc:
Reported-by: Zhang Yi
Signed-off-by: Joce
01>] process_one_work+0x8b7/0x1540
[<3375b17c>] worker_thread+0x70a/0xed0
[<b0d43cd9>] kthread+0x29f/0x340
[<8d770833>] ret_from_fork+0x1f/0x30
unreferenced object 0xff11000333089a00 (size 128):
cc:
Fixes: 1d42bbc8f7f9 ("drm/
Jocelyn Falempe (2):
drm/client: Fix memory leak in drm_client_target_cloned
drm/client: Fix memory leak in drm_client_modeset_probe
drivers/gpu/drm/drm_client_modeset.c | 8
1 file changed, 8 insertions(+)
base-commit: 2f98e686ef59b5d19af5847d755798e2031bee3a
--
2.41.0
On 10/07/2023 08:57, Thomas Zimmermann wrote:
Hi Jocelyn
Am 06.07.23 um 11:58 schrieb Jocelyn Falempe:
Aspeed always report the display port as "connected", because it
doesn't set a .detect callback.
Fix this by providing the proper detect callback for astdp and dp501.
This
On 06/07/2023 15:03, Linux regression tracking (Thorsten Leemhuis) wrote:
On 06.07.23 11:58, Jocelyn Falempe wrote:
Aspeed always report the display port as "connected", because it
doesn't set a .detect callback.
Fix this by providing the proper detect callback for astdp and dp501.
On 07/07/2023 09:30, Thomas Zimmermann wrote:
Hi
Am 06.07.23 um 18:37 schrieb Jocelyn Falempe:
[...]
You could out-comment the VGA code in the ast driver for testing.
Oh, Thanks for the idea, I will try that.
The result is that I get a black screen on the remote BMC. So maybe
adding
On 06/07/2023 13:31, Jocelyn Falempe wrote:
On 06/07/2023 12:26, Thomas Zimmermann wrote:
Hi
Am 06.07.23 um 11:16 schrieb Jocelyn Falempe:
On 04/07/2023 18:45, Jocelyn Falempe wrote:
On 04/07/2023 16:54, Jani Nikula wrote:
On Fri, 23 Jun 2023, Jocelyn Falempe wrote:
Since commit
On 06/07/2023 12:26, Thomas Zimmermann wrote:
Hi
Am 06.07.23 um 11:16 schrieb Jocelyn Falempe:
On 04/07/2023 18:45, Jocelyn Falempe wrote:
On 04/07/2023 16:54, Jani Nikula wrote:
On Fri, 23 Jun 2023, Jocelyn Falempe wrote:
Since commit fae7d186403e ("drm/probe-helper: Default to 64
On 06/07/2023 11:32, Jani Nikula wrote:
On Thu, 06 Jul 2023, Jocelyn Falempe wrote:
On 04/07/2023 18:45, Jocelyn Falempe wrote:
On 04/07/2023 16:54, Jani Nikula wrote:
On Fri, 23 Jun 2023, Jocelyn Falempe wrote:
Since commit fae7d186403e ("drm/probe-helper: Default to 640x480 if no
back to the dp/dp501 connector (Jani Nikula)
Signed-off-by: Jocelyn Falempe
---
drivers/gpu/drm/ast/ast_dp.c| 9
drivers/gpu/drm/ast/ast_dp501.c | 37 ++---
drivers/gpu/drm/ast/ast_drv.h | 2 ++
drivers/gpu/drm/ast/ast_mode.c | 24 +
On 04/07/2023 18:45, Jocelyn Falempe wrote:
On 04/07/2023 16:54, Jani Nikula wrote:
On Fri, 23 Jun 2023, Jocelyn Falempe wrote:
Since commit fae7d186403e ("drm/probe-helper: Default to 640x480 if no
EDID on DP")
The default resolution is now 640x480 when no monitor is connected.
On 04/07/2023 16:54, Jani Nikula wrote:
On Fri, 23 Jun 2023, Jocelyn Falempe wrote:
Since commit fae7d186403e ("drm/probe-helper: Default to 640x480 if no
EDID on DP")
The default resolution is now 640x480 when no monitor is connected.
But Aspeed graphics is mostly used in serv
On 16/06/2023 10:08, Thomas Zimmermann wrote:
Hi
Am 15.06.23 um 19:15 schrieb Jocelyn Falempe:
On 15/06/2023 16:24, Thomas Zimmermann wrote:
Hi Jocelyn
Am 31.05.23 um 11:21 schrieb Jocelyn Falempe:
Even if the transfer is not faster, it brings significant
improvement in latencies and CPU
on to 640x480, which is
inconvenient, and breaks the anaconda installer.
So when no EDID is present, set 1024x768 as preferred resolution.
Fixes: fae7d186403e ("drm/probe-helper: Default to 640x480 if no EDID on DP")
Signed-off-by: Jocelyn Falempe
---
drivers/gpu/drm/ast/ast_mode.c | 26
On 23/06/2023 10:28, Thomas Zimmermann wrote:
Am 17.05.23 um 15:41 schrieb Tom Rix:
smatch reports
drivers/gpu/drm/mgag200/mgag200_drv.c:23:5: warning: symbol
'mgag200_modeset' was not declared. Should it be static?
This variable is only used in its defining file, so it should be static
This patch was already sent by Tom Rix last month:
https://patchwork.freedesktop.org/series/117881/
I can push it to drm-misc-next, if Thomas is ok.
Best regards,
--
Jocelyn
On 21/06/2023 21:11, Sui Jingfeng wrote:
drivers/gpu/drm/mgag200/mgag200_drv.c:23:5: warning: symbol
On 31/05/2023 09:08, Thomas Zimmermann wrote:
Hi
Am 30.05.23 um 16:26 schrieb Jocelyn Falempe:
I've contributed to these two drivers, fixing bugs and performance
issues.
Thanks for the work you're doing.
Signed-off-by: Jocelyn Falempe
Acked-by: Thomas Zimmermann
Applied to drm
to be done in the same place
and affect each other.
Tested on AST1100 and AST2300.
I've also tested (remotely) on AST2600
For the whole series:
Reviewed-by: Jocelyn Falempe
Tested-by: Jocelyn Falempe
Thomas Zimmermann (14):
drm/ast: Fix DRAM init on AST2200
drm/ast: Remove vga2_clone
On 15/06/2023 16:24, Thomas Zimmermann wrote:
Hi Jocelyn
Am 31.05.23 um 11:21 schrieb Jocelyn Falempe:
Even if the transfer is not faster, it brings significant
improvement in latencies and CPU usage.
CPU usage drops from 100% of one core to 3% when continuously
refreshing the screen.
I
201 - 300 of 413 matches
Mail list logo
