Re: [PATCH v3 0/2] Parfait changes

2018-03-05 Thread Joe Moriarty
On 2/20/2018 2:11 PM, Joe Moriarty wrote: The following patch(s) are bugs found by the static compiler 'Parfait'. Care was taken to make sure false positive results were removed from this patchset. Parfait Overview https://labs.oracle.com/pls/apex/f?p=labs:49

[PATCH v3 0/2] Parfait changes

2018-02-20 Thread Joe Moriarty
original v1 patch into 4 separate patches per request from Jani Nikula - Fixed system hang during boot up on test machine. v3: - Made changes requested by Daniel Vetter. Joe Moriarty (2): drm: NULL pointer dereference [null-pointer-deref] (CWE 476) problem drm: NULL pointer dereference [null

[PATCH v3 2/2] drm: NULL pointer dereference [null-pointer-deref] (CWE 476) problem

2018-02-20 Thread Joe Moriarty
with BUG() from drm_minor_get_slot(). Signed-off-by: Joe Moriarty <joe.moria...@oracle.com> Reviewed-by: Steven Sistare <steven.sist...@oracle.com> --- drivers/gpu/drm/drm_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/d

[PATCH v3 1/2] drm: NULL pointer dereference [null-pointer-deref] (CWE 476) problem

2018-02-20 Thread Joe Moriarty
und when trying to find the struct crtc from it's assigned index given in drm_crtc_init_with_planes(). 3 return checks for NULL where added with a call to WARN_ON(!crtc). Signed-off-by: Joe Moriarty <joe.moria...@oracle.com> Reviewed-by: Steven Sistare <steven.sist...@oracle.com> ---

Re: [PATCH v2 4/4] drm: NULL pointer dereference [null-pointer-deref] (CWE 476) problem

2018-02-20 Thread Joe Moriarty
On 2/19/2018 8:32 AM, Daniel Vetter wrote: On Mon, Feb 12, 2018 at 02:51:44PM -0500, Joe Moriarty wrote: The Parfait (version 2.1.0) static code analysis tool found the following NULL pointer derefernce problem. - drivers/gpu/drm/drm_vblank.c Null pointer checks were added to return values

Re: [PATCH v2 1/4] drm: NULL pointer dereference [null-pointer-deref] (CWE 476) problem

2018-02-20 Thread Joe Moriarty
On 2/19/2018 6:57 AM, Daniel Vetter wrote: On Mon, Feb 12, 2018 at 02:51:41PM -0500, Joe Moriarty wrote: The Parfait (version 2.1.0) static code analysis tool found the following NULL pointer dereference problem. - drivers/gpu/drm/drm_drv.c Any calls to drm_minor_get_slot() could result

[PATCH v2 4/4] drm: NULL pointer dereference [null-pointer-deref] (CWE 476) problem

2018-02-12 Thread Joe Moriarty
und when trying to find the struct crtc from it's assigned index given in drm_crtc_init_with_planes(). 3 return checks for NULL where added. Signed-off-by: Joe Moriarty <joe.moria...@oracle.com> Reviewed-by: Steven Sistare <steven.sist...@oracle.com> --- drivers/gpu/drm/drm_vblank.

[PATCH v2 2/4] drm: NULL pointer dereference [null-pointer-deref] (CWE 476) problem

2018-02-12 Thread Joe Moriarty
ure to allocate memory for port->mstb. Signed-off-by: Joe Moriarty <joe.moria...@oracle.com> Reviewed-by: Steven Sistare <steven.sist...@oracle.com> --- drivers/gpu/drm/drm_dp_mst_topology.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm

[PATCH v2 3/4] drm: NULL pointer dereference [null-pointer-deref] (CWE 476) problem

2018-02-12 Thread Joe Moriarty
. A check for this added right after the call to drm_cvt_mode() in this particular area of code. Signed-off-by: Joe Moriarty <joe.moria...@oracle.com> Reviewed-by: Steven Sistare <steven.sist...@oracle.com> --- drivers/gpu/drm/drm_edid.c | 2 ++ 1 file changed, 2 insertions(+) diff --g

[PATCH v2 1/4] drm: NULL pointer dereference [null-pointer-deref] (CWE 476) problem

2018-02-12 Thread Joe Moriarty
for pointer manipulation (drm_minor_get_slot() and drm_minor_set_minor()) along with checks for valid pointers for struct drm_device variables throughout this module. Signed-off-by: Joe Moriarty <joe.moria...@oracle.com> Reviewed-by: Steven Sistare <steven.sist...@oracle.com> --- dri

[PATCH v2 0/4] Parfait changes

2018-02-12 Thread Joe Moriarty
original v1 patch into 4 separate patches per request from Jani Nikula - Fixed system hang during boot up on test machine. Joe Moriarty (4): drm: NULL pointer dereference [null-pointer-deref] (CWE 476) problem drm: NULL pointer dereference [null-pointer-deref] (CWE 476) problem drm: NULL pointer

Re: [PATCH v1 1/1] drm: Multiple Null pointer dereference [null-pointer-deref] (CWE 476) problems:

2018-02-09 Thread Joe Moriarty
On 2/9/2018 7:17 AM, Jani Nikula wrote: On Thu, 08 Feb 2018, Joe Moriarty <joe.moria...@oracle.com> wrote: The Parfait (version 2.1.0) static code analysis tool found multiple NULL pointer derefernce problems. Thanks for the patch. Multiple problems requires multiple patches to fix the

[PATCH v1 0/1] Parfait changes

2018-02-08 Thread Joe Moriarty
The following patch(s) are bugs found by the static compiler 'Parfait'. Care was taken to make sure false positive results were removed from this patchset. Parfait Overview https://labs.oracle.com/pls/apex/f?p=labs:49:P49_PROJECT_ID:13 Joe Moriarty (1): drm: Multiple

[PATCH v1 1/1] drm: Multiple Null pointer dereference [null-pointer-deref] (CWE 476) problems:

2018-02-08 Thread Joe Moriarty
ruct crtc from it's assigned index given in drm_crtc_init_with_planes(). 3 return checks for NULL where added. Signed-off-by: Joe Moriarty <joe.moria...@oracle.com> Reviewed-by: Steven Sistare <steven.sist...@oracle.com> --- drivers/gpu/drm/drm_dp_mst_topology.c | 8 +--- driv