[PATCH] drm: drm_printer: add __printf validation

2017-02-15 Thread Joe Perches
drm_printf does not currently use the compiler to verify format and arguments. Make it do so. Miscellanea: o Add appropriate #include files for __printf and struct va_format o Convert dev_printk to dev_info Signed-off-by: Joe Perches --- drivers/gpu/drm/drm_print.c | 2 +- include/drm

[PATCH] treewide: Make remaining source files non-executable

2016-12-12 Thread Joe Perches
.c and .h source files should not be executable, change the permissions to 0644. Signed-off-by: Joe Perches Acked-by: David Howells --- Linus, Andrew Morton suggested privately that you apply this directly as his toolchain doesn't support rename/permission only patches. Apparently, A

[PATCH] treewide: Make remaining source files non-executable

2016-12-11 Thread Joe Perches
.c and .h source files should not be executable, change the permissions to 0644. Signed-off-by: Joe Perches --- drivers/gpu/drm/amd/include/asic_reg/dce/dce_11_2_d.h | 0 drivers/gpu/drm/amd/include/asic_reg/dce/dce_11_2_sh_mask.h | 0 drivers/gpu/drm/amd/include/cgs_common.h

[RFC PATCH] get_maintainer: Look for arbitrary letter prefixes in sections

2016-11-03 Thread Joe Perches
On Thu, 2016-11-03 at 10:07 +0100, Paul Bolle wrote: > On Mon, 2016-10-24 at 11:05 -0700, Joe Perches wrote: > > Jani Nikula proposes patches to add a few new letter prefixes > > for "B:" bug reporting and "C:" maintainer chatting to the > > various sectio

[PATCH] drm/amd/powerplay: fix spelling mistake and add KERN_WARNING to printks

2016-10-24 Thread Joe Perches
On Mon, 2016-10-24 at 23:30 +0100, Colin King wrote: > From: Colin Ian King > > Fix trivial spelling mistake cant't -> can't and add KERN_WARNING to > printk messages. trivia: > diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/fiji_smc.c > b/drivers/gpu/drm/amd/powerplay/smumgr/fiji_smc.c []

[RFC PATCH] get_maintainer: Look for arbitrary letter prefixes in sections

2016-10-24 Thread Joe Perches
ix types in a section. Signed-off-by: Joe Perches ---  scripts/get_maintainer.pl | 12 +---  1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl index aed4511f0304..633f2dd3de27 100755 --- a/scripts/get_maintainer.pl +++ b/scri

[PATCH 00/15] improve function-level documentation

2016-10-01 Thread Joe Perches
On Sat, 2016-10-01 at 21:46 +0200, Julia Lawall wrote: > These patches fix cases where the documentation above a function definition > is not consistent with the function header. Issues are detected using the > semantic patch below (http://coccinelle.lip6.fr/). Basically, the semantic > patch par

[PATCH 1/2] drm: Simplify logging macros, convert DRM_NOTE to DRM_NOTICE

2016-09-27 Thread Joe Perches
On Tue, 2016-09-27 at 17:36 +0100, Emil Velikov wrote: > On 27 September 2016 at 17:04, Joe Perches wrote: > > On Tue, 2016-09-27 at 11:58 -0400, Sean Paul wrote: > > > On Sun, Sep 25, 2016 at 10:18 PM, Joe Perches wrote: > > > > Use a bit more consistent style w

[PATCH 1/2] drm: Simplify logging macros, convert DRM_NOTE to DRM_NOTICE

2016-09-27 Thread Joe Perches
On Tue, 2016-09-27 at 17:36 +0100, Emil Velikov wrote: > On 27 September 2016 at 17:04, Joe Perches wrote: > > On Tue, 2016-09-27 at 11:58 -0400, Sean Paul wrote: > > > On Sun, Sep 25, 2016 at 10:18 PM, Joe Perches wrote: > > > > Use a bit more consistent style w

[PATCH 1/2] drm: Simplify logging macros, convert DRM_NOTE to DRM_NOTICE

2016-09-27 Thread Joe Perches
On Tue, 2016-09-27 at 11:58 -0400, Sean Paul wrote: > > On Sun, Sep 25, 2016 at 10:18 PM, Joe Perches wrote: > > Use a bit more consistent style with kernel loglevels > > I'm not convinced this is worth doing if we're going to keep the > WARN/WARNING discrepan

[PATCH 2/2] drm: Simplify drm_printk to reduce object size quite a bit

2016-09-25 Thread Joe Perches
ely used and not worth conversion Signed-off-by: Joe Perches --- drivers/gpu/drm/drm_drv.c | 5 +++-- include/drm/drmP.h| 30 ++ 2 files changed, 17 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c index 80c7

[PATCH 1/2] drm: Simplify logging macros, convert DRM_NOTE to DRM_NOTICE

2016-09-25 Thread Joe Perches
Use a bit more consistent style with kernel loglevels without using macro argument concatenation. Miscellanea: o Single statement macros don't need do {} while (0) Signed-off-by: Joe Perches --- drivers/gpu/drm/i915/intel_guc_loader.c | 22 -- include/drm/d

[PATCH 0/2] drm: Neaten and reduce object size

2016-09-25 Thread Joe Perches
Joe Perches (2): drm: Simplify logging macros, convert DRM_NOTE to DRM_NOTICE drm: Simplify drm_printk to reduce object size quite a bit drivers/gpu/drm/drm_drv.c | 5 +-- drivers/gpu/drm/i915/intel_guc_loader.c | 22 +++-- include/drm/drmP.h | 56

[PATCH 14/14] GPU-DRM-TTM: Mark an array of text strings as "const" in ttm_dma_pool_init()

2016-09-22 Thread Joe Perches
On Thu, 2016-09-22 at 19:46 +0200, SF Markus Elfring wrote: > The local variable "n" was not modified after it was initialized with > a few text strings. > Thus express this detail also by the data type qualifier "const". [] > diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c > b/drivers/gpu/d

[PATCH 1/1] drm/radeon: avoid NULL dereference, si_get_vce_clock_voltage

2016-08-21 Thread Joe Perches
On Sun, 2016-08-21 at 23:20 +0200, Heinrich Schuchardt wrote: > On 08/21/2016 11:06 PM, Joe Perches wrote: > > On Sun, 2016-08-21 at 22:52 +0200, Heinrich Schuchardt wrote: > > > > > > It does not make sense to check if table is NULL > > > and

[PATCH 1/1] drm/radeon: avoid NULL dereference, si_get_vce_clock_voltage

2016-08-21 Thread Joe Perches
On Sun, 2016-08-21 at 22:52 +0200, Heinrich Schuchardt wrote: > It does not make sense to check if table is NULL > and afterwards to dereference it without > considering the result. This makes no sense. > The inconsistency was indicated by cppcheck. Perhaps this is a defect in cppcheck? > An ac

[PATCH] drm/gma500: dont expose bytes from kernel stack

2016-08-21 Thread Joe Perches
On Sun, 2016-08-21 at 21:35 +0200, Heinrich Schuchardt wrote: > On 08/21/2016 08:46 PM, Joe Perches wrote: > > On Sun, 2016-08-21 at 20:39 +0200, Heinrich Schuchardt wrote: > > > Components m1, m2, p2, dot, vco of variable clock should be > > > initialized to avoid byt

[PATCH 1/1] drm/amdgpu/gmc7: remove dead code

2016-08-21 Thread Joe Perches
On Sun, 2016-08-21 at 20:45 +0200, Heinrich Schuchardt wrote: > On 08/21/2016 08:29 PM, Joe Perches wrote: > > On Sun, 2016-08-21 at 20:06 +0200, Heinrich Schuchardt wrote: > > > In an if block for (running == 0) running cannot be non-zero. > > This code could also be

[PATCH] drm/gma500: dont expose bytes from kernel stack

2016-08-21 Thread Joe Perches
On Sun, 2016-08-21 at 20:39 +0200, Heinrich Schuchardt wrote: > Components m1, m2, p2, dot, vco of variable clock should be > initialized to avoid bytes from the kernel stack to be > exposed. How was this found? visual code inspection? And isn't this true for mrst_lvds_find_best_pll as well? >

[PATCH 1/1] drm/amdgpu/gmc7: remove dead code

2016-08-21 Thread Joe Perches
On Sun, 2016-08-21 at 20:06 +0200, Heinrich Schuchardt wrote: > In an if block for (running == 0) running cannot be non-zero. This code could also be better unindented by one level (all of the block would fit 80 columns) by changing: if (running == 0) { [code...]

[PATCH 6/7] drm: Add ratelimited versions of the DRM_DEBUG* macros

2016-08-06 Thread Joe Perches
On Fri, 2016-08-05 at 20:30 -0400, Lyude wrote: > There's a couple of places where this would be useful for drivers (such > as reporting DP aux transaction timeouts). Maybe a single static _rs or one for each type would be better than an individual _rs per callsite.

[PATCH v2 0/7] lib: string: add functions to case-convert strings

2016-07-05 Thread Joe Perches
On Tue, 2016-07-05 at 15:36 -0700, Markus Mayer wrote: > On 5 July 2016 at 15:14, Joe Perches wrote: > > On Tue, 2016-07-05 at 13:47 -0700, Markus Mayer wrote: > > > This series introduces a family of generic string case conversion > > > functions. This kind of functio

[PATCH v2 0/7] lib: string: add functions to case-convert strings

2016-07-05 Thread Joe Perches
On Tue, 2016-07-05 at 13:47 -0700, Markus Mayer wrote: > This series introduces a family of generic string case conversion > functions. This kind of functionality is needed in several places in > the kernel. Right now, everybody seems to be implementing their own > copy of this functionality. > >

[PATCH 5/7] staging/android: prepare sw_sync files for de-staging

2016-06-20 Thread Joe Perches
On Mon, 2016-06-20 at 12:53 -0300, Gustavo Padovan wrote: > From: Gustavo Padovan > > Fix paths in the comments. Why is it useful to have the path or filename embedded in the file at all?

[PATCH v12 1/2] kernel.h: add u64_to_user_ptr()

2016-04-26 Thread Joe Perches
On Tue, 2016-04-26 at 11:29 -0300, Gustavo Padovan wrote: > 2016-04-26 Lucas Stach : > > Am Donnerstag, den 21.04.2016, 12:38 -0300 schrieb Gustavo Padovan: > > > From: Gustavo Padovan > > > > > > This function had copies in 3 different files. Unify them in ke

[PATCH 2/3] kernel.h: add u64_to_user_ptr()

2016-04-20 Thread Joe Perches
On Wed, 2016-04-20 at 16:18 -0300, Gustavo Padovan wrote: > From: Gustavo Padovan > > This function had copies in 3 different files. Unify them in kernel.h. [] > diff --git a/include/linux/kernel.h b/include/linux/kernel.h [] > @@ -53,6 +53,12 @@ > >  #define ARRAY_SIZE(arr) (sizeof(arr) / size

[PATCH] drm/amdgpu: fix compare_const_fl.cocci warnings

2016-04-15 Thread Joe Perches
t; While it's not so much of a problem any more with modern compilers, some > > people still prefer to have it on the left side to catch accidental value > > assignments. > > I don't know if it is documented.  Joe Perches suggested that on the right > was b

[PATCH] drm/vmwgfx: use *_32_bits() macros

2016-04-14 Thread Joe Perches
On Thu, 2016-04-14 at 13:32 +0200, Paul Bolle wrote: > On do, 2016-03-03 at 11:26 +0100, Paul Bolle wrote: > > > > Use the upper_32_bits() macro instead of the four line equivalent that > > triggers a GCC warning on 32 bits x86: > >     drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c: In function > > '

[PATCH] gma500: fix missing comma in dsi_errors array initializer

2016-03-22 Thread Joe Perches
On Tue, 2016-03-22 at 22:49 +, Colin King wrote: > From: Colin Ian King > > There is a missing comma between two strings in the dsi_errors[] > array initializer, causing two strings to be concatenated and the > array being incorrectly initialized.  Add in the missing comma. > > Signed-off-

[PATCH] gpu/drm: Use u64_to_user_pointer

2016-03-18 Thread Joe Perches
On Sat, 2016-03-19 at 01:39 +0800, kbuild test robot wrote: > Hi Joe, > > [auto build test WARNING on drm/drm-next] > [also build test WARNING on next-20160318] > [cannot apply to v4.5] > [if your patch is applied to the wrong git tree, please drop us a > note to help improving the system] Thanks

[PATCH] gpu/drm: Use u64_to_user_pointer

2016-03-18 Thread Joe Perches
Use the newly added u64_to_user_pointer a bit more frequently. Signed-off-by: Joe Perches --- drivers/gpu/drm/armada/armada_gem.c| 2 +- drivers/gpu/drm/nouveau/nouveau_gem.c | 7 --- drivers/gpu/drm/tegra/drm.c| 15 --- drivers/gpu/drm/vc4/vc4_bo.c

[PATCH v10 2/3] kernel.h: add u64_to_user_ptr()

2016-03-18 Thread Joe Perches
On Fri, 2016-03-18 at 10:27 -0300, Gustavo Padovan wrote: > From: Gustavo Padovan > > This function had copies in 3 different files. Unify them in > kernel.h. This function might be used more in drm files in a separate patch too: $ git grep -n -E "__user.*\(\s*uintptr_t\s*\)" drivers/gpu/drm dr

[PATCH v9 2/3] kernel.h: add to_user_ptr()

2016-03-17 Thread Joe Perches
On Thu, 2016-03-17 at 18:19 -0300, Gustavo Padovan wrote: > 2016-03-17 Joe Perches : > > On Thu, 2016-03-17 at 16:50 -0400, Rob Clark wrote: > > > On Thu, Mar 17, 2016 at 4:40 PM, Joe Perches wrote: > > [] > > > > It's a name that seems like it should be a

[PATCH v9 2/3] kernel.h: add to_user_ptr()

2016-03-17 Thread Joe Perches
On Thu, 2016-03-17 at 16:50 -0400, Rob Clark wrote: > On Thu, Mar 17, 2016 at 4:40 PM, Joe Perches wrote: [] > > It's a name that seems like it should be a straightforward > > cast of a kernel pointer to a __user pointer like: > > > > static inline void __user *to

[PATCH v9 2/3] kernel.h: add to_user_ptr()

2016-03-17 Thread Joe Perches
On Thu, 2016-03-17 at 16:33 -0400, Rob Clark wrote: > On Thu, Mar 17, 2016 at 4:22 PM, Joe Perches wrote: > > On Thu, 2016-03-17 at 15:43 -0300, Gustavo Padovan wrote: > > > 2016-03-17 Gustavo Padovan : > > > > 2016-03-17 Joe Perches : > > > > > On Th

[PATCH v9 2/3] kernel.h: add to_user_ptr()

2016-03-17 Thread Joe Perches
On Thu, 2016-03-17 at 15:43 -0300, Gustavo Padovan wrote: > 2016-03-17 Gustavo Padovan : > > 2016-03-17 Joe Perches : > > > On Thu, 2016-03-17 at 14:30 -0300, Gustavo Padovan wrote: > > > > > > > > This function had copies in 3 different files. Unify th

[PATCH v9 2/3] kernel.h: add to_user_ptr()

2016-03-17 Thread Joe Perches
On Thu, 2016-03-17 at 14:30 -0300, Gustavo Padovan wrote: > This function had copies in 3 different files. Unify them in > kernel.h. This is only used by gpu/drm. I think this is a poor name for a generic function that would be in kernel.h. Isn't there an include file in linux/drm that's appropr

[RFC 00/29] De-stage android's sync framework

2016-01-15 Thread Joe Perches
On Fri, 2016-01-15 at 12:55 -0200, Gustavo Padovan wrote: > From: Gustavo Padovan > > This patch series de-stage the sync framework, and in order to accomplish that > a bunch of cleanups/improvements on the sync and fence were made. Perhaps add/update a MAINTAINERS entry too?

[PATCH v4 01/16] drm: exynos/dp: fix code style

2015-09-02 Thread Joe Perches
On Thu, 2015-09-03 at 13:33 +0800, Yakir Yang wrote: [] > diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c [] > @@ -155,24 +156,22 @@ static int exynos_dp_read_edid(struct > exynos_dp_device *dp) > } > exynos_dp_read_byte_from_dpcd(dp, DP_TEST_RE

[RFC PATCH 1/8] drm: exynos/dp: fix code style

2015-08-06 Thread Joe Perches
On Thu, 2015-08-06 at 09:04 -0500, Yakir Yang wrote: > make checkpatch.pl script happy That should not be the primary reason to submit a patch. Making it easier for human code reader to understand what the code does should be though. > diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c > b/dr

[PATCH 04/12] drm/radeon: Use DECLARE_BITMAP

2015-05-19 Thread Joe Perches
Use the generic mechanism to declare a bitmap instead of unsigned long. Signed-off-by: Joe Perches --- drivers/gpu/drm/radeon/radeon.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/radeon.h b/drivers/gpu/drm/radeon/radeon.h index 46eb0fa..d556733

[PATCH 03/12] drm/amdkfd: Use DECLARE_BITMAP

2015-05-19 Thread Joe Perches
Use the generic mechanism to declare a bitmap instead of unsigned long. It seems that "struct kfd_process.allocated_queue_bitmap" is unused. Maybe it could be deleted instead. Signed-off-by: Joe Perches --- drivers/gpu/drm/amd/amdkfd/kfd_priv.h | 5 ++--- 1 file changed, 2 insert

[PATCH 00/12] treewide: Use DECLARE_BITMAP

2015-05-19 Thread Joe Perches
Use the standard method to declare a bitmap array. Joe Perches (12): ARM: mach-imx: iomux-imx31: Use DECLARE_BITMAP dmaengine: rcar-dmac: Use DECLARE_BITMAP drm/amdkfd: Use DECLARE_BITMAP drm/radeon: Use DECLARE_BITMAP IB/ehca: Use DECLARE_BITMAP bcache: Use DECLARE_BITMAP

[PATCH drm] drm/vgem: vgem_gem_dumb_map() can be static

2015-04-01 Thread Joe Perches
On Thu, 2015-04-02 at 10:59 +0800, kbuild test robot wrote: > Signed-off-by: Fengguang Wu [] > diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c [] > @@ -195,7 +195,7 @@ static int vgem_gem_dumb_create(struct drm_file *file, > struct drm_device *dev, > return 0;

[PATCH 1/7] drm: Use bool function return values of true/false not 1/0

2015-03-30 Thread Joe Perches
Use the normal return values for bool functions Signed-off-by: Joe Perches --- drivers/gpu/drm/ast/ast_post.c| 2 +- drivers/gpu/drm/vmwgfx/vmwgfx_fence.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/ast/ast_post.c b/drivers/gpu/drm/ast

[PATCH 0/7] drivers: Use bool function return values true/false not 1/0

2015-03-30 Thread Joe Perches
Joe Perches (7): drm: Use bool function return values of true/false not 1/0 dm_table: Use bool function return values of true/false not 1/0 genwqe: Use bool function return values of true/false not 1/0 wmi: Use bool function return values of true/false not 1/0 ssb: Use bool function

[trivial PATCH] MAINTAINERS: Remove DRM DRIVERS FOR RENESAS pattern

2015-03-23 Thread Joe Perches
commit 2378ad1228d2 ("drm: rcar-du: Remove platform data support") removed the file, remove the pattern. Signed-off-by: Joe Perches --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 78195d3..47aaa52 100644 --- a/MAINTAINERS +++ b/M

[PATCH v2 1/3] drm: bridge/dw_hdmi: fixed codec style

2015-03-08 Thread Joe Perches
On Sun, 2015-03-08 at 21:48 -0700, Joe Perches wrote: > Shouldn't all of these be static? Don't mind me. These shouldn't be static. I was a bit mislead by the commit message. I think it'd be better not to put patch-like + and - lines in the commit description. cheers, Joe

[PATCH v2 1/3] drm: bridge/dw_hdmi: fixed codec style

2015-03-08 Thread Joe Perches
On Mon, 2015-03-09 at 12:42 +0800, Yakir Yang wrote: > diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c > b/drivers/gpu/drm/bridge/dw_hdmi.c [] > @@ -900,10 +900,10 @@ static int hdmi_phy_configure(struct dw_hdmi *hdmi, > unsigned char prep, > { > unsigned res_idx, i; > u8 val, msec; >

[Intel-gfx] 3.19-rc1 errors when opening LID

2014-12-27 Thread Joe Perches
On Sat, 2014-12-27 at 21:22 +0100, Rafael J. Wysocki wrote: [] > +++ linux-pm/include/acpi/acpi_bus.h > @@ -589,7 +589,8 @@ static inline u32 acpi_target_system_sta > > static inline bool acpi_device_power_manageable(struct acpi_device *adev) > { > - return adev->flags.power_manageable; > +

[PATCH 0/20] fix misspelling of current function in string

2014-12-07 Thread Joe Perches
On Sun, 2014-12-07 at 20:20 +0100, Julia Lawall wrote: > These patches replace what appears to be a reference to the name of the > current function but is misspelled in some way by either the name of the > function itself, or by %s and then __func__ in an argument list. At least a few of these see

[PATCH v5 06/24] Update MAINTAINERS and CREDITS files with amdkfd info

2014-11-08 Thread Joe Perches
On Sat, 2014-11-08 at 20:59 +0200, Oded Gabbay wrote: > I also noticed I forgot to modify drivers/gpu/drm/radeon/amdkfd/* to > drivers/gpu/drm/amd/amdkfd/* That should probably just be drivers/gpu/drm/adm/amdkfd/ The trailing star means if there are subdirectories, do not match them, just match t

[PATCH v5 06/24] Update MAINTAINERS and CREDITS files with amdkfd info

2014-11-08 Thread Joe Perches
On Sat, 2014-11-08 at 11:01 -0800, Josh Triplett wrote: > On Sat, Nov 08, 2014 at 08:37:27PM +0200, Oded Gabbay wrote: > > CREDITS | 7 +++ > > MAINTAINERS | 10 ++ > > 2 files changed, 17 insertions(+) > > Given the wide variety of folks who patch CREDITS and MAINTAINERS, might

[PATCH v5 06/24] Update MAINTAINERS and CREDITS files with amdkfd info

2014-11-08 Thread Joe Perches
On Sat, 2014-11-08 at 20:37 +0200, Oded Gabbay wrote: [] > diff --git a/MAINTAINERS b/MAINTAINERS [] > @@ -610,6 +610,16 @@ F: drivers/crypto/geode* > F: drivers/video/fbdev/geode/ > F: arch/x86/include/asm/geode.h > > +AMD KFD (radeon extension) > +M: Oded Gabbay > +L: dri-devel

[PATCH] drm: Reduce code size of drm_err and DRM_DEBUG[_] uses

2014-11-04 Thread Joe Perches
On Tue, 2014-11-04 at 09:52 +0100, Daniel Vetter wrote: > On Tue, Nov 04, 2014 at 12:03:46AM -0800, Joe Perches wrote: > > Using %pf, __builtin_return_address(0) instead ofy > > "%s", __func__ reduces code size by eliminating > > a function argument. [] > I h

[PATCH] drm: Reduce code size of drm_err and DRM_DEBUG[_] uses

2014-11-04 Thread Joe Perches
t-in.o.new 4737680 1321947 1669472 7729099 75efcb drivers/gpu/drm/built-in.o.old Signed-off-by: Joe Perches --- drivers/gpu/drm/drm_drv.c | 10 ++ include/drm/drmP.h| 45 ++--- 2 files changed, 28 insertions(+), 27 deletions(-) diff --git a/drive

[PATCH 02/11 V2] radeon: evergreen: Fix probable mask then right shift defect

2014-10-27 Thread Joe Perches
Precedence of & and >> is not the same and is not left to right. shift has higher precedence and should be done after the mask. Add parentheses around the mask. Use the already #defined values instead of hardcoding. Signed-off-by: Joe Perches --- > I think t

[PATCH 02/11] radeon: evergreen: Fix probable mask then right shift defects

2014-10-26 Thread Joe Perches
Precedence of & and >> is not the same and is not left to right. shift has higher precedence and should be done after the mask. Add parentheses around the mask. Use the already #defined values instead of hardcoding. Signed-off-by: Joe Perches --- drivers/gpu/drm/radeon/evergreen.c

[PATCH 00/11] treewide: mask then shift defects and style updates

2014-10-26 Thread Joe Perches
logical mask has lower precedence than shift but should be done before the shift so parentheses are generally required. And when masking with a fixed value after a shift, normal kernel style has the shift on the left, then the shift on the right so convert a few non-conforming uses. Joe Perches

[PATCH] drm: drm_err: Remove unnecessary __func__ argument

2014-10-13 Thread Joe Perches
On Mon, 2014-10-13 at 17:46 +0200, David Herrmann wrote: > Hi > > On Sun, Oct 12, 2014 at 7:08 AM, Joe Perches wrote: > > Removing the unnecessary drm_err __func__ argument by using > > the equivalent %pf and __builtin_return_address(0) makes the > > code smaller for

[PATCH] drm: drm_err: Remove unnecessary __func__ argument

2014-10-11 Thread Joe Perches
193257 296736 1412440 158d58 drivers/gpu/drm/i915/i915.o.new 928111 193257 296736 1418104 15a378 drivers/gpu/drm/i915/i915.o.old Signed-off-by: Joe Perches --- drivers/gpu/drm/drm_drv.c | 5 +++-- include/drm/drmP.h| 8 2 files changed, 7 insertions(+), 6 deletions(-) diff

[PATCH] drm: change drm_err return type to void

2014-09-22 Thread Joe Perches
The return value is not used by callers of this function nor by uses of the DRM_ERROR macro so change the function to return void. Signed-off-by: Joe Perches --- This change is associated to a desire to eventually change printk to return void. No x86 change in output size for drm_drv.o

[PATCH] gpu: drm: omapdrm: Use %pad format for values of the dma_addr_t type

2014-07-24 Thread Joe Perches
On Thu, 2014-07-24 at 21:58 +0400, matwey at sai.msu.ru wrote: > The format change is to fix the following compilation issue: Just a trivial note: > diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c > b/drivers/gpu/drm/omapdrm/omap_gem.c [] > @@ -791,7 +791,7 @@ int omap_gem_get_paddr(struct drm_g

[PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use

2014-07-18 Thread Joe Perches
On Fri, 2014-07-18 at 09:43 -0700, Greg KH wrote: > On Fri, Jul 18, 2014 at 12:22:13PM -0400, John W. Linville wrote: > > On Fri, Jul 18, 2014 at 05:26:47PM +0200, Benoit Taine wrote: > > > We should prefer `const struct pci_device_id` over > > > `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding styl

[PATCH 09/83] hsa/radeon: Add code base of hsa driver for AMD's GPUs

2014-07-11 Thread Joe Perches
On Fri, 2014-07-11 at 15:22 -0400, Jerome Glisse wrote: > Just to be explicit, my point is that is you claim GPL in MODULE_LICENSE > then this is a GPL licensed code, if you claim GPL with additional rights > than this is dual licensed code. This is how i read and interpret this > with additional r

[PATCH 09/83] hsa/radeon: Add code base of hsa driver for AMD's GPUs

2014-07-11 Thread Joe Perches
On Fri, 2014-07-11 at 13:04 -0400, Jerome Glisse wrote: > On Fri, Jul 11, 2014 at 12:50:09AM +0300, Oded Gabbay wrote: [] > > +static long kfd_ioctl(struct file *, unsigned int, unsigned long); > > Nitpick, avoid unsigned int just use unsigned. I suggest unsigned int is much more common (and bett

[PATCH 04/83] drm/radeon: Add radeon <--> kfd interface

2014-07-10 Thread Joe Perches
On Fri, 2014-07-11 at 00:50 +0300, Oded Gabbay wrote: > This patch adds the interface between the radeon driver and the kfd > driver. The interface implementation is contained in > radeon_kfd.c and radeon_kfd.h. [] > include/linux/radeon_kfd.h | 67 ++ Is there a g

[PATCH 00/22] Add and use pci_zalloc_consistent

2014-06-23 Thread Joe Perches
On Mon, 2014-06-23 at 10:25 -0700, Luis R. Rodriguez wrote: > On Mon, Jun 23, 2014 at 06:41:28AM -0700, Joe Perches wrote: > > Adding the helper reduces object code size as well as overall > > source size line count. > > > > It's also consistent with all the vari

[PATCH 06/22] i810: Use pci_zalloc_consistent

2014-06-23 Thread Joe Perches
Remove the now unnecessary memset too. Signed-off-by: Joe Perches --- drivers/gpu/drm/i810/i810_dma.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i810/i810_dma.c b/drivers/gpu/drm/i810/i810_dma.c index e88bac1..bae897d 100644 --- a/drivers/gpu/drm

[PATCH 00/22] Add and use pci_zalloc_consistent

2014-06-23 Thread Joe Perches
Adding the helper reduces object code size as well as overall source size line count. It's also consistent with all the various zalloc mechanisms in the kernel. Done with a simple cocci script and some typing. Joe Perches (22): pci-dma-compat: Add pci_zalloc_consistent helper atm

[PATCH -next 07/26] gpu: Use dma_zalloc_coherent

2014-06-15 Thread Joe Perches
Use the zeroing function instead of dma_alloc_coherent & memset(,0,) Signed-off-by: Joe Perches --- drivers/gpu/drm/drm_pci.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_pci.c b/drivers/gpu/drm/drm_pci.c index 020cfd9..6b3ca60 100644 -

[PATCH -next 00/26] treewide: Use dma_zalloc_coherent

2014-06-15 Thread Joe Perches
Use the zeroing function instead of dma_alloc_coherent & memset(,0,) Joe Perches (26): powerpc: Use dma_zalloc_coherent sh: Use dma_zalloc_coherent ata: Use dma_zalloc_coherent block: Use dma_zalloc_coherent crypto: Use dma_zalloc_coherent dma: Use dma_zalloc_coherent gpu:

[PATCH 4/5] i915: Convert last uses of __FUNCTION__ to __func__

2014-03-25 Thread Joe Perches
Just about all of these have been converted to __func__, so convert the last uses. Signed-off-by: Joe Perches --- drivers/gpu/drm/i915/dvo_ns2501.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/dvo_ns2501.c b/drivers/gpu/drm/i915

[PATCH 0/5] Convert last few uses of __FUNCTION__ to __func__

2014-03-25 Thread Joe Perches
Outside of staging, there aren't any more uses of __FUNCTION__ now... Joe Perches (5): powerpc: Convert last uses of __FUNCTION__ to __func__ x86: Convert last uses of __FUNCTION__ to __func__ block: Convert last uses of __FUNCTION__ to __func__ i915: Convert last uses of __FUNCTION

[PATCH v5 17/23] drm/i2c: tda998x: set the PLL division factor in range 0..3

2014-01-29 Thread Joe Perches
On Sat, 2014-01-25 at 18:14 +0100, Jean-Francois Moine wrote: > The predivider division factor of the register PLL_SERIAL_2 is in the > range 0..3, the value 0 being used for a division by 1. trivia: > diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c > b/drivers/gpu/drm/i2c/tda998x_drv.c [] > @@ -

Re: [PATCH] gpu: host1x: use %pa to print dma_addr_t

2013-09-16 Thread Joe Perches
On Mon, 2013-09-16 at 08:46 -0700, Olof Johansson wrote: > On Mon, Sep 16, 2013 at 8:17 AM, Thierry Reding > wrote: > > On Wed, Sep 11, 2013 at 09:41:49PM -0700, Olof Johansson wrote: > >> This removes two warnings where dma_addr_t variables were printed using > >> %x when built with CONFIG_ARM_LP

[PATCH 3/6] i915_gem: Convert kmem_cache_alloc(...GFP_ZERO) to kmem_cache_zalloc

2013-08-29 Thread Joe Perches
The helper exists, might as well use it instead of __GFP_ZERO. Signed-off-by: Joe Perches --- drivers/gpu/drm/i915/i915_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 8a0eb96..c4acd96 100644 --- a

[PATCH 0/6] treewide: kmem_cache_alloc GFP_ZERO cleanups

2013-08-29 Thread Joe Perches
Just a few cleanups to use zalloc style calls and reduce the uses of __GFP_ZERO for kmem_cache_alloc[_node] uses. Use the more kernel normal zalloc style. Joe Perches (6): slab/block: Add and use kmem_cache_zalloc_node block: Convert kmem_cache_alloc(...GFP_ZERO) to kmem_cache_zalloc

[PATCH 3/6] i915_gem: Convert kmem_cache_alloc(...GFP_ZERO) to kmem_cache_zalloc

2013-08-29 Thread Joe Perches
The helper exists, might as well use it instead of __GFP_ZERO. Signed-off-by: Joe Perches --- drivers/gpu/drm/i915/i915_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 8a0eb96..c4acd96 100644 --- a

[PATCH 0/6] treewide: kmem_cache_alloc GFP_ZERO cleanups

2013-08-29 Thread Joe Perches
Just a few cleanups to use zalloc style calls and reduce the uses of __GFP_ZERO for kmem_cache_alloc[_node] uses. Use the more kernel normal zalloc style. Joe Perches (6): slab/block: Add and use kmem_cache_zalloc_node block: Convert kmem_cache_alloc(...GFP_ZERO) to kmem_cache_zalloc

Re: [PATCH 2/2] i2c.c: Fixed coding style issue for if statement

2013-07-27 Thread Joe Perches
On Sat, 2013-07-27 at 23:18 +0530, santosh.anbu wrote: > From: "santosh.anbu" [] > diff --git a/drivers/gpu/drm/nouveau/core/subdev/bios/i2c.c > b/drivers/gpu/drm/nouveau/core/subdev/bios/i2c.c > index cfb9288..e88529c 100644 > --- a/drivers/gpu/drm/nouveau/core/subdev/bios/i2c.c > +++ b/drivers/

[PATCH 2/2] i2c.c: Fixed coding style issue for if statement

2013-07-27 Thread Joe Perches
On Sat, 2013-07-27 at 23:18 +0530, santosh.anbu wrote: > From: "santosh.anbu" [] > diff --git a/drivers/gpu/drm/nouveau/core/subdev/bios/i2c.c > b/drivers/gpu/drm/nouveau/core/subdev/bios/i2c.c > index cfb9288..e88529c 100644 > --- a/drivers/gpu/drm/nouveau/core/subdev/bios/i2c.c > +++ b/drivers/

Re: [PATCH] drivers/gpu/drm/nouveau: remove erroneous semicolon

2013-04-06 Thread Joe Perches
On Sun, 2013-04-07 at 11:57 +0800, Chen Gang wrote: > On 2013年04月07日 11:49, Greg KH wrote: > > On Sun, Apr 07, 2013 at 09:03:55AM +0800, Chen Gang wrote: > >> Hello Greg KH: > >> when you have time, can you help to check this patch whether OK ? > > No. > Why ? does it also need a test ?? Greg's

[PATCH] drivers/gpu/drm/nouveau: remove erroneous semicolon

2013-04-06 Thread Joe Perches
On Sun, 2013-04-07 at 11:57 +0800, Chen Gang wrote: > On 2013?04?07? 11:49, Greg KH wrote: > > On Sun, Apr 07, 2013 at 09:03:55AM +0800, Chen Gang wrote: > >> Hello Greg KH: > >> when you have time, can you help to check this patch whether OK ? > > No. > Why ? does it also need a test ?? Greg's

Re: [PATCH] drivers: gpu: drm: i915: Replaced calls to kmalloc & memcpy with kmemdup

2013-03-11 Thread Joe Perches
On Mon, 2013-03-11 at 22:39 +0200, Alexandru Gheorghiu wrote: > Replaced calls to kmalloc followed by memcpy with a single call to kmemdup. > Also removed a now redundant if statement. [] > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c [] > @@ -2335,11 +2335,8 @@ in

[PATCH] drivers: gpu: drm: i915: Replaced calls to kmalloc & memcpy with kmemdup

2013-03-11 Thread Joe Perches
On Mon, 2013-03-11 at 22:39 +0200, Alexandru Gheorghiu wrote: > Replaced calls to kmalloc followed by memcpy with a single call to kmemdup. > Also removed a now redundant if statement. [] > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c [] > @@ -2335,11 +2335,8 @@ in

Re: [PATCH V3] get_maintainer: use filename-only regex match for Tegra

2013-03-11 Thread Joe Perches
a entry from using K: to N: Acked-by: Joe Perches ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH V3] get_maintainer: use filename-only regex match for Tegra

2013-03-11 Thread Joe Perches
a entry from using K: to N: Acked-by: Joe Perches

Re: [PATCH V2 3/3] get_maintainer: prevent keywords from matching filenames

2013-03-06 Thread Joe Perches
On Wed, 2013-03-06 at 23:47 -0700, Stephen Warren wrote: > On 03/06/2013 05:40 PM, Joe Perches wrote: > > Which is why I showed the whole thing in a single patch. > > No worries if it's simply to increase the patch count... > > I'm not sure what showed refers to?

[PATCH V2 3/3] get_maintainer: prevent keywords from matching filenames

2013-03-06 Thread Joe Perches
On Wed, 2013-03-06 at 23:47 -0700, Stephen Warren wrote: > On 03/06/2013 05:40 PM, Joe Perches wrote: > > Which is why I showed the whole thing in a single patch. > > No worries if it's simply to increase the patch count... > > I'm not sure what showed refers to?

Re: [PATCH V2 3/3] get_maintainer: prevent keywords from matching filenames

2013-03-06 Thread Joe Perches
On Wed, 2013-03-06 at 17:34 -0700, Stephen Warren wrote: > On 03/06/2013 05:30 PM, Joe Perches wrote: > > On Wed, 2013-03-06 at 17:29 -0700, Stephen Warren wrote: > >> From: Stephen Warren > >> > >> This reverts most of eb90d08 "get_maintainer: allow keyw

[PATCH V2 3/3] get_maintainer: prevent keywords from matching filenames

2013-03-06 Thread Joe Perches
On Wed, 2013-03-06 at 17:34 -0700, Stephen Warren wrote: > On 03/06/2013 05:30 PM, Joe Perches wrote: > > On Wed, 2013-03-06 at 17:29 -0700, Stephen Warren wrote: > >> From: Stephen Warren > >> > >> This reverts most of eb90d08 "get_maintainer: allow keyw

Re: [PATCH V2 3/3] get_maintainer: prevent keywords from matching filenames

2013-03-06 Thread Joe Perches
On Wed, 2013-03-06 at 17:29 -0700, Stephen Warren wrote: > From: Stephen Warren > > This reverts most of eb90d08 "get_maintainer: allow keywords to match > filenames"; all except the parts that are required to implement the new > N: entry type. Just combine patches 1 and 3 into a single patch.

[PATCH V2 3/3] get_maintainer: prevent keywords from matching filenames

2013-03-06 Thread Joe Perches
On Wed, 2013-03-06 at 17:29 -0700, Stephen Warren wrote: > From: Stephen Warren > > This reverts most of eb90d08 "get_maintainer: allow keywords to match > filenames"; all except the parts that are required to implement the new > N: entry type. Just combine patches 1 and 3 into a single patch.

Re: [PATCH 1/2] get_maintainer: create filename-only regex match type

2013-03-06 Thread Joe Perches
On Wed, 2013-03-06 at 16:36 -0700, Stephen Warren wrote: > From: Stephen Warren > > Create a new N: entry type in MAINTAINERS which performs a regex match > against filenames; either those extracted from patch +++ or --- lines, > or those specified on the command-line using the -f option. NAK A

[PATCH 1/2] get_maintainer: create filename-only regex match type

2013-03-06 Thread Joe Perches
On Wed, 2013-03-06 at 16:36 -0700, Stephen Warren wrote: > From: Stephen Warren > > Create a new N: entry type in MAINTAINERS which performs a regex match > against filenames; either those extracted from patch +++ or --- lines, > or those specified on the command-line using the -f option. NAK A

Re: nouveau lockdep splat

2013-03-06 Thread Joe Perches
On Wed, 2013-03-06 at 12:31 -0700, Stephen Warren wrote: > On 03/06/2013 12:14 PM, Marcin Slusarz wrote: > > On Wed, Mar 06, 2013 at 01:04:29AM +0100, Borislav Petkov wrote: > >> On Tue, Mar 05, 2013 at 05:30:52PM +0100, Lucas Stach wrote: > >>> Dropping Tegra ML, it's not the place where Nouveau m

nouveau lockdep splat

2013-03-06 Thread Joe Perches
On Wed, 2013-03-06 at 12:31 -0700, Stephen Warren wrote: > On 03/06/2013 12:14 PM, Marcin Slusarz wrote: > > On Wed, Mar 06, 2013 at 01:04:29AM +0100, Borislav Petkov wrote: > >> On Tue, Mar 05, 2013 at 05:30:52PM +0100, Lucas Stach wrote: > >>> Dropping Tegra ML, it's not the place where Nouveau m

Re: radeon 0000:02:00.0: GPU lockup CP stall for more than 10000msec

2012-12-23 Thread Joe Perches
On Sun, 2012-12-23 at 11:01 +, Andy Furniss wrote: > Borislav Petkov wrote: > > > [ 28.191072] radeon: `0' invalid for parameter `wb' > > > > although the whole driver blubber didn't appear on the console fterwards > > aso something got turned off allright. > > > > Then, I went and tried "ra

radeon 0000:02:00.0: GPU lockup CP stall for more than 10000msec

2012-12-23 Thread Joe Perches
On Sun, 2012-12-23 at 11:01 +, Andy Furniss wrote: > Borislav Petkov wrote: > > > [ 28.191072] radeon: `0' invalid for parameter `wb' > > > > although the whole driver blubber didn't appear on the console fterwards > > aso something got turned off allright. > > > > Then, I went and tried "ra

<    1   2   3   4   5   >