On 2023-11-14 23:01, Hamza Mahfooz wrote:
On 11/14/23 10:27, José Pekkarinen wrote:
The following patch will fix a minor issue where a debug message is
referencing an struct that has just being checked whether is null or
not. This has been noticed by using coccinelle, in the following
output
is NULL but dereferenced.
Fixes: 5d72e247e58c9 ("drm/amd/display: switch DC over to the new DRM logging
macros")
Signed-off-by: José Pekkarinen
---
[v1 -> v2]: Remove the debugging message, requested by Hamza
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 5 +
1
This patch will address the following coccinelle warning where a pointer
is compared to 0 instead of NULL.
drivers/gpu/drm/amd/display/dc/dml2/display_mode_core.c:5423:19-20: WARNING
comparing pointer to 0
Fixes: 7966f319c66d9 ("drm/amd/display: Introduce DML2")
Signed-off-by: José
is NULL but dereferenced.
Fixes: 5d72e247e58c9 ("drm/amd/display: switch DC over to the new DRM logging
macros")
Signed-off-by: José Pekkarinen
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/g
On 2023-11-10 10:25, Lazar, Lijo wrote:
On 11/9/2023 2:11 PM, José Pekkarinen wrote:
The following patch will convert the power values returned by
amdgpu_hwmon_get_power to signed, fixing the following warnings
reported
by coccinelle:
drivers/gpu/drm/amd/pm/amdgpu_pm.c:2801:5-8: WARNING
On 2023-11-09 11:06, Greg KH wrote:
On Thu, Nov 09, 2023 at 10:43:50AM +0200, José Pekkarinen wrote:
On 2023-11-08 09:29, Greg KH wrote:
> On Wed, Nov 08, 2023 at 08:54:35AM +0200, José Pekkarinen wrote:
> > The following case seems to be safe to be replaced with a flexible
5-8: WARNING: Unsigned expression
compared with zero: val < 0
Signed-off-by: José Pekkarinen
---
drivers/gpu/drm/amd/pm/amdgpu_pm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
index e7bb1d
On 2023-11-08 09:29, Greg KH wrote:
On Wed, Nov 08, 2023 at 08:54:35AM +0200, José Pekkarinen wrote:
The following case seems to be safe to be replaced with a flexible
array
to clean up the added coccinelle warning. This patch will just do it.
drivers/gpu/drm/amd/pm/powerplay/smumgr
On 2023-10-30 15:54, Aurabindo Pillai wrote:
On 10/29/2023 5:39 AM, José Pekkarinen wrote:
Spotted by coccicheck, there is a redundant check for
v->SourcePixelFormat[k] != dm_444_16. This patch will
remove it. The corresponding output follows.
drivers/gpu/drm/amd/display/dc/dml/dc
On 2023-11-07 20:03, Guenter Roeck wrote:
On 11/7/23 09:26, José Pekkarinen wrote:
On 2023-11-07 16:08, Guenter Roeck wrote:
On 11/7/23 00:29, José Pekkarinen wrote:
There is a couple of function return checks of functions that return
unsigned values, and local variables to hold them are also
://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
drivers/gpu/drm/amd/pm/powerplay/inc/hwmgr.h:518:32-39: WARNING use
flexible-array member instead
(https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
Signed-off-by: José
(https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
Signed-off-by: José Pekkarinen
---
drivers/gpu/drm/amd/include/mes_v11_api_def.h | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/include/mes_v11_api_def.h
b/drivers/gpu/drm
/process/deprecated.html#zero-length-and-one-element-arrays)
Signed-off-by: José Pekkarinen
---
drivers/gpu/drm/amd/pm/powerplay/smumgr/smu8_smumgr.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/pm/powerplay/smumgr/smu8_smumgr.h
b/drivers/gpu/drm/amd/pm
On 2023-11-07 17:39, Alex Deucher wrote:
On Tue, Nov 7, 2023 at 4:44 AM José Pekkarinen
wrote:
This patch will address the following couple of warnings retrieved by
using coccinelle, where there is an explicit conversion to bool that
are redundant.
drivers/gpu/drm/amd/display/amdgpu_dm
On 2023-11-07 16:08, Guenter Roeck wrote:
On 11/7/23 00:29, José Pekkarinen wrote:
There is a couple of function return checks of functions that return
unsigned values, and local variables to hold them are also unsigned,
so
checking if they are negative will always return false. This patch
/amdgpu_dm/amdgpu_dm_replay.c:102:72-77: WARNING:
conversion to bool not needed here
Signed-off-by: José Pekkarinen
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_replay.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm
:2801:5-8: WARNING: Unsigned expression
compared with zero: val < 0
drivers/gpu/drm/amd/pm/amdgpu_pm.c:2814:5-8: WARNING: Unsigned expression
compared with zero: val < 0
Signed-off-by: José Pekkarinen
---
drivers/gpu/drm/amd/pm/amdgpu_pm.c | 4
1 file changed, 4 deletions(-)
diff
On 2023-10-31 17:45, Alex Deucher wrote:
On Sat, Oct 28, 2023 at 8:05 AM José Pekkarinen
wrote:
On 2023-10-27 20:55, Deucher, Alexander wrote:
> [Public]
>
>> -Original Message-----
>> From: José Pekkarinen
>> Sent: Friday, October 27, 2023 12:59 PM
>> T
-arrays)
drivers/gpu/drm/radeon/atombios.h:7355:27-35: WARNING use flexible-array member
instead
(https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
Signed-off-by: José Pekkarinen
---
[v1 -> v2] removed padding and hinted sensitive cases f
On 2023-10-31 14:20, Greg KH wrote:
On Tue, Oct 31, 2023 at 01:42:17PM +0200, José Pekkarinen wrote:
On 2023-10-31 07:48, Greg KH wrote:
> On Mon, Oct 30, 2023 at 07:17:48PM +0200, José Pekkarinen wrote:
> > This patch addresses the following warning spotted by
> > using c
On 2023-10-31 07:48, Greg KH wrote:
On Mon, Oct 30, 2023 at 07:17:48PM +0200, José Pekkarinen wrote:
This patch addresses the following warning spotted by
using coccinelle where the case checked does the same
than the else case.
drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32
m/amd/display: Add check for PState change in DCN32")
Signed-off-by: José Pekkarinen
---
.../drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c | 4
1 file changed, 4 deletions(-)
diff --git
a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
b/drivers/gpu/drm/amd/
m/amd/display: Add check for PState change in DCN32")
Cc: sta...@vger.kernel.org
Signed-off-by: José Pekkarinen
---
.../drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c | 4
1 file changed, 4 deletions(-)
diff --git
a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_ut
On 2023-10-30 15:52, Aurabindo Pillai wrote:
On 10/29/2023 8:44 AM, José Pekkarinen wrote:
This patch addresses the following warning spotted by
using coccinelle where the case checked does the same
than the else case.
drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c:4664:8
This patch addresses the following warning spotted by
using coccinelle where the case checked does the same
than the else case.
drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c:4664:8-10:
WARNING: possible condition with no effect (if == else)
Signed-off-by: José Pekkarinen
Spotted by coccicheck, there is a redundant check for
v->SourcePixelFormat[k] != dm_444_16. This patch will
remove it. The corresponding output follows.
drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c:5130:86-122:
duplicated argument to && or ||
Signed-off-by: José
On 2023-10-27 20:55, Deucher, Alexander wrote:
[Public]
-Original Message-
From: José Pekkarinen
Sent: Friday, October 27, 2023 12:59 PM
To: Deucher, Alexander ; Koenig, Christian
; Pan, Xinhui ;
sk...@linuxfoundation.org
Cc: José Pekkarinen ; airl...@gmail.com;
dan...@ffwll.ch; amd
use flexible-array member
instead
(https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
Signed-off-by: José Pekkarinen
---
drivers/gpu/drm/radeon/atombios.h | 54 +++
1 file changed, 27 insertions(+), 27 deletions(-)
diff
On 2023-09-19 19:56, Michel Dänzer wrote:
On 9/18/23 18:53, José Pekkarinen wrote:
Kasan reported the following in my system:
[ 3935.321003]
==
[ 3935.321022] BUG: KASAN: slab-use-after-free
On 2023-09-19 08:26, José Pekkarinen wrote:
Kasan reported the following in my system:
[ 3935.321003]
==
[ 3935.321022] BUG: KASAN: slab-use-after-free in
drm_atomic_helper_wait_for_vblanks.part.0+0x116/0x450 [drm_kms_helper
On 2023-09-12 09:08, José Pekkarinen wrote:
The removed line prevents the following cleanup function
to execute a dma_fence_put on the out_fence to free its
memory, producing the following output in kmemleak:
unreferenced object 0x888126d8ee00 (size 128):
comm "kwin_wayland"
772]
==
This suggest there may be some situation where a
struct drm_crtc_state is referenced after already
being freed by drm_atomic_state_default_clear. This
patch will check the new_crtc_state is not null before
using it.
Signed-off-by: José Pekkarinen
---
[v1->v2] co
772]
==
This suggest there may be some situation where a
struct drm_crtc_state is referenced after already
being freed by drm_atomic_state_default_clear. This
patch will check the new_crtc_state is not null before
using it.
Signed-off-by: José Pekkarinen
---
drivers/gpu/
On 2023-09-13 12:50, Maxime Ripard wrote:
Hi,
On Wed, Sep 13, 2023 at 11:32:23AM +0300, José Pekkarinen wrote:
Running drm_exec_test by modprobing the module I
observe the following output:
[ 424.471936] KTAP version 1
[ 424.471942] 1..1
[ 424.472446] KTAP version 1
[ 424.472450
643] ok 1 drm_exec
Signed-off-by: José Pekkarinen
---
drivers/gpu/drm/tests/drm_exec_test.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/drivers/gpu/drm/tests/drm_exec_test.c
b/drivers/gpu/drm/tests/drm_exec_test.c
index 563949d777dd..7ff6bc6467d4 100644
--- a/drivers/gpu/
On 2023-09-13 17:41, mrip...@kernel.org wrote:
On Wed, Sep 13, 2023 at 05:01:40PM +0300, José Pekkarinen wrote:
On 2023-09-13 12:50, Maxime Ripard wrote:
> Hi,
>
> On Wed, Sep 13, 2023 at 11:32:23AM +0300, José Pekkarinen wrote:
> > Running drm_exec_test by modprobing the modul
fail:0 skip:0 total:4
[ 1098.941546] # Totals: pass:4 fail:0 skip:0 total:4
[ 1098.941556] ok 1 drm_modes_analog_tv
Signed-off-by: José Pekkarinen
---
drivers/gpu/drm/tests/drm_modes_test.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers/gpu/drm/tests/drm_modes_tes
On 2023-09-14 15:00, Maxime Ripard wrote:
On Wed, Sep 13, 2023 at 07:35:57PM +0300, José Pekkarinen wrote:
On 2023-09-13 17:41, mrip...@kernel.org wrote:
> On Wed, Sep 13, 2023 at 05:01:40PM +0300, José Pekkarinen wrote:
> > On 2023-09-13 12:50, Maxime Ripard wrote:
> > > Hi,
entry_SYSCALL_64_after_hwframe+0x6e/0xd8
[...]
This memleak will grow quickly, being possible to see the
following line in dmesg after few minutes of life in the
virtual machine:
[ 706.217388] kmemleak: 10731 new suspected memory leaks (see
/sys/kernel/debug/kmemleak)
The patch will re
39 matches
Mail list logo
