[RFC] drm: Parse HDMI 2.0 YCbCr 4:2:0 VDB and VCB

2017-01-09 Thread Jose Abreu
Hi Shashank, Thanks for the review. On 09-01-2017 05:22, Sharma, Shashank wrote: > Regards > > Shashank > > > On 12/30/2016 10:23 PM, Jose Abreu wrote: >> HDMI 2.0 introduces a new sampling mode called YCbCr 4:2:0. >> According to the spec the EDID may con

[PATCH v2 17/29] drm: bridge: dw-hdmi: Refactor PHY power handling

2017-01-06 Thread Jose Abreu
Hi Laurent, Sorry for the delayed answer but I am quite busy at the moment. On 06-01-2017 01:48, Laurent Pinchart wrote: [snip] The TX_READY signal is documented in the i.MX6 datasheet as being a PHY output signal, but there seems to be no HDMI TX register from which its state

[PATCH v2 17/29] drm: bridge: dw-hdmi: Refactor PHY power handling

2017-01-05 Thread Jose Abreu
Hi Laurent, On 05-01-2017 12:29, Laurent Pinchart wrote: > Hi Jose, > > On Tuesday 20 Dec 2016 12:17:23 Jose Abreu wrote: >> On 20-12-2016 11:45, Russell King - ARM Linux wrote: >>> On Tue, Dec 20, 2016 at 03:33:48AM +0200, Laurent Pinchart wrote: >>>> Instea

[RFC] drm: Parse HDMI 2.0 YCbCr 4:2:0 VDB and VCB

2017-01-05 Thread Jose Abreu
Hi Ville, On 05-01-2017 11:46, Ville Syrjälä wrote: > On Thu, Jan 05, 2017 at 10:07:45AM +0000, Jose Abreu wrote: >> Hi Ville, >> >> >> On 04-01-2017 16:36, Ville Syrjälä wrote: >>> On Wed, Jan 04, 2017 at 04:15:01PM +, Jose Abreu wrote: >>

[PATCH v2 16/29] drm: bridge: dw-hdmi: Detect PHY type at runtime

2017-01-05 Thread Jose Abreu
Hi Laurent, On 05-01-2017 11:44, Laurent Pinchart wrote: [snip] >>> I've tried moving SVSRET right before the reset and everything still seems >>> to work fine, so I'll submit a patch. >>> >>> Is the rest of the sequence correct ? When should SVSRET be deasserted >>> (the driver currently

[PATCH v2 16/29] drm: bridge: dw-hdmi: Detect PHY type at runtime

2017-01-05 Thread Jose Abreu
Hi Laurent, On 05-01-2017 00:15, Laurent Pinchart wrote: > Hi Jose, > > On Tuesday 20 Dec 2016 15:01:52 Jose Abreu wrote: >> On 20-12-2016 13:11, Laurent Pinchart wrote: >>> On Tuesday 20 Dec 2016 11:39:21 Jose Abreu wrote: >>>> On 20-12-2016 01:33, Laurent

[RFC] drm: Parse HDMI 2.0 YCbCr 4:2:0 VDB and VCB

2017-01-05 Thread Jose Abreu
Hi Ville, On 04-01-2017 16:36, Ville Syrjälä wrote: > On Wed, Jan 04, 2017 at 04:15:01PM +0000, Jose Abreu wrote: >> [snip] >>> Why does userspace need to know this? My thinking has been that the >>> driver would do the right thing automagically. >>&g

[RFC] drm: Parse HDMI 2.0 YCbCr 4:2:0 VDB and VCB

2017-01-04 Thread Jose Abreu
Hi Ville, On 04-01-2017 13:22, Ville Syrjälä wrote: > On Fri, Dec 30, 2016 at 04:53:16PM +0000, Jose Abreu wrote: >> HDMI 2.0 introduces a new sampling mode called YCbCr 4:2:0. >> According to the spec the EDID may contain two blocks that >> signal this sampling mode:

[RFC] drm: Parse HDMI 2.0 YCbCr 4:2:0 VDB and VCB

2017-01-04 Thread Jose Abreu
Hi Daniel, On 04-01-2017 08:34, Daniel Vetter wrote: > On Fri, Dec 30, 2016 at 04:53:16PM +0000, Jose Abreu wrote: >> HDMI 2.0 introduces a new sampling mode called YCbCr 4:2:0. >> According to the spec the EDID may contain two blocks that >> signal this sampling mode:

[RFC v2] drm: Parse HDMI 2.0 YCbCr 4:2:0 VDB and VCB

2017-01-02 Thread Jose Abreu
. The reason this is still a RFC is because there is no reference in kernel for this new sampling mode (specially in AVI infoframe part), so, I was hoping to hear some feedback first. Tested in a HDMI 2.0 compliance scenario. Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: Daniel Vetter Cc: Jani

[RFC] drm: Parse HDMI 2.0 YCbCr 4:2:0 VDB and VCB

2016-12-30 Thread Jose Abreu
. The reason this is still a RFC is because there is no reference in kernel for this new sampling mode (specially in AVI infoframe part), so, I was hoping to hear some feedback first. Tested in a HDMI 2.0 compliance scenario. Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: Daniel Vetter Cc: Jani

[PATCH] drm: clean cached display info

2016-12-29 Thread Jose Abreu
s-qhY=wGqvHYK00VvbUVGun4-ZhK6KZ4Ht_lHwPGfC6ajlzxE=7YpJD-fwUixHNz9SNn2B1ijuL5mEVeEUmolbf3NqWcs= > > (still under review) and sending as individual patch. > > Cc: Jose Abreu > Cc: Daniel Vetter > > Suggested-by: Jose Abreu > Signed-off-by: Shashank Sharma > --- Reviewed-by: Jose

[Intel-gfx] [PATCH v3 3/3] drm: clean cached display info

2016-12-29 Thread Jose Abreu
Hi Shashank, On 29-12-2016 05:53, Sharma, Shashank wrote: > Regards > > Shashank > > > On 12/27/2016 3:07 PM, Daniel Vetter wrote: >> On Thu, Dec 22, 2016 at 10:21:25AM +, Jose Abreu wrote: >>> Hi Shashank, >>> >>> >>> On 21-12-201

[PATCH v3 3/3] drm: clean cached display info

2016-12-22 Thread Jose Abreu
te, avoiding any errors due to invalid cached data. > > Cc: Jose Abreu > > Suggested-by: Jose Abreu > Signed-off-by: Shashank Sharma > --- > drivers/gpu/drm/drm_probe_helper.c | 20 > 1 file changed, 20 insertions(+) > > diff --git a/drivers/g

[PATCH v3 2/3] drm: parse hf-vsdb

2016-12-22 Thread Jose Abreu
- Fix the bit nos for YUV420 deep color macros > - write HDMI_IEEE_OUI_HFVSDB value in lower case > > Cc: Thierry Reding > Cc: Daniel Vetter > Cc: Jose Abreu > Signed-off-by: Shashank Sharma Looks good by me. I don't have the setup to test it right now,

[PATCH v3 1/3] drm: Create new structure for HDMI info

2016-12-22 Thread Jose Abreu
Hi Shashank, On 21-12-2016 15:29, Shashank Sharma wrote: [snip] > + > + /** > + * @edid_yuv420_dc_modes: bpc for deep color yuv420 encoding. > + * various sinks can support 10/12/16 bit per channel deep > + * color encoding. edid_yuv420_dc_modes = 0 means sink doesn't > +

[PATCH v2 1/2] drm: Create new structure for HDMI info

2016-12-21 Thread Jose Abreu
Hi Shashank, On 21-12-2016 03:49, Sharma, Shashank wrote: > Thanks for the review Jose. > > My comments, inline. > > Regards > Shashank > On 12/20/2016 7:49 PM, Jose Abreu wrote: >> Hi Shashank, >> >> >> On 20-12-2016 13:47, Shashank Sharma

[PATCH v2 16/29] drm: bridge: dw-hdmi: Detect PHY type at runtime

2016-12-20 Thread Jose Abreu
Hi Laurent, On 20-12-2016 13:11, Laurent Pinchart wrote: > Hi Jose, > > On Tuesday 20 Dec 2016 11:39:21 Jose Abreu wrote: >> On 20-12-2016 01:33, Laurent Pinchart wrote: >>> Detect the PHY type and use it to handle the PHY type-specific SVSRET >>> signal. >&g

[PATCH v2 2/2] drm: parse hf-vsdb

2016-12-20 Thread Jose Abreu
ros of 36 and 30-bit depths > - Added a sub-class for HDMI related information within drm_display_info > (Thierry, Daniel) and populated it with HF-VSDB specific info. > > Cc: Thierry Reding > Cc: Daniel Vetter > Cc: Jose Abreu > Signed-off-by: Shashank Sharma > --- > dri

[PATCH v2 1/2] drm: Create new structure for HDMI info

2016-12-20 Thread Jose Abreu
rrect values in this structure. > We are adding parsing of HF-VSDB In the next patch. > > Cc: Thierry Reding > Cc: Daniel Vetter > Cc: Jose Abreu > Suggested-by: Thierry Reding > Signed-off-by: Shashank Sharma > --- > drivers/gpu/drm/drm_edid.c | 6 +

[PATCH v2 17/29] drm: bridge: dw-hdmi: Refactor PHY power handling

2016-12-20 Thread Jose Abreu
Hi Russell, On 20-12-2016 11:45, Russell King - ARM Linux wrote: > On Tue, Dec 20, 2016 at 03:33:48AM +0200, Laurent Pinchart wrote: >> Instead of spreading version-dependent PHY power handling code around, >> group it in two functions to power the PHY on and off and use them >> through the

[PATCH v2 16/29] drm: bridge: dw-hdmi: Detect PHY type at runtime

2016-12-20 Thread Jose Abreu
Hi Laurent, On 20-12-2016 01:33, Laurent Pinchart wrote: > Detect the PHY type and use it to handle the PHY type-specific SVSRET > signal. > > Signed-off-by: Laurent Pinchart > --- > drivers/gpu/drm/bridge/dw-hdmi.c | 68 >

[PATCH v2 15/29] drm: bridge: dw-hdmi: Handle overflow workaround based on device version

2016-12-20 Thread Jose Abreu
pinchart+renesas at ideasonboard.com> Reviewed-by: Jose Abreu Best regards, Jose Miguel Abreu > --- > drivers/gpu/drm/bridge/dw-hdmi.c | 46 > > 1 file changed, 33 insertions(+), 13 deletions(-) > > diff --git a/drivers/gpu/drm/bridg

[PATCH v2 14/29] drm: bridge: dw-hdmi: Detect AHB audio DMA using correct register

2016-12-20 Thread Jose Abreu
t.pinchart+renesas at ideasonboard.com> Reviewed-by: Jose Abreu Best regards, Jose Miguel Abreu > --- > drivers/gpu/drm/bridge/dw-hdmi.c | 6 +++--- > drivers/gpu/drm/bridge/dw-hdmi.h | 4 > 2 files changed, 7 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/dr

[PATCH v2 13/29] drm: bridge: dw-hdmi: Reject invalid product IDs

2016-12-20 Thread Jose Abreu
w register values. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas at ideasonboard.com> Reviewed-by: Jose Abreu > --- > drivers/gpu/drm/bridge/dw-hdmi.c | 25 +++-- > drivers/gpu/drm/bridge/dw-hdmi.h | 8 > 2 files changed, 27 ins

[PATCH v2 12/29] drm: bridge: dw-hdmi: Rename CONF0 SPARECTRL bit to SVSRET

2016-12-20 Thread Jose Abreu
name the bit accordingly. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas at ideasonboard.com> Reviewed-by: Jose Abreu > --- > drivers/gpu/drm/bridge/dw-hdmi.c | 8 > drivers/gpu/drm/bridge/dw-hdmi.h | 4 ++-- > 2 files changed, 6 insertions(+),

[PATCH v2 3/3] drm/edid: Implement SCDC Read Request capability detection

2016-12-06 Thread Jose Abreu
Hi Daniel, On 06-12-2016 08:23, Daniel Vetter wrote: > On Mon, Dec 05, 2016 at 05:37:22PM +0100, Thierry Reding wrote: >> On Mon, Dec 05, 2016 at 02:19:48PM +0000, Jose Abreu wrote: >>> Hi Thierry, >>> >>> >>> On 05-12-2016 11:14, Thierry Reding w

[PATCH v2 3/3] drm/edid: Implement SCDC Read Request capability detection

2016-12-05 Thread Jose Abreu
Hi Thierry, On 05-12-2016 11:14, Thierry Reding wrote: > On Mon, Dec 05, 2016 at 11:06:15AM +0000, Jose Abreu wrote: >> Hi Thierry, >> >> >> Do you think while you are at it you could implement a >> set_scrambling() callback? It should be pretty straight forward:

[PATCH v2 1/3] drm: Add SCDC helpers

2016-12-05 Thread Jose Abreu
Hi, On 05-12-2016 13:31, Ville Syrjälä wrote: > On Mon, Dec 05, 2016 at 12:16:52PM +0100, Thierry Reding wrote: >> On Mon, Dec 05, 2016 at 10:12:39AM +0000, Jose Abreu wrote: >>> On 02-12-2016 19:24, Thierry Reding wrote: >> [...] >>>> +/** >>>

[PATCH 13/22] drm: bridge: dw-hdmi: Replace device type with platform quirks

2016-12-05 Thread Jose Abreu
Hi Laurent, On 05-12-2016 11:32, Laurent Pinchart wrote: > Hi Jose, > > On Monday 05 Dec 2016 10:50:19 Jose Abreu wrote: >> On 02-12-2016 15:43, Laurent Pinchart wrote: >>> On Friday 02 Dec 2016 14:24:01 Russell King - ARM Linux wrote: >>>> On Fri, Dec 0

[PATCH v2 3/3] drm/edid: Implement SCDC Read Request capability detection

2016-12-05 Thread Jose Abreu
Hi Thierry, Do you think while you are at it you could implement a set_scrambling() callback? It should be pretty straight forward: you read the SCDC_TMDS_CONFIG reg, do a mask, and then write it again. I think this is an important feature that we should have. Best regards, Jose Miguel

[PATCH 13/22] drm: bridge: dw-hdmi: Replace device type with platform quirks

2016-12-05 Thread Jose Abreu
Hi Laurent, On 02-12-2016 15:43, Laurent Pinchart wrote: > Hi Russell, > > On Friday 02 Dec 2016 14:24:01 Russell King - ARM Linux wrote: >> On Fri, Dec 02, 2016 at 01:43:28AM +0200, Laurent Pinchart wrote: >>> From: Kieran Bingham >>> >>> The dw-hdmi

[PATCH v2 1/3] drm: Add SCDC helpers

2016-12-05 Thread Jose Abreu
Hi Thierry, On 02-12-2016 19:24, Thierry Reding wrote: > From: Thierry Reding > > SCDC is a mechanism defined in the HDMI 2.0 specification that allows > the source and sink devices to communicate. > > This commit introduces helpers to access the SCDC and provides the > symbolic names for the

[PATCH 12/22] drm: bridge: dw-hdmi: Abstract the platform PHY configuration

2016-12-02 Thread Jose Abreu
Hi Laurent, On 01-12-2016 23:43, Laurent Pinchart wrote: > From: Kieran Bingham > > Platforms implement the dw-hdmi with a separate PHY entity. It is > configured over it's own I2C bus. To allow for different PHY's to be > configured from the dw-hdmi

[PATCH 00/22] R-Car Gen3 HDMI output support

2016-12-02 Thread Jose Abreu
pu/drm/rcar-du/rcar_du_regs.h | 23 ++ > drivers/gpu/drm/rcar-du/rcar_dw_hdmi.c | 105 ++ > drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c| 17 +- > include/drm/bridge/dw_hdmi.h | 35 +- > 21 files changed, 765 insertions(+), 295 deletions(-) > create mode 100644 > Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt > create mode 100644 drivers/gpu/drm/rcar-du/rcar_dw_hdmi.c > Patches 01 to 13 are: Reviewed-by: Jose Abreu I have one minor comment for patch 12. Best regards, Jose Miguel Abreu

Question regarding clocks in the DW-HDMI DT bindings

2016-11-29 Thread Jose Abreu
Hi Laurent, On 28-11-2016 19:19, Laurent Pinchart wrote: > Hi Jose, > > On Monday 28 Nov 2016 15:25:18 Jose Abreu wrote: >> On 28-11-2016 14:24, Laurent Pinchart wrote: >>> On Monday 28 Nov 2016 12:09:59 Jose Abreu wrote: >>>> On 28-11-2016 11:45, Laurent Pi

Question regarding clocks in the DW-HDMI DT bindings

2016-11-28 Thread Jose Abreu
Hi Laurent, On 28-11-2016 14:24, Laurent Pinchart wrote: > Hi Jose, > > On Monday 28 Nov 2016 12:09:59 Jose Abreu wrote: >> On 28-11-2016 11:45, Laurent Pinchart wrote: >>> On Monday 28 Nov 2016 19:34:59 Andy Yan wrote: >>>> On 2016年11月26日 03:26, Lauren

Question regarding clocks in the DW-HDMI DT bindings

2016-11-28 Thread Jose Abreu
Hi All, On 28-11-2016 11:45, Laurent Pinchart wrote: > Hi Andy, > > (CC'ing Kieran Bingham) > > On Monday 28 Nov 2016 19:34:59 Andy Yan wrote: >> On 2016年11月26日 03:26, Laurent Pinchart wrote: >>> On Friday 25 Nov 2016 17:08:13 Philipp Zabel wrote: Am Freitag, den 25.11.2016, 17:45

[PATCH 1/2] Revert "drm: Add and handle new aspect ratios in DRM layer"

2016-11-15 Thread Jose Abreu
Hi, On 15-11-2016 10:52, Daniel Vetter wrote: > On Tue, Nov 15, 2016 at 03:36:02PM +0530, Sharma, Shashank wrote: >> On 11/15/2016 3:30 PM, Daniel Vetter wrote: >>> On Tue, Nov 15, 2016 at 02:30:47PM +0530, Sharma, Shashank wrote: On 11/15/2016 2:21 PM, Daniel Vetter wrote: > On Mon,

[PATCH] drm: Complete CEA modedb(VIC 1-107)

2016-10-20 Thread Jose Abreu
; +3840, 4016, 4104, 4400, 0, > +2160, 2168, 2178, 2250, 0, > +DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC), > + .vrefresh = 25, .picture_aspect_ratio = HDMI_PICTURE_ASPECT_64_27}, 4016 should be instead 4896. 4104 should be instead 4984. 44

[PATCH v3 0/4]: Picture aspect ratio support in DRM layer

2016-10-17 Thread Jose Abreu
Hi Shashank, On 17-10-2016 12:32, Shashank Sharma wrote: > This patch series adds 4 patches. > - The first two patches add aspect ratio support in DRM layes > - Next two patches add new aspect ratios defined in CEA-861-F > supported for HDMI 2.0 4k modes. > > Adding aspect ratio support in DRM

[PATCH RESEND] drm: bridge/dw-hdmi: Fix colorspace and scan information registers values

2016-08-29 Thread Jose Abreu
On 29-08-2016 10:21, Russell King - ARM Linux wrote: > On Mon, Aug 29, 2016 at 10:17:04AM +0100, Jose Abreu wrote: >> Colorspace and scan information values were being written in wrong >> offsets. This patch corrects this and writes the values at the >> offsets spec

[PATCH v2 0/4] Picture aspect ratio support in DRM layer

2016-08-18 Thread Jose Abreu
arma (4): > drm: add picture aspect ratio flags > drm: Add aspect ratio parsing in DRM layer > video: Add new aspect ratios for HDMI 2.0 > drm: Add and handle new aspect ratios in DRM layer I am using these patches to run HDMI 2.0 compliance so: Tested-by: Jose Abreu I als

[PATCH] drm: bridge/dw-hdmi: Fix colorspace and scan information registers values

2016-08-18 Thread Jose Abreu
Colorspace and scan information values were being written in wrong offsets. This patch corrects this and writes the values at the offsets specified in the databook. Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: David Airlie Cc: Russell King <rmk+kernel at arm.linux.org.uk> Cc:

drm/bridge: dw_hdmi: Colorspace registers

2016-08-17 Thread Jose Abreu
Hi Russell, On 17-08-2016 12:21, Russell King - ARM Linux wrote: > On Wed, Aug 17, 2016 at 10:33:10AM +0100, Jose Abreu wrote: >> Hi Russell, >> >> When using driver dw-hdmi in any other colorspace than RGB the >> Y1, Y0 and YCC values are not corre

drm/bridge: dw_hdmi: Colorspace registers

2016-08-17 Thread Jose Abreu
Hi Russell, When using driver dw-hdmi in any other colorspace than RGB the Y1, Y0 and YCC values are not correct. I confirmed in databook that these registers are being written to the wrong offset (per my databook they should be written in bits 0:1 and 7 instead of bits 4:5). The piece of code in

[PATCH] drm: edid: HDMI 2.0 HF-VSDB block parsing

2016-08-12 Thread Jose Abreu
Hi Ville, On 12-08-2016 14:46, Ville Syrjälä wrote: > On Wed, Aug 10, 2016 at 04:29:21PM +0100, Jose Abreu wrote: >> Adds parsing for HDMI 2.0 'HDMI Forum Vendor >> Specific Data Block'. This block is present in >> some HDMI 2.0 EDID's and gives information about >&g

[PATCH] drm: edid: HDMI 2.0 HF-VSDB block parsing

2016-08-10 Thread Jose Abreu
Adds parsing for HDMI 2.0 'HDMI Forum Vendor Specific Data Block'. This block is present in some HDMI 2.0 EDID's and gives information about scrambling support, SCDC, 3D Views, and others. Parsed parameters are stored in drm_connector structure. Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc

[Intel-gfx] [PATCH 1/4] drm: add picture aspect ratio flags

2016-08-09 Thread Jose Abreu
Hi Sharma, On 05-08-2016 04:37, Sharma, Shashank wrote: > Regards > > Shashank > > > On 8/4/2016 9:39 PM, Daniel Vetter wrote: >> On Thu, Aug 04, 2016 at 03:31:45PM +0100, Emil Velikov wrote: >>> On 4 August 2016 at 14:15, Sharma, Shashank >>> wrote: On 8/4/2016 5:04 PM, Emil Velikov

[PATCH 3/3 v3] drm: bridge/dw-hdmi: Move edid reading to .detect() callback

2016-08-08 Thread Jose Abreu
Hi, On 05-08-2016 09:13, Chris Wilson wrote: > On Fri, Aug 05, 2016 at 10:06:08AM +0200, Daniel Vetter wrote: >> On Fri, Aug 05, 2016 at 12:01:25AM +0100, Russell King - ARM Linux wrote: >>> On Thu, Aug 04, 2016 at 06:13:18PM +0100, Jose Abreu wrote: >>>> Hi Russe

HDMI 2.0 Support

2016-08-08 Thread Jose Abreu
Hi, Currently I am working on some HDMI 2.0 features using the DRM infrastructure. I am mainly working in parsing the newly introduced EDID blocks such as HDMI Forum Vendor Specific Data Block, YCBCR 420 Video Data Block and YCBCR Capability Map Data Block. The new blocks require some changes in

[PATCH 3/3 v3] drm: bridge/dw-hdmi: Move edid reading to .detect() callback

2016-08-04 Thread Jose Abreu
Hi Russell, On 04-08-2016 16:04, Russell King - ARM Linux wrote: > On Thu, Aug 04, 2016 at 03:57:21PM +0100, Jose Abreu wrote: >> Hmm, I am not debugging it right now but I remember that >> drm_fb_helper_probe_connector_modes() was not being called at the >> time I set

[PATCH 2/3 v3] drm: bridge/dw-hdmi: Enable ISCR1, ISCR2 and ACP packets

2016-08-04 Thread Jose Abreu
Hi Russell, On 04-08-2016 16:32, Russell King - ARM Linux wrote: > On Thu, Aug 04, 2016 at 11:44:50AM +0100, Jose Abreu wrote: >> Currently ISCR and ACP packets are not being sent causing >> HDMI compliance tests like CTS 7-19 HDMI 1.4b to fail. > Hmm. Reading the HDMI sp

[PATCH 0/4]: Picture aspect ratio support in DRM layer

2016-08-04 Thread Jose Abreu
On 04-08-2016 15:29, Sharma, Shashank wrote: > Regards > > Shashank > > > On 8/4/2016 7:46 PM, Jose Abreu wrote: >> Hi Sharma, >> >> >> On 03-08-2016 16:47, Sharma, Shashank wrote: >>> Hello Joes, >>>> I've also seen this before and

[PATCH 3/3 v3] drm: bridge/dw-hdmi: Move edid reading to .detect() callback

2016-08-04 Thread Jose Abreu
Hi Russell, On 04-08-2016 15:31, Russell King - ARM Linux wrote: > On Thu, Aug 04, 2016 at 02:58:00PM +0100, Jose Abreu wrote: >> Hi Russell, >> >> I am not sure if this is a bug in DRM or a bad implementation of >> dw-hdmi. I've seen at least two more drivers

[PATCH 0/4]: Picture aspect ratio support in DRM layer

2016-08-04 Thread Jose Abreu
modeset back to libdrm. Do you mean Xserver, the X driver that I am using (which is modesetting), the xrandr or all of them? I guess that if they don't touch the flags field and return the mode exactly the same as it was probed to DRM then it will work as expected. Best regards, Jose Miguel

[PATCH 3/3 v3] drm: bridge/dw-hdmi: Move edid reading to .detect() callback

2016-08-04 Thread Jose Abreu
Hi Russell, On 04-08-2016 11:47, Russell King - ARM Linux wrote: > On Thu, Aug 04, 2016 at 11:44:51AM +0100, Jose Abreu wrote: >> When running HDMI compliance tests we noticed that sometimes >> the edid changes but the get_modes() function is not called >> so the edid i

[PATCH 3/3 v3] drm: bridge/dw-hdmi: Move edid reading to .detect() callback

2016-08-04 Thread Jose Abreu
When running HDMI compliance tests we noticed that sometimes the edid changes but the get_modes() function is not called so the edid is not updated. Moving the edid reading to the detect() callback ensures that the edid is correctly updated after an hotplug. Signed-off-by: Jose Abreu Cc: Carlos

[PATCH 2/3 v3] drm: bridge/dw-hdmi: Enable ISCR1, ISCR2 and ACP packets

2016-08-04 Thread Jose Abreu
Currently ISCR and ACP packets are not being sent causing HDMI compliance tests like CTS 7-19 HDMI 1.4b to fail. With this pacth the mentioned packets are activated when needed. Verified using HDMI compliance equipment. Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: Archit Taneja Cc

[PATCH 1/3 v3] drm: bridge/dw-hdmi: Add support for DWC Phy

2016-08-04 Thread Jose Abreu
and validated. This is specific to Synopsys Phy. Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: Archit Taneja Cc: David Airlie Cc: Russell King <rmk+kernel at arm.linux.org.uk> Cc: Fabio Estevam Cc: Daniel Vetter Cc: Takashi Iwai Cc: Vladimir Zapolskiy Cc: Thierry Reding Cc: dri

[PATCH 0/3 v3] drm: bridge/dw-hdmi: Fixes for dw-hdmi and DWC support

2016-08-04 Thread Jose Abreu
Cc: Thierry Reding Cc: dri-devel at lists.freedesktop.org Cc: linux-kernel at vger.kernel.org Jose Abreu (3): drm: bridge/dw-hdmi: Add support for DWC Phy drm: bridge/dw-hdmi: Enable ISCR1, ISCR2 and ACP packets drm: bridge/dw-hdmi: Move edid reading to .detect() callback drivers/gpu/d

[PATCH 0/4]: Picture aspect ratio support in DRM layer

2016-08-03 Thread Jose Abreu
Hi, On 03-08-2016 12:48, Daniel Vetter wrote: > On Wed, Aug 03, 2016 at 04:26:24PM +0530, Shashank Sharma wrote: >> This patch series adds 4 patches. >> - The first two patches add aspect ratio support in DRM layes >> - Next two patches add new aspect ratios defined in CEA-861-F >> supported

[PATCH 1/3] drm: bridge: add DesignWare HDMI I2S audio support

2016-08-01 Thread Jose Abreu
Thank you for your test. I'm happy if it could have it. > > Mark, Thierry, Daniel > I wonder who can be maintainer for this patch ?? > > Best regards > --- > Kuninori Morimoto Tested-by: Jose Abreu Best regards, Jose Miguel Abreu

[PATCH 1/3] drm: bridge: add DesignWare HDMI I2S audio support

2016-07-28 Thread Jose Abreu
Hi, On 24-06-2016 03:40, Kuninori Morimoto wrote: > From: Kuninori Morimoto > > Current dw-hdmi is supporting sound via AHB bus, but it has > I2S audio feature too. This patch adds I2S audio support to dw-hdmi. > This HDMI I2S is supported by using ALSA SoC common HDMI encoder > driver. > >

DMA, CMA and SWIOTLB

2016-06-29 Thread Jose Abreu
Hi all, I am writing a very simple KMS driver that uses Xilinx VDMA to transfer data between the host and a FPGA. To handle memory allocation for DMA I am using the CMA helpers available in the DRM subsystem. When setting for low video modes (small memory requirements) everything works fine, but

[PATCH v2] drm: bridge/dw-hdmi: Add support for DWC Phy

2016-06-28 Thread Jose Abreu
if this is specific to Synopsys Phy we only set this if Phy type is DWC_HDMI. Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: David Airlie Cc: Russell King <rmk+kernel at arm.linux.org.uk> Cc: Fabio Estevam Cc: Daniel Vetter Cc: Takashi Iwai Cc: Vladimir Zapolskiy Cc: Thierry Redi

DRM DMA Engine

2016-06-20 Thread Jose Abreu
Hi Ilia, Thanks for your answer. On 16-06-2016 13:39, Ilia Mirkin wrote: > On Thu, Jun 16, 2016 at 8:09 AM, Jose Abreu > wrote: >> Hi Daniel, >> >> Sorry to bother you again. I promise this is the last time :) >> >> On 15-06-2016 11:15, Daniel Vetter wrote:

DRM DMA Engine

2016-06-16 Thread Jose Abreu
Hi Daniel, Sorry to bother you again. I promise this is the last time :) On 15-06-2016 11:15, Daniel Vetter wrote: > On Wed, Jun 15, 2016 at 11:48 AM, Jose Abreu > wrote: >> On 15-06-2016 09:52, Daniel Vetter wrote: >>> On Tue, Jun 14, 2016 at 1:19 PM, Jose Abreu >

DRM DMA Engine

2016-06-15 Thread Jose Abreu
Hi Daniel, On 15-06-2016 09:52, Daniel Vetter wrote: > On Tue, Jun 14, 2016 at 1:19 PM, Jose Abreu > wrote: >>> I assume that xilinx VDMA is the only way to feed pixel data into your >>> display pipeline. Under that assumption: >>> >>> drm_plane sh

DRM DMA Engine

2016-06-14 Thread Jose Abreu
Hi Daniel, On 30-05-2016 10:36, Daniel Vetter wrote: > On Mon, May 30, 2016 at 10:00:56AM +0100, Jose Abreu wrote: >> ++ Daniel >> >> >> On 30-05-2016 09:44, Jose Abreu wrote: >>> Hi Daniel, >>> >>> Thanks for your answer. >>> &g

[PATCH] drm: bridge/dw-hdmi: Add support for DWC Phy

2016-06-13 Thread Jose Abreu
This patch adds support for the Synopsys HDMI TX Phy in bridge dw-hdmi. The init flow is the same as the Rockchip Phy so we only need to add one define and one if statement. Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: David Airlie Cc: dri-devel at lists.freedesktop.org Cc: linux-kernel

DRM DMA Engine

2016-05-30 Thread Jose Abreu
++ Daniel On 30-05-2016 09:44, Jose Abreu wrote: > Hi Daniel, > > Thanks for your answer. > > On 26-05-2016 09:06, Daniel Vetter wrote: >> On Wed, May 25, 2016 at 04:46:15PM +0100, Jose Abreu wrote: >>> Hi all, >>> >>> Currently I am trying to de

DRM DMA Engine

2016-05-30 Thread Jose Abreu
Hi Daniel, Thanks for your answer. On 26-05-2016 09:06, Daniel Vetter wrote: > On Wed, May 25, 2016 at 04:46:15PM +0100, Jose Abreu wrote: >> Hi all, >> >> Currently I am trying to develop a DRM driver that will use >> Xilinx VDMA to transfer video data to a HDM

DRM DMA Engine

2016-05-25 Thread Jose Abreu
Hi all, Currently I am trying to develop a DRM driver that will use Xilinx VDMA to transfer video data to a HDMI TX Phy and I am facing a difficulty regarding the understanding of the DRM DMA Engine. I looked at several sources and at the DRM core source but the flow of creating and interfacing

DRM DMA Engine

2016-05-25 Thread Jose Abreu
Hi all, Currently I am trying to develop a DRM driver that will use Xilinx VDMA to transfer video data to a HDMI TX Phy and I am facing a difficulty regarding the understanding of the DRM DMA Engine. I looked at several sources and at the DRM core source but the flow of creating and interfacing

[alsa-devel] [PATCH 2/5 v4] drm/i2c/adv7511: Add audio support

2016-04-11 Thread Jose Abreu
Hi Lars, On 11-04-2016 13:23, Lars-Peter Clausen wrote: > On 04/11/2016 01:32 PM, Jose Abreu wrote: >> Hi Lars, >> >> >> On 11-04-2016 10:33, Lars-Peter Clausen wrote: >>> On 04/11/2016 11:27 AM, Jose Abreu wrote: >>>> Hi Lars, >>>

[alsa-devel] [PATCH 2/5 v4] drm/i2c/adv7511: Add audio support

2016-04-11 Thread Jose Abreu
Hi Lars, On 11-04-2016 10:33, Lars-Peter Clausen wrote: > On 04/11/2016 11:27 AM, Jose Abreu wrote: >> Hi Lars, >> >> >> On 09-04-2016 16:02, Lars-Peter Clausen wrote: >>> On 04/08/2016 06:12 PM, Jose Abreu wrote: >>> [...] >>>>>

[alsa-devel] [PATCH 2/5 v4] drm/i2c/adv7511: Add audio support

2016-04-11 Thread Jose Abreu
Hi Lars, On 09-04-2016 16:02, Lars-Peter Clausen wrote: > On 04/08/2016 06:12 PM, Jose Abreu wrote: > [...] >>> [...] >>>> +- adi,enable-audio: If set the ADV7511 driver will register a codec >>>> interface >>>> + into ALSA SoC. >>>

[alsa-devel] [PATCH 5/5 v4] ASoC: dwc: Update DOCUMENTATION for I2S Driver

2016-04-11 Thread Jose Abreu
Hi Lars, On 09-04-2016 15:55, Lars-Peter Clausen wrote: > On 04/08/2016 06:08 PM, Jose Abreu wrote: >> Hi Lars, >> >> >> On 08-04-2016 16:52, Lars-Peter Clausen wrote: >>> On 04/08/2016 12:06 PM, Jose Abreu wrote: >>>> Hi Mark, >>>> &

[alsa-devel] [PATCH 2/5 v4] drm/i2c/adv7511: Add audio support

2016-04-08 Thread Jose Abreu
Hi Lars, On 08-04-2016 16:46, Lars-Peter Clausen wrote: > On 04/07/2016 06:53 PM, Jose Abreu wrote: >> This patch adds audio support for the ADV7511 HDMI transmitter >> using ALSA SoC. >> >> The code was ported from Analog Devices linux tree from >> commit 177

[alsa-devel] [PATCH 5/5 v4] ASoC: dwc: Update DOCUMENTATION for I2S Driver

2016-04-08 Thread Jose Abreu
Hi Lars, On 08-04-2016 16:52, Lars-Peter Clausen wrote: > On 04/08/2016 12:06 PM, Jose Abreu wrote: >> Hi Mark, >> >> >> On 07-04-2016 18:53, Mark Brown wrote: >>> On Thu, Apr 07, 2016 at 05:53:59PM +0100, Jose Abreu wrote: >>> >>>> +

[PATCH 5/5 v4] ASoC: dwc: Update DOCUMENTATION for I2S Driver

2016-04-08 Thread Jose Abreu
Hi Mark, On 07-04-2016 18:53, Mark Brown wrote: > On Thu, Apr 07, 2016 at 05:53:59PM +0100, Jose Abreu wrote: > >> + Optional properties: >> + - snps,use-dmaengine: If set the driver will use ALSA DMA engine. If set >> + it is required to use the properti

[PATCH 5/5 v4] ASoC: dwc: Update DOCUMENTATION for I2S Driver

2016-04-07 Thread Jose Abreu
This patch updates documentation for the Designware I2S driver. Signed-off-by: Jose Abreu --- This patch was only introduced in v4. Documentation/devicetree/bindings/sound/designware-i2s.txt | 5 + 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/sound

[PATCH 4/5 v4] ASoC: dwc: Add custom PCM driver

2016-04-07 Thread Jose Abreu
it was necessary to add this custom platform driver so that HDMI audio works in AXS boards. The selection between the use of DMA engine or custom PCM can be made using a device tree boolean parameter which was introduced in this patch ('snps,use-dmaengine'). Signed-off-by: Jose Abreu --- Changes v3

[PATCH 3/5 v4] ASoC: dwc: Use fifo depth to program FCR

2016-04-07 Thread Jose Abreu
This patch makes Designware I2S driver use the fifo depth value to program the fifo configuration register instead of using hardcoded values. Signed-off-by: Jose Abreu --- This patch was only introduced in v4. sound/soc/dwc/designware_i2s.c | 9 +++-- 1 file changed, 7 insertions(+), 2

[PATCH 2/5 v4] drm/i2c/adv7511: Add audio support

2016-04-07 Thread Jose Abreu
sinc/linux/ The audio can be disabled using menu-config and/or device tree so it is possible to use only video mode. The audio (when enabled) registers as a codec into ALSA. SPDIF DAI format was also added to ASoC as it is required by adv7511 audio. Signed-off-by: Jose Abreu --- No change

[PATCH 1/5 v4] drm/i2c/adv7511: Rename and move to separate folder

2016-04-07 Thread Jose Abreu
the adding of audio support. Signed-off-by: Jose Abreu --- No changes v3 -> v4. This patch was only introduced in v3. drivers/gpu/drm/i2c/Kconfig| 6 +--- drivers/gpu/drm/i2c/Makefile | 2 +- drivers/gpu/drm/i2c/adv7511/Kconfig|

[PATCH 0/5 v4] Add I2S/ADV7511 audio support for ARC AXS10x boards

2016-04-07 Thread Jose Abreu
suggested by Alexey Brodkin) * Removed defconfigs entries (as suggested by Alexey Brodkin) NOTE: Although the mainline I2S driver uses ALSA DMA engine, this controller can be built without DMA support so it was necessary to add this custom platform driver so that HDMI audio works in AXS boards. Jose

[PATCH 3/3 v3] ASoC: dwc: Unmask I2S interrupts only for enabled channels

2016-04-05 Thread Jose Abreu
There is no need to unmask all interrupts at I2S start. This can cause performance issues in slower platforms. Unmask only the interrupts for the used channels. Signed-off-by: Jose Abreu --- Changes v2 -> v3: * Dropped custom platform driver, using now ALSA DMA engine * Dropped IRQ hand

[PATCH 2/3 v3] drm/i2c/adv7511: Add audio support

2016-04-05 Thread Jose Abreu
sinc/linux/ The audio can be disabled using menu-config so it is possible to use only video mode. The audio (when enabled) registers as a codec into ALSA. SPDIF DAI format was also added to ASoC as it is required by adv7511 audio. Signed-off-by: Jose Abreu --- .../bindings/display/bridge/adi,a

[PATCH 1/3 v3] drm/i2c/adv7511: Rename and move to separate folder

2016-04-05 Thread Jose Abreu
the adding of audio support. Signed-off-by: Jose Abreu --- This patch was only introduced in v3. drivers/gpu/drm/i2c/Kconfig| 6 +--- drivers/gpu/drm/i2c/Makefile | 2 +- drivers/gpu/drm/i2c/adv7511/Kconfig| 6 drivers/gpu/drm/i2c

[PATCH 0/3 v3] Add I2S/ADV7511 audio support for ARC AXS10x boards

2016-04-05 Thread Jose Abreu
ine * Dropped IRQ handler for I2S Changes v1 -> v2: * DT bindings moved to separate patch (as suggested by Alexey Brodkin) * Removed defconfigs entries (as suggested by Alexey Brodkin) Jose Abreu (3): drm/i2c/adv7511: Rename and move to separate folder drm/i2c/adv7511: Add audio support ASo

[PATCH 1/3 v2] drm/i2c/adv7511: Add audio support

2016-04-05 Thread Jose Abreu
Hi Laurent, On 04-04-2016 22:41, Laurent Pinchart wrote: > Hi Jose, > > On Monday 04 Apr 2016 10:05:39 Jose Abreu wrote: >> On 01-04-2016 18:10, Laurent Pinchart wrote: >>> On Monday 28 Mar 2016 15:36:09 Jose Abreu wrote: >>>> This patch adds audio supp

[PATCH 1/3 v2] drm/i2c/adv7511: Add audio support

2016-04-04 Thread Jose Abreu
Hi Laurent, On 01-04-2016 18:10, Laurent Pinchart wrote: > Hi Jose, > > Thank you for the patch. > > On Monday 28 Mar 2016 15:36:09 Jose Abreu wrote: >> This patch adds audio support for the ADV7511 HDMI transmitter >> using ALSA SoC. >> >> The code was por

[PATCH 1/3 v2] drm/i2c/adv7511: Add audio support

2016-03-31 Thread Jose Abreu
Hi Archit, On 29-03-2016 18:03, Archit Taneja wrote: > > > On 3/29/2016 4:22 PM, Jose Abreu wrote: >> Hi Archit, >> >> On 29-03-2016 09:05, Archit Taneja wrote: >>> Hi, >>> >>> On 03/28/2016 08:06 PM, Jose Abreu wrote: >>>&

[PATCH 2/3 v2] ASoC: dwc: Add I2S HDMI audio support

2016-03-31 Thread Jose Abreu
Hi Mark, On 29-03-2016 19:22, Mark Brown wrote: > On Tue, Mar 29, 2016 at 07:03:01PM +0100, Jose Abreu wrote: > >> The major part of this patch is the adding of an ALSA platform driver so that >> audio comes out of the box in AXS boards but we also added functionalities to

[PATCH 2/3 v2] ASoC: dwc: Add I2S HDMI audio support

2016-03-29 Thread Jose Abreu
Hi Mark, On 29-03-2016 18:31, Mark Brown wrote: > On Mon, Mar 28, 2016 at 03:36:10PM +0100, Jose Abreu wrote: >> HDMI audio support was added to the AXS board using an >> I2S cpu driver and a custom platform driver. >> >> The platform driver supports two channels

[PATCH 1/3 v2] drm/i2c/adv7511: Add audio support

2016-03-29 Thread Jose Abreu
Hi Archit, On 29-03-2016 09:05, Archit Taneja wrote: > Hi, > > On 03/28/2016 08:06 PM, Jose Abreu wrote: >> This patch adds audio support for the ADV7511 HDMI transmitter >> using ALSA SoC. >> >> The code was ported from Analog Devices linux tree from >

[PATCH 2/3 v2] ASoC: dwc: Add I2S HDMI audio support

2016-03-28 Thread Jose Abreu
Hi Alexey, On 28-03-2016 16:35, Alexey Brodkin wrote: > Hi Jose, > > On Mon, 2016-03-28 at 15:36 +0100, Jose Abreu wrote: >> HDMI audio support was added to the AXS board using an >> I2S cpu driver and a custom platform driver. >> >> The platform drive

[PATCH 3/3 v2] arc: axs10x: Add support for Designware I2S on DT

2016-03-28 Thread Jose Abreu
Synopsys Designware ARC SDP boards support HDMI audio output using the ADV7511 HDMI transmitter. This patchs enables audio output using Designware I2S driver, ALSA SoC simple audio card and ADV7511 codec. Signed-off-by: Jose Abreu --- Changes v1 -> v2: * This change was introduced in

<    1   2   3   4   >