Cc: Joshua Ashton
Cc: Michel Dänzer
Cc: Aleix Pol
Cc: Xaver Hugl
Cc: Victoria Brekenfeld
Cc: Sima
Cc: Uma Shankar
Cc: Naseer Ahmed
Cc: Christopher Braga
Cc: Abhinav Kumar
Cc: Arthur Grillo
Cc: Hector Martin
Cc: Liviu Dudau
Cc: Sasha McIntosh
Cc: Chaitanya Kumar Borah
Alex Hung (10
- Fix LUTs and some issues with applying LUTs in VKMS
Cc: Ville Syrjala
Cc: Pekka Paalanen
Cc: Simon Ser
Cc: Harry Wentland
Cc: Melissa Wen
Cc: Jonas Ådahl
Cc: Sebastian Wick
Cc: Shashank Sharma
Cc: Alexander Goins
Cc: Joshua Ashton
Cc: Michel Dänzer
Cc: Aleix Pol
Cc: Xaver Hugl
Cc
Hello! I was rewriting the code in our compositor for Steam Deck,
Gamescope, to use epoll for dmabuf image waits.
I found out that using epoll + dmabufs + close(...) while it is added to
the epoll causes a NULL pointer dereference BUG in the kernel.
Using epoll_ctl with EPOLL_CTL_DEL before
; Sebastian
Wick ; Shashank Sharma
; Alexander Goins ; Joshua
Ashton ; Michel Dänzer ; Aleix Pol
; Xaver Hugl ; Victoria Brekenfeld
; Sima ; Shankar, Uma
; Naseer Ahmed ;
Christopher Braga ; Abhinav Kumar
; Arthur Grillo ; Hector
Martin ; Liviu Dudau ; Sasha
McIntosh
Subject: [RFC PATCH v2 06/17
uff there)
The reason it looked like it worked for you now is because the duplicate
was broken, so color mgmt for planes was always being marked as dirty there.
Thanks
- Joshie ✨
On 11/2/23 03:48, Joshua Ashton wrote:
On 10/5/23 18:15, Melissa Wen wrote:
Add 3D LUT property for plane co
On 10/5/23 18:15, Melissa Wen wrote:
Add 3D LUT property for plane color transformations using a 3D lookup
table. 3D LUT allows for highly accurate and complex color
transformations and is suitable to adjust the balance between color
channels. It's also more complex to manage and require more
Degamma has always been on the plane on AMD. CRTC DEGAMMA_LUT has actually
just been applying it to every plane pre-blend.
Degamma makes no sense after blending anyway.
The entire point is for it to happen before blending to blend in linear
space. Otherwise DEGAMMA_LUT and REGAMMA_LUT are the
driver-private properties for plane color management.
First add plane degamma LUT properties that means user-blob and its
size. We will add more plane color properties in the next commits. In
addition, we keep these driver-private plane properties limited by
defining AMD_PRIVATE_COLOR.
Co-develope
Thanks Harry. Looks good.
Reviewed-by: Joshua Ashton
- Joshie ✨
On 6/6/23 21:25, Harry Wentland wrote:
This patchset is based on Joshua's previous patchset [1], as well
as my previous patchset [2].
It is
- enabling support for the colorspace property in amdgpu, as well as
- allowing
-by: Joshua Ashton
Signed-off-by: Joshua Ashton
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 36 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 8 +++
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 22 ++
.../amd/display/amdgpu_dm
When we are talking about being 'prescriptive' in the API, are we
outright saying we don't want to support arbitrary 3D LUTs, or are we
just offering certain algorithms to be 'executed' for a plane/crtc/etc
in the atomic API? I am confused...
There is so much stuff to do with color, that I don't
:
>
> On 5/9/23 12:54, Joshua Ashton wrote:
> > We currently do not have a use for this as we settled on per-plane 3D
> > LUT + Shaper, but we might end up wanting to use in our scRGB stack
> > someday so I would like to keep it.
> >
>
> uAPI should always have a
I am okay with us dropping the shaper + 3D LUT from crtc. It has
problems anyway wrt. atomicity.
On Tue, 9 May 2023 at 16:34, Melissa Wen wrote:
>
> On 05/08, Harry Wentland wrote:
> >
> >
> > On 4/23/23 10:10, Melissa Wen wrote:
> > > From: Joshua Ashton
&g
n 4/23/23 10:10, Melissa Wen wrote:
> > > From: Joshua Ashton
> > >
> > > Multiplier to 'gain' the plane. When PQ is decoded using the fixed func
> > > transfer function to the internal FP16 fb, 1.0 -> 80 nits (on AMD at
> > > least) When sRGB is
AMD driver-private properties used on Steam Deck color mgmt
> > > pipeline.
> > >
> > > Co-developed-by: Joshua Ashton
> > > Signed-off-by: Joshua Ashton
> > > Signed-off-by: Melissa Wen
> > > ---
> > > drivers/gpu/drm/amd/display
On 5/5/23 15:16, Pekka Paalanen wrote:
On Fri, 5 May 2023 14:30:11 +0100
Joshua Ashton wrote:
Some corrections and replies inline.
On Fri, 5 May 2023 at 12:42, Pekka Paalanen wrote:
On Thu, 04 May 2023 15:22:59 +
Simon Ser wrote:
...
To wrap things up, let's take a real-world
Some corrections and replies inline.
On Fri, 5 May 2023 at 12:42, Pekka Paalanen wrote:
>
> On Thu, 04 May 2023 15:22:59 +
> Simon Ser wrote:
>
> > Hi all,
> >
> > The goal of this RFC is to expose a generic KMS uAPI to configure the color
> > pipeline before blending, ie. after a pixel is
On 4/3/23 20:54, Christian König wrote:
Am 03.04.23 um 21:40 schrieb Joshua Ashton:
Hello all!
I would like to propose a new API for allowing processes to control
the priority of GPU queues similar to RLIMIT_NICE/RLIMIT_RTPRIO.
The main reason for this is for compositors such as Gamescope
Add support for the new RLIMIT_GPUPRIO when doing the priority
checks creating an amdgpu_ctx.
Signed-off-by: Joshua Ashton
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
b
This allows it to be used by other parts of the codebase without fear
of a circular include dependency being introduced.
Signed-off-by: Joshua Ashton
---
include/drm/drm_sched_priority.h | 41
include/drm/gpu_scheduler.h | 15 +---
2 files changed
queue is still advantageous.
With adding RLIMIT_GPUPRIO, a process outside of a container or
eg. rtkit could call `prlimit` on the process inside to allow it to make
a realtime queue and solve these problems.
Signed-off-by: Joshua Ashton
---
fs/proc/base.c | 1 +
include/asm
This allows AMDGPU scheduler priority above normal to be expressed
using the DRM_SCHED_PRIORITY enum.
Signed-off-by: Joshua Ashton
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 2 +-
drivers/gpu/drm/msm/msm_gpu.h | 2 +-
include/drm/gpu_scheduler.h | 1 +
3 files changed
!
- Joshie
Joshua Ashton (4):
drm/scheduler: Add DRM_SCHED_PRIORITY_VERY_HIGH
drm/scheduler: Split out drm_sched_priority to own file
uapi: Add RLIMIT_GPUPRIO
drm/amd/amdgpu: Check RLIMIT_GPUPRIO in priority permissions
drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 13 ++--
drivers/gpu
On 3/17/23 13:35, Pekka Paalanen wrote:
On Fri, 17 Mar 2023 14:50:40 +0200
Ville Syrjälä wrote:
On Fri, Mar 17, 2023 at 10:53:35AM +0200, Pekka Paalanen wrote:
On Fri, 17 Mar 2023 01:01:38 +0200
Ville Syrjälä wrote:
On Thu, Mar 16, 2023 at 10:13:54PM +0100, Sebastian Wick wrote:
On
On 2/8/23 09:30, Pekka Paalanen wrote:
On Fri, 3 Feb 2023 02:07:44 +
Joshua Ashton wrote:
Userspace has no way of controlling or knowing the pixel encoding
currently, so there is no way for it to ever get the right values here.
When we do add pixel_encoding control from userspace,we
at 10:24:52AM -0500, Harry Wentland wrote:
On 2/3/23 10:19, Ville Syrjälä wrote:
On Fri, Feb 03, 2023 at 09:39:42AM -0500, Harry Wentland wrote:
On 2/3/23 07:59, Sebastian Wick wrote:
On Fri, Feb 3, 2023 at 11:40 AM Ville Syrjälä
wrote:
On Fri, Feb 03, 2023 at 02:07:44AM +, Joshua
.
Signed-off-by: Joshua Ashton
Cc: Pekka Paalanen
Cc: Sebastian Wick
Cc: vitaly.pros...@amd.com
Cc: Uma Shankar
Cc: Ville Syrjälä
Cc: Joshua Ashton
Cc: dri-devel@lists.freedesktop.org
Cc: amd-...@lists.freedesktop.org
---
drivers/gpu/drm/display/drm_hdmi_helper.c | 9 -
drivers/gpu
To match the other enums, and add more information about these values.
Signed-off-by: Joshua Ashton
Cc: Pekka Paalanen
Cc: Sebastian Wick
Cc: vitaly.pros...@amd.com
Cc: Uma Shankar
Cc: Ville Syrjälä
Cc: Joshua Ashton
Cc: dri-devel@lists.freedesktop.org
Cc: amd-...@lists.freedesktop.org
From: Harry Wentland
This allows us to use strongly typed arguments.
Signed-off-by: Harry Wentland
Reviewed-by: Simon Ser
Cc: Pekka Paalanen
Cc: Sebastian Wick
Cc: vitaly.pros...@amd.com
Cc: Uma Shankar
Cc: Ville Syrjälä
Cc: Joshua Ashton
Cc: dri-devel@lists.freedesktop.org
Cc: amd
for
anything more here.
- Joshie ✨
On Fri, Jan 13, 2023 at 5:26 PM Harry Wentland wrote:
From: Joshua Ashton
Userspace might not aware whether we're sending RGB or YCbCr
data to the display. If COLOR_SPACE_2020_RGB_FULLRANGE is
requested but the output encoding is YCbCr we should
send
On 6/27/22 13:18, Ville Syrjälä wrote:
On Sun, Jun 19, 2022 at 09:31:03PM -0100, Melissa Wen wrote:
Add 3D LUT for gammar correction using a 3D lookup table. The position
in the color correction pipeline where 3D LUT is applied depends on hw
design, being after CTM or gamma. If just after
random commit
comes from).
Once the documentation comment is fixed in "[PATCH 07/16] drm/connector:
Print connector colorspace in state debugfs" this series is Reviewed-By:
Joshua Ashton
- Joshie ✨
On 12/12/22 18:21, Harry Wentland wrote:
This patchset enables the DP and HDMI
32 matches
Mail list logo
