Re: [PATCH v2 12/22] wifi: ath11k: Use iommu_paging_domain_alloc()

2024-06-04 Thread Kalle Valo
Lu Baolu writes: > An iommu domain is allocated in ath11k_ahb_fw_resources_init() and is > attached to ab_ahb->fw.dev in the same function. > > Use iommu_paging_domain_alloc() to make it explicit. > > Signed-off-by: Lu Baolu > --- > drivers/net/wireless/ath/ath11k/ahb.c | 6 +++--- > 1 file

Re: [PATCH 17/22] wireless: mac80211_hwsim: drop owner assignment

2024-03-27 Thread Kalle Valo
Krzysztof Kozlowski writes: > virtio core already sets the .owner, so driver does not need to. > > Signed-off-by: Krzysztof Kozlowski We use "wifi:" in the title, not "wireless:". It would be nice if you can fix this during commit. -- https://patchwork.kernel.org/project/linux-wireless/list/

Re: Linux 6.3-rc3

2023-03-29 Thread Kalle Valo
Nathan Chancellor writes: >> >> And maybe request a similar llvm directory under pub/tools to make it >> >> more official? :) > > We now have https://kernel.org/pub/tools/llvm/, which is about as > official as we can get I suppose :) Nice, thanks. Bookmarked and I'll advertise this to wireless

Re: Linux 6.3-rc3

2023-03-27 Thread Kalle Valo
Jani Nikula writes: > On Sat, 25 Mar 2023, Masahiro Yamada wrote: > >> On Thu, Mar 23, 2023 at 1:56 AM Linus Torvalds >> wrote: >>> >>> On Wed, Mar 22, 2023 at 9:40 AM Sedat Dilek wrote: >>> > >>> > You have to pass `make LLVM=1` in any case... to `oldconfig` or when >>> > adding any

Re: Linux 6.3-rc3

2023-03-24 Thread Kalle Valo
Nathan Chancellor writes: >> This is nitpicking but it would be nice if the tarball contents wouldn't >> conflict with each other. Now both llvm-16.0.0-aarch64.tar.gz and >> llvm-16.0.0-x86_64.tar extract to the same directory llvm-16.0.0 with >> same binary names. It would be much better if

Re: Linux 6.3-rc3

2023-03-24 Thread Kalle Valo
Nathan Chancellor writes: > On Wed, Mar 22, 2023 at 02:44:47PM +0200, Kalle Valo wrote: >> Nathan Chancellor writes: >> >> > Perhaps these would make doing allmodconfig builds with clang more >> > frequently less painful for you? >> > >> >

Re: Linux 6.3-rc3

2023-03-22 Thread Kalle Valo
Nathan Chancellor writes: > On Mon, Mar 20, 2023 at 11:26:17AM -0700, Linus Torvalds wrote: >> On Mon, Mar 20, 2023 at 11:05 AM Nathan Chancellor wrote: >> > >> > On the clang front, I am still seeing the following warning turned error >> > for arm64 allmodconfig at least: >> > >> >

Re: [PATCH] treewide: Convert del_timer*() to timer_shutdown*()

2022-12-21 Thread Kalle Valo
.../broadcom/brcm80211/brcmfmac/btcoex.c | 2 +- > drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c | 2 +- > drivers/net/wireless/intel/iwlwifi/mvm/sta.c | 2 +- > drivers/net/wireless/intersil/hostap/hostap_ap.c | 2 +- > drivers/net/wireless/marvell/mwifiex/main.c | 2 +- > drivers/net/wireless/microchip/wilc1000/hif.c| 6 +++--- Acked-by: Kalle Valo -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [PATCH 10/12] iwlwifi: Track scan_cmd allocation size explicitly

2022-09-21 Thread Kalle Valo
out an overflow.) > > Cc: Gregory Greenman > Cc: Kalle Valo > Cc: Johannes Berg > Cc: linux-wirel...@vger.kernel.org > Cc: net...@vger.kernel.org > Signed-off-by: Kees Cook Via which tree is this iwlwifi patch going? Normally via wireless-next or something else? -- https://pat

Re: [PATCH 2/4] arm64: dts: qcom: add sdm845-google-blueline (Pixel 3)

2022-07-27 Thread Kalle Valo
ew minor items to improve. [...] >> + { >> +status = "okay"; >> + >> +vdd-0.8-cx-mx-supply = <_l5a_0p8>; >> +vdd-1.8-xo-supply = <_l7a_1p8>; >> +vdd-1.3-rfa-supply = <_l17a_1p3>; >> +vdd-3.3-ch0-supply

Re: [PATCH 0/1] add support for enum module parameters

2022-04-19 Thread Kalle Valo
+ linux-wireless, netdev Jani Nikula writes: > On Thu, 14 Apr 2022, Greg Kroah-Hartman wrote: >> On Thu, Apr 14, 2022 at 03:30:32PM +0300, Jani Nikula wrote: >>> Hey, I've sent this before, ages ago, but haven't really followed >>> through with it. I still think it would be useful for many

Re: Build regressions/improvements in v5.18-rc1

2022-04-05 Thread Kalle Valo
Geert Uytterhoeven writes: > On Mon, Apr 4, 2022 at 8:39 PM Kalle Valo wrote: >> Geert Uytterhoeven writes: >> >> /kisskb/src/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c: >> >> error: case label does not reduce to an integer constant: => 3798:2,

Re: Build regressions/improvements in v5.18-rc1

2022-04-04 Thread Kalle Valo
Geert Uytterhoeven writes: >> /kisskb/src/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c: >> error: case label does not reduce to an integer constant: => 3798:2, >> 3809:2 > > arm64-gcc5.4/arm64-allmodconfig > powerpc-gcc5/powerpc-allmodconfig > powerpc-gcc5/ppc64_book3e_allmodconfig

Re: [PATCH 04/11] ath11: Wstringop-overread warning

2021-09-28 Thread Kalle Valo
s should really get > fixed in gcc, but it's also easy to work around this instance > by changing the function prototype to no include the length of > the array. > > Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99673 > Signed-off-by: Arnd Bergmann > Signed-off-by: Kalle V

Re: [PATCH] [RFC] qcom_scm: hide Kconfig symbol

2021-09-28 Thread Kalle Valo
_SCM=m this can't be =y > + select QCOM_SCM > select QCOM_QMI_HELPERS > help > This module adds support for integrated WCN3990 chip connected I assume I can continue to build test ATH10K_SNOC with x86 as before? That's important for me. If yes, then: Acked-by: Kalle Valo -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [PATCH v2 45/63] ath11k: Use memset_startat() for clearing queue descriptors

2021-08-21 Thread Kalle Valo
Kees Cook writes: > On Thu, Aug 19, 2021 at 04:19:37PM +0300, Kalle Valo wrote: >> Kees Cook writes: >> >> > In preparation for FORTIFY_SOURCE performing compile-time and run-time >> > field bounds checking for memset(), avoid intentionally writing across >&

Re: [PATCH v2 45/63] ath11k: Use memset_startat() for clearing queue descriptors

2021-08-20 Thread Kalle Valo
destination member that is intended to be the starting point > of zeroing through the end of the struct. Additionally split up a later > field-spanning memset() so that memset() can reason about the size. > > Cc: Kalle Valo > Cc: "David S. Miller" > Cc: Jakub Kicinski >

Re: [PATCH net-next] ath11k: use GFP_ATOMIC under spin lock

2020-04-28 Thread Kalle Valo
Wei Yongjun writes: > A spin lock is taken here so we should use GFP_ATOMIC. > > Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices") > Signed-off-by: Wei Yongjun Do note that ath11k patches go to my ath.git tree, not net-next. But no need to resend because of this. --

Re: [PATCH net-next] ath11k: use GFP_ATOMIC under spin lock

2020-04-28 Thread Kalle Valo
Wei Yongjun wrote: > A spin lock is taken here so we should use GFP_ATOMIC. > > Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices") > Signed-off-by: Wei Yongjun > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks.

Re: [PATCH v2 2/9] net: wireless: rtl818x: Constify ioreadX() iomem argument (as in generic implementation)

2020-01-27 Thread Kalle Valo
Krzysztof Kozlowski wrote: > The ioreadX() helpers have inconsistent interface. On some architectures > void *__iomem address argument is a pointer to const, on some not. > > Implementations of ioreadX() do not modify the memory under the address > so they can be converted to a "const" version

Re: [PATCH v2 9/9] net: wireless: ath5k: Constify ioreadX() iomem argument (as in generic implementation)

2020-01-12 Thread Kalle Valo
"const" version for const-safety and > consistency among architectures. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/net/wireless/ath/ath5k/ahb.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) No need to have "net: wireless: "

Re: [PATCH v2 2/9] net: wireless: rtl818x: Constify ioreadX() iomem argument (as in generic implementation)

2020-01-12 Thread Kalle Valo
rtl8180.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) No need to have "net: wireless: " in the title, this is enough. rtl818x: Constify ioreadX() iomem argument (as in generic implementation) I assume someone else will take this so here's my ack: Acked-by: Kalle

Re: [PATCH 11/12] brcmfmac: Loading the correct firmware for brcm43456

2019-04-15 Thread Kalle Valo
meg...@megous.com wrote: > From: Ondrej Jirman > > SDIO based brcm43456 is currently misdetected as brcm43455 and the wrong > firmware name is used. Correct the detection and load the correct > firmware file. Chiprev for brcm43456 is "9". > > Signed-off-by: Ondrej Jirman Patch applied to

Re: [PATCH 11/16] treewide: simplify Kconfig dependencies for removed archs

2018-03-15 Thread Kalle Valo
ers/net/wireless/cisco/Kconfig | 2 +- Acked-by: Kalle Valo <kv...@codeaurora.org> -- Kalle Valo ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v2 05/11] Kbuild: don't add obj tree in additional includes

2016-07-19 Thread Kalle Valo
atch along with a third one that > turned out to be unnecessary. Greg applies drivers/staging patches to his staging tree, but I'll take the rtlwifi patch. -- Kalle Valo

[PATCH v2 05/11] Kbuild: don't add obj tree in additional includes

2016-07-19 Thread Kalle Valo
t now is > > a281bfa5713a [SUBMITTED 20160615] [EXPERIMENTAL] Kbuild: enable > -Wmissing-include-dirs by default > 83934921e68e [SUBMITTED 20160615] rtlwifi: don't add include path for > rtl8188ee Apparently[1] you didn't CC linux-wireless and that's why I didn't see the rtlwifi patch in wireless patchwork. Care to resend? [1] https://patchwork.kernel.org/patch/9178861/ -- Kalle Valo