[PATCH v2 3/3] drm/sprd: check the platform_get_resource() return value

2022-01-17 Thread Kevin Tang
platform_get_resource() may fail and return NULL, so check it's value before using it. Reported-by: Zou Wei Signed-off-by: Kevin Tang Reviewed-by: Javier Martinez Canillas Acked-by: Thomas Zimmermann v1 -> v2: - new patch --- drivers/gpu/drm/sprd/sprd_dpu.c | 5 + drivers/gpu/drm/s

[PATCH v2 2/3] drm/sprd: fix potential NULL dereference

2022-01-17 Thread Kevin Tang
'drm' could be null in sprd_drm_shutdown, and drm_warn maybe dereference it, remove this warning log. Reported-by: Dan Carpenter Signed-off-by: Kevin Tang Reviewed-by: Javier Martinez Canillas Acked-by: Thomas Zimmermann v1 -> v2: - Split checking platform_get_resource() return va

[PATCH v2 1/3] drm/sprd: remove the selected DRM_KMS_CMA_HELPER in kconfig

2022-01-17 Thread Kevin Tang
LPER refers to a non-existing kconfig symbol. Reported-by: Lukas Bulwahn Signed-off-by: Kevin Tang Reviewed-by: Javier Martinez Canillas Acked-by: Thomas Zimmermann Reviewed-by: Lukas Bulwahn v1 -> v2: - fix commit comments long lines issue and drop "On linux-next" comments --- driv

[PATCH v2 0/3] sprd drm cover letter

2022-01-17 Thread Kevin Tang
he warning log Kevin Tang (3): drm/sprd: remove the selected DRM_KMS_CMA_HELPER in kconfig drm/sprd: fix potential NULL dereference drm/sprd: check the platform_get_resource() return value drivers/gpu/drm/sprd/Kconfig| 1 - drivers/gpu/drm/sprd/sprd_dpu.c | 5 + drivers/gp

[PATCH v1 2/2] drm/sprd: fix potential NULL dereference

2021-12-24 Thread Kevin Tang
platform_get_resource() may fail and return NULL, so check it's value before using it. 'drm' could be null in sprd_drm_shutdown, and drm_warn maybe dereference it, remove this warning log. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang --- drivers/gpu/drm/sprd/sprd_dpu.c | 3

[PATCH v1 1/2] drm/sprd: remove the selected DRM_KMS_CMA_HELPER in kconfig

2021-12-24 Thread Kevin Tang
MS_CMA_HELPER refers to a non-existing kconfig symbol. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang --- drivers/gpu/drm/sprd/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/sprd/Kconfig b/drivers/gpu/drm/sprd/Kconfig index 3edeaeca0..9a9c7ebfc 100644 -

[PATCH v1 0/2] sprd drm cover letter

2021-12-24 Thread Kevin Tang
v1: remove the selected DRM_KMS_CMA_HELPER in kconfig drm-sprd-fix-potential-NULL-dereference Kevin Tang (2): drm/sprd: remove the selected DRM_KMS_CMA_HELPER in kconfig drm/sprd: fix potential NULL dereference drivers/gpu/drm/sprd/Kconfig| 1 - drivers/gpu/drm/sprd/sprd_dpu.c | 3

Re: [PATCH v8 0/6] Add Unisoc's drm kms module

2021-12-20 Thread Kevin Tang
Dear Maarten, I see it from the cgit.freedesktop.org, our sprd drivers seems has been merged into drm-misc. Now, what shall we do next? BR, Best wishes Kevin Tang 于2021年12月7日周二 22:27写道: > > ChangeList: > RFC v1: > 1. only upstream modeset and atomic at first commit. > 2. rem

Re: [PATCH -next] drm/sprd: fix potential NULL dereference

2021-12-18 Thread Kevin Tang
Dear Wei, Thank you for your notice. I have received it. I will be fix it later. Best wishes Zou Wei 于2021年12月14日周二 17:11写道: > > platform_get_resource() may fail and return NULL, so we should > better check it's return value to avoid a NULL pointer dereference > a bit later in the code. > >

Re: [bug report] drm/sprd: add Unisoc's drm kms master

2021-12-18 Thread Kevin Tang
Dear Dan, Thank you for your notice. I have received it. I will be fix it later. Best wishes Dan Carpenter 于2021年12月15日周三 19:32写道: > > Hello Kevin Tang, > > This is a semi-automatic email about new static checker warnings. > > The patch 43531edd53f0: "drm/sprd: add Unisoc

[PATCH v8 6/6] drm/sprd: add Unisoc's drm mipi dsi driver

2021-12-07 Thread Kevin Tang
instead of drm panel API. - Register mipi_dsi_host on probe phase; - Remove some unused function. v8: - Fix missing signed-off-by. - Move component_add to dsi_host.attach callback. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang --- drivers/gpu/drm/sprd/Kconfig |1

[PATCH v8 5/6] dt-bindings: display: add Unisoc's mipi dsi controller bindings

2021-12-07 Thread Kevin Tang
From: Kevin Tang Adds MIPI DSI Controller support for Unisoc's display subsystem. v5: - Remove panel_in port for dsi node. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang Reviewed-by: Rob Herring --- .../display/sprd/sprd,sharkl3-dsi-host.yaml | 88 +++ 1

[PATCH v8 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-12-07 Thread Kevin Tang
ode on mode_set_nofb - Remove enable_irq and disable_irq function call. - Remove drm_format_info function call. v7: - Remove iommu error interrupt handling function. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang Reviewed-by: Maxime Ripard --- drivers/gpu/drm/sprd/Kconfig|

[PATCH v8 3/6] dt-bindings: display: add Unisoc's dpu bindings

2021-12-07 Thread Kevin Tang
From: Kevin Tang DPU (Display Processor Unit) is the Display Controller for the Unisoc SoCs which transfers the image data from a video memory buffer to an internal LCD interface. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang Reviewed-by: Rob Herring --- .../display/sprd/sprd

[PATCH v8 2/6] drm/sprd: add Unisoc's drm kms master

2021-12-07 Thread Kevin Tang
eep the selects sorted by alphabet for Kconfig. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang --- drivers/gpu/drm/Kconfig | 2 + drivers/gpu/drm/Makefile| 1 + drivers/gpu/drm/sprd/Kconfig| 11 ++ drivers/gpu/drm/sprd/Makefile | 3 + drivers/gpu/drm/s

[PATCH v8 1/6] dt-bindings: display: add Unisoc's drm master bindings

2021-12-07 Thread Kevin Tang
From: Kevin Tang The Unisoc DRM master device is a virtual device needed to list all DPU devices or other display interface nodes that comprise the graphics subsystem Unisoc's display pipeline have several components as below description, multi display controllers and corresponding physical

[PATCH v8 0/6] Add Unisoc's drm kms module

2021-12-07 Thread Kevin Tang
iables. v7: 1. Fix codeing style issue by checkpatch. 2. Drop the pll registers structure define. 3. Use bridge API instead of drm panel API. 4. Register mipi_dsi_host on probe phase; 5. Remove iommu error interrupt handling function. 6. Remove some unused function. v8: 1. Fix missing signed-off-by.

Re: [PATCH v7 6/6] drm/sprd: add Unisoc's drm mipi dsi driver

2021-12-03 Thread Kevin Tang
Maxime Ripard 于2021年12月3日周五 18:38写道: > > On Mon, Oct 25, 2021 at 05:34:18PM +0800, Kevin Tang wrote: > > @@ -618,9 +619,25 @@ static void sprd_crtc_mode_set_nofb(struct drm_crtc > > *crtc) > > { > > struct sprd_dpu *dpu = to_sprd_crtc(crtc); > >

Re: [RESEND PATCH v7 6/6] drm/sprd: add Unisoc's drm mipi dsi driver

2021-12-03 Thread Kevin Tang
Maarten Lankhorst 于2021年11月30日周二 21:20写道: > > On 22-11-2021 10:34, Kevin Tang wrote: > > Adds dsi host controller support for the Unisoc's display subsystem. > > Adds dsi phy support for the Unisoc's display subsystem. > > Only MIPI DSI Displays supported, DP

Re: [PATCH v7 2/6] drm/sprd: add Unisoc's drm kms master

2021-12-03 Thread Kevin Tang
Maarten Lankhorst 于2021年11月26日周五 22:03写道: > > On 25-10-2021 11:34, Kevin Tang wrote: > > Adds drm support for the Unisoc's display subsystem. > > > > This is drm kms driver, this driver provides support for the > > application framework in Android, Yocto and more.

[RESEND PATCH v7 6/6] drm/sprd: add Unisoc's drm mipi dsi driver

2021-11-22 Thread Kevin Tang
return ret; + + return 0; +} + +static void sprd_dsi_unbind(struct device *dev, + struct device *master, void *data) +{ + struct sprd_dsi *dsi = dev_get_drvdata(dev); + + drm_of_panel_bridge_remove(dev->of_node, 1, 0); + + drm_encoder_cleanup(>

[PATCH v7 6/6] drm/sprd: add Unisoc's drm mipi dsi driver

2021-10-25 Thread Kevin Tang
ret = sprd_dsi_bridge_init(dsi, dev); + if (ret) + return ret; + + ret = sprd_dsi_context_init(dsi, dev); + if (ret) + return ret; + + return 0; +} + +static void sprd_dsi_unbind(struct device *dev, + struct device *maste

[PATCH v7 5/6] dt-bindings: display: add Unisoc's mipi dsi controller bindings

2021-10-25 Thread Kevin Tang
From: Kevin Tang Adds MIPI DSI Controller support for Unisoc's display subsystem. v5: - Remove panel_in port for dsi node. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang Reviewed-by: Rob Herring --- .../display/sprd/sprd,sharkl3-dsi-host.yaml | 88 +++ 1

[PATCH v7 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-10-25 Thread Kevin Tang
ode on mode_set_nofb - Remove enable_irq and disable_irq function call. - Remove drm_format_info function call. v7: - Remove iommu error interrupt handling function. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang --- drivers/gpu/drm/sprd/Kconfig| 1 + drivers/gpu/drm/s

[PATCH v7 3/6] dt-bindings: display: add Unisoc's dpu bindings

2021-10-25 Thread Kevin Tang
From: Kevin Tang DPU (Display Processor Unit) is the Display Controller for the Unisoc SoCs which transfers the image data from a video memory buffer to an internal LCD interface. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang Reviewed-by: Rob Herring --- .../display/sprd/sprd

[PATCH v7 2/6] drm/sprd: add Unisoc's drm kms master

2021-10-25 Thread Kevin Tang
test tool) and Android HWComposer. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang v4: - Move the devm_drm_dev_alloc to master_ops->bind function. - The managed drmm_mode_config_init() it is no longer necessary for drivers to explicitly call drm_mode_config_cleanup, so del

[PATCH v7 1/6] dt-bindings: display: add Unisoc's drm master bindings

2021-10-25 Thread Kevin Tang
From: Kevin Tang The Unisoc DRM master device is a virtual device needed to list all DPU devices or other display interface nodes that comprise the graphics subsystem Unisoc's display pipeline have several components as below description, multi display controllers and corresponding physical

[PATCH v7 0/6] Add Unisoc's drm kms module

2021-10-25 Thread Kevin Tang
iables. v7: 1. Fix codeing style issue by checkpatch. 2. Drop the pll registers structure define. 3. Use bridge API instead of drm panel API. 4. Register mipi_dsi_host on probe phase; 5. Remove iommu error interrupt handling function. 6. Remove some unused function. Kevin Tang (6): dt-bindi

Re: [PATCH v6 6/6] drm/sprd: add Unisoc's drm mipi dsi driver

2021-10-20 Thread Kevin Tang
Maxime Ripard 于2021年9月28日周二 下午5:28写道: > > On Sun, Sep 26, 2021 at 10:31:53PM +0800, Kevin Tang wrote: > > Maxime Ripard 于2021年9月17日周五 下午11:40写道: > > > > +static void sprd_dsi_encoder_mode_set(struct drm_encoder *encoder, > > > > +

Re: [PATCH v6 6/6] drm/sprd: add Unisoc's drm mipi dsi driver

2021-10-06 Thread Kevin Tang
Sam, Thanks for your response. Sam Ravnborg 于2021年9月27日周一 上午12:33写道: > > Hi Kevin, > > > > > + reg->_0b.bits.out_sel = pll->out_sel; > > > > + reg->_0b.bits.kint_l = pll->kint & 0xf; > > > > + reg->_0e.bits.pll_pu_byp = 0; > > > > + reg->_0e.bits.pll_pu = 0; > > > > +

Re: [PATCH v6 6/6] drm/sprd: add Unisoc's drm mipi dsi driver

2021-10-06 Thread Kevin Tang
Maxime Ripard 于2021年9月28日周二 下午5:28写道: > > On Sun, Sep 26, 2021 at 10:31:53PM +0800, Kevin Tang wrote: > > Maxime Ripard 于2021年9月17日周五 下午11:40写道: > > > > +static void sprd_dsi_encoder_mode_set(struct drm_encoder *encoder, > > > > +

Re: [PATCH v6 6/6] drm/sprd: add Unisoc's drm mipi dsi driver

2021-09-26 Thread Kevin Tang
Maxime Ripard 于2021年9月17日周五 下午11:40写道: > > On Fri, Aug 13, 2021 at 10:53:02PM +0800, Kevin Tang wrote: > > Adds dsi host controller support for the Unisoc's display subsystem. > > Adds dsi phy support for the Unisoc's display subsystem. > > Only MIPI DSI Displa

Re: [PATCH v6 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-09-26 Thread Kevin Tang
Maxime Ripard 于2021年9月17日周五 下午10:58写道: > > Hi, > > On Fri, Aug 13, 2021 at 10:53:00PM +0800, Kevin Tang wrote: > > Adds DPU(Display Processor Unit) support for the Unisoc's display > > subsystem. > > It's support multi planes, scaler, rotation, PQ(Picture

[PATCH v6 6/6] drm/sprd: add Unisoc's drm mipi dsi driver

2021-08-13 Thread Kevin Tang
Adds dsi host controller support for the Unisoc's display subsystem. Adds dsi phy support for the Unisoc's display subsystem. Only MIPI DSI Displays supported, DP/TV/HMDI will be support in the feature. v1: - Remove dphy and dsi graph binding, merge the dphy driver into the dsi. v2: - Use

[PATCH v6 5/6] dt-bindings: display: add Unisoc's mipi dsi controller bindings

2021-08-13 Thread Kevin Tang
From: Kevin Tang Adds MIPI DSI Controller support for Unisoc's display subsystem. v5: - Remove panel_in port for dsi node. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang Reviewed-by: Rob Herring --- .../display/sprd/sprd,sharkl3-dsi-host.yaml | 88 +++ 1

[PATCH v6 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-08-13 Thread Kevin Tang
ode on mode_set_nofb - Remove enable_irq and disable_irq function call. - Remove drm_format_info function call. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang --- drivers/gpu/drm/sprd/Kconfig| 1 + drivers/gpu/drm/sprd/Makefile | 3 +- drivers/gpu/drm/sprd/sprd_dpu.c |

[PATCH v6 3/6] dt-bindings: display: add Unisoc's dpu bindings

2021-08-13 Thread Kevin Tang
From: Kevin Tang DPU (Display Processor Unit) is the Display Controller for the Unisoc SoCs which transfers the image data from a video memory buffer to an internal LCD interface. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang Reviewed-by: Rob Herring --- .../display/sprd/sprd

[PATCH v6 2/6] drm/sprd: add Unisoc's drm kms master

2021-08-13 Thread Kevin Tang
test tool) and Android HWComposer. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang v4: - Move the devm_drm_dev_alloc to master_ops->bind function. - The managed drmm_mode_config_init() it is no longer necessary for drivers to explicitly call drm_mode_config_cleanup, so del

[PATCH v6 1/6] dt-bindings: display: add Unisoc's drm master bindings

2021-08-13 Thread Kevin Tang
From: Kevin Tang The Unisoc DRM master device is a virtual device needed to list all DPU devices or other display interface nodes that comprise the graphics subsystem Unisoc's display pipeline have several components as below description, multi display controllers and corresponding physical

[PATCH v6 0/6] Add Unisoc's drm kms module

2021-08-13 Thread Kevin Tang
le and clear interrupts before register dpu IRQ 2. Init dpi config used by crtc_state->adjusted_mode on mode_set_nofb 3. Remove enable_irq and disable_irq function call. 4. Remove drm_format_info function call. 5. Redesign the way to access the dsi register. 6. Reduce the dsi_context member variab

Re: [PATCH v5 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-05-14 Thread Kevin Tang
Maxime Ripard 于2021年4月30日周五 下午5:22写道: > > On Sun, Apr 25, 2021 at 08:36:05PM +0800, Kevin Tang wrote: > > Adds DPU(Display Processor Unit) support for the Unisoc's display > > subsystem. > > It's support multi planes, scaler, rotation, PQ(Picture Quality) and more. > &g

Re: [PATCH v5 6/6] drm/sprd: add Unisoc's drm mipi dsi driver

2021-05-12 Thread Kevin Tang
Maxime Ripard 于2021年4月30日周五 下午5:35写道: > > Hi, > > On Sun, Apr 25, 2021 at 08:36:07PM +0800, Kevin Tang wrote: > > Adds dsi host controller support for the Unisoc's display subsystem. > > Adds dsi phy support for the Unisoc's display subsystem. > > Only MIPI DSI

Re: [PATCH v5 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-04-30 Thread Kevin Tang
Cc Robin & Joerg Maxime Ripard 于2021年4月30日周五 下午5:22写道: > > On Sun, Apr 25, 2021 at 08:36:05PM +0800, Kevin Tang wrote: > > Adds DPU(Display Processor Unit) support for the Unisoc's display > > subsystem. > > It's support multi planes, scaler, rotation, PQ(Picture Q

[PATCH v5 6/6] drm/sprd: add Unisoc's drm mipi dsi driver

2021-04-25 Thread Kevin Tang
-by for dsi patch. - Use the mode_flags of mipi_dsi_device to setup crtc DPI and EDPI mode. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang --- drivers/gpu/drm/sprd/Kconfig |1 + drivers/gpu/drm/sprd/Makefile|6 +- drivers/gpu/drm/sprd/dsi_ctrl.c | 794

[PATCH v5 5/6] dt-bindings: display: add Unisoc's mipi dsi controller bindings

2021-04-25 Thread Kevin Tang
From: Kevin Tang Adds MIPI DSI Controller support for Unisoc's display subsystem. v5: - Remove panel_in port for dsi node. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang Reviewed-by: Rob Herring --- .../display/sprd/sprd,sharkl3-dsi-host.yaml | 88 +++ 1

[PATCH v5 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-04-25 Thread Kevin Tang
callback. - Follow the OF-Graph bindings, use of_graph_get_port_by_id instead of of_parse_phandle. - Use zpos to represent the layer position. - Rebase to last drm misc branch. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang --- drivers/gpu/drm/sprd/Kconfig| 1 + drivers

[PATCH v5 3/6] dt-bindings: display: add Unisoc's dpu bindings

2021-04-25 Thread Kevin Tang
From: Kevin Tang DPU (Display Processor Unit) is the Display Controller for the Unisoc SoCs which transfers the image data from a video memory buffer to an internal LCD interface. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang Reviewed-by: Rob Herring --- .../display/sprd/sprd

[PATCH v5 2/6] drm/sprd: add Unisoc's drm kms master

2021-04-25 Thread Kevin Tang
eep the selects sorted by alphabet for Kconfig. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang Reviewed-by: Rob Herring --- drivers/gpu/drm/Kconfig | 2 + drivers/gpu/drm/Makefile| 1 + drivers/gpu/drm/sprd/Kconfig| 11 ++ drivers/gpu/drm/sprd/Makefile |

[PATCH v5 1/6] dt-bindings: display: add Unisoc's drm master bindings

2021-04-25 Thread Kevin Tang
From: Kevin Tang The Unisoc DRM master device is a virtual device needed to list all DPU devices or other display interface nodes that comprise the graphics subsystem Unisoc's display pipeline have several components as below description, multi display controllers and corresponding physical

[PATCH v5 0/6] Add Unisoc's drm kms module

2021-04-25 Thread Kevin Tang
ad of of_parse_phandle. 6. Use zpos to represent the layer position. 7. Rebase to last drm misc branch. 8. Remove panel_in port for dsi node. 9. Drop the dsi ip file prefix. 10. Add Signed-off-by for dsi patch. 11. Use the mode_flags of mipi_dsi_device to setup crtc DPI and EDPI mode. Kevin Tang (6

Re: [PATCH v4 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-04-19 Thread Kevin Tang
Hi, Maxime Ripard 于2021年4月15日周四 下午5:03写道: > > Hi, > > On Thu, Apr 15, 2021 at 08:18:52AM +0800, Kevin Tang wrote: > > Maxime Ripard 于2021年3月24日周三 下午7:10写道: > > > > +static struct sprd_dpu *sprd_crtc_init(struct drm_device *drm, > > > > +

Re: [PATCH v4 5/6] dt-bindings: display: add Unisoc's mipi dsi controller bindings

2021-04-18 Thread Kevin Tang
Maxime Ripard 于2021年4月15日周四 下午4:42写道: > > On Fri, Apr 09, 2021 at 08:23:19AM +0800, Kevin Tang wrote: > > Maxime Ripard 于2021年4月7日周三 下午6:46写道: > > > > > On Wed, Mar 31, 2021 at 09:49:14AM +0800, Kevin Tang wrote: > > > > Hi Maxime, > > >

Re: [PATCH v4 6/6] drm/sprd: add Unisoc's drm mipi dsi driver

2021-04-15 Thread Kevin Tang
Maxime Ripard 于2021年4月7日周三 下午6:48写道: > > On Wed, Mar 31, 2021 at 09:47:12AM +0800, Kevin Tang wrote: > > > > diff --git a/drivers/gpu/drm/sprd/Makefile > > > b/drivers/gpu/drm/sprd/Makefile > > > > index 6c25bfa99..d49f4977b 100644 > > > > --- a/

Re: [PATCH v4 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-04-15 Thread Kevin Tang
Maxime Ripard 于2021年3月24日周三 下午7:10写道: > > Hi, > > On Mon, Feb 22, 2021 at 09:28:20PM +0800, Kevin Tang wrote: > > Adds DPU(Display Processor Unit) support for the Unisoc's display subsystem. > > It's support multi planes, scaler, rotation, PQ(Picture Quality) and more

Re: [PATCH v4 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-04-12 Thread Kevin Tang
Hi Thomas, Thomas Zimmermann 于2021年4月8日周四 下午6:53写道: > Hi, > > please see my comments below. > > Best regards > Thomas > > Am 22.02.21 um 14:28 schrieb Kevin Tang: > > Adds DPU(Display Processor Unit) support for the Unisoc's display > subsystem. > > It's

Re: [PATCH v4 2/6] drm/sprd: add Unisoc's drm kms master

2021-04-09 Thread Kevin Tang
Hi Thomas, First of all, thanks for comments. Thomas Zimmermann 于2021年4月8日周四 下午6:21写道: > Hi, > > I have just a few nits below plus the points that others made. > > Am 22.02.21 um 14:28 schrieb Kevin Tang: > > Adds drm support for the Unisoc's display subsystem. > >

Re: [PATCH v4 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-04-09 Thread Kevin Tang
Maxime Ripard 于2021年4月7日周三 下午6:45写道: > Hi, > > Adding Jörg, Will and Robin, > > On Wed, Mar 31, 2021 at 09:21:19AM +0800, Kevin Tang wrote: > > > > +static u32 check_mmu_isr(struct sprd_dpu *dpu, u32 reg_val) > > > > +{ > > > > + struct

Re: [PATCH v4 5/6] dt-bindings: display: add Unisoc's mipi dsi controller bindings

2021-04-09 Thread Kevin Tang
Maxime Ripard 于2021年4月7日周三 下午6:46写道: > On Wed, Mar 31, 2021 at 09:49:14AM +0800, Kevin Tang wrote: > > Hi Maxime, > > > > Maxime Ripard 于2021年3月24日周三 下午7:13写道: > > > > > On Mon, Feb 22, 2021 at 09:28:21PM +0800, Kevin Tang wrote: > > > >

Re: [PATCH v4 5/6] dt-bindings: display: add Unisoc's mipi dsi controller bindings

2021-03-31 Thread Kevin Tang
Hi Maxime, Maxime Ripard 于2021年3月24日周三 下午7:13写道: > On Mon, Feb 22, 2021 at 09:28:21PM +0800, Kevin Tang wrote: > > From: Kevin Tang > > > > Adds MIPI DSI Controller > > support for Unisoc's display subsystem. > > > > Cc: Orson Zhai > > Cc:

Re: [PATCH v4 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-03-31 Thread Kevin Tang
Hi Maxime, Maxime Ripard 于2021年3月24日周三 下午7:10写道: > Hi, > > On Mon, Feb 22, 2021 at 09:28:20PM +0800, Kevin Tang wrote: > > Adds DPU(Display Processor Unit) support for the Unisoc's display > subsystem. > > It's support multi planes, scaler, rotation, PQ(Picture Quality

Re: [PATCH v4 2/6] drm/sprd: add Unisoc's drm kms master

2021-03-31 Thread Kevin Tang
Maxime Ripard 于2021年3月24日周三 下午6:53写道: > Hi > > On Mon, Feb 22, 2021 at 09:28:18PM +0800, Kevin Tang wrote: > > Adds drm support for the Unisoc's display subsystem. > > > > This is drm kms driver, this driver provides support for the > > application fra

Re: [PATCH v4 2/6] drm/sprd: add Unisoc's drm kms master

2021-03-21 Thread Kevin Tang
Hi Sam Ravnborg, Do you have more comments about my patch? Looking forward to your reply, thank you. Kevin Tang 于2021年2月22日周一 下午9:28写道: > Adds drm support for the Unisoc's display subsystem. > > This is drm kms driver, this driver provides support for the > application framewor

[PATCH v4 6/6] drm/sprd: add Unisoc's drm mipi dsi driver

2021-02-22 Thread Kevin Tang
Adds dsi host controller support for the Unisoc's display subsystem. Adds dsi phy support for the Unisoc's display subsystem. Only MIPI DSI Displays supported, DP/TV/HMDI will be support in the feature. v1: - Remove dphy and dsi graph binding, merge the dphy driver into the dsi. v2: - Use

[PATCH v4 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-02-22 Thread Kevin Tang
Adds DPU(Display Processor Unit) support for the Unisoc's display subsystem. It's support multi planes, scaler, rotation, PQ(Picture Quality) and more. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang v2: - Use drm_xxx to replace all DRM_XXX. - Use kzalloc to replace

[PATCH v4 5/6] dt-bindings: display: add Unisoc's mipi dsi controller bindings

2021-02-22 Thread Kevin Tang
From: Kevin Tang Adds MIPI DSI Controller support for Unisoc's display subsystem. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang Reviewed-by: Rob Herring --- .../display/sprd/sprd,sharkl3-dsi-host.yaml | 102 ++ 1 file changed, 102 insertions(+) create mode

[PATCH v4 3/6] dt-bindings: display: add Unisoc's dpu bindings

2021-02-22 Thread Kevin Tang
From: Kevin Tang DPU (Display Processor Unit) is the Display Controller for the Unisoc SoCs which transfers the image data from a video memory buffer to an internal LCD interface. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang Reviewed-by: Rob Herring --- .../display/sprd/sprd

[PATCH v4 1/6] dt-bindings: display: add Unisoc's drm master bindings

2021-02-22 Thread Kevin Tang
From: Kevin Tang The Unisoc DRM master device is a virtual device needed to list all DPU devices or other display interface nodes that comprise the graphics subsystem Unisoc's display pipeline have several components as below description, multi display controllers and corresponding physical

[PATCH v4 2/6] drm/sprd: add Unisoc's drm kms master

2021-02-22 Thread Kevin Tang
test tool) and Android HWComposer. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang v4: - Move the devm_drm_dev_alloc to master_ops->bind function. - The managed drmm_mode_config_init() it is no longer necessary for drivers to explicitly call drm_mode_config_cleanup, so del

[PATCH v4 0/6] Add Unisoc's drm kms module

2021-02-22 Thread Kevin Tang
m_dev_alloc to master_ops->bind function. 2. The managed drmm_mode_config_init() it is no longer necessary for drivers to explicitly call drm_mode_config_cleanup, so delete it. 3. Use drmm_helpers to allocate crtc ,planes and encoder. 4. Move allocate crtc ,planes, encoder to bind funtion. 5. Move ro

Re: [PATCH v3 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-02-17 Thread Kevin Tang
Robin Murphy 于2021年2月16日周二 下午10:22写道: > On 2021-01-05 13:46, Kevin Tang wrote: > > Adds DPU(Display Processor Unit) support for the Unisoc's display > subsystem. > > It's support multi planes, scaler, rotation, PQ(Picture Quality) and > more. > > > > Cc:

Re: [PATCH v3 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-02-13 Thread Kevin Tang
Daniel Vetter 于2021年2月3日周三 下午10:23写道: > On Tue, Jan 05, 2021 at 09:46:05PM +0800, Kevin Tang wrote: > > Adds DPU(Display Processor Unit) support for the Unisoc's display > subsystem. > > It's support multi planes, scaler, rotation, PQ(Picture Quality) and > more. > >

Re: [PATCH v3 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-02-13 Thread Kevin Tang
Daniel Vetter 于2021年2月3日周三 下午10:15写道: > On Tue, Jan 05, 2021 at 09:46:05PM +0800, Kevin Tang wrote: > > Adds DPU(Display Processor Unit) support for the Unisoc's display > subsystem. > > It's support multi planes, scaler, rotation, PQ(Picture Quality) and > more. > >

Re: [PATCH v3 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-02-11 Thread Kevin Tang
Daniel Vetter 于2021年2月3日周三 下午10:15写道: > On Tue, Jan 05, 2021 at 09:46:05PM +0800, Kevin Tang wrote: > > Adds DPU(Display Processor Unit) support for the Unisoc's display > subsystem. > > It's support multi planes, scaler, rotation, PQ(Picture Quality) and > more. > >

Re: [PATCH v3 0/6] Add Unisoc's drm kms module

2021-01-23 Thread Kevin Tang
Hi Daniel, Do you have some more comments for our patch? Kevin Tang 于2021年1月5日周二 下午9:46写道: > ChangeList: > RFC v1: > 1. only upstream modeset and atomic at first commit. > 2. remove some unused code; > 3. use alpha and blend_mode properties; > 3. add yaml support; > 4.

[PATCH v3 6/6] drm/sprd: add Unisoc's drm mipi dsi driver

2021-01-06 Thread Kevin Tang
Adds dsi host controller support for the Unisoc's display subsystem. Adds dsi phy support for the Unisoc's display subsystem. Only MIPI DSI Displays supported, DP/TV/HMDI will be support in the feature. v1: - Remove dphy and dsi graph binding, merge the dphy driver into the dsi. v2: - Use

[PATCH v3 0/6] Add Unisoc's drm kms module

2021-01-06 Thread Kevin Tang
. Add commit messages for Unisoc's virtual nodes. v2: 1. Use drm_xxx to replace all DRM_XXX. 2. Use kzalloc to replace devm_kzalloc for sprd_dsi/sprd_dpu structure init. 3. Remove dpu_core_ops midlayer. v3: 1. Remove dpu_layer midlayer and commit layers by aotmic_update Kevin Tang (6): dt-bindin

[PATCH v3 2/6] drm/sprd: add Unisoc's drm kms master

2021-01-06 Thread Kevin Tang
test tool) and Android HWComposer. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang --- drivers/gpu/drm/Kconfig | 2 + drivers/gpu/drm/Makefile| 1 + drivers/gpu/drm/sprd/Kconfig| 12 +++ drivers/gpu/drm/sprd/Makefile | 5 + drivers/gpu/drm/sprd/sprd_drm.c

[PATCH v3 5/6] dt-bindings: display: add Unisoc's mipi dsi controller bindings

2021-01-06 Thread Kevin Tang
From: Kevin Tang Adds MIPI DSI Controller support for Unisoc's display subsystem. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang Reviewed-by: Rob Herring --- .../display/sprd/sprd,sharkl3-dsi-host.yaml| 102 + 1 file changed, 102 insertions

[PATCH v3 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-01-06 Thread Kevin Tang
Adds DPU(Display Processor Unit) support for the Unisoc's display subsystem. It's support multi planes, scaler, rotation, PQ(Picture Quality) and more. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang v2: - Use drm_xxx to replace all DRM_XXX. - Use kzalloc to replace

[PATCH v3 1/6] dt-bindings: display: add Unisoc's drm master bindings

2021-01-06 Thread Kevin Tang
From: Kevin Tang The Unisoc DRM master device is a virtual device needed to list all DPU devices or other display interface nodes that comprise the graphics subsystem Unisoc's display pipeline have several components as below description, multi display controllers and corresponding physical

[PATCH v3 3/6] dt-bindings: display: add Unisoc's dpu bindings

2021-01-06 Thread Kevin Tang
From: Kevin Tang DPU (Display Processor Unit) is the Display Controller for the Unisoc SoCs which transfers the image data from a video memory buffer to an internal LCD interface. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang Reviewed-by: Rob Herring --- .../bindings/display

[PATCH v2 2/6] drm/sprd: add Unisoc's drm kms master

2020-12-28 Thread Kevin Tang
test tool) and Android HWComposer. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang --- drivers/gpu/drm/Kconfig | 2 + drivers/gpu/drm/Makefile| 1 + drivers/gpu/drm/sprd/Kconfig| 12 +++ drivers/gpu/drm/sprd/Makefile | 5 + drivers/gpu/drm/sprd/sprd_drm.c

[PATCH v2 3/6] dt-bindings: display: add Unisoc's dpu bindings

2020-12-28 Thread Kevin Tang
From: Kevin Tang DPU (Display Processor Unit) is the Display Controller for the Unisoc SoCs which transfers the image data from a video memory buffer to an internal LCD interface. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang Reviewed-by: Rob Herring --- .../bindings/display

[PATCH v2 1/6] dt-bindings: display: add Unisoc's drm master bindings

2020-12-28 Thread Kevin Tang
From: Kevin Tang The Unisoc DRM master device is a virtual device needed to list all DPU devices or other display interface nodes that comprise the graphics subsystem Unisoc's display pipeline have several components as below description, multi display controllers and corresponding physical

[PATCH v2 6/6] drm/sprd: add Unisoc's drm mipi dsi driver

2020-12-28 Thread Kevin Tang
drm_xxx to replace all DRM_XXX. - Use kzalloc to replace devm_kzalloc for sprd_dsi structure init. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang --- drivers/gpu/drm/sprd/Makefile |8 +- drivers/gpu/drm/sprd/dw_dsi_ctrl.c | 794 + drivers/gpu/drm

[PATCH v2 4/6] drm/sprd: add Unisoc's drm display controller driver

2020-12-28 Thread Kevin Tang
Adds DPU(Display Processor Unit) support for the Unisoc's display subsystem. It's support multi planes, scaler, rotation, PQ(Picture Quality) and more. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang v2: - Use drm_xxx to replace all DRM_XXX. - Use kzalloc to replace

[PATCH v2 0/6] Add Unisoc's drm kms module

2020-12-28 Thread Kevin Tang
. Add commit messages for Unisoc's virtual nodes. v2: 1. Use drm_xxx to replace all DRM_XXX. 2. Use kzalloc to replace devm_kzalloc for sprd_dsi/sprd_dpu structure init. Kevin Tang (6): dt-bindings: display: add Unisoc's drm master bindings drm/sprd: add Unisoc's drm kms master dt-bindings: dis

[PATCH v2 5/6] dt-bindings: display: add Unisoc's mipi dsi controller bindings

2020-12-28 Thread Kevin Tang
From: Kevin Tang Adds MIPI DSI Controller support for Unisoc's display subsystem. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang Reviewed-by: Rob Herring --- .../display/sprd/sprd,sharkl3-dsi-host.yaml| 107 + 1 file changed, 107 insertions

[PATCH v1 5/6] dt-bindings: display: add Unisoc's mipi dsi controller bindings

2020-12-08 Thread Kevin Tang
From: Kevin Tang Adds MIPI DSI Controller support for Unisoc's display subsystem. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang --- .../display/sprd/sprd,sharkl3-dsi-host.yaml| 107 + 1 file changed, 107 insertions(+) create mode 100644

[PATCH v1 2/6] drm/sprd: add Unisoc's drm kms master

2020-12-08 Thread Kevin Tang
test tool) and Android HWComposer. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang --- drivers/gpu/drm/Kconfig | 2 + drivers/gpu/drm/Makefile| 1 + drivers/gpu/drm/sprd/Kconfig| 12 +++ drivers/gpu/drm/sprd/Makefile | 5 + drivers/gpu/drm/sprd/sprd_drm.c

[PATCH v1 0/6] Add Unisoc's drm kms module

2020-12-08 Thread Kevin Tang
for sprd drtc driver, but dpu_layer need to keeping. Because all the HW update in crtc->atomic_flush, we need temporary storage all layers for the dpu pageflip of atomic_flush. 2. Add ports subnode with port@X. v1: 1. Remove dphy and dsi graph binding, merge the dphy driver into the dsi. 2

[PATCH v1 4/6] drm/sprd: add Unisoc's drm display controller driver

2020-12-08 Thread Kevin Tang
Adds DPU(Display Processor Unit) support for the Unisoc's display subsystem. It's support multi planes, scaler, rotation, PQ(Picture Quality) and more. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang --- drivers/gpu/drm/sprd/Kconfig| 1 + drivers/gpu/drm/sprd/Makefile | 6

[PATCH v1 1/6] dt-bindings: display: add Unisoc's drm master bindings

2020-12-08 Thread Kevin Tang
From: Kevin Tang The Unisoc DRM master device is a virtual device needed to list all DPU devices or other display interface nodes that comprise the graphics subsystem Unisoc's display pipeline have several components as below description, multi display controllers and corresponding physical

[PATCH v1 6/6] drm/sprd: add Unisoc's drm mipi dsi driver

2020-12-08 Thread Kevin Tang
Cc: Chunyan Zhang Signed-off-by: Kevin Tang --- drivers/gpu/drm/sprd/Makefile |8 +- drivers/gpu/drm/sprd/dw_dsi_ctrl.c | 792 + drivers/gpu/drm/sprd/dw_dsi_ctrl.h | 1475 drivers/gpu/drm/sprd/dw_dsi_ctrl_ppi.c | 275

[PATCH v1 3/6] dt-bindings: display: add Unisoc's dpu bindings

2020-12-08 Thread Kevin Tang
From: Kevin Tang DPU (Display Processor Unit) is the Display Controller for the Unisoc SoCs which transfers the image data from a video memory buffer to an internal LCD interface. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang --- .../bindings/display/sprd/sprd,sharkl3-dpu.yaml

Re: [PATCH 5/6] dt-bindings: display: add Unisoc's mipi dsi bindings

2020-12-02 Thread Kevin Tang
Hi Rob, Rob Herring 于2020年12月1日周二 上午4:31写道: > On Mon, Nov 30, 2020 at 7:29 AM Kevin Tang wrote: > > > > From: Kevin Tang > > > > Adds MIPI DSI Master and MIPI DSI-PHY (D-PHY) > > support for Unisoc's display subsystem. > > > > Cc: Orson Zhai &g

[PATCH 5/6] dt-bindings: display: add Unisoc's mipi dsi bindings

2020-12-01 Thread Kevin Tang
From: Kevin Tang Adds MIPI DSI Master and MIPI DSI-PHY (D-PHY) support for Unisoc's display subsystem. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang --- .../display/sprd/sprd,sharkl3-dsi-host.yaml| 107 + .../display/sprd/sprd,sharkl3-dsi-phy.yaml

[PATCH 2/6] drm/sprd: add Unisoc's drm kms master

2020-12-01 Thread Kevin Tang
test tool) and Android HWComposer. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang --- drivers/gpu/drm/Kconfig | 2 + drivers/gpu/drm/Makefile| 1 + drivers/gpu/drm/sprd/Kconfig| 12 +++ drivers/gpu/drm/sprd/Makefile | 5 + drivers/gpu/drm/sprd/sprd_drm.c

[PATCH 6/6] drm/sprd: add Unisoc's drm mipi dsi driver

2020-12-01 Thread Kevin Tang
Adds dsi host controller support for the Unisoc's display subsystem. Adds dsi phy support for the Unisoc's display subsystem. Only MIPI DSI Displays supported, DP/TV/HMDI will be support in the feature. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang --- drivers/gpu/drm/sprd

[PATCH 4/6] drm/sprd: add Unisoc's drm display controller driver

2020-12-01 Thread Kevin Tang
Adds DPU(Display Processor Unit) support for the Unisoc's display subsystem. It's support multi planes, scaler, rotation, PQ(Picture Quality) and more. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang --- drivers/gpu/drm/sprd/Kconfig| 1 + drivers/gpu/drm/sprd/Makefile | 6

  1   2   >