Re: [PATCH v2 2/9] vgacon: rework screen_info #ifdef checks

2023-07-21 Thread Khalid Aziz
that is handled by EFI. IA64 has both vgacon and EFI, though EFI apparently never uses a framebuffer here. Reviewed-by: Javier Martinez Canillas Reviewed-by: Thomas Zimmermann Signed-off-by: Arnd Bergmann Reviewed-by: Khalid Aziz --- v2 changes: - split out mips/jazz change - improve

Re: [PATCH v2 6/9] vgacon: clean up global screen_info instances

2023-07-21 Thread Khalid Aziz
changes are reasonable. Acked-by: Khalid Aziz --- arch/alpha/kernel/proto.h | 2 ++ arch/alpha/kernel/setup.c | 6 ++-- arch/alpha/kernel/sys_sio.c | 6 ++-- arch/arm/include/asm/setup.h | 5 arch/arm/kernel/atags_parse.c | 18 ++-- arch/arm

Re: [PATCH v2 5/9] vgacon: remove screen_info dependency

2023-07-21 Thread Khalid Aziz
On 7/19/23 6:39 AM, Arnd Bergmann wrote: From: Arnd Bergmann The vga console driver is fairly self-contained, and only used by architectures that explicitly initialize the screen_info settings. Chance every instance that picks the vga console by setting conswitchp to call a function instead,

Re: [PATCH v2 1/9] vgacon: rework Kconfig dependencies

2023-07-21 Thread Khalid Aziz
-by: Thomas Zimmermann Signed-off-by: Arnd Bergmann Reviewed-by: Khalid Aziz --- drivers/video/console/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/video/console/Kconfig b/drivers/video/console/Kconfig index 1b5a319971ed0..6af90db6d2da9 100644

Re: [PATCH v18 10/15] drm/radeon: untag user pointers in radeon_gem_userptr_ioctl

2019-06-27 Thread Khalid Aziz
ups, which can only by done with > untagged pointers. > > This patch untags user pointers in radeon_gem_userptr_ioctl(). > > Suggested-by: Felix Kuehling > Acked-by: Felix Kuehling > Signed-off-by: Andrey Konovalov > --- Reviewed-by: Khalid Aziz > drivers/gpu/drm/rade

Re: [PATCH v17 05/15] mm, arm64: untag user pointers in mm/gup.c

2019-06-20 Thread Khalid Aziz
s. > > Reviewed-by: Kees Cook > Reviewed-by: Catalin Marinas > Signed-off-by: Andrey Konovalov > --- Reviewed-by: Khalid Aziz > mm/gup.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/mm/gup.c b/mm/gup.c > index ddde097cf9e4..c37df3d455a2 100644 > --

Re: [PATCH v17 04/15] mm, arm64: untag user pointers passed to memory syscalls

2019-06-20 Thread Khalid Aziz
ur for the > corresponding vma. > > Reviewed-by: Catalin Marinas > Reviewed-by: Kees Cook > Signed-off-by: Andrey Konovalov > --- Reviewed-by: Khalid Aziz > mm/madvise.c | 2 ++ > mm/mempolicy.c | 3 +++ > mm/migrate.c | 2 +- > mm/mincore.c | 2 ++ > mm/mloc

Re: [PATCH v17 06/15] mm, arm64: untag user pointers in get_vaddr_frames

2019-06-20 Thread Khalid Aziz
e to commit log in my previous email: Reviewed-by: Khalid Aziz > mm/frame_vector.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/mm/frame_vector.c b/mm/frame_vector.c > index c64dca6e27c2..c431ca81dad5 100644 > --- a/mm/frame_vector.c > +++ b/mm/frame_vector

Re: [PATCH v17 07/15] fs, arm64: untag user pointers in copy_mount_options

2019-06-20 Thread Khalid Aziz
before subtracting. > > Reviewed-by: Kees Cook > Reviewed-by: Catalin Marinas > Signed-off-by: Andrey Konovalov > --- Please update commit log to make it not arm64 specific since this change affects other architectures as well. Other than that, Reviewed-by: Khalid Aziz > fs/name

Re: [PATCH v17 04/15] mm, arm64: untag user pointers passed to memory syscalls

2019-06-20 Thread Khalid Aziz
On 6/19/19 9:55 AM, Khalid Aziz wrote: > On 6/12/19 5:43 AM, Andrey Konovalov wrote: >> This patch is a part of a series that extends arm64 kernel ABI to allow to >> pass tagged user pointers (with the top byte set to something else other >> than 0x00) as syscall arguments. &g

Re: [PATCH v17 12/15] media/v4l2-core, arm64: untag user pointers in videobuf_dma_contig_user_get

2019-06-20 Thread Khalid Aziz
to not be specific to arm64. Reviewed-by: Khalid Aziz > drivers/media/v4l2-core/videobuf-dma-contig.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > exact_copy_from_user > diff --git a/drivers/media/v4l2-core/videobuf-dma-contig.c > b/drivers/medi

Re: [PATCH v16 04/16] mm: untag user pointers in do_pages_move

2019-06-12 Thread Khalid Aziz
On 6/3/19 10:55 AM, Andrey Konovalov wrote: > This patch is a part of a series that extends arm64 kernel ABI to allow to > pass tagged user pointers (with the top byte set to something else other > than 0x00) as syscall arguments. > > do_pages_move() is used in the implementation of the

Re: [PATCH v16 03/16] lib, arm64: untag user pointers in strn*_user

2019-06-12 Thread Khalid Aziz
ters to perform > validity checks, but then uses them as is to perform user memory accesses. > > Reviewed-by: Catalin Marinas > Signed-off-by: Andrey Konovalov > --- > lib/strncpy_from_user.c | 3 ++- > lib/strnlen_user.c | 3 ++- > 2 files changed, 4 insertions(

Re: [PATCH v16 01/16] uaccess: add untagged_addr definition for other arches

2019-06-04 Thread Khalid Aziz
rchitectures. > > Define it as a noop for architectures other than arm64. > > Acked-by: Catalin Marinas > Reviewed-by: Khalid Aziz > Signed-off-by: Andrey Konovalov > --- > include/linux/mm.h | 4 > 1 file changed, 4 insertions(+) > > diff --git a/in

Re: [PATCH v16 01/16] uaccess: add untagged_addr definition for other arches

2019-06-04 Thread Khalid Aziz
On 6/3/19 11:06 AM, Andrey Konovalov wrote: > On Mon, Jun 3, 2019 at 7:04 PM Khalid Aziz wrote: >> Andrey, >> >> This patch has now become part of the other patch series Chris Hellwig >> has sent out - >> <https://lore.kernel.org/lkml/20190601074959.14036-1

Re: [PATCH v16 01/16] uaccess: add untagged_addr definition for other arches

2019-06-04 Thread Khalid Aziz
On 6/3/19 11:29 AM, Christoph Hellwig wrote: > On Mon, Jun 03, 2019 at 11:24:35AM -0600, Khalid Aziz wrote: >> On 6/3/19 11:06 AM, Andrey Konovalov wrote: >>> On Mon, Jun 3, 2019 at 7:04 PM Khalid Aziz wrote: >>>> Andrey, >>>> >>>> This pat