Re: [PATCH 2/2] drm/dp_mst: Align mst link rate with soure rate

2021-01-25 Thread Koba Ko
On Wed, Jan 13, 2021 at 7:51 PM Jani Nikula wrote: > > On Wed, 13 Jan 2021, Koba Ko wrote: > > After read the link rate from MST hub, align with > > maximum source rate. > > > > Signed-off-by: Koba Ko > > --- > > drivers/gpu/drm/drm_dp_mst_topology.

[PATCH 1/2] drm/dp_mst: Retrieve extended DPCD caps for topology manager

2021-01-13 Thread Koba Ko
As per DP-1.3, First check DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT. If DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT is 1,read the DP_DP13_DPCD_REV to get the faster capability. If DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT is 0,read DP_DPCD_REV. Signed-off-by: Koba Ko Reviewed-by: Lyude Paul [added aux

[PATCH 2/2] drm/dp_mst: Align mst link rate with soure rate

2021-01-13 Thread Koba Ko
After read the link rate from MST hub, align with maximum source rate. Signed-off-by: Koba Ko --- drivers/gpu/drm/drm_dp_mst_topology.c | 8 drivers/gpu/drm/i915/display/intel_dp.c | 7 +++ include/drm/drm_dp_helper.h | 8 include/drm/drm_dp_mst_helper.h

[PATCH] Revert "drm/dp_mst: Retrieve extended DPCD caps for topology manager"

2020-11-03 Thread Koba Ko
This reverts commit ad44c03208e46b83e4ae3269e32c9e524aa71cf8. Currently DRM driver assume the source device caps is higher than the MST device caps. With this commit, this statement would be broken. e.g. the source device only support DP1.2 and the mst device support DP1.4. Signed-off-by: Koba

Re: [PATCH V4] drm/dp_mst: Retrieve extended DPCD caps for topology manager

2020-09-24 Thread Koba Ko
Thanks a lot. On Wed, Sep 23, 2020, 10:18 PM Lyude Paul wrote: > On Wed, 2020-09-23 at 10:16 +0800, Koba Ko wrote: > > Thanks for the review. > > Sorry for that I thought the review tag should be appended by myself. > > One thing to confirm with you, will you or I push t

Re: [PATCH V4] drm/dp_mst: Retrieve extended DPCD caps for topology manager

2020-09-23 Thread Koba Ko
print the name of the AUX adapter > in question. I don't mind just adding that myself before I push it though so > you don't need to send a respin. > > Going to go push this to drm-misc-next, thanks! > > On Tue, 2020-09-22 at 14:53 +0800, Koba Ko wrote: > &

[PATCH V4] drm/dp_mst: Retrieve extended DPCD caps for topology manager

2020-09-22 Thread Koba Ko
As per DP-1.3, First check DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT. If DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT is 1,read the DP_DP13_DPCD_REV to get the faster capability. If DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT is 0,read DP_DPCD_REV. Signed-off-by: Koba Ko Reviewed-by: Lyude Paul --- drivers

Re: [PATCH v3] drm/dp_mst: Retrieve extended DPCD caps for topology manager

2020-09-22 Thread Koba Ko
On Tue, Sep 22, 2020 at 2:11 AM Lyude Paul wrote: > > Hi, sorry I lost track of this until just now. Comments down below: Sorry, the wrong base. I will modify it based on v2 and will send v4. > > On Fri, 2020-09-11 at 11:44 +0800, Koba Ko wrote: > > As per D

Re: [PATCH v3] drm/dp_mst: Retrieve extended DPCD caps for topology manager

2020-09-22 Thread Koba Ko
On Tue, Sep 22, 2020 at 2:11 AM Lyude Paul wrote: > > Hi, sorry I lost track of this until just now. Comments down below: > Sorry, the wrong base. I will modify it based on v2 and will send v4. > On Fri, 2020-09-11 at 11:44 +0800, Koba Ko wrote: > > As per D

[PATCH v3] drm/dp_mst: Retrieve extended DPCD caps for topology manager

2020-09-11 Thread Koba Ko
As per DP-1.3, First check DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT. If DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT is 1, read the DP_DP13_DPCD_REV to get the faster capability. If DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT is 0, read DP_DPCD_REV. Signed-off-by: Koba Ko Reviewed-by: Lyude Paul

[PATCH] V2: Currently, DRM get the capability of the mst hub only from DP_DPCD_REV and get the slower speed even the mst hub can run in the faster speed.

2020-09-10 Thread Koba Ko
As per DP-1.3, First check DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT. If DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT is 1, read the DP_DP13_DPCD_REV to get the faster capability. If DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT is 0, read DP_DPCD_REV. Signed-off-by: Koba Ko --- ChangeLog: 1. use

Re: [PATCH] drm/dp: For MST hub, Get max_link_rate_lane from extended rx capability field if EXTENDED_RECEIVER_CAPABILITY_FILED_PRESENT is set.

2020-09-09 Thread Koba Ko
On Thu, Aug 27, 2020 at 1:30 PM Koba Ko wrote: > > Currently, DRM get the capability of the mst hub only from DP_DPCD_REV and > get the slower speed even the mst hub can run in the faster speed. > > As per DP-1.3, First check DP_EXTENDED_RECEIVER_CA

[PATCH] drm/dp: For MST hub, Get max_link_rate_lane from extended rx capability field if EXTENDED_RECEIVER_CAPABILITY_FILED_PRESENT is set.

2020-08-27 Thread Koba Ko
the faster capability. If DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT is 0, read DP_DPCD_REV. Signed-off-by: Koba Ko --- drivers/gpu/drm/drm_dp_mst_topology.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm