Re: [PATCH v3 02/15] phy: qualcomm: add QMP HDMI PHY driver

2023-10-26 Thread Konrad Dybcio
On 9/28/23 13:16, Dmitry Baryshkov wrote: Port Qualcomm QMP HDMI PHY to the generic PHY framework. Split the generic part and the msm8996 part. When adding support for msm8992/4 and msm8998 (which also employ QMP for HDMI PHY), one will have to provide the PLL programming part only. Signed-of

Re: [PATCH v3 15/15] drm/msm/hdmi: drop old HDMI PHY code

2023-10-26 Thread Konrad Dybcio
On 9/28/23 13:16, Dmitry Baryshkov wrote: Drop source files used by old HDMI PHY and HDMI PLL drivers. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi_phy.c | 216 --- drivers/gpu/drm/msm/hdmi/hdmi_phy_8960.c | 51 -- drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c |

Re: [PATCH v3 14/15] drm/msm/hdmi: switch to generic PHY subsystem

2023-10-26 Thread Konrad Dybcio
: Konrad Dybcio Konrad

Re: [PATCH v3 13/15] drm/msm/hdmi: pair msm_hdmi_phy_powerup with msm_hdmi_phy_powerdown

2023-10-26 Thread Konrad Dybcio
On 9/28/23 13:16, Dmitry Baryshkov wrote: In preparation to converting MSM HDMI driver to use PHY framework, which requires phy_power_on() calls to be paired with phy_power_off(), add a conditional call to msm_hdmi_phy_powerdown() before the call to msm_hdmi_phy_powerup(). Signed-off-by: Dmit

Re: [PATCH v3 11/15] drm/msm/hdmi: switch to atomic_pre_enable/post_disable

2023-10-26 Thread Konrad Dybcio
On 9/28/23 13:16, Dmitry Baryshkov wrote: In preparation of reworking the HDMI mode setting, switch pre_enable and post_disable callbacks to their atomic variants. Signed-off-by: Dmitry Baryshkov --- This looks good, but I'm far from knowledgeable in terms of drm, so: Acked-by: K

Re: [PATCH v3 10/15] drm/msm/hdmi: correct indentation of HDMI bridge functions

2023-10-26 Thread Konrad Dybcio
On 9/28/23 13:16, Dmitry Baryshkov wrote: Signed-off-by: Dmitry Baryshkov --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v3 09/15] drm/msm/hdmi: simplify extp clock handling

2023-10-26 Thread Konrad Dybcio
On 9/28/23 13:16, Dmitry Baryshkov wrote: With the extp being the only "power" clock left, remove the surrounding loops and handle the extp clock directly. Signed-off-by: Dmitry Baryshkov ---Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH] drm/msm/adreno: Drop WARN_ON from patchid lookup for new GPUs

2023-10-26 Thread Konrad Dybcio
On 10/23/23 22:20, Rob Clark wrote: On Mon, Oct 23, 2023 at 12:56 PM Konrad Dybcio wrote: On 10/23/23 21:42, Rob Clark wrote: On Mon, Oct 23, 2023 at 7:29 AM Konrad Dybcio wrote: New GPUs still use the lower 2 bytes of the chip id (in whatever form it comes) to signify silicon

Re: [PATCH] drm/msm/adreno: Drop WARN_ON from patchid lookup for new GPUs

2023-10-23 Thread Konrad Dybcio
On 10/23/23 21:42, Rob Clark wrote: On Mon, Oct 23, 2023 at 7:29 AM Konrad Dybcio wrote: New GPUs still use the lower 2 bytes of the chip id (in whatever form it comes) to signify silicon revision. Drop the warning that makes it sound as if that was unintended. Fixes: 90b593ce1c9e (&quo

[PATCH] drm/msm/adreno: Drop WARN_ON from patchid lookup for new GPUs

2023-10-23 Thread Konrad Dybcio
New GPUs still use the lower 2 bytes of the chip id (in whatever form it comes) to signify silicon revision. Drop the warning that makes it sound as if that was unintended. Fixes: 90b593ce1c9e ("drm/msm/adreno: Switch to chip-id for identifying GPU") Signed-off-by: Konrad Dybcio --- d

Re: [PATCH] drm/panel/raydium-rm692e5: select CONFIG_DRM_DISPLAY_DP_HELPER

2023-10-23 Thread Konrad Dybcio
On 23.10.2023 15:25, Neil Armstrong wrote: > Hi, > > On 23/10/2023 13:55, Arnd Bergmann wrote: >> From: Arnd Bergmann >> >> As with several other panel drivers, this fails to link without the DP >> helper library: >> >> ld: drivers/gpu/drm/panel/panel-raydium-rm692e5.o: in function >> `rm692e5_p

Re: [PATCH 5/7] arm64: dts: qcom: sc7280: Fix up GPU SIDs

2023-10-18 Thread Konrad Dybcio
On 10/16/23 22:22, Akhil P Oommen wrote: On Tue, Sep 26, 2023 at 08:24:40PM +0200, Konrad Dybcio wrote: GPU_SMMU SID 1 is meant for Adreno LPAC (Low Priority Async Compute). On platforms that support it (in firmware), it is necessary to describe that link, or Adreno register access will

Re: [PATCH 2/7] drm/msm/adreno: Add ZAP firmware name to A635

2023-10-17 Thread Konrad Dybcio
On 10/17/23 09:33, Rob Clark wrote: On Mon, Oct 16, 2023 at 1:12 PM Akhil P Oommen wrote: On Tue, Sep 26, 2023 at 08:24:37PM +0200, Konrad Dybcio wrote: Some (many?) devices with A635 expect a ZAP shader to be loaded. Set the file name to allow for that. Signed-off-by: Konrad Dybcio

Re: [PATCH] drm/msm/a6xx: add QMP dependency

2023-10-17 Thread Konrad Dybcio
_send' Add the usual dependency that still allows compiling without QMP but otherwise avoids the broken combination of options. Fixes: 88a0997f2f949 ("drm/msm/a6xx: Send ACD state to QMP at GMU resume") Signed-off-by: Arnd Bergmann --- Right, thanks! Reviewed-by: Konrad Dybcio Konrad

[PATCH] drm/msm/a6xx: Fix up QMP handling

2023-10-13 Thread Konrad Dybcio
these issues. Reported-by: Dan Carpenter Fixes: 88a0997f2f94 ("drm/msm/a6xx: Send ACD state to QMP at GMU resume") Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/g

Re: [PATCH v3 6/6] arm64: dts: qcom: sdm670: add display subsystem

2023-10-10 Thread Konrad Dybcio
On 10/10/23 01:33, Richard Acayan wrote: The Snapdragon 670 has a display subsystem for controlling and outputting to the display. Add support for it in the device tree. Reviewed-by: Dmitry Baryshkov Signed-off-by: Richard Acayan --- [...] + interconnects = <&mmss_n

[PATCH v2 2/2] drm/panel: Add driver for BOE RM692E5 AMOLED panel

2023-09-29 Thread Konrad Dybcio
Add support for the 2700x1224 AMOLED BOE panel bundled with a RM692E5 driver IC, as found on the Fairphone 5 smartphone. Co-developed-by: Luca Weiss Signed-off-by: Luca Weiss Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile

[PATCH v2 1/2] dt-bindings: display: panel: Add Raydium RM692E5

2023-09-29 Thread Konrad Dybcio
Raydium RM692E5 is a display driver IC used to drive AMOLED DSI panels. Describe it. Reviewed-by: Conor Dooley Signed-off-by: Konrad Dybcio --- .../bindings/display/panel/raydium,rm692e5.yaml| 73 ++ 1 file changed, 73 insertions(+) diff --git a/Documentation

[PATCH v2 0/2] Raydium RM692E5-based BOE panel driver

2023-09-29 Thread Konrad Dybcio
The Fairphone 5 smartphone ships with a BOE AMOLED panel in conjunction with a Raydium RM692E5 driver IC. This series adds the bindings and driver for that. Signed-off-by: Konrad Dybcio --- Changes in v2: DRIVER: - Remove 1ms sleeps after each DCS command submission - Remove WARN_ON from probe

Re: [PATCH 2/2] drm/panel: Add driver for BOE RM692E5 AMOLED panel

2023-09-28 Thread Konrad Dybcio
On 29.09.2023 00:00, Jessica Zhang wrote: > Hi Konrad, > > On 9/27/2023 6:19 AM, Konrad Dybcio wrote: >> Add support for the 2700x1224 AMOLED BOE panel bundled with a RM692E5 >> driver IC, as found on the Fairphone 5 smartphone. >> >> Co-developed-by: Luca We

Re: [PATCH 1/2] dt-bindings: display: panel: Add Raydium RM692E5

2023-09-28 Thread Konrad Dybcio
On 28.09.2023 19:09, Conor Dooley wrote: > On Wed, Sep 27, 2023 at 03:19:01PM +0200, Konrad Dybcio wrote: >> Raydium RM692E5 is a display driver IC used to drive AMOLED DSI panels. >> Describe it. >> >> Signed-off-by: Konrad Dybcio >> --- >> .../bind

Re: [PATCH v3 01/15] phy: Add HDMI configuration options

2023-09-28 Thread Konrad Dybcio
On 28.09.2023 13:16, Dmitry Baryshkov wrote: > From: Sandor Yu > > Allow HDMI PHYs to be configured through the generic > functions through a custom structure added to the generic union. > > The parameters added here are based on HDMI PHY > implementation practices. The current set of parameter

[PATCH 2/2] drm/panel: Add driver for BOE RM692E5 AMOLED panel

2023-09-27 Thread Konrad Dybcio
Add support for the 2700x1224 AMOLED BOE panel bundled with a RM692E5 driver IC, as found on the Fairphone 5 smartphone. Co-developed-by: Luca Weiss Signed-off-by: Luca Weiss Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile

[PATCH 1/2] dt-bindings: display: panel: Add Raydium RM692E5

2023-09-27 Thread Konrad Dybcio
Raydium RM692E5 is a display driver IC used to drive AMOLED DSI panels. Describe it. Signed-off-by: Konrad Dybcio --- .../bindings/display/panel/raydium,rm692e5.yaml| 73 ++ 1 file changed, 73 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel

[PATCH 0/2] Raydium RM692E5-based BOE panel driver

2023-09-27 Thread Konrad Dybcio
The Fairphone 5 smartphone ships with a BOE AMOLED panel in conjunction with a Raydium RM692E5 driver IC. This series adds the bindings and driver for that. Signed-off-by: Konrad Dybcio --- Konrad Dybcio (2): dt-bindings: display: panel: Add Raydium RM692E5 drm/panel: Add driver for

Re: [PATCH 5/6] drm/msm/dpu: Add hw revision 4.1 (SDM670)

2023-09-26 Thread Konrad Dybcio
On 26.09.2023 01:26, Richard Acayan wrote: > The Snapdragon 670 uses similar clocks (with one frequency added) to the > Snapdragon 845 but reports DPU revision 4.1. Add support for this DPU > with configuration from the Pixel 3a downstream kernel. > > Since revision 4.0 is SDM845, reuse some confi

Re: [PATCH v2 1/1] drm/msm/adreno: Add support for SM7150 SoC machine

2023-09-26 Thread Konrad Dybcio
On 26.09.2023 21:10, Danila Tikhonov wrote: > > I think you mean by name downstream dt - sdmmagpie-gpu.dtsi > > You can see the forked version of the mainline here: > https://github.com/sm7150-mainline/linux/blob/next/arch/arm64/boot/dts/qcom/sm7150.dtsi > > All fdt that we got here, if it is us

Re: [PATCH v2 1/1] drm/msm/adreno: Add support for SM7150 SoC machine

2023-09-26 Thread Konrad Dybcio
On 26.09.2023 19:42, Danila Tikhonov wrote: > SM7150 has 5 power levels which correspond to 5 speed-bin values: 0, > 128, 146, 167, 172. Speed-bin value is calulated as FMAX/4.8MHz round up > to zero decimal places. > > Also a618 on SM7150 uses a615 zapfw. Add a squashed version (.mbn). > > Add t

Re: [PATCH 4/7] arm64: dts: qcom: sc7280: Add ZAP shader support

2023-09-26 Thread Konrad Dybcio
On 26.09.2023 20:24, Konrad Dybcio wrote: > Non-Chrome SC7280-family platforms ship a ZAP shader with the Adreno GPU. > Describe that and make sure it doesn't interfere with Chrome devices. > > Signed-off-by: Konrad Dybcio > --- > arch/arm64/boot/dts/qcom/sc7280-

Re: [PATCH 6/7] arm64: dts: qcom: sc7280: Mark Adreno SMMU as DMA coherent

2023-09-26 Thread Konrad Dybcio
On 26.09.2023 20:24, Konrad Dybcio wrote: > The SMMUs on sc7280 are cache-coherent. APPS_SMMU is marked as such, > mark the GPU one as well. > > Signed-off-by: Konrad Dybcio > --- Fixes: 96c471970b7b ("arm64: dts: qcom: sc7280: Add gpu support") Sorry. Konrad

[PATCH 6/7] arm64: dts: qcom: sc7280: Mark Adreno SMMU as DMA coherent

2023-09-26 Thread Konrad Dybcio
The SMMUs on sc7280 are cache-coherent. APPS_SMMU is marked as such, mark the GPU one as well. Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sc7280.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi

[PATCH 7/7] arm64: dts: qcom: sc7280: Add 0xac Adreno speed bin

2023-09-26 Thread Konrad Dybcio
A643 (A635 speedbin 0xac) tops out at 812 MHz. Fill in the opp-supported-hw appropriately. Note that fuseval 0xac is referred to as speedbin 1 downstream, but that was already in use upstream, so 2 was chosen instead. Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sc7280.dtsi | 12

[PATCH 5/7] arm64: dts: qcom: sc7280: Fix up GPU SIDs

2023-09-26 Thread Konrad Dybcio
. Fixes: 96c471970b7b ("arm64: dts: qcom: sc7280: Add gpu support") Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sc7280.dtsi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.

[PATCH 3/7] drm/msm/adreno: Add A635 speedbin 0xac (A643)

2023-09-26 Thread Konrad Dybcio
Downstream calls this the "speedbin 1", but that number is already occupied. Use index two. Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/adreno_device.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/

[PATCH 4/7] arm64: dts: qcom: sc7280: Add ZAP shader support

2023-09-26 Thread Konrad Dybcio
Non-Chrome SC7280-family platforms ship a ZAP shader with the Adreno GPU. Describe that and make sure it doesn't interfere with Chrome devices. Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sc7280-chrome-common.dtsi | 2 ++ arch/arm64/boot/dts/qcom/sc7280.dtsi

[PATCH 1/7] drm/msm/a6xx: Fix unknown speedbin case

2023-09-26 Thread Konrad Dybcio
eniently always bound to fuseval == 0). Fixes: c928a05e4415 ("drm/msm/adreno: Move speedbin mapping to device table") Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx

[PATCH 2/7] drm/msm/adreno: Add ZAP firmware name to A635

2023-09-26 Thread Konrad Dybcio
Some (many?) devices with A635 expect a ZAP shader to be loaded. Set the file name to allow for that. Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/adreno_device.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm

[PATCH 0/7] Adreno 643 + fixes

2023-09-26 Thread Konrad Dybcio
as it says on the can drm/msm patches for Rob arm64 patches for linux-arm-msm for use with https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25408 tested on QCM6490 (SC7280-IOT) Fairphone FP5 Signed-off-by: Konrad Dybcio --- Konrad Dybcio (7): drm/msm/a6xx: Fix unknown speedbin

[PATCH v5 10/10] drm/msm/a6xx: Poll for GBIF unhalt status in hw_init

2023-09-25 Thread Konrad Dybcio
d GPU that can't receive data on its end of the bus. Failing to do this will result in inexplicable GMU timeouts or worse. This is a rather ugly hack which introduces a whole lot of latency. Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Dmitry Baryshkov # sm8450 Signed-off-by: Kon

[PATCH v5 07/10] drm/msm/a6xx: Mostly implement A7xx gpu_state

2023-09-25 Thread Konrad Dybcio
Provide the necessary alternations to mostly support state dumping on A7xx. Newer GPUs will probably require more changes here. Crashdumper and debugbus remain untested. Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Dmitry Baryshkov # sm8450 Signed-off-by: Konrad Dybcio --- drivers/gpu

[PATCH v5 09/10] drm/msm/a6xx: Add A740 support

2023-09-25 Thread Konrad Dybcio
# on SM8550-QRD Tested-by: Dmitry Baryshkov # sm8450 Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 88 +- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 82 +--- drivers/gpu/drm/msm/adreno/a6xx_hfi.c | 27

[PATCH v5 08/10] drm/msm/a6xx: Add A730 support

2023-09-25 Thread Konrad Dybcio
Add support for Adreno 730, also known as GEN7_0_x, found on SM8450. Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Dmitry Baryshkov # sm8450 Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 126 - drivers/gpu/drm/msm/adreno

[PATCH v5 06/10] drm/msm/a6xx: Send ACD state to QMP at GMU resume

2023-09-25 Thread Konrad Dybcio
8550-QRD Tested-by: Dmitry Baryshkov # sm8450 Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 15 +++ drivers/gpu/drm/msm/adreno/a6xx_gmu.h | 3 +++ 2 files changed, 18 insertions(+) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu

[PATCH v5 05/10] drm/msm/a6xx: Add skeleton A7xx support

2023-09-25 Thread Konrad Dybcio
Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Dmitry Baryshkov # sm8450 Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 96 +-- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 451 drivers/gpu/drm/msm/adreno/adreno_gpu.c | 1 +

[PATCH v5 03/10] dt-bindings: display/msm/gpu: Allow A7xx SKUs

2023-09-25 Thread Konrad Dybcio
Allow A7xx SKUs, such as the A730 GPU found on SM8450 and friends. They use GMU for all things DVFS, just like most A6xx GPUs. Reviewed-by: Krzysztof Kozlowski Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Dmitry Baryshkov # sm8450 Signed-off-by: Konrad Dybcio --- Documentation

[PATCH v5 01/10] dt-bindings: display/msm/gmu: Add Adreno 7[34]0 GMU

2023-09-25 Thread Konrad Dybcio
U. Reviewed-by: Krzysztof Kozlowski Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Dmitry Baryshkov # sm8450 Signed-off-by: Konrad Dybcio --- .../devicetree/bindings/display/msm/gmu.yaml | 40 +- 1 file changed, 39 insertions(+), 1 deletion(-) diff --git a/Documenta

[PATCH v5 04/10] drm/msm/a6xx: Add missing regs for A7XX

2023-09-25 Thread Konrad Dybcio
Add some missing definitions required for A7 support. This may be substituted with a mesa header sync. Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Dmitry Baryshkov # sm8450 Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx.xml.h | 9 + drivers/gpu/drm/msm

[PATCH v5 02/10] dt-bindings: display/msm/gmu: Allow passing QMP handle

2023-09-25 Thread Konrad Dybcio
: Krzysztof Kozlowski Signed-off-by: Konrad Dybcio --- Documentation/devicetree/bindings/display/msm/gmu.yaml | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/gmu.yaml b/Documentation/devicetree/bindings/display/msm/gmu.yaml index 428eb138881a

[PATCH v5 00/10] A7xx support

2023-09-25 Thread Konrad Dybcio
olrz,flushall,noubwc MESA_LOADER_DRIVER_OVERRIDE=zink kmscube [1] https://lore.kernel.org/linux-arm-msm/20230517-topic-a7xx_prep-v4-0-b16f273a9...@linaro.org/ [2] https://github.com/SoMainline/linux/commits/topic/a7xx_dt [3] https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23217 Signed-o

Re: [PATCH 2/3] drm/msm/dpu: Add missing DPU_DSC_OUTPUT_CTRL to SC7280

2023-09-21 Thread Konrad Dybcio
On 9/21/23 02:01, Abhinav Kumar wrote: On 9/20/2023 3:46 PM, Konrad Dybcio wrote: DPU_DSC_OUTPUT_CTRL should be enabled for all platforms with a CTL CFG 1.0.0. SC7280 is one of them. Add it. sc7280 and all other chipsets using DSC 1.2 use dpu_hw_dsc_init_1_2 and not dpu_hw_dsc_init

Re: [PATCH 1/3] drm/msm/dpu: Fix SC7280 PP length

2023-09-21 Thread Konrad Dybcio
On 9/21/23 01:41, Abhinav Kumar wrote: On 9/20/2023 3:46 PM, Konrad Dybcio wrote: Commit 194347df5844 ("drm/msm/dpu: inline DSC_BLK and DSC_BLK_1_2 macros") unrolled a macro incorrectly. Fix that. No, its correct from what i can tell. Before inlining it was using PP_BLK_DI

[PATCH 2/3] drm/msm/dpu: Add missing DPU_DSC_OUTPUT_CTRL to SC7280

2023-09-20 Thread Konrad Dybcio
DPU_DSC_OUTPUT_CTRL should be enabled for all platforms with a CTL CFG 1.0.0. SC7280 is one of them. Add it. Fixes: 0d1b10c63346 ("drm/msm/dpu: add DSC 1.2 hw blocks for relevant chipsets") Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_7_2_sc7280.h | 2

[PATCH 3/3] drm/msm/dpu: Fix SC7280 DSC block length

2023-09-20 Thread Konrad Dybcio
Commit e550ad0e5c3d ("drm/msm/dpu: fix DSC 1.2 block lengths") changed the block length from a wrong value to another wrong value. Use the correct one this time. Fixes: e550ad0e5c3d ("drm/msm/dpu: fix DSC 1.2 block lengths") Signed-off-by: Konrad Dybcio --- drivers/g

[PATCH 1/3] drm/msm/dpu: Fix SC7280 PP length

2023-09-20 Thread Konrad Dybcio
Commit 194347df5844 ("drm/msm/dpu: inline DSC_BLK and DSC_BLK_1_2 macros") unrolled a macro incorrectly. Fix that. Fixes: 194347df5844 ("drm/msm/dpu: inline DSC_BLK and DSC_BLK_1_2 macros") Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_7_2_sc72

[PATCH 0/3] SC7280 DPU fixups

2023-09-20 Thread Konrad Dybcio
Found a couple mistakes, this series attempts to fix it. Signed-off-by: Konrad Dybcio --- Konrad Dybcio (3): drm/msm/dpu: Fix SC7280 PP length drm/msm/dpu: Add missing DPU_DSC_OUTPUT_CTRL to SC7280 drm/msm/dpu: Fix SC7280 DSC block length drivers/gpu/drm/msm/disp/dpu1/catalog

Re: [PATCH] drm/msm/dsi: fix irq_of_parse_and_map() error checking

2023-09-15 Thread Konrad Dybcio
On 15.09.2023 14:59, Dan Carpenter wrote: > The irq_of_parse_and_map() function returns zero on error. It > never returns negative error codes. Fix the check. > > Fixes: a689554ba6ed ("drm/msm: Initial add DSI connector support") > Signed-off-by: Dan Carpenter > --

Re: [PATCH] drm/msm/adreno: Add support for SM7150 SoC machine

2023-09-13 Thread Konrad Dybcio
On 13.09.2023 21:19, Danila Tikhonov wrote: > SM7150 has 5 power levels which correspond to 5 speed-bin values: 0, > 128, 146, 167, 172. Speed-bin value is calulated as FMAX/4.8MHz round up > to zero decimal places. > > The vendor's FW GMU is called a618_gmu.bin. And also a618 on SM7150 uses > a61

Re: [PATCH v3 09/10] drm/msm/a6xx: Add A740 support

2023-09-12 Thread Konrad Dybcio
On 23.08.2023 14:56, Konrad Dybcio wrote: > A740 builds upon the A730 IP, shuffling some values and registers > around. More differences will appear when things like BCL are > implemented. > > adreno_is_a740_family is added in preparation for more A7xx GPUs, > the logic ch

[PATCH v4 10/10] drm/msm/a6xx: Poll for GBIF unhalt status in hw_init

2023-09-12 Thread Konrad Dybcio
d GPU that can't receive data on its end of the bus. Failing to do this will result in inexplicable GMU timeouts or worse. This is a rather ugly hack which introduces a whole lot of latency. Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Dmitry Baryshkov # sm8450 Signed-off-by: Kon

[PATCH v4 01/10] dt-bindings: display/msm/gmu: Add Adreno 7[34]0 GMU

2023-09-12 Thread Konrad Dybcio
U. Reviewed-by: Krzysztof Kozlowski Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Dmitry Baryshkov # sm8450 Signed-off-by: Konrad Dybcio --- .../devicetree/bindings/display/msm/gmu.yaml | 40 +- 1 file changed, 39 insertions(+), 1 deletion(-) diff --git a/Documenta

[PATCH v4 09/10] drm/msm/a6xx: Add A740 support

2023-09-12 Thread Konrad Dybcio
# on SM8550-QRD Tested-by: Dmitry Baryshkov # sm8450 Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 88 +- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 82 +--- drivers/gpu/drm/msm/adreno/a6xx_hfi.c | 27

[PATCH v4 08/10] drm/msm/a6xx: Add A730 support

2023-09-12 Thread Konrad Dybcio
Add support for Adreno 730, also known as GEN7_0_x, found on SM8450. Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Dmitry Baryshkov # sm8450 Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 126 - drivers/gpu/drm/msm/adreno

[PATCH v4 07/10] drm/msm/a6xx: Mostly implement A7xx gpu_state

2023-09-12 Thread Konrad Dybcio
Provide the necessary alternations to mostly support state dumping on A7xx. Newer GPUs will probably require more changes here. Crashdumper and debugbus remain untested. Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Dmitry Baryshkov # sm8450 Signed-off-by: Konrad Dybcio --- drivers/gpu

[PATCH v4 06/10] drm/msm/a6xx: Send ACD state to QMP at GMU resume

2023-09-12 Thread Konrad Dybcio
8550-QRD Tested-by: Dmitry Baryshkov # sm8450 Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 21 + drivers/gpu/drm/msm/adreno/a6xx_gmu.h | 3 +++ 2 files changed, 24 insertions(+) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu

[PATCH v4 04/10] drm/msm/a6xx: Add missing regs for A7XX

2023-09-12 Thread Konrad Dybcio
Add some missing definitions required for A7 support. This may be substituted with a mesa header sync. Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Dmitry Baryshkov # sm8450 Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx.xml.h | 9 + drivers/gpu/drm/msm

[PATCH v4 05/10] drm/msm/a6xx: Add skeleton A7xx support

2023-09-12 Thread Konrad Dybcio
Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Dmitry Baryshkov # sm8450 Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 96 +-- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 451 drivers/gpu/drm/msm/adreno/adreno_gpu.c | 1 +

[PATCH v4 03/10] dt-bindings: display/msm/gpu: Allow A7xx SKUs

2023-09-12 Thread Konrad Dybcio
Allow A7xx SKUs, such as the A730 GPU found on SM8450 and friends. They use GMU for all things DVFS, just like most A6xx GPUs. Reviewed-by: Krzysztof Kozlowski Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Dmitry Baryshkov # sm8450 Signed-off-by: Konrad Dybcio --- Documentation

[PATCH v4 02/10] dt-bindings: display/msm/gmu: Allow passing QMP handle

2023-09-12 Thread Konrad Dybcio
: Krzysztof Kozlowski Signed-off-by: Konrad Dybcio --- Documentation/devicetree/bindings/display/msm/gmu.yaml | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/gmu.yaml b/Documentation/devicetree/bindings/display/msm/gmu.yaml index 20ddb89a4500

[PATCH v4 00/10] A7xx support

2023-09-12 Thread Konrad Dybcio
olrz,flushall,noubwc MESA_LOADER_DRIVER_OVERRIDE=zink kmscube [1] https://lore.kernel.org/linux-arm-msm/20230517-topic-a7xx_prep-v4-0-b16f273a9...@linaro.org/ [2] https://github.com/SoMainline/linux/commits/topic/a7xx_dt [3] https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23217 Signed-o

Re: [PATCH v3 2/9] arm64: dts: qcom: apq8016-sbc: Add overlay for usb host mode

2023-09-11 Thread Konrad Dybcio
On 8.09.2023 17:22, Vignesh Raman wrote: > Due to the presence of the fastboot micro cable in the CI farm, > it causes the hardware to remain in gadget mode instead of host mode. > So it doesn't find the network, which results in failure to mount root > fs via NFS. > > Add an overlay dtso file tha

Re: [PATCH v2 3/4] arm64: dts: qcom: qrb5165-rb5: enable displayport controller

2023-08-26 Thread Konrad Dybcio
On 17.08.2023 16:59, Dmitry Baryshkov wrote: > Enable the onboard displayport controller, connect it to QMP PHY. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH] drm/msm/adreno: Fix SM6375 GPU ID

2023-08-26 Thread Konrad Dybcio
On 26.08.2023 03:29, Rob Clark wrote: > On Fri, Aug 25, 2023 at 2:11 PM Konrad Dybcio > wrote: >> >> SM6375 comes with a patchlevel=1. Fix the chipid up to reflect that. >> >> Fixes: 90b593ce1c9e ("drm/msm/adreno: Switch to chip-id for identifying GP

[PATCH] drm/msm/adreno: Fix SM6375 GPU ID

2023-08-25 Thread Konrad Dybcio
SM6375 comes with a patchlevel=1. Fix the chipid up to reflect that. Fixes: 90b593ce1c9e ("drm/msm/adreno: Switch to chip-id for identifying GPU") Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/adreno_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[PATCH v3 09/10] drm/msm/a6xx: Add A740 support

2023-08-23 Thread Konrad Dybcio
# on SM8550-QRD Tested-by: Dmitry Baryshkov # sm8450 Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 88 +- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 82 +--- drivers/gpu/drm/msm/adreno/a6xx_hfi.c | 27

[PATCH v3 04/10] drm/msm/a6xx: Add missing regs for A7XX

2023-08-23 Thread Konrad Dybcio
Add some missing definitions required for A7 support. This may be substituted with a mesa header sync. Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Dmitry Baryshkov # sm8450 Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx.xml.h | 9 + drivers/gpu/drm/msm

[PATCH v3 01/10] dt-bindings: display/msm/gmu: Add Adreno 7[34]0 GMU

2023-08-23 Thread Konrad Dybcio
U. Reviewed-by: Krzysztof Kozlowski Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Dmitry Baryshkov # sm8450 Signed-off-by: Konrad Dybcio --- .../devicetree/bindings/display/msm/gmu.yaml | 40 +- 1 file changed, 39 insertions(+), 1 deletion(-) diff --git a/Documenta

[PATCH v3 10/10] drm/msm/a6xx: Poll for GBIF unhalt status in hw_init

2023-08-23 Thread Konrad Dybcio
d GPU that can't receive data on its end of the bus. Failing to do this will result in inexplicable GMU timeouts or worse. This is a rather ugly hack which introduces a whole lot of latency. Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Dmitry Baryshkov # sm8450 Signed-off-by: Kon

[PATCH v3 06/10] drm/msm/a6xx: Send ACD state to QMP at GMU resume

2023-08-23 Thread Konrad Dybcio
8550-QRD Tested-by: Dmitry Baryshkov # sm8450 Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 21 + drivers/gpu/drm/msm/adreno/a6xx_gmu.h | 3 +++ 2 files changed, 24 insertions(+) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu

[PATCH v3 05/10] drm/msm/a6xx: Add skeleton A7xx support

2023-08-23 Thread Konrad Dybcio
Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Dmitry Baryshkov # sm8450 Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 95 +-- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 451 drivers/gpu/drm/msm/adreno/adreno_gpu.c | 1 +

[PATCH v3 07/10] drm/msm/a6xx: Mostly implement A7xx gpu_state

2023-08-23 Thread Konrad Dybcio
Provide the necessary alternations to mostly support state dumping on A7xx. Newer GPUs will probably require more changes here. Crashdumper and debugbus remain untested. Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Dmitry Baryshkov # sm8450 Signed-off-by: Konrad Dybcio --- drivers/gpu

[PATCH v3 08/10] drm/msm/a6xx: Add A730 support

2023-08-23 Thread Konrad Dybcio
Add support for Adreno 730, also known as GEN7_0_x, found on SM8450. Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Dmitry Baryshkov # sm8450 Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 126 - drivers/gpu/drm/msm/adreno

[PATCH v3 02/10] dt-bindings: display/msm/gmu: Allow passing QMP handle

2023-08-23 Thread Konrad Dybcio
: Krzysztof Kozlowski Signed-off-by: Konrad Dybcio --- Documentation/devicetree/bindings/display/msm/gmu.yaml | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/gmu.yaml b/Documentation/devicetree/bindings/display/msm/gmu.yaml index 20ddb89a4500

[PATCH v3 00/10] A7xx support

2023-08-23 Thread Konrad Dybcio
olrz,flushall,noubwc MESA_LOADER_DRIVER_OVERRIDE=zink kmscube [1] https://lore.kernel.org/linux-arm-msm/20230517-topic-a7xx_prep-v4-0-b16f273a9...@linaro.org/ [2] https://github.com/SoMainline/linux/commits/topic/a7xx_dt [3] https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23217 Signed-o

[PATCH v3 03/10] dt-bindings: display/msm/gpu: Allow A7xx SKUs

2023-08-23 Thread Konrad Dybcio
Allow A7xx SKUs, such as the A730 GPU found on SM8450 and friends. They use GMU for all things DVFS, just like most A6xx GPUs. Reviewed-by: Krzysztof Kozlowski Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Dmitry Baryshkov # sm8450 Signed-off-by: Konrad Dybcio --- Documentation

Re: [PATCH] drm/msm/a690: Switch to a660_gmu.bin

2023-08-11 Thread Konrad Dybcio
On 11.08.2023 18:21, Rob Clark wrote: > On Fri, Aug 11, 2023 at 9:11 AM Konrad Dybcio > wrote: >> >> On 11.08.2023 18:09, Rob Clark wrote: >>> On Fri, Aug 11, 2023 at 9:05 AM Rob Clark wrote: >>>> >>>> From: Rob Clark >>>> >

Re: [PATCH] drm/msm/a690: Switch to a660_gmu.bin

2023-08-11 Thread Konrad Dybcio
t;> generation (or "family") will use the same fw, and a690 is in the a660 >> family. >> > > possibly this could be considered as: > > Fixes: 5e7665b5e484 ("drm/msm/adreno: Add Adreno A690 support") For a lack of a better response, "meh"

[PATCH v2 14/14] drm/msm/a6xx: Poll for GBIF unhalt status in hw_init

2023-08-08 Thread Konrad Dybcio
d GPU that can't receive data on its end of the bus. Failing to do this will result in inexplicable GMU timeouts or worse. This is a rather ugly hack which introduces a whole lot of latency. Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Dmitry Baryshkov # sm8450 Signed-off-by: Kon

[PATCH v2 13/14] drm/msm/a6xx: Vastly increase HFI timeout

2023-08-08 Thread Konrad Dybcio
A7xx GMUs can be slow as molasses at times. Increase the timeout to 1 second to match the vendor driver. Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Dmitry Baryshkov # sm8450 Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx_hfi.c | 2 +- 1 file changed, 1 insertion

[PATCH v2 12/14] drm/msm/a6xx: Add A740 support

2023-08-08 Thread Konrad Dybcio
# on SM8550-QRD Tested-by: Dmitry Baryshkov # sm8450 Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 88 +- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 82 +--- drivers/gpu/drm/msm/adreno/a6xx_hfi.c | 27

[PATCH v2 11/14] drm/msm/a6xx: Add A730 support

2023-08-08 Thread Konrad Dybcio
Add support for Adreno 730, also known as GEN7_0_x, found on SM8450. Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Dmitry Baryshkov # sm8450 Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 126 - drivers/gpu/drm/msm/adreno

[PATCH v2 10/14] drm/msm/a6xx: Mostly implement A7xx gpu_state

2023-08-08 Thread Konrad Dybcio
Provide the necessary alternations to mostly support state dumping on A7xx. Newer GPUs will probably require more changes here. Crashdumper and debugbus remain untested. Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Dmitry Baryshkov # sm8450 Signed-off-by: Konrad Dybcio --- drivers/gpu

[PATCH v2 09/14] drm/msm/a6xx: Send ACD state to QMP at GMU resume

2023-08-08 Thread Konrad Dybcio
8550-QRD Tested-by: Dmitry Baryshkov # sm8450 Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 21 + drivers/gpu/drm/msm/adreno/a6xx_gmu.h | 3 +++ 2 files changed, 24 insertions(+) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu

[PATCH v2 08/14] drm/msm/a6xx: Add skeleton A7xx support

2023-08-08 Thread Konrad Dybcio
Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Dmitry Baryshkov # sm8450 Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 95 +-- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 451 drivers/gpu/drm/msm/adreno/adreno_gpu.c | 1 +

[PATCH v2 07/14] drm/msm/a6xx: Bail out early if setting GPU OOB fails

2023-08-08 Thread Konrad Dybcio
If the GMU can't guarantee the required resources are up, trying to bring up the GPU is a lost cause. Return early if setting GPU OOB fails. Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Dmitry Baryshkov # sm8450 Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx_

[PATCH v2 05/14] drm/msm/a6xx: Introduce a6xx_llc_read

2023-08-08 Thread Konrad Dybcio
Add a helper that does exactly what it says on the can, it'll be required for A7xx. Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Dmitry Baryshkov # sm8450 Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 5 + 1 file changed, 5 insertions(+) diff --

[PATCH v2 06/14] drm/msm/a6xx: Move LLC accessors to the common header

2023-08-08 Thread Konrad Dybcio
Move these wrappers in preparation for use in a6xx_gmu.c Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Dmitry Baryshkov # sm8450 Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 15 --- drivers/gpu/drm/msm/adreno/a6xx_gpu.h | 15 +++ 2

[PATCH v2 04/14] drm/msm/a6xx: Add missing regs for A7XX

2023-08-08 Thread Konrad Dybcio
Add some missing definitions required for A7 support. This may be substituted with a mesa header sync. Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Dmitry Baryshkov # sm8450 Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx.xml.h | 9 + drivers/gpu/drm/msm

[PATCH v2 02/14] dt-bindings: display/msm/gmu: Allow passing QMP handle

2023-08-08 Thread Konrad Dybcio
: Konrad Dybcio --- Documentation/devicetree/bindings/display/msm/gmu.yaml | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/gmu.yaml b/Documentation/devicetree/bindings/display/msm/gmu.yaml index 20ddb89a4500..e132dbff3c4a 100644 --- a

[PATCH v2 03/14] dt-bindings: display/msm/gpu: Allow A7xx SKUs

2023-08-08 Thread Konrad Dybcio
Allow A7xx SKUs, such as the A730 GPU found on SM8450 and friends. They use GMU for all things DVFS, just like most A6xx GPUs. Reviewed-by: Krzysztof Kozlowski Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Dmitry Baryshkov # sm8450 Signed-off-by: Konrad Dybcio --- Documentation

[PATCH v2 01/14] dt-bindings: display/msm/gmu: Add Adreno 7[34]0 GMU

2023-08-08 Thread Konrad Dybcio
U. Reviewed-by: Krzysztof Kozlowski Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Dmitry Baryshkov # sm8450 Signed-off-by: Konrad Dybcio --- .../devicetree/bindings/display/msm/gmu.yaml | 40 +- 1 file changed, 39 insertions(+), 1 deletion(-) diff --git a/Documenta

<    1   2   3   4   5   6   7   8   9   10   >