komeda_drv.c
> b/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
> index 3f4e719eebd8..28f76e07dd95 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
> @@ -6,6 +6,7 @@
> */
> #include
> #include
>
and add the debugfs files directly on hdlcd_drm_bind(),
> before drm_dev_register().
>
> Signed-off-by: Maíra Canal
Acked-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/arm/hdlcd_drv.c | 24 +---
> 1 file changed, 9 insertions(+), 15 deletion
Hi Jiasheng,
I appreciate the effort you have put into this and I find nothing wrong with the
intention of the patch. However, I don't intend to move base from being the
first
member of the malidp_mw_connector_state struct as it has other benefits in the
code
and we can use container_of() in imp
On Wed, Dec 07, 2022 at 01:59:04PM +, Robin Murphy wrote:
> On 2022-12-07 09:21, Jiasheng Jiang wrote:
> > As kzalloc may fail and return NULL pointer, it should be better to check
> > the return value in order to avoid the NULL pointer dereference in
> > __drm_atomic_helper_connector_reset.
>
ot;drm: mali-dp: Add writeback connector")
> Signed-off-by: Jiasheng Jiang
Thanks for catching this!
Acked-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/arm/malidp_mw.c | 6 +-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gp
On Wed, Oct 26, 2022 at 05:59:29PM +0200, Danilo Krummrich wrote:
> Hi,
Hi Danilo,
Sorry for the additional delay in reviewing and testing this series. I've now
managed
to get enough of both to be happy with the series.
For the whole series: Reviewed-by: Liviu Dudau
I will push th
gned-off-by: Gaosheng Cui
Acked-by: Liviu Dudau
Thanks for the fix!
Best regards,
Liviu
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_
ut it for now, but
> > hope that
> > this is something you'll keep in mind in the later series when you do
> > drm_dev_unplug().
>
> Yes, I'd expect this to be related to the missing protection of platform
> device bound resources.
>
> >
> >
u'll keep in mind in the later series when you do
drm_dev_unplug().
With that, for the whole series:
Acked-by: Liviu Dudau
Thanks for the patience and going through the series iterations with me.
I can pull this series into drm-misc-next on Monday if you don't have any other
plans.
Best
On Fri, Oct 14, 2022 at 02:07:09AM +0200, Danilo Krummrich wrote:
> Hi Liviu,
>
> On 10/12/22 17:07, Liviu Dudau wrote:
> > Hi Danilo,
> >
> > Appologies again for the delay in reviewing this as I was at XDC last week.
>
> No worries, thanks for following up.
&g
Hi Danilo,
Appologies again for the delay in reviewing this as I was at XDC last week.
This patch is causing a regression at 'rmmod' time as the drm_crtc_vblank_off()
does
not get called when we disable outputs and the HDLCD remains active as I keep
getting
unhandled context faults from the arm
On Wed, Sep 14, 2022 at 12:03:58AM +0200, Danilo Krummrich wrote:
> On 9/13/22 10:58, Liviu Dudau wrote:
> > On Mon, Sep 12, 2022 at 09:50:26PM +0200, Danilo Krummrich wrote:
> > > Hi Liviu,
> >
> > Hi Danilo,
> >
> > >
> > > Thanks for ha
On Mon, Sep 26, 2022 at 04:21:19PM +0100, Brian Starkey wrote:
> On Tue, Sep 13, 2022 at 04:36:57PM +0100, Liviu Dudau wrote:
> > On Tue, Sep 13, 2022 at 03:43:06PM +0100, Brian Starkey wrote:
> > > These formats are not subsampled, but that means hsub and vsub should
On Wed, Sep 14, 2022 at 12:03:58AM +0200, Danilo Krummrich wrote:
> On 9/13/22 10:58, Liviu Dudau wrote:
> > On Mon, Sep 12, 2022 at 09:50:26PM +0200, Danilo Krummrich wrote:
> > > Hi Liviu,
> >
> > Hi Danilo,
> >
> > >
> > > Thanks for ha
-by: butt3rflyh4ck
> Signed-off-by: Brian Starkey
Reviewed-by: Liviu Dudau
Should this be backported into stable releases? How far back to we go?
Best regards,
Liviu
> ---
> drivers/gpu/drm/drm_fourcc.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>
works without your
series. Can you explain
to me again what are you trying to fix?
Best regards,
Liviu
>
> - Danilo
>
>
>
> On 9/12/22 19:36, Liviu Dudau wrote:
> > Hi Danilo,
> >
> > I have applied your patch series for HDLCD on top of drm-next (com
Hi Danilo,
I have applied your patch series for HDLCD on top of drm-next (commit
213cb76ddc8b)
and on start up I get a warning:
[ 12.882554] hdlcd 7ff5.hdlcd: drm_WARN_ON(funcs && funcs->destroy)
[ 12.882596] WARNING: CPU: 1 PID: 211 at drivers/gpu/drm/drm_crtc.c:393
__drmm_crtc_init_wi
On Mon, Sep 05, 2022 at 05:19:02PM +0200, Danilo Krummrich wrote:
> Hi,
Hi Danilo,
>
> This patch series converts the driver to use drm managed resources to prevent
> potential use-after-free issues on driver unbind/rebind and to get rid of the
> usage of deprecated APIs.
Appologies for the ext
/drivers/gpu/drm/arm/malidp_planes.c
> @@ -13,7 +13,7 @@
> #include
> #include
> #include
> -#include
> +#include
> #include
> #include
> #include
> @@ -722,19 +722,19 @@ static void malidp_set_plane_base_addr(struct
> drm_framebuffer *fb,
aling to userspace.
Reported-by: Carsten Haitzler
Tested-by: Carsten Haitzler
Signed-off-by: Liviu Dudau
---
.../gpu/drm/arm/display/komeda/komeda_crtc.c | 4 ++--
.../gpu/drm/arm/display/komeda/komeda_kms.c | 21 ++-
.../gpu/drm/arm/display/komeda/komeda_kms.h | 2 ++
3
On Fri, Jul 08, 2022 at 07:03:37PM +0100, Carsten Haitzler wrote:
>
>
> On 7/8/22 17:02, Liviu Dudau wrote:
> > On Mon, Jun 06, 2022 at 12:47:14PM +0100, carsten.haitz...@foss.arm.com
> > wrote:
> > > From: Carsten Haitzler
> >
> > Hi Carsten,
> &g
FB that this patch is trying to fix, but I lack an
usable plaform for that. It will generate a flicker at module load time, but if
users
of Morello are happy with that, then
Acked-by: Liviu Dudau
Best regards,
Liviu
>
> Signed-off-by: Carsten Haitzler
> ---
> drivers/gpu/drm/arm
on a system for debug and general usability, so enable
> it. You can always toggle CONFIG_FRAMEBUFFER_CONSOLE.
>
> Signed-off-by: Carsten Haitzler
Reviewed-by: Liviu Dudau
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_drv.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>
a815e9eb56152f85454521079f10 Mon Sep 17 00:00:00 2001
From: Liviu Dudau
Date: Fri, 8 Jul 2022 16:39:21 +0100
Subject: [PATCH] drm/komeda: Fix handling of atomic commits in the
atomic_commit_tail hook
Komeda driver relies on the generic DRM atomic helper functions to handle
comm
27;re always
> clearing everything as well.
>
> Signed-off-by: Robin Murphy
Acked-by: Liviu Dudau
Thanks for the cleanup!
Best regards,
Liviu
> ---
> drivers/gpu/drm/arm/hdlcd_drv.c | 62 +
> 1 file changed, 16 insertions(+), 46 deletions(-)
now that probe time is not atomic and it can have some weird behaviour,
but I
was not expecting pixels to shift. Maybe it is because of clock reprogramming?
>
> Signed-off-by: Robin Murphy
Acked-by: Liviu Dudau
Will merge this into drm-misc-next if/when there are no more comments.
Best
On Wed, Jun 15, 2022 at 10:00:52AM +0200, Javier Martinez Canillas wrote:
> On 6/15/22 09:53, Thomas Zimmermann wrote:
> >
> >
> > Am 15.06.22 um 09:50 schrieb Javier Martinez Canillas:
> > [...]
> >>> Historically, most drivers call this function very early. But for error
> >>> recovery it would
On Fri, May 27, 2022 at 11:39:03AM +0800, 1064094...@qq.com wrote:
> From: pengfuyuan
>
> Fix spelling typo in comments.
>
> Reported-by: k2ci
> Signed-off-by: pengfuyuan
Acked-by: Liviu Dudau
I've got only patch 1 of 5, so I'm going to assume that you're g
ma")
> Link:
> https://lore.kernel.org/linux-arm-kernel/ynumgeilublhb...@e110455-lin.cambridge.arm.com/
> Signed-off-by: Andre Przywara
> Reported-by: Liviu Dudau
Reviewed-by: Liviu Dudau
Thanks for cleaning this up!
Best regards,
Liviu
> ---
> Documentation/devicetre
On Mon, May 09, 2022 at 02:49:01PM +0100, Andre Przywara wrote:
> On Fri, 06 May 2022 17:39:53 -0500
> Rob Herring wrote:
>
> > On Fri, 06 May 2022 15:05:32 +0100, Andre Przywara wrote:
> > > The Arm Mali Display Processor (DP) 5xx/6xx is a series of IP that scans
> > > out a framebuffer and hand
On Thu, Apr 28, 2022 at 12:57:52PM +0100, Steven Price wrote:
> On 03/12/2021 13:08, Liviu Dudau wrote:
> > On Fri, Dec 03, 2021 at 10:28:15AM +, Steven Price wrote:
> >> While the check for format_count > 64 in __drm_universal_plane_init()
> >> shouldn
On Tue, Apr 26, 2022 at 08:16:39PM +0800, pengfuyuan wrote:
> Fix spelling typo in comment.
>
> Signed-off-by: pengfuyuan
Acked-by: Liviu Dudau
Many thanks for fixing this!
Best regards,
Liviu
> ---
> drivers/gpu/drm/arm/malidp_regs.h | 2 +-
> 1 file changed, 1 insert
On Tue, Apr 26, 2022 at 05:51:06PM +0800, pengfuyuan wrote:
> Fix spelling typo in comment.
>
> Signed-off-by: pengfuyuan
> ---
> drivers/gpu/drm/arm/malidp_regs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/arm/malidp_regs.h
> b/drivers/gpu/drm/arm
On Tue, Apr 19, 2022 at 06:45:56PM -0700, Abhinav Kumar wrote:
> Add writeback blocks to the sm8250 DPU hardware catalog. Other
> chipsets support writeback too but add it to sm8250 to prototype
> the feature so that it can be easily extended to other chipsets.
>
> changes in v2:
> - none
>
Hi Abhinav,
Sorry for the delay in reviewing this, Easter break happened in between.
On Fri, Apr 08, 2022 at 05:53:54PM -0700, Abhinav Kumar wrote:
> For some vendor driver implementations, display hardware can
> be shared between the encoder used for writeback and the physical
> display.
>
> In
On Sun, Apr 17, 2022 at 01:29:18PM +, Xuezhi Zhang wrote:
> Fix the following coccicheck warning:
> drivers/gpu/drm/arm/malidp_drv.c:658:8-16:
> WARNING: use scnprintf or sprintf
>
> Signed-off-by: Xuezhi Zhang
Acked-by: Liviu Dudau
Thanks for this!
Best regards,
Liviu
&
On Wed, Apr 06, 2022 at 10:27:00AM +0100, Brian Starkey wrote:
> Hi Robin,
>
> On Tue, Apr 05, 2022 at 03:11:18PM +0100, Robin Murphy wrote:
> > iommu_get_domain_for_dev() is already perfectly happy to return NULL
> > if the given device has no IOMMU. Drop the unnecessary check.
> >
> > Signed-of
ack_connector's encoder has
> already been
> + * created and initialized before invoking this function.
> + *
> + * In addition, this function also assumes that callers of this API will
> manage
> + * assigning the encoder helper functions, possible_crtcs and any othe
On Fri, Mar 25, 2022 at 09:31:35AM -0700, Abhinav Kumar wrote:
> Hi Liviu
Hi Abhinav,
Sorry for the delay, got busy with other things at the beginning of the week.
>
> On 3/25/2022 3:19 AM, Liviu Dudau wrote:
> > On Thu, Mar 24, 2022 at 09:36:50AM -0700, Abhinav Kumar wrote:
On Thu, Mar 24, 2022 at 09:36:50AM -0700, Abhinav Kumar wrote:
> Hi Liviu
Hello,
>
> Thanks for the response.
>
> On 3/24/2022 3:12 AM, Liviu Dudau wrote:
> > On Wed, Mar 23, 2022 at 11:28:56AM -0700, Abhinav Kumar wrote:
> > > Hi Liviu
> >
> > Hell
On Wed, Mar 23, 2022 at 11:28:56AM -0700, Abhinav Kumar wrote:
> Hi Liviu
Hello,
>
> Thanks for the review.
>
> On 3/23/2022 9:46 AM, Liviu Dudau wrote:
> > On Mon, Mar 21, 2022 at 04:56:43PM -0700, Abhinav Kumar wrote:
> > > For vendors drivers which
On Mon, Mar 21, 2022 at 04:56:43PM -0700, Abhinav Kumar wrote:
> For vendors drivers which pass an already allocated and
> initialized encoder especially for cases where the encoder
> hardware is shared OR the writeback encoder shares the resources
> with the rest of the display pipeline introduce
On Thu, Mar 17, 2022 at 10:26:38AM -0700, Abhinav Kumar wrote:
> Hi Laurent
>
> Thanks for the review.
>
> On 3/17/2022 1:51 AM, Laurent Pinchart wrote:
> > Hi Abhinav,
> >
> > Thank you for the patch.
> >
> > On Wed, Mar 16, 2022 at 11:48:16AM -0700, Abhinav Kumar wrote:
> > > For some vendor
On Thu, Mar 17, 2022 at 06:45:34PM -0700, Abhinav Kumar wrote:
> For some vendor driver implementations, display hardware can
> be shared between the encoder used for writeback and the physical
> display.
>
> In addition resources such as clocks and interrupts can
> also be shared between writebac
const u32 *formats, int n_formats, uint32_t
> possible_crtcs)
> {
> struct drm_property_blob *blob;
> struct drm_connector *connector = &wb_connector->base;
> @@ -190,6 +191,9 @@ int drm_writeback_connector_init(struct drm_device *dev,
> return PTR_ERR(blob);
> Cc: "James (Qian) Wang"
> Cc: Liviu Dudau
> Cc: Mihail Atanassov
> Signed-off-by: Maxime Ripard
Acked-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_plane.c | 6 +-
> 1 file changed, 1 insertion(+), 5 deletions(-)
&
tate, the driver had
> to set it again in komeda_plane_reset(). However, the helpers have been
> adjusted to set it properly at reset, so this is not needed anymore.
>
> Cc: Brian Starkey
> Cc: "James (Qian) Wang"
> Cc: Liviu Dudau
> Cc: Mihail Atanassov
> Signe
n komeda_plane_reset(). However, the helpers have been
> adjusted to set it properly at reset, so this is not needed anymore.
>
> Cc: Brian Starkey
> Cc: "James (Qian) Wang"
> Cc: Liviu Dudau
> Cc: Mihail Atanassov
> Signed-off-by: Maxime Ripard
Acked-by: Liviu Dudau
> Signed-off-by: Carsten Haitzler
Acked-by: Liviu Dudau
I will add Steven's reviewed-by as well when pushing it.
Best regards,
Liviu
> ---
> drivers/gpu/drm/arm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/d
Hi Jiasheng,
On Tue, Dec 14, 2021 at 08:51:10PM +0800, Jiasheng Jiang wrote:
> The return value of kzalloc() needs to be checked.
> To avoid use of null pointer '&state->base' in case of the
> failure of alloc.
>
> Fixes: 99665d072183 ("drm: mali-dp: add malidp_crtc_state struct")
> Signed-off-by
; drm_mode_object_unregister() leaking the modeset identifier. Move it to
> the start of the function to avoid allocating those resources in the
> first place.
>
> Signed-off-by: Steven Price
Well spotted!
Reviewed-by: Liviu Dudau
I'm going to wait to see if anyone else has any c
: Liviu Dudau
---
drivers/gpu/drm/arm/display/komeda/komeda_plane.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
index aa193c58f4bf6d9..517b94c3bcaf966 100644
--- a
On Wed, Dec 01, 2021 at 03:44:03PM +, Steven Price wrote:
> On 30/11/2021 14:25, Zhou Qingyang wrote:
> > In komeda_plane_add(), komeda_get_layer_fourcc_list() is assigned to
> > formats and used in drm_universal_plane_init().
> > drm_universal_plane_init() passes formats to
> > __drm_universal
ch komeda_dev to DRM-KMS")
> Signed-off-by: Zhou Qingyang
Thanks for the fix!
Reviewed-by: Liviu Dudau
Best regards,
Liviu
> ---
> Changes in v2
> - Use kfree and return instead of using 'goto'
>
> drivers/gpu/drm/arm/display/komeda/komeda_plane.c | 4
Hi Zhou,
On Tue, Nov 30, 2021 at 10:23:01PM +0800, Zhou Qingyang wrote:
> In komeda_plane_add(), komeda_get_layer_fourcc_list() is assigned to
> formats and used in drm_universal_plane_init().
> drm_universal_plane_init() passes formats to
> __drm_universal_plane_init(). __drm_universal_plane_init
On Tue, Aug 31, 2021 at 03:43:19PM +0800, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
>
> Signed-off-by: Cai Huoqing
Acked-by: Liviu Dudau
Many thanks,
Liviu
>
gt; Signed-off-by: Thomas Zimmermann
> Acked-by: Sam Ravnborg
Sorry for the delayed response due to holidays.
Acked-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/arm/hdlcd_drv.c | 174 ++--
> drivers/gpu/drm/arm/hdlcd_drv.h | 1 +
> 2 f
#x27;s modes list.
> It is not expected by mode_valid.
>
> Replace mode->crtc_clock with mode->clock to fix the issue.
>
> Signed-off-by: Sandor Yu
It looks like at least drm/bridge/cdns-dsi.c does the same thing of using
mode->clock when validating, so looks like a legi
On Thu, Jul 01, 2021 at 06:07:09PM +0100, Normunds Rieksts wrote:
> Arm Fixed Rate Compression (AFRC) is a proprietary fixed rate image
> compression protocol and format.
> It is designed to provide guaranteed bandwidth and memory footprint
> reductions in graphics and media use-cases.
>
> This pa
0 but
scaled up in an irregular way. Reverting the commit or applying this
patch fixes the problem on v5.14-rc1.
Fixes: 72a7cf0aec0c ("drm/amd/display: Keep linebuffer pixel depth at 30bpp for
DCE-11.0.")
Signed-off-by: Liviu Dudau
---
drivers/gpu/drm/amd/display/dc/core/dc_resource.c
s.
>
> This patch aims to add modifier definitions for describing
> AFRC.
>
> Signed-off-by: Normunds Rieksts
Looks good to me!
Reviewed-by: Liviu Dudau
Best regards,
Liviu
> ---
> include/uapi/drm/drm_fourcc.h | 109 +-
> 1 file cha
#include
> #include
> #include
> -#include
> #include
> #include
> #include
> --
> 2.32.0
>
Acked-by: Liviu Dudau
Best regards,
Liviu
--
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---
¯\_(ツ)_/¯
R_LEGACY)))
> > >
> > > return dev->irq_enabled;
> > >
> > > #endif
> > > return drm_dev_has_vblank(dev);
> > >
> > > }
> > >
> > >
> > > ?
> > >
> &g
Hi Thomas,
On Wed, Jun 23, 2021 at 08:43:07AM +0200, Thomas Zimmermann wrote:
> Hi Liviu
>
> Am 22.06.21 um 17:25 schrieb Liviu Dudau:
> > Hello,
> >
> > On Tue, Jun 22, 2021 at 04:09:44PM +0200, Thomas Zimmermann wrote:
> > > For KMS drivers, replace the IRQ
On Tue, Jun 22, 2021 at 04:09:46PM +0200, Thomas Zimmermann wrote:
> The field drm_device.irq_enabled is only used by legacy drivers
> with userspace modesetting. Don't set it in malidp.
>
> Signed-off-by: Thomas Zimmermann
Acked-by: Liviu Dudau
Best regards,
Liviu
> --
On Tue, Jun 22, 2021 at 04:09:45PM +0200, Thomas Zimmermann wrote:
> The field drm_device.irq_enabled is only used by legacy drivers
> with userspace modesetting. Don't set it in komeda.
>
> Signed-off-by: Thomas Zimmermann
Acked-by: Liviu Dudau
Best regards,
Liviu
> --
Hello,
On Tue, Jun 22, 2021 at 04:09:44PM +0200, Thomas Zimmermann wrote:
> For KMS drivers, replace the IRQ check in VBLANK ioctls with a check for
> vblank support. IRQs might be enabled wthout vblanking being supported.
>
> This change also removes the DRM framework's only dependency on IRQ st
On Mon, Jun 14, 2021 at 05:49:12PM +0300, Pekka Paalanen wrote:
> On Fri, 11 Jun 2021 13:03:09 +0100
> Liviu Dudau wrote:
>
> > On Fri, Jun 11, 2021 at 08:14:59AM +, Simon Ser wrote:
> > > On Thursday, June 10th, 2021 at 23:00, Daniel Vetter
> > > wro
On Fri, Jun 11, 2021 at 08:56:04AM -0400, Alyssa Rosenzweig wrote:
> > What I'm expected to see in the future is new functionality that gets
> > implemented by
> > one hardware vendor and the kernel developers trying to enable that for
> > userspace. It
> > could be that the new property is gener
On Fri, Jun 11, 2021 at 08:14:59AM +, Simon Ser wrote:
> On Thursday, June 10th, 2021 at 23:00, Daniel Vetter
> wrote:
>
> > If there's a strong consensus that we really need this then I'm not
> > going to nack this, but this really needs a pile of acks from
> > compositor folks that they're
> Cc: Jonathan Hunter
> Cc: Joonas Lahtinen
> Cc: Joonyoung Shim
> Cc: Jyri Sarha
> Cc: Kevin Hilman
> Cc: Kieran Bingham
> Cc: Krzysztof Kozlowski
> Cc: Kyungmin Park
> Cc: Laurent Pinchart
> Cc: Linus Walleij
> Cc: Liviu Dudau
> Cc: Lucas Stach
>
Cc: Hans de Goede
> > > Cc: "Heiko Stübner"
> > > Cc: Huang Rui
> > > Cc: Hyun Kwon
> > > Cc: Inki Dae
> > > Cc: Jani Nikula
> > > Cc: Jernej Skrabec
> > > Cc: Jerome Brunet
> > > Cc: Joel Stanley
> > >
ducts.
> To
> +of course we'd better share as much as possible between different products.
> To
> achieve this, split the komeda device into two layers: CORE and CHIP.
>
> - CORE: for common features and capabilities handling.
Acked-by: Liviu D
On Tue, Apr 27, 2021 at 11:20:12AM +0200, Daniel Vetter wrote:
> Even when all we support is linear, make that explicit. Otherwise the
> uapi is rather confusing.
:)
>
> Cc: sta...@vger.kernel.org
> Cc: Pekka Paalanen
> Cc: Liviu Dudau
> Cc: Brian Starkey
> Sign
nit
>
> this is done automatically as part of plane init, if drivers set the
> modifier list correctly. Which is the case here for both komeda and
> malidp.
>
> Signed-off-by: Daniel Vetter
> Cc: "James (Qian) Wang"
> Cc: Liviu Dudau
Acked-by: Liviu Dudau
Best rega
N already flags this as out-of-bounds
> stack reads. This fixes it by just importing inot a local long.
>
> Signed-off-by: Carsten Haitzler
Acked-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_pipeline.c | 3 ++-
> 1 file changed, 2 inser
inter tocompare memory content there
> agains the new sate to see if it changed. In this case, it's better to
s/sate/state/
> assume that the input changed as there is no old state to compare
> against and thus assume the changes happen anyway.
>
> Signed-off-by: Carsten Haitz
n Haitzler
Acked-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
>
}
>
> @ adds_new_state @
> identifier crtc_atomic_func.func;
> identifier crtc, state;
> @@
>
> func(struct drm_crtc *crtc, struct drm_atomic_state *state) {
> + struct drm_crtc_state *crtc_state = drm_atomic_get_new_crtc_state(state,
> crtc);
> ...
> - crtc->state
> + crtc_sta
aniel Vetter
> Cc: "James (Qian) Wang"
> Cc: Liviu Dudau
Acked-by: Liviu Dudau
Thanks for the patch!
Best regards,
Liviu
> Cc: Mihail Atanassov
> ---
> drivers/gpu/drm/arm/malidp_drv.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gp
= seq_read,
> - .llseek = seq_lseek,
> - .release= single_release,
> -};
> +DEFINE_SHOW_ATTRIBUTE(komeda_register);
Hi Qinglang,
Sorry for the belated response!
Acked-by: Liviu Dudau
Best regards,
Liviu
>
> #ifdef CONFIG_DEBUG_FS
> static void komeda_debugf
se.state;
> + struct vkms_crtc_state *crtc_state = output->composer_state;
> +
> + if (!conn_state)
> + return;
> +
> + vkms_set_composer(&vkmsdev->output, true);
> +
> + spin_lock_irq(&output->composer_lock);
> + crtc_state->active_writeback = conn_state->writeback_job-&
um 15:12 schrieb Daniel Vetter:
> > >>>>>>> On Fri, Aug 07, 2020 at 01:10:22PM +0200, Thomas Zimmermann wrote:
> > >>>>>>>> The malidp driver uses GEM object functions for callbacks. Fix it
> > >>>>>>>> to
> &
o a testing for this patch but when I dug out the
series
from the ML it looked like it has extra dependencies, so I was waiting for the
dust
to settle.
Otherwise, LGTM.
Best regards,
Liviu
>
> Signed-off-by: Daniel Vetter
> Cc: "James (Qian) Wang"
> Cc: Liviu Dudau
&g
On Thu, Jun 18, 2020 at 01:50:34PM +0100, Colin Ian King wrote:
> On 18/06/2020 13:14, Liviu Dudau wrote:
> > On Thu, Jun 18, 2020 at 11:04:00AM +0100, Colin King wrote:
> >> From: Colin Ian King
> >
> > Hi Colin,
> >
> >>
> >> Shifting th
On Thu, Jun 18, 2020 at 11:04:00AM +0100, Colin King wrote:
> From: Colin Ian King
Hi Colin,
>
> Shifting the integer value 1 is evaluated using 32-bit arithmetic
> and then used in an expression that expects a long value leads to
> a potential integer overflow.
I'm afraid this explanation mak
down reordered.
Got confused by the subject not having any version of the patch, so I've
acked the other one, but this is the one I've meant to Ack.
So, Acked-by: Liviu Dudau
Best regards,
Liviu
>
> Signed-off-by: Daniel Vetter
> Cc: Liviu Dudau
> Cc: Brian Starkey
>
rtc, so need to reorder that.
>
> Signed-off-by: Daniel Vetter
> Cc: Liviu Dudau
Acked-by: Liviu Dudau
Best regards,
Liviu
> Cc: Brian Starkey
> Cc:
> ---
> drivers/gpu/drm/arm/hdlcd_drv.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/
e
and I was hitting warnings from 84014b0a39eef6df ("drm/atomic-helper: check that
drivers call drm_crtc_vblank_off"), but I'm happy that things have now been
fixed.
> Signed-off-by: Daniel Vetter
> Cc: Liviu Dudau
Acked-by: Liviu Dudau
Best regards,
Liviu
> Cc: Brian
Hi Emil,
On Wed, May 20, 2020 at 12:54:17AM +0100, Emil Velikov wrote:
> On Mon, 18 May 2020 at 12:10, Liviu Dudau wrote:
> >
> > On Sun, May 17, 2020 at 08:36:53PM +0100, Emil Velikov wrote:
> > > Add the COMPILE_TEST conditional, so that people can at least buil
ot.com/bug?id=0ba17d70d062b2595e1f061231474800f076c7cb
> Reported-by: Tetsuo Handa
> Reported-by: syzbot+0871b14ca2e2fb64f...@syzkaller.appspotmail.com
> Cc: Tetsuo Handa
> Cc: "James (Qian) Wang"
> Cc: Liviu Dudau
> Cc: Mihail Atanassov
> Cc: Brian Starkey
> Cc:
On Wed, May 27, 2020 at 01:07:05PM +0200, Daniel Vetter wrote:
> On Wed, May 27, 2020 at 12:57 PM Liviu Dudau wrote:
> >
> > Hi Daniel,
> >
> > On Wed, May 27, 2020 at 11:53:32AM +0200, Daniel Vetter wrote:
> > > Only when vblanks are supported ofc.
> >
ink:
> https://syzkaller.appspot.com/bug?id=0ba17d70d062b2595e1f061231474800f076c7cb
> Reported-by: Tetsuo Handa
> Reported-by: syzbot+0871b14ca2e2fb64f...@syzkaller.appspotmail.com
> Cc: Tetsuo Handa
> Cc: "James (Qian) Wang"
> Cc: Liviu Dudau
> Cc: Mihail Atanassov
> Cc: Brian Star
remaining
> operations are provided by CMA GEM object functions.
>
> Signed-off-by: Thomas Zimmermann
Acked-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/arm/malidp_drv.c | 11 +--
> 1 file changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/driv
remaining
> operations are provided by CMA GEM object functions.
>
> Signed-off-by: Thomas Zimmermann
Acked-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_kms.c | 11 +--
> 1 file changed, 1 insertion(+), 10 deletions(-)
>
>
t;
> Signed-off-by: Thomas Zimmermann
Acked-by: Liviu Dudau
Thanks!
Liviu
> ---
> drivers/gpu/drm/arm/hdlcd_drv.c | 12 +---
> 1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/arm/hdlcd_drv.c b/drivers/gpu/drm/arm/hdlcd_drv.c
> i
On Sun, May 17, 2020 at 08:36:53PM +0100, Emil Velikov wrote:
> Add the COMPILE_TEST conditional, so that people can at least build test
> the drivers.
>
> Cc: Liviu Dudau
Acked-by: Liviu Dudau
> Cc: Brian Starkey
> Cc: Mali DP Maintainers
> Cc: dri-devel@lists.freedes
Hi Bernard,
On Fri, May 08, 2020 at 04:47:17PM +0800, Bernard wrote:
> From: "赵军奎"
> Date: 2020-04-24 19:37:36
> To: Liviu Dudau
> Cc: Brian Starkey ,David Airlie
> ,Daniel Vetter
> ,dri-devel@lists.freedesktop.org,linux-ker...@vger.kernel.org,opensource.ker.
;
> Just drop the suffix. It makes the API cleaner.
>
> Done via the following script:
>
> __from=drm_gem_object_put_unlocked
> __to=drm_gem_object_put
> for __file in $(git grep --name-only $__from); do
> sed -i "s/$__from/$__to/g" $__file;
> done
>
On Thu, Apr 30, 2020 at 09:32:20AM +0100, Ben Davis wrote:
> AFBC has a mode that guarantees use of AFBC with an uncompressed
> payloads, we add a new modifier to support this mode.
>
> V2: updated modifier comment
>
> Signed-off-by: Ben Davis
Acked-by: Liviu Dudau
B
101 - 200 of 985 matches
Mail list logo
