and demarchi for help with the move!
and thank you for preparing all the patches to the different repos.
Lucas De Marchi
Ryszard
De Marchi
On Fri, 17 May 2024 13:43:02 -0700, Lucas De Marchi wrote:
> v5 of of
> https://lore.kernel.org/all/20240515214258.59209-1-lucas.demar...@intel.com
>
> Add per-client usage statistics to xe. This ports xe to use the common
> method in drm to export the usage to userspace per
On Tue, May 21, 2024 at 02:53:56AM GMT, Matthew Brost wrote:
On Sat, May 18, 2024 at 09:37:20AM -0500, Lucas De Marchi wrote:
On Fri, May 17, 2024 at 03:40:22PM GMT, Matt Roper wrote:
> On Fri, May 17, 2024 at 01:43:07PM -0700, Lucas De Marchi wrote:
> > From: Umesh Nerlige Ramappa
&g
On Fri, May 17, 2024 at 03:40:22PM GMT, Matt Roper wrote:
On Fri, May 17, 2024 at 01:43:07PM -0700, Lucas De Marchi wrote:
From: Umesh Nerlige Ramappa
Add a helper to accumulate per-client runtime of all its
exec queues. This is called every time a sched job is finished.
v2:
- Use
nes in the gt and update that when it's needed. This
will help implementing per client engine utilization so this (mostly
constant) information doesn't need to be re-calculated on every query.
Reviewed-by: Jonathan Cavitt
Reviewed-by: Umesh Nerlige Ramappa
Signed-off-by: Lucas De Marchi
---
drivers/
Just like CTX_TIMESTAMP is used to calculate runtime, add a helper to
get the timestamp for the engine so it can be used to calculate the
"engine time" with the same unit as the runtime is recorded.
Reviewed-by: Umesh Nerlige Ramappa
Signed-off-by: Lucas De Marchi
---
drivers/
Get the first available engine from a gt, which helps in the case any
engine serves as a context, like when reading RING_TIMESTAMP.
Reviewed-by: Umesh Nerlige Ramappa
Signed-off-by: Lucas De Marchi
---
drivers/gpu/drm/xe/xe_gt.c | 11 +++
drivers/gpu/drm/xe/xe_gt.h | 7 +++
2
the first sample should be a valid
one.
- Handle the parallel submission case by multiplying the runtime by
width.
v3: Update comments
Signed-off-by: Umesh Nerlige Ramappa
Signed-off-by: Lucas De Marchi
---
drivers/gpu/drm/xe/xe_device_types.h | 3 +++
drivers/gpu/drm/xe/xe_exec_queue.c
From: Umesh Nerlige Ramappa
Add a helper to capture CTX_TIMESTAMP from the context image so it can
be used to calculate the runtime.
v2: Add kernel-doc to clarify expectation from caller
Signed-off-by: Umesh Nerlige Ramappa
Reviewed-by: Francois Dugast
Signed-off-by: Lucas De Marchi
-off-by: Lucas De Marchi
---
drivers/gpu/drm/xe/xe_hw_engine.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_hw_engine.c
b/drivers/gpu/drm/xe/xe_hw_engine.c
index b71e90c555fa..942fca8f1eb9 100644
--- a/drivers/gpu/drm/xe/xe_hw_engine.c
+++ b
Move it out of the sysfs compilation unit so it can be re-used in other
places.
Reviewed-by: Nirmoy Das
Reviewed-by: Oak Zeng
Signed-off-by: Lucas De Marchi
---
drivers/gpu/drm/xe/xe_hw_engine.c | 18 ++
drivers/gpu/drm/xe/xe_hw_engine.h | 2
gt. This also moves the read of the gpu timestamp out
of the loop as suggested by Tvrtko and using the helpers implemented
in the new patches.
v5:
- Fix kernel-doc
- Move pm_runtime_put() earlier in the function as it's not needed
anymore after interacting with the HW.
Lucas De Marchi (6
faulting to 1 sample
per minute or more.
Reviewed-by: Umesh Nerlige Ramappa
Acked-by: Tvrtko Ursulin
Signed-off-by: Lucas De Marchi
---
Documentation/gpu/drm-usage-stats.rst | 21 +++-
Documentation/gpu/xe/index.rst | 1 +
Documentation/gpu/xe/xe-drm-usage-stats.rst | 10 ++
On Thu, May 16, 2024 at 11:33:54AM GMT, Umesh Nerlige Ramappa wrote:
On Wed, May 15, 2024 at 02:42:56PM -0700, Lucas De Marchi wrote:
gt->info.engine_mask used to indicate the available engines, but that
is not always true anymore: some engines are reserved to kernel and some
may be expo
On Wed, May 15, 2024 at 07:22:22PM GMT, Oded Gabbay wrote:
Because I left Intel, I'm removing myself from the list
of Xe driver maintainers.
Signed-off-by: Oded Gabbay
Acked-by: Lucas De Marchi
thanks
Lucas De Marchi
---
MAINTAINERS | 1 -
1 file changed, 1 deletion(-)
diff --git
On Thu, May 16, 2024 at 08:57:48AM GMT, Tvrtko Ursulin wrote:
On 15/05/2024 22:42, Lucas De Marchi wrote:
Print the accumulated runtime for client when printing fdinfo.
Each time a query is done it first does 2 things:
1) loop through all the exec queues for the current client
Get the first available engine from a gt, which helps in the case any
engine serves as a context, like when reading RING_TIMESTAMP.
Signed-off-by: Lucas De Marchi
---
drivers/gpu/drm/xe/xe_gt.c | 11 +++
drivers/gpu/drm/xe/xe_gt.h | 7 +++
2 files changed, 18 insertions(+)
diff
Just like CTX_TIMESTAMP is used to calculate runtime, add a helper to
get the timestamp for the engine so it can be used to calculate the
"engine time" with the same unit as the runtime is recorded.
Reviewed-by: Umesh Nerlige Ramappa
Signed-off-by: Lucas De Marchi
---
drivers/
faulting to 1 sample
per minute or more.
Signed-off-by: Lucas De Marchi
---
Documentation/gpu/drm-usage-stats.rst | 21 +++-
Documentation/gpu/xe/index.rst | 1 +
Documentation/gpu/xe/xe-drm-usage-stats.rst | 10 ++
drivers/gpu/drm/xe/xe_drm_client.c | 121 +
nes in the gt and update that when it's needed. This
will help implementing per client engine utilization so this (mostly
constant) information doesn't need to be re-calculated on every query.
Signed-off-by: Lucas De Marchi
---
drivers/gpu/drm/xe/xe_gt.c | 23 +++
drivers/
From: Umesh Nerlige Ramappa
Add a helper to capture CTX_TIMESTAMP from the context image so it can
be used to calculate the runtime.
v2: Add kernel-doc to clarify expectation from caller
Signed-off-by: Umesh Nerlige Ramappa
Signed-off-by: Lucas De Marchi
---
drivers/gpu/drm/xe/regs
Move it out of the sysfs compilation unit so it can be re-used in other
places.
Reviewed-by: Nirmoy Das
Reviewed-by: Oak Zeng
Signed-off-by: Lucas De Marchi
---
drivers/gpu/drm/xe/xe_hw_engine.c | 18 ++
drivers/gpu/drm/xe/xe_hw_engine.h | 2
the first sample should be a valid
one.
- Handle the parallel submission case by multiplying the runtime by
width.
v3: Update comments
Signed-off-by: Umesh Nerlige Ramappa
Signed-off-by: Lucas De Marchi
---
drivers/gpu/drm/xe/xe_device_types.h | 3 +++
drivers/gpu/drm/xe/xe_exec_queue.c
-off-by: Lucas De Marchi
---
drivers/gpu/drm/xe/xe_hw_engine.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_hw_engine.c
b/drivers/gpu/drm/xe/xe_hw_engine.c
index 520db5d518c3..f76bb507e1a5 100644
--- a/drivers/gpu/drm/xe/xe_hw_engine.c
+++ b
also moves the read of the gpu timestamp out
of the loop as suggested by Tvrtko and using the helpers implemented
in the new patches.
Lucas De Marchi (6):
drm/xe: Promote xe_hw_engine_class_to_str()
drm/xe: Add XE_ENGINE_CLASS_OTHER to str conversion
drm/xe: Add helper to capture en
Hi Dave and Sima,
Please pull the drm-xe-fixes for this week targeting v6.9.
thanks
Lucas De Marchi
drm-xe-fixes-2024-05-09:
- Fix use zero-length element array
- Move more from system wq to ordered private wq
- Do not ignore return for drmm_mutex_init
The following changes since commit
ences is 0, calling drm_exec_lock_obj()
is sufficient as was done in commit 9377de4cb3e8 ("drm/xe/vm: Avoid
reserving zero fences")
Cc: Nirmoy Das
Cc: Matthew Brost
Signed-off-by: Shuicheng Lin
with the reword,
Reviewed-by: Lucas De Marchi
And also add:
Link: htt
On Wed, May 08, 2024 at 09:23:17AM GMT, Tvrtko Ursulin wrote:
On 07/05/2024 22:35, Lucas De Marchi wrote:
On Fri, Apr 26, 2024 at 11:47:37AM GMT, Tvrtko Ursulin wrote:
On 24/04/2024 00:56, Lucas De Marchi wrote:
Print the accumulated runtime for client when printing fdinfo.
Each time
On Wed, May 08, 2024 at 09:34:59AM GMT, Tvrtko Ursulin wrote:
On 07/05/2024 23:45, Lucas De Marchi wrote:
From: Umesh Nerlige Ramappa
Add a helper to accumulate per-client runtime of all its
exec queues. This is called every time a sched job is finished.
v2:
- Use guc_exec_queue_free_job
On Tue, May 07, 2024 at 04:45:36PM GMT, Umesh Nerlige Ramappa wrote:
On Tue, May 07, 2024 at 03:45:09PM -0700, Lucas De Marchi wrote:
From: Umesh Nerlige Ramappa
Add a helper to accumulate per-client runtime of all its
exec queues. This is called every time a sched job is finished.
v2:
- Use
kqueue to accumulate the counters
every so often, but it's additional complexity for something that is
done already by userspace every few seconds in tools like gputop (from
igt), htop, nvtop, etc with none of them really defaulting to 1 sample
per minute or more.
Signed-off-by: Lucas De Marchi
---
D
From: Umesh Nerlige Ramappa
Add a helper to capture CTX_TIMESTAMP from the context image so it can
be used to calculate the runtime.
v2: Add kernel-doc to clarify expectation from caller
Signed-off-by: Umesh Nerlige Ramappa
Signed-off-by: Lucas De Marchi
---
drivers/gpu/drm/xe/regs
and clarify usage of
xe_lrc_update_timestamp()
v3:
- Fix bugs in "drm/xe: Add helper to accumulate exec queue runtime" -
see commit message
- Reorder commits so the ones that are useful in other patch series
come first
Lucas De Marchi (4):
drm/xe: Promote xe_hw_engine_cl
Just like CTX_TIMESTAMP is used to calculate runtime, add a helper to
get the timestamp for the engine so it can be used to calculate the
"engine time" with the same unit as the runtime is recorded.
Reviewed-by: Umesh Nerlige Ramappa
Signed-off-by: Lucas De Marchi
---
drivers/
Move it out of the sysfs compilation unit so it can be re-used in other
places.
Reviewed-by: Nirmoy Das
Reviewed-by: Oak Zeng
Signed-off-by: Lucas De Marchi
---
drivers/gpu/drm/xe/xe_hw_engine.c | 18 ++
drivers/gpu/drm/xe/xe_hw_engine.h | 2
the first sample should be a valid
one.
- Handle the parallel submission case by multiplying the runtime by
width.
Signed-off-by: Umesh Nerlige Ramappa
Signed-off-by: Lucas De Marchi
---
drivers/gpu/drm/xe/xe_device_types.h | 9 +++
drivers/gpu/drm/xe/xe_exec_queue.c | 35
-off-by: Lucas De Marchi
---
drivers/gpu/drm/xe/xe_hw_engine.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_hw_engine.c
b/drivers/gpu/drm/xe/xe_hw_engine.c
index 85712650be22..de30b74bf253 100644
--- a/drivers/gpu/drm/xe/xe_hw_engine.c
+++ b
On Fri, Apr 26, 2024 at 11:47:37AM GMT, Tvrtko Ursulin wrote:
On 24/04/2024 00:56, Lucas De Marchi wrote:
Print the accumulated runtime for client when printing fdinfo.
Each time a query is done it first does 2 things:
1) loop through all the exec queues for the current client
um_fences) {
| + ret = dma_resv_reserve_fences(obj->resv, num_fences);
| + if (ret) {
| + drm_exec_unlock_obj(exec, obj);
| + return ret;
| + }
| }
|
| return 0;
thanks
Lucas De Marchi
Nirmoy
Regards,
Nirmoy
Hi Dave and Sima,
Please pull the drm-xe-fixes for this week targeting v6.9-rc7.
Two important fixes: one avoiding a use-after-free in the rebind worker
and the other to make display work in ADL-N.
thanks
Lucas De Marchi
drm-xe-fixes-2024-05-02:
- Fix UAF on rebind worker
- Fix ADL-N display
On Wed, May 01, 2024 at 09:25:01AM GMT, Rob Clark wrote:
On Wed, May 1, 2024 at 9:19 AM Lucas De Marchi wrote:
On Wed, May 01, 2024 at 04:58:05PM GMT, Tvrtko Ursulin wrote:
>
>Hi,
>
>On 24/04/2024 15:48, Adrián Larumbe wrote:
>>Hi Tvrtko,
>>
>>On 15.04.20
with a drm fd), we are
leaking that info. So we should probably make this
DEVICE_ATTR_ADMIN_RO.
Lucas De Marchi
Shouldn't BIN_ATTR_RO be used for binary files in sysfs?
Like I said above, I sort of faked a binary attribute through the regular sysfs
attr API,
which is most likely a bad idea
default:
+ break;
since reg->type is an enum and we are handling all the values, another
possible approach is to remove the default handling and then the
compiler will warn you of missing cases if built with -Wswitch.
Any of the approaches seem good to me.
Reviewed-by: Lucas De M
On Fri, Apr 26, 2024 at 06:08:19PM GMT, Danilo Krummrich wrote:
On 4/25/24 18:38, Timur Tabi wrote:
On Thu, 2024-04-25 at 15:22 +0200, Danilo Krummrich wrote:
+ size_t length;
+
+ /* Remove any whitespace from the parameter string */
+ length =
age certainly missed that. Please Cc dri-devel on changes outside xe
and provide the motivation in the commit message.
thanks
Lucas De Marchi
BR,
Jani.
Signed-off-by: Farah Kassabri
---
drivers/gpu/drm/drm_drv.c | 6 +++---
include/drm/drm_drv.h | 2 ++
2 files changed, 5 insertions(+)
On Wed, Apr 24, 2024 at 01:41:59PM GMT, Ryszard Knop wrote:
The drm-intel repo is moving from the classic fd.o git host to GitLab.
Update its location with a URL matching other fd.o GitLab kernel trees.
Signed-off-by: Ryszard Knop
Acked-by: Lucas De Marchi
Also Cc'ing maintainers
On Fri, 26 Apr 2024 10:49:04 +0100, Colin Ian King wrote:
> There is a spelling mistake in a drm_dbg message. Fix it.
>
>
Applied, thanks!
[1/1] drm/xe: Fix spelling mistake "forcebly" -> "forcibly"
(no commit info)
Best regards,
--
Lucas De Marchi
Hi Dave and Sima
Please pull the drm-xe-fixes for this week targeting v6.9-rc6.
Simple fixes not really visible to end users: 2 around error paths on
drm managed allocations and 1 on PF/VF relay messages that are not
enabled by default.
thanks
Lucas De Marchi
drm-xe-fixes-2024-04-25:
- Fix
On Mon, Apr 22, 2024 at 03:10:10PM GMT, Jani Nikula wrote:
drivers/gpu/drm/xe/xe_debugfs.c | 1 +
drivers/gpu/drm/xe/xe_gt_debugfs.c | 2 ++
drivers/gpu/drm/xe/xe_uc_debugfs.c | 2 ++
Acked-by: Lucas De Marchi
thanks
Lucas De Marchi
Marchi
thanks
Lucas De Marchi
8 files changed, 167 insertions(+), 199 deletions(-)
--
2.44.0
On Wed, Apr 24, 2024 at 04:08:29AM GMT, Matthew Brost wrote:
On Tue, Apr 23, 2024 at 04:56:48PM -0700, Lucas De Marchi wrote:
From: Umesh Nerlige Ramappa
Add a helper to accumulate per-client runtime of all its
exec queues. Currently that is done in 2 places:
1. when the exec_queue
Acked-by: Lucas De Marchi
Lucas De Marchi
+https://gitlab.freedesktop.org/drm/i915/kernel.git
+ssh://g...@gitlab.freedesktop.org/drm/i915/kernel.git
+"
+drm_old_urls[drm-intel]="
ssh://git.freedesktop.org/git/drm/drm-intel
ssh://git.freedesktop.org/git/drm-intel
git://anongit.freedesk
From: Umesh Nerlige Ramappa
Add a helper to capture CTX_TIMESTAMP from the context image so it can
be used to calculate the runtime.
v2: Add kernel-doc to clarify expectation from caller
Signed-off-by: Umesh Nerlige Ramappa
Signed-off-by: Lucas De Marchi
---
drivers/gpu/drm/xe/regs
Move it out of the sysfs compilation unit so it can be re-used in other
places.
Reviewed-by: Nirmoy Das
Reviewed-by: Oak Zeng
Signed-off-by: Lucas De Marchi
---
drivers/gpu/drm/xe/xe_hw_engine.c | 18 ++
drivers/gpu/drm/xe/xe_hw_engine.h | 1 +
drivers
From: Umesh Nerlige Ramappa
Add a helper to accumulate per-client runtime of all its
exec queues. Currently that is done in 2 places:
1. when the exec_queue is destroyed
2. when the sched job is completed
Signed-off-by: Umesh Nerlige Ramappa
Signed-off-by: Lucas De Marchi
Just like CTX_TIMESTAMP is used to calculate runtime, add a helper to
get the timestamp for the engine so it can be used to calculate the
"engine time" with the same unit as the runtime is recorded.
Reviewed-by: Umesh Nerlige Ramappa
Signed-off-by: Lucas De Marchi
---
drivers/
:
- Create a new drm-total-cycles instead of re-using drm-engine with a
different unit
- Add documentation for the new interface and clarify usage of
xe_lrc_update_timestamp()
Test-with:
https://lore.kernel.org/igt-dev/20240423234431.1959354-1-lucas.demar...@intel.com/
Lucas De Marchi
Signed-off-by: Lucas De Marchi
---
drivers/gpu/drm/xe/xe_hw_engine.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_hw_engine.c
b/drivers/gpu/drm/xe/xe_hw_engine.c
index e1b167149166..7395e25d1c2e 100644
--- a/drivers/gpu/drm/xe/xe_hw_engine.c
kqueue to accumulate the counters
every so often, but it's additional complexity for something that is
done already by userspace every few seconds in tools like gputop (from
igt), htop, nvtop, etc with none of them really defaulting to 1 sample
per minute or more.
Signed-off-by: Lucas De Marchi
---
D
Hi Dave and Sima,
Please pull the drm-xe-fixes for this week targeting v6.9-rc5.
thanks
Lucas De Marchi
drm-xe-fixes-2024-04-18:
- Fix bo leak on error path during fb init
- Fix use-after-free due to order vm is put and destroyed
The following changes since commit
[=n] && ACPI [=y]
Selected by [m]:
- DRM_XE [=m] && HAS_IOMEM [=y] && DRM [=m] && PCI [=y] && MMU [=y] &&
(m && MODULES [=y] || y && KUNIT [=y]=y) && X86 [=y] && ACPI [=y]
Signed-off-by: Lu Yao
Reviewed-by: Luc
future commit making use of that register.
thanks
Lucas De Marchi
drm-xe-fixes-2024-04-11:
- Fix double display mutex initializations
- Fix u32 -> u64 implicit conversions
- Fix RING_CONTEXT_CONTROL not marked as masked
The following changes since commit fec50db7033ea478773b159e0e2efb135270e
, I suggest merging the lot via
drm-intel-next. Please ack if this is fine for you.
Acked-by: Lucas De Marchi
Lucas De Marchi
Chancellor
Reviewed-by: Lucas De Marchi
and pushed to drm-xe-next.
We probably need to find a way to make sure we generate it before
anything else. Maybe it'd be simpler to just do this:
diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile
index 60c90dc918b2..f3
what does "rebase" instead of "PATCH" is supposed to mean here?
And then we have a "PATCH v2" as reply to this one.
Shouldn't this go to dri-devel (too)?
Lucas De Marchi
On Thu, Apr 04, 2024 at 12:48:11PM +0200, Maarten Lankhorst wrote:
From: Maarten Lankhorst
with the
workqueue changes introduced in v6.9. That shouldn't be the normal use
case but was causing CI to abort further tests. Other changes include
fixes around rebinding and TLB invalidation.
thanks
Lucas De Marchi
drm-xe-fixes-2024-04-04:
- Stop using system_unbound_wq for preempt fences,
as this can
)
- Fix build on mips
- Fix wrong bound checks
- Fix use of msec rather than jiffies
- Remove dead code
Lucas De Marchi (1):
drm/xe: Fix END redefinition
Matthew Auld (5
rnel/-/commit/0d8cf0c924732a045273c6aca6900a340ac88529
Lucas De Marchi
1-5: Reviewed-by: Lucas De Marchi
thanks
Lucas De Marchi
ani Nikula
Signed-off-by: Lucas De Marchi
---
.../gpu/drm/i915/gt/intel_workarounds.c.rej| 18 --
1 file changed, 18 deletions(-)
delete mode 100644 drivers/gpu/drm/i915/gt/intel_workarounds.c.rej
diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c.rej
b/drivers/gpu/d
the need to do unbind and rebind as the driver needs to
reinitialize the device afresh post FLR.
Cc: Rodrigo Vivi
Cc: Lucas De Marchi
Signed-off-by: Aravind Iddamsetty
---
drivers/gpu/drm/xe/Makefile | 1 +
drivers/gpu/drm/xe/xe_device_types.h | 3 +
drivers/gpu/drm/xe/xe_gt.c | 31
the need to do unbind and rebind as the driver needs to
reinitialize the device afresh post FLR.
Cc: Rodrigo Vivi
Cc: Lucas De Marchi
we get the below splat but the device has recovered, have executed an
IGT post FLR.
ok, but that also means we we will need a few commits between patch 1
and 2
rmstrong
Acked-by: Lucas De Marchi
Lucas De Marchi
On Sun, Mar 17, 2024 at 09:14:14AM -0700, Guenter Roeck wrote:
Hi,
On Thu, Jan 18, 2024 at 04:16:12PM -0800, Lucas De Marchi wrote:
Now that all the issues with 32bits are fixed, enable it again.
Reviewed-by: Matt Roper
Signed-off-by: Lucas De Marchi
---
drivers/gpu/drm/xe/Kconfig | 2
.
Lucas De Marchi
drm-xe-next-fixes-2024-03-14:
Driver changes:
- Invalidate userptr VMA on page pin fault, allowing userspace
to free userptr while still having bindings
- Fail early on sysfs file creation error
- Skip VMA pinning on xe_exec with num_batch_buffer == 0
The following changes
)) ||
From what I can see, this workaround is also needed on Xe_LPG+ (12.74)
Isn't that an Xe platform? Or is 12.74 just ARL?
official xe platforms start with Xe2, with graphics version being 20
Lucas De Marchi
On Tue, Mar 12, 2024 at 03:54:09PM -0700, Matt Roper wrote:
On Wed, Mar 06, 2024 at 11:36:39AM -0800, Lucas De Marchi wrote:
With dynamic load-balancing disabled on the compute side, there's no
reason left to enable WA 16015675438. Drop it from both PVC and DG2.
Note that this can be done
On Tue, Mar 12, 2024 at 03:58:19PM -0700, Matt Roper wrote:
On Wed, Mar 06, 2024 at 11:36:40AM -0800, Lucas De Marchi wrote:
PCI IDs for XEHPSDV were never added and platform always marked with
force_probe. Drop what's not used and rename some places to either be
xehp or dg2, depending
On Mon, Mar 11, 2024 at 11:16:06AM -0400, Rodrigo Vivi wrote:
On Wed, Mar 06, 2024 at 11:36:40AM -0800, Lucas De Marchi wrote:
PCI IDs for XEHPSDV were never added and platform always marked with
force_probe. Drop what's not used and rename some places to either be
xehp or dg2, depending
On Tue, Mar 12, 2024 at 09:54:41AM +, Tvrtko Ursulin wrote:
On 11/03/2024 19:27, Lucas De Marchi wrote:
On Mon, Mar 11, 2024 at 05:43:00PM +, Tvrtko Ursulin wrote:
On 06/03/2024 19:36, Lucas De Marchi wrote:
Remove platforms that never had their PCI IDs added to the driver
On Mon, Mar 11, 2024 at 05:43:00PM +, Tvrtko Ursulin wrote:
On 06/03/2024 19:36, Lucas De Marchi wrote:
Remove platforms that never had their PCI IDs added to the driver and
are of course marked with requiring force_probe. Note that most of the
code for those platforms is actually used
uld also keep the caller as well.
right... I had removed it but brought it back since I noticed the
kernel-doc mentions and forgot to bring back the caller too. I will fix
this in next rev.
thanks
Lucas De Marchi
On Mon, Mar 11, 2024 at 11:18:03AM -0400, Rodrigo Vivi wrote:
On Wed, Mar 06, 2024 at 11:36:41AM -0800, Lucas De Marchi wrote:
With no platform declaring graphics/media IP_VER(12, 50),
this is not true.
We still have
#define XE_HPM_FEATURES \
.__runtime.media.ip.ver = 12
On Fri, Mar 08, 2024 at 01:55:52PM +0200, Jani Nikula wrote:
Prefer forward declarations over includes where possible.
Signed-off-by: Jani Nikula
Reviewed-by: Lucas De Marchi
Lucas De Marchi
---
drivers/gpu/drm/display/drm_dp_mst_topology_internal.h | 4 +++-
1 file changed, 3 insertions
On Fri, Mar 08, 2024 at 01:55:53PM +0200, Jani Nikula wrote:
Prefer forward declarations over includes where possible.
Signed-off-by: Jani Nikula
Reviewed-by: Lucas De Marchi
Lucas De Marchi
---
drivers/gpu/drm/drm_crtc_helper_internal.h | 10 ++
1 file changed, 6 insertions
On Fri, Mar 08, 2024 at 01:55:45PM +0200, Jani Nikula wrote:
Make documentation match code. Slightly fix up the documentation
comments while at it.
v2:
- Move comments next to members instead of struct comment (Lucas)
- Small fixups while at it
Cc: Lucas De Marchi
Acked-by: Thomas Zimmermann
On Thu, Feb 29, 2024 at 10:06:02PM -0600, Lucas De Marchi wrote:
On Thu, Feb 29, 2024 at 08:27:30PM +0200, Andy Shevchenko wrote:
On Thu, Feb 29, 2024 at 12:21:34PM -0600, Lucas De Marchi wrote:
On Thu, Feb 29, 2024 at 12:49:57PM +0200, Andy Shevchenko wrote:
On Wed, Feb 28, 2024 at 05:39
* drivers for the PXP services
- * @tee_dev: device that provide the PXP service from TEE Bus.
- * @pxp_ops: Ops implemented by TEE driver, used by i915 driver.
*/
... which you follow here.
Lucas De Marchi
struct i915_pxp_component {
+ /**
+* @tee_dev: device that provide the PXP
service from MEI Bus.
^provides
+*/
struct device *hdcp_dev;
+
+ /**
+* @ops: Ops implemented by hdcp driver or intel_hdcp_gsc , used by i915
extra space before ","
anyway,
Reviewed-by: Lucas De Marchi
Lucas
On Wed, Mar 06, 2024 at 08:31:20PM +0200, Jani Nikula wrote:
There's no proper way to document function pointer members, but at least
silence the warnings.
Signed-off-by: Jani Nikula
Reviewed-by: Lucas De Marchi
Lucas De Marchi
/xe/xe_lrc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Just a gentle ping.
I tweaked the commit message a little bit and applied to drm-xe-next.
Thanks.
Lucas De Marchi
PCI IDs for XEHPSDV were never added and platform always marked with
force_probe. Drop what's not used and rename some places to either be
xehp or dg2, depending on the platform/IP checks.
The registers not used anymore are also removed.
Signed-off-by: Lucas De Marchi
---
Potential problem
With both XEHPSDV and PVC removed (as platforms, most of their code
remain used by others), there's no need to handle !RCS_MASK() as
other platforms don't ever have fused-off render. Remove those code
paths and the special WA flag when initializing GuC.
Signed-off-by: Lucas De Marchi
PCI IDs for PVC were never added and platform always marked with
force_probe. Drop what's not used and rename some places as needed.
The registers not used anymore are also removed.
Signed-off-by: Lucas De Marchi
---
.../gpu/drm/i915/gem/i915_gem_object_types.h | 2 +-
drivers/gpu/drm/i915
is still needed because of 18020744125, so update
the comment accordingly.
Cc: Mateusz Jablonski
Cc: Michal Mrozek
Cc: Rodrigo Vivi
Signed-off-by: Lucas De Marchi
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 6 +-
drivers/gpu/drm/i915/gt/uc/intel_guc.c | 2 +-
2 files changed, 2
-lucas.demar...@intel.com .
While loooking at this WA I was wondering why we still had some of that
code around.
Build-tested only for now.
Lucas De Marchi (5):
drm/i915: Drop WA 16015675438
drm/i915: Drop dead code for xehpsdv
drm/i915: Update IP_VER(12, 50)
drm/i915: Drop dead code
without pointless overrides.
Signed-off-by: Lucas De Marchi
---
drivers/gpu/drm/i915/gem/selftests/huge_pages.c | 4 ++--
.../gpu/drm/i915/gem/selftests/i915_gem_client_blt.c | 8
drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 2 +-
drivers/gpu/drm/i915/gt
o find all the issues
my configs didn't catch.
I built this on x86-64 (both gcc and clang), arm and arm64, and
[ ... ]
Acked-by: Maxime Ripard
Thanks everyone for acks and reviews, pushed to drm-misc-next.
should we start removing the now duplicate ones in i915 and xe?
Lucas De Marchi
handling page fault on a VM not in fault mode
- Drop use of "grouped target" feature in Makefile since that's
only available in make >= 4.3
thanks,
Lucas De Marchi
The following changes since commit c6d6a82d8a9f8f9326b760accaa532b839b80140:
Merge tag 'drm-misc-next-fixes-2024-02-
1 - 100 of 885 matches
Mail list logo
