[PULL] drm-xe-next-fixes

2025-10-03 Thread Lucas De Marchi
Hi Dave and Sima, This contains a set of fixes for 6.18-rc1. I ended up delaying this and hence collected more patches. Fixes are mostly spread around the driver for the new features, particularly on error paths. Thanks Lucas De Marchi drm-xe-next-fixes-2025-10-03: Cross-subsystem Changes

Re: [PATCH 1/2] PCI: Release BAR0 of an integrated bridge to allow GPU BAR resize

2025-10-02 Thread Lucas De Marchi
On Thu, Sep 18, 2025 at 01:58:56PM -0700, Lucas De Marchi wrote: From: Ilpo Järvinen Resizing BAR to a larger size has to release upstream bridge windows in order make the bridge windows larger as well (and to potential relocate them into a larger free block within iomem space). Some GPUs have

Re: [PATCH] drm/{i915,xe}: driver agnostic drm to display pointer chase

2025-09-27 Thread Lucas De Marchi
On Fri, Sep 26, 2025 at 06:11:41PM +0300, Jani Nikula wrote: On Fri, 26 Sep 2025, Lucas De Marchi wrote: On Fri, Sep 26, 2025 at 02:10:32PM +0300, Jani Nikula wrote: diff --git a/drivers/gpu/drm/i915/display/intel_display_conversion.c b/drivers/gpu/drm/i915/display/intel_display_conversion.c

Re: drm/xe: Linker errors on configfs symbols

2025-09-26 Thread Lucas De Marchi
elect CONFIGFS_FS Maybe it'd be better to have it like this so it's still possible to remove it? config DRM_XE_CONFIGFS depends on DRM_XE depends on CONFIGFS_FS Lucas De Marchi help Driver for Intel Xe2 series GPUs and later. Experimental support for Xe series is also available.

Re: [PATCH] drm/{i915,xe}: driver agnostic drm to display pointer chase

2025-09-26 Thread Lucas De Marchi
r the drm member. Cc: Lucas De Marchi Cc: Rodrigo Vivi Cc: Ville Syrjala Suggested-by: Simona Vetter Signed-off-by: Jani Nikula --- .../i915/display/intel_display_conversion.c | 20 + drivers/gpu/drm/i915/i915_driver.c| 4 ++ drivers/gpu/drm/i915/i915_drv.h

Re: [PATCH] fbcon: Fix OOB access in font allocation

2025-09-22 Thread Lucas De Marchi
/gitlab.freedesktop.org/drm/xe/kernel/-/issues/6201 Reviewed-by: Lucas De Marchi thanks Lucas De Marchi Cc: Samasth Norway Ananda Cc: Thomas Zimmermann Cc: George Kennedy Cc: Greg Kroah-Hartman Cc: Simona Vetter Cc: Helge Deller Cc: "Ville Syrjälä" Cc: Sam Ravnborg Cc: Qianqiang

Re: [PATCH v9 2/9] mei: late_bind: add late binding component driver

2025-09-20 Thread Lucas De Marchi
dev = to_pci_dev(dev); + + if (pdev->vendor != PCI_VENDOR_ID_INTEL) + return 0; + + if (pdev->class != (PCI_CLASS_DISPLAY_VGA << 8) && + pdev->class != (PCI_CLASS_DISPLAY_OTHER << 8)) this doesn't seem right, we should allow o

[PULL] drm-xe-next

2025-09-19 Thread Lucas De Marchi
ill take a look in dim to understand what's happening and how this escaped. For the escape it's probably because the check was skipped for the first patch, since it's a bug in dim, but then it also skipped for subsequent patches in the same series when pushing. thanks Lucas De Marc

[PATCH 2/2] drm/xe: Move rebar to be done earlier

2025-09-18 Thread Lucas De Marchi
ood to move it out of xe_vram.c, but this refactor is left for later. Cc: Ilpo Järvinen Cc: # 6.12+ Link: https://lore.kernel.org/intel-xe/fafda2a3-fc63-ce97-d22b-803f771a4...@linux.intel.com Signed-off-by: Lucas De Marchi --- v2: - Use res->parent to test resource assignment and avoid

[PATCH 1/2] PCI: Release BAR0 of an integrated bridge to allow GPU BAR resize

2025-09-18 Thread Lucas De Marchi
GPU's sysfs entries required for initiating the resize operation, whereas removing the topmost bridge this quirk targets would result in removing the GPU device as well so no manual workaround for this problem exists. Reported-by: Lucas De Marchi Link: https://lore.kernel.org/linu

[PATCH 0/2] drm/xe: Fix some rebar issues

2025-09-18 Thread Lucas De Marchi
, it's expected that it won't be needed for a long time. Signed-off-by: Lucas De Marchi --- Ilpo Järvinen (1): PCI: Release BAR0 of an integrated bridge to allow GPU BAR resize Lucas De Marchi (1): drm/xe: Move rebar to be done earlier drivers/gpu/drm/xe/xe_pci.c |

Re: [PATCH 3/3] drm/xe: Move rebar to its own file

2025-09-18 Thread Lucas De Marchi
On Thu, Sep 18, 2025 at 07:41:59PM +0300, Ilpo Järvinen wrote: On Wed, 17 Sep 2025, Lucas De Marchi wrote: Now that xe_pci.c calls the rebar directly, it doens't make sense to keep it in xe_vram.c since it's closer to the PCI initialization than to the vram. Move it to its own file.

Re: [PATCH 3/3] drm/xe: Move rebar to its own file

2025-09-18 Thread Lucas De Marchi
On Thu, Sep 18, 2025 at 12:22:22AM +0200, Michal Wajdeczko wrote: On 9/17/2025 11:37 PM, Lucas De Marchi wrote: Now that xe_pci.c calls the rebar directly, it doens't make sense to typo: doesn't keep it in xe_vram.c since it's closer to the PCI initialization than to the v

Re: [PATCH 1/3] PCI: Release BAR0 of an integrated bridge to allow GPU BAR resize

2025-09-18 Thread Lucas De Marchi
On Thu, Sep 18, 2025 at 02:45:17PM +0300, Ilpo Järvinen wrote: On Wed, 17 Sep 2025, Lucas De Marchi wrote: From: Ilpo Järvinen Resizing BAR to a larger size has to release upstream bridge windows in order make the bridge windows larger as well (and to potential relocate them into a larger

[PATCH 2/3] drm/xe: Move rebar to be done earlier

2025-09-17 Thread Lucas De Marchi
ood to move it out of xe_vram.c, but this refactor is left for later. Cc: Ilpo Järvinen Cc: # 6.12+ Link: https://lore.kernel.org/intel-xe/fafda2a3-fc63-ce97-d22b-803f771a4...@linux.intel.com Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/xe/xe_pci.c | 2 ++ drivers/gpu/drm

[PATCH 3/3] drm/xe: Move rebar to its own file

2025-09-17 Thread Lucas De Marchi
ned-off-by: Lucas De Marchi --- drivers/gpu/drm/xe/Makefile | 1 + drivers/gpu/drm/xe/xe_pci.c | 3 +- drivers/gpu/drm/xe/xe_pci_rebar.c | 125 ++ drivers/gpu/drm/xe/xe_pci_rebar.h | 13 drivers/gpu/drm/xe/xe_vram.c

[PATCH 1/3] PCI: Release BAR0 of an integrated bridge to allow GPU BAR resize

2025-09-17 Thread Lucas De Marchi
GPU's sysfs entries required for initiating the resize operation, whereas removing the topmost bridge this quirk targets would result in removing the GPU device as well so no manual workaround for this problem exists. Reported-by: Lucas De Marchi Cc: # 6.12+ Link: https://lore.kernel.org/linu

[PATCH 0/3] drm/xe: Fix some rebar issues

2025-09-17 Thread Lucas De Marchi
th the PCI refactors and BAR fitting logic that Ilpo is working on, it's expected that it won't be needed for a long time. Signed-off-by: Lucas De Marchi --- Ilpo Järvinen (1): PCI: Release BAR0 of an integrated bridge to allow GPU BAR resize Lucas De Marchi (2): drm/xe: M

Re: [PATCH v2 00/11] PCI: Resizable BAR improvements

2025-09-17 Thread Lucas De Marchi
On Wed, Sep 17, 2025 at 04:00:10PM +0300, Ilpo Järvinen wrote: On Tue, 16 Sep 2025, Lucas De Marchi wrote: On Mon, Sep 15, 2025 at 08:24:06PM +0300, Ilpo Järvinen wrote: > On Mon, 15 Sep 2025, Lucas De Marchi wrote: > > > On Mon, Sep 15, 2025 at 12:13:47PM +0300, Ilpo Jä

Re: [PATCH -next] drm/xe: Remove duplicate header files

2025-09-16 Thread Lucas De Marchi
to drm-xe-next. Thanks. [1/1] drm/xe: Remove duplicate header files commit: 9e6eb49ec13936461c697348c74e5450ac82707d -- Lucas De Marchi

Re: [PATCH v2 00/11] PCI: Resizable BAR improvements

2025-09-16 Thread Lucas De Marchi
On Mon, Sep 15, 2025 at 08:24:06PM +0300, Ilpo Järvinen wrote: On Mon, 15 Sep 2025, Lucas De Marchi wrote: On Mon, Sep 15, 2025 at 12:13:47PM +0300, Ilpo Järvinen wrote: > pci.c has been used as catch everything that doesn't fits elsewhere > within PCI core and thus resizable BAR co

Re: [PATCH v9 2/9] mei: late_bind: add late binding component driver

2025-09-15 Thread Lucas De Marchi
is doesn't seem right, we should allow other PCI classes. AFAICS this check could just be removed and just leave the INTEL_COMPONENT_LB below to protect for component match Lucas De Marchi The subcomponent is unique only in its own instance of the component framework. Or I'm wron

Re: [PATCH -next 2/2] drm/xe: Remove duplicated include in xe_tlb_inval.c

2025-09-15 Thread Lucas De Marchi
as in the previous one. Please use `LANG=C sort -u` and submit as a single patch. thanks Lucas De Marchi

Re: [PATCH v2 00/11] PCI: Resizable BAR improvements

2025-09-15 Thread Lucas De Marchi
remap if we have have to resize or just move the resize logic early on. thanks Lucas De Marchi Some parts of this are to be used by the resizable BAR changes into the resource fitting/assingment logic but these seem to stand on their own so sending these out now to reduce the size of the oth

Re: [PATCH] drm/xe: Use ERR_CAST instead of ERR_PTR(PTR_ERR(...))

2025-09-15 Thread Lucas De Marchi
On Sun, 14 Sep 2025 18:16:30 +0800, Fushuai Wang wrote: > Use ERR_CAST inline function instead of ERR_PTR(PTR_ERR(...)). > > Merged to drm-xe-next, thanks! [1/1] drm/xe: Use ERR_CAST instead of ERR_PTR(PTR_ERR(...)) commit: 84afb84bcc28b08e6d8a4e36865959d770e2643d -- Lucas De Marchi

Re: [PATCH -next 1/2] drm/xe: Remove duplicated include in xe_pt.c

2025-09-15 Thread Lucas De Marchi
t_types.h" | #include "xe_pt_walk.h" | #include "xe_res_cursor.h" | #include "xe_sched_job.h" | -#include "xe_sync.h" | #include "xe_svm.h" | +#include "xe_sync.h" | #include "xe_tlb_inval_job.h" | #include "xe

Re: [PATCH][next] drm/xe/guc: Fix spelling mistake "sheduling" -> "scheduling"

2025-09-12 Thread Lucas De Marchi
abcd05306233b367c6b407 -- Lucas De Marchi

Re: [PATCH v9 2/9] mei: late_bind: add late binding component driver

2025-09-11 Thread Lucas De Marchi
On Tue, Sep 09, 2025 at 09:43:02AM -0500, Lucas De Marchi wrote: On Tue, Sep 09, 2025 at 04:50:41AM +, Usyskin, Alexander wrote: +static int mei_lb_component_match(struct device *dev, int subcomponent, + void *data) +{ + /* +* This function

Re: [PATCH] drm/xe/hwmon: Use devm_mutex_init()

2025-09-09 Thread Lucas De Marchi
dec hex filename > 36884 10296 64 47244b88c drivers/gpu/drm/xe/xe_hwmon.o > > [...] Applied to drm-xe-next, thanks! [1/1] drm/xe/hwmon: Use devm_mutex_init() commit: 7b77941724628e6171a286edbf04d67a1f1c1459 Best regards, -- Lucas De Marchi

Re: [PATCH v3] MAINTAINERS: Update Min Ma's email for AMD XDNA driver

2025-09-04 Thread Lucas De Marchi
/83 For now, please use `dim -f ...` to bypass this error. Lucas De Marchi dim: ERROR: a12586e4e737 ("MAINTAINERS: Update Min Ma's email for AMD XDNA driver"): Mandatory Maintainer Acked-by missing., aborting Thanks, Lizhi On 9/2/25 12:47, Lizhi Hou wrote: Reviewed-by: Lizh

[PULL] drm-xe-next

2025-08-29 Thread Lucas De Marchi
couple of weeks, but it should be smaller than this one. Thaks, Lucas De Marchi drm-xe-next-2025-08-29: UAPI Changes: - Add madvise interface (Himal Prasad Ghimiray) - Add DRM_IOCTL_XE_VM_QUERY_MEMORY_RANGE_ATTRS to query VMA count and memory attributes (Himal Prasad Ghimiray) - Handle Firmware

Re: [PATCH][next] drm/xe: Avoid dozens of -Wflex-array-member-not-at-end warnings

2025-08-29 Thread Lucas De Marchi
patch be together with actually enabling the warning (at least locally in xe) so we don't re-introduce it? From the user side it's not obvious that dev_pagemap itself contains an array so it can only be embedded at the end. Lucas De Marchi Signed-off-by: Gustavo A. R. Silva --- drive

Re: [PATCH v4 3/7] kunit: Pass parameterized test context to generate_params()

2025-08-28 Thread Lucas De Marchi
change log for the definitions. --- drivers/gpu/drm/xe/tests/xe_pci.c | 14 +++--- drivers/gpu/drm/xe/tests/xe_pci_test.h | 9 +++++---- Acked-by: Lucas De Marchi thanks Lucas De Marchi include/kunit/test.h | 9 ++--- kernel/kcsan/kcsan_test.c

Re: [PATCH v3] drm/xe: switch to local xbasename() helper

2025-08-25 Thread Lucas De Marchi
drm/xe: prepare xe_gen_wa_oob to be multi-use") Suggested-by: Lucas De Marchi Reviewed-by: Tiffany Yang Signed-off-by: Carlos Llamas Reviewed-by: Lucas De Marchi I'll push to drm-xe-next later today. Thanks. Lucas De Marchi --- v3: - Switch __basename() -> xbase

Re: [PATCH] drm/xe: add missing include

2025-08-25 Thread Lucas De Marchi
ng.h, but other libc's don't (or removed it recently). See https://lore.kernel.org/intel-xe/w4j3kzezrd4xqc4q4vkpbbxqvqxitam5htkex6rj6dguj5kbw5@27gqnp6veuu4/ Lucas De Marchi

Re: [PATCH v2] drm/xe: switch to local __basename() helper

2025-08-23 Thread Lucas De Marchi
macros for internal purposes without risk of conflict with names in user programs. provides the same functionality and avoids portability issues. Unfortunately with that name it could created other portability issues. Lucas De Marchi Fixes: b0a2ee5567ab ("drm/xe: prepare xe_gen_wa_

Re: [PATCH] drm/xe: replace basename() with portable strrchr()

2025-08-21 Thread Lucas De Marchi
On Wed, Aug 20, 2025 at 11:05:47PM +, Carlos Llamas wrote: On Wed, Aug 20, 2025 at 04:15:47PM -0500, Lucas De Marchi wrote: On Wed, Aug 20, 2025 at 08:16:11PM +, Carlos Llamas wrote: > Commit b0a2ee5567ab ("drm/xe: prepare xe_gen_wa_oob to be multi-use") > introduced a

Re: [PATCH] drm/xe: replace basename() with portable strrchr()

2025-08-20 Thread Lucas De Marchi
somewhere that can be shared across the userspace tools in the kernel tree to fix the mess that we have here: git grep basename -- tools/**.c Some dup the arg simply to be able to use the libgen.h version, some use one or the other on purpose, etc etc. Lucas De Marchi

Re: [PATCH] gpu/trace: TRACE_GPU_MEM should depend on DRM

2025-08-08 Thread Lucas De Marchi
t;gpu/trace: make TRACE_GPU_MEM configurable") Signed-off-by: Geert Uytterhoeven Currently there are 2 drivers using it: drm/xe and drm/msm, but there's no real dependency and in future more drivers may add these tracepoints. Juston, do you have any other drivers planned? Lucas De March

Re: [PATCH 5/9] drm/xe: Update parameter generator to new signature

2025-08-07 Thread Lucas De Marchi
straightforward fix after patch 3. xe folks, would you prefer this kept as a separate patch, or squashed into patch 3 (which changed the function signature)? I don't like the breakage. Squashing would be much preferred. thanks Lucas De Marchi

Re: [PATCH 3/9] drm/xe/xe_late_bind_fw: Introducing xe_late_bind_fw

2025-07-25 Thread Lucas De Marchi
rs/gpu/drm/xe/xe_pci.c +++ b/drivers/gpu/drm/xe/xe_pci.c @@ -332,6 +332,7 @@ static const struct xe_device_desc bmg_desc = { .has_gsc_nvm = 1, .has_heci_cscfi = 1, .max_gt_per_tile = 2, + .has_late_bind = true, again, boring is good: all the has_ flags should be sorted

Re: linux-next: Tree for Jul 21 [drivers/gpu/drm/xe/xe.ko]

2025-07-23 Thread Lucas De Marchi
On Tue, Jul 22, 2025 at 10:26:11AM -0300, Lucas De Marchi wrote: On Mon, Jul 21, 2025 at 10:50:29PM -0700, Randy Dunlap wrote: Hi, On 7/21/25 6:38 PM, Lucas De Marchi wrote: On Mon, Jul 21, 2025 at 01:17:33PM -0700, Randy Dunlap wrote: On 7/21/25 12:41 AM, Stephen Rothwell wrote: Hi all

Re: linux-next: Tree for Jul 21 [drivers/gpu/drm/xe/xe.ko]

2025-07-22 Thread Lucas De Marchi
On Mon, Jul 21, 2025 at 10:50:29PM -0700, Randy Dunlap wrote: Hi, On 7/21/25 6:38 PM, Lucas De Marchi wrote: On Mon, Jul 21, 2025 at 01:17:33PM -0700, Randy Dunlap wrote: On 7/21/25 12:41 AM, Stephen Rothwell wrote: Hi all, Changes since 20250718: on ARCH=um SUBARCH=i386, when

Re: linux-next: Tree for Jul 21 [drivers/gpu/drm/xe/xe.ko]

2025-07-21 Thread Lucas De Marchi
(CONFIG_DEBUG_FS) && should_fail(>_reset_failure, 1); } struct xe_gt *xe_gt_alloc(struct xe_tile *tile); -----8<--- thanks, Lucas De Marchi ERROR: modpost: "gt_reset_failure" [drivers/gpu/drm/xe/xe.ko] undefined! -- ~Randy

[PULL] drm-xe-fixes

2025-07-17 Thread Lucas De Marchi
topology There's a small conflict when applying drm-next and when applying drm-xe-next on top of them, but should be trivial and already solved in drm-tip. thanks, Lucas De Marchi. The following changes since commit 347e9f5043c89695b01e66b3ed111755afcf1911: Linux 6.16-rc6 (2025-07-13 14:

Re: [PATCH] drm/xe: Remove unused functions

2025-07-14 Thread Lucas De Marchi
I've left those, as opposed to these that had the code that used them removed). Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Lucas De Marchi Applied to drm-xe-next! [1/1] drm/xe: Remove unused functions commit: 8f3d1c9fb04e2ae018d06b4cacc49e146120facc thanks Lucas De Marc

[PULL] drm-xe-fixes

2025-07-10 Thread Lucas De Marchi
devcoredump - Fix xe_pm_set_vram_threshold() doc - Recommend new minor versions of GuC firmware - Drop some workarounds on VF - Do not use verbose GuC logging by default: it should be only for debugging thanks, Lucas De Marchi The following changes since commit d7b8f8e20813f0179d8ef519541a3527e7661d3a

Re: [PATCH v5 2/2] drm/xe/bo: add GPU memory trace points

2025-07-08 Thread Lucas De Marchi
wouldn't it be better to move the ifdef inside the function? Any compiler would remove the empty call regardless of the inline annotation, so I think this would make it less error prone if we change function signature. No need to send a new version, I can move that while applying if agreed. Lucas De Marchi

Re: [PATCH v5 1/2] gpu/trace: make TRACE_GPU_MEM configurable

2025-07-08 Thread Lucas De Marchi
-by: Lucas De Marchi This first patch is now applied to drm-misc-next. Thanks Lucas De Marchi

Re: [PATCH v5 2/2] drm/xe/bo: add GPU memory trace points

2025-07-08 Thread Lucas De Marchi
Kconfig Signed-off-by: Juston Li Reviewed-by: Tvrtko Ursulin Reviewed-by: Lucas De Marchi Lucas De Marchi

[PULL] drm-xe-fixes

2025-07-03 Thread Lucas De Marchi
) - Fix wedging the device on signal (Matthew Brost) thanks, Lucas De Marchi The following changes since commit d0b3b7b22dfa1f4b515fd3a295b3fd958f9e81af: Linux 6.16-rc4 (2025-06-29 13:09:04 -0700) are available in the Git repository at: https://gitlab.freedesktop.org/drm/xe/kernel.git tags

Re: [PATCH] drm/ttm: Remove unneeded blank line in comment

2025-07-02 Thread Lucas De Marchi
commit: d6a59ee852758bc69c4cc821954db277a2bd5b93 Lucas De Marchi

Re: iosys-map: refactor to reduce struct size

2025-06-27 Thread Lucas De Marchi
7;re going to re-submit without the last one? thanks Lucas De Marchi Dave.

Re: linux-next: Tree for Jun 25 (drivers/gpu/drm/{i915,xe}/intel_pcode.o)

2025-06-26 Thread Lucas De Marchi
xt+0x9d0): first defined here not exclusive to i386... the pcode part used to be guarded by CONFIG_DRM_XE_DISPLAY, but that is broken now. Possible fix discussed in https://lore.kernel.org/intel-xe/gbisrh7ep2gn2fxv7xz4g4sy75qjpmcr5yqdx5atlab2oxevlx@j3zwx3k4o4x4/ Lucas De Marchi -- ~Randy

Re: [PATCH] drm/xe: Fix kconfig prompt

2025-06-16 Thread Lucas De Marchi
On Wed, 11 Jun 2025 12:38:37 -0700, Lucas De Marchi wrote: > The xe driver is the official driver for Intel Xe2 and later, while > maintaining experimental support for earlier GPUs. Reword the help > message accordingly. > > Applied to drm-xe-next, thanks! [1/1] drm/xe: Fix

Re: [PATCH v4 2/2] drm/xe/bo: add GPU memory trace points

2025-06-13 Thread Lucas De Marchi
On Fri, Jun 13, 2025 at 03:14:24PM +0100, Tvrtko Ursulin wrote: On 13/06/2025 15:10, Lucas De Marchi wrote: On Fri, Jun 13, 2025 at 09:02:27AM +0100, Tvrtko Ursulin wrote: On 12/06/2025 19:53, Yiwei Zhang wrote: On Thu, Jun 12, 2025 at 11:02 AM Lucas De Marchi wrote: On Thu, Jun 12, 2025

Re: [PATCH v4 2/2] drm/xe/bo: add GPU memory trace points

2025-06-13 Thread Lucas De Marchi
On Fri, Jun 13, 2025 at 09:02:27AM +0100, Tvrtko Ursulin wrote: On 12/06/2025 19:53, Yiwei Zhang wrote: On Thu, Jun 12, 2025 at 11:02 AM Lucas De Marchi wrote: On Thu, Jun 12, 2025 at 05:46:52PM +0100, Tvrtko Ursulin wrote: On 12/06/2025 06:40, Lucas De Marchi wrote: On Wed, Jun 11, 2025

Re: [PATCH v2 0/5] drm/xe: enable driver usage on non-4KiB kernels

2025-06-12 Thread Lucas De Marchi
For some reason this patch series didn't make it to any mailing list... it only shows the b4-sent and stable: https://lore.kernel.org/intel-xe/20250604-upstream-xe-non-4k-v2-v2-0-ce7905da7...@aosc.io/ Could you resend this series? thanks Lucas De Marchi On Wed, Jun 04, 2025 at 10:57:54AM

Re: [PATCH v4 2/2] drm/xe/bo: add GPU memory trace points

2025-06-12 Thread Lucas De Marchi
On Thu, Jun 12, 2025 at 05:46:52PM +0100, Tvrtko Ursulin wrote: On 12/06/2025 06:40, Lucas De Marchi wrote: On Wed, Jun 11, 2025 at 03:51:24PM -0700, Juston Li wrote: Add TRACE_GPU_MEM tracepoints for tracking global and per-process GPU memory usage. These are required by VSR on Android 12

Re: [PATCH v6 4/4] drm/xe: Make dma-fences compliant with the safe access rules

2025-06-12 Thread Lucas De Marchi
Marchi for merging this through drm-misc tree. Lucas De Marchi

Re: [PATCH v4 2/2] drm/xe/bo: add GPU memory trace points

2025-06-11 Thread Lucas De Marchi
atomic64_t process_mem; so... this is not per-process, it's actually "per dev node" open. Does this map correctly to the intended use and how it's handled in msm? Lucas De Marchi +#endif }; #endif -- 2.50.0.rc1.591.g9c95f17f64-goog

Re: [PATCH v4 1/2] gpu/trace: make TRACE_GPU_MEM configurable

2025-06-11 Thread Lucas De Marchi
-by: Lucas De Marchi thanks Lucas De Marchi --- drivers/Kconfig | 2 -- drivers/gpu/trace/Kconfig | 11 ++- drivers/video/Kconfig | 1 + 3 files changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/Kconfig b/drivers/Kconfig index 7c556c5ac4fdd..c5edbd2288a19 100

[PATCH] drm/xe: Fix kconfig prompt

2025-06-11 Thread Lucas De Marchi
The xe driver is the official driver for Intel Xe2 and later, while maintaining experimental support for earlier GPUs. Reword the help message accordingly. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/xe/Kconfig | 5 +++-- drivers/gpu/drm/xe/xe_drv.h | 2 +- 2 files changed, 4 insertions

[PATCH] drm/ttm: Fix build with CONFIG_DEBUG_FS=n

2025-06-03 Thread Lucas De Marchi
ristian König Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/ttm/ttm_pool.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_pool.c b/drivers/gpu/drm/ttm/ttm_pool.c index e671812789ea7..2dead28a6c1c0 100644 --- a/drivers/gpu/drm/ttm/ttm_pool.c +++

Re: [PATCH v2 2/2] drm/ttm: Increase pool shrinker batch target

2025-06-03 Thread Lucas De Marchi
TCH’ undeclared (first use in this function) 1335 | mm_shrinker->batch = TTM_SHRINKER_BATCH; | ^~ Maybe move it to the top of the file or before the ifdef... ? Lucas De Marchi

Re: [PATCH v2] drm/xe/bo: add GPU memory trace points

2025-05-30 Thread Lucas De Marchi
On Wed, May 28, 2025 at 08:01:21PM +, Juston Li wrote: On Wed, 2025-05-28 at 18:34 +, Juston Li wrote: On Thu, 2025-05-22 at 16:14 +0100, Tvrtko Ursulin wrote: > > On 22/05/2025 15:50, Lucas De Marchi wrote: > > + dri-devel > > > > On Wed, May 21, 2025 at 10:

Re: [PATCH v2] drm/xe/vsec: fix CONFIG_INTEL_VSEC dependency

2025-05-30 Thread Lucas De Marchi
On Thu, 29 May 2025 10:23:56 -0700, Lucas De Marchi wrote: > The XE driver can be built with or without VSEC support, but fails to link as > built-in if vsec is in a loadable module: > > x86_64-linux-ld: vmlinux.o: in function `xe_vsec_init': > (.text+0x1e83e16): un

[PATCH v2] drm/xe/vsec: fix CONFIG_INTEL_VSEC dependency

2025-05-29 Thread Lucas De Marchi
ec: Support BMG devices") Signed-off-by: Arnd Bergmann Reviewed-by: Lucas De Marchi Signed-off-by: Lucas De Marchi --- v2: s/INTEL_PLATFORM_DEVICES/X86_PLATFORM_DEVICES/ drivers/gpu/drm/xe/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu

Re: [PATCH] drm/xe: Fix NPD when saving default context

2025-05-29 Thread Lucas De Marchi
q->xef->drm->client_id); +q->xef ? q->xef->drm->client_id : 0); drm_sched_job_init() has only 4 args! and the line above uses only 4. Lucas De Marchi

Re: [PATCH] drm/xe: Fix NPD when saving default context

2025-05-29 Thread Lucas De Marchi
On Wed, May 28, 2025 at 02:51:33PM -0700, Matthew Brost wrote: On Wed, May 28, 2025 at 02:42:22PM -0700, Lucas De Marchi wrote: xef is only valid if it's a job from userspace. For in-kernel jobs it causes a NPD like below: <4> [] RIP: 0010:xe_sched_job_create+0xb

[PATCH] drm/xe: Fix NPD when saving default context

2025-05-28 Thread Lucas De Marchi
+0x542/0xb00 [xe] Since drm_file starts with 1 for the unique id, just use 0 for the in-kernel jobs. Fixes: 2956554823ce ("drm/sched: Store the drm client_id in drm_sched_fence") Cc: Christian König Cc: Pierre-Eric Pelloux-Prayer Cc: Philipp Stanner Signed-off-by: Lucas De Marchi ---

Re: [PATCH v11 02/10] drm/sched: Store the drm client_id in drm_sched_fence

2025-05-28 Thread Lucas De Marchi
id : 0); | if (err) | goto err_free; I tested with the above diff and it at least loads... Also, I see this in intel-xe mailing list, but I'm not sure why we didn't have any CI results... I will check that. Lucas De Marchi

Re: [PATCH] drm/bridge: analogix_dp: Fix clk-disable removal

2025-05-28 Thread Lucas De Marchi
pare() during probing") Signed-off-by: Heiko Stuebner Reviewed-by: Lucas De Marchi Dmitry, maybe you have to enable a config in your build tests so we don't have broken builds? Lucas De Marchi

Re: [PATCH] drm/xe/vsec: fix CONFIG_INTEL_VSEC dependency

2025-05-27 Thread Lucas De Marchi
ends on INTEL_PLATFORM_DEVICES || !(X86 && ACPI) ^ Did you mean X86_PLATFORM_DEVICES here? With that, Reviewed-by: Lucas De Marchi I see several drivers selecting X86_PLATFORM_DEVICES though. Maybe they should also be translated to dependencies instead? $

[PULL] drm-xe-fixes

2025-05-22 Thread Lucas De Marchi
onize Panther Lake PCI IDs thanks Lucas De Marchi The following changes since commit a5806cd506af5a7c19bcd596e4708b5c464bfd21: Linux 6.15-rc7 (2025-05-18 13:57:29 -0700) are available in the Git repository at: https://gitlab.freedesktop.org/drm/xe/kernel.git tags/drm-xe-fixes-2025-05-23 fo

Re: [PATCH 9/9] iosys_map: embed the is_iomem bit into the pointer.

2025-05-22 Thread Lucas De Marchi
On Fri, May 23, 2025 at 06:32:43AM +1000, Dave Airlie wrote: On Fri, 23 May 2025 at 01:10, Lucas De Marchi wrote: On Thu, May 22, 2025 at 04:52:18PM +1000, Dave Airlie wrote: >From: Dave Airlie > >This reduces this struct from 16 to 8 bytes, and it gets embedded >into a l

Re: [PATCH 9/9] iosys_map: embed the is_iomem bit into the pointer.

2025-05-22 Thread Lucas De Marchi
ructs like guc_gt_system_info. In this particular case it doesn't give unaligned address, but we should probably then protect iosys_map from doing the wrong thing. So, if we are keeping this patch, we should probably protect initially-unaligned addresses and the iosys_map_incr() call? thanks

Re: [PATCH v2] drm/xe/bo: add GPU memory trace points

2025-05-22 Thread Lucas De Marchi
gem_object_open. The impl of the update_* functions could also be in the form static void update_...() { #if IS_ENABLED(CONFIG_...) #endif } thanks Lucas De Marchi + .open = xe_gem_object_open, +#endif .close = xe_gem_object_close, .mmap = drm_gem_ttm_mmap, .

Re: iosys-map: refactor to reduce struct size

2025-05-22 Thread Lucas De Marchi
the series: Reviewed-by: Lucas De Marchi We will probably have quite a few conflicts in drm-xe-next as there are some changes touching those vmaps, but we can handle those. Lucas De Marchi Dave.

Re: [PATCH 4/9] drm/xe: avoid accessing internals of iosys_map

2025-05-22 Thread Lucas De Marchi
ess. But I have no idea why exactly this is hand rolling the read. It seems we'd benefit from also having fixed-types (at least u32) in iosys_map so drivers don't seem tempted to do this. Lucas De Marchi } static inline void xe_map_write32(struct xe_device *xe, struct iosys_map *m

Re: [PATCH 5/9] drm/qxl: avoid accessing iosys_map internals.

2025-05-22 Thread Lucas De Marchi
p); this looks wrong as we then lose the __iomem. Or is this dead code and it's never iomem? Anyway, pre-existent issue unrelated to this patch. Lucas De Marchi else - bo->kptr = bo->map.vaddr; + bo->kptr = iosys_map_ptr(&bo->m

Re: [PATCH 1/9] iosys-map: add new accessor interfaces and use them internally.

2025-05-22 Thread Lucas De Marchi
ere are just a few cases in which we'd have a direct translation to existing API... so I wouldn't make this internal when they are clearly needed externally. Lucas De Marchi Best regards Thomas /** * IOSYS_MAP_INIT_VADDR - Initializes struct iosys_map to an address in system memo

Re: [PATCH v5 3/3] drm/xe: Add WA BB to capture active context utilization

2025-05-20 Thread Lucas De Marchi
T | MI_SRM_ADD_CS_OFFSET); xe_map_write32(xe, cmd, ENGINE_ID(0).addr); ... maybe we could add an iosys_map_wr_many() that would be a variadic version with offset incr and hopefully the check for is_iomem in a single place. Another option would be a local buffer that we memcpy at the end. +Thomas Zimmerman

[PULL] drm-xe-fixes

2025-05-15 Thread Lucas De Marchi
not saving timestamp with lite restore enabled. Thanks, Lucas De Marchi The following changes since commit 82f2b0b97b36ee3fcddf0f0780a9a0825d52fec3: Linux 6.15-rc6 (2025-05-11 14:54:11 -0700) are available in the Git repository at: https://gitlab.freedesktop.org/drm/xe/kernel.git tags/drm-xe-

[PULL] drm-xe-fixes

2025-05-08 Thread Lucas De Marchi
Hi Dave and Sima, Here's the drm-xe-fixes for 6.15-rc6. drm-xe-fixes-2025-05-09: Driver Changes: - Prevent PF queue overflow - Hold all forcewake during mocs test - Remove GSC flush on reset path - Fix forcewake put on error path - Fix runtime warning when building without svm thanks Luc

Re: [PATCH] drm/gpusvm: remove unused pages pointer

2025-05-02 Thread Lucas De Marchi
On Tue, 22 Apr 2025 12:59:43 +0300, Dafna Hirschfeld wrote: > the pages pointer is not used, remove it > > Applied to drm-misc-next, thanks! [1/1] drm/gpusvm: remove unused pages pointer commit: a912b0c8b5eabd9b70dc24cc97a167eb7287a20a Best regards, -- Lucas De Marchi

[PULL] drm-xe-fixes

2025-05-01 Thread Lucas De Marchi
anges: - Eustall locking fix and disabling on VF - Documentation fix kernel version supporting hwmon entries - SVM fixes on error handling thanks Lucas De Marchi The following changes since commit b4432656b36e5cc1d50a1f2dc15357543add530e: Linux 6.15-rc4 (2025-04-27 15:19:23 -0700) are available i

Re: [PATCH v4 01/15] drm/i915/gt: Avoid using masked workaround for CCS_MODE setting

2025-04-23 Thread Lucas De Marchi
ll go through. bspec 46034 shows this register as a masked register: Access: Masked(R/W) and documentation for bits 31:16 shows the mask. Lucas De Marchi

Re: [PATCH v2 2/6] drm/i915/gt: Move CCS workaround to the correct section

2025-04-23 Thread Lucas De Marchi
*/ + if (!FIRST_CCS(engine)) the problem you'd face is that if you fix this macro to also include render, then you break it here. Lucas De Marchi + return; + + /* +* Wa_14019159160: This workaround, along with others, leads to +* significant challenges

Re: [PATCH v2 6/6] drm/i915/gt: Remove unused I915_ENGINE_FIRST_RENDER_COMPUTE flag

2025-04-23 Thread Lucas De Marchi
implemented the macro exclusively using CCS_MASK, so it only means compute and will skip applying the workarounds on platforms that don't have compute but have render. Lucas De Marchi Remove the flag definition and its assignment from intel_engine_setup(). Suggested-by: Lucas De Marchi Signed-o

Re: [PATCH v2 0/6] Remove I915_ENGINE_FIRST_RENDER_COMPUTE

2025-04-23 Thread Lucas De Marchi
". And yes, if unofficial support for PVC is desired, then that can't be done, but shifting it to be always on CCS would be wrong too. Lucas De Marchi

[PULL] drm-xe-fixes

2025-04-17 Thread Lucas De Marchi
unconditionally Thanks, Lucas De Marchi The following changes since commit 8ffd015db85fea3e15a77027fda6c02ced4d2444: Linux 6.15-rc2 (2025-04-13 11:54:49 -0700) are available in the Git repository at: https://gitlab.freedesktop.org/drm/xe/kernel.git tags/drm-xe-fixes-2025-04-18 for you to fetch changes

[PULL] drm-xe-fixes

2025-04-10 Thread Lucas De Marchi
Xe3 - Fix PM runtime get/put on sysfs files - Fix u64 division on 32b - Fix flickering due to missing L3 invalidations - Fix missing error code return thanks, Lucas De Marchi The following changes since commit 0af2f6be1b4281385b618cb86ad946eded089ac8: Linux 6.15-rc1 (2025-04-06 13:11:33 -0700

Re: [PATCH 1/3] drm/panel: auo-a030jtn01: Fix compilation build

2025-04-08 Thread Lucas De Marchi
On Tue, Apr 08, 2025 at 04:57:44PM +0200, Maxime Ripard wrote: Hi Lucas, On Tue, Apr 08, 2025 at 09:34:22AM -0500, Lucas De Marchi wrote: On Tue, Apr 08, 2025 at 02:20:06PM +0200, Maxime Ripard wrote: > Commit 9d7d7c3c9a19 ("panel/auo-a030jtn01: Use refcounted allocation in &g

Re: [PATCH 04/10] panel/auo-a030jtn01: Use refcounted allocation in place of devm_kzalloc()

2025-04-08 Thread Lucas De Marchi
this thread before the patch series mentioned in IRC to fix it. The additional patch needed is probably something like in https://lore.kernel.org/dri-devel/nyrjnvctqnk6f3x5q7rlmy5nb7iopoti56pgh43zqknici5ms4@cibpldh7epra/ ? Lucas De Marchi

Re: [PATCH 1/3] drm/panel: auo-a030jtn01: Fix compilation build

2025-04-08 Thread Lucas De Marchi
alloc" [drivers/gpu/drm/panel/panel-auo-a030jtn01.ko] undefined! because that entire block is: #ifdef CONFIG_OF Based on the header, I think the intention wasn't to add those functions there, right? Moving it outside the ifdef at least fixes the build for me. Lucas De Marchi --

[PATCH drm-rerere] nightly.conf: Update to ssh.gitlab.freedesktop.org

2025-04-08 Thread Lucas De Marchi
ld be configured with the new repositories. Note that we are taking the opportunity to be explicit on the protocol, adding the ssh:// and dropping the entry without it. It's clearer and less entries to maintain. Signed-off-by: Lucas De Marchi --- nightly.conf | 25 ---

Re: [PATCH v1] drm/shmem-helper: Fix unsetting shmem vaddr while vmap refcount > 0

2025-04-03 Thread Lucas De Marchi
zero to fix the bug. Fixes: e1fc39a92332 ("drm/shmem-helper: Use refcount_t for vmap_use_count") Reported-by: Lucas De Marchi Closes: https://lore.kernel.org/dri-devel/20250403105053.788b0...@collabora.com/T/#m3dca6d81bedc8d6146a56b82694624fbc6fa4c96 Signed-off-by: Dmitry Osipenko T

Re: [PATCH v20 00/10] Add generic DRM-shmem memory shrinker (part 1)

2025-04-02 Thread Lucas De Marchi
pu on top) makes the warning go away. Any idea what's going on? Lucas De Marchi

[PULL] drm-xe-next-fixes

2025-03-27 Thread Lucas De Marchi
le pointer dereference after free Lucas De Marchi (2): drm/xe: Move survivability back to xe drm/xe: Set survivability mode before heci init Michal Wajdeczko (1): drm/xe/vf: Don't check CTC_MODE[0] if VF Vinay Belgaumkar (1): drm/xe: Apply Wa_16023105232 Yue Haibing (1):

  1   2   3   4   5   6   7   8   9   10   >