Re: [PATCH 07/11] drm/dp: Add drm_dp_uhbr_channel_coding_supported()

2024-03-26 Thread Manasi Navare
Reviewed-by: Manasi Navare Manasi On Tue, Mar 26, 2024 at 5:54 AM Nautiyal, Ankit K wrote: > > > On 3/21/2024 1:41 AM, Imre Deak wrote: > > Factor out a function to check for UHBR channel coding support used by a > > follow-up patch in the patchset. > > > > Cc

Re: [PATCH 01/11] drm/i915/dp: Fix DSC line buffer depth programming

2024-03-26 Thread Manasi Navare
change makes sense, just want to confirm if this applies to all platforms or any particular? With that clarification: Reviewed-by: Manasi Navare Regards Manasi On Tue, Mar 26, 2024 at 3:01 AM Nautiyal, Ankit K wrote: > > > On 3/21/2024 1:41 AM, Imre Deak wrote: > > Fix the calcula

Re: [PATCH v3] drm/dp_mst: Fix NULL deref in get_mst_branch_device_by_guid_helper()

2023-10-06 Thread Manasi Navare
Thanks Lukasz for the patch, looks like it is reviewed by. @dan...@ffwll.ch or @airl...@gmail.com , could any of you ack this as well, so I can go ahead and push this to drm-misc-fixes branch? Regards Manasi On Thu, Oct 5, 2023 at 6:35 AM Lukasz Majczak wrote: > wt., 26 wrz 2023 o 16:01

Re: [PATCH v4 6/6] drm/i915/dp_link_training: Emit a link-status=Bad uevent with trigger property

2023-09-01 Thread Manasi Navare
roperty_event instead of the earlier generic drm_kms_helper_connector_hotplug_event. This will need some changes in other userspaces that parse this else it will cause failures for other userspace once this lands. With all the above changes, Acked-by: Manasi Navare Regards Manasi > > Signe

Re: [PATCH 1/3] drm/i915/dp_link_training: Add a final failing state to link training fallback

2023-08-18 Thread Manasi Navare
ed as connected. > > Cc: Jani Nikula > Cc: Manasi Navare > Cc: Sean Paul > Signed-off-by: Gil Dekel > --- > drivers/gpu/drm/i915/display/intel_dp.c | 18 -- > 1 file changed, 16 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/displ

Re: [PATCH] drm/sysfs: Expose DRM connector id in each connector sysfs

2023-04-28 Thread Manasi Navare
Hi Won, Thanks for the patch, I have now merged to drm-misc-next Regards Manasi On Mon, Apr 17, 2023 at 3:52 PM Manasi Navare wrote: > > On Tue, Mar 28, 2023 at 6:45 PM Won Chung wrote: > > > > Expose DRM connector id in device sysfs so that we can map the connector >

Re: [PATCH v6] drm/sysfs: Link DRM connectors to corresponding Type-C connectors

2023-04-28 Thread Manasi Navare
i.kroge...@linux.intel.com/ > USB4: > https://lore.kernel.org/all/20220418175932.1809770-3-wonch...@google.com/ > So, we follow the same pattern in this patch. > > Signed-off-by: Won Chung > Acked-by: Heikki Krogerus > Reviewed-by: Manasi Navare > --- > Cha

Re: [PATCH v5] drm/sysfs: Link DRM connectors to corresponding Type-C connectors

2023-04-24 Thread Manasi Navare
"drm 1.1.0 20060810"); > > /** > @@ -353,9 +383,16 @@ int drm_sysfs_connector_add(struct drm_connector > *connector) > > connector->kdev = kdev; > > + if (dev_fwnode(kdev)) { > + r = component_add(kdev, _connector_ops); &

Re: [PATCH] drm/sysfs: Expose DRM connector id in each connector sysfs

2023-04-17 Thread Manasi Navare
which port is deriving which displays even with > a MST hub. Chromium patch for parsing DRM connector id from the kernel > is at http://crrev.com/c/4317207. > > Signed-off-by: Won Chung Exposing connector id in device sysfs looks good to me. Reviewed-by: Manasi Navare Manasi >

[PATCH v6 1/2] drm/vrr: Set VRR capable prop only if it is attached to connector

2022-02-24 Thread Manasi Navare
Signed-off-by: Manasi Navare --- drivers/gpu/drm/drm_connector.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c index a50c82bc2b2f..76a8c707c34b 100644 --- a/drivers/gpu/drm/drm_connector.c +++ b/drivers/gpu/drm/drm_connector.c

[PATCH v3] drm/atomic: Add the crtc to affected crtc only if uapi.enable = true

2021-10-04 Thread Manasi Navare
lle) Cc: Ville Syrjälä Cc: Simon Ser Cc: Pekka Paalanen Cc: Daniel Stone Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Manasi Navare --- drivers/gpu/drm/drm_atomic.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/

[PATCH v2] drm/atomic: Add the crtc to affected crtc only if uapi.enable = true

2021-10-04 Thread Manasi Navare
in review comments because the crtc gets stolen only after the atomic_check call. Cc: Ville Syrjälä Cc: Simon Ser Cc: Pekka Paalanen Cc: Daniel Stone Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Manasi Navare --- drivers/gpu/drm/drm_atomic.c | 6 -- 1 file changed, 4

[PATCH] drm/atomic: Add the crtc to affected crtc only if uapi.enable = true

2021-03-02 Thread Manasi Navare
: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Manasi Navare --- drivers/gpu/drm/drm_atomic.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c index 5b4547e0f775..d7acd6bbd97e 100644 --- a/drivers

[PATCH] Revert "drm/atomic: document and enforce rules around "spurious" EBUSY"

2021-02-09 Thread Manasi Navare
. Cc: Ville Syrjala Cc: Daniel Vetter Signed-off-by: Manasi Navare --- drivers/gpu/drm/drm_atomic.c | 29 - 1 file changed, 29 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c index b1efa9322be2..48b2262d69f6 100644 --- a/drivers

Re: [PATCH 1/2] drm/dp: Add PHY_TEST_PATTERN CP2520 Pattern 2 and 3

2020-07-21 Thread Manasi Navare
On Mon, Jul 20, 2020 at 05:40:10PM -0700, Almahallawy, Khaled wrote: > On Mon, 2020-07-20 at 17:07 -0700, Manasi Navare wrote: > > On Mon, Jul 20, 2020 at 04:41:25PM -0700, Khaled Almahallawy wrote: > > > Add the missing CP2520 pattern 2 and 3 phy compliance patterns >

Re: [PATCH 2/2] drm/i915/dp: TPS4 PHY test pattern compliance support

2020-07-20 Thread Manasi Navare
On Mon, Jul 20, 2020 at 04:41:26PM -0700, Khaled Almahallawy wrote: > Adding support for TPS4 (CP2520 Pattern 3) PHY pattern source tests. > > Signed-off-by: Khaled Almahallawy > --- > drivers/gpu/drm/i915/display/intel_dp.c | 14 -- > drivers/gpu/drm/i915/i915_reg.h | 4

Re: [PATCH 1/2] drm/dp: Add PHY_TEST_PATTERN CP2520 Pattern 2 and 3

2020-07-20 Thread Manasi Navare
On Mon, Jul 20, 2020 at 04:41:25PM -0700, Khaled Almahallawy wrote: > Add the missing CP2520 pattern 2 and 3 phy compliance patterns > > Signed-off-by: Khaled Almahallawy > --- > drivers/gpu/drm/drm_dp_helper.c | 2 +- > include/drm/drm_dp_helper.h | 4 +++- > 2 files changed, 4

[PATCH v4] Revert "drm/amd/display: Expose connector VRR range via debugfs"

2020-06-26 Thread Manasi Navare
-off-by: Bhanuprakash Modem Cc: Nicholas Kazlauskas Cc: Harry Wentland Cc: Alex Deucher Cc: Manasi Navare Cc: AMD gfx Reviewed-by: Nicholas Kazlauskas --- .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 20 --- 1 file changed, 20 deletions(-) diff --git a/drivers/gpu/drm/amd

Re: [v9 2/3] drm/debug: Expose connector VRR monitor range via debugfs

2020-06-25 Thread Manasi Navare
base > v8: > * Move debugfs node creation logic to DRM (Emil) > * Remove AMD specific logic (Emil) > v9: > * Seperate patch for removal of AMD specific logic (Manasi) > > Signed-off-by: Bhanuprakash Modem > Signed-off-by: Manasi Navare > Cc: Jani Ni

[PATCH v2 3/3] Revert "drm/amd/display: Expose connector VRR range via debugfs"

2020-06-24 Thread Manasi Navare
Modem Cc: Nicholas Kazlauskas Cc: Harry Wentland Cc: Alex Deucher Cc: Manasi Navare Cc: AMD gfx Reviewed-by: Nicholas Kazlauskas --- .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 20 --- 1 file changed, 20 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm

Re: [v9 2/3] drm/debug: Expose connector VRR monitor range via debugfs

2020-06-22 Thread Manasi Navare
DRM (Emil) > * Remove AMD specific logic (Emil) > v9: > * Seperate patch for removal of AMD specific logic (Manasi) > > Signed-off-by: Bhanuprakash Modem > Signed-off-by: Manasi Navare > Cc: Jani Nikula > Cc: Ville Syrjälä > Cc: Harry Wentland &g

Re: [Intel-gfx] [v1 3/3] Revert "drm/amd/display: Expose connector VRR range via debugfs"

2020-06-22 Thread Manasi Navare
gic should move to core DRM. > > > >This reverts commit 727962f030c23422a01e8b22d0f463815fb15ec4. > > > >Signed-off-by: Bhanuprakash Modem > >Cc: Nicholas Kazlauskas > >Cc: Harry Wentland > >Cc: Alex Deucher > >Cc: Manasi Navare > >Cc: AMD gfx >

Re: [Intel-gfx] [v6 1/3] drm/dp: DRM DP helper for reading Ignore MSA from DPCD

2020-06-19 Thread Manasi Navare
Thanks for the review, pushed to drm-misc Manasi On Sat, Jun 20, 2020 at 02:53:54AM +0530, Bhanuprakash Modem wrote: > From: Manasi Navare > > DP sink device sets the Ignore MSA bit in its > DP_DOWNSTREAM_PORT_COUNT register to indicate its ability to > ignore the MSA video ti

Re: [v8 3/3] drm/debug: Expose connector VRR monitor range via debugfs

2020-06-19 Thread Manasi Navare
> v5: > * Rename to vrr_range to match AMD debugfs > v6: > * Rebase (manasi) > v7: > * Fix cmpilation due to rebase > v8: > * Move debugfs node creation logic to DRM (Emil) > * Remove AMD specific logic (Emil) > > Signed-off-by: Bhanuprakash Modem > Signed-off-by

Re: [PATCH v6 1/3] drm/dp: DRM DP helper for reading Ignore MSA from DPCD

2020-06-18 Thread Manasi Navare
@Jani N, could you give an ACK on this if this looks okay, addressed your review comments regarding the name of the function. Else I have a r-b functionality wise so good to get merged? Regards Manasi On Fri, Jun 12, 2020 at 04:04:42PM -0700, Manasi Navare wrote: > DP sink device sets the Ign

Re: [PATCH v7 3/3] drm/i915/dp: Expose connector VRR monitor range via debugfs

2020-06-18 Thread Manasi Navare
On Tue, Jun 16, 2020 at 04:34:07PM +0100, Emil Velikov wrote: > On Mon, 15 Jun 2020 at 22:47, Manasi Navare wrote: > > > > On Mon, Jun 15, 2020 at 10:36:28PM +0100, Emil Velikov wrote: > > > Hi Manasi, > > > > > > On Sat, 13 Jun 2020 at 00:55, Manasi

Re: [PATCH v7 3/3] drm/i915/dp: Expose connector VRR monitor range via debugfs

2020-06-15 Thread Manasi Navare
On Mon, Jun 15, 2020 at 10:36:28PM +0100, Emil Velikov wrote: > Hi Manasi, > > On Sat, 13 Jun 2020 at 00:55, Manasi Navare wrote: > > > > From: Bhanuprakash Modem > > > > [Why] > > It's useful to know the min and max vrr range for IGT testing. > &g

[PATCH v7 3/3] drm/i915/dp: Expose connector VRR monitor range via debugfs

2020-06-12 Thread Manasi Navare
RR capable to display Yes or No (Manasi) * Fix indentation checkpatch errors (Manasi) Signed-off-by: Bhanuprakash Modem Signed-off-by: Manasi Navare Cc: Jani Nikula Cc: Ville Syrjälä Tested-by: Manasi Navare --- .../drm/i915/display/intel_display_debugfs.c | 22 ++- 1 file c

[PATCH v6 0/3] VRR capable attach prop in i915, DPCD helper, VRR debugfs

2020-06-12 Thread Manasi Navare
debugfs Aditya Swarup (1): drm/i915/dp: Attach and set drm connector VRR property Bhanuprakash Modem (1): drm/i915/dp: Expose connector VRR monitor range via debugfs Manasi Navare (1): drm/dp: DRM DP helper for reading Ignore MSA from DPCD .../drm/i915/display/intel_display_debugfs.c | 20

[PATCH v6 1/3] drm/dp: DRM DP helper for reading Ignore MSA from DPCD

2020-06-12 Thread Manasi Navare
that it is Adaptive sync capable. v3: * Fi the typo in commit message (Manasi) v2: * Rename to describe what the function does (Jani Nikula) Cc: Jani Nikula Cc: Ville Syrjälä Cc: Harry Wentland Cc: Nicholas Kazlauskas Signed-off-by: Manasi Navare Reviewed-by: Harry Wentland --- include/drm

[PATCH v6 2/3] drm/i915/dp: Attach and set drm connector VRR property

2020-06-12 Thread Manasi Navare
(Manasi) v4: * Rebase (Mansi) v3: * intel_dp_is_vrr_capable can be used for debugfs, make it non static (Manasi) v2: * Just set this in intel_dp_get_modes instead of new hook (Jani) Cc: Ville Syrjälä Cc: Jani Nikula Signed-off-by: Aditya Swarup Signed-off-by: Manasi Navare --- drivers/gpu/drm

[PATCH v6 3/3] drm/i915/dp: Expose connector VRR monitor range via debugfs

2020-06-12 Thread Manasi Navare
asi) * Fix indentation checkpatch errors (Manasi) Signed-off-by: Bhanuprakash Modem Signed-off-by: Manasi Navare Cc: Jani Nikula Cc: Ville Syrjälä Tested-by: Manasi Navare --- .../drm/i915/display/intel_display_debugfs.c | 20 +++ 1 file changed, 20 insertions(+) diff --git a/d

Re: [Intel-gfx] [PATCH] drm/i915/dp: DP PHY compliance for JSL

2020-06-12 Thread Manasi Navare
On Fri, Jun 12, 2020 at 10:21:31PM +0300, Ville Syrjälä wrote: > On Fri, Jun 12, 2020 at 12:12:25PM -0700, Manasi Navare wrote: > > On Fri, Jun 12, 2020 at 10:01:19PM +0300, Ville Syrjälä wrote: > > > On Fri, Jun 12, 2020 at 11:44:13AM -0700, Manasi Navare wrote: > > > &

Re: [Intel-gfx] [PATCH] drm/i915/dp: DP PHY compliance for JSL

2020-06-12 Thread Manasi Navare
On Fri, Jun 12, 2020 at 10:01:19PM +0300, Ville Syrjälä wrote: > On Fri, Jun 12, 2020 at 11:44:13AM -0700, Manasi Navare wrote: > > On Fri, Jun 12, 2020 at 09:36:37PM +0300, Ville Syrjälä wrote: > > > On Fri, Jun 12, 2020 at 11:25:42AM -0700, Manasi Navare wrote: > > > &

Re: [Intel-gfx] [PATCH] drm/i915/dp: DP PHY compliance for JSL

2020-06-12 Thread Manasi Navare
On Fri, Jun 12, 2020 at 09:36:37PM +0300, Ville Syrjälä wrote: > On Fri, Jun 12, 2020 at 11:25:42AM -0700, Manasi Navare wrote: > > On Fri, Jun 05, 2020 at 12:03:19AM +0300, Ville Syrjälä wrote: > > > On Thu, Jun 04, 2020 at 08:01:03PM +, Almahallawy, Khaled wrote: > >

Re: [Intel-gfx] [PATCH] drm/i915/dp: DP PHY compliance for JSL

2020-06-12 Thread Manasi Navare
On Thu, Jun 04, 2020 at 08:01:03PM +, Almahallawy, Khaled wrote: > On Thu, 2020-06-04 at 22:06 +0300, Ville Syrjälä wrote: > > On Thu, Jun 04, 2020 at 10:33:48AM +0530, Vidya Srinivas wrote: > > > Signed-off-by: Khaled Almahallawy > > > Signed-off-by: Vidya Srinivas > > > --- > > >

Re: [Intel-gfx] [PATCH] drm/i915/dp: DP PHY compliance for JSL

2020-06-12 Thread Manasi Navare
On Fri, Jun 05, 2020 at 12:03:19AM +0300, Ville Syrjälä wrote: > On Thu, Jun 04, 2020 at 08:01:03PM +, Almahallawy, Khaled wrote: > > On Thu, 2020-06-04 at 22:06 +0300, Ville Syrjälä wrote: > > > On Thu, Jun 04, 2020 at 10:33:48AM +0530, Vidya Srinivas wrote: > > > > Signed-off-by: Khaled

Re: [PATCH] drm: document how user-space should use link-status

2020-06-02 Thread Manasi Navare
ser-space and how it should > > > handle it. The logic described has been implemented in igt [1]. > > > > > > [1]: > > > https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/commit/fbe61f529737191d0920521946a575bd55f00fbe > > > > > > Signed

Re: [PATCH v5 3/3] drm/i915/dp: Expose connector VRR info via debugfs

2020-05-13 Thread Manasi Navare
r No (Manasi) > * Fix indentation checkpatch errors (Manasi) > > Signed-off-by: Bhanuprakash Modem > Signed-off-by: Manasi Navare > Cc: Jani Nikula > Cc: Ville Syrjälä > Tested-by: Manasi Navare > --- > .../drm/i915/display/intel_display_debugfs.c | 22 ++

[PATCH v5 3/3] drm/i915/dp: Expose connector VRR info via debugfs

2020-05-12 Thread Manasi Navare
ndentation checkpatch errors (Manasi) Signed-off-by: Bhanuprakash Modem Signed-off-by: Manasi Navare Cc: Jani Nikula Cc: Ville Syrjälä Tested-by: Manasi Navare --- .../drm/i915/display/intel_display_debugfs.c | 22 ++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/d

[PATCH v5 2/3] drm/i915/dp: Attach and set drm connector VRR property

2020-05-12 Thread Manasi Navare
(Manasi) v4: * Rebase (Mansi) v3: * intel_dp_is_vrr_capable can be used for debugfs, make it non static (Manasi) v2: * Just set this in intel_dp_get_modes instead of new hook (Jani) Cc: Ville Syrjälä Cc: Jani Nikula Signed-off-by: Aditya Swarup Signed-off-by: Manasi Navare --- drivers/gpu/drm

[PATCH v5 1/3] drm/dp: DRM DP helper for reading Ignore MSA from DPCD

2020-05-12 Thread Manasi Navare
that it is Adaptive sync capable. v3: * Fi the typo in commit message (Manasi) v2: * Rename to describe what the function does (Jani Nikula) Cc: Jani Nikula Cc: Ville Syrjälä Cc: Harry Wentland Cc: Nicholas Kazlauskas Signed-off-by: Manasi Navare Reviewed-by: Harry Wentland --- include/drm

Re: [Intel-gfx] [PATCH] drm/edid: Fix off-by-one in DispID DTD pixel clock

2020-04-23 Thread Manasi Navare
> References: https://gitlab.freedesktop.org/drm/intel/-/issues/27 > Signed-off-by: Ville Syrjälä Makes total sense, Reviewed-by: Manasi Navare Manasi > --- > drivers/gpu/drm/drm_edid.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/driver

[PATCH v4 2/3] drm/i915/dp: Attach and set drm connector VRR property

2020-04-13 Thread Manasi Navare
(Manasi) v2: * Just set this in intel_dp_get_modes instead of new hook (Jani) Cc: Ville Syrjälä Cc: Jani Nikula Signed-off-by: Aditya Swarup Signed-off-by: Manasi Navare --- drivers/gpu/drm/i915/display/intel_dp.c | 24 drivers/gpu/drm/i915/display/intel_dp.h | 2 ++ 2

[PATCH v4 1/3] drm/dp: DRM DP helper for reading Ignore MSA from DPCD

2020-04-13 Thread Manasi Navare
that it is Adaptive sync capable. v3: * Fi the typo in commit message (Manasi) v2: * Rename to describe what the function does (Jani Nikula) Cc: Jani Nikula Cc: Ville Syrjälä Cc: Harry Wentland Cc: Nicholas Kazlauskas Signed-off-by: Manasi Navare Reviewed-by: Harry Wentland --- include/drm

[PATCH v4 3/3] drm/i915/dp: Expose connector VRR info via debugfs

2020-04-13 Thread Manasi Navare
kash Modem Signed-off-by: Manasi Navare Cc: Jani Nikula Cc: Ville Syrjälä Tested-by: Manasi Navare --- .../drm/i915/display/intel_display_debugfs.c | 22 ++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drive

[PATCH v3 3/3] drm/i915/dp: Expose connector VRR info via debugfs

2020-04-10 Thread Manasi Navare
x the typo in max_vfreq (Manasi) * Change the name of node to i915_vrr_info so we can add other vrr info for more debug info (Manasi) * Change the VRR capable to display Yes or No (Manasi) * Fix indentation checkpatch errors (Manasi) Signed-off-by: Bhanuprakash Modem Signed-off-by: Manasi Navare Cc: Jani

[PATCH v3 1/3] drm/dp: DRM DP helper for reading Ignore MSA from DPCD

2020-04-10 Thread Manasi Navare
that it is Adaptive sync capable. v3: * Fi the typo in commit message (Manasi) v2: * Rename to describe what the function does (Jani Nikula) Cc: Jani Nikula Cc: Ville Syrjälä Cc: Harry Wentland Cc: Nicholas Kazlauskas Signed-off-by: Manasi Navare Reviewed-by: Harry Wentland --- include/drm

[PATCH v3 2/3] drm/i915/dp: Attach and set drm connector VRR property

2020-04-10 Thread Manasi Navare
set this in intel_dp_get_modes instead of new hook (Jani) Cc: Ville Syrjälä Cc: Jani Nikula Signed-off-by: Aditya Swarup Signed-off-by: Manasi Navare --- drivers/gpu/drm/i915/display/intel_dp.c | 24 drivers/gpu/drm/i915/display/intel_dp.h | 2 ++ 2 files changed, 26

Re: [PATCH v2 2/2] drm/i915/dp: Attach and set drm connector VRR property

2020-03-30 Thread Manasi Navare
@Jani @Ville, this is the one we had discussed on IRC, could you take a look at this patch? Manasi On Tue, Mar 24, 2020 at 06:22:01PM -0700, Manasi Navare wrote: > From: Aditya Swarup > > This function sets the VRR property for connector based > on the platform support, EDID m

Re: Variable Refresh Rate & flickering screens

2020-03-25 Thread Manasi Navare
On Tue, Mar 17, 2020 at 09:25:33AM -0400, Harry Wentland wrote: > > > On 2020-03-17 5:08 a.m., Simon Ser wrote: > > On Thursday, March 12, 2020 3:43 PM, Harry Wentland > > wrote: > > > >> Not the main VRR expert and we're still discussing this internally but I > >> think it'll very much

[PATCH v2 2/2] drm/i915/dp: Attach and set drm connector VRR property

2020-03-24 Thread Manasi Navare
: Jani Nikula Signed-off-by: Aditya Swarup Signed-off-by: Manasi Navare --- drivers/gpu/drm/i915/display/intel_dp.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index ef2e06e292d5

[PATCH v2 1/2] drm/dp: DRM DP helper for reading Ignore MSA from DPCD

2020-03-24 Thread Manasi Navare
that it is Adaptive sync capable. v2: * Rename to describe what the function does (Jani Nikula) Cc: Jani Nikula Cc: Ville Syrjälä Cc: Harry Wentland Cc: Nicholas Kazlauskas Signed-off-by: Manasi Navare Reviewed-by: Harry Wentland --- include/drm/drm_dp_helper.h | 8 1 file changed

Re: [PATCH 1/3] drm/dp: DRM DP helper for reading Ignore MSA from DPCD

2020-03-19 Thread Manasi Navare
On Thu, Mar 19, 2020 at 11:59:38AM +0200, Jani Nikula wrote: > On Tue, 17 Mar 2020, Manasi Navare wrote: > > DP sink device sets the Ignore MSA bit in its > > DP_DOWNSTREAM_PORT_COUNT register to indicate its ability to > > ignore the MSA video timing paramaters and i

Re: [PATCH 2/3] drm: Create a drm_connector_helper_funcs hook for Adaptive Sync support

2020-03-19 Thread Manasi Navare
On Thu, Mar 19, 2020 at 12:07:37PM +0200, Jani Nikula wrote: > On Tue, 17 Mar 2020, Manasi Navare wrote: > > This patch adds a hook in drm_connector_helper_funcs to get the > > support of the driver for adaptive sync functionality. > > > > This can be called in the conn

Re: [PATCH 3/3] drm/i915/dp: intel_dp connector hook for VRR support

2020-03-19 Thread Manasi Navare
On Thu, Mar 19, 2020 at 12:14:28PM +0200, Jani Nikula wrote: > On Tue, 17 Mar 2020, Manasi Navare wrote: > > This defines the get_vrr_support hook for intel DP connector > > VRR support is set to true based on the DPCD ignore MSA and > > EDID monitor range > >

[PATCH 2/3] drm: Create a drm_connector_helper_funcs hook for Adaptive Sync support

2020-03-18 Thread Manasi Navare
Nikula Cc: Ville Syrjälä Cc: Harry Wentland Cc: Nicholas Kazlauskas Signed-off-by: Manasi Navare --- drivers/gpu/drm/drm_probe_helper.c | 4 include/drm/drm_modeset_helper_vtables.h | 16 2 files changed, 20 insertions(+) diff --git a/drivers/gpu/drm

[PATCH 1/3] drm/dp: DRM DP helper for reading Ignore MSA from DPCD

2020-03-18 Thread Manasi Navare
that it is Adaptive sync capable. Cc: Jani Nikula Cc: Ville Syrjälä Cc: Harry Wentland Cc: Nicholas Kazlauskas Signed-off-by: Manasi Navare --- include/drm/drm_dp_helper.h | 8 1 file changed, 8 insertions(+) diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h

[PATCH 3/3] drm/i915/dp: intel_dp connector hook for VRR support

2020-03-18 Thread Manasi Navare
This defines the get_vrr_support hook for intel DP connector VRR support is set to true based on the DPCD ignore MSA and EDID monitor range Cc: Jani Nikula Cc: Ville Syrjälä Cc: Harry Wentland Cc: Nicholas Kazlauskas Cc: Aditya Swarup Signed-off-by: Manasi Navare --- .../drm/i915/display

[PATCH v6 2/2] drm/edid: Add function to parse EDID descriptors for monitor range

2020-03-10 Thread Manasi Navare
: Kazlauskas Nicholas Signed-off-by: Manasi Navare Reviewed-by: Nicholas Kazlauskas --- drivers/gpu/drm/drm_edid.c | 44 + include/drm/drm_connector.h | 22 +++ 2 files changed, 66 insertions(+) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers

[PATCH v6 1/2] drm/edid: Name the detailed monitor range flags

2020-03-10 Thread Manasi Navare
This patch adds defines for the detailed monitor range flags as per the EDID specification. v2: * Rename the flags with DRM_EDID_ (Jani N) Suggested-by: Ville Syrjälä Cc: Ville Syrjälä Cc: Harry Wentland Cc: Clinton A Taylor Cc: Kazlauskas Nicholas Cc: Jani Nikula Signed-off-by: Manasi

Re: [PATCH v5 2/2] drm/edid: Add function to parse EDID descriptors for adaptive sync limits

2020-03-10 Thread Manasi Navare
On Tue, Mar 10, 2020 at 09:13:30PM +0200, Ville Syrjälä wrote: > On Tue, Mar 10, 2020 at 12:08:33PM -0700, Manasi Navare wrote: > > Hi Ville, > > > > Please find answers to your concerns below: > > > > On Mon, Mar 09, 2020 at 02:39:40PM -0700, Manasi Navare wro

Re: [PATCH v5 1/2] drm/edid: Name the detailed monitor range flags

2020-03-10 Thread Manasi Navare
On Tue, Mar 10, 2020 at 06:20:27PM +0200, Ville Syrjälä wrote: > On Mon, Mar 09, 2020 at 02:39:39PM -0700, Manasi Navare wrote: > > This patch adds defines for the detailed monitor > > range flags as per the EDID specification. > > > > v2: > > * Rename

Re: [PATCH v5 2/2] drm/edid: Add function to parse EDID descriptors for adaptive sync limits

2020-03-10 Thread Manasi Navare
Hi Ville, Please find answers to your concerns below: On Mon, Mar 09, 2020 at 02:39:40PM -0700, Manasi Navare wrote: > Adaptive Sync is a VESA feature so add a DRM core helper to parse > the EDID's detailed descritors to obtain the adaptive sync monitor range. > Store this info a

[PATCH v5 1/2] drm/edid: Name the detailed monitor range flags

2020-03-09 Thread Manasi Navare
This patch adds defines for the detailed monitor range flags as per the EDID specification. v2: * Rename the flags with DRM_EDID_ (Jani N) Suggested-by: Ville Syrjälä Cc: Ville Syrjälä Cc: Harry Wentland Cc: Clinton A Taylor Cc: Kazlauskas Nicholas Cc: Jani Nikula Signed-off-by: Manasi

[PATCH v5 2/2] drm/edid: Add function to parse EDID descriptors for adaptive sync limits

2020-03-09 Thread Manasi Navare
-by: Manasi Navare Reviewed-by: Nicholas Kazlauskas --- drivers/gpu/drm/drm_edid.c | 44 + include/drm/drm_connector.h | 22 +++ 2 files changed, 66 insertions(+) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index

Re: [Intel-gfx] [PATCH v4 1/2] drm/edid: Name the detailed monitor range flags

2020-03-09 Thread Manasi Navare
On Mon, Mar 09, 2020 at 10:35:52AM +0200, Jani Nikula wrote: > On Fri, 06 Mar 2020, Manasi Navare wrote: > > On Fri, Mar 06, 2020 at 12:30:46PM +0200, Jani Nikula wrote: > >> On Thu, 05 Mar 2020, Manasi Navare wrote: > >> > This patch adds defines for the detai

Re: [Intel-gfx] [PATCH v4 1/2] drm/edid: Name the detailed monitor range flags

2020-03-06 Thread Manasi Navare
On Fri, Mar 06, 2020 at 12:30:46PM +0200, Jani Nikula wrote: > On Thu, 05 Mar 2020, Manasi Navare wrote: > > This patch adds defines for the detailed monitor > > range flags as per the EDID specification. > > > > Suggested-by: Ville Syrjälä > > Cc: Ville Syrjäl

[PATCH v4 1/2] drm/edid: Name the detailed monitor range flags

2020-03-05 Thread Manasi Navare
This patch adds defines for the detailed monitor range flags as per the EDID specification. Suggested-by: Ville Syrjälä Cc: Ville Syrjälä Cc: Harry Wentland Cc: Clinton A Taylor Cc: Kazlauskas Nicholas Signed-off-by: Manasi Navare --- include/drm/drm_edid.h | 5 + 1 file changed, 5

[PATCH v4 2/2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2020-03-05 Thread Manasi Navare
function static (Harry, Jani) v2: * Change vmin and vmax to use u8 (Ville) * Dont store pixel clock since that is just a max dotclock and not related to VRR mode (Manasi) Cc: Ville Syrjälä Cc: Harry Wentland Cc: Clinton A Taylor Cc: Kazlauskas Nicholas Signed-off-by: Manasi Navare --- drivers

Re: [PATCH v3] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2020-03-04 Thread Manasi Navare
On Tue, Mar 03, 2020 at 03:42:12PM +0200, Ville Syrjälä wrote: > On Mon, Mar 02, 2020 at 04:08:59PM -0800, Manasi Navare wrote: > > Adaptive Sync is a VESA feature so add a DRM core helper to parse > > the EDID's detailed descritors to obtain the adaptive sync monitor range. >

[PATCH v3] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2020-03-02 Thread Manasi Navare
store pixel clock since that is just a max dotclock and not related to VRR mode (Manasi) Cc: Ville Syrjälä Cc: Harry Wentland Cc: Clinton A Taylor Cc: Kazlauskas, Nicholas Signed-off-by: Manasi Navare --- drivers/gpu/drm/drm_edid.c | 44 + include/drm

Re: [PATCH v2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2020-03-02 Thread Manasi Navare
On Mon, Mar 02, 2020 at 09:15:27AM -0500, Kazlauskas, Nicholas wrote: > On 2020-02-28 9:38 p.m., Manasi Navare wrote: > >On Fri, Feb 28, 2020 at 01:18:45PM -0800, Manasi Navare wrote: > >>On Thu, Jan 09, 2020 at 03:08:52PM +0200, Ville Syrjälä wrote: > >>>On Tue, Ja

Re: [PATCH v2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2020-02-28 Thread Manasi Navare
On Fri, Feb 28, 2020 at 01:18:45PM -0800, Manasi Navare wrote: > On Thu, Jan 09, 2020 at 03:08:52PM +0200, Ville Syrjälä wrote: > > On Tue, Jan 07, 2020 at 04:32:08PM -0800, Manasi Navare wrote: > > > Adaptive Sync is a VESA feature so add a DRM core helper to parse > &g

Re: [PATCH v2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2020-02-28 Thread Manasi Navare
On Thu, Jan 09, 2020 at 03:08:52PM +0200, Ville Syrjälä wrote: > On Tue, Jan 07, 2020 at 04:32:08PM -0800, Manasi Navare wrote: > > Adaptive Sync is a VESA feature so add a DRM core helper to parse > > the EDID's detailed descritors to obtain the adaptive sync monitor range. >

Re: [PATCH v2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2020-01-14 Thread Manasi Navare
On Tue, Jan 14, 2020 at 08:31:22AM -0500, Harry Wentland wrote: > Fixing Nick's email. > > On 2020-01-10 5:43 p.m., Manasi Navare wrote: > > On Thu, Jan 09, 2020 at 05:24:30PM +0200, Jani Nikula wrote: > >> On Tue, 07 Jan 2020, Manasi Navare wrote: > >>> Ad

Re: [PATCH v2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2020-01-14 Thread Manasi Navare
On Tue, Jan 14, 2020 at 03:07:56PM +0200, Ville Syrjälä wrote: > On Mon, Jan 13, 2020 at 04:39:00PM -0800, Manasi Navare wrote: > > Hi Ville, > > > > So the two major changes you would like to see here are: > > > > use version_greate

Re: [PATCH v2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2020-01-13 Thread Manasi Navare
? Manasi On Fri, Jan 10, 2020 at 03:17:43PM -0800, Manasi Navare wrote: > On Thu, Jan 09, 2020 at 03:08:52PM +0200, Ville Syrjälä wrote: > > On Tue, Jan 07, 2020 at 04:32:08PM -0800, Manasi Navare wrote: > > > Adaptive Sync is a VESA feature so add a DRM core helper to pars

Re: [PATCH v2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2020-01-10 Thread Manasi Navare
On Thu, Jan 09, 2020 at 03:08:52PM +0200, Ville Syrjälä wrote: > On Tue, Jan 07, 2020 at 04:32:08PM -0800, Manasi Navare wrote: > > Adaptive Sync is a VESA feature so add a DRM core helper to parse > > the EDID's detailed descritors to obtain the adaptive sync monitor range. >

Re: [PATCH v2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2020-01-10 Thread Manasi Navare
On Thu, Jan 09, 2020 at 05:24:30PM +0200, Jani Nikula wrote: > On Tue, 07 Jan 2020, Manasi Navare wrote: > > Adaptive Sync is a VESA feature so add a DRM core helper to parse > > the EDID's detailed descritors to obtain the adaptive sync monitor range. > > Store

Re: [PATCH v2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2020-01-08 Thread Manasi Navare
so I would leave the usage of this to you and Nicholas depending on what works better in your driver. Regards Manasi On Tue, Jan 07, 2020 at 04:32:08PM -0800, Manasi Navare wrote: > Adaptive Sync is a VESA feature so add a DRM core helper to parse > the EDID's detailed descritors

[PATCH v2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2020-01-07 Thread Manasi Navare
Signed-off-by: Manasi Navare --- drivers/gpu/drm/drm_edid.c | 51 + include/drm/drm_connector.h | 22 include/drm/drm_edid.h | 2 ++ 3 files changed, 75 insertions(+) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c

Re: [PATCH v3 1/9] drm/amd/display: Align macro name as per DP spec

2020-01-03 Thread Manasi Navare
Harry, Jani - Since this also updates the AMD driver file, should this be merged through AMD tree and then backmerged to drm-misc ? Manasi On Mon, Dec 30, 2019 at 09:45:15PM +0530, Animesh Manna wrote: > [Why]: > Aligh with DP spec wanted to follow same naming convention. > > [How]: > Changed

Re: [Intel-gfx] [PATCH v3 8/9] drm/i915/dp: Update the pattern as per request

2020-01-03 Thread Manasi Navare
On Thu, Jan 02, 2020 at 11:23:14AM +0200, Jani Nikula wrote: > On Mon, 30 Dec 2019, Animesh Manna wrote: > > As per request from DP phy compliance test few special > > test pattern need to set by source. Added function > > to set pattern in DP_COMP_CTL register. It will be > > called along with

Re: [PATCH v3 3/9] drm/i915/dp: Move vswing/pre-emphasis adjustment calculation

2020-01-03 Thread Manasi Navare
On Thu, Jan 02, 2020 at 03:56:09PM +0530, Manna, Animesh wrote: > On 02-01-2020 14:48, Jani Nikula wrote: > >On Mon, 30 Dec 2019, Animesh Manna wrote: > >>vswing/pre-emphasis adjustment calculation is needed in processing > >>of auto phy compliance request other than link training, so moved >

Re: [PATCH v2 2/9] drm/amd/display: Fix compilation issue.

2019-12-18 Thread Manasi Navare
On Wed, Dec 18, 2019 at 09:43:49PM +0530, Manna, Animesh wrote: > > On 18-12-2019 21:12, Harry Wentland wrote: > >On 2019-12-18 10:13 a.m., Animesh Manna wrote: > >>[Why]: > >>Aligh with DP spec wanted to follow same naming convention. > >> > >>[How]: > >>Changed the macro name of the dpcd

Re: [PATCH 1/2] drm: Handle connector tile support only for modes that match tile size

2019-12-17 Thread Manasi Navare
On Wed, Dec 11, 2019 at 01:24:32PM -0800, Manasi Navare wrote: > DRM Fb driver expects multiple CRTCs if it sees connector->has_tile > is set, but we need to handle tile support and look for multiple CRTCs > only for the modes that match the tile size. The other modes shou

Re: [PATCH 1/1] drm/dp: get/set phy compliance pattern

2019-12-11 Thread Manasi Navare
Did you look at the build failure here? The build fails for amdgpu that uses the old #define of DP_TEST_PHY_PATTERN So you will have to send a patch for the amdgpu wherever they are using the older #define along with this with correct explanation that name changed to match the spec. Manasi On

Re: [PATCH 1/1] drm/dp: get/set phy compliance pattern

2019-12-11 Thread Manasi Navare
On Mon, Nov 18, 2019 at 11:55:55PM +0530, Animesh Manna wrote: > During phy compliance auto test mode source need to read > requested test pattern from sink through DPCD. After processing > the request source need to set the pattern. So set/get method > added in drm layer as it is DP protocol.

[PATCH 1/2] drm: Handle connector tile support only for modes that match tile size

2019-12-11 Thread Manasi Navare
dds the check to match the tile size with requested mode to handle the tile support. Cc: Ville Syrjälä Cc: Maarten Lankhorst Cc: Jani Nikula Cc: Dave Airlie Signed-off-by: Manasi Navare --- drivers/gpu/drm/drm_fb_helper.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/

[PATCH 2/2] drm/fbdev: Fallback to non tiled mode if all tiles not present

2019-12-11 Thread Manasi Navare
is pruned (Dave) v1: * Just handle the 1st connector hotplug case * v1 Reviewed-by: Dave Airlie Bugzilla: https://gitlab.freedesktop.org/drm/intel/issues/5 Suggested-by: Ville Syrjälä Suggested-by: Dave Airlie Cc: Ville Syrjälä Cc: Dave Airlie Signed-off-by: Manasi Navare Reviewed-by: Dave

[PATCH 0/5] DRM and i915 fixes to handle hotplug/unplug for 8K tiled displays

2019-12-10 Thread Manasi Navare
: Unplug master/slave: It does a full modeset and displays next lower mode Case5: Hotplug second port back in: It now does a full modeset again to display full 8K Manasi Navare (5): drm: Handle connector tile support only for modes that match tile size drm/fbdev: Fallback to non tiled mode if all

[PATCH 5/5] drm/i915/dp: Disable Port sync mode correctly on teardown

2019-12-10 Thread Manasi Navare
("drm/i915/display/icl: Disable transcoder port sync as part of crtc_disable() sequence") Signed-off-by: Manasi Navare --- drivers/gpu/drm/i915/display/intel_display.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drive

[PATCH 4/5] drm/i915/dp: Make port sync mode assignments only if all tiles present

2019-12-10 Thread Manasi Navare
://gitlab.freedesktop.org/drm/intel/issues/5 Cc: Ville Syrjälä Signed-off-by: Manasi Navare --- drivers/gpu/drm/i915/display/intel_display.c | 28 ++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display

[PATCH 2/5] drm/fbdev: Fallback to non tiled mode if all tiles not present

2019-12-10 Thread Manasi Navare
is pruned (Dave) v1: * Just handle the 1st connector hotplug case * v1 Reviewed-by: Dave Airlie Bugzilla: https://gitlab.freedesktop.org/drm/intel/issues/5 Suggested-by: Ville Syrjälä Suggested-by: Dave Airlie Cc: Ville Syrjälä Cc: Dave Airlie Signed-off-by: Manasi Navare Reviewed-by: Dave

[PATCH 1/5] drm: Handle connector tile support only for modes that match tile size

2019-12-10 Thread Manasi Navare
dds the check to match the tile size with requested mode to handle the tile support. Cc: Ville Syrjälä Cc: Maarten Lankhorst Cc: Jani Nikula Cc: Dave Airlie Signed-off-by: Manasi Navare --- drivers/gpu/drm/drm_fb_helper.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/

[PATCH 3/5] drm/i915/dp: Make sure all tiled connectors get added to the state with full modeset

2019-12-10 Thread Manasi Navare
Syrjälä Cc: Ville Syrjälä Cc: José Roberto de Souza Bugzilla: https://gitlab.freedesktop.org/drm/intel/issues/5 Signed-off-by: Manasi Navare --- drivers/gpu/drm/i915/display/intel_display.c | 78 1 file changed, 78 insertions(+) diff --git a/drivers/gpu/drm/i915/display

Re: [CI v2] drm/fbdev: Fallback to non tiled mode if all tiles not present

2019-11-17 Thread Manasi Navare
Pushed tod rm-misc-next, thanks a lot Dave all the feedback and reviews. Regards Manasi On Wed, Nov 13, 2019 at 02:29:52PM -0800, Manasi Navare wrote: > In case of tiled displays, if we hotplug just one connector, > fbcon currently just selects the preferred mode and if it is > t

[CI v2] drm/fbdev: Fallback to non tiled mode if all tiles not present

2019-11-13 Thread Manasi Navare
hotplug case * v1 Reviewed-by: Dave Airlie Suggested-by: Ville Syrjälä Suggested-by: Dave Airlie Cc: Ville Syrjälä Cc: Dave Airlie Signed-off-by: Manasi Navare Reviewed-by: Dave Airlie --- drivers/gpu/drm/drm_client_modeset.c | 70 1 file changed, 70 insertions

[PATCH v2] drm/fbdev: Fallback to non tiled mode if all tiles not present

2019-11-08 Thread Manasi Navare
hotplug case * v1 Reviewed-by: Dave Airlie Suggested-by: Ville Syrjälä Suggested-by: Dave Airlie Cc: Ville Syrjälä Cc: Dave Airlie Signed-off-by: Manasi Navare --- drivers/gpu/drm/drm_client_modeset.c | 70 1 file changed, 70 insertions(+) diff --git a/drivers/gpu

  1   2   3   4   5   6   7   >