Re: [PATCH v3 12/12] drm/bridge: tc358768: Attempt to fix DSI horizontal timings

2023-09-04 Thread Marcel Ziswiler
ion. > > Reviewed-by: Peter Ujfalusi > Signed-off-by: Tomi Valkeinen For the whole series: Tested-by: Marcel Ziswiler > --- >  drivers/gpu/drm/bridge/tc358768.c | 211 > +- >  1 file changed, 183 insertions(+), 28 deletions(-) > >

Re: [PATCH 3/4] drm/bridge: lt8912b: Manually disable HPD only if it was enabled

2023-09-04 Thread Marcel Ziswiler
this wrong call > Add the check to avoid wrongly calling drm_bridge_hpd_disable(). > > Fixes: 3b0a01a6a522 ("drm/bridge: lt8912b: Add hot plug detection") > Signed-off-by: Tomi Valkeinen For the whole series: Tested-by: Marcel Ziswiler > --- >  drivers/gpu/drm/bridge

Re: [PATCH v14 0/6] drm/imx: Introduce i.MX8qm/qxp DPU DRM

2023-08-22 Thread Marcel Ziswiler
Hi Liu Ying On Tue, 2023-08-22 at 05:36 +, Ying Liu wrote: > Hi, > > > On Friday, January 6, 2023 1:50 PM Ying Liu wrote: > > > > Hi, > > > > > > This is the v14 series to introduce i.MX8qm/qxp Display Processing Unit(DPU) > > DRM support. [snip] > This patch series has been submitted

Re: [PATCH v13 5/6] drm/imx: Introduce i.MX8qm/qxp DPU DRM

2023-01-04 Thread Marcel Ziswiler
Hi Liu Thank you very much! On Wed, 2022-10-19 at 10:02 +0800, Liu Ying wrote: > This patch introduces i.MX8qm/qxp Display Processing Unit(DPU) DRM support. > > DPU is comprised of two main components that include a blit engine for > 2D graphics accelerations(with composition support) and a

Re: [PATCH] drm: bridge: samsung-dsim: Add i.MX8M Plus support

2022-11-01 Thread Marcel Ziswiler
i.MX8M Mini/Nano one. > > Signed-off-by: Marek Vasut Reviewed-by: Marcel Ziswiler I also tried to test it on Verdin iMX8M Plus but so far I was unable to make it work. Either I am still missing some other pieces or I got the imx8mp.dtsi parts wrong. Do you have them available somew

Re: [PATCH v7 00/10] drm: bridge: Add Samsung MIPI DSIM bridge

2022-10-19 Thread Marcel Ziswiler
h 0008: input_bus_flags > > Patch 0009: document fsl,imx8mm-mipi-dsim > > Patch 0010: add i.MX8MM DSIM support > > Tested in Engicam i.Core MX8M Mini SoM. Thanks for this work! This also works great on Verdin iMX8M Mini together with the SN65DSI84-based Verdin

Re: [PATCH] drm/bridge: dw-hdmi: use safe format when first in bridge chain

2022-01-17 Thread Marcel Ziswiler
Hi Neil Sorry, just some trivial spelling fixes. On Mon, 2022-01-17 at 15:17 +0100, Neil Armstrong wrote: > When the dw-hdmi bridge is in first place of the bridge chain, this > means there is now way no way > to select an input format of the dw-hdmi HW > component. > > Since introduction of

Re: [PATCH v1] drm: import DMA_BUF module namespace

2021-10-29 Thread Marcel Ziswiler
On Thu, 2021-10-28 at 20:45 +0200, Thomas Zimmermann wrote: > Hi > > Am 27.10.21 um 22:54 schrieb Marcel Ziswiler: > > Sali Thomas > > > > On Wed, 2021-10-27 at 20:30 +0200, Thomas Zimmermann wrote: > > > Hi, > > > > > > thanks for t

Re: [PATCH v1] drm: import DMA_BUF module namespace

2021-10-27 Thread Marcel Ziswiler
Sali Thomas On Wed, 2021-10-27 at 20:30 +0200, Thomas Zimmermann wrote: > Hi, > > thanks for the patch. You are very welcome. > Am 27.10.21 um 17:25 schrieb Marcel Ziswiler: > > From: Marcel Ziswiler > > > > Today's -next fails building arm64 defconfig as fo

Re: ERROR: modpost: module drm_cma_helper uses symbol dma_buf_vunmap from namespace DMA_BUF, but does not import it.

2021-10-27 Thread Marcel Ziswiler
On Wed, 2021-10-27 at 18:14 +0530, Naresh Kamboju wrote: > Regression found on arm64 gcc-10 and gcc-11 built with defconfig > Following build warnings / errors reported on linux next 20211027. > > metadata: >     git_describe: next-20211027 >     git_repo:

Re: [PATCH v6 00/14] Add some DRM bridge drivers support for i.MX8qm/qxp SoCs

2021-03-28 Thread Marcel Ziswiler
Hi Liu On Tue, 2021-03-23 at 17:09 +0800, Liu Ying wrote: > On Tue, 2021-03-23 at 01:03 +0000, Marcel Ziswiler wrote: > > Hi Liu > > > > Some further discrepancy with them binding examples: > > > > arch/arm64/boot/dts/freescale/imx8qxp.dtsi:335.9-36: Warning (re

Re: [PATCH v6 00/14] Add some DRM bridge drivers support for i.MX8qm/qxp SoCs

2021-03-23 Thread Marcel Ziswiler
Hi Liu I gave this a try however I believe I am still missing some piece as it throws the following during compilation of the device tree: arch/arm64/boot/dts/freescale/imx8qxp.dtsi:333.18-439.7: ERROR (phandle_references): /dpu@5618: Reference to non-existent node or label "dc0_irqsteer"

Re: [PATCH v6 01/14] media: uapi: Add some RGB bus formats for i.MX8qm/qxp pixel combiner

2021-03-23 Thread Marcel Ziswiler
On Wed, 2021-03-17 at 11:42 +0800, Liu Ying wrote: > This patch adds RGB666_1X30_CPADLO, RGB888_1X30_CPADLO, RGB666_1X36_CPADLO > and RGB888_1X36_CPADLO bus formats used by i.MX8qm/qxp pixel combiner. > The RGB pixels with padding low per component are transmitted on a 30-bit > input bus(10-bit

Re: [PATCH v6 05/14] dt-bindings: display: bridge: Add i.MX8qm/qxp display pixel link binding

2021-03-23 Thread Marcel Ziswiler
On Wed, 2021-03-17 at 11:42 +0800, Liu Ying wrote: > This patch adds bindings for i.MX8qm/qxp display pixel link. > > Reviewed-by: Rob Herring > Signed-off-by: Liu Ying > --- > v5->v6: > * No change. > > v4->v5: > * No change. > > v3->v4: > * No change. > > v2->v3: > * Add Rob's R-b tag. >

Re: [PATCH v6 03/14] dt-bindings: display: bridge: Add i.MX8qm/qxp pixel combiner binding

2021-03-23 Thread Marcel Ziswiler
On Wed, 2021-03-17 at 11:42 +0800, Liu Ying wrote: > This patch adds bindings for i.MX8qm/qxp pixel combiner. > > Reviewed-by: Rob Herring > Signed-off-by: Liu Ying > --- > v5->v6: > * No change. > > v4->v5: > * No change. > > v3->v4: > * No change. > > v2->v3: > * Add Rob's R-b tag. > >

Re: [PATCH v6 00/14] Add some DRM bridge drivers support for i.MX8qm/qxp SoCs

2021-03-23 Thread Marcel Ziswiler
Hi Liu Some further discrepancy with them binding examples: arch/arm64/boot/dts/freescale/imx8qxp.dtsi:335.9-36: Warning (reg_format): /dpu@5618:reg: property has invalid length (8 bytes) (#address-cells == 2, #size-cells == 2) arch/arm64/boot/dts/freescale/imx8qxp.dtsi:508.9-35: Warning

Re: [PATCH v2 3/3] dt-bindings: display: panel: add bindings for logic technologies displays

2020-01-20 Thread Marcel Ziswiler
On Wed, 2019-10-30 at 09:29 -0500, Rob Herring wrote: > On Sun, Oct 27, 2019 at 03:26:09PM +0100, Marcel Ziswiler wrote: > > From: Marcel Ziswiler > > > > Add bindings for the following 3 previously added display panels > > manufactured by Logic Technologies Limited: &

Re: [PATCH v2 3/3] dt-bindings: display: panel: add bindings for logic technologies displays

2020-01-20 Thread Marcel Ziswiler
Sorry, just noticed that this has not gone through yet. On Wed, 2019-10-30 at 09:28 -0500, Rob Herring wrote: > On Sun, Oct 27, 2019 at 03:26:09PM +0100, Marcel Ziswiler wrote: > > From: Marcel Ziswiler > > > > Add bindings for the following 3 previously added display pa

Re: [PATCH v3 2/3] drm/panel: simple: add display timings for logic technologies displays

2020-01-20 Thread Marcel Ziswiler
Hi Sam On Sun, 2020-01-19 at 23:47 +0100, Sam Ravnborg wrote: > Hi Marcel. > > On Sun, Jan 19, 2020 at 11:02:03PM +0100, Marcel Ziswiler wrote: > > From: Marcel Ziswiler > > > > Add display timings for the following 3 display panels manufactured > >

[PATCH v1 1/2] dt-bindings: add vendor prefix for logic technologies limited

2019-09-20 Thread Marcel Ziswiler
From: Marcel Ziswiler Add vendor prefix for Logic Technologies Limited [1] which is a Chinese display manufacturer e.g. distributed by German Endrich Bauelemente Vertriebs GmbH [2]. [1] https://logictechno.com/contact-us/ [2] https://www.endrich.com/isi50_isi30_tft-displays/lt170410-1whc_isi30

[PATCH v1 2/2] drm/panel: simple: add display timings for logic technologies displays

2019-09-20 Thread Marcel Ziswiler
From: Marcel Ziswiler Add display timings for the following 3 display panels manufactured by Logic Technologies Limited: - LT161010-2NHC e.g. as found in the Toradex Capacitive Touch Display 7" Parallel [1] - LT161010-2NHR e.g. as found in the Toradex Resistive Touch Display 7" P

Re: TK1: DRM, Nouveau and VIC

2018-12-11 Thread Marcel Ziswiler
Hi Thierry On Mon, 2018-12-10 at 12:00 +0100, Thierry Reding wrote: > On Mon, Dec 10, 2018 at 11:21:47AM +0100, Thierry Reding wrote: > > On Sat, Dec 08, 2018 at 02:54:45PM +0000, Marcel Ziswiler wrote: > > > Hi Thierry et al. > > > > > > I noticed that si

Re: TK1: DRM, Nouveau and VIC

2018-12-11 Thread Marcel Ziswiler
Hi Thierry On Mon, 2018-12-10 at 17:23 +0100, Thierry Reding wrote: Snip. > > Looks like with pci_disable_device() it may take a rather strange > > path... > > Yikes... it has no business at all calling pci_disable_device() on > Tegra. Unless if you happen to have a GPU plugged into the PCIe

Re: drm/nouveau: tegra: Call nouveau_drm_device_init()

2018-12-11 Thread Marcel Ziswiler
atform driver initialization was > left incomplete. Add a call to nouveau_drm_device_init() to make sure > all of the structures are properly initialized. > > Signed-off-by: Thierry Reding > Reviewed-by: Lyude Paul Tested-by: Marcel Ziswiler > --- > drivers/gpu/drm/nouv

Re: TK1: DRM, Nouveau and VIC

2018-12-11 Thread Marcel Ziswiler
Hi Thierry On Mon, 2018-12-10 at 11:21 +0100, Thierry Reding wrote: > On Sat, Dec 08, 2018 at 02:54:45PM +0000, Marcel Ziswiler wrote: > > Hi Thierry et al. > > > > I noticed that since commit 3dde5a2342cd ("ARM: tegra: Add VIC on > > Tegra124") graphics

TK1: DRM, Nouveau and VIC

2018-12-10 Thread Marcel Ziswiler
Hi Thierry et al. I noticed that since commit 3dde5a2342cd ("ARM: tegra: Add VIC on Tegra124") graphics on Apalis TK1 is broken. During boot it fails loading the vic firmware: [1.595824] tegra-vic 5434.vic: Direct firmware load for nvidia/tegra124/vic03_ucode.bin failed with error -2 [

[PATCH v2] drm/tegra: hdmi: probe deferral error reporting

2018-08-15 Thread Marcel Ziswiler
From: Marcel Ziswiler Actually report the error code from devm_regulator_get() unless it is just a probe deferral. Signed-off-by: Marcel Ziswiler --- Changes in v2: - Silence probe deferral as suggested by Lucas. - Fix line over 80 characters as reported by checkpatch. drivers/gpu/drm

Re: [PATCH] drm/tegra: hdmi: probe deferral error reporting

2018-07-24 Thread Marcel Ziswiler
On July 23, 2018 10:49:15 PM GMT+02:00, Lucas Stach wrote: >Am Freitag, den 20.07.2018, 09:55 +0200 schrieb Marcel Ziswiler: >> From: Marcel Ziswiler >> >> Actually report the error code from devm_regulator_get() which may as >> well just be a probe deferral. >

[PATCH] drm/tegra: hdmi: probe deferral error reporting

2018-07-23 Thread Marcel Ziswiler
From: Marcel Ziswiler Actually report the error code from devm_regulator_get() which may as well just be a probe deferral. Signed-off-by: Marcel Ziswiler --- drivers/gpu/drm/tegra/hdmi.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/tegra

Re: [PATCH] backlight: pwm_bl: Fix uninitialized variable

2018-07-19 Thread Marcel Ziswiler
On Wed, 2018-07-18 at 11:12 +0100, Daniel Thompson wrote: > On Wed, Jul 18, 2018 at 10:53:35AM +0100, Lee Jones wrote: > > On Wed, 18 Jul 2018, Marcel Ziswiler wrote: > > > > > On Wed, 2018-07-18 at 09:09 +0100, Lee Jones wrote: > > > > On Mon

Re: [PATCH] backlight: pwm_bl: Fix uninitialized variable

2018-07-19 Thread Marcel Ziswiler
On Wed, 2018-07-18 at 14:08 +0100, Lee Jones wrote: > On Wed, 18 Jul 2018, Marcel Ziswiler wrote: > > > On Wed, 2018-07-18 at 11:12 +0100, Daniel Thompson wrote: > > > On Wed, Jul 18, 2018 at 10:53:35AM +0100, Lee Jones wrote: > > > > On Wed, 1

Re: [PATCH] backlight: pwm_bl: Fix uninitialized variable

2018-07-19 Thread Marcel Ziswiler
. > > > > Fixes: 573fe6d1c25c ("backlight: pwm_bl: Linear interpolation > > between > > brightness-levels") > > Reported-by: Marcel Ziswiler > > Signed-off-by: Daniel Thompson > > Signed-off-by: Marcel Ziswiler > > This line is confusing.

Re: [GIT PULL] drm/tegra: Changes for v4.17-rc1

2018-03-22 Thread Marcel Ziswiler
On Mon, 2018-03-19 at 17:52 +0100, Thierry Reding wrote: > On Mon, Mar 19, 2018 at 02:32:08PM +0000, Marcel Ziswiler wrote: > > Hi Thierry > > > > On Mon, 2018-03-19 at 10:59 +0100, Thierry Reding wrote: > > > Hi Dave, > > > &

Re: [GIT PULL] drm/tegra: Changes for v4.17-rc1

2018-03-22 Thread Marcel Ziswiler
Hi Thierry On Mon, 2018-03-19 at 10:59 +0100, Thierry Reding wrote: > Hi Dave, > > The following changes since commit > 7928b2cbe55b2a410a0f5c1f154610059c57b1b2: > > Linux 4.16-rc1 (2018-02-11 15:04:29 -0800) > > are available in the Git repository at: > >

[PATCH v2] drm/tegra: dc: use correct format array for Tegra124.

2018-03-22 Thread Marcel Ziswiler
From: Stefan Agner <ste...@agner.ch> Use tegra124_(primary|overlay)_formats for Tegra124. Fixes: 511c7023cf23 ("drm/tegra: dc: Support more formats") Signed-off-by: Stefan Agner <ste...@agner.ch> Acked-by: Marcel Ziswiler <marcel.ziswi...@toradex.com> --- Chan

Re: [PATCH 3/3] drm/tegra: fb: Implement ->fb_mmap() callback

2018-02-08 Thread Marcel Ziswiler
t; mmap() creates a mapping that conflicts with DRM usage and causes a > hang > when the memory is accessed through the mapping. With that legacy Qt4e applications run just fine now on Apalis TK1 running Linux kernel 4.14.18. Thanks, Thierry! Tested-by: Marcel Ziswiler <marcel.ziswi...@torade

imx-drm: regression due to commit 503fe87bd0a8 ("gpu: ipu-v3: Fix imx-ipuv3-crtc module autoloading")

2016-05-17 Thread Marcel Ziswiler
Hi there On Fri, 2016-05-13 at 12:33 +0200, Lothar Waßmann wrote: > Hi, > > the commit 503fe87bd0a8 ("gpu: ipu-v3: Fix imx-ipuv3-crtc module > autoloading") > indeed fixes the autoloading issue, but completely breaks the driver > in > non-modular mode (at least with the parallel-display driver