Re: [PATCH 1/3] drm/omap: Pass along the format info from .fb_create() to drm_helper_mode_fill_fb_struct()

2025-08-05 Thread Mark Brown
On Tue, Aug 05, 2025 at 06:43:04PM +0300, Tomi Valkeinen wrote: > The patch description here sounds more like it's just refactoring the > code a bit, but if I understand correctly, it's fixing an issue that > cause a WARN? Yes, this has been causing a regression in my testing since before the mer

Re: [PATCH 1/3] drm/omap: Pass along the format info from .fb_create() to drm_helper_mode_fill_fb_struct()

2025-07-29 Thread Mark Brown
On Mon, Jul 28, 2025 at 01:16:01PM +0300, Imre Deak wrote: > Plumb the format info from .fb_create() all the way to > drm_helper_mode_fill_fb_struct() to avoid the redundant > lookup. Tested-by: Mark Brown signature.asc Description: PGP signature

Re: [PATCH v2 19/19] drm: Make passing of format info to drm_helper_mode_fill_fb_struct() mandatory

2025-07-25 Thread Mark Brown
On Fri, Jul 25, 2025 at 05:23:36PM +0300, Imre Deak wrote: > On Fri, Jul 25, 2025 at 02:36:31PM +0100, Mark Brown wrote: > > This regression is still present in today's -next, I've not seen any > > response to my report? > Looks like the following would fix it, c

Re: [PATCH v2 19/19] drm: Make passing of format info to drm_helper_mode_fill_fb_struct() mandatory

2025-07-25 Thread Mark Brown
On Tue, Jul 22, 2025 at 02:41:53PM +0100, Mark Brown wrote: > On Tue, Jul 01, 2025 at 12:07:22PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Now that everyone passes along the format info to > > drm_helper_mode_fill_fb_struct() we can make this behav

Re: [PATCH v2 2/3] ASoC: hdac_hdmi: Use dev_info on invalid ELD version

2025-07-23 Thread Mark Brown
On Tue, Jul 22, 2025 at 03:54:36PM -0400, Detlev Casanova wrote: > When disconnected, the ELD data cannot be read by the display driver, so > it just sets the data to 0. Please don't put patches for different subsystems into the same series if there's no dependencies, it just makes dependencies le

Re: [PATCH v2 19/19] drm: Make passing of format info to drm_helper_mode_fill_fb_struct() mandatory

2025-07-22 Thread Mark Brown
On Tue, Jul 01, 2025 at 12:07:22PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Now that everyone passes along the format info to > drm_helper_mode_fill_fb_struct() we can make this behaviour > mandatory and drop the extra lookup. This patch, which is in -next as 41ab92d35ccd2d66, appea

Re: next-20250702 kernel NULL pointer dereference adv7511_cec_register_volatile

2025-07-09 Thread Mark Brown
On Wed, Jul 09, 2025 at 01:26:02AM +0530, Naresh Kamboju wrote: > I am investigating this issue, > Planning to revert and re-build and test in a loop. > c871c199accb3 regmap: fix potential memory leak of regmap_bus > [ 11.087822] Call trace: > [ 11.094930] adv7511_cec_register_volatile+0xc/

Re: (subset) [PATCH 01/11] zynqmp: don't bother with debugfs_file_{get,put}() in proxied fops

2025-07-04 Thread Mark Brown
On Wed, 02 Jul 2025 22:14:08 +0100, Al Viro wrote: > When debugfs file has been created by debugfs_create_file_unsafe(), > we do need the file_operations methods to use debugfs_file_{get,put}() > to prevent concurrent removal; for files created by debugfs_create_file() > that is done in the wrapper

Re: [PATCH 0/6] Add few updates to the STM32 SPI driver

2025-06-25 Thread Mark Brown
On Mon, 16 Jun 2025 11:21:01 +0200, Clément Le Goffic wrote: > This series aims to improve the STM32 SPI driver in different areas. > It adds SPI_READY mode, fixes an issue raised by a kernel bot, > add the ability to use DMA-MDMA chaining for RX and deprecate an ST bindings > vendor property. > >

Re: [PATCH v6 10/10] drm/bridge: adv7511: switch to the HDMI connector helpers

2025-06-13 Thread Mark Brown
On Sat, May 17, 2025 at 04:59:46AM +0300, Dmitry Baryshkov wrote: > Rewrite the ADV7511 driver to use implementation provided by the DRM > HDMI connector framework, including the Audio and CEC bits. Drop the > in-bridge connector support and use drm_bridge_connector if the host > requires the conne

Re: [PATCH 14/20] ASoC: rockchip: i2s-tdm: switch to HWORD_UPDATE_CONST macro

2025-06-13 Thread Mark Brown
ATE_CONST. The const variant is chosen here because > some of the header defines are then used in initializers. Acked-by: Mark Brown signature.asc Description: PGP signature

Re: [PATCH v2] ASoC: hdmi-codec: wire up the .prepare callback also for SPDIF DAI ops

2025-04-09 Thread Mark Brown
On Sat, 29 Mar 2025 20:14:33 +0100, Martin Blumenstingl wrote: > Commit 2fef64eec23a ("ASoC: hdmi-codec: Add a prepare hook") added a > prepare implementation. Back then the new callback was only integrated > with hdmi_codec_i2s_dai_ops (which is used by the I2S input code-path). > It was not added

Re: [PATCH v2 4/4] arm64: dts: rockchip: Enable HDMI1 on rock-5b

2025-04-05 Thread Mark Brown
On Wed, Dec 11, 2024 at 01:06:17AM +0200, Cristian Ciocaltea wrote: > Add the necessary DT changes to enable the second HDMI output port on > Radxa ROCK 5B. > > While at it, switch the position of &vop_mmu and @vop to maintain the > alphabetical order. We're seeing failures in the Arm lab the IGT

Re: (subset) [PATCH v2 00/57] irqdomain: Cleanups and Documentation

2025-03-24 Thread Mark Brown
On Wed, 19 Mar 2025 10:28:53 +0100, Jiri Slaby (SUSE) wrote: > tl;dr if patches are agreed upon, I ask subsys maintainers to take the > respective ones via their trees (as they are split per subsys), so that > the IRQ tree can take only the rest. That would minimize churn/conflicts > during merges.

Re: (subset) [PATCH v2 00/12] arm64: dts: freescale: Add support for the GOcontroll Moduline Display

2025-03-14 Thread Mark Brown
On Wed, 26 Feb 2025 15:19:11 +0100, Maud Spierings wrote: > Add inital support for 2 variants of the Moduline Display controller. > This system is powered by the Ka-Ro Electronics tx8p-ml81 COM, which > features an imx8mp SoC. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/br

Re: (subset) [PATCH 0/9] Remove pcf50633

2025-03-11 Thread Mark Brown
On Tue, Mar 11, 2025 at 09:05:57PM +, Dr. David Alan Gilbert wrote: > * Mark Brown (broo...@kernel.org) wrote: > > [6/9] regulator: pcf50633-regulator: Remove > > commit: 248bc01138b11ff3af38c3b4a39cb8db7aae6eb6 > Thanks! > AlthoughI'd only tested this

Re: [PATCH 6/9] regulator: pcf50633-regulator: Remove

2025-03-11 Thread Mark Brown
drivers/regulator/pcf50633-regulator.c | 124 - > include/linux/mfd/pcf50633/core.h | 1 - Putting MFD changes into the subsystem changes just makes everything harder to apply, please keep things separate unless there's a strong need to keep everything integra

Re: (subset) [PATCH v2 0/9] Remove pcf50633

2025-03-11 Thread Mark Brown
On Tue, 11 Mar 2025 01:49:50 +, li...@treblig.org wrote: > The pcf50633 was used as part of the OpenMoko devices but > the support for its main chip was recently removed in: > commit 61b7f8920b17 ("ARM: s3c: remove all s3c24xx support") > > See https://lore.kernel.org/all/Z8z236h4B5A6Ki3D@gall

Re: (subset) [PATCH 0/9] Remove pcf50633

2025-03-11 Thread Mark Brown
On Sun, 09 Mar 2025 19:36:03 +, li...@treblig.org wrote: > The pcf50633 was used as part of the OpenMoko devices but > the support for its main chip was recently removed in: > commit 61b7f8920b17 ("ARM: s3c: remove all s3c24xx support") > > See https://lore.kernel.org/all/Z8z236h4B5A6Ki3D@gall

Re: (subset) [PATCH v3 00/15] rockchip: Add rk3562 SoC and evb support

2025-02-27 Thread Mark Brown
On Thu, 27 Feb 2025 19:18:58 +0800, Kever Yang wrote: > This patch set adds rk3562 SoC and its evb support. > > I have split out patches need driver change for different subsystem. > And all the modules with dt-binding document update in this patch set > do not need any driver change. I put them t

Re: [PATCH v3 00/16] Converge on using secs_to_jiffies() part two

2025-02-26 Thread Mark Brown
On Wed, Feb 26, 2025 at 12:38:51PM -0800, Andrew Morton wrote: > On Wed, 26 Feb 2025 11:29:53 +0000 Mark Brown wrote: > > Please don't combine patches for multiple subsystems into a single > > series if there's no dependencies between them, it just creates > >

Re: (subset) [PATCH v3 00/16] Converge on using secs_to_jiffies() part two

2025-02-26 Thread Mark Brown
On Tue, 25 Feb 2025 20:17:14 +, Easwar Hariharan wrote: > This is the second series (part 1*) that converts users of msecs_to_jiffies() > that > either use the multiply pattern of either of: > - msecs_to_jiffies(N*1000) or > - msecs_to_jiffies(N*MSEC_PER_SEC) > > where N is a constant or an e

Re: [PATCH v3 00/16] Converge on using secs_to_jiffies() part two

2025-02-26 Thread Mark Brown
On Tue, Feb 25, 2025 at 08:17:14PM +, Easwar Hariharan wrote: > This is the second series (part 1*) that converts users of msecs_to_jiffies() > that > either use the multiply pattern of either of: > - msecs_to_jiffies(N*1000) or > - msecs_to_jiffies(N*MSEC_PER_SEC) > > where N is a constant o

Re: On community influencing (was Re: [PATCH v8 2/2] rust: add dma coherent allocator abstraction.)

2025-02-19 Thread Mark Brown
On Fri, Feb 14, 2025 at 02:10:57AM -0500, Neal Gompa wrote: > On Mon, Feb 10, 2025 at 12:28 PM Mark Brown wrote: > > We do actually have some people using forges already, for example the > > SOF people do a bunch of their review on github and then turn that into > > patc

Re: On community influencing (was Re: [PATCH v8 2/2] rust: add dma coherent allocator abstraction.)

2025-02-10 Thread Mark Brown
On Sun, Feb 09, 2025 at 03:25:26AM -0500, Neal Gompa wrote: > On Friday, February 7, 2025 1:16:11 PM Eastern Standard Time Konstantin > Ryabitsev wrote: > > It is my goal to be able to give subsystems a way to use forges without it > > impacting how they interact with upstream or handle tree-wide

Re: [PATCH v3 1/1] regmap: Synchronize cache for the page selector

2025-02-03 Thread Mark Brown
On Mon, Feb 03, 2025 at 11:19:22AM +0200, Andy Shevchenko wrote: > Thank you, guys, for reporting an testing, but it seems the simple problem > to solve requires a lot of changes to be done without regressions > (this fix on fix makes a regression to those who have cache enabled), which > means th

Re: [PATCH v3 1/1] regmap: Synchronize cache for the page selector

2025-01-29 Thread Mark Brown
On Wed, Jan 29, 2025 at 06:50:57PM +0100, Marek Szyprowski wrote: > Bingo! This patch (on top of current linux-next) fixed the probe issue. > Feel free to add: > Reported-by: Marek Szyprowski > Tested-by: Marek Szyprowski > (although I'm not sure if this is a fix for the generic case or just

Re: [PATCH 13/16] spi: spi-imx: convert timeouts to secs_to_jiffies()

2025-01-29 Thread Mark Brown
On Tue, Jan 28, 2025 at 06:21:58PM +, Easwar Hariharan wrote: > Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced > secs_to_jiffies(). As the value here is a multiple of 1000, use > secs_to_jiffies() instead of msecs_to_jiffies to avoid the multiplicati

Re: [PATCH 12/16] spi: spi-fsl-lpspi: convert timeouts to secs_to_jiffies()

2025-01-29 Thread Mark Brown
On Tue, Jan 28, 2025 at 06:21:57PM +, Easwar Hariharan wrote: > Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced > secs_to_jiffies(). As the value here is a multiple of 1000, use > secs_to_jiffies() instead of msecs_to_jiffies to avoid the multiplicati

Re: [PATCH v2 0/5] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2025-01-24 Thread Mark Brown
On Fri, Jan 24, 2025 at 06:32:07PM +0200, Jarkko Sakkinen wrote: > Can we then agree that any CI changes can be sent untested to LKML if > a patch set needs to reflect on those? It's not reasonable to except > local runs Gitlab from individuals for patch sets. It makes our lives > more difficult,

Re: [PATCH v3 1/1] regmap: Synchronize cache for the page selector

2025-01-17 Thread Mark Brown
On Fri, Jan 17, 2025 at 04:30:59PM +0200, Andy Shevchenko wrote: > On Fri, Jan 17, 2025 at 04:09:58PM +0200, Andy Shevchenko wrote: > @@ -69,7 +69,7 @@ struct lt9611uxc { > static const struct regmap_range_cfg lt9611uxc_ranges[] = { > { > .name = "register_range", > -

Re: (subset) [PATCH v10 00/10] drm: add DRM HDMI Codec framework

2025-01-14 Thread Mark Brown
On Tue, Jan 14, 2025 at 03:45:15AM +0200, Dmitry Baryshkov wrote: > On Tue, 14 Jan 2025 at 00:16, Mark Brown wrote: > > [01/10] ASoC: hdmi-codec: pass data to get_dai_id too > > commit: a8e792d3f0bbecb87ab05e9592cadf0b178ab952 > > [02/10] ASoC: hdmi-codec: move no_c

Re: (subset) [PATCH v10 00/10] drm: add DRM HDMI Codec framework

2025-01-13 Thread Mark Brown
On Tue, 24 Dec 2024 03:47:52 +0200, Dmitry Baryshkov wrote: > While porting lt9611 DSI-to-HDMI bridge driver to use HDMI Connector > framework, I stumbled upon an issue while handling the Audio InfoFrames. > The HDMI codec callbacks weren't receiving the drm_atomic_state, so > there was no simple w

Re: [PATCH v2 1/3] ASoC: hdmi-codec: Add event handler for hdmi TX

2024-12-06 Thread Mark Brown
On Fri, Dec 06, 2024 at 03:39:15PM +, Jiaxin Yu (俞家鑫) wrote: > On Mon, 2024-12-02 at 13:16 +0000, Mark Brown wrote: > > On Sun, Dec 01, 2024 at 05:15:45PM +, Jiaxin Yu (俞家鑫) wrote: > > > So I want to ask if I can do it by just adding > > > SOC_DAPM

linux-next: manual merge of the drm-intel tree with the drm-intel-fixes tree

2024-12-03 Thread Mark Brown
Hi all, Today's linux-next merge of the drm-intel tree got a conflict in: drivers/gpu/drm/i915/display/intel_dsb.c between commit: ebd1e5faa72af ("drm/i915/dsb: Don't use indexed register writes needlessly") from the drm-intel-fixes tree and commit: ecba559a88ab8 ("drm/i915/dsb: Don't u

Re: [PATCH v5 2/9] ASoC: hdmi-codec: move no_capture_mute to struct hdmi_codec_pdata

2024-12-02 Thread Mark Brown
On Mon, Dec 02, 2024 at 02:29:55PM +0100, Maxime Ripard wrote: > On Mon, Dec 02, 2024 at 12:59:22PM +0000, Mark Brown wrote: > > On Mon, Dec 02, 2024 at 01:06:09PM +0100, Maxime Ripard wrote: > > > On Sun, Dec 01, 2024 at 02:44:06AM +0200, Dmitry Baryshkov wrote: > > >

Re: [PATCH v2 1/3] ASoC: hdmi-codec: Add event handler for hdmi TX

2024-12-02 Thread Mark Brown
On Sun, Dec 01, 2024 at 05:15:45PM +, Jiaxin Yu (俞家鑫) wrote: > So I want to ask if I can do it by just adding > SOC_DAPM_PIN_SWITCH("Speakers") and SOC_DAPM_PIN_SWITCH("HDMI")? > Correspondingly, dapm widget and route path need to be added. That is > "SND_SOC_DAPM_SPK("Speakers", NULL)/ SND_SO

Re: [PATCH v5 2/9] ASoC: hdmi-codec: move no_capture_mute to struct hdmi_codec_pdata

2024-12-02 Thread Mark Brown
On Mon, Dec 02, 2024 at 01:06:09PM +0100, Maxime Ripard wrote: > On Sun, Dec 01, 2024 at 02:44:06AM +0200, Dmitry Baryshkov wrote: > > The no_capture_mute flag might differ from platform to platform, > > especially in the case of the wrapping implementations, like the > I appreciate it might be a

Re: [PATCH] Documentation/CoC: spell out enforcement for unacceptable behaviors

2024-11-12 Thread Mark Brown
On Mon, Nov 11, 2024 at 02:50:45PM -0700, Shuah Khan wrote: > On 11/11/24 13:07, Simona Vetter wrote: > > Personal take, but I think a forced public apology as the primary or at > > least initial coc enforcement approach is one of the worst. ... > This document isn't intended to be a complete su

Re: [PATCH RFC v2 2/7] ASoC: hdmi-codec: move no_capture_mute to struct hdmi_codec_pdata

2024-11-01 Thread Mark Brown
t; in struct hdmi_codec_pdata. Acked-by: Mark Brown signature.asc Description: PGP signature

Re: [PATCH v6 01/12] spi: add driver for intel graphics on-die spi device

2024-09-25 Thread Mark Brown
On Wed, Sep 25, 2024 at 12:31:34PM +, Usyskin, Alexander wrote: > > It's locking/refcounting stuff that looks nothing like any other SPI > > controller driver. Even if it works it's obviously fragile since the > > driver does surprising things which break assumptions that will be made > > by

Re: [PATCH v6 01/12] spi: add driver for intel graphics on-die spi device

2024-09-23 Thread Mark Brown
On Sat, Sep 21, 2024 at 01:00:52PM +, Winkler, Tomas wrote: > > On Thu, Sep 19, 2024 at 09:54:24AM +, Winkler, Tomas wrote: > > > > On Mon, Sep 16, 2024 at 04:49:17PM +0300, Alexander Usyskin wrote: > > Just do normal open coded allocations, the reference counting is just > > obscure. > T

Re: [PATCH v6 04/12] spi: intel-dg: spi register with mtd

2024-09-19 Thread Mark Brown
On Thu, Sep 19, 2024 at 10:01:06AM +, Winkler, Tomas wrote: > > On Mon, Sep 16, 2024 at 04:49:20PM +0300, Alexander Usyskin wrote: > > > +static int intel_dg_spi_write(struct mtd_info *mtd, loff_t to, size_t > > > len, > > > + size_t *retlen, const u_char *buf) { > > > +

Re: [PATCH v6 02/12] spi: intel-dg: implement region enumeration

2024-09-19 Thread Mark Brown
On Thu, Sep 19, 2024 at 09:55:54AM +, Winkler, Tomas wrote: > > On Mon, Sep 16, 2024 at 04:49:18PM +0300, Alexander Usyskin wrote: > > > In intel-dg spi, there is no access to the spi controller, the > > > information is extracted from the descriptor region. > > Which information? I can't te

Re: [PATCH v6 01/12] spi: add driver for intel graphics on-die spi device

2024-09-19 Thread Mark Brown
On Thu, Sep 19, 2024 at 09:54:24AM +, Winkler, Tomas wrote: > > On Mon, Sep 16, 2024 at 04:49:17PM +0300, Alexander Usyskin wrote: > > > @@ -0,0 +1,142 @@ > > > +// SPDX-License-Identifier: GPL-2.0 > > > +/* > > > + * Copyright(c) 2019-2024, Intel Corporation. All rights reserved. > > > + */

Re: [PATCH v6 00/12] spi: add driver for Intel discrete graphics

2024-09-19 Thread Mark Brown
On Thu, Sep 19, 2024 at 06:56:39AM +, Usyskin, Alexander wrote: > > On Mon, Sep 16, 2024 at 04:49:16PM +0300, Alexander Usyskin wrote: > > As far as I can tell this does not actually provide a SPI driver, there > > is no call to any SPI API that I've noticed here. The SPI framework > > does h

Re: [PATCH v6 00/12] spi: add driver for Intel discrete graphics

2024-09-18 Thread Mark Brown
On Mon, Sep 16, 2024 at 04:49:16PM +0300, Alexander Usyskin wrote: > Add driver for access to Intel discrete graphics card > internal SPI device. > Expose device on auxiliary bus by i915 and Xe drivers and > provide spi driver to register this device with MTD framework. As far as I can tell this d

Re: [PATCH v6 04/12] spi: intel-dg: spi register with mtd

2024-09-18 Thread Mark Brown
On Mon, Sep 16, 2024 at 04:49:20PM +0300, Alexander Usyskin wrote: > From: Tomas Winkler > > Register the on-die spi device with the mtd subsystem. > Refcount spi object on _get and _put mtd callbacks. This is a MTD driver, it should be in drivers/mtd. > +static int intel_dg_spi_erase(struct m

Re: [PATCH v6 02/12] spi: intel-dg: implement region enumeration

2024-09-18 Thread Mark Brown
On Mon, Sep 16, 2024 at 04:49:18PM +0300, Alexander Usyskin wrote: > In intel-dg spi, there is no access to the spi controller, > the information is extracted from the descriptor region. Which information? I can't tell what this patch is supposed to do; as with the first patch this shouldn't be

Re: [PATCH v6 01/12] spi: add driver for intel graphics on-die spi device

2024-09-18 Thread Mark Brown
On Mon, Sep 16, 2024 at 04:49:17PM +0300, Alexander Usyskin wrote: > Add auxiliary driver for intel discrete graphics > on-die spi device. This doesn't actually do anything AFAICT? It doesn't register with any subsystem or anything. Please don't submit empty boilerplate like this, submit a driv

Re: (subset) [PATCH v7 00/16] Add audio support for the MediaTek Genio 350-evk board

2024-09-12 Thread Mark Brown
On Thu, Sep 12, 2024 at 03:51:00PM +0100, Lee Jones wrote: > On Wed, 04 Sep 2024, Mark Brown wrote: > > [03/16] dt-bindings: mfd: mediatek: Add codec property for MT6357 PMIC > > commit: 761cab667898d86c04867948f1b7aec1090be796 > Did you mean to hoover this up? It

Re: (subset) [PATCH v7 00/16] Add audio support for the MediaTek Genio 350-evk board

2024-09-06 Thread Mark Brown
On Fri, Sep 06, 2024 at 12:23:23PM -0700, Nathan Chancellor wrote: > On Fri, Sep 06, 2024 at 07:27:01PM +0100, Mark Brown wrote: > > Are these just warnings introduced by recent versions of the toolchains? > > These commits passed an x86 allmodconfig with GCC 12 at each step (I di

Re: (subset) [PATCH v7 00/16] Add audio support for the MediaTek Genio 350-evk board

2024-09-06 Thread Mark Brown
On Fri, Sep 06, 2024 at 07:27:04PM +0100, Mark Brown wrote: > These commits passed an x86 allmodconfig with GCC 12 at each step (I did > catch one warning there with another patch in the series that didn't get > applied) and 0day didn't say anything at any point. Oh, actu

Re: (subset) [PATCH v7 00/16] Add audio support for the MediaTek Genio 350-evk board

2024-09-06 Thread Mark Brown
On Fri, Sep 06, 2024 at 11:03:48AM -0700, Nathan Chancellor wrote: > I am seeing several warnings/errors from both GCC and Clang with > ARCH=arm64 allmodconfig after this series appeared in next-20240906. > As far as I can tell, they appear to agree. I wondered how this was not > caught during the

Re: (subset) [PATCH v7 00/16] Add audio support for the MediaTek Genio 350-evk board

2024-09-04 Thread Mark Brown
On Mon, 22 Jul 2024 08:53:29 +0200, Alexandre Mergnat wrote: > This serie aim to add the following audio support for the Genio 350-evk: > - Playback > - 2ch Headset Jack (Earphone) > - 1ch Line-out Jack (Speaker) > - 8ch HDMI Tx > - Capture > - 1ch DMIC (On-board Digital Microphone) > - 1

Re: (subset) [PATCH v6 00/16] Add audio support for the MediaTek Genio 350-evk board

2024-09-04 Thread Mark Brown
On Wed, 19 Jun 2024 16:46:36 +0200, Alexandre Mergnat wrote: > This serie aim to add the following audio support for the Genio 350-evk: > - Playback > - 2ch Headset Jack (Earphone) > - 1ch Line-out Jack (Speaker) > - 8ch HDMI Tx > - Capture > - 1ch DMIC (On-board Digital Microphone) > - 1

Re: (subset) [PATCH v4 0/9] Add device tree for ArmSoM Sige 5 board

2024-09-03 Thread Mark Brown
On Tue, 03 Sep 2024 11:22:30 -0400, Detlev Casanova wrote: > Add the rk3576-armsom-sige5 device tree as well as its rk3576.dtsi base > and pinctrl information in rk3576-pinctrl.dtsi. > > The other commits add DT bindings documentation for the devices that > already work with the current correspond

Re: [PATCH v7 12/16] ASoC: codecs: add MT6357 support

2024-09-03 Thread Mark Brown
On Mon, Jul 22, 2024 at 08:53:41AM +0200, amerg...@baylibre.com wrote: > From: Nicolas Belin > > Add the support of MT6357 PMIC audio codec. This breaks the build: /build/stage/linux/sound/soc/codecs/mt6357.c: In function ‘mt6357_platform_driver_probe’: /build/stage/linux/sound/soc/codecs/mt63

Re: [PATCH] regulator: core: Stub devm_regulator_bulk_get_const() if !CONFIG_REGULATOR

2024-08-30 Thread Mark Brown
On Fri, 30 Aug 2024 07:35:12 -0700, Douglas Anderson wrote: > When adding devm_regulator_bulk_get_const() I missed adding a stub for > when CONFIG_REGULATOR is not enabled. Under certain conditions (like > randconfig testing) this can cause the compiler to reports errors > like: > > error: impli

Re: [PATCH v7 00/16] Add audio support for the MediaTek Genio 350-evk board

2024-08-14 Thread Mark Brown
On Wed, Aug 14, 2024 at 10:23:12AM +0200, Alexandre Mergnat wrote: > Simple gentle ping, the serie seems ready to be applied. Please don't send content free pings and please allow a reasonable time for review. People get busy, go on holiday, attend conferences and so on so unless there is some

Re: [PATCH v2 3/9] ASoC: test-component: use new of_graph functions

2024-08-13 Thread Mark Brown
On Fri, Aug 09, 2024 at 04:22:38AM +, Kuninori Morimoto wrote: > Current test-component.c is using for_each_endpoint_of_node() > for parsing "port", because there was no "port" base loop before. > It has been assuming 1 port has 1 endpoint here. Acked-by

Re: [PATCH 6/9] ASoC: audio-graph-card2: use new of_graph functions

2024-08-06 Thread Mark Brown
On Tue, Aug 06, 2024 at 04:58:46AM +, Kuninori Morimoto wrote: > Now we can use new port related functions for port parsing. Use it. Acked-by: Mark Brown signature.asc Description: PGP signature

Re: [PATCH 5/9] ASoC: audio-graph-card: use new of_graph functions

2024-08-06 Thread Mark Brown
On Tue, Aug 06, 2024 at 04:58:42AM +, Kuninori Morimoto wrote: > Now we can use new port related functions for port parsing. Use it. Acked-by: Mark Brown signature.asc Description: PGP signature

Re: [PATCH 4/9] ASoC: rcar_snd: use new of_graph functions

2024-08-06 Thread Mark Brown
On Tue, Aug 06, 2024 at 04:58:38AM +, Kuninori Morimoto wrote: > Now we can use new port related functions for port parsing. Use it. Acked-by: Mark Brown signature.asc Description: PGP signature

Re: [PATCH v5 00/12] spi: add driver for Intel discrete graphics

2024-07-29 Thread Mark Brown
On Mon, Jul 29, 2024 at 11:43:14AM +0300, Alexander Usyskin wrote: > V5: depend solely on AUXILIARY_BUS, not on COMPILE_TEST > disable spi driver on virtual function in Xe, no spi device there > V4: fix white-spaces > add check for discrete graphics missed in i915 intel_spi_fini > V3: re

Re: linux-next: build failure after merge of the drm

2024-06-28 Thread Mark Brown
On Fri, Jun 28, 2024 at 07:58:23PM +0200, Michal Wajdeczko wrote: > On 28.06.2024 19:03, Mark Brown wrote: > > /tmp/next/build/drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c: In function > > 'pf_get_threshold': > > /tmp/next/build/drivers/gpu/drm/xe/xe_gt_s

linux-next: build failure after merge of the drm

2024-06-28 Thread Mark Brown
Hi all, After merging the drm tree, today's linux-next build (x86_64 allmodconfig) failed like this: /tmp/next/build/drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c: In function 'pf_get_threshold': /tmp/next/build/drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c:1788:27: error: unused variable 'xe' [-Werr

linux-next: manual merge of the drm tree with the origin tree

2024-06-28 Thread Mark Brown
Hi all, Today's linux-next merge of the drm tree got a conflict in: drivers/gpu/drm/xe/xe_gt_idle.c between commit: 2470b141bfae2 ("drm/xe: move disable_c6 call") from the origin tree and commits: 6800e63cf97ba ("drm/xe: move disable_c6 call") 38e8c4184ea0e ("drm/xe: Enable Coarse Pow

linux-next: manual merge of the drm tree with the drm-fixes tree

2024-06-27 Thread Mark Brown
Hi all, Today's linux-next merge of the drm tree got a conflict in: drivers/gpu/drm/amd/pm/swsmu/inc/smu_types.h between commit: c223376b3019a ("drm/amd/swsmu: add MALL init support workaround for smu_v14_0_1") from the drm-fixes tree and commit: ec41bdd82e9b0 ("drm/amd/pm: Update PMFW

linux-next: manual merge of the drm tree with the origin tree

2024-06-27 Thread Mark Brown
Hi all, Today's linux-next merge of the drm tree got a conflict in: drivers/gpu/drm/amd/display/dc/hwss/dcn35/dcn35_init.c between commit: c03d770c0b014 ("drm/amd/display: Attempt to avoid empty TUs when endpoint is DPIA") from the origin tree and commit: 0127f0445f7c1 ("drm/amd/displa

linux-next: manual merge of the drm tree with the drm-fixes tree

2024-06-27 Thread Mark Brown
Hi all, Today's linux-next merge of the drm tree got a conflict in: drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c between commit: f6f49dda49db7 ("drm/amdgpu/atomfirmware: fix parsing of vram_info") from the drm-fixes tree and commit: 9a55c77978308 ("drm/amdgpu: fix getting vram info

Re: [PATCH v6 12/16] ASoC: codecs: add MT6357 support

2024-06-21 Thread Mark Brown
On Wed, Jun 19, 2024 at 04:46:48PM +0200, amerg...@baylibre.com wrote: > From: Nicolas Belin > > Add the support of MT6357 PMIC audio codec. This breaks an x86 allmodconfig build: /build/stage/linux/sound/soc/codecs/mt6357.c: In function ‘mt_delay_250_event’: /build/stage/linux/sound/soc/codecs

linux-next: manual merge of the drm tree with the drm-fixes tree

2024-06-21 Thread Mark Brown
Hi all, Today's linux-next merge of the drm tree got a conflict in: drivers/gpu/drm/amd/display/dc/hwss/dcn35/dcn35_init.c between commit: c03d770c0b014 ("drm/amd/display: Attempt to avoid empty TUs when endpoint is DPIA") from the drm-fixes tree and commits: 47745acc5e8dd ("drm/amd/di

Re: [PATCH v6 12/16] ASoC: codecs: add MT6357 support

2024-06-21 Thread Mark Brown
On Wed, Jun 19, 2024 at 04:46:48PM +0200, amerg...@baylibre.com wrote: > + /* gain default values*/ > + regmap_update_bits(priv->regmap, MT6357_AUDENC_ANA_CON0, > MT6357_AUDPREAMPLGAIN_MASK, > +UL_GAIN_0DB << MT6357_AUDPREAMPLGAIN_SFT); > + regmap_update_bits(p

Missing signoffs in the drm-next tree

2024-06-21 Thread Mark Brown
In today's drm tree commits 824a450c0d90a ("accel/habanalabs: gradual sleep in polling memory macro") fb0e9ebb93aa9 ("accel/habanalabs: move heartbeat work initialization to early init") ee6350c6c3300 ("accel/habanalabs: print timestamp of last PQ heartbeat on EQ heartbeat failure") 9948

Re: [PATCH v3 18/23] regulator: add s2dos05 regulator support

2024-06-19 Thread Mark Brown
On Wed, Jun 19, 2024 at 06:49:06PM +0300, Dzmitry Sankouski wrote: > вт, 18 июн. 2024 г. в 17:08, Mark Brown : > > On Tue, Jun 18, 2024 at 04:59:52PM +0300, Dzmitry Sankouski wrote: > > > +// SPDX-License-Identifier: GPL-2.0+ > > > +/* > > > + * s2dos05.

Re: [PATCH RESEND v5 00/16] Add audio support for the MediaTek Genio 350-evk board

2024-06-18 Thread Mark Brown
On Mon, Jun 17, 2024 at 10:05:37AM +0200, Alexandre Mergnat wrote: > On 14/06/2024 11:31, Mark Brown wrote: > > I seem to remember you had review comments that needed addressing from > > AngeloGioacchino, why resend without addressing those? > I don't see any comment: &g

Re: [PATCH v3 18/23] regulator: add s2dos05 regulator support

2024-06-18 Thread Mark Brown
On Tue, Jun 18, 2024 at 04:59:52PM +0300, Dzmitry Sankouski wrote: > index ..3c58a1bd2262 > --- /dev/null > +++ b/drivers/regulator/s2dos05-regulator.c > @@ -0,0 +1,362 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * s2dos05.c - Regulator driver for the Samsung s2dos05 > + * Pl

linux-next: manual merge of the drm tree with the drm-intel-fixes tree

2024-06-17 Thread Mark Brown
Hi all, Today's linux-next merge of the drm tree got conflicts in: drivers/gpu/drm/xe/xe_gt_idle.c drivers/gpu/drm/xe/xe_guc_pc.c between commits: 2470b141bfae2 ("drm/xe: move disable_c6 call") 7c877115da419 ("drm/xe/xe_gt_idle: use GT forcewake domain assertion") from the drm-intel-fi

Re: [PATCH RFC 2/5] ASoC: hdmi-codec: pass data to get_dai_id too

2024-06-17 Thread Mark Brown
On Sat, Jun 15, 2024 at 08:53:31PM +0300, Dmitry Baryshkov wrote: > The upcoming DRM connector HDMI codec implementation is going to use > codec-specific data in the .get_dai_id to get drm_connector. Pass data > to the callback, as it is done with other hdmi_codec_ops callbacks. Acked

Re: [PATCH RESEND v5 00/16] Add audio support for the MediaTek Genio 350-evk board

2024-06-14 Thread Mark Brown
On Fri, Jun 14, 2024 at 09:27:43AM +0200, Alexandre Mergnat wrote: > This serie aim to add the following audio support for the Genio 350-evk: > - Playback > - 2ch Headset Jack (Earphone) > - 1ch Line-out Jack (Speaker) > - 8ch HDMI Tx I seem to remember you had review comments that needed ad

Re: [PATCH v4 05/16] SoC: mediatek: mt8365: support audio clock control

2024-04-29 Thread Mark Brown
On Fri, Apr 26, 2024 at 07:22:34PM +0200, Alexandre Mergnat wrote: > Add audio clock wrapper and audio tuner control. Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the

Re: [PATCH v3 07/13] drm: Make drivers depends on DRM_DW_HDMI

2024-04-22 Thread Mark Brown
On Tue, Apr 02, 2024 at 04:43:46PM +0100, Mark Brown wrote: > On Wed, Mar 27, 2024 at 11:57:02AM +0100, Maxime Ripard wrote: > > > DRM_DW_HDMI has a number of dependencies that might not be enabled. > > However, drivers were used to selecting it while not enforcing t

Re: [PATCH 0/7] drm/display: Fix display helpers depends on fallouts

2024-04-15 Thread Mark Brown
On Mon, Apr 15, 2024 at 01:21:47PM +0200, Maxime Ripard wrote: > On Wed, Apr 10, 2024 at 07:06:39PM +0100, Mark Brown wrote: > > Is there any news on getting the rest of this merged? It's been more > > than a week now and the Designware display controllers are all still

Re: [PATCH 0/7] drm/display: Fix display helpers depends on fallouts

2024-04-10 Thread Mark Brown
On Wed, Apr 03, 2024 at 12:56:18PM +0200, Maxime Ripard wrote: > Hi, > > Here's a series addressing the various regressions that were reported > after the Kconfig rework for the DRM display helpers. > > Let me know what you think, > Maxime Is there any news on getting the rest of this merged? I

Re: [PATCH 0/7] drm/display: Fix display helpers depends on fallouts

2024-04-03 Thread Mark Brown
nfig so Reviewed-by: Mark Brown Between the arm64 defconfig update not applying on -next and unrelated breakage on arm I didn't actually do a proper test. signature.asc Description: PGP signature

Re: [PATCH v3 07/13] drm: Make drivers depends on DRM_DW_HDMI

2024-04-02 Thread Mark Brown
On Wed, Mar 27, 2024 at 11:57:02AM +0100, Maxime Ripard wrote: > DRM_DW_HDMI has a number of dependencies that might not be enabled. > However, drivers were used to selecting it while not enforcing the > DRM_DW_HDMI dependencies. > > This could result in Kconfig warnings (and further build breaka

Re: (subset) [PATCH v2 0/4] drm: xlnx: zynqmp: Add DP audio support

2024-03-26 Thread Mark Brown
On Tue, 19 Mar 2024 10:22:35 +0200, Tomi Valkeinen wrote: > Add DisplayPort audio support for Xilinx ZynqMP platforms. > > This depends on patch adding cyclic DMA mode for DPDMA driver: > > https://lore.kernel.org/all/20240228042124.3074044-3-vishal.sa...@amd.com/ > > If that patch is missing, s

Re: (subset) [PATCH 0/4] drm: xlnx: zynqmp: Add DP audio support

2024-03-26 Thread Mark Brown
On Tue, 12 Mar 2024 11:41:01 +0200, Tomi Valkeinen wrote: > Add DisplayPort audio support for Xilinx ZynqMP platforms. > > This depends on patch adding cyclic DMA mode for DPDMA driver: > > https://lore.kernel.org/all/20240228042124.3074044-3-vishal.sa...@amd.com/ > > If that patch is missing, s

Re: [PATCH 12/18] ASoC: codecs: mt6357: add MT6357 codec

2024-03-15 Thread Mark Brown
On Fri, Mar 15, 2024 at 06:36:19PM +0100, Alexandre Mergnat wrote: > On 15/03/2024 16:15, Mark Brown wrote: > > On Fri, Mar 15, 2024 at 04:05:21PM +0100, Alexandre Mergnat wrote: > > > > In the register. You only need to reset the gain to -40dB at the start > > > &

Re: [PATCH 12/18] ASoC: codecs: mt6357: add MT6357 codec

2024-03-15 Thread Mark Brown
On Fri, Mar 15, 2024 at 04:05:21PM +0100, Alexandre Mergnat wrote: > On 15/03/2024 15:30, Mark Brown wrote: > > > Let me know, when you change de gain to do a ramp down (start from user > > > gain > > > to gain=-40db), next time for the ramp up, how/where d

Re: [PATCH 00/18] Add audio support for the MediaTek Genio 350-evk board

2024-03-15 Thread Mark Brown
On Tue, Mar 12, 2024 at 09:58:05AM +0100, Alexandre Mergnat wrote: > I'm a bit lost for mixer-test and pcm-test. > Currently, I cross-compile the alsa lib project to be able to build the > tests and put it on my board. > I can execute it, but I still have 2 issues: > 1) I've a lot of missing mod

Re: [PATCH 12/18] ASoC: codecs: mt6357: add MT6357 codec

2024-03-15 Thread Mark Brown
On Fri, Mar 15, 2024 at 12:01:12PM +0100, Alexandre Mergnat wrote: > On 13/03/2024 18:23, Mark Brown wrote: > > On Tue, Mar 12, 2024 at 07:03:25PM +0100, Alexandre Mergnat wrote: > > > Actually you must save the values because the gain selected by the user > > > wil

Re: [PATCH 12/18] ASoC: codecs: mt6357: add MT6357 codec

2024-03-13 Thread Mark Brown
On Wed, Mar 13, 2024 at 06:11:50PM +0100, Alexandre Mergnat wrote: > On 26/02/2024 17:09, Mark Brown wrote: > > > index ..13e95c227114 > > > --- /dev/null > > > +++ b/sound/soc/codecs/mt6357.c > > > @@ -0,0 +1,1805 @@ >

Re: [PATCH 12/18] ASoC: codecs: mt6357: add MT6357 codec

2024-03-13 Thread Mark Brown
On Tue, Mar 12, 2024 at 07:03:25PM +0100, Alexandre Mergnat wrote: > On 26/02/2024 17:09, Mark Brown wrote: > > > + case MT6357_ZCD_CON2: > > > + regmap_read(priv->regmap, MT6357_ZCD_CON2, ®); > > > + priv->ana_gain[ANALOG_VOLUME_HP

Re: [PATCH 1/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-03-01 Thread Mark Brown
On Fri, Mar 01, 2024 at 12:27:13PM +0200, Nikolai Kondrashov wrote: > On 2/29/24 10:21 PM, Linus Torvalds wrote: > > We already have the situation that the drm people have their own ci > > model. II'm ok with that, partly because then at least the maintainers > > of that subsystem can agree on the

Re: [PATCH 0/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-02-29 Thread Mark Brown
On Thu, Feb 29, 2024 at 01:19:19PM +0200, Laurent Pinchart wrote: > On Thu, Feb 29, 2024 at 01:10:16PM +0200, Nikolai Kondrashov wrote: > > Of course. You're also welcome to join the #kernelci channel on libera.chat. > Isn't that a bit pointless if it's no the main IM channel ? It *was* the orig

Re: [PATCH 0/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-02-29 Thread Mark Brown
On Thu, Feb 29, 2024 at 09:39:01AM +, Sakari Ailus wrote: > On Thu, Feb 29, 2024 at 01:07:25AM +0200, Laurent Pinchart wrote: > > > We have a Slack channel, #gitlab-ci, on the KernelCI Slack instance > > > https://kernelci.slack.com/ . > > > Feel free to join and contribute to the conversatio

Re: [PATCH v5 7/8] ASoC: dt-bindings: xmos, xvf3500: add XMOS XVF3500 voice processor

2024-02-28 Thread Mark Brown
On Wed, Feb 28, 2024 at 02:51:34PM +0100, Javier Carrasco wrote: > The XMOS XVF3500 VocalFusion Voice Processor[1] is a low-latency, 32-bit > multicore controller for voice processing. Acked-by: Mark Brown signature.asc Description: PGP signature

Re: [PATCH 00/18] Add audio support for the MediaTek Genio 350-evk board

2024-02-27 Thread Mark Brown
On Mon, Feb 26, 2024 at 03:01:38PM +0100, Alexandre Mergnat wrote: > This serie aim to add the following audio support for the Genio 350-evk: > - Playback > - 2ch Headset Jack (Earphone) > - 1ch Line-out Jack (Speaker) > - 8ch HDMI Tx > - Capture > - 1ch DMIC (On-board Digital Microphone) >

  1   2   3   4   5   6   7   8   9   >