Re: [PATCH] dt-bindings: yamllint: Require a space after a comment '#'

2023-03-04 Thread Mark Brown
> '#'. A couple of cases with comments which were not intended to be > comments are revealed. Those were in ti,sa2ul.yaml, ti,cal.yaml, and > brcm,bcmgenet.yaml. Acked-by: Mark Brown signature.asc Description: PGP signature

Re: [PATCH] dt-bindings: Fix SPI and I2C bus node names in examples

2023-02-28 Thread Mark Brown
s crept in. Fix all these > cases. Mostly scripted with the following commands: Acked-by: Mark Brown signature.asc Description: PGP signature

Re: [PATCH] tree-wide: trivial: s/ a SPI/ an SPI/

2023-02-03 Thread Mark Brown
On Fri, Feb 03, 2023 at 11:28:03AM +0100, Geert Uytterhoeven wrote: > On Fri, Feb 3, 2023 at 11:17 AM Tudor Ambarus > wrote: > > The deciding factor for when a/an should be used is the sound > > that begins the word which follows these indefinite articles, > > rather than the letter which does.

Re: (subset) [PATCH v2 00/13] spi: Add support for stacked/parallel memories

2023-02-01 Thread Mark Brown
On Fri, 20 Jan 2023 00:23:29 +0530, Amit Kumar Mahapatra wrote: > This patch is in the continuation to the discussions which happened on > 'commit f89504300e94 ("spi: Stacked/parallel memories bindings")' for > adding dt-binding support for stacked/parallel memories. > > This patch series updated

Re: [PATCH v2 02/13] spi: Replace all spi->chip_select and spi->cs_gpiod references with function call

2023-02-01 Thread Mark Brown
On Fri, Jan 20, 2023 at 12:23:31AM +0530, Amit Kumar Mahapatra wrote: > Supporting multi-cs in spi drivers would require the chip_select & cs_gpiod > members of struct spi_device to be an array. But changing the type of these > members to array would break the spi driver functionality. To make the

Re: (subset) [PATCH 00/35] Documentation: correct lots of spelling errors (series 1)

2023-01-28 Thread Mark Brown
On Thu, 26 Jan 2023 22:39:30 -0800, Randy Dunlap wrote: > Correct many spelling errors in Documentation/ as reported by codespell. > > Maintainers of specific kernel subsystems are only Cc-ed on their > respective patches, not the entire series. [if all goes well] > > These patches are based on l

Re: [PATCH] dt-bindings: Add missing (unevaluated|additional)Properties on child node schemas

2023-01-25 Thread Mark Brown
nt. > > Add unevaluatedProperties or additionalProperties as appropriate, and > then add any missing properties flagged by the addition. Acked-by: Mark Brown signature.asc Description: PGP signature

Re: [PATCH] dt-bindings: Add missing (unevaluated|additional)Properties on child node schemas

2023-01-25 Thread Mark Brown
nt. > > Add unevaluatedProperties or additionalProperties as appropriate, and > then add any missing properties flagged by the addition. Acked-by: Mark Brown signature.asc Description: PGP signature

dri-devel@lists.freedesktop.org

2023-01-12 Thread Mark Brown
On Thu, 05 Jan 2023 14:45:55 +0100, Arnd Bergmann wrote: > Most of the legacy PXA board files were marked as unused in linux-5.19 and > can get removed in linux-6.3. There is support for pxa250/pxa270/pxa300 > using devicetree already, which supports a number of boards, but progress > on converting

Re: next-20230110: arm64: defconfig+kselftest config boot failed - Unable to handle kernel paging request at virtual address fffffffffffffff8

2023-01-11 Thread Mark Brown
On Wed, Jan 11, 2023 at 12:29:04PM +, Mark Brown wrote: > We're seeing issues in all configs on meson-gxl-s905x-libretech-cc > today, not just with the kselftest fragment. The initial failuire seems > to be: > [ 17.337253] WARNING: CPU: 3 PID: 123 at drivers/gpu/drm/

Re: next-20230110: arm64: defconfig+kselftest config boot failed - Unable to handle kernel paging request at virtual address fffffffffffffff8

2023-01-11 Thread Mark Brown
On Wed, Jan 11, 2023 at 11:34:41AM +0100, Neil Armstrong wrote: > I merged a fix that could be related: > https://lore.kernel.org/all/20230109220033.31202-1-m.szyprow...@samsung.com/ > This could make the driver to return from probe while not totally probed, and > explain such error. We're see

Re: next-20230110: arm64: defconfig+kselftest config boot failed - Unable to handle kernel paging request at virtual address fffffffffffffff8

2023-01-10 Thread Mark Brown
On Tue, Jan 10, 2023 at 04:32:59PM +, Will Deacon wrote: > On Tue, Jan 10, 2023 at 09:44:40PM +0530, Naresh Kamboju wrote: > > GOOD: next-20230109 (defconfig + kselftests configs) > > BAD: next-20230110 (defconfig + kselftests configs) > I couldn't find a kselftests .config in the tree (assu

Re: renesas/master bisection: igt-kms-rockchip.kms_vblank.pipe-A-wait-forked on rk3399-gru-kevin

2022-12-14 Thread Mark Brown
On Wed, Dec 14, 2022 at 03:27:56PM +0100, Guillaume Tucker wrote: > On 14/12/2022 14:50, Mark Brown wrote: > > As a developer I tend to find this unhelpful, it makes it much more > > likely that the mail will get missed. As a reporter it means there's > > more informati

Re: renesas/master bisection: igt-kms-rockchip.kms_vblank.pipe-A-wait-forked on rk3399-gru-kevin

2022-12-14 Thread Mark Brown
On Wed, Dec 14, 2022 at 03:16:33PM +0100, Guillaume Tucker wrote: > Mark, how did you get the list of recipients? > There's a command for this btw, which was used when the reports > were automatically sent to the recipients before we reverted to > manual filtering to reduce the noise: My standar

Re: renesas/master bisection: igt-kms-rockchip.kms_vblank.pipe-A-wait-forked on rk3399-gru-kevin

2022-12-14 Thread Mark Brown
On Wed, Dec 14, 2022 at 01:55:03PM +0100, Guillaume Tucker wrote: > Maybe you could retrieve the original thread and rely to it with > the report? That's the ideal way of following up on a patch I > think. You can get the mbox file this way: > ./kci_bisect get_mbox \ > --commit ca871659ec1606

Re: renesas/master bisection: igt-kms-rockchip.kms_vblank.pipe-A-wait-forked on rk3399-gru-kevin

2022-12-13 Thread Mark Brown
On Tue, Dec 13, 2022 at 05:56:30AM -0800, KernelCI bot wrote: The KernelCI bisection bot found regressions in at least two KMS tests in the Renesas tree on rk3399-gru-kevin just after the Renesas tree merged up mainline: igt-kms-rockchip.kms_vblank.pipe-A-wait-forked igt-kms-rockchip.kms_v

Re: [PATCH v2 1/3] ASoC: hdmi-codec: Add event handler for hdmi TX

2022-12-13 Thread Mark Brown
On Tue, Dec 13, 2022 at 02:23:32PM +, Jiaxin Yu (俞家鑫) wrote: > On Mon, 2022-12-05 at 12:07 +0000, Mark Brown wrote: > > On Mon, Dec 05, 2022 at 09:34:17AM +, Jiaxin Yu (俞家鑫) wrote: > > No, I mean that if you want to control the enable and disable of the > > o

Re: [PATCH 1/3] ASoC: dt-bindings: Extend name-prefix.yaml into common DAI properties

2022-12-05 Thread Mark Brown
On Sat, 3 Dec 2022 17:04:40 +0100, Krzysztof Kozlowski wrote: > Rename name-prefix.yaml into common DAI schema and document > '#sound-dai-cells' for completeness. The '#sound-dai-cells' cannot be > really constrained, as there are users with value of 0, 1 and 2, but at > least it brings definition

Re: [PATCH v2 1/3] ASoC: hdmi-codec: Add event handler for hdmi TX

2022-12-05 Thread Mark Brown
On Mon, Dec 05, 2022 at 09:34:17AM +, Jiaxin Yu (俞家鑫) wrote: > 1. I have added a DAPM widget that is "SDB", when we open or close HDMI > PIN_SWITCH, the callback 'hdmi_tx_event' registered in the widget will > be triggered. Maybe you mean I shouldn't use SNDRV_PCM_TRIGGER_START > and SNDRV_PCM

Re: [PATCH v1 0/2] ASoC/tda998x: Fix reporting of nonexistent capture streams

2022-12-04 Thread Mark Brown
On Wed, 30 Nov 2022 18:46:42 +, Mark Brown wrote: > The recently added pcm-test selftest has pointed out that systems with > the tda998x driver end up advertising that they support capture when in > reality as far as I can see the tda998x devices are transmit only. The > DAI

Re: [PATCH v2 1/3] ASoC: hdmi-codec: Add event handler for hdmi TX

2022-12-01 Thread Mark Brown
On Thu, Dec 01, 2022 at 03:06:04PM +, Jiaxin Yu (俞家鑫) wrote: > On Tue, 2022-11-29 at 17:22 +0000, Mark Brown wrote: > > static const struct snd_kcontrol_new > > mt8186_mt6366_rt1019_rt5682s_controls[] = { > > SOC_DAPM_PIN_SWITCH("Speakers"), &

Re: [PATCH v2 0/6] drm/gud: Use the shadow plane helper

2022-12-01 Thread Mark Brown
On Thu, Dec 01, 2022 at 03:27:32PM +0100, Vlastimil Babka wrote: > I usually do that with git send-email and a custom --cc-cmd script, but > additionally it sends the cover letter also to everyone that's on any > individual patch's Cc, so everyone gets at least the cover letter + their > specific

[PATCH v1 2/2] drm: tda99x: Don't advertise non-existent capture support

2022-11-30 Thread Mark Brown
As far as I can tell none of the tda998x devices support audio capture so don't advertise support for it, ensuring that we don't confuse userspace. Signed-off-by: Mark Brown --- drivers/gpu/drm/i2c/tda998x_drv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/g

[PATCH v1 1/2] ASoC: hdmi-codec: Allow playback and capture to be disabled

2022-11-30 Thread Mark Brown
things to userspace that we can't actually support. In order to avoid breaking existing users the flags in platform data are a bit awkward and specify what should be disabled rather than doing the perhaps more expected thing and defaulting to not supporting capture. Signed-off-by: Mark Brow

[PATCH v1 0/2] ASoC/tda998x: Fix reporting of nonexistent capture streams

2022-11-30 Thread Mark Brown
s for example due to pinmux management. This is happening due to the hdmi-codec helpers not providing any mechanism for indicating unidirectional audio so add one and use it in the tda998x driver. It is likely other hdmi-codec users are also affected but I don't have those systems to hand.

Re: [PATCH v2 1/3] ASoC: hdmi-codec: Add event handler for hdmi TX

2022-11-29 Thread Mark Brown
On Mon, Nov 28, 2022 at 03:07:22PM +, Jiaxin Yu (俞家鑫) wrote: > On Fri, 2022-11-25 at 12:18 +0000, Mark Brown wrote: > > On Fri, Nov 25, 2022 at 05:44:11PM +0800, Jiaxin Yu wrote: > > I'm a little unclear why this is being implemented as a DAPM > > operation > &g

Re: [PATCH v2 1/3] ASoC: hdmi-codec: Add event handler for hdmi TX

2022-11-25 Thread Mark Brown
On Fri, Nov 25, 2022 at 05:44:11PM +0800, Jiaxin Yu wrote: > + /* > + * PCM trigger callback. > + * Mandatory > + */ > + int (*trigger)(struct device *dev, int cmd); > + Making this mandatory would break all existing users, though... > + switch (event) { > + case S

Re: [PATCH 2/3] drm/tiny: ili9486: Do not assume 8-bit only SPI controllers

2022-11-18 Thread Mark Brown
On Fri, Nov 18, 2022 at 11:36:27AM +0100, Carlo Caione wrote: > On 17/11/2022 15:59, Mark Brown wrote: > > So this is an issue in the MIPI DBI code where the interpretation of the > > buffer passed in depends on both the a caller parameter and the > > capabilities of the unde

Re: [PATCH 2/3] drm/tiny: ili9486: Do not assume 8-bit only SPI controllers

2022-11-17 Thread Mark Brown
On Thu, Nov 17, 2022 at 02:40:05PM +0100, Carlo Caione wrote: > On 17/11/2022 12:09, Mark Brown wrote: > > I don't understand what the commit log is saying here. The meson-spicc > > driver advertises support for 8 bit words, if the driver is sending data > > formatted a

Re: [PATCH 2/3] drm/tiny: ili9486: Do not assume 8-bit only SPI controllers

2022-11-17 Thread Mark Brown
On Thu, Nov 17, 2022 at 09:47:40AM +0100, Carlo Caione wrote: > The ILI9486 driver is wrongly assuming that the SPI panel is interfaced > only with 8-bit SPI controllers and consequently that the pixel data > passed by the MIPI DBI subsystem are already swapped before being sent > over SPI using 8

Re: [PATCH 3/3] spi: meson-spicc: Lower CS between bursts

2022-11-17 Thread Mark Brown
On Thu, Nov 17, 2022 at 09:47:41AM +0100, Carlo Caione wrote: > On some hardware (reproduced on S905X) when a large payload is > transmitted over SPI in bursts at the end of each burst, the clock line > briefly fluctuates creating spurious clock transitions that are being > recognised by the connec

Re: [PATCH v2 43/65] ASoC: tlv320aic32x4: Add a determine_rate hook

2022-11-07 Thread Mark Brown
On Mon, Nov 07, 2022 at 04:26:03PM +0100, Maxime Ripard wrote: > On Mon, Nov 07, 2022 at 12:06:07PM +0000, Mark Brown wrote: > > On Mon, Nov 07, 2022 at 09:43:22AM +0100, Maxime Ripard wrote: > > The series does fill in __clk_mux_determine_rate for everything though - > > i

Re: [PATCH v2 43/65] ASoC: tlv320aic32x4: Add a determine_rate hook

2022-11-07 Thread Mark Brown
On Mon, Nov 07, 2022 at 09:43:22AM +0100, Maxime Ripard wrote: > On Fri, Nov 04, 2022 at 03:59:53PM +0000, Mark Brown wrote: > > Well, hopefully everyone for whom it's an issue currently will be > > objecting to this version of the change anyway so we'll either know >

Re: [PATCH v2 43/65] ASoC: tlv320aic32x4: Add a determine_rate hook

2022-11-04 Thread Mark Brown
On Fri, Nov 04, 2022 at 04:51:23PM +0100, Maxime Ripard wrote: > Just filling determine_rate if it's missing with > __clk_mux_determine_rate will possibly pick different parents, and I'm > fairly certain that this have never been tested on most platforms, and > will be completely broken. And I don

Re: [PATCH v2 43/65] ASoC: tlv320aic32x4: Add a determine_rate hook

2022-11-04 Thread Mark Brown
On Fri, Nov 04, 2022 at 02:18:00PM +0100, Maxime Ripard wrote: > So, the set_parent hook is effectively unused, possibly because of an > oversight. However, it could also be an explicit decision by the > original author to avoid any reparenting but through an explicit call to > clk_set_parent().

Re: [PATCH 1/2] component: Add helper for device nodes

2022-11-03 Thread Mark Brown
dding the helper from updating to use the helper - it makes things easier to merge. Acked-by: Mark Brown signature.asc Description: PGP signature

Re: linux-next: build failure after merge of the drm tree

2022-10-04 Thread Mark Brown
On Tue, Oct 04, 2022 at 02:05:58PM +1100, Stephen Rothwell wrote: > On Tue, 4 Oct 2022 12:24:37 +1000 David Airlie wrote: > > On Tue, Oct 4, 2022 at 12:21 PM Stephen Rothwell > > wrote: > > I'm not seeing it here, what gcc is this with? > I am using an x86_64 cross compiler hosted on ppc64le -

Re: (subset) [PATCH v1 00/11] Get rid of [devm_]gpiod_get_from_of_node() public APIs

2022-09-05 Thread Mark Brown
On Sun, 4 Sep 2022 23:30:52 -0700, Dmitry Torokhov wrote: > I would like to stop exporting OF-specific [devm_]gpiod_get_from_of_node() > so that gpiolib can be cleaned a bit. We can do that by switching drivers > to use generic fwnode API ([devm_]fwnode_gpiod_get()). By doing so we open > the door

Re: (subset) [PATCH v2 0/7] Devm helpers for regulator get and enable

2022-08-24 Thread Mark Brown
On Fri, 12 Aug 2022 13:08:17 +0300, Matti Vaittinen wrote: > Devm helpers for regulator get and enable > > First patch in the series is actually just a simple documentation fix > which could be taken in as it is now. > > A few* drivers seem to use pattern demonstrated by pseudocode: > > [...] A

Re: (subset) [PATCH v2 0/7] Devm helpers for regulator get and enable

2022-08-24 Thread Mark Brown
On Mon, Aug 15, 2022 at 06:54:45PM +0300, Laurent Pinchart wrote: > - With devres, you don't have full control over the order in which > resources will be released, which means that you can't control the > power off sequence, in particular if it needs to be sequenced with > GPIOs and clocks.

Re: (subset) [PATCH v3 00/14] Use devm helpers for regulator get and enable

2022-08-23 Thread Mark Brown
On Fri, 19 Aug 2022 22:16:48 +0300, Matti Vaittinen wrote: > Use devm helpers for regulator get and enable > > NOTE: The series depends on commit > ee94aff2628b ("Devm helpers for regulator get and enable") > which currently sits in Mark's regulator/for-next > > A few* drivers seem to pattern dem

Re: (subset) [PATCH v2 0/7] Devm helpers for regulator get and enable

2022-08-18 Thread Mark Brown
On Thu, Aug 18, 2022 at 02:33:53PM +0300, Matti Vaittinen wrote: > On 8/15/22 18:44, Mark Brown wrote: > > [2/7] regulator: Add devm helpers for get and enable > >(no commit info) > I was planning to send out the v3 (where IIO patches are no longer squashed > into on

Re: (subset) [PATCH v2 0/7] Devm helpers for regulator get and enable

2022-08-16 Thread Mark Brown
On Tue, Aug 16, 2022 at 11:06:21AM +, Vaittinen, Matti wrote: > I wonder if writing such 'release callbacks' is compulsory? I mean, if I > was writing a driver to some new (to me) subsystem and was required to > write an explicit release-callback for a resource - then it'd surely > rang a b

Re: (subset) [PATCH v2 0/7] Devm helpers for regulator get and enable

2022-08-16 Thread Mark Brown
On Tue, Aug 16, 2022 at 07:56:06AM +0300, Matti Vaittinen wrote: > On 8/16/22 01:55, Mark Brown wrote: > > On Tue, Aug 16, 2022 at 12:17:17AM +0300, Laurent Pinchart wrote: > > > These devres helpers give > > > a false sense of security to driver authors and they wi

Re: (subset) [PATCH v2 0/7] Devm helpers for regulator get and enable

2022-08-15 Thread Mark Brown
On Tue, Aug 16, 2022 at 12:17:17AM +0300, Laurent Pinchart wrote: > On Mon, Aug 15, 2022 at 01:58:55PM -0700, Stephen Boyd wrote: > > The basic idea is that drivers should be focused on what they're > > driving, not navigating the (sometimes) complex integration that's > > taking place around them

Re: (subset) [PATCH v2 0/7] Devm helpers for regulator get and enable

2022-08-15 Thread Mark Brown
On Mon, Aug 15, 2022 at 01:58:55PM -0700, Stephen Boyd wrote: > Quoting Laurent Pinchart (2022-08-15 11:52:36) > > On Mon, Aug 15, 2022 at 05:33:06PM +0100, Mark Brown wrote: > > > On Mon, Aug 15, 2022 at 06:54:45PM +0300, Laurent Pinchart wrote: > > > > - With devre

Re: [PATCH] spi/panel: dt-bindings: drop 3-wire from common properties

2022-08-15 Thread Mark Brown
On Wed, 10 Aug 2022 16:13:11 +0300, Krzysztof Kozlowski wrote: > The spi-3wire property is device specific and should be accepted only if > device really needs them. Drop it from common spi-peripheral-props.yaml > schema, mention in few panel drivers which use it and include instead in > the SPI c

Re: (subset) [PATCH v2 0/7] Devm helpers for regulator get and enable

2022-08-15 Thread Mark Brown
On Fri, 12 Aug 2022 13:08:17 +0300, Matti Vaittinen wrote: > Devm helpers for regulator get and enable > > First patch in the series is actually just a simple documentation fix > which could be taken in as it is now. > > A few* drivers seem to use pattern demonstrated by pseudocode: > > [...] A

Re: [PATCH] spi/panel: dt-bindings: drop 3-wire from common properties

2022-08-10 Thread Mark Brown
On Wed, Aug 10, 2022 at 04:13:11PM +0300, Krzysztof Kozlowski wrote: > The spi-3wire property is device specific and should be accepted only if > device really needs them. Drop it from common spi-peripheral-props.yaml > schema, mention in few panel drivers which use it and include instead in > the

Re: [PATCH v16 0/3] eDP/DP Phy vdda realted function

2022-07-29 Thread Mark Brown
On Fri, Jul 29, 2022 at 03:35:33PM +0200, Johan Hovold wrote: > I guess we just need to drop all those regulator-allow-set-load > properties for now even if using DT for power-management configuration > this way does seem to run against the whole DT-as-hardware-description > idea (e.g. we may want

Re: [PATCH v2 0/7] drm/msm/dsi regulator improvements

2022-07-27 Thread Mark Brown
On Tue, Jul 26, 2022 at 10:38:17AM -0700, Douglas Anderson wrote: > * After that I have patches that add to the regulator API and then > show a usage of those in the DSI driver. I'd expect that the two > regulator patches could land in the regulator tree. The DSI patches > would need to wait

Re: (subset) [PATCH v2 0/7] drm/msm/dsi regulator improvements

2022-07-27 Thread Mark Brown
On Tue, 26 Jul 2022 10:38:17 -0700, Douglas Anderson wrote: > The main goal of this series is to make a small dent in cleaning up > the way we deal with regulator loads. The idea is to add some extra > functionality to the regulator "bulk" API so that consumers can > specify the load using that. Th

Re: [PATCH v2 0/1] dt-bindings: spi/display/panel: drop SPI CPHA and CPOL

2022-07-26 Thread Mark Brown
On Fri, 22 Jul 2022 21:15:38 +0200, Krzysztof Kozlowski wrote: > Rebased on Linus' master > > Changes since v1 > > 1. Rework patchset as Rob suggested, so there is only one patch - changing spi >and display/panel. > v1: > https://lore.kernel.org/all/20220721153155.245336-2-kr

Re: [PATCH v16 0/3] eDP/DP Phy vdda realted function

2022-07-21 Thread Mark Brown
On Thu, Jul 21, 2022 at 07:52:01AM -0700, Doug Anderson wrote: > On Thu, Jul 21, 2022 at 7:39 AM Doug Anderson wrote: > > vdda-phy-supply = <&vdda_mipi_dsi0_1p2>; > > vdda-phy-supply-base-load = <21800>; > Ah, sorry to respond to my own thread so quickly, but I just thought > of a reason for the

Re: [PATCH v16 0/3] eDP/DP Phy vdda realted function

2022-07-21 Thread Mark Brown
On Thu, Jul 21, 2022 at 08:43:48AM -0700, Doug Anderson wrote: > I guess I'd put it this way, though: how many drivers in Linux today > have _two_ calls to regulator_set_load(): one for the "active" state > and one for the retention state. Looks like UFS maybe. Any others? For > most devices the p

Re: [PATCH v16 0/3] eDP/DP Phy vdda realted function

2022-07-21 Thread Mark Brown
On Thu, Jul 21, 2022 at 07:49:55AM -0700, Doug Anderson wrote: > Every single LDO on Qualcomm's PMICs seems to be able to be set in > "high power mode" and "low power mode", but I think the majority of > clients only really care about two things: on and in high power mode > vs. off. I think the am

Re: [PATCH v16 0/3] eDP/DP Phy vdda realted function

2022-07-21 Thread Mark Brown
On Thu, Jul 21, 2022 at 12:20:31PM +0100, Mark Brown wrote: > You could add a way to specify constant base loads in DT on either a per > regulator or per consumer basis. ...and also note that this is only an issue if the system gives permission to change the mode in the constraints wh

Re: [PATCH v16 0/3] eDP/DP Phy vdda realted function

2022-07-21 Thread Mark Brown
On Thu, Jul 21, 2022 at 12:31:41PM +0200, Johan Hovold wrote: If you're copying someone into a thread that's not obviously relevant for them it's good practice to put a note about it at the top of the mail to reduce the chances that it just gets deleted unread - people get copies of all sorts of r

Re: (subset) [PATCH V2 0/5] I2S driver changes for Jadeite platform

2022-07-06 Thread Mark Brown
On Fri, 1 Jul 2022 17:11:02 +0530, Vijendar Mukunda wrote: > Jadeite(JD) platform is Stoney APU varaint which uses I2S MICSP > instance and ES8336 Codec. > This patch series creates I2S platform devices for JD platform, > adds I2S MICSP instance support and Machine driver support > > This patch se

Re: (subset) [PATCH v4 00/14] Canaan devicetree fixes

2022-07-04 Thread Mark Brown
On Fri, 1 Jul 2022 20:22:46 +0100, Conor Dooley wrote: > From: Conor Dooley > > Hey all, > This series should rid us of dtbs_check errors for the RISC-V Canaan k210 > based boards. To make keeping it that way a little easier, I changed the > Canaan devicetree Makefile so that it would build all o

Re: [PATCH V2 0/5] I2S driver changes for Jadeite platform

2022-07-01 Thread Mark Brown
On Fri, Jul 01, 2022 at 05:11:02PM +0530, Vijendar Mukunda wrote: > This patch set depends on: > --checkpatch warnings patch > > --https://patchwork.kernel.org/project/alsa-devel/patch/20220627125834.481731-1-vijendar.muku...@amd.com/ That's "drm: amd: amdgpu: fix checkpatch warnin

Re: (subset) [PATCH v3 00/15] Canaan devicetree fixes

2022-07-01 Thread Mark Brown
On Wed, 29 Jun 2022 19:43:29 +0100, Conor Dooley wrote: > From: Conor Dooley > > Hey all, > This series should rid us of dtbs_check errors for the RISC-V Canaan k210 > based boards. To make keeping it that way a little easier, I changed the > Canaan devicetree Makefile so that it would build all

Re: [PATCH 5/5] ASoC: amd: enable machine driver build for Jadeite platform

2022-06-30 Thread Mark Brown
On Thu, Jun 30, 2022 at 08:47:55AM +0530, Vijendar Mukunda wrote: > + depends on SND_SOC_AMD_ACP && I2C && ACPI The code treated ACPI as optional so you could relax the ACPI dependency ot be "ACPI || COMPILE_TEST" (I think the same applies to I2C). signature.asc Description: PGP signature

Re: [PATCH 4/5] ASoC: amd: add Machine driver for Jadeite platform

2022-06-30 Thread Mark Brown
On Thu, Jun 30, 2022 at 08:47:54AM +0530, Vijendar Mukunda wrote: > +static int st_es8336_hw_params(struct snd_pcm_substream *substream, > +struct snd_pcm_hw_params *params) > +{ > + int ret = 0; > + struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substr

Re: [PATCH v2 00/96] Refactor non_legacy_dai_naming flag

2022-06-29 Thread Mark Brown
On Thu, 23 Jun 2022 13:51:14 +0100, Charles Keepax wrote: > Historically, the legacy DAI naming scheme was applied to platform > drivers and the newer scheme to CODEC drivers. During componentisation > the core lost the knowledge of if a driver was a CODEC or platform, they > were all now component

Re: [PATCH 00/96] Refactor non_legacy_dai_naming flag

2022-06-29 Thread Mark Brown
On Thu, 16 Jun 2022 15:32:53 +0100, Charles Keepax wrote: > Historically, the legacy DAI naming scheme was applied to platform > drivers and the newer scheme to CODEC drivers. During componentisation > the core lost the knowledge of if a driver was a CODEC or platform, they > were all now component

Re: (subset) [PATCH 00/22] Fix kernel-doc warnings at linux-next

2022-06-28 Thread Mark Brown
On Tue, 28 Jun 2022 10:46:04 +0100, Mauro Carvalho Chehab wrote: > As we're currently discussing about making kernel-doc issues fatal when > CONFIG_WERROR is enable, let's fix all 60 kernel-doc warnings > inside linux-next: > > arch/x86/include/uapi/asm/sgx.h:19: warning: Enum value > 'SGX_

Re: (subset) [PATCH v3 00/14] Add Mediatek MT6370 PMIC support

2022-06-23 Thread Mark Brown
On Thu, 23 Jun 2022 19:56:17 +0800, ChiaEn Wu wrote: > From: ChiaEn Wu > > This patch series add Mediatek MT6370 PMIC support. The MT6370 is a > highly-integrated smart power management IC, which includes a single > cell Li-Ion/Li-Polymer switching battery charger, a USB > Type-C & Power Delivery

Re: [PATCH] ASoC: hdmi-codec: Update to modern DAI terminology

2022-06-13 Thread Mark Brown
On Thu, 2 Jun 2022 12:30:29 +0200, Mark Brown wrote: > As part of retiring the old defines used to specify DAI formats update the > hdmi_codec driver to use the modern names, including the variables in the > struct hdmi_codec_daifmt exported to the DRM drivers. > > In updating

[PATCH] drm/i2c: tda9950: Lower severity of log message about missing interrupts

2022-06-06 Thread Mark Brown
check for an interrupt to the tda998x driver instead but this feels better from an encapsulation point of view, there's still a log message to help anyone doing system integration. Signed-off-by: Mark Brown --- drivers/gpu/drm/i2c/tda9950.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH] ASoC: hdmi-codec: Update to modern DAI terminology

2022-06-02 Thread Mark Brown
clock provider settings, thinking about what this hardware is doing I rather suspect that there might not be any hardware out there which needs the configuration so it may be worth considering just having hdmi-codec support only clock consumer. Signed-off-by: Mark Brown --- drivers/gpu/drm/bridge

Re: [PATCH 03/14] regulator: mt6370: Add mt6370 DisplayBias and VibLDO support

2022-05-31 Thread Mark Brown
On Tue, May 31, 2022 at 06:27:58PM +0800, ChiaEn Wu wrote: > From: ChiYuan Huang > > Add mt6370 DisplayBias and VibLDO support. Other than one small thing this looks nice and clean: > + enable_gpio = fwnode_gpiod_get_index(of_fwnode_handle(np), "enable", 0, > +

Re: [PATCH] dt-bindings: Fix properties without any type

2022-05-19 Thread Mark Brown
arious property schemas which are missing a type. Most of these > tend to be device specific properties which don't have a vendor prefix. > A vendor prefix is how we normally ensure a type is defined. Acked-by: Mark Brown signature.asc Description: PGP signature

[PATCH] drm/i2c: tda9950: Lower severity of log message about missing interrupts

2022-05-10 Thread Mark Brown
check for an interrupt to the tda998x driver instead but this feels better from an encapsulation point of view, there's still a log message to help anyone doing system integration. Signed-off-by: Mark Brown --- drivers/gpu/drm/i2c/tda9950.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: (subset) [PATCH 1/2] [RFC] regmap: Add bulk read/write callbacks into regmap_config

2022-05-09 Thread Mark Brown
On Mon, May 09, 2022 at 03:54:11PM +0200, Daniel Vetter wrote: > On Fri, May 06, 2022 at 01:42:37PM +0100, Mark Brown wrote: > > Not outside of the source. I did a presentation at ELC-E ages > > ago which you can probably find but I'm not sure how much it > > would

Re: (subset) [PATCH 1/2] [RFC] regmap: Add bulk read/write callbacks into regmap_config

2022-05-06 Thread Mark Brown
On Fri, May 06, 2022 at 01:55:57AM +0200, Marek Vasut wrote: > On 5/5/22 23:08, Mark Brown wrote: > > I did go through it and didn't spot > > any issues so it seemed like the testing coverage would be useful here. > > Are there specific things you're worried about

Re: (subset) [PATCH 1/2] [RFC] regmap: Add bulk read/write callbacks into regmap_config

2022-05-06 Thread Mark Brown
On Fri, May 06, 2022 at 01:58:18PM +0300, Jani Nikula wrote: > Hey Mark, sorry for hijacking the thread a bit. regmap.h seems to have > comprehensive API documentation, but there's very little in terms of > higher level documentation that I could find. Is there any? Not outside of the source. I

Re: (subset) [PATCH 1/2] [RFC] regmap: Add bulk read/write callbacks into regmap_config

2022-05-05 Thread Mark Brown
On Thu, May 05, 2022 at 07:32:23PM +0200, Marek Vasut wrote: > On 5/5/22 17:12, Mark Brown wrote: > > On Sat, 30 Apr 2022 04:51:44 +0200, Marek Vasut wrote: > > > Currently the regmap_config structure only allows the user to implement > > > single element register

Re: (subset) [PATCH 1/2] [RFC] regmap: Add bulk read/write callbacks into regmap_config

2022-05-05 Thread Mark Brown
On Sat, 30 Apr 2022 04:51:44 +0200, Marek Vasut wrote: > Currently the regmap_config structure only allows the user to implement > single element register read/write using .reg_read/.reg_write callbacks. > The regmap_bus already implements bulk counterparts of both, and is being > misused as a work

Re: [PATCH 18/48] ARM: pxa: hx4700: use gpio descriptors for audio

2022-05-05 Thread Mark Brown
On Thu, May 05, 2022 at 04:59:35PM +0200, Arnd Bergmann wrote: > On Thu, May 5, 2022 at 4:39 PM Mark Brown wrote: > > On Thu, May 05, 2022 at 04:33:06PM +0200, Linus Walleij wrote: > > > On Thu, May 5, 2022 at 8:04 AM Arnd Bergmann wrote: > > > > static struc

Re: [PATCH 18/48] ARM: pxa: hx4700: use gpio descriptors for audio

2022-05-05 Thread Mark Brown
On Thu, May 05, 2022 at 04:33:06PM +0200, Linus Walleij wrote: > On Thu, May 5, 2022 at 8:04 AM Arnd Bergmann wrote: > > /* Headphones jack detection DAPM pin */ > > static struct snd_soc_jack_pin hs_jack_pin[] = { > > { > > .pin= "Headphone Jack", > >

Re: [PATCH] dt-bindings: Drop redundant 'maxItems/minItems' in if/then schemas

2022-05-03 Thread Mark Brown
On Tue, May 03, 2022 at 11:27:38AM -0500, Rob Herring wrote: > Another round of removing redundant minItems/maxItems when 'items' list is > specified. This time it is in if/then schemas as the meta-schema was > failing to check this case. Acked-by: Mark Brown signature.a

Re: [PATCH 5/5] drm/solomon: Add SSD130x OLED displays SPI support

2022-04-08 Thread Mark Brown
byte is not used, instead a real D/C# line > must be pulled HIGH for commands data and LOW for graphics display data. > > For this reason the standard SPI regmap can't be used and a custom .write > bus handler is needed. Acked-by: Mark Brown signature.asc Description: PGP signature

Re: [PATCH] drm: bridge: icn6211: Convert to regmap

2022-04-07 Thread Mark Brown
On Sun, Apr 03, 2022 at 07:10:04PM +0200, Marek Vasut wrote: > To make debugging easier, convert driver to regmap. Implement read and write > regmap tables for known registers, keep all known register readable and mark > those which are obviously read-only as not writeable. Acked-by: M

Re: (subset) [PATCH 00/30] fix typos in comments

2022-03-15 Thread Mark Brown
On Mon, 14 Mar 2022 12:53:24 +0100, Julia Lawall wrote: > Various spelling mistakes in comments. > Detected with the help of Coccinelle. > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [21/30] spi: sun4i: fix typos in comments commit: 20

Re: [PATCH] ASoC: qcom: Fix error code in lpass_platform_copy()

2022-03-02 Thread Mark Brown
On Tue, 1 Mar 2022 11:11:04 +0300, Dan Carpenter wrote: > The copy_to/from_user() functions return the number of bytes remaining > to be copied. This function needs to return negative error codes > because snd_soc_pcm_component_copy_user() treats positive returns as > success in soc_component_ret(

Re: [PATCH] dt-bindings: Another pass removing cases of 'allOf' containing a '$ref'

2022-02-28 Thread Mark Brown
silently). The correct > form was to put a '$ref' under an 'allOf'. This behavior is now changed > in the 2019-09 json-schema spec and '$ref' can be mixed with other > keywords. Acked-by: Mark Brown signature.asc Description: PGP signature

Re: [PATCH 20/23] ASoC: codecs: wcd938x: Make use of the helper component_compare/release_of

2022-02-14 Thread Mark Brown
On Mon, Feb 14, 2022 at 02:08:16PM +0800, Yong Wu wrote: > Use the common compare/release helpers from component. What's the story with dependencies here? I've just got this one patch with no cover letter... signature.asc Description: PGP signature

Re: [PATCH 0/5] spi: make remove callback a void function

2022-02-10 Thread Mark Brown
On Sun, 23 Jan 2022 18:51:56 +0100, Uwe Kleine-König wrote: > this series goal is to change the spi remove callback's return value to void. > After numerous patches nearly all drivers already return 0 unconditionally. > The four first patches in this series convert the remaining three drivers to >

Re: [PATCH v3 3/7] drm: Add driver for Solomon SSD130X OLED displays

2022-02-09 Thread Mark Brown
On Wed, Feb 09, 2022 at 03:50:13PM +0100, Javier Martinez Canillas wrote: > On 2/9/22 15:22, Mark Brown wrote: > > On Wed, Feb 09, 2022 at 03:17:06PM +0100, Javier Martinez Canillas wrote: > >> I guess in that case what we should do then is to just have a regulator > >&g

Re: [PATCH v3 3/7] drm: Add driver for Solomon SSD130X OLED displays

2022-02-09 Thread Mark Brown
On Wed, Feb 09, 2022 at 03:17:06PM +0100, Javier Martinez Canillas wrote: > On 2/9/22 14:43, Mark Brown wrote: > > Unless the device supports power being physically omitted regulator > > usage should not be optional, it's just more code and a recipie for poor > > error h

Re: [PATCH v3 3/7] drm: Add driver for Solomon SSD130X OLED displays

2022-02-09 Thread Mark Brown
On Wed, Feb 09, 2022 at 10:03:10AM +0100, Javier Martinez Canillas wrote: > + if (ssd130x->vbat_reg) { > + ret = regulator_enable(ssd130x->vbat_reg); > + if (ret) { > + dev_err(dev, "Failed to enable VBAT: %d\n", ret); > + return

Re: [PATCH 5/5] spi: make remove callback a void function

2022-02-09 Thread Mark Brown
On Sun, Jan 23, 2022 at 06:52:01PM +0100, Uwe Kleine-König wrote: > The value returned by an spi driver's remove function is mostly ignored. > (Only an error message is printed if the value is non-zero that the > error is ignored.) > > So change the prototype of the remove function to return no va

Re: [PATCH v2 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays

2022-02-08 Thread Mark Brown
On Tue, Feb 08, 2022 at 04:10:49PM +0100, Javier Martinez Canillas wrote: > On 2/8/22 15:19, Geert Uytterhoeven wrote: > > - "time ls" on the serial console (no files in the current directory, > > so nothing to print) increases from 0.86s to 1.92s, so the system is > > more loaded. As s

[PATCH v2 2/2] drm/st7735r: Add SPI ID table

2022-02-02 Thread Mark Brown
all OF IDs. Fixes: 96c8395e2166 ("spi: Revert modalias changes") Signed-off-by: Mark Brown Cc: David Lechner --- drivers/gpu/drm/tiny/st7735r.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/tiny/st7735r.c b/drivers/gpu/drm/tiny/st7735r.c index fc40dd10efa8..71

[PATCH v2 0/2] drm/tiny: Ensure DT compatibles have SPI device IDs

2022-02-02 Thread Mark Brown
ebase onto v5.17-rc1. Mark Brown (2): drm/ili9486: Add SPI ID table drm/st7735r: Add SPI ID table drivers/gpu/drm/tiny/ili9486.c | 2 ++ drivers/gpu/drm/tiny/st7735r.c | 1 + 2 files changed, 3 insertions(+) base-commit: e783362eb54cd99b2cac8b3a9aeac942e6f6ac07 -- 2.30.2

[PATCH v2 1/2] drm/ili9486: Add SPI ID table

2022-02-02 Thread Mark Brown
all OF IDs. Fixes: 96c8395e2166 ("spi: Revert modalias changes") Signed-off-by: Mark Brown Cc: Kamlesh Gurudasani --- drivers/gpu/drm/tiny/ili9486.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/tiny/ili9486.c b/drivers/gpu/drm/tiny/ili9486.c index e9

[PATCH v2 3/3] drm/ili9486: Add SPI ID table

2022-02-02 Thread Mark Brown
all OF IDs. Fixes: 96c8395e2166 ("spi: Revert modalias changes") Signed-off-by: Mark Brown Cc: Kamlesh Gurudasani --- drivers/gpu/drm/tiny/ili9486.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/tiny/ili9486.c b/drivers/gpu/drm/tiny/ili9486.c index e9

[PATCH v2 2/3] drm/panel-novotek-nt39016: Add SPI ID table

2022-02-02 Thread Mark Brown
IDs for everything. Fixes: 96c8395e2166 ("spi: Revert modalias changes") Signed-off-by: Mark Brown --- drivers/gpu/drm/panel/panel-novatek-nt39016.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-novatek-nt39016.c b/drivers/gpu/drm/panel/pan

[PATCH v2 1/3] drm/panel-ilitek-il9322: Add SPI ID table

2022-02-02 Thread Mark Brown
IDs for everything. Fixes: 96c8395e2166 ("spi: Revert modalias changes") Signed-off-by: Mark Brown --- drivers/gpu/drm/panel/panel-ilitek-ili9322.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9322.c b/drivers/gpu/drm/panel/pa

<    1   2   3   4   5   6   7   8   9   >