From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Mon, 27 Nov 2017 18:14:41 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Mon, 27 Nov 2017 18:53:21 +0100
Three update suggestions were taken into account
from static source code analysis.
Markus Elfring (3):
Delete an error message for a failed memory allocation
Improve a size determination
>> Omit an extra message for a memory allocation failure in these functions.
…
> nak, unlike many others, these message give extra info on which
> allocation failed, that can be useful.
Can a default allocation failure report provide the information
which you might expect so far?
Regards,
Markus
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Mon, 27 Nov 2017 17:53:05 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Mon, 27 Nov 2017 17:27:51 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Mon, 27 Nov 2017 11:04:22 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Mon, 27 Nov 2017 10:33:19 +0100
Omit extra messages for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Mon, 27 Nov 2017 10:12:26 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Mon, 27 Nov 2017 09:56:09 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Sun, 26 Nov 2017 22:13:55 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Sun, 26 Nov 2017 21:21:33 +0100
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Li
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Sun, 26 Nov 2017 21:16:30 +0100
Omit an extra message for a memory allocation failure in these functions.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfr...@users.source
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Sun, 26 Nov 2017 21:38:42 +0100
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation in two functions
Improve a size determi
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Sun, 26 Nov 2017 19:46:09 +0100
Omit an extra message for a memory allocation failure in these functions.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfr...@users.source
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Sun, 26 Nov 2017 18:21:25 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Sun, 26 Nov 2017 18:16:20 +0100
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Li
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Sun, 26 Nov 2017 18:09:15 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Sun, 26 Nov 2017 18:38:48 +0100
Three update suggestions were taken into account
from static source code analysis.
Markus Elfring (3):
Delete an error message for a failed memory allocation in omapfb_do_probe()
Improve
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Sun, 26 Nov 2017 15:03:03 +0100
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Li
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Sun, 26 Nov 2017 15:00:16 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Sun, 26 Nov 2017 15:12:34 +0100
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation
Improve a size determination
drivers
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Sun, 26 Nov 2017 13:48:55 +0100
Omit an extra message for a memory allocation failure in these functions.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfr...@users.source
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Sun, 26 Nov 2017 13:08:43 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Sun, 26 Nov 2017 10:56:46 +0100
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script “checkpatch.pl” pointed information out like the following.
Comparison to NULL could be written !…
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Sun, 26 Nov 2017 10:43:36 +0100
The script "checkpatch.pl" pointed information out like the following.
WARNING: quoted string split across lines
Thus fix four source code places.
Signed-off-by: Mark
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Sun, 26 Nov 2017 10:22:37 +0100
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Li
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Sun, 26 Nov 2017 10:10:31 +0100
Omit extra messages for a memory allocation failure in these functions.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Sun, 26 Nov 2017 11:10:01 +0100
A few update suggestions were taken into account
from static source code analysis.
Markus Elfring (4):
Delete error messages for a failed memory allocation in two functions
Improve a size determi
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Sun, 26 Nov 2017 08:18:20 +0100
Up to four checks could be repeated by the ufx_usb_probe() function
during error handling even if the relevant properties can be determined
for the involved variables before by source code an
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Sat, 25 Nov 2017 21:21:20 +0100
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script “checkpatch.pl” pointed information out like the following.
Comparison to NULL could be written …
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Sat, 25 Nov 2017 21:10:22 +0100
Replace the specification of data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Li
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Sat, 25 Nov 2017 19:56:44 +0100
* Return an error code without storing it in an intermediate variable.
* Delete the label "error" and local variable "retval"
which became unnecessary with this refactori
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Sat, 25 Nov 2017 19:47:51 +0100
Up to four checks could be repeated by the ufx_usb_probe() function
during error handling even if the relevant properties can be determined
for the involved variables before by source code an
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Sat, 25 Nov 2017 18:32:29 +0100
Omit an extra message for a memory allocation failure in these functions.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfr...@users.source
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Sat, 25 Nov 2017 21:38:42 +0100
A few update suggestions were taken into account
from static source code analysis.
Markus Elfring (5):
Delete an error message for a failed memory allocation in two functions
Less
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Sat, 25 Nov 2017 16:50:26 +0100
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Li
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Sat, 25 Nov 2017 16:45:56 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Sat, 25 Nov 2017 16:56:46 +0100
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation
Improve a size determination
drivers
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Fri, 24 Nov 2017 22:22:06 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Fri, 24 Nov 2017 21:36:39 +0100
The script "checkpatch.pl" pointed information out like the following.
WARNING: void function return statements are not generally useful
Thus remove such a statement in the affected functi
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Fri, 24 Nov 2017 21:30:37 +0100
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Li
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Fri, 24 Nov 2017 21:22:25 +0100
* Return an error code without storing it in an intermediate variable.
* Delete the label "error" and local variable "retval"
which became unnecessary with this refactori
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Fri, 24 Nov 2017 21:12:54 +0100
Omit an extra message for a memory allocation failure in these functions.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfr...@users.source
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Fri, 24 Nov 2017 21:45:54 +0100
A few update suggestions were taken into account
from static source code analysis.
Markus Elfring (4):
Delete an error message for a failed memory allocation in two functions
Return an error cod
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Fri, 24 Nov 2017 20:42:08 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Fri, 24 Nov 2017 20:22:10 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Mon, 6 Nov 2017 19:00:58 +0100
A duplicate error message was used so far in this function implementation.
Thus use a consistent message format instead together with property names
where constant merging can be applied by the co
> Sorry but NACK: the message was malformed and resulted in the
> duplication of the error log that you spotted.
>
> The proper way to fix this is to modify the second occurrence of this message.
* Would you like to achieve that a corresponding message will mention
anything around a property
>> If you want to lower the size of strings in this driver, you can do it,
>> but not like this.
>
> Just so we're clear, GCC already detects and combines it when you use
> the same string constant twice.
Do you distinguish between merging of constants and the combination
of statements for such
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Sun, 5 Nov 2017 14:54:52 +0100
Add a jump target so that a bit of exception handling can be better reused
at the end of this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Sun, 5 Nov 2017 14:00:52 +0100
Add a jump target so that a specific error message is stored only once
at the end of this function implementation.
Replace two calls of the function "dev_err" by goto statements.
This is
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Wed, 1 Nov 2017 16:00:46 +0100
The script "checkpatch.pl" pointed information out like the following.
Comparison to NULL could be written !...
Thus fix the affected source code places.
Signed-off-by: Mark
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Wed, 1 Nov 2017 15:57:31 +0100
* Add a jump target so that a bit of exception handling can be better
reused at the end of this function.
* Increase the scope for the variable "ret".
This issue was detected by usin
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Wed, 1 Nov 2017 16:23:45 +0100
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
drm/rcar-du: Use common error handling code in rcar_du_encoders_init()
drm/rcar-du: Adjust 14
> In general, I'll pick up any patches that are good,
This is usual.
> but the current track record is that Markus' patches need extra scrutiny,
I find that this can be fine according to a safe review for presented
update suggestions.
> and many of the patches contain subjective changes that
> Just for the record, I've been bitten in the past by applying one of Markus'
> patches that seemed to make sense, only to discover later that it introduced
> a
> security hole.
How do you think about to take another look at the circumstances
under which a questionable commit happened in the
> These long email threads are a waste of time
They occur for different topics.
> when we already answered your questions completely
There were some attempts for specific details.
> and over and over.
I hope that further useful adjustments can be achieved for
involved information sources.
>> Would you like to support Unicode characters there?
>
> Multiple people have answered this question already and I have answered
> it multiple times.
I found the corresponding feedback not sufficient so far to reach
a final consensus.
Will this topic evolve any further?
Regards,
Markus
>> The script “checkpatch.pl” pointed information out like the following.
>>
>> Comparison to NULL could be written !…
>>
>> Thus fix the affected source code places.
>>
>
> This one is fine
This kind of feedback is nice.
> except for the commit message.
Would you like to support Unicode
> But anyways I guess other people sometimes disagree with me.
Am I one of them? ;-)
> Unwinding is for when you allocate five things in a row.
This is a general issue.
I find that it is also needed in this function as usual.
> You have to undo four if the last allocation fails.
Concrete
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Tue, 24 Oct 2017 19:21:24 +0200
Return the code "-EPROBE_DEFER" directly in one if branch
without assigning it to the local variable "err" before.
Signed-off-by: Markus Elfring <elfr...@users.sourceforge.ne
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Tue, 24 Oct 2017 19:12:09 +0200
Add a jump target so that a bit of exception handling can be better reused
at the end of this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Tue, 24 Oct 2017 19:29:39 +0200
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Use common error handling code
Use an error code directly
drivers/gpu/drm/tegra/output.
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Tue, 24 Oct 2017 17:47:37 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script “checkpatch.pl” pointed information out like the following.
Comparison to NULL could be written !…
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Tue, 24 Oct 2017 17:16:09 +0200
Add a jump target so that a bit of exception handling can be better reused
at the end of this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Tue, 24 Oct 2017 17:55:43 +0200
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Use common error handling code in rcar_du_encoders_init()
Adjust 14 checks for null po
>> Do you prefer to delegate the proposed software refactoring
>> only to a corresponding optimiser?
>
> yes.
Will any applications around the semantic patch language
(Coccinelle software) fit also in the preferred tool category?
Regards,
Markus
___
>> … It's just that two out of three error
>> messages happened to be the same and Markus wants to save a bit of
>> memory by using the same string. The memory savings is not so big that
>> it's worth making the code less readable.
>
> I agree with Dan.
>
> It doesn't save any real memory
> This isn't the case here.
I find your view interesting for further clarification somehow.
> Instead of making the code more readable, we're making it more convoluted.
Can the shown software refactoring usually help here?
> It's just that two out of three error messages happened to be the
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Tue, 24 Oct 2017 15:40:47 +0200
Adjust jump targets so that a specific error code assignment
will be in the implementation only at the end of this function.
This issue was detected by using the Coccinelle software.
Signed-off-by:
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Tue, 24 Oct 2017 15:15:20 +0200
A jump was specified for a location which was directly behind.
Thus remove such an unnecessary goto statement.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Tue, 24 Oct 2017 15:54:32 +0200
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an unnecessary goto statement in intel_dp_sink_crc()
Use common error handlin
>> Add a jump target so that a call of the function "gvt_vgpu_err" is stored
>> only once at the end of this function implementation.
>> Replace two calls by goto statements.
>>
>> This issue was detected by using the Coccinelle software.
>
> I don't think this is an issue or an improvement.
Do
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Tue, 24 Oct 2017 14:20:06 +0200
Add a jump target so that a call of the function "gvt_vgpu_err" is stored
only once at the end of this function implementation.
Replace two calls by goto statements.
This issue was d
>> @@ -1401,11 +1400,14 @@ static void exynos_dsi_enable(struct drm_encoder
>> *encoder)
>> dsi->state &= ~DSIM_STATE_ENABLED;
>> exynos_dsi_set_display_enable(dsi, false);
>> drm_panel_unprepare(dsi->panel);
>> -
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Tue, 24 Oct 2017 10:20:20 +0200
The script "checkpatch.pl" pointed misspelled words out.
Thus fix the affected places.
Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
---
drivers/gpu/drm/exynos
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Tue, 24 Oct 2017 09:50:54 +0200
Adjust jump targets so that a bit of exception handling can be better
reused at the end of this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Tue, 24 Oct 2017 09:32:18 +0200
Add a jump target so that a bit of exception handling can be better reused
at the end of this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Tue, 24 Oct 2017 10:34:56 +0200
Three update suggestions were taken into account
from static source code analysis.
Markus Elfring (3):
Use common error handling code in exynos_dsi_enable()
Use common error handlin
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Mon, 23 Oct 2017 21:27:30 +0200
Add a jump target so that a call of the function "mutex_unlock" is stored
only once at the end of this function implementation.
Replace three calls by goto statements.
This issue was d
>> ret = i2c_smbus_write_byte_data(client, offset, value);
>> -if (ret < 0) {
>> -dev_err(ctx->dev, "writebm: %4s[0x%02x] <- 0x%02x\n",
>> -sii9234_client_name[id], offset, value);
>> -ctx->i2c_error = ret;
>> -}
>> +if (!ret)
>> +
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Sun, 22 Oct 2017 21:50:51 +0200
* Add a jump target so that a bit of exception handling can be better
reused at the end of this function.
This issue was detected by using the Coccinelle software.
* Adjust condition checks.
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Sun, 22 Oct 2017 21:21:44 +0200
* Add a jump target so that a bit of exception handling can be better
reused at the end of this function.
This issue was detected by using the Coccinelle software.
* Adjust condition checks.
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Wed, 10 May 2017 17:03:20 +0200
* Use a special format string specification for the desired output of the
array "val" into a sequence.
* Adjust two local variables accordingly.
This refactoring supersedes the u
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Mon, 8 May 2017 13:42:03 +0200
A single character (line break) should be put into a sequence.
Thus use the corresponding function "seq_putc".
This issue was detected by using the Coccinelle software.
Signed-off-by: Mark
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Mon, 8 May 2017 13:08:11 +0200
The script "checkpatch.pl" pointed information out like the following.
WARNING: Possible unnecessary 'out of memory' message
Thus remove such a statement here.
Link:
http://events.lin
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Mon, 8 May 2017 13:00:28 +0200
Two single characters (line breaks) should be put into a sequence.
Thus use the corresponding function "seq_putc".
This issue was detected by using the Coccinelle software.
Signed-off-by
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Mon, 8 May 2017 13:16:15 +0200
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Use seq_putc() in etnaviv_buffer_dump()
Delete an error message for a failed memory allo
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Mon, 8 May 2017 10:55:42 +0200
Three single characters (line breaks) should be put into a sequence.
Thus use the corresponding function "seq_putc".
This issue was detected by using the Coccinelle software.
Signed-off-by
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Mon, 8 May 2017 10:54:17 +0200
The script "checkpatch.pl" pointed information out like the following.
Comparison to NULL could be written "!attach"
Thus adjust this expression.
Signed-of
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Mon, 8 May 2017 10:50:09 +0200
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Li
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Mon, 8 May 2017 10:32:44 +0200
A bit of data was put into a sequence by two separate function calls.
Print the same data by a single function call instead.
This issue was detected by using the Coccinelle software.
Signed-off-by:
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Mon, 8 May 2017 11:05:05 +0200
A few update suggestions were taken into account
from static source code analysis.
Markus Elfring (4):
Combine two function calls into one in dma_buf_debug_show()
Improve a size determi
>> 1. I suggest to combine a few functions into fewer ones.
>>* Do you spot any programming mistakes in these concrete cases?
>
> Not in the patches I skimmed.
Thanks for such feedback.
> However, your history of breaking code tells me that there have been mistakes
> missed in the past.
I
> Generally speaking, I don't care about checkpatch/cocci changes that aren't
> tested.
I find this view interesting only to some degree.
1. I suggest to combine a few functions into fewer ones.
* Do you spot any programming mistakes in these concrete cases?
* Can such code reduction
> It seems like you're back to submitting cocci patches again :)
My contribution activities are varying also for Linux software over time. ;-)
The corresponding source code search patterns get different popularity.
> I don't want to waste your time by ignoring your patches, so please ensure
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Fri, 5 May 2017 15:33:19 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script “checkpatch.pl” pointed information out like the following.
Comparison to NULL could be written !…
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Fri, 5 May 2017 15:32:08 +0200
Adjust this description for a function call.
Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
---
drivers/gpu/drm/sti/sti_tvout.c | 2 +-
1 file changed, 1 insertion(+), 1 delet
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Fri, 5 May 2017 15:30:44 +0200
Add a missing character in this description for a data structure.
Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
---
drivers/gpu/drm/sti/sti_cursor.c | 2 +-
1 file changed,
From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Fri, 5 May 2017 15:00:46 +0200
Single characters should be put into a sequence at several places.
Thus use the corresponding function "seq_putc".
This issue was detected by using the Coccinelle software.
Signed-off-by
301 - 400 of 603 matches
Mail list logo
