problem for me since I
> ran into it too [1].
>
> Tested-by: Douglas Anderson
>
> [1]
> https://lore.kernel.org/r/CAD=FV=XnpS-=cookkxzfm8og9wcsemxfesmftyh811438qg...@mail.gmail.com
>
I do not like Perl.
IMHO, Python should be OK if Perl is OK.
I agree that the required version should be
documented changes.rst, at least.
--
Best Regards
Masahiro Yamada
gt; [user@localhost linux]$
>
> I'm not familiar with kbuild. Can anyone troubleshoot it further? You
> can find .config from attachment.
I do not have time to take a look at every build error,
but somebody in the DRM list may help you.
--
Best Regards
Masahiro Yamada
epends on DRM'.
This commit encloses the entire DRM configuration with 'if DRM' and
'endif', except for DRM_PANEL_ORIENTATION_QUIRKS.
Note:
Now, 'depends on DRM' properties inside the if-block are all redundant.
I leave it as follow-up cleanups.
Signed-off-by: Masahiro Yamada
Acked-by: Arnd Be
This commit surrounds the entire DRM configuration with 'if DRM' and
'endif', except DRM_PANEL_ORIENTATION_QUIRKS.
Note:
Now, 'depends on DRM' properties inside 'if DRM' ... 'endif' are
all redundant. I leave it as follow-up cleanups.
Signed-off-by: Masahiro Yamada
---
drivers/gpu/drm/
g" makes sense only when it is
followed by "if".
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
index 5a0c476361c3..6984b3fea271 100644
--- a/drivers/gpu/drm/Kconfig
+++ b/drivers/gpu/drm/Kconfig
@@ -29,6 +29,8 @@ menuconfig DRM
details. You should also select and configure AGP
(/dev/agpgart) support if it is available for your platform.
+if DRM
+
config DRM_MIPI_DBI
tristate
depends on DRM
@@ -414,3 +416,5 @@ config DRM_LIB_RANDOM
config DRM_PRIVACY_SCREEN
bool
default n
+
+endif
--
Best Regards
Masahiro Yamada
the kbuild tree, it already touches
> too many places at once.
>
> It may be better for me to just drop the drivers/gpu/ part of
> my patch so you can just just take your patch through the
> drm tree. I actually have a similar patch for the amdgpu driver
> that I can send if you like this option better.
>
> Arnd
>
Applied to linux-kbuild/fixes.
Thanks.
--
Best Regards
Masahiro Yamada
On Mon, Feb 26, 2024 at 8:01 PM Dmitry Baryshkov
wrote:
>
> On Mon, 26 Feb 2024 at 08:33, Masahiro Yamada wrote:
> >
> > On Mon, Feb 26, 2024 at 11:11 AM Dmitry Baryshkov
> > wrote:
> > >
> > > The driver might decide to put the _shipped files
s/gpu/drm/msm/adreno/adreno_gpu.h
@@ -12,7 +12,7 @@
#include
#include
-#include "msm_gpu.h"
+#include "../msm_gpu.h"
#include "adreno_common.xml.h"
#include "adreno_pm4.xml.h"
--
Best Regards
Masahiro Yamada
@@
> # SPDX-License-Identifier: GPL-2.0
> ccflags-y := -I $(srctree)/$(src)
> +ccflags-y := -I $(obj)/registers
This accidentally overwrites ccflags-y defined above.
So, "-I $(srctree)/$(src)" is lost.
It should be
ccflags-y += -I $(obj)/registers
I see several build errors.
--
Best Regards
Masahiro Yamada
e. Use 'cat' instead in order to generate a writable file.
> quiet_cmd_copy = COPY$@
> - cmd_copy = cat $< > $@
> + cmd_copy = mkdir -p $(shell dirname $@) && cat $< > $@
>
> $(obj)/%: $(src)/%_shipped
> $(call cmd,copy)
>
> --
> 2.39.2
>
--
Best Regards
Masahiro Yamada
u/drm/msm/registers/xml/dsi_phy_10nm.xml | 102 ++
> drivers/gpu/drm/msm/registers/xml/dsi_phy_14nm.xml | 135 ++
> drivers/gpu/drm/msm/registers/xml/dsi_phy_20nm.xml | 100 ++
> drivers/gpu/drm/msm/registers/xml/dsi_phy_28nm.xml | 180 +++
> .../drm/msm/registers/xml/dsi_phy_28nm_8960.xml| 134 ++
> drivers/gpu/drm/msm/registers/xml/dsi_phy_7nm.xml | 230
> drivers/gpu/drm/msm/registers/xml/edp.xml | 239
> .../drm/msm/registers/xml/freedreno_copyright.xml | 40 +
> drivers/gpu/drm/msm/registers/xml/hdmi.xml | 1015 +++
> drivers/gpu/drm/msm/registers/xml/mdp4.xml | 480 +++
> drivers/gpu/drm/msm/registers/xml/mdp5.xml | 806
> drivers/gpu/drm/msm/registers/xml/mdp_common.xml | 89 ++
> drivers/gpu/drm/msm/registers/xml/mmss_cc.xml | 48 +
> drivers/gpu/drm/msm/registers/xml/msm.xml | 32 +
> drivers/gpu/drm/msm/registers/xml/rules-ng.xsd | 457 +++
> drivers/gpu/drm/msm/registers/xml/sfpb.xml | 17 +
> scripts/Makefile.lib |2 +-
> 47 files changed, 8034 insertions(+), 587 deletions(-)
> ---
> base-commit: ffa0c87f172bf7a0132aa960db412f8d63b2f533
> change-id: 20240225-fd-xml-shipped-ba9a321cdedf
>
> Best regards,
> --
> Dmitry Baryshkov
>
--
Best Regards
Masahiro Yamada
nfig.h
> create mode 100644 drivers/gpu/drm/imagination/pvr_rogue_meta.h
> create mode 100644 drivers/gpu/drm/imagination/pvr_rogue_mips.h
> create mode 100644 drivers/gpu/drm/imagination/pvr_rogue_mips_check.h
> create mode 100644 drivers/gpu/drm/imagination/pvr_rogue_mmu_defs.h
> create mode 100644 drivers/gpu/drm/imagination/pvr_stream.c
> create mode 100644 drivers/gpu/drm/imagination/pvr_stream.h
> create mode 100644 drivers/gpu/drm/imagination/pvr_stream_defs.c
> create mode 100644 drivers/gpu/drm/imagination/pvr_stream_defs.h
> create mode 100644 drivers/gpu/drm/imagination/pvr_sync.c
> create mode 100644 drivers/gpu/drm/imagination/pvr_sync.h
> create mode 100644 drivers/gpu/drm/imagination/pvr_vm.c
> create mode 100644 drivers/gpu/drm/imagination/pvr_vm.h
> create mode 100644 drivers/gpu/drm/imagination/pvr_vm_mips.c
> create mode 100644 drivers/gpu/drm/imagination/pvr_vm_mips.h
> create mode 100644 include/uapi/drm/pvr_drm.h
>
> --
> 2.41.0
>
--
Best Regards
Masahiro Yamada
) \
> > + $(call cc-option, -Wstringop-truncation) \
> > + $(call cc-option, -Wpacked-not-aligned)
> > +subdir-ccflags-y += $(cond-flags)
> > subdir-ccflags-y += -Wno-unused-parameter
> > subdir-ccflags-y += -Wno-type-limits
> > subdir-ccflags-y += -Wno-sign-compare
> > --
> > 2.40.1
> >
--
Best Regards
Masahiro Yamada
With the previous fix, these modules are built from a single C file.
Rename the source files so they match the module names.
Signed-off-by: Masahiro Yamada
Reviewed-by: Laurent Pinchart
Reviewed-by: Liu Ying
---
(no changes since v1)
drivers/gpu/drm/bridge/imx/Makefile
odule-builtin objects").
Split imx-ldb-helper.c into a separate module.
Signed-off-by: Masahiro Yamada
Reviewed-by: Laurent Pinchart
Reviewed-by: Liu Ying
---
Changes in v3:
- Remove MODULE_ALIAS()
Changes in v2:
- Add a separate module instead of making the functions static inline
d
On Sun, Jun 4, 2023 at 10:26 PM Laurent Pinchart
wrote:
>
> Hello Yamada-san,
>
> Thank you for the patch.
>
> On Sun, Jun 04, 2023 at 04:57:12PM +0900, Masahiro Yamada wrote:
> > With CONFIG_DRM_IMX8QM_LDB=m and CONFIG_DRM_IMX8QXP_LDB=y (or vice
> > versa), imx-ldb-
On Sun, Jun 4, 2023 at 1:52 PM Laurent Pinchart
wrote:
>
> Hi Yamada-san,
>
> Thank you for the patch.
>
> On Sun, Jun 04, 2023 at 02:07:46AM +0900, Masahiro Yamada wrote:
> > With CONFIG_DRM_IMX8QM_LDB=m and CONFIG_DRM_IMX8QXP_LDB=y (or vice
> > versa), imx-ldb-
With the previous fix, these modules are built from a single C file.
Rename the source files so they match the module names.
Signed-off-by: Masahiro Yamada
---
(no changes since v1)
drivers/gpu/drm/bridge/imx/Makefile | 4
drivers/gpu/drm/bridge/imx/{imx8qm-ldb
odule-builtin objects").
Split imx-ldb-helper.c into a separate module.
Signed-off-by: Masahiro Yamada
---
Changes in v2:
- Add a separate module instead of making the functions static inline
drivers/gpu/drm/bridge/imx/Kconfig | 5 +
drivers/gpu/drm/bridge/imx/Makefile
With the previous fix, these modules are built from a single C file.
Rename the source files so they match the module names.
Signed-off-by: Masahiro Yamada
---
drivers/gpu/drm/bridge/imx/Makefile | 4
drivers/gpu/drm/bridge/imx/{imx8qm-ldb-drv.c => imx8qm-ld
odule-builtin objects").
Turn helpers in imx-ldb-helper.c into inline functions.
Signed-off-by: Masahiro Yamada
---
drivers/gpu/drm/bridge/imx/Makefile | 4 +-
drivers/gpu/drm/bridge/imx/imx-ldb-helper.c | 221
drivers/gpu/drm/bridge/imx/imx-ldb-help
option from the command line.
https://github.com/u-boot/u-boot/blob/v2023.01/arch/Kconfig#L44
You may get a quick idea of what it will look like.
I will take a look at this direction (the compiler choice in Kconfig first),
but it will not happen soonish due to the limited time for upstream work.
--
Best Regards
Masahiro Yamada
sed/Makefile | 2 +-
> drivers/gpu/drm/amd/display/dc/dml/Makefile | 3 ++-
> scripts/Kconfig.include | 2 +-
> scripts/Makefile.clang | 2 ++
> scripts/Makefile.compiler | 8 +++---
> scripts/as-version.sh | 2 +-
> 21 files changed, 74 insertions(+), 98 deletions(-)
> ---
> base-commit: 88603b6dc419445847923fcb7fe5080067a30f98
> change-id: 20221228-drop-qunused-arguments-0c5c7dae54fb
>
> Best regards,
> --
> Nathan Chancellor
>
--
Best Regards
Masahiro Yamada
c-11+, clang-14+
ifeq ($(call cc-min-version, 11, 14),y)
dwarf-version-y := 5
else
dwarf-version-y := 4
endif
... can be written in a more simpler way:
dwarf-version-y := 4
dwarf-version-$(call gcc-min-version, 11) := 5
dwarf-version-$(call clang-min-version, 14) := 5
With $(call cc-min-version, 11, 14),
you never know the meaning of 11, 14
until you see the definition of this macro.
So, you feel like adding the comment "gcc-11+, clang-14+".
The latter form, the code is self-documenting.
> # ld-option
> # Usage: KBUILD_LDFLAGS += $(call ld-option, -X, -Y)
> --
> 2.37.2.672.g94769d06f0-goog
>
--
Best Regards
Masahiro Yamada
On Wed, Jun 15, 2022 at 5:35 PM Michel Dänzer
wrote:
>
> On 2022-04-14 18:57, Michel Dänzer wrote:
> > On 2022-04-14 17:04, Masahiro Yamada wrote:
> >> On Thu, Apr 14, 2022 at 10:50 PM Michel Dänzer
> >> wrote:
> >>> On 2022-04-14 15:34, Alex Deucher wro
rivers.
> >>
> >> Yes, exactly that. I'm like 95% sure that used to work, but I don't know
> >> why exactly either.
> >>
> >>> FWIW, this is pretty common in the kernel according to git grep.
> >>
> >> Maybe Alex or somebody else
tch explciitly
enales the warnings with `-Wdeclaration-after-statement`, which takes
effect regardless of which version of the C standard is in use."
modpost is already built with -std=gnu89.
If Wdeclaration-after-statement is implied by gnu89,
why did nobody notice this before?
--
Best Regards
Masahiro Yamada
xtra, ...
> 'make W=1' option, as well as for three drivers in the kernel that always
> enable -Werror, but it was only observed with the i915 driver so far.
Same here.
enable -Werror, but ...
->
enable -Wextra, but ...
Otherwise,
Acked-by: Masahiro Yamada
Please let me
erpart. However the feedback received from Masahiro Yamada was that
> it is too ugly, not providing much value. And just wrapping in a boolean
> context is too dumb - we could simply open code it.
>
> As detailed in commit babaab2f4738 ("drm/i915: Encapsulate kconfig
> consta
On Fri, Oct 1, 2021 at 12:55 AM Lucas De Marchi
wrote:
>
> On Thu, Sep 30, 2021 at 11:01:36PM +0900, Masahiro Yamada wrote:
> >On Thu, Sep 30, 2021 at 3:34 AM Lucas De Marchi
> > wrote:
> >>
> >> The check for config value doesn't really belong to i915_utils
.
For a few sources of the warnings,
replacing it with != 0 or > 0 is just fine.
Of course, such an ugly macro is not worth being moved to
--
Best Regards
Masahiro Yamada
On Mon, Sep 6, 2021 at 4:34 PM Daniel Vetter wrote:
>
> On Mon, Sep 6, 2021 at 12:49 AM Stephen Rothwell
> wrote:
> > Hi all,
> >
> > On Thu, 2 Sep 2021 07:50:38 +1000 Stephen Rothwell
> > wrote:
> > >
> > > On Fri, 20 Au
9f68dd64 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_requests.h
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_requests.h
> @@ -6,7 +6,7 @@
> #ifndef INTEL_GT_REQUESTS_H
> #define INTEL_GT_REQUESTS_H
>
> -#include
> +#include
>
> struct intel_engine_cs;
> struct intel_gt;
> --
> 2.32.0
>
> --
> Cheers,
> Stephen Rothwell
--
Best Regards
Masahiro Yamada
g.
Signed-off-by: Masahiro Yamada
---
Documentation/process/4.Coding.rst| 2 +-
Documentation/process/submit-checklist.rst| 2 +-
Documentation/translations/it_IT/process/4.Coding.rst | 2 +-
Documentation/translations/it_IT/proc
On Thu, Feb 4, 2021 at 12:23 AM Petr Mladek wrote:
>
> On Tue 2021-02-02 09:44:22, John Ogness wrote:
> > On 2021-02-02, Masahiro Yamada wrote:
> > > CONSOLE_LOGLEVEL_DEFAULT is nothing more than a shorthand of
> > > CONFIG_CONSOLE_LOGLEVEL_DEFAUL
On Tue, Feb 2, 2021 at 7:09 PM Sergey Senozhatsky
wrote:
>
> On (21/02/02 16:02), Masahiro Yamada wrote:
> >
> > CONSOLE_LOGLEVEL_DEFAULT is nothing more than a shorthand of
> > CONFIG_CONSOLE_LOGLEVEL_DEFAULT.
> >
> > When you change CONFIG_CONSOLE_LOGLEVEL_
include/generated/compile.h
UPD include/generated/compile.h
CC init/version.o
AR init/built-in.a
LD vmlinux.o
...
For the same reason, do likewise for CONSOLE_LOGLEVEL_QUIET and
MESSAGE_LOGLEVEL_DEFAULT.
Signed-off-by: Masahiro Yamada
---
arch/x86
On Thu, Jan 21, 2021 at 6:39 AM Rob Herring wrote:
>
> On Wed, Jan 20, 2021 at 03:23:51PM +0900, Masahiro Yamada wrote:
> > As commit d0e628cd817f ("kbuild: doc: clarify the difference between
> > extra-y and always-y") explained, extra-y should be used for listing
>
As commit d0e628cd817f ("kbuild: doc: clarify the difference between
extra-y and always-y") explained, extra-y should be used for listing
the prerequsites of vmlinux. always-y is a better fix here.
Signed-off-by: Masahiro Yamada
---
Documentation/devicetree/bindings/Mak
On Wed, Jul 8, 2020 at 3:06 AM Randy Dunlap wrote:
>
> Drop the doubled word "the".
>
> Signed-off-by: Randy Dunlap
> Cc: Jonathan Corbet
> Cc: linux-...@vger.kernel.org
> Cc: Masahiro Yamada
I guess this series will go in via the doc sub-system.
If so,
)/' is added to allow
include/trace/define_trace.h to find the gvt/trace.h
By setting the correct relative path to TRACE_INCLUDE_PATH, this -I
is also unneeded.
Signed-off-by: Masahiro Yamada
---
drivers/gpu/drm/i915/gvt/Makefile | 1 -
drivers/gpu/drm/i915/gvt/trace.h | 2 +-
2 files changed, 1
Including subdirectory Makefile from the driver main Makefile does not
buy us much because this is not real isolation.
Having a single Makefile at the top of the module is clearer, and
it is what this driver almost does.
Move all gvt objects to the i915 main Makefile.
Signed-off-by: Masahiro
Hi Rob,
On Mon, Mar 30, 2020 at 4:09 PM Masahiro Yamada wrote:
>
> On Thu, Mar 26, 2020 at 7:06 AM Rob Herring wrote:
> >
> > Setting 'additionalProperties: false' is frequently omitted, but is
> > important in order to check that there aren't extra undocumented
>
all
> those occurrences.
>
> Cc: Stephen Boyd
> Cc: Linus Walleij
> Cc: Bartosz Golaszewski
> Cc: Masahiro Yamada
> Cc: Jonathan Cameron
> Cc: Hartmut Knaack
> Cc: Lars-Peter Clausen
> Cc: Peter Meerwald-Stadler
> Cc: Neil Armstrong
> Cc: Mauro Carvalho Chehab
&
ob Herring
> ---
> .../devicetree/bindings/gpio/socionext,uniphier-gpio.yaml | 2 ++
You may have already queue this up, but just in case.
Acked-by: Masahiro Yamada
--
Best Regards
Masahiro Yamada
___
dri-devel mailing list
dri-devel@li
On Fri, Mar 27, 2020 at 5:46 AM Jason A. Donenfeld wrote:
>
> On Thu, Mar 26, 2020 at 2:44 PM Masahiro Yamada wrote:
> > I collected more Reviewed-by and Acked-by,
> > then pushed this series to
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux
nto -next ASAP, today would be ideal for test
> coverage ...
I collected more Reviewed-by and Acked-by,
then pushed this series to
git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git
kbuild-asinstr
It will show up in -next soon.
--
Best Regards
Masahiro Yamada
version to 2.21").
I confirmed the code in $(call as-instr,...) can be assembled by the
binutils 2.21 assembler and also by LLVM integrated assembler.
Remove CONFIG_AS_MOVNTDQA, which is always defined.
Signed-off-by: Masahiro Yamada
Reviewed-by: Nick Desaulniers
---
Changes in v2: None
):
x86: probe assembler capabilities via kconfig instead of makefile
crypto: x86 - rework configuration based on Kconfig
crypto: curve25519 - do not pollute dispatcher based on assembler
x86: update AS_* macros to binutils >=2.23, supporting ADX and AVX2
Masahiro Yamada (11):
lib/raid6/t
Hi Ingo,
On Wed, Mar 25, 2020 at 1:59 PM Ingo Molnar wrote:
>
>
> * Masahiro Yamada wrote:
>
> > This series of cleanups was prompted by Linus:
> > https://lkml.org/lkml/2020/3/12/726
> >
> > First, this series drop always-on CONFIG_AS_* options.
> > So
On Wed, Mar 25, 2020 at 4:42 AM Alex Deucher wrote:
>
> On Tue, Mar 24, 2020 at 12:48 PM Masahiro Yamada wrote:
> >
> > Hi,
> >
> > I think this series is a good clean-up.
> >
> > Could you take a look at this please?
>
> Can you resend? I d
Hi,
I think this series is a good clean-up.
Could you take a look at this please?
On Fri, Feb 14, 2020 at 12:40 AM Masahiro Yamada wrote:
>
> A header include path without $(srctree)/ is suspicious because it does
> not work with O= builds.
>
> You can build drivers/gpu/drm/
Hi i915 maintainers,
On Mon, Mar 23, 2020 at 11:12 AM Masahiro Yamada wrote:
>
> CONFIG_AS_MOVNTDQA was introduced by commit 0b1de5d58e19 ("drm/i915:
> Use SSE4.1 movntdqa to accelerate reads from WC memory").
>
> We raise the minimal supported binutils version from
version to 2.21").
I confirmed the code in $(call as-instr,...) can be assembled by the
binutils 2.21 assembler and also by LLVM integrated assembler.
Remove CONFIG_AS_MOVNTDQA, which is always defined.
Signed-off-by: Masahiro Yamada
Reviewed-by: Nick Desaulniers
---
drivers/gpu/drm/i9
: curve25519 - do not pollute dispatcher based on assembler
x86: update AS_* macros to binutils >=2.23, supporting ADX and AVX2
Masahiro Yamada (11):
lib/raid6/test: fix build on distros whose /bin/sh is not bash
x86: remove unneeded defined(__ASSEMBLY__) check from asm/dwarf2.h
x86: rem
version to 2.21").
I confirmed the code in $(call as-instr,...) can be assembled by the
binutils 2.21 assembler and also by Clang's integrated assembler.
Remove CONFIG_AS_MOVNTDQA, which is always defined.
Signed-off-by: Masahiro Yamada
---
drivers/gpu/drm/i915/Makefile | 3 ---
/r300.o
Signed-off-by: Masahiro Yamada
---
drivers/gpu/drm/radeon/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/Makefile b/drivers/gpu/drm/radeon/Makefile
index 480a8d4a3c82..11c97edde54d 100644
--- a/drivers/gpu/drm/radeon/Makefile
+++ b
This Makefile repeats similar build rules. Use a pattern rule.
Signed-off-by: Masahiro Yamada
---
drivers/gpu/drm/radeon/Makefile | 29 +
1 file changed, 1 insertion(+), 28 deletions(-)
diff --git a/drivers/gpu/drm/radeon/Makefile b/drivers/gpu/drm/radeon/Makefile
if_changed must have FORCE as a prerequisite, and the targets must be
added to 'targets'.
Signed-off-by: Masahiro Yamada
---
drivers/gpu/drm/radeon/Makefile | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/radeon/Makefile b/drivers
The headers in the gem/selftests/, gt/selftests, gvt/, selftests/
directories have never been compile-tested, but it would be possible
to make them self-contained.
This commit only addresses missing and forward
struct declarations.
Signed-off-by: Masahiro Yamada
---
Rebase on git
The headers in the gem/selftests/, gt/selftests, gvt/, selftests/
directories have never been compile-tested, but it would be possible
to make them self-contained.
This commit only addresses missing and forward
struct declarations.
Signed-off-by: Masahiro Yamada
---
drivers/gpu/drm/i915/gem
On Fri, Nov 8, 2019 at 2:15 PM Masahiro Yamada
wrote:
>
> The headers in the gem/selftests/, gt/selftests, gvt/, selftests/
> directories have never been compile-tested, but it would be possible
> to make them self-contained.
>
> This commit only addresses missing an
Since this function is defined in a header file, it should be
'static inline' instead of 'static'.
Signed-off-by: Masahiro Yamada
---
drivers/gpu/drm/i915/gem/selftests/mock_dmabuf.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gem/selftests
--
Best Regards
Masahiro Yamada
d by
'depends on ATARI' or 'depends on AMIGA'.
The correct tag is:
Fixes: 9012d011660e ("compiler: allow all arches to enable
CONFIG_OPTIMIZE_INLINING")
The commit id is stable.
As an additional work,
depends on (AMIGA || COMPILE_TEST)
would be nice unless this driver contains m68k-specific code.
--
Best Regards
Masahiro Yamada
> Signed-off-by: Geert Uytterhoeven
Reviewed-by: Masahiro Yamada
--
Best Regards
Masahiro Yamada
AMDDALPATH)/dc/dml/dcn21/display_mode_vba_21.o := $(dml_ccflags)
> CFLAGS_$(AMDDALPATH)/dc/dml/dcn21/display_rq_dlg_calc_21.o := $(dml_ccflags)
> --
> 2.6.2
>
--
Best Regards
Masahiro Yamada
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
lan to send a formal patch with
> Signed-off-by.
>
CONFIG_DRM is tristate.
Your patch requires everything under drivers/gpu/drm/
modular when CONFIG_DRM=m.
At least, drivers/gpu/drm/drm_mipi_dsi.c
is built-in only.
I guess that is the reason why
they use 'obj-y += drm/'.
In other words, if you are able to
make all the drm code modular,
your patch is applicable.
--
Best Regards
Masahiro Yamada
Since commit 04d5e2765802 ("drm/amdgpu: Merge amdkfd into amdgpu"),
drivers/gpu/drm/amd/amdkfd/Makefile does not contain any syntax that
is understood by the build system.
Signed-off-by: Masahiro Yamada
---
drivers/gpu/drm/Makefile | 1 -
1 file changed, 1 deletion(-)
diff --git a/d
This tool is only used by drivers/video/logo/Makefile. No reason to
keep it in scripts/.
Signed-off-by: Masahiro Yamada
---
drivers/video/logo/.gitignore | 1 +
drivers/video/logo/Makefile | 10 +-
{scripts => drivers/video/logo}/pnmtologo.c | 0
scri
The pattern *.o is cleaned up globally by the top Makefile.
Signed-off-by: Masahiro Yamada
---
Changes in v2: None
drivers/video/logo/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/logo/Makefile b/drivers/video/logo/Makefile
index 228a89b9bdd1
Currently, all the logo C files are generated irrespective of the
CONFIG options. Adding them to extra-y is wrong. What we need to do
here is to add them to 'targets' so that if_changed works properly.
Files listed in 'targets' are cleaned, so clean-files is unneeded.
Signed-off-by: Masahiro
Changes in v2:
- Fix commit log
Masahiro Yamada (4):
video/logo: remove unneeded *.o pattern from clean-files
video/logo: do not generate unneeded logo C files
video/logo: simplify cmd_logo
video/logo: move pnmtologo tool to drivers/video/logo/ from scripts/
drivers/video/logo
Shorten the code. It still works in the same way.
Signed-off-by: Masahiro Yamada
---
Changes in v2: None
drivers/video/logo/Makefile | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/video/logo/Makefile b/drivers/video/logo/Makefile
index 16f60c1e1766
This tool is only used by drivers/video/logo/Makefile. No reason to
keep it in scripts/.
Signed-off-by: Masahiro Yamada
---
Changes in v2: None
drivers/video/logo/.gitignore | 1 +
drivers/video/logo/Makefile | 10 +-
{scripts => drivers/video/l
On Wed, Aug 21, 2019 at 12:56 PM Masahiro Yamada
wrote:
I will replace 'font' -> 'logo'.
(My brain was corrupted.)
> Currently, all the font C files are generated irrespective of CONFIG
> options. Adding them to extra-y is wrong. What we need to do here is
> to add them to
The pattern *.o is cleaned up globally by the top Makefile.
Signed-off-by: Masahiro Yamada
---
drivers/video/logo/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/logo/Makefile b/drivers/video/logo/Makefile
index 228a89b9bdd1..10b75ce3ce09 100644
Currently, all the font C files are generated irrespective of CONFIG
options. Adding them to extra-y is wrong. What we need to do here is
to add them to 'targets' so that if_changed works properly.
All files listed in 'targets' are cleaned, so clean-files is unneeded.
Signed-off-by: Masahiro
Masahiro Yamada (4):
video/logo: remove unneeded *.o pattern from clean-files
video/logo: fix unneeded generation of font C files
video/logo: simplify cmd_logo
video/logo: move pnmtologo tool to drivers/video/logo/ from scripts/
drivers/video/logo/.gitignore | 1
Shorten the code. It still works in the same way.
Signed-off-by: Masahiro Yamada
---
drivers/video/logo/Makefile | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/video/logo/Makefile b/drivers/video/logo/Makefile
index 16f60c1e1766..7d672d40bf01 100644
You can use the -y syntax in sub-directory Makefiles
of modules.
Demonstrate how it works.
PLEASE DO NOT APPLY FOR NOW: this is only for comments.
Signed-off-by: Masahiro Yamada
---
drivers/gpu/drm/i915/Makefile | 126 ++--
drivers/gpu/drm/i915/display/Makefile
ags-y does not work.
The single targets directly descend into the directory of
that file resides.
It missed subdir-ccflags-y if it is specifies in parent
Makefiles.
Perhaps, I will have to manage correct implementation of single targets.
Masahiro Yamada (5):
kbuild: treat
Add header include guards just in case.
Signed-off-by: Masahiro Yamada
---
include/video/ili9320.h | 4
include/video/platform_lcd.h | 4
2 files changed, 8 insertions(+)
diff --git a/include/video/ili9320.h b/include/video/ili9320.h
index 62f424f0bc52..b76a0b8f16fc 100644
ndan Higgins
> Cc: Masahiro Yamada
> Cc: Michal Marek
> Reviewed-by: Greg Kroah-Hartman
> Reviewed-by: Logan Gunthorpe
> ---
> Kconfig | 2 ++
> Makefile | 2 +-
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Kconfig b/Kconfig
> index 48a80bea
On Fri, Jul 5, 2019 at 12:23 PM Randy Dunlap wrote:
>
> On 7/4/19 8:09 PM, Masahiro Yamada wrote:
> > On Fri, Jul 5, 2019 at 12:05 PM Masahiro Yamada
> > wrote:
> >>
> >> On Fri, Jul 5, 2019 at 10:09 AM Randy Dunlap wrote:
> >>>
> >
On Fri, Jul 5, 2019 at 12:05 PM Masahiro Yamada
wrote:
>
> On Fri, Jul 5, 2019 at 10:09 AM Randy Dunlap wrote:
> >
> > On 7/4/19 3:01 PM, a...@linux-foundation.org wrote:
> > > The mm-of-the-moment snapshot 2019-07-04-15-01 has been uploaded to
> > >
> &
d
>
I checked next-20190704 tag.
I see the empty file
drivers/gpu/drm/i915/oa/Makefile
Did someone delete it?
--
Best Regards
Masahiro Yamada
On Wed, May 15, 2019 at 3:25 PM Chris Wilson wrote:
>
> Quoting Masahiro Yamada (2019-05-15 05:37:53)
> > The top level Makefile adds -Wall globally:
> >
> > KBUILD_CFLAGS := -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs
> > \
> >
> > I
The top level Makefile adds -Wall globally:
KBUILD_CFLAGS := -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs \
I see two "-Wall" added for compiling under drivers/gpu/drm/i915/.
Signed-off-by: Masahiro Yamada
---
BTW, I have a question in the comment:
"Note the
ernel/ certs/ mm/ fs/ ipc/ security/ crypto/ block/
> +core-y += kernel/ certs/ mm/ fs/ ipc/ security/ crypto/ block/ kunit/
>
> vmlinux-dirs := $(patsubst %/,%,$(filter %/, $(init-y) $(init-m) \
> $(core-y) $(core-m) $(drivers-y) $(drivers-m) \
> --
>
Hi.
On Fri, Mar 29, 2019 at 8:37 PM Masahiro Yamada
wrote:
>
> Currently, the Kbuild core manipulates header search paths in a crazy
> way [1].
>
> To fix this mess, I want all Makefiles to add explicit $(srctree)/ to
> the search paths in the srctree. Some Makefiles a
consistent, and finally get rid of the gross hacks.
Having whitespaces after -I does not matter since commit 48f6e3cf5bc6
("kbuild: do not drop -I without parameter").
[1]: https://patchwork.kernel.org/patch/9632347/
Signed-off-by: Masahiro Yamada
Reviewed-by: Sam Ravnborg
---
I put a
On Thu, Jan 31, 2019 at 1:01 PM Masahiro Yamada
wrote:
>
> Currently, the Kbuild core manipulates header search paths in a crazy
> way [1].
>
> To fix this mess, I want all Makefiles to add explicit $(srctree)/ to
> the search paths in the srctree. Some Makefiles are already wri
consistent, and finally get rid of the gross hacks.
Having whitespaces after -I does not matter since commit 48f6e3cf5bc6
("kbuild: do not drop -I without parameter").
[1]: https://patchwork.kernel.org/patch/9632347/
Signed-off-by: Masahiro Yamada
---
I put all gpu/drm changes into a si
Hi.
2018-07-06 14:12 GMT+09:00 Masahiro Yamada :
> I refactored the include directives under include/drm/ some time ago.
> This flag is unneeded.
>
> Signed-off-by: Masahiro Yamada
Ping?
> ---
>
> drivers/gpu/drm/scheduler/Makefile | 1 -
> 1 file changed, 1 de
Please do not comment out unneeded code. Remove.
Signed-off-by: Masahiro Yamada
---
drivers/gpu/drm/bridge/synopsys/Makefile | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/synopsys/Makefile
b/drivers/gpu/drm/bridge/synopsys/Makefile
index 5dad97d..3e1b1e3 100644
I refactored the include directives under include/drm/ some time ago.
This flag is unneeded.
Signed-off-by: Masahiro Yamada
---
drivers/gpu/drm/scheduler/Makefile | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/scheduler/Makefile
b/drivers/gpu/drm/scheduler/Makefile
index
Please do not comment out unneeded code, but remove it.
Signed-off-by: Masahiro Yamada
---
drivers/gpu/drm/bridge/synopsys/Makefile | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/synopsys/Makefile
b/drivers/gpu/drm/bridge/synopsys/Makefile
index 5dad97d..3e1b1e3
er (to get right) to have two separate rules, and let make chain them
> automatically.
>
> Gr{oetje,eeting}s,
>
> Geert
>
I submit the patches.
I'd like to queue them up for the next merge window,
so your problems will be fixed if Kbuild pull requests are pul
o get right) to have two separate rules, and let make chain them
> automatically.
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 --
> ge...@linux-m68k.org
>
> In personal conversations with tech
1 - 100 of 206 matches
Mail list logo
