Re: [RESEND] drm/edid/firmware: stop using a throwaway platform device

ssues/2061 Reported-by: Matthieu CHARETTE Tested-by: Matthieu CHARETTE Cc: Ville Syrjälä Signed-off-by: Jani Nikula Acked-by: Thomas Zimmermann I looked through request_firmware() but did not see any signs that it somehow depends on a platform device. I assume that this might on

Re: [PATCH] drm/edid/firmware: stop using throwaway platform device

Hi, I've tested the patch and I can confirm that it fixed the issue. Tested on Fedora 36 with kernel 6.0.8. Thanks, Matthieu On Tue, Nov 8 2022 at 04:40:52 PM +0100, Matthieu CHARETTE wrote: I didn't test the patch yet. I will do. But even without testing I can tell you that it will work

Re: [PATCH] drm/edid/firmware: stop using throwaway platform device

kind of kernel panic. Matthieu On Tue, Nov 8 2022 at 01:27:33 PM +0200, Jani Nikula wrote: On Sun, 06 Nov 2022, Matthieu CHARETTE wrote: Hi, Can you tell me what are we waiting for? Maybe I can help. Have you tried the patch? Is it an improvement over the status quo? The "

Re: [PATCH] drm/edid/firmware: stop using throwaway platform device

Hi, Can you tell me what are we waiting for? Maybe I can help. Thanks. Matthieu On Wed, Oct 12 2022 at 07:16:29 PM +0200, Matthieu CHARETTE wrote: By crash, I mean that an error is returned here: https://kernel.googlesource.com/pub/scm/linux/kernel/git/torvalds/linux.git/+/refs/heads

Re: [PATCH] drm/edid/firmware: stop using throwaway platform device

: On Tue, 11 Oct 2022, Matthieu CHARETTE wrote: Currently the EDID is requested during the resume. But since it's requested too early, this means before the filesystem is mounted, the firmware request fails. This make the DRM driver crash when resuming. This kind of issue should

Re: [PATCH] drm/edid/firmware: stop using throwaway platform device

: > On Tue, 11 Oct 2022, Matthieu CHARETTE wrote: >> It should fix the issue. Meanwhile, the system will still crash if a >> new monitor is plugged while the machine is suspended. We might need to >> precache the EDID to prevent that. > > Please elaborate. > > BR, > J

Re: [PATCH] drm/edid/firmware: stop using throwaway platform device

way to go ;) References: https://lore.kernel.org/r/20220727074152.43059-1-matthieu.chare...@gmail.com Cc: Matthieu CHARETTE Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid_load.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drive

Re: [PATCH] drm: Fix EDID firmware load on resume

the machine. Or you may have a better idea? Thanks, Matthieu On Mon, Aug 8 2022 at 08:19:01 PM +0300, Jani Nikula wrote: On Mon, 08 Aug 2022, Matthieu CHARETTE wrote: Sorry, What do you mean? You cache with one name at connector init time, but the name specified using drm.edid_firmware may

Re: [PATCH] drm: Fix EDID firmware load on resume

Sorry, What do you mean? Matthieu On Tue, Aug 2 2022 at 05:29:12 PM +0300, Jani Nikula wrote: On Wed, 27 Jul 2022, Matthieu CHARETTE wrote: Loading an EDID using drm.edid_firmware parameter makes resume to fail after firmware cache is being cleaned. This is because edid_load() use

Re: [PATCH] drm: Fix EDID firmware load on resume

Sorry, What do you mean? Matthieu On Tue, Aug 2 2022 at 05:29:12 PM +0300, Jani Nikula wrote: On Wed, 27 Jul 2022, Matthieu CHARETTE <mailto:matthieu.chare...@gmail.com>> wrote: Loading an EDID using drm.edid_firmware parameter makes resume to fail after firmware cache is bein

Re: [PATCH] drm: Fix EDID firmware load on resume

device can take more memory than 128 bytes of data. I let you decide which option is better. Just tell me if I should cache the bytes instead. Thanks. Matthieu On Wed, Jul 27 2022 at 10:18:48 AM +0200, Takashi Iwai wrote: On Wed, 27 Jul 2022 09:41:52 +0200, Matthieu CHARETTE wrote: Loading

[PATCH] drm: Fix EDID firmware load on resume

during resume. So the request_firmware() call should use a permanent device for each connector. Also, we should cache the EDID even if no monitor is connected, in case it's plugged while suspended. Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2061 Signed-off-by: Matthieu CHARETTE

[PATCH] drm: Fix EDID firmware load on resume

during resume. So the request_firmware() call should use a permanent device for each connector. Also, we should cache the EDID even if no monitor is connected, in case it's plugged while suspended. Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2061 Signed-off-by: Matthieu CHARETTE

Re: [PATCH] drm: Fix EDID firmware load on resume

Hi, Sorry, my email client removed every tab. I will send the v2 in a new thread. Thanks. Matthieu On Thu, Jul 14 2022 at 11:23:10 AM -0300, André Almeida wrote: Hi Matthieu, Thanks for your patch. Às 11:58 de 06/07/22, Matthieu CHARETTE escreveu: Loading an EDID using

Re: [PATCH] drm: Fix EDID firmware load on resume

Sorry, I forgot to add a tag. --- Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2061 On Wed, Jul 6 2022 at 04:58:08 PM +0200, Matthieu CHARETTE wrote: Loading an EDID using drm.edid_firmware parameter makes resume to fail after firmware cache is being cleaned. This is because

[PATCH] drm: Fix EDID firmware load on resume

during resume. So the request_firmware() call should use a permanent device for each connector. Also, we should cache the EDID even if no monitor is connected, in case it's plugged while suspended. Signed-off-by: Matthieu CHARETTE --- drivers/gpu/drm/drm_connector.c | 9 drivers/gpu/drm