Re: [Intel-gfx] [PATCH v3 1/3] drm/i915: pass a pointer for tlb seqno at vma_invalidate_tlb()

2022-08-08 Thread Mauro Carvalho Chehab
0200, Andi Shyti wrote: > > > > Hi Mauro, > > > > > > > > On Thu, Aug 04, 2022 at 09:37:22AM +0200, Mauro Carvalho Chehab > > > > wrote: > > > > > WRITE_ONCE() should happen at the original var, not on a local > > > > > copy of it. >

Re: [Intel-gfx] [PULL] drm-intel-next-fixes

2022-08-05 Thread Mauro Carvalho Chehab
On Fri, 5 Aug 2022 10:39:44 -0400 Rodrigo Vivi wrote: > On Fri, Aug 05, 2022 at 10:46:57AM +0200, Mauro Carvalho Chehab wrote: > > Hi Rodrigo, > > > > On Thu, 4 Aug 2022 13:33:06 -0400 > > Rodrigo Vivi wrote: > > > > > Hi Dave and Daniel, > >

Re: [Intel-gfx] [PATCH v3 3/3] drm/i915/gt: document TLB cache invalidation functions

2022-08-05 Thread Mauro Carvalho Chehab
On Fri, 5 Aug 2022 10:24:25 +0100 Tvrtko Ursulin wrote: > On 05/08/2022 10:08, Andi Shyti wrote: > > Hi Randy, > > > >>> +/** > >>> + * intel_gt_invalidate_tlb_full - do full TLB cache invalidation > >>> + * @gt: GT structure > >> > >> In multiple places (here and below) it would be nice to

Re: [Intel-gfx] [PULL] drm-intel-next-fixes

2022-08-05 Thread Mauro Carvalho Chehab
Hi Rodrigo, On Thu, 4 Aug 2022 13:33:06 -0400 Rodrigo Vivi wrote: > Hi Dave and Daniel, > > Here goes drm-intel-next-fixes-2022-08-04: > > - disable pci resize on 32-bit systems (Nirmoy) > - don't leak the ccs state (Matt) > - TLB invalidation fixes (Chris) > > Thanks, > Rodrigo. > > The fol

[PATCH v3 0/3] Move TLB invalidation code for its own file and document it

2022-08-04 Thread Mauro Carvalho Chehab
/PDF; - Remove mention for GuC, as this depends on a series that will be sent later. Chris Wilson (1): drm/i915/gt: Move TLB invalidation to its own file Mauro Carvalho Chehab (2): drm/i915: pass a pointer for tlb seqno at vma_invalidate_tlb() drm/i915/gt: document TLB cache invalidation

[PATCH v3 3/3] drm/i915/gt: document TLB cache invalidation functions

2022-08-04 Thread Mauro Carvalho Chehab
Add a description for the TLB cache invalidation algorithm and for the related kAPI functions. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v3 0/3] at: https://lore.kernel.org/all/cover

[PATCH v3 1/3] drm/i915: pass a pointer for tlb seqno at vma_invalidate_tlb()

2022-08-04 Thread Mauro Carvalho Chehab
WRITE_ONCE() should happen at the original var, not on a local copy of it. Fixes: 5d36acb7198b ("drm/i915/gt: Batch TLB invalidations") Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH

[PATCH v3 2/3] drm/i915/gt: Move TLB invalidation to its own file

2022-08-04 Thread Mauro Carvalho Chehab
Wilson Reviewed-by: Niranjana Vishwanathapura Reviewed-by: Andi Shyti Cc: Fei Yang Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v3 0/3] at: https://lore.kernel.org/all/cover.1659598090.git.mche

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/gt: document TLB cache invalidation functions

2022-08-04 Thread Mauro Carvalho Chehab
On Tue, 2 Aug 2022 15:30:44 -0700 Niranjana Vishwanathapura wrote: > On Fri, Jul 29, 2022 at 09:03:55AM +0200, Mauro Carvalho Chehab wrote: > >Add a description for the TLB cache invalidation algorithm and for > >the related kAPI functions. > > > >Signed-of

Re: [Intel-gfx] [PATCH v2 09/21] drm/i915/guc: Define CTB based TLB invalidation routines

2022-08-02 Thread Mauro Carvalho Chehab
On Thu, 14 Jul 2022 16:06:28 +0200 Michal Wajdeczko wrote: > On 14.07.2022 14:06, Mauro Carvalho Chehab wrote: > > From: Prathap Kumar Valsan > > > > Add routines to interface with GuC firmware for TLB invalidation. > > > > Signed-off-by: Prathap Kumar Va

[PATCH v2 1/2] drm/i915/gt: Move TLB invalidation to its own file

2022-07-29 Thread Mauro Carvalho Chehab
From: Chris Wilson Prepare for supporting more TLB invalidation scenarios by moving the current MMIO invalidation to its own file. Signed-off-by: Chris Wilson Cc: Fei Yang Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C

[PATCH v2 0/2] Move TLB invalidation code for its own file and document it

2022-07-29 Thread Mauro Carvalho Chehab
text form and after its conversion to HTML/PDF; - Remove mention for GuC, as this depends on a series that will be sent later. Chris Wilson (1): drm/i915/gt: Move TLB invalidation to its own file Mauro Carvalho Chehab (1): drm/i915/gt: document TLB cache invalidation functions

[PATCH v2 2/2] drm/i915/gt: document TLB cache invalidation functions

2022-07-29 Thread Mauro Carvalho Chehab
Add a description for the TLB cache invalidation algorithm and for the related kAPI functions. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v2 0/2] at: https://lore.kernel.org/all/cover

Re: [Intel-gfx] [PATCH v3 0/6] drm/i915: reduce TLB performance regressions

2022-07-28 Thread Mauro Carvalho Chehab
https://patchwork.freedesktop.org/series/106806/ That should make easier to maintain TLB-related code and have such functions properly documented. Regards, Mauro > > Thanks, > Andi > > On Wed, Jul 27, 2022 at 02:29:50PM +0200, Mauro Carvalho Chehab wrote: > > Doing TLB invalidation

[PATCH 0/2] Move TLB invalidation code for its own file and document it

2022-07-28 Thread Mauro Carvalho Chehab
There are more things to be added to TLB invalidation. Before doing that, move the code to its own file, and add the relevant documentation. Chris Wilson (1): drm/i915/gt: Move TLB invalidation to its own file Mauro Carvalho Chehab (1): drm/i915/gt: document TLB cache invalidation functions

[PATCH 1/2] drm/i915/gt: Move TLB invalidation to its own file

2022-07-28 Thread Mauro Carvalho Chehab
From: Chris Wilson Prepare for supporting more TLB invalidation scenarios by moving the current MMIO invalidation to its own file. Signed-off-by: Chris Wilson Cc: Fei Yang Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C

[PATCH 2/2] drm/i915/gt: document TLB cache invalidation functions

2022-07-28 Thread Mauro Carvalho Chehab
Add a description for the TLB cache invalidation algorithm and for the related kAPI functions. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH 0/2] at: https://lore.kernel.org/all/cover.1659011328

Re: [Intel-gfx] [PATCH v2 06/21] drm/i915/gt: Batch TLB invalidations

2022-07-28 Thread Mauro Carvalho Chehab
On Thu, 28 Jul 2022 08:32:32 +0200 Mauro Carvalho Chehab wrote: > On Wed, 27 Jul 2022 13:56:50 +0100 > Tvrtko Ursulin wrote: > > > > Because vma_invalidate_tlb() basically stores a TLB seqno, but the > > > actual invalidation is deferred to w

Re: [Intel-gfx] [PATCH v2 06/21] drm/i915/gt: Batch TLB invalidations

2022-07-27 Thread Mauro Carvalho Chehab
On Wed, 27 Jul 2022 13:56:50 +0100 Tvrtko Ursulin wrote: > > Because vma_invalidate_tlb() basically stores a TLB seqno, but the > > actual invalidation is deferred to when the pages are unset, at > > __i915_gem_object_unset_pages(). > > > > So, what happens is: > > > > - on VMA sync mode, the n

[PATCH v3 0/6] drm/i915: reduce TLB performance regressions

2022-07-27 Thread Mauro Carvalho Chehab
ilson (4): drm/i915/gt: Ignore TLB invalidations on idle engines drm/i915/gt: Invalidate TLB of the OA unit at TLB invalidations drm/i915/gt: Skip TLB invalidations once wedged drm/i915/gt: Batch TLB invalidations Mauro Carvalho Chehab (2): drm/i915/gt: document with_intel_gt_pm_if_awake() d

[PATCH v3 6/6] drm/i915/gt: describe the new tlb parameter at i915_vma_resource

2022-07-27 Thread Mauro Carvalho Chehab
. Document it. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v3 0/6] at: https://lore.kernel.org/all/cover.1658924372.git.mche...@kernel.org/ drivers/gpu/drm/i915/i915_vma_resource.c | 4 1 file

[PATCH v3 5/6] drm/i915/gt: Batch TLB invalidations

2022-07-27 Thread Mauro Carvalho Chehab
] Cc: sta...@vger.kernel.org Fixes: 7938d61591d3 ("drm/i915: Flush TLBs before releasing backing store") Suggested-by: Tvrtko Ursulin Signed-off-by: Chris Wilson Cc: Fei Yang Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing list

[PATCH v3 3/6] drm/i915/gt: Invalidate TLB of the OA unit at TLB invalidations

2022-07-27 Thread Mauro Carvalho Chehab
: Fei Yang Reviewed-by: Andi Shyti Acked-by: Tvrtko Ursulin Acked-by: Thomas Hellström Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v3 0/6] at: https://lore.kernel.org/all/cover.165892437

[PATCH v3 2/6] drm/i915/gt: document with_intel_gt_pm_if_awake()

2022-07-27 Thread Mauro Carvalho Chehab
Add a kernel-doc markup to document this new macro. Reviewed-by: Tvrtko Ursulin Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v3 0/6] at: https://lore.kernel.org/all/cover.1658924372.git.mche

[PATCH v3 1/6] drm/i915/gt: Ignore TLB invalidations on idle engines

2022-07-27 Thread Mauro Carvalho Chehab
ned-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v3 0/6] at: https://lore.kernel.org/all/cover.1658924372.git.mche...@kernel.org/ drivers/gpu/drm/i915/gem/i915_gem_pages.c | 10 ++ drivers/gpu/d

[PATCH v3 4/6] drm/i915/gt: Skip TLB invalidations once wedged

2022-07-27 Thread Mauro Carvalho Chehab
cked-by: Thomas Hellström Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v3 0/6] at: https://lore.kernel.org/all/cover.1658924372.git.mche...@kernel.org/ drivers/gpu/drm/i915/gt/intel_gt.c | 3 +++

Re: [Intel-gfx] [PATCH v2 06/21] drm/i915/gt: Batch TLB invalidations

2022-07-27 Thread Mauro Carvalho Chehab
On Wed, 20 Jul 2022 11:49:59 +0100 Tvrtko Ursulin wrote: > On 20/07/2022 08:13, Mauro Carvalho Chehab wrote: > > On Mon, 18 Jul 2022 14:52:05 +0100 > > Tvrtko Ursulin wrote: > > > >> > >> On 14/07/2022 13:06, Mauro Carvalho Chehab wrote: > >>

Re: [Intel-gfx] [PATCH v2 06/21] drm/i915/gt: Batch TLB invalidations

2022-07-20 Thread Mauro Carvalho Chehab
On Mon, 18 Jul 2022 14:52:05 +0100 Tvrtko Ursulin wrote: > > On 14/07/2022 13:06, Mauro Carvalho Chehab wrote: > > From: Chris Wilson > > > > Invalidate TLB in patch, in order to reduce performance regressions. > > "in batches"? Yeah. Will fix it.

Re: [Intel-gfx] [PATCH v2 05/21] drm/i915/gt: Skip TLB invalidations once wedged

2022-07-18 Thread Mauro Carvalho Chehab
On Mon, 18 Jul 2022 14:45:22 +0100 Tvrtko Ursulin wrote: > On 14/07/2022 13:06, Mauro Carvalho Chehab wrote: > > From: Chris Wilson > > > > Skip all further TLB invalidations once the device is wedged and > > had been reset, as, on such cases, it can no longer proc

Re: [Intel-gfx] [PATCH v2 04/21] drm/i915/gt: Only invalidate TLBs exposed to user manipulation

2022-07-18 Thread Mauro Carvalho Chehab
On Mon, 18 Jul 2022 14:39:17 +0100 Tvrtko Ursulin wrote: > On 14/07/2022 13:06, Mauro Carvalho Chehab wrote: > > From: Chris Wilson > > > > Don't flush TLBs when the buffer is only used in the GGTT under full > > control of the kernel, as there's no ri

Re: [Intel-gfx] [PATCH v2 01/21] drm/i915/gt: Ignore TLB invalidations on idle engines

2022-07-18 Thread Mauro Carvalho Chehab
On Mon, 18 Jul 2022 14:16:10 +0100 Tvrtko Ursulin wrote: > On 14/07/2022 13:06, Mauro Carvalho Chehab wrote: > > From: Chris Wilson > > > > Check if the device is powered down prior to any engine activity, > > as, on such cases, all the TLBs were already invalida

Re: [Intel-gfx] [PATCH v2 24/39] drm/i915: dvo_sil164.c: use SPDX header

2022-07-18 Thread Mauro Carvalho Chehab
On Fri, 15 Jul 2022 15:16:05 -0700 Joe Perches wrote: > On Fri, 2022-07-15 at 17:35 -0400, Rodrigo Vivi wrote: > > On Wed, Jul 13, 2022 at 09:12:12AM +0100, Mauro Carvalho Chehab wrote: > > > This file is licensed with MIT license. Change its license text

[PATCH RFC] drm/i915/gt: Retry RING_HEAD reset until it sticks

2022-07-15 Thread Mauro Carvalho Chehab
c: Andrzej Hajda Cc: Mika Kuoppala Signed-off-by: Mauro Carvalho Chehab --- .../gpu/drm/i915/gt/intel_ring_submission.c | 44 +-- drivers/gpu/drm/i915/i915_utils.h | 10 + 2 files changed, 40 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/d

Re: [PATCH] Revert "drm/amdgpu: add drm buddy support to amdgpu"

2022-07-14 Thread Mauro Carvalho Chehab
hing is ok. Probably the issue was due to some badly solved merge conflict. Thank you! Mauro > > Alex > > > > > > I will double check drm-tip once more. > > > > Regards, > > Christian. > > > > Am 14.07.22 um 14:54 schrieb Mauro Carval

Re: [PATCH] Revert "drm/amdgpu: add drm buddy support to amdgpu"

2022-07-14 Thread Mauro Carvalho Chehab
On Thu, 14 Jul 2022 15:08:48 +0200 Christian König wrote: > Hi Mauro, > > well the last time I checked drm-tip was clean. > > The revert is necessary because we had some problems with the commit > which we couldn't fix in the 5.19 cycle. I see. I don't have any issues with the patch itself, p

Re: [PATCH] Revert "drm/amdgpu: add drm buddy support to amdgpu"

2022-07-14 Thread Mauro Carvalho Chehab
On Fri, 8 Jul 2022 03:21:24 -0700 Arunpravin Paneer Selvam wrote: > This reverts the following commits: > commit 708d19d9f362 ("drm/amdgpu: move internal vram_mgr function into the C > file") > commit 5e3f1e7729ec ("drm/amdgpu: fix start calculation in > amdgpu_vram_mgr_new") > commit c9cad937c

[PATCH v2 08/21] drm/i915/gt: Move TLB invalidation to its own file

2022-07-14 Thread Mauro Carvalho Chehab
From: Chris Wilson Prepare for supporting more TLB invalidation scenarios by moving the current MMIO invalidation to its own file. Signed-off-by: Chris Wilson Cc: Fei Yang Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C

[PATCH v2 19/21] drm/i915/gt: document TLB cache invalidation functions

2022-07-14 Thread Mauro Carvalho Chehab
Add a description for the kAPI functions inside intel_tlb.c. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v2 00/21] at: https://lore.kernel.org/all/cover.1657800199.git.mche...@kernel.org

[PATCH v2 01/21] drm/i915/gt: Ignore TLB invalidations on idle engines

2022-07-14 Thread Mauro Carvalho Chehab
can only do so when the connection to the GuC is awake. Cc: sta...@vger.kernel.org Fixes: 7938d61591d3 ("drm/i915: Flush TLBs before releasing backing store") Signed-off-by: Chris Wilson Cc: Fei Yang Cc: Andi Shyti Cc: Thomas Hellström Signed-off-by: Mauro Carvalho Chehab ---

[PATCH v2 15/21] drm/i915: Add platform macro for selective tlb flush

2022-07-14 Thread Mauro Carvalho Chehab
From: Prathap Kumar Valsan Add support for selective TLB invalidation, which is a platform feature supported on XeHP. Signed-off-by: Prathap Kumar Valsan Cc: Niranjana Vishwanathapura Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing

[PATCH v2 14/21] drm/i915: document tlb field at struct drm_i915_gem_object

2022-07-14 Thread Mauro Carvalho Chehab
Add documentation to the TLB field inside struct drm_i915_gem_object. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v2 00/21] at: https://lore.kernel.org/all/cover.1657800199.git.mche

[PATCH v2 02/21] drm/i915/gt: document with_intel_gt_pm_if_awake()

2022-07-14 Thread Mauro Carvalho Chehab
Add a kernel-doc markup to document this new macro. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v2 00/21] at: https://lore.kernel.org/all/cover.1657800199.git.mche...@kernel.org/ drivers/gpu

[PATCH v2 18/21] drm/i915: Use selective tlb invalidations where supported

2022-07-14 Thread Mauro Carvalho Chehab
ff-by: Prathap Kumar Valsan Cc: Niranjana Vishwanathapura Cc: Fei Yang Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v2 00/21] at: https://lore.kernel.org/all/cover.1657800199.git.mche...@kerne

[PATCH v2 09/21] drm/i915/guc: Define CTB based TLB invalidation routines

2022-07-14 Thread Mauro Carvalho Chehab
From: Prathap Kumar Valsan Add routines to interface with GuC firmware for TLB invalidation. Signed-off-by: Prathap Kumar Valsan Cc: Bruce Chang Cc: Michal Wajdeczko Cc: Matthew Brost Cc: Chris Wilson Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of

[PATCH v2 11/21] drm/i915/guc: document the TLB invalidation struct members

2022-07-14 Thread Mauro Carvalho Chehab
Add documentation for the 3 new members of struct intel_guc that are used to handle TLB cache invalidation logic. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v2 00/21] at: https

[PATCH v2 00/21] Fix performance regressions with TLB and add GuC support

2022-07-14 Thread Mauro Carvalho Chehab
drm/i915/gt: Batch TLB invalidations drm/i915/gt: Move TLB invalidation to its own file drm/i915: Invalidate the TLBs on each GT Mauro Carvalho Chehab (8): drm/i915/gt: document with_intel_gt_pm_if_awake() drm/i915/gt: describe the new tlb parameter at i915_vma_resource drm/i915/guc: use k

[PATCH v2 04/21] drm/i915/gt: Only invalidate TLBs exposed to user manipulation

2022-07-14 Thread Mauro Carvalho Chehab
erformance regression introduced by TLB invalidate logic. Cc: sta...@vger.kernel.org Fixes: 7938d61591d3 ("drm/i915: Flush TLBs before releasing backing store") Signed-off-by: Chris Wilson Cc: Fei Yang Cc: Andi Shyti Acked-by: Thomas Hellström Signed-off-by: Mauro Carvalho Chehab --- To

[PATCH v2 06/21] drm/i915/gt: Batch TLB invalidations

2022-07-14 Thread Mauro Carvalho Chehab
] Cc: sta...@vger.kernel.org Fixes: 7938d61591d3 ("drm/i915: Flush TLBs before releasing backing store") Suggested-by: Tvrtko Ursulin Signed-off-by: Chris Wilson Cc: Fei Yang Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing list

[PATCH v2 13/21] drm/i915: Invalidate the TLBs on each GT

2022-07-14 Thread Mauro Carvalho Chehab
From: Chris Wilson With multi-GT devices, the object may have been bound on each GT. Invalidate the TLBs across all GT before releasing the pages back to the system. Signed-off-by: Chris Wilson Cc: Fei Yang Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of

[PATCH v2 03/21] drm/i915/gt: Invalidate TLB of the OA unit at TLB invalidations

2022-07-14 Thread Mauro Carvalho Chehab
i Yang Cc: Andi Shyti Acked-by: Thomas Hellström Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v2 00/21] at: https://lore.kernel.org/all/cover.1657800199.git.mche...@kernel.org/ drivers/gpu/d

[PATCH v2 17/21] drm/i915: Add generic interface for tlb invalidation for XeHP

2022-07-14 Thread Mauro Carvalho Chehab
Yang Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v2 00/21] at: https://lore.kernel.org/all/cover.1657800199.git.mche...@kernel.org/ drivers/gpu/drm/i915/gt/intel_gt_regs.h | 8 +++ drivers

[PATCH v2 16/21] drm/i915: Define GuC Based TLB invalidation routines

2022-07-14 Thread Mauro Carvalho Chehab
From: Prathap Kumar Valsan Add routines to interface with GuC firmware for selective TLB invalidation supported on XeHP. Signed-off-by: Prathap Kumar Valsan Cc: Matthew Brost Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C

[PATCH v2 20/21] drm/i915/guc: describe enum intel_guc_tlb_invalidation_type

2022-07-14 Thread Mauro Carvalho Chehab
Add a description for intel_guc_tlb_invalidation_type enum. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v2 00/21] at: https://lore.kernel.org/all/cover.1657800199.git.mche...@kernel.org

[PATCH v2 10/21] drm/i915/guc: use kernel-doc for enum intel_guc_tlb_inval_mode

2022-07-14 Thread Mauro Carvalho Chehab
Transform the comments for intel_guc_tlb_inval_mode into a kernel-doc markup. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v2 00/21] at: https://lore.kernel.org/all/cover.1657800199.git.mche

[PATCH v2 21/21] drm/i915/guc: document TLB cache invalidation functions

2022-07-14 Thread Mauro Carvalho Chehab
Add documentation for the kAPI functions that do TLB cache invalidation via GuC. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v2 00/21] at: https://lore.kernel.org/all/cover.1657800199.git.mche

[PATCH v2 12/21] drm/i915/guc: Introduce TLB_INVALIDATION_ALL action

2022-07-14 Thread Mauro Carvalho Chehab
From: Piotr Piórkowski Add a new way to invalidate TLB via GuC using actions 0x7002 (TLB_INVALIDATION_ALL). Those actions will be used on upcoming patches. Signed-off-by: Piotr Piórkowski Cc: Michal Wajdeczko Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number

[PATCH v2 05/21] drm/i915/gt: Skip TLB invalidations once wedged

2022-07-14 Thread Mauro Carvalho Chehab
ed by TLB invalidate logic. Cc: sta...@vger.kernel.org Fixes: 7938d61591d3 ("drm/i915: Flush TLBs before releasing backing store") Signed-off-by: Chris Wilson Cc: Fei Yang Cc: Andi Shyti Acked-by: Thomas Hellström Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a

[PATCH v2 07/21] drm/i915/gt: describe the new tlb parameter at i915_vma_resource

2022-07-14 Thread Mauro Carvalho Chehab
. Document it. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v2 00/21] at: https://lore.kernel.org/all/cover.1657800199.git.mche...@kernel.org/ drivers/gpu/drm/i915/i915_vma_resource.c | 4 1

Re: [PATCH v3 4/7] drm/i915: Check for integer truncation on the configuration of ttm place

2022-07-14 Thread Mauro Carvalho Chehab
Add safe_conversion_gem_bug_on() macro and remove temporal > SAFE_CONVERSION() macro. > > Signed-off-by: Gwan-gyeong Mun > Cc: Chris Wilson > Cc: Matthew Auld > Cc: Thomas Hellström > Reviewed-by: Nirmoy Das LGTM. Reviewed-by: Mauro Carvalho Chehab > --- > dr

Re: [PATCH v3 2/7] drm/i915/gem: Typecheck page lookups

2022-07-14 Thread Mauro Carvalho Chehab
gt; Signed-off-by: Gwan-gyeong Mun > Cc: Tvrtko Ursulin > Cc: Matthew Auld > Cc: Thomas Hellström > Reviewed-by: Nirmoy Das LGTM, so: > Reviewed-by: Mauro Carvalho Chehab Yet, it would make sense to have some patch adding kernel-doc markups to the kAPI functions declared at the

Re: [PATCH v3 1/7] drm: Move and add a few utility macros into drm util header

2022-07-14 Thread Mauro Carvalho Chehab
dify overflows_type() macro to consider signed data types (Mauro) > Fix the problem that safe_conversion() macro always returns true > > Signed-off-by: Gwan-gyeong Mun > Cc: Thomas Hellström > Cc: Matthew Auld > Cc: Nirmoy Das > Cc: Jani Nikula LGTM. Reviewed-by: Ma

Re: [Intel-gfx] [PATCH v2 06/39] drm/i915: gt: fix some Kernel-doc issues

2022-07-14 Thread Mauro Carvalho Chehab
On Wed, 13 Jul 2022 18:07:44 -0400 Rodrigo Vivi wrote: > On Wed, Jul 13, 2022 at 09:11:54AM +0100, Mauro Carvalho Chehab wrote: > > There are several trivial warnings there, due to trivial things: > > - lack of function name at the kerneldoc markup; > > - undocumente

Re: [Intel-gfx] [PATCH v2 05/39] drm/i915: display: fix kernel-doc markup warnings

2022-07-14 Thread Mauro Carvalho Chehab
On Wed, 13 Jul 2022 18:05:06 -0400 Rodrigo Vivi wrote: > On Wed, Jul 13, 2022 at 09:11:53AM +0100, Mauro Carvalho Chehab wrote: > > There are a couple of issues at i915 display kernel-doc markups: > > > > drivers/gpu/drm/i915/display/intel_display_debugfs.c:2238: w

Re: [Intel-gfx] [PATCH v2 01/39] drm/i915/gvt: Fix kernel-doc for intel_gvt_switch_mmio()

2022-07-14 Thread Mauro Carvalho Chehab
On Wed, 13 Jul 2022 18:00:59 -0400 Rodrigo Vivi wrote: > On Wed, Jul 13, 2022 at 05:54:44PM -0400, Rodrigo Vivi wrote: > > On Wed, Jul 13, 2022 at 09:11:49AM +0100, Mauro Carvalho Chehab wrote: > > > From: Jiapeng Chong > > > > > > Fix the following W=1 k

[PATCH 19/21] drm/i915/gt: document TLB cache invalidation functions

2022-07-13 Thread Mauro Carvalho Chehab
Add a description for the kAPI functions inside intel_tlb.c. Signed-off-by: Mauro Carvalho Chehab --- See [PATCH 00/21] at: https://lore.kernel.org/all/cover.1657703926.git.mche...@kernel.org/ drivers/gpu/drm/i915/gt/intel_tlb.c | 36 + 1 file changed, 36

[PATCH 13/21] drm/i915: Invalidate the TLBs on each GT

2022-07-13 Thread Mauro Carvalho Chehab
From: Chris Wilson With multi-GT devices, the object may have been bound on each GT. Invalidate the TLBs across all GT before releasing the pages back to the system. Signed-off-by: Chris Wilson Cc: Fei Yang Signed-off-by: Mauro Carvalho Chehab --- See [PATCH 00/21] at: https

[PATCH 06/21] drm/i915/gt: Batch TLB invalidations

2022-07-13 Thread Mauro Carvalho Chehab
] Cc: sta...@vger.kernel.org Fixes: 7938d61591d3 ("drm/i915: Flush TLBs before releasing backing store") Suggested-by: Tvrtko Ursulin Signed-off-by: Chris Wilson Cc: Fei Yang Signed-off-by: Mauro Carvalho Chehab --- See [PATCH 00/21] at: https://lore.kernel.org/all/cover.165770392

[PATCH 09/21] drm/i915/guc: Define CTB based TLB invalidation routines

2022-07-13 Thread Mauro Carvalho Chehab
From: Prathap Kumar Valsan Add routines to interface with GuC firmware for TLB invalidation. Signed-off-by: Prathap Kumar Valsan Cc: Bruce Chang Cc: Michal Wajdeczko Cc: Matthew Brost Cc: Chris Wilson Signed-off-by: Mauro Carvalho Chehab --- See [PATCH 00/21] at: https://lore.kernel.org

[PATCH 21/21] drm/i915/guc: document TLB cache invalidation functions

2022-07-13 Thread Mauro Carvalho Chehab
Add documentation for the kAPI functions that do TLB cache invalidation via GuC. Signed-off-by: Mauro Carvalho Chehab --- See [PATCH 00/21] at: https://lore.kernel.org/all/cover.1657703926.git.mche...@kernel.org/ drivers/gpu/drm/i915/gt/uc/intel_guc.c | 52 ++ 1 file

[PATCH 00/21] Fix performance regressions with TLB and add GuC support

2022-07-13 Thread Mauro Carvalho Chehab
t TLB invalidations drm/i915/gt: Only invalidate TLBs exposed to user manipulation drm/i915/gt: Skip TLB invalidations once wedged drm/i915/gt: Batch TLB invalidations drm/i915/gt: Move TLB invalidation to its own file drm/i915: Invalidate the TLBs on each GT Mauro Carvalho Chehab (8):

[PATCH 07/21] drm/i915/gt: describe the new tlb parameter at i915_vma_resource

2022-07-13 Thread Mauro Carvalho Chehab
. Document it. Signed-off-by: Mauro Carvalho Chehab --- See [PATCH 00/21] at: https://lore.kernel.org/all/cover.1657703926.git.mche...@kernel.org/ drivers/gpu/drm/i915/i915_vma_resource.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_vma_resource.c b/drivers/gpu

[PATCH 12/21] drm/i915/guc: Introduce TLB_INVALIDATION_ALL action

2022-07-13 Thread Mauro Carvalho Chehab
From: Piotr Piórkowski Add a new way to invalidate TLB via GuC using actions 0x7002 (TLB_INVALIDATION_ALL). Those actions will be used on upcoming patches. Signed-off-by: Piotr Piórkowski Cc: Michal Wajdeczko Signed-off-by: Mauro Carvalho Chehab --- See [PATCH 00/21] at: https

[PATCH 04/21] drm/i915/gt: Only invalidate TLBs exposed to user manipulation

2022-07-13 Thread Mauro Carvalho Chehab
erformance regression introduced by TLB invalidate logic. Cc: sta...@vger.kernel.org Fixes: 7938d61591d3 ("drm/i915: Flush TLBs before releasing backing store") Signed-off-by: Chris Wilson Cc: Fei Yang Cc: Andi Shyti Acked-by: Thomas Hellström Signed-off-by: Mauro Carvalho Chehab ---

[PATCH 20/21] drm/i915/guc: describe enum intel_guc_tlb_invalidation_type

2022-07-13 Thread Mauro Carvalho Chehab
Add a description for intel_guc_tlb_invalidation_type enum. Signed-off-by: Mauro Carvalho Chehab --- See [PATCH 00/21] at: https://lore.kernel.org/all/cover.1657703926.git.mche...@kernel.org/ drivers/gpu/drm/i915/gt/uc/abi/guc_actions_abi.h | 12 1 file changed, 12 insertions

[PATCH 14/21] drm/i915: document tlb field at struct drm_i915_gem_object

2022-07-13 Thread Mauro Carvalho Chehab
Add documentation to the TLB field inside struct drm_i915_gem_object. Signed-off-by: Mauro Carvalho Chehab --- See [PATCH 00/21] at: https://lore.kernel.org/all/cover.1657703926.git.mche...@kernel.org/ drivers/gpu/drm/i915/gem/i915_gem_object_types.h | 1 + 1 file changed, 1 insertion

[PATCH 17/21] drm/i915: Add generic interface for tlb invalidation for XeHP

2022-07-13 Thread Mauro Carvalho Chehab
Yang Signed-off-by: Mauro Carvalho Chehab --- See [PATCH 00/21] at: https://lore.kernel.org/all/cover.1657703926.git.mche...@kernel.org/ drivers/gpu/drm/i915/gt/intel_gt_regs.h | 8 +++ drivers/gpu/drm/i915/gt/intel_tlb.c | 78 - drivers/gpu/drm/i915/gt

[PATCH 16/21] drm/i915: Define GuC Based TLB invalidation routines

2022-07-13 Thread Mauro Carvalho Chehab
From: Prathap Kumar Valsan Add routines to interface with GuC firmware for selective TLB invalidation supported on XeHP. Signed-off-by: Prathap Kumar Valsan Cc: Matthew Brost Signed-off-by: Mauro Carvalho Chehab --- See [PATCH 00/21] at: https://lore.kernel.org/all/cover.1657703926

[PATCH 08/21] drm/i915/gt: Move TLB invalidation to its own file

2022-07-13 Thread Mauro Carvalho Chehab
From: Chris Wilson Prepare for supporting more TLB invalidation scenarios by moving the current MMIO invalidation to its own file. Signed-off-by: Chris Wilson Cc: Fei Yang Signed-off-by: Mauro Carvalho Chehab --- See [PATCH 00/21] at: https://lore.kernel.org/all/cover.1657703926.git.mche

[PATCH 15/21] drm/i915: Add platform macro for selective tlb flush

2022-07-13 Thread Mauro Carvalho Chehab
From: Prathap Kumar Valsan Add support for selective TLB invalidation, which is a platform feature supported on XeHP. Signed-off-by: Prathap Kumar Valsan Cc: Niranjana Vishwanathapura Signed-off-by: Mauro Carvalho Chehab --- See [PATCH 00/21] at: https://lore.kernel.org/all/cover

[PATCH 18/21] drm/i915: Use selective tlb invalidations where supported

2022-07-13 Thread Mauro Carvalho Chehab
ff-by: Prathap Kumar Valsan Cc: Niranjana Vishwanathapura Cc: Fei Yang Signed-off-by: Mauro Carvalho Chehab --- See [PATCH 00/21] at: https://lore.kernel.org/all/cover.1657703926.git.mche...@kernel.org/ drivers/gpu/drm/i915/gt/intel_ppgtt.c | 2 +- drivers/gpu/drm/i915/i915_vma.c

[PATCH 01/21] drm/i915/gt: Ignore TLB invalidations on idle engines

2022-07-13 Thread Mauro Carvalho Chehab
can only do so when the connection to the GuC is awake. Cc: sta...@vger.kernel.org Fixes: 7938d61591d3 ("drm/i915: Flush TLBs before releasing backing store") Signed-off-by: Chris Wilson Cc: Fei Yang Cc: Andi Shyti Cc: Thomas Hellström Signed-off-by: Mauro Carvalho Chehab --- See [P

[PATCH 11/21] drm/i915/guc: document the TLB invalidation struct members

2022-07-13 Thread Mauro Carvalho Chehab
Add documentation for the 3 new members of struct intel_guc that are used to handle TLB cache invalidation logic. Signed-off-by: Mauro Carvalho Chehab --- See [PATCH 00/21] at: https://lore.kernel.org/all/cover.1657703926.git.mche...@kernel.org/ drivers/gpu/drm/i915/gt/uc/intel_guc.h | 14

[PATCH 05/21] drm/i915/gt: Skip TLB invalidations once wedged

2022-07-13 Thread Mauro Carvalho Chehab
ed by TLB invalidate logic. Cc: sta...@vger.kernel.org Fixes: 7938d61591d3 ("drm/i915: Flush TLBs before releasing backing store") Signed-off-by: Chris Wilson Cc: Fei Yang Cc: Andi Shyti Acked-by: Thomas Hellström Signed-off-by: Mauro Carvalho Chehab --- See [PATCH 00/21] at: https://

[PATCH 10/21] drm/i915/guc: use kernel-doc for enum intel_guc_tlb_inval_mode

2022-07-13 Thread Mauro Carvalho Chehab
Transform the comments for intel_guc_tlb_inval_mode into a kernel-doc markup. Signed-off-by: Mauro Carvalho Chehab --- See [PATCH 00/21] at: https://lore.kernel.org/all/cover.1657703926.git.mche...@kernel.org/ drivers/gpu/drm/i915/gt/uc/abi/guc_actions_abi.h | 11 +++ 1 file changed

[PATCH 03/21] drm/i915/gt: Invalidate TLB of the OA unit at TLB invalidations

2022-07-13 Thread Mauro Carvalho Chehab
i Yang Cc: Andi Shyti Acked-by: Thomas Hellström Signed-off-by: Mauro Carvalho Chehab --- See [PATCH 00/21] at: https://lore.kernel.org/all/cover.1657703926.git.mche...@kernel.org/ drivers/gpu/drm/i915/gt/intel_gt.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/d

[PATCH 02/21] drm/i915/gt: document with_intel_gt_pm_if_awake()

2022-07-13 Thread Mauro Carvalho Chehab
Add a kernel-doc markup to document this new macro. Signed-off-by: Mauro Carvalho Chehab --- See [PATCH 00/21] at: https://lore.kernel.org/all/cover.1657703926.git.mche...@kernel.org/ drivers/gpu/drm/i915/gt/intel_gt_pm.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu

[PATCH v2 14/39] drm/i915: document kernel-doc trivial issues

2022-07-13 Thread Mauro Carvalho Chehab
drm/i915/gt/uc/intel_guc_hwconfig.c:113: warning: Function parameter or member 'gt' not described in 'guc_hwconfig_init' drivers/gpu/drm/i915/gt/intel_engine_types.h:276: warning: Function parameter or member 'preempt_hang' not described in 'intel_engine_execlists'

[PATCH v2 10/39] drm/i915: i915_gem_ttm: fix a kernel-doc markup

2022-07-13 Thread Mauro Carvalho Chehab
Two new fields were added to __i915_gem_ttm_object_init() without their corresponding documentation. Document them. Fixes: 9b78b5dade2d ("drm/i915: add i915_gem_object_create_region_at()") Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, on

[PATCH v2 28/39] drm/i915: i915_deps: use a shorter title markup

2022-07-13 Thread Mauro Carvalho Chehab
The DOC: tag waits for a one-line short title for the doc section. Using multiple lines will produce a weird output. So, add a shorter description for the title, while keeping the current content below it. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people

[PATCH v2 08/39] drm/i915: gem: fix some Kernel-doc issues

2022-07-13 Thread Mauro Carvalho Chehab
gpu/drm/i915/gem/i915_gem_wait.c:130: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst Caused by: - lack of function name at the kernel-doc markup; - renamed parameters. Address them. Signed-of

[PATCH v2 38/39] drm/i915: add descriptions for some RPM macros at intel_gt_pm.h

2022-07-13 Thread Mauro Carvalho Chehab
The intel_gt_pm.h file contains some convenient macros to be used in GT code in order to get/put runtime PM references and for checking them. Add descriptions based on the ones at intel_wakeref.h and intel_runtime_pm.c. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large

[PATCH v2 20/39] drm/i915: i915_gem_wait.c: fix a kernel-doc markup

2022-07-13 Thread Mauro Carvalho Chehab
The return codes for i915_gem_wait_ioctl() have identation issues, and will be displayed on a very confusing way. Use lists to improve its output. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v2

[PATCH v2 26/39] drm/i915: i915_gem.c fix a kernel-doc issue

2022-07-13 Thread Mauro Carvalho Chehab
Prevent this Sphinx warning: Documentation/foo/i915:728: ./drivers/gpu/drm/i915/i915_gem.c:447: WARNING: Inline emphasis start-string without end-string. By using @data to identify the data field, as expected by kernel-doc. Signed-off-by: Mauro Carvalho Chehab --- To avoid

[PATCH v2 33/39] docs: gpu: i915.rst: PM: add more kernel-doc markups

2022-07-13 Thread Mauro Carvalho Chehab
Both intel_runtime_pm.h and intel_pm.c contains kAPI for runtime PM. So, add them to the documentation. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v2 00/39] at: https://lore.kernel.org/all

[PATCH v2 37/39] drm/i915: document struct drm_i915_gem_object

2022-07-13 Thread Mauro Carvalho Chehab
This is a large struct used to describe gem objects. It is currently partially documented. Finish its documentation, filling the gaps from git logs. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH

[PATCH v2 35/39] docs: gpu: i915.rst: add the remaining kernel-doc markup files

2022-07-13 Thread Mauro Carvalho Chehab
fi; done >aaa Add them to i915.rst as well. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v2 00/39] at: https://lore.kernel.org/all/cover.1657699522.git.mche...

[PATCH v2 11/39] drm/i915: i915_gem_ttm_pm.c: fix kernel-doc markups

2022-07-13 Thread Mauro Carvalho Chehab
i915_gem_ttm_pm.c:199: warning: Excess function parameter 'allow_gpu' description in 'i915_ttm_restore_region' Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v2 00/39] at: https://

[PATCH v2 03/39] drm/i915/gvt: Fix kernel-doc for intel_vgpu_*_resource()

2022-07-13 Thread Mauro Carvalho Chehab
for intel_alloc_vgpu_resource(). Prototype was for intel_vgpu_alloc_resource() instead. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong Acked-by: Zhenyu Wang Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the

[PATCH v2 25/39] drm/i915: i915_vma_resource.c: fix some kernel-doc markups

2022-07-13 Thread Mauro Carvalho Chehab
-string without end-string. That's because @foo evaluates into **foo**, and placing anything after it without spaces cause Sphinx to warn and do the wrong thing.. So, replace them by a different Sphinx-compatible tag. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large numb

[PATCH v2 27/39] drm/i915: i915_scatterlist.h: fix some kernel-doc markups

2022-07-13 Thread Mauro Carvalho Chehab
warn and do the wrong thing.. So, replace them by a different Sphinx-compatible tag. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v2 00/39] at: https://lore.kernel.org/all/cover.1657699522.git

<    1   2   3   4   5   6   7   8   >