[PATCH v3 32/56] video: fix some kernel-doc markups

2020-10-23 Thread Mauro Carvalho Chehab
Some identifiers have different names between their prototypes and the kernel-doc markup. Signed-off-by: Mauro Carvalho Chehab --- drivers/video/fbdev/core/fbcmap.c | 2 +- drivers/video/hdmi.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/video

[PATCH v3 11/56] drm/amdgpu: fix some kernel-doc markups

2020-10-23 Thread Mauro Carvalho Chehab
Some functions have different names between their prototypes and the kernel-doc markup. Signed-off-by: Mauro Carvalho Chehab --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 2 +- include/uapi/drm/amdgpu_drm.h| 2 +- 3 files

[PATCH v3 03/56] amdgpu: fix a few kernel-doc markup issues

2020-10-23 Thread Mauro Carvalho Chehab
A kernel-doc markup can't be mixed with a random comment, as it causes parsing problems. While here, change an invalid kernel-doc markup into a common comment. Signed-off-by: Mauro Carvalho Chehab --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 +--- 1 file changed, 5 insertions(+), 3

[PATCH v3 0/6] Documentation build fixes against upstream

2020-10-21 Thread Mauro Carvalho Chehab
warnings caused by patches pending merges. I'll be posting those in separate. Regards, Mauro Mauro Carvalho Chehab (6): drm: amdgpu: kernel-doc: update some adev parameters docs: lockdep-design: fix some warning issues locking/refcount: move kernel-doc markups to the proper place IB/srpt

[PATCH v3 1/6] drm: amdgpu: kernel-doc: update some adev parameters

2020-10-21 Thread Mauro Carvalho Chehab
meter for it to be the same on all functions using a pointer to struct amdgpu_device. Update the kernel-doc documentation accordingly. Signed-off-by: Mauro Carvalho Chehab --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 28 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c

Re: [PATCH v2 12/24] drm/dp: fix a kernel-doc issue at drm_edid.c

2020-10-21 Thread Mauro Carvalho Chehab
aiting until 5.11 ;-) So, if OK for you, I'll send this upstream via my tree by the end of the merge window, as our goal is that 5.10 won't have doc warnings. Regards, Mauro > > > On Tue, 2020-10-13 at 14:14 +0200, Mauro Carvalho Chehab wrote: > > The name of the argument is dif

Re: [PATCH v6 44/80] docs: gpu: i915.rst: Fix several C duplication warnings

2020-10-16 Thread Mauro Carvalho Chehab
d. Regards, Mauro > > Regards, Joonas > > Quoting Mauro Carvalho Chehab (2020-10-13 14:53:59) > > As reported by Sphinx: > > > > ./Documentation/gpu/i915:646: > > ./drivers/gpu/drm/i915/i915_perf.c:1147: WARNING: Duplicate C declaration, &

Re: [PATCH v6 00/80] htmldoc build fixes with Sphinx 2.x and 3.x

2020-10-15 Thread Mauro Carvalho Chehab
Em Thu, 15 Oct 2020 17:49:23 +0200 Daniel Vetter escreveu: > On Tue, Oct 13, 2020 at 01:53:15PM +0200, Mauro Carvalho Chehab wrote: > > This series actually folds the previous Sphinx 3.x patch series > > with the other patches I sent fixing warnings with Sphinx > > 2.

[PATCH v2 11/24] drm/dp: fix kernel-doc warnings at drm_dp_helper.c

2020-10-13 Thread Mauro Carvalho Chehab
' Some function parameters weren't documented. Fixes: 38784f6f8805 ("drm/dp: Add helpers to identify downstream facing port types") Signed-off-by: Mauro Carvalho Chehab --- drivers/gpu/drm/drm_dp_helper.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_

[PATCH v2 12/24] drm/dp: fix a kernel-doc issue at drm_edid.c

2020-10-13 Thread Mauro Carvalho Chehab
' description in 'drm_display_mode_from_cea_vic' Fixes: 7af655bce275 ("drm/dp: Add drm_dp_downstream_mode()") Signed-off-by: Mauro Carvalho Chehab --- drivers/gpu/drm/drm_edid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/

[PATCH v2 07/24] drm: amdgpu: kernel-doc: update some adev parameters

2020-10-13 Thread Mauro Carvalho Chehab
ation accordingly. Signed-off-by: Mauro Carvalho Chehab --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 6 +++--- drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 5 ++--- 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/dr

[PATCH v2 08/24] drm: kernel-doc: document drm_dp_set_subconnector_property() params

2020-10-13 Thread Mauro Carvalho Chehab
a subconnector property") Signed-off-by: Mauro Carvalho Chehab --- drivers/gpu/drm/drm_dp_helper.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index 90807a6b415c..b1c71af88579 100644 --- a/drivers/gpu

[PATCH v6 79/80] drm: drm_edid: remove a duplicated kernel-doc declaration

2020-10-13 Thread Mauro Carvalho Chehab
-kms-helpers'. Declaration is 'bool drm_edid_are_equal (const struct edid *edid1, const struct edid *edid2)'. So, get rid of the duplicated kernel-doc markup. Signed-off-by: Mauro Carvalho Chehab --- include/drm/drm_edid.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/include

[PATCH v6 56/80] dt-bindings: fix references to files converted to yaml

2020-10-13 Thread Mauro Carvalho Chehab
There were several files converted to yaml, but the .txt file is still referenced somewhere else. Update the references for them to point to the right file. Signed-off-by: Mauro Carvalho Chehab --- .../bindings/display/tilcdc/tilcdc.txt | 2 +- .../devicetree/bindings/mailbox/omap

[PATCH v6 73/80] drm: kernel-doc: drm_dp_helper.h: fix a typo

2020-10-13 Thread Mauro Carvalho Chehab
Right now, kernel-doc generates a warning: ./include/drm/drm_dp_helper.h:1786: warning: Function parameter or member 'hbr2_reset' not described in 'drm_dp_phy_test_params' This is due to a typo: @hb2_reset -> @hbr2_reset Signed-off-by: Mauro Carvalho Chehab --- include/

[PATCH v6 72/80] drm/amd/display: kernel-doc: document force_timing_sync

2020-10-13 Thread Mauro Carvalho Chehab
4e52d0cf24 ("drm/amd/display: Add debugfs for forcing stream timing sync") Signed-off-by: Mauro Carvalho Chehab --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h b/drivers/gpu/drm/a

[PATCH v6 65/80] docs: amdgpu: fix a warning when building the documentation

2020-10-13 Thread Mauro Carvalho Chehab
As reported by Sphinx: Documentation/gpu/amdgpu.rst:200: WARNING: Inline emphasis start-string without end-string. Signed-off-by: Mauro Carvalho Chehab --- Documentation/gpu/amdgpu.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/gpu/amdgpu.rst

[PATCH v6 44/80] docs: gpu: i915.rst: Fix several C duplication warnings

2020-10-13 Thread Mauro Carvalho Chehab
file. Signed-off-by: Mauro Carvalho Chehab --- Documentation/gpu/i915.rst | 29 + 1 file changed, 25 insertions(+), 4 deletions(-) diff --git a/Documentation/gpu/i915.rst b/Documentation/gpu/i915.rst index 33cc6ddf8f64..cff1f154b473 100644 --- a/Documentation/gpu/i915

[PATCH v6 75/80] drm: kernel-doc: add description for a new function parameter

2020-10-13 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab --- drivers/gpu/drm/drm_prime.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c index 1693aa7c14b5..1395688930f8 100644 --- a/drivers/gpu/drm/drm_prime.c +++ b/drivers/gpu/drm/drm_prime.c @@ -793,6 +7

[PATCH v6 74/80] gpu: docs: amdgpu.rst: get rid of wrong kernel-doc markups

2020-10-13 Thread Mauro Carvalho Chehab
altogether. For amdgpu_ras.c, however, we need to remove the kernel-doc with just internal. This should be re-introduced if this file ever gets new non-DOC markups. Signed-off-by: Mauro Carvalho Chehab --- Documentation/gpu/amdgpu.rst | 7 --- 1 file changed, 7 deletions(-) diff --git

Re: [PATCH v2 09/17] mm: Add unsafe_follow_pfn

2020-10-11 Thread Mauro Carvalho Chehab
Em Sun, 11 Oct 2020 08:27:41 +0200 Mauro Carvalho Chehab escreveu: > Em Sat, 10 Oct 2020 23:50:27 +0200 > Daniel Vetter escreveu: > > > On Sat, Oct 10, 2020 at 11:36 PM Laurent Pinchart > > wrote: > > > > > > > > We probably still ha

Re: [PATCH v2 09/17] mm: Add unsafe_follow_pfn

2020-10-11 Thread Mauro Carvalho Chehab
Em Sat, 10 Oct 2020 23:50:27 +0200 Daniel Vetter escreveu: > On Sat, Oct 10, 2020 at 11:36 PM Laurent Pinchart > wrote: > > > > > We probably still have a few legacy drivers using videobuf (non-2), > > > but IMHO those should be safe to put behind some disabled-by-default > > > Kconfig symbol

Re: [PATCH v2 09/17] mm: Add unsafe_follow_pfn

2020-10-10 Thread Mauro Carvalho Chehab
Em Sat, 10 Oct 2020 12:53:49 +0200 Daniel Vetter escreveu: > Hi Mauro, > > You might want to read the patches more carefully, because what you're > demanding is what my patches do. Short summary: > > - if STRICT_FOLLOW_PFN is set: > a) normal memory is handled as-is (i.e. your example works)

Re: [PATCH v2 10/17] media/videbuf1|2: Mark follow_pfn usage as unsafe

2020-10-10 Thread Mauro Carvalho Chehab
Em Fri, 9 Oct 2020 09:59:27 +0200 Daniel Vetter escreveu: > The media model assumes that buffers are all preallocated, so that > when a media pipeline is running we never miss a deadline because the > buffers aren't allocated or available. > > This means we cannot fix the v4l follow_pfn usage

Re: [PATCH v2 09/17] mm: Add unsafe_follow_pfn

2020-10-10 Thread Mauro Carvalho Chehab
Em Fri, 9 Oct 2020 19:52:05 +0200 Daniel Vetter escreveu: > On Fri, Oct 9, 2020 at 2:48 PM Jason Gunthorpe wrote: > > > > On Fri, Oct 09, 2020 at 02:37:23PM +0200, Mauro Carvalho Chehab wrote: > > > > > I'm not a mm/ expert, but, from what I understood from Da

Re: [PATCH v2 09/17] mm: Add unsafe_follow_pfn

2020-10-09 Thread Mauro Carvalho Chehab
Em Fri, 9 Oct 2020 14:37:23 +0200 Mauro Carvalho Chehab escreveu: > Em Fri, 9 Oct 2020 09:21:11 -0300 > Jason Gunthorpe escreveu: > > > On Fri, Oct 09, 2020 at 12:34:21PM +0200, Mauro Carvalho Chehab wrote: > > > Hi, > > > > > > Em Fri, 9 O

Re: [PATCH v2 09/17] mm: Add unsafe_follow_pfn

2020-10-09 Thread Mauro Carvalho Chehab
Em Fri, 9 Oct 2020 09:21:11 -0300 Jason Gunthorpe escreveu: > On Fri, Oct 09, 2020 at 12:34:21PM +0200, Mauro Carvalho Chehab wrote: > > Hi, > > > > Em Fri, 9 Oct 2020 09:59:26 +0200 > > Daniel Vetter escreveu: > > > > > Way back it was a reason

Re: [PATCH v2 09/17] mm: Add unsafe_follow_pfn

2020-10-09 Thread Mauro Carvalho Chehab
Hi, Em Fri, 9 Oct 2020 09:59:26 +0200 Daniel Vetter escreveu: > Way back it was a reasonable assumptions that iomem mappings never > change the pfn range they point at. But this has changed: > > - gpu drivers dynamically manage their memory nowadays, invalidating > ptes with

Re: [PATCH v2 06/17] media: videobuf2: Move frame_vector into media subsystem

2020-10-09 Thread Mauro Carvalho Chehab
viewed-by: John Hubbard > Signed-off-by: Daniel Vetter > Cc: Jason Gunthorpe > Cc: Pawel Osciak > Cc: Marek Szyprowski > Cc: Kyungmin Park > Cc: Tomasz Figa > Cc: Mauro Carvalho Chehab > Cc: Andrew Morton > Cc: John Hubbard > Cc: Jérôme Glisse > Cc: Jan Kara &

[PATCH v5 44/52] docs: gpu: i915.rst: Fix several C duplication warnings

2020-10-06 Thread Mauro Carvalho Chehab
file. Signed-off-by: Mauro Carvalho Chehab --- Documentation/gpu/i915.rst | 29 + 1 file changed, 25 insertions(+), 4 deletions(-) diff --git a/Documentation/gpu/i915.rst b/Documentation/gpu/i915.rst index 33cc6ddf8f64..cff1f154b473 100644 --- a/Documentation/gpu/i915

[PATCH v4 44/52] docs: gpu: i915.rst: Fix several C duplication warnings

2020-09-30 Thread Mauro Carvalho Chehab
file. Signed-off-by: Mauro Carvalho Chehab --- Documentation/gpu/i915.rst | 29 + 1 file changed, 25 insertions(+), 4 deletions(-) diff --git a/Documentation/gpu/i915.rst b/Documentation/gpu/i915.rst index 33cc6ddf8f64..cff1f154b473 100644 --- a/Documentation/gpu/i915

[PATCH v4 20/52] drm: drm_dsc.h: fix a kernel-doc markup

2020-09-30 Thread Mauro Carvalho Chehab
for one struct is wrong, as struct is used twice. Signed-off-by: Mauro Carvalho Chehab --- include/drm/drm_dsc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/drm_dsc.h b/include/drm/drm_dsc.h index 887954cbfc60..732f32740c86 100644 --- a/include/drm/drm_dsc.h

[PATCH 2/3] drm/dp: fix kernel-doc warnings at drm_dp_helper.c

2020-09-22 Thread Mauro Carvalho Chehab
' Some function parameters weren't documented. Fixes: 38784f6f8805 ("drm/dp: Add helpers to identify downstream facing port types") Signed-off-by: Mauro Carvalho Chehab --- drivers/gpu/drm/drm_dp_helper.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_

[PATCH 3/3] drm/dp: fix a kernel-doc issue at drm_edid.c

2020-09-22 Thread Mauro Carvalho Chehab
' description in 'drm_display_mode_from_cea_vic' Fixes: 7af655bce275 ("drm/dp: Add drm_dp_downstream_mode()") Signed-off-by: Mauro Carvalho Chehab --- drivers/gpu/drm/drm_edid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/

[PATCH 0/3] Fix Kernel-doc warnings introduced on next-20200921

2020-09-22 Thread Mauro Carvalho Chehab
A few new warnings were added at linux-next. Address them, in order for us to keep zero warnings at the docs. The entire patchset fixing all kernel-doc warnings is at: https://git.linuxtv.org/mchehab/experimental.git/log/?h=doc-fixes Mauro Carvalho Chehab (3): net: fix a new kernel-doc

Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-10 Thread Mauro Carvalho Chehab
650.c| 5 ++--- > drivers/media/i2c/smiapp/smiapp-core.c| 2 +- > drivers/media/i2c/tvp5150.c | 2 +- > drivers/media/pci/ddbridge/ddbridge-core.c| 2 +- > drivers/media/usb/cpia2/cpi

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-25 Thread Mauro Carvalho Chehab
Em Tue, 25 Aug 2020 05:29:29 +1000 Dave Airlie escreveu: > On Thu, 20 Aug 2020 at 20:02, Laurent Pinchart > wrote: > > > > Hi Mauro, > > > > On Thu, Aug 20, 2020 at 09:03:26AM +0200, Mauro Carvalho Chehab wrote: > > > Em Wed, 19 Aug 2020 12:52:06 -0700

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-24 Thread Mauro Carvalho Chehab
Em Fri, 21 Aug 2020 17:56:50 +0200 Sam Ravnborg escreveu: > Hi Mauro. > > On Fri, Aug 21, 2020 at 04:41:58PM +0200, Mauro Carvalho Chehab wrote: > > Another quick question: > > > > Em Wed, 19 Aug 2020 19:35:58 +0200 > > Sam Ravnborg escreveu: > > &

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-24 Thread Mauro Carvalho Chehab
Em Mon, 24 Aug 2020 08:49:30 +0200 Mauro Carvalho Chehab escreveu: > Hi John, > > Em Wed, 19 Aug 2020 20:28:44 -0700 > John Stultz escreveu: > > > > That said even with the patches I've got on top of your series, I > > still see a few issues: > > 1) I'm s

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-24 Thread Mauro Carvalho Chehab
Hi John, Em Wed, 19 Aug 2020 20:28:44 -0700 John Stultz escreveu: > That said even with the patches I've got on top of your series, I > still see a few issues: > 1) I'm seeing red-blue swap with your driver. I need to dig a bit to > see what the difference is, I know gralloc has a config

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-21 Thread Mauro Carvalho Chehab
Another quick question: Em Wed, 19 Aug 2020 19:35:58 +0200 Sam Ravnborg escreveu: > > +#define DSS_REDUCE(x) ((x) > 0 ? ((x) - 1) : (x)) > Use generic macros for this? Do you know a generic macro similar to this? Or do you mean adding it to include/kernel.h? There are the atomic sub

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-21 Thread Mauro Carvalho Chehab
Em Wed, 19 Aug 2020 19:35:58 +0200 Sam Ravnborg escreveu: > Also a few high level comments: Hi Sam, Finally finished addressing the things you pointed, except by a few ones: - bridge bindings; - use drm_foo() instead of DRM_foo() when possible. A few answers to some of your

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-21 Thread Mauro Carvalho Chehab
Hi Sam, Em Wed, 19 Aug 2020 19:35:58 +0200 Sam Ravnborg escreveu: > > + ret = drm_bridge_attach(encoder, bridge, NULL, 0); > The bridge should be attached with the falg that tell the bridge NOT to > create a connector. > > The display driver shall created the connector. > > Please see how

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-20 Thread Mauro Carvalho Chehab
Em Thu, 20 Aug 2020 16:48:08 +0200 Sam Ravnborg escreveu: > Hi Mauro. > > On Thu, Aug 20, 2020 at 04:06:49PM +0200, Mauro Carvalho Chehab wrote: > > Em Wed, 19 Aug 2020 19:35:58 +0200 > > Sam Ravnborg escreveu: > > > > I'm already handling the other com

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-20 Thread Mauro Carvalho Chehab
Em Wed, 19 Aug 2020 19:35:58 +0200 Sam Ravnborg escreveu: I'm already handling the other comments from your review (I'll send a more complete comment about them after finishing), but I have a doubt what you meant about this: > +static int kirin_drm_bind(struct device *dev) > > +{ > > + struct

Re: [PATCH 1/3] drm: hikey9xx: Fix inconsistent compat string

2020-08-20 Thread Mauro Carvalho Chehab
Em Thu, 20 Aug 2020 03:39:39 + John Stultz escreveu: > This is against Mauro's tree here: > https://gitlab.freedesktop.org/mchehab_kernel/hikey-970/-/commits/master/ > > A previous patch changed this string to be > "hisilicon,kirin960-dpe", but there are other place where the > code still

Re: [PATCH 25/49] staging: hikey9xx/gpu: do some code cleanups

2020-08-20 Thread Mauro Carvalho Chehab
(added c/c Rob Herring) Em Wed, 19 Aug 2020 18:53:06 -0700 John Stultz escreveu: > On Wed, Aug 19, 2020 at 4:46 AM Mauro Carvalho Chehab > wrote: > > @@ -376,7 +355,7 @@ static int kirin_drm_platform_resume(struct > > platform_device *pdev) > > } > > > &g

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-20 Thread Mauro Carvalho Chehab
Em Wed, 19 Aug 2020 14:36:52 -0700 John Stultz escreveu: > On Wed, Aug 19, 2020 at 4:46 AM Mauro Carvalho Chehab > wrote: > > So, IMO, the best is to keep it on staging for a while, until those > > remaining bugs gets solved. > > > > I added this series, toge

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-20 Thread Mauro Carvalho Chehab
Em Wed, 19 Aug 2020 20:28:44 -0700 John Stultz escreveu: > On Wed, Aug 19, 2020 at 7:01 PM John Stultz wrote: > > > > On Wed, Aug 19, 2020 at 2:36 PM John Stultz wrote: > > > > > > > > On Wed, Aug 19, 2020 at 4:46 AM Mauro Carvalho Chehab > > >

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-20 Thread Mauro Carvalho Chehab
Hi Sam, Em Wed, 19 Aug 2020 22:48:00 +0200 Sam Ravnborg escreveu: > Hi Mauro. > > It seems my review comments failed to reach dri-devel - likely due to > the size of the mail. Probably. It reached here properly. > Link: >

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-20 Thread Mauro Carvalho Chehab
Em Wed, 19 Aug 2020 12:52:06 -0700 John Stultz escreveu: > On Wed, Aug 19, 2020 at 8:31 AM Laurent Pinchart > wrote: > > On Wed, Aug 19, 2020 at 05:21:20PM +0200, Sam Ravnborg wrote: > > > On Wed, Aug 19, 2020 at 01:45:28PM +0200, Mauro Carvalho Chehab wrote: > >

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-20 Thread Mauro Carvalho Chehab
Em Wed, 19 Aug 2020 23:25:51 +0200 Sam Ravnborg escreveu: > Hi John. > > > > So, IMO, the best is to keep it on staging for a while, until those > > > remaining bugs gets solved. > > > > I'm not sure I see all of these as compelling for pushing it in via > > staging. And I suspect in the

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-20 Thread Mauro Carvalho Chehab
Em Wed, 19 Aug 2020 14:13:05 -0700 John Stultz escreveu: > On Wed, Aug 19, 2020 at 4:46 AM Mauro Carvalho Chehab > wrote: > > Yet, I'm submitting it via staging due to the following reasons: > > > > - It depends on the LDO3 power supply, which is provided by

[PATCH 47/49] dts: add support for Hikey 970 DRM

2020-08-19 Thread Mauro Carvalho Chehab
Add the needed bits for the DRM driver to work with the Hikey 970 board. Signed-off-by: Mauro Carvalho Chehab --- .../boot/dts/hisilicon/hi3670-hikey970.dts| 52 +++ arch/arm64/boot/dts/hisilicon/hi3670.dtsi | 6 + .../boot/dts/hisilicon/hikey970-drm.dtsi | 130

[PATCH 26/49] staging: hikey9xx/gpu: use default GEM_CMA fops

2020-08-19 Thread Mauro Carvalho Chehab
Instead of implementing it at the code, use the default methods from CMA helper Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/hikey9xx/gpu/kirin9xx_drm_drv.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/staging/hikey9xx/gpu

[PATCH 35/49] staging: hikey9xx/gpu: add SPMI headers

2020-08-19 Thread Mauro Carvalho Chehab
Use SPMI headers to identify the license of each file. Signed-off-by: Mauro Carvalho Chehab --- .../staging/hikey9xx/gpu/kirin960_dpe_reg.h | 1 + .../staging/hikey9xx/gpu/kirin970_dpe_reg.h | 1 + .../hikey9xx/gpu/kirin9xx_drm_dpe_utils.c | 4 ++- .../hikey9xx/gpu

[PATCH 38/49] staging: hikey9xx/gpu: add kirin9xx driver to the building system

2020-08-19 Thread Mauro Carvalho Chehab
Now that everything is in place, add the driver to the building system. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/hikey9xx/Kconfig | 3 ++ drivers/staging/hikey9xx/Makefile | 1 + drivers/staging/hikey9xx/gpu/Kconfig | 52 ++- drivers/staging

[PATCH 33/49] staging: hikey9xx/gpu: re-work the mode validation code

2020-08-19 Thread Mauro Carvalho Chehab
Carvalho Chehab --- .../staging/hikey9xx/gpu/kirin9xx_drm_dss.c | 274 +++--- .../hikey9xx/gpu/kirin9xx_dw_drm_dsi.c| 34 +++ 2 files changed, 211 insertions(+), 97 deletions(-) diff --git a/drivers/staging/hikey9xx/gpu/kirin9xx_drm_dss.c b/drivers/staging/hikey9xx/gpu

[PATCH 43/49] staging: hikey9xx/gpu: get rid of DRM_HISI_KIRIN970

2020-08-19 Thread Mauro Carvalho Chehab
There are lots of ifdefs checking if the SoC version is 960 or 970. Replace them all by runtime definitions. With that, the same DRM driver should work with both versions. The behavior will dynamically change depending on the OF compatible strings. Signed-off-by: Mauro Carvalho Chehab

[PATCH 08/49] staging: hikey9xx/gpu: Support MIPI DSI 3 lanes for hikey970.

2020-08-19 Thread Mauro Carvalho Chehab
From: Xiubin Zhang Modfiy mipi dsi lanes to improve HDMI compatibility. Signed-off-by: Xiubin Zhang Signed-off-by: Liuyao An Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/hikey9xx/gpu/dw_drm_dsi.c | 24 --- drivers/staging/hikey9xx/gpu/hdmi/adv7535.c | 4

[PATCH 28/49] staging: hikey9xx/gpu: remove an uneeded hack

2020-08-19 Thread Mauro Carvalho Chehab
At least on current upstream Kernels, forcing an event parse during init time isn't needed anymore. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/hikey9xx/gpu/kirin9xx_drm_drv.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/hikey9xx/gpu/kirin9xx_drm_drv.c b

[PATCH 44/49] dts: hisilicon: hi3670.dtsi: add I2C settings

2020-08-19 Thread Mauro Carvalho Chehab
The I2C buses are not declared at the device tree. As this will be needed by further patches, add them, keeping all in disabled state. Per-board settings can override it. Signed-off-by: Mauro Carvalho Chehab --- arch/arm64/boot/dts/hisilicon/hi3670.dtsi | 71 +++ 1 file

[PATCH 12/49] staging: hikey9xx/gpu: get rid of adv7535 fork

2020-08-19 Thread Mauro Carvalho Chehab
The OOT had a fork of adv7535 with some changes for it to work with a failing EDID retrival I/O. Get rid of it, as we'll be using the upstream driver. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/hikey9xx/gpu/hdmi/adv7535.c | 1678 - drivers/staging/hikey9xx/gpu

[PATCH 46/49] dt: hisilicon: add support for the PMIC found on Hikey 970

2020-08-19 Thread Mauro Carvalho Chehab
Add a device tree for the HiSilicon 6421v600 SPMI PMIC, used on HiKey970 board. As we now have support for it, change the fixed regulators used by the SD I/O to use the proper LDO supplies. Signed-off-by: Mauro Carvalho Chehab --- .../boot/dts/hisilicon/hi3670-hikey970.dts| 22

[PATCH 00/49] DRM driver for Hikey 970

2020-08-19 Thread Mauro Carvalho Chehab
of display staging: hikey9xx/gpu: resolve the performance issue by interrupt mechanism Mauro Carvalho Chehab (38): staging: hikey9xx/gpu: get rid of adv7535 fork staging: hikey9xx/gpu: rename the Kirin9xx namespace staging: hikey9xx/gpu: get rid of kirin9xx_fbdev.c staging: hikey9xx/gpu

[PATCH 22/49] staging: hikey9xx/gpu: cleanup encoder attach logic

2020-08-19 Thread Mauro Carvalho Chehab
Place both adv7535 and panel logic at the same routine, cleaning up things a little bit and fixing the includes. Signed-off-by: Mauro Carvalho Chehab --- .../hikey9xx/gpu/kirin9xx_dw_drm_dsi.c| 58 ++- 1 file changed, 31 insertions(+), 27 deletions(-) diff --git

[PATCH 21/49] staging: hikey9xx/gpu: add support for using a reserved CMA memory

2020-08-19 Thread Mauro Carvalho Chehab
/046e29834ef1c523c73614747377d3660eec3964 Signed-off-by: Mauro Carvalho Chehab --- .../staging/hikey9xx/gpu/kirin9xx_drm_drv.c | 36 ++- .../staging/hikey9xx/gpu/kirin9xx_drm_drv.h | 4 +-- .../hikey9xx/gpu/kirin9xx_drm_overlay_utils.c | 16 ++--- 3 files changed, 13 insertions(+), 43

[PATCH 25/49] staging: hikey9xx/gpu: do some code cleanups

2020-08-19 Thread Mauro Carvalho Chehab
- Get rid of a global var meant to store one of its priv structs; - Change the name of the driver, in order to not be confused with the kirin6220; - Remove some unneeded ifdef; - use drm_of.h helper. Signed-off-by: Mauro Carvalho Chehab --- .../staging/hikey9xx/gpu/kirin9xx_drm_drv.c | 81

[PATCH 32/49] staging: hikey9xx/gpu: get rid of iommu_format

2020-08-19 Thread Mauro Carvalho Chehab
Those aren't needed anymore. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/hikey9xx/gpu/kirin960_dpe_reg.h | 1 - drivers/staging/hikey9xx/gpu/kirin970_dpe_reg.h | 1 - drivers/staging/hikey9xx/gpu/kirin9xx_drm_drv.h | 2 -- 3 files changed, 4 deletions(-) diff --git a/drivers

[PATCH 37/49] staging: hikey9xx/gpu: don't use iommu code

2020-08-19 Thread Mauro Carvalho Chehab
Carvalho Chehab --- drivers/staging/hikey9xx/gpu/kirin9xx_drm_dss.c | 12 ++-- .../hikey9xx/gpu/kirin9xx_drm_overlay_utils.c| 10 ++ 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/drivers/staging/hikey9xx/gpu/kirin9xx_drm_dss.c b/drivers/staging/hikey9xx

[PATCH 16/49] staging: hikey9xx/gpu: rename the config option for Kirin970

2020-08-19 Thread Mauro Carvalho Chehab
Use the same standard as used on other Hisilicon DRM config vars for kirin9xx. Signed-off-by: Mauro Carvalho Chehab --- .../staging/hikey9xx/gpu/kirin9xx_drm_dpe_utils.c| 2 +- .../staging/hikey9xx/gpu/kirin9xx_drm_dpe_utils.h| 2 +- drivers/staging/hikey9xx/gpu/kirin9xx_drm_dss.c

[PATCH 39/49] staging: hikey9xx/gpu: get rid of typedefs

2020-08-19 Thread Mauro Carvalho Chehab
There are a few typedefs inside this driver. Get rid of them. Signed-off-by: Mauro Carvalho Chehab --- .../staging/hikey9xx/gpu/kirin960_dpe_reg.h | 126 +- .../staging/hikey9xx/gpu/kirin970_dpe_reg.h | 117 .../hikey9xx/gpu/kirin9xx_drm_dpe_utils.c

[PATCH 27/49] staging: hikey9xx/gpu: place vblank enable/disable at the right place

2020-08-19 Thread Mauro Carvalho Chehab
Those methods belong to crtc fops Signed-off-by: Mauro Carvalho Chehab --- .../staging/hikey9xx/gpu/kirin9xx_drm_dss.c | 21 ++- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/staging/hikey9xx/gpu/kirin9xx_drm_dss.c b/drivers/staging/hikey9xx/gpu

[PATCH 17/49] staging: hikey9xx/gpu: change the includes to reflect upstream

2020-08-19 Thread Mauro Carvalho Chehab
The includes there reflect a downstream version back on v4.4 times. change them to reflect the current upstream and to avoid the need of using a -I flag at the Makefile. Signed-off-by: Mauro Carvalho Chehab --- ...{kirin9xx_dpe_reg.h => kirin960_dpe_reg.h} | 3 +++ .../staging/hikey9xx/

[PATCH 30/49] staging: hikey9xx/gpu: register connector

2020-08-19 Thread Mauro Carvalho Chehab
call drm_connector_register() when initializing the connector. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/hikey9xx/gpu/kirin9xx_dw_drm_dsi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/hikey9xx/gpu/kirin9xx_dw_drm_dsi.c b/drivers/staging/hikey9xx/gpu

[PATCH 11/49] staging: hikey9xx/gpu: Add support 10.1 inch special HDMI displays.

2020-08-19 Thread Mauro Carvalho Chehab
From: Xiubin Zhang Adjust pixel clock for compatibility with 10.1 inch special displays. Signed-off-by: Xiubin Zhang Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/hikey9xx/gpu/kirin_drm_dss.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/hikey9xx/gpu

[PATCH 20/49] staging: hikey9xx/gpu: get rid of ION headers

2020-08-19 Thread Mauro Carvalho Chehab
This is not used anymore on this version, so let's get rid of them. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/hikey9xx/gpu/kirin960_dpe_reg.h | 3 --- drivers/staging/hikey9xx/gpu/kirin970_dpe_reg.h | 3 --- drivers/staging/hikey9xx/gpu/kirin9xx_drm_drv.h | 2 -- 3 files changed

[PATCH 45/49] dts: hikey970-pinctrl.dtsi: add missing pinctrl settings

2020-08-19 Thread Mauro Carvalho Chehab
There are several pinctrl settings that are missing at this DT file. Also, the entries are out of order. Add the missing bits, as they'll be required by the DRM driver - and probably by other drivers not upstreamed yet. Reorder the entres, adding the missing bits. Signed-off-by: Mauro Carvalho

[PATCH 31/49] staging: hikey9xx/gpu: fix driver name

2020-08-19 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/hikey9xx/gpu/kirin9xx_dw_drm_dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/hikey9xx/gpu/kirin9xx_dw_drm_dsi.c b/drivers/staging/hikey9xx/gpu/kirin9xx_dw_drm_dsi.c index 09d035038c1a

[PATCH 13/49] staging: hikey9xx/gpu: rename the Kirin9xx namespace

2020-08-19 Thread Mauro Carvalho Chehab
There's already a driver with the same namespace for an older Kirin chipset. Rename this one, in order to make it clearer that this is the driver for Kirin 960/970. Signed-off-by: Mauro Carvalho Chehab --- .../staging/hikey9xx/gpu/{kirin_dpe_reg.h => kirin9xx_dpe_reg.h} | 0 .../

[PATCH 07/49] staging: hikey9xx/gpu: Solve HDMI compatibility Problem.

2020-08-19 Thread Mauro Carvalho Chehab
From: Xiubin Zhang Modfiy pix_clk and dsi lanes to improve HDMI compatibility for hikey970. Signed-off-by: Xiubin Zhang Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/hikey9xx/gpu/dw_drm_dsi.c | 53 ++- drivers/staging/hikey9xx/gpu/hdmi/adv7535.c | 9 +- .../hikey9xx

[PATCH 36/49] staging: hikey9xx/gpu: solve most coding style issues

2020-08-19 Thread Mauro Carvalho Chehab
There are lots of coding style issues on this driver, as reported by checkpatch. Address most of them. Signed-off-by: Mauro Carvalho Chehab --- .../staging/hikey9xx/gpu/kirin960_dpe_reg.h | 340 +++-- .../staging/hikey9xx/gpu/kirin970_dpe_reg.h | 1199 - .../hikey9xx/gpu

[PATCH 34/49] staging: hikey9xx/gpu: add support for enable/disable ldo3 regulator

2020-08-19 Thread Mauro Carvalho Chehab
This is needed for the DRM to work. Ok, right now, this is enabled on default fastboot logic, but, as soon as we enable the proper SPMI driver, such code is needed. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/hikey9xx/gpu/kirin970_dpe_reg.h | 4 +--- drivers/staging/hikey9xx

[PATCH 18/49] staging: hikey9xx/gpu: port driver to upstream kAPIs

2020-08-19 Thread Mauro Carvalho Chehab
There were several changes at the upstream kAPIs since Kernel 4.4. Update the driver for it to build with the upstream Kernel. Signed-off-by: Mauro Carvalho Chehab --- .../staging/hikey9xx/gpu/kirin9xx_drm_drv.c | 28 +++--- .../staging/hikey9xx/gpu/kirin9xx_drm_dss.c | 26

[PATCH 40/49] staging: hikey9xx/gpu: get rid of input/output macros

2020-08-19 Thread Mauro Carvalho Chehab
(val, addr) Signed-off-by: Mauro Carvalho Chehab --- .../staging/hikey9xx/gpu/kirin960_dpe_reg.h | 15 -- .../staging/hikey9xx/gpu/kirin970_dpe_reg.h | 15 -- .../hikey9xx/gpu/kirin9xx_drm_dpe_utils.c | 251 ++ .../staging/hikey9xx/gpu/kirin9xx_drm_dss.c | 24

[PATCH 49/49] dt: display: Add binds for the DPE and DSI controller for Kirin 960/970

2020-08-19 Thread Mauro Carvalho Chehab
Add a description of the bindings used by Kirin 960/970 Display Serial Interface (DSI) controller and by its Display Engine (DPE). Signed-off-by: Mauro Carvalho Chehab --- .../display/hisilicon,hi3660-dpe.yaml | 99 + .../display/hisilicon,hi3660-dsi.yaml | 102

[PATCH 41/49] staging: hikey9xx/gpu: get rid of some unused data

2020-08-19 Thread Mauro Carvalho Chehab
There are some things inside struct dss_hw_ctx that are unused. Get rid of them. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/hikey9xx/gpu/kirin960_dpe_reg.h | 2 -- drivers/staging/hikey9xx/gpu/kirin970_dpe_reg.h | 3 --- drivers/staging/hikey9xx/gpu/kirin9xx_drm_dss.c | 2 -- 3

[PATCH 14/49] staging: hikey9xx/gpu: get rid of kirin9xx_fbdev.c

2020-08-19 Thread Mauro Carvalho Chehab
We don't need to implement legacy fbdev support. Just use the FB emulation instead. Signed-off-by: Mauro Carvalho Chehab --- .../staging/hikey9xx/gpu/kirin9xx_drm_drv.c | 9 +- .../staging/hikey9xx/gpu/kirin9xx_drm_drv.h | 2 - drivers/staging/hikey9xx/gpu/kirin9xx_fb.c| 94

[PATCH 23/49] staging: hikey9xx/gpu: Change the logic which sets the burst mode

2020-08-19 Thread Mauro Carvalho Chehab
The logic there is more complex than it needs. It also places the device with a wrong setting if the flags are missed. This currently happens on Kirin970 for HDMI, as there's a bug at the part of the driver which selects between PANEL or OUTPUT at encoder init code. Signed-off-by: Mauro Carvalho

[PATCH 15/49] staging: hikey9xx/gpu: get rid of some ifdefs

2020-08-19 Thread Mauro Carvalho Chehab
There are some #ifdefs there for non-existing CONFIG_ options (nor even at the downstream code). Let's get rid of those. It can be re-added later if ever needed. Signed-off-by: Mauro Carvalho Chehab --- .../hikey9xx/gpu/kirin9xx_drm_dpe_utils.c | 36 --- .../hikey9xx/gpu

[PATCH 48/49] staging: hikey9xx/gpu: drop kirin9xx_pwm

2020-08-19 Thread Mauro Carvalho Chehab
for it. Signed-off-by: Mauro Carvalho Chehab --- .../boot/dts/hisilicon/hikey970-drm.dtsi | 37 -- drivers/staging/hikey9xx/gpu/Makefile | 2 +- drivers/staging/hikey9xx/gpu/kirin9xx_pwm.c | 404 -- 3 files changed, 1 insertion(+), 442 deletions(-) delete mode 100644

[PATCH 04/49] staging: hikey9xx/gpu: resolve the performance issue by interrupt mechanism

2020-08-19 Thread Mauro Carvalho Chehab
hardware interrupt, implement the interrupt service to get vactive end interrupt, and fb_post return to tell gpu render next framebuffer. Signed-off-by: Wanchun Zheng Signed-off-by: Liwei Cai Signed-off-by: John Stultz Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/hikey9xx/gpu

[PATCH 09/49] staging: hikey9xx/gpu: Solve SR test reset problem for hikey970.

2020-08-19 Thread Mauro Carvalho Chehab
From: Xiubin Zhang Add HDMI/DSS power on in the SR flow. Signed-off-by: Xiubin Zhang Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/hikey9xx/gpu/Makefile | 1 - drivers/staging/hikey9xx/gpu/dw_drm_dsi.c | 10 +-- .../staging/hikey9xx/gpu/kirin970_dpe_reg.h | 9

[PATCH 06/49] staging: hikey9xx/gpu: Solve SR Cannot Display Problems.

2020-08-19 Thread Mauro Carvalho Chehab
From: Xiubin Zhang Add suspend and resume interface to solve SR Cannot Display Problems. Signed-off-by: Xiubin Zhang Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/hikey9xx/gpu/dw_drm_dsi.c | 32 +++ drivers/staging/hikey9xx/gpu/hdmi/adv7535.c | 14 +- .../staging/hikey9xx

[PATCH 10/49] staging: hikey9xx/gpu: add debug prints for this driver

2020-08-19 Thread Mauro Carvalho Chehab
From: Xiubin Zhang Add some debug prints on adv7535 and kirin_drm_drv. Signed-off-by: Xiubin Zhang Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/hikey9xx/gpu/hdmi/adv7535.c | 40 ++-- drivers/staging/hikey9xx/gpu/kirin_drm_drv.c | 2 +- 2 files changed, 37

[PATCH 29/49] staging: hikey9xx/gpu: add a possible implementation for atomic_disable

2020-08-19 Thread Mauro Carvalho Chehab
Currently, the method is empty. However, looking at the driver, it sounds it shouldn't be hard to implement it. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/hikey9xx/gpu/kirin9xx_drm_dss.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH 24/49] staging: hikey9xx/gpu: fix the DRM setting logic

2020-08-19 Thread Mauro Carvalho Chehab
var that will tell what was the latest attached encoder. Signed-off-by: Mauro Carvalho Chehab --- .../hikey9xx/gpu/kirin9xx_dw_drm_dsi.c| 38 +-- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/drivers/staging/hikey9xx/gpu/kirin9xx_dw_drm_dsi.c b/drivers

[PATCH 19/49] staging: hikey9xx/gpu: add a copy of set_reg() function there

2020-08-19 Thread Mauro Carvalho Chehab
This function has a too generic name to export it as a symbol. Also, we should likely use some other macro instead. So, for now, just copy it into the Kirin9xx dsi module, in order for the driver to build. Signed-off-by: Mauro Carvalho Chehab --- .../staging/hikey9xx/gpu/kirin9xx_dw_drm_dsi.c

[PATCH 02/49] staging: hikey9xx/gpu: port it to work with Kernel v4.9

2020-08-19 Thread Mauro Carvalho Chehab
From: John Stultz Update the driver to work with v4.9 kernels Signed-off-by: John Stultz Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/hikey9xx/gpu/dw_drm_dsi.c | 4 +- drivers/staging/hikey9xx/gpu/kirin_dpe_reg.h | 1 + drivers/staging/hikey9xx/gpu/kirin_drm_drv.c | 3

[PATCH 03/49] staging: hikey9xx/gpu: solve tearing issue of display

2020-08-19 Thread Mauro Carvalho Chehab
From: Liwei Cai The use of synchronization mechanisms to deal with the display of buffer, to solve the problem of display tearing. Signed-off-by: Wanchun Zheng Signed-off-by: Liwei Cai Signed-off-by: John Stultz Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/hikey9xx/gpu

<    1   2   3   4   5   6   7   8   >