Dharma, all,
On 06/03/2024 at 15:35, Dharma B - I70843 wrote:
On 05/03/24 3:31 am, Rob Herring wrote:
On Mon, Mar 04, 2024 at 08:00:03PM +0530, Dharma Balasubiramani wrote:
Convert the atmel,lcdc bindings to DT schema.
Changes during conversion: add missing clocks and clock-names properties.
On 05/02/2024 at 12:06, Dharma B - I70843 wrote:
Enable LVDS serializer support for display pipeline.
Signed-off-by: Dharma Balasubiramani
Acked-by: Hari Prasath Gujulan Elango
Acked-by: Nicolas Ferre
---
arch/arm/configs/at91_dt_defconfig | 1 +
1 file changed, 1 insertion(+)
diff
RIVER"
Otherwise:
Acked-by: Nicolas Ferre
Regards,
Nicolas
---
Changelog
v1 -> v2
- No Changes.
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index a7c4cf8201e0..24a266d20df6 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1423
On 09/11/2023 at 10:55, Helge Deller wrote:
On 11/9/23 07:24, Uwe Kleine-König wrote:
Hello,
On Wed, Nov 08, 2023 at 10:57:00PM +0100, Helge Deller wrote:
On 11/8/23 22:52, Uwe Kleine-König wrote:
But info and so info->fix live longer than the probe function, don't
they?
Yes, they do.
But
On 16/06/2023 at 08:44, Manikandan M - I67131 wrote:
On 14/06/23 20:10, Nicolas Ferre wrote:
On 13/06/2023 at 20:21, Conor Dooley wrote:
On Tue, Jun 13, 2023 at 08:17:13PM +0200, Krzysztof Kozlowski wrote:
On 13/06/2023 09:04, Manikandan Muralidharan wrote:
Add new compatible string
unny, as the LCD is precisely one aspect
where we differentiate between sam9x75, sam9x72 and sam9x70...
So please Manikandan sort this out if difference between these chips
will be better handled with different compatibility string, in
particular about //, LVDS and MIPI-DSI variants!
Regards,
Nicolas
--
Nicolas Ferre
= "sgmii";
phys = < 1 PHY_TYPE_SGMII 1 1>;
fixed-link {
Acked-by: Nicolas Ferre
Thanks Rob. Best regards,
Nicolas
--
Nicolas Ferre
ic void atmel_hlcdc_crtc_atomic_flush(struct drm_crtc *crtc,
- struct drm_atomic_state *state)
-{
- /* TODO: write common plane control register if available */
+ spin_unlock_irqrestore(>dev->event_lock, flags);
}
static const struct drm_crtc_helper_funcs lcdc_crtc_helper_funcs = {
--
Nicolas Ferre
config.max_height = dc->desc->max_height;
dev->mode_config.funcs = _config_funcs;
+ dev->mode_config.async_page_flip = true;
return 0;
}
--
2.17.1
--
Nicolas Ferre
On 06/04/2020 at 07:34, Tang Bin wrote:
The platform_get_irq() can print error message,so remove the redundant
dev_err() here.
Signed-off-by: Tang Bin
Acked-by: Nicolas Ferre
---
drivers/video/fbdev/atmel_lcdfb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/video/fbdev
AT91 product line
Anyway, I'd wait for Boris' feedback for making a decision.
Best regards,
--
Nicolas Ferre
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
g question indeed.
Or is this in reality a simple GPU that requires a
dedicated GPU driver?
Sam
--
Nicolas Ferre
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
| 158 +++
drivers/pwm/Kconfig| 13 +
drivers/pwm/Makefile |1 +
drivers/pwm/pwm-atmel-lcdc.c | 178
include/linux/mfd/atmel-lcdc.h | 184
22
On 05/02/2018 at 09:23, Ludovic Desroches wrote:
> Use GPIO descriptors instead of relying on the old method.
>
> Signed-off-by: Ludovic Desroches <ludovic.desroc...@microchip.com>
Acked-by: Nicolas Ferre <nicolas.fe...@microchip.com>
Thanks!
> ---
> drivers/vid
On 05/02/2018 at 09:47, Ludovic Desroches wrote:
> Use GPIO descriptors instead of relying on the old method.
>
> Signed-off-by: Ludovic Desroches <ludovic.desroc...@microchip.com>
Acked-by: Nicolas Ferre <nicolas.fe...@microchip.com>
On this resent patch as well ;-)
&
. Beware about the added complexity though.
Regards,
--
Nicolas Ferre
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
tmel_lcdfb_info
> *sinfo)
> put_display_node:
> of_node_put(display_np);
> return ret;
> +
> +report_bits_failure:
> + dev_err(dev, "failed to get property bits-per-pixel\n");
> + goto put_display_node;
> }
> #else
> static int atmel_lcdfb_of_init(struct atmel_lcdfb_info *sinfo)
>
--
Nicolas Ferre
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
ers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c| 14
> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h| 16 ++
> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 29
> +
> 4 files changed, 64 insertions(+)
>
--
Nicolas Ferre
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
.default_color = 6,
>>> - .chroma_key = 7,
>>> - .chroma_key_mask = 8,
>>> - .general_config = 9,
>>> - },
>>> - },
>>> - {
>>> .name = "high-end-overlay",
>>> .formats = _hlcdc_plane_rgb_and_yuv_formats,
>>> .regs_offset = 0x340,
>>> - .id = 3,
>>> + .id = 2,
>>> .type = ATMEL_HLCDC_OVERLAY_LAYER,
>>> .cfgs_offset = 0x4c,
>>> .layout = {
>>
>
>
--
Nicolas Ferre
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
y need. This rework is a good excuse to simplify it. Note
> that this rework solves an existing resource leak (leading to a -EBUSY
> error) which I failed to clearly identify.
>
> Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com>
I have little knowledge f
node_put() call in the error path.
>
> Signed-off-by: Boris Brezillon
> Fixes: 17a8e03e7e97 ("drm: atmel-hlcdc: rework the output code to support drm
> bridges")
Reviewed-by: Nicolas Ferre
> ---
> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c | 10 ++
>
ot;drm: add Atmel HLCDC Display Controller support")
> Cc:
Reviewed-by: Nicolas Ferre
Thanks!
> ---
> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> b/driver
Le 30/03/2016 16:19, Boris Brezillon a écrit :
> Add the HLCDC drivers to multi_v7_defconfig.
>
> Signed-off-by: Boris Brezillon
If it gives more weight:
Acked-by: Nicolas Ferre
BTW, arm-soc guys, I recall that you prefer patches for this kind of
modification to multi_v7_defconfi
ameter is passed
on the kernel cmdline. In some cases the user provided mode is preferred
over the simple panel ones, which might result in unpredictable behavior.
Signed-off-by: Boris Brezillon
Reviewed-by: Nicolas Ferre
Tested-by: Nicolas Ferre
---
drivers/gpu/drm/panel/panel-simple.c | 8
Le 28/05/2015 16:25, Boris Brezillon a écrit :
> Hi Thierry,
>
> Could you have a look at this patch (a.k.a. ping) ?
It's been a long time and... It seems that this patch doesn't apply
anymore but:
Reviewed-by: Nicolas Ferre
So, I'm updating it and resending right now.
Bye,
>
Le 06/01/2016 13:25, Boris Brezillon a écrit :
> Add basic support for the sil902x RGB -> HDMI bridge.
> This driver does not support audio output yet.
>
> Signed-off-by: Boris Brezillon
You can add my:
Tested-by: Nicolas Ferre
I tested it on a SAMA5D4 Xplained board with a De
king code
> from ->atomic_check() to ->mode_fixup().
To give more weight to this series, you can also add my:
Tested-by: Nicolas Ferre
Bye,
> Boris Brezillon (8):
> drm: atmel-hlcdc: add a ->cleanup_fb() operation
> drm: atmel-hlcdc: support asynchronous atomic commi
Le 06/01/2016 11:19, Boris Brezillon a écrit :
> Move the adjusted display mode check into ->mode_fixup().
>
> Signed-off-by: Boris Brezillon
Seems okay:
Acked-by: Nicolas Ferre
> ---
> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 10 --
> 1 file change
max_height: maximum height supported by the Display Controller
> + * @max_spw: maximum vertical/horizontal pulse width
> + * @max_vpw: maximum vertical back/front porch width
> + * @max_hpw: maximum horizontal back/front porch width
> * @layers: a layer description table describing available layers
> * @nlayers: layer description table size
> */
> @@ -58,6 +61,9 @@ struct atmel_hlcdc_dc_desc {
> int min_height;
> int max_width;
> int max_height;
> + int max_spw;
> + int max_vpw;
> + int max_hpw;
> const struct atmel_hlcdc_layer_desc *layers;
> int nlayers;
> };
>
--
Nicolas Ferre
Le 06/01/2016 11:19, Boris Brezillon a écrit :
> The ->dpms field is no longer used and can be removed.
> The same goes for the dummy ->mode_fixup() implementation which always
> returns true.
>
> Signed-off-by: Boris Brezillon
Acked-by: Nicolas Ferre
> ---
>
g conversion")
Seems okay:
Reviewed-by: Nicolas Ferre
> ---
> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h| 2 ++
> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 22 +++---
> 2 files changed, 21 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/
Le 06/01/2016 11:19, Boris Brezillon a écrit :
> The hlcdc IP keep the pixel stream in raw RGB mode, and does not provide
> any specific connector. Since DRM_MODE_CONNECTOR_RAW_RGB does not exist,
> use DRM_MODE_CONNECTOR_Unknown.
>
> Signed-off-by: Boris Brezillon
Yes:
Acked-by
api/drm/i915*
>>
>> +DRM DRIVERS FOR ATMEL_AT91
>
> I would remove AT91
Yes I agree with Alexandre.
Otherwise, you can add my:
Acked-by: Nicolas Ferre
on your v2 patch.
Bye,
--
Nicolas Ferre
As the hardware description for this chip is the same as the sama5d4, we use
this SoC structures for layers and DC descriptions. Thus only 2 lines are added
to the atmel_hlcdc_of_match table.
The compatible string is already documented in the parent MFD driver's binding.
Signed-off-by: Nicolas
'video=' parameter is passed
> on the kernel cmdline. In some cases the user provided mode is preferred
> over the simple panel ones, which might result in unpredictable behavior.
>
> Signed-off-by: Boris Brezillon
Tested-by: Nicolas Ferre
On Atmel sama5d3xek board.
> ---
> driv
Le 24/03/2015 17:12, Nicolas Ferre a écrit :
> Signed-off-by: Nicolas Ferre
Ping?
> ---
> Thierry,
>
> Here it is ;-)
>
> Bye,
>
> Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Docu
Le 24/03/2015 17:12, Nicolas Ferre a écrit :
> Signed-off-by: Nicolas Ferre
> ---
> Thierry,
>
> Boris added the support for a Foxlink panel in this commit: 102932b0e474
> (drm/panel: add support for Foxlink FL500WVR00-A0T panel). Here is the vendor
> pre
Signed-off-by: Nicolas Ferre
---
Thierry,
Boris added the support for a Foxlink panel in this commit: 102932b0e474
(drm/panel: add support for Foxlink FL500WVR00-A0T panel). Here is the vendor
prefix.
Bye,
Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
1 file changed, 1
Signed-off-by: Nicolas Ferre
---
Thierry,
Here it is ;-)
Bye,
Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt
b/Documentation/devicetree/bindings/vendor-prefixes.txt
index
The Innolux AT043TN24 4.3" WQVGA TFT LCD panel.
This panel with backlight is found in PDA 4.3" LCD screen (TM43xx series for
instance).
Signed-off-by: Nicolas Ferre
---
.../bindings/panel/innolux,at043tn24.txt | 7 ++
drivers/gpu/drm/panel/panel-simple.c
From: Boris BREZILLON <boris.brezil...@free-electrons.com>
The Shelly SCA07010-BFN-LNN is a 7.0" WVGA TFT LCD panel.
This panel with backlight is found in PDA 7" LCD screen (TM70xx series for
instance).
Signed-off-by: Boris BREZILLON
Signed-off-by: Nicolas Ferre
---
.../bindi
gt; + if (!clk_is_match(new_clk, chip->cur_clk)) {
> u32 gencfg = 0;
> int ret;
>
>
--
Nicolas Ferre
Remove this configuration bit in crtc driver as the rising edge clock is widely
used.
Signed-off-by: Boris BREZILLON
Signed-off-by: Nicolas Ferre
---
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/atmel-hlcdc
ong awaited Atmel AVR 64 bits
> processor :-)).
>
> More seriously, if Atmel ever decide to reuse this IP on a different
> architecture, I think we'll add an '&& (ARM || XXX)' condition to the
> depends on line.
Yes, it's not planned in the near future. So we can keep the "ARM"
restriction for now I think.
Bye,
>> Anyway, the xtensa:allmodconfig build is passing again with this patch
>> applied, so
>>
>> Tested-by: Guenter Roeck
>>
>
> Thanks for reporting the bug and testing the fix.
>
> Best Regards,
>
> Boris
>
>
>
--
Nicolas Ferre
kefile
> create mode 100644 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c
> create mode 100644 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
> create mode 100644 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h
> create mode 100644 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_layer.c
> create mode 100644 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_layer.h
> create mode 100644 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c
> create mode 100644 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
>
>
--
Nicolas Ferre
drm: add DT bindings documentation for atmel-hlcdc-dc driver
Boris, David,
I realize that I already gave my acknowledgement to this driver for the
v7 revision. It was before it is split.
For the record, here is my review and the message:
https://lkml.org/lkml/2014/10/8/219
As I had said:
"I'
On 01/10/2014 16:53, Boris Brezillon :
> From: Boris BREZILLON
>
> The Atmel HLCDC (HLCD Controller) IP available on some Atmel SoCs (i.e.
> at91sam9n12, at91sam9x5 family or sama5d3 family) provides a display
> controller device.
>
> This display controller supports at least one primary plane
++
>>>>>>>>>>> include/linux/mfd/atmel-hlcdc.h | 85
>>>>>>>>>>> 4 files changed, 214 insertions(+)
>>>>>>>>>>> create mode 100644 drivers/mfd/atmel-hlcdc.c
>>>>&
en (see patch 1) which should
>> solve part of the issue.
>
> I think that's wrong but I don't care enough to object.
Ok, me, I kind of like it: the MFD is something convenient to aggregate
two drivers using the same register set (LCD and Backlight) but has no
real "feature" interest in my opinion: it ease things.
>> Now that I have your attention :-), could you review this series [1] ?
>> The HLCDC KMS depends on those changes (which you and Laurent
>> suggested).
>
> My attention span tends to be very short these days. No promises. =)
>
> Thierry
>
Thanks, bye,
--
Nicolas Ferre
49 matches
Mail list logo
