[PATCH 0/4] drm/tinydrm: Use damage helper for dirtyfb

2019-01-09 Thread Noralf Trønnes
when -rc1 arrives there. Noralf. Noralf Trønnes (4): drm/gem-fb-helper: Add drm_gem_fb_create_with_dirty() drm/damage-helper: Add drm_atomic_helper_damage_merged() drm/tinydrm: Use struct drm_rect drm/tinydrm: Use damage helper for dirtyfb drivers/gpu/drm/drm_damage_helper.c

Re: [PATCH] drm/fb-helper: fix leaks in error path of drm_fb_helper_fbdev_setup

2019-01-08 Thread Noralf Trønnes
Den 05.01.2019 19.25, skrev Noralf Trønnes: > > > Den 24.12.2018 16.03, skrev Peter Wu: >> On Mon, Dec 24, 2018 at 03:52:55PM +0100, Noralf Trønnes wrote: >>> >>> >>> Den 24.12.2018 00.10, skrev Peter Wu: >>>> On Sun,

Re: [PATCH] drm/fb-helper: generic: Fix setup error path

2019-01-08 Thread Noralf Trønnes
le the error path. >> >> Error cleanup is removed from .fb_probe and is handled by one function for >> all paths. >> >> Fixes: 9060d7f49376 ("drm/fb-helper: Finish the generic fbdev emulation") >> Reported-by: Peter Wu >> Signed-off-by: Noral

Re: [PATCH] drm/todo: Better defio support in the generic fbdev emulation

2019-01-07 Thread Noralf Trønnes
Den 07.01.2019 11.22, skrev Daniel Vetter: > The current one essentially means you need CMA or a vmalloc backed > object, which makes fbdev emulation a special case. > > Since implementing this will be quite a bit of work, capture the idea > in a TODO. > > Cc: Noralf

Re: [PATCH v2 13/14] drm/tinydrm: do not reply on drmP.h from drm_gem_cma_helper.h

2019-01-07 Thread Noralf Trønnes
in include/drm/ > > To prepare tinydrm/ for this add dependencies that > othwewise was pulled in by drmP.h from drm_gem_cma_helper.h > > To avoid that tinydrm.h became "include everything", > push include files to the individual drivers. > > Signed-off-by: Sam Ravnborg

Re: [PATCH v2 14/14] drm: remove drmP.h from drm_gem_cma_helper.h

2019-01-07 Thread Noralf Trønnes
> Cc: Maxime Ripard > Cc: Sean Paul > Cc: David Airlie > Cc: Daniel Vetter > --- Acked-by: Noralf Trønnes ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 12/14] drm/stm: do not reply on drmP.h from drm_gem_cma_helper.h

2019-01-07 Thread Noralf Trønnes
n Gaignard > Cc: Vincent Abriou > Cc: David Airlie > Cc: Daniel Vetter > --- Acked-by: Noralf Trønnes ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 11/14] drm/arc: do not reply on drmP.h from drm_gem_cma_helper.h

2019-01-07 Thread Noralf Trønnes
in include/drm/ > > To prepare arc/ for this add dependencies that > othwewise was pulled in by drmP.h from drm_gem_cma_helper.h > > Signed-off-by: Sam Ravnborg > Cc: Alexey Brodkin > Cc: Daniel Vetter > Cc: David Airlie > --- Acked-by: Noralf Trønnes ___

Re: [PATCH v2 09/14] drm: remove include of drmP.h from drm_encoder_slave.h

2019-01-07 Thread Noralf Trønnes
Den 30.12.2018 18.48, skrev Sam Ravnborg: > No further changes required. > > Signed-off-by: Sam Ravnborg > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Sean Paul > Cc: David Airlie > Cc: Daniel Vetter > --- Acked-by: Noralf Trønnes

Re: [PATCH v2 05/14] drm: make drm_file.h self contained

2019-01-07 Thread Noralf Trønnes
pler to remove drmP.h includes > > Signed-off-by: Sam Ravnborg > Cc: Jani Nikula > Cc: Daniel Vetter > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Sean Paul > Cc: David Airlie > --- Acked-by: Noralf Trønnes ___ dri-de

Re: [PATCH v2 04/14] drm: make drm_framebuffer.h self contained

2019-01-07 Thread Noralf Trønnes
uct drm_framebuffer; > struct drm_file; > struct drm_device; > +struct drm_clip_rect; I think you can add drm_gem_object to this list. > > /** > * struct drm_framebuffer_funcs - framebuffer hooks > Acked-by: Noralf Trønnes ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/fb-helper: fix leaks in error path of drm_fb_helper_fbdev_setup

2019-01-05 Thread Noralf Trønnes
Den 24.12.2018 16.03, skrev Peter Wu: On Mon, Dec 24, 2018 at 03:52:55PM +0100, Noralf Trønnes wrote: Den 24.12.2018 00.10, skrev Peter Wu: On Sun, Dec 23, 2018 at 02:55:52PM +0100, Noralf Trønnes wrote: Den 23.12.2018 01.55, skrev Peter Wu: After drm_fb_helper_fbdev_setup calls

[PATCH] drm/fb-helper: generic: Fix setup error path

2019-01-05 Thread Noralf Trønnes
t;drm/fb-helper: Finish the generic fbdev emulation") Reported-by: Peter Wu Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_fb_helper.c | 98 +++-- 1 file changed, 58 insertions(+), 40 deletions(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drive

Re: [PATCH 5/9] drm/fb-helper: Add generic fbdev emulation .fb_probe function

2019-01-03 Thread Noralf Trønnes
Den 28.12.2018 21.38, skrev Daniel Vetter: On Tue, May 29, 2018 at 9:54 AM Daniel Vetter wrote: On Fri, May 25, 2018 at 02:42:02PM +0200, Noralf Trønnes wrote: Den 24.05.2018 11.16, skrev Daniel Vetter: On Wed, May 23, 2018 at 04:34:07PM +0200, Noralf Trønnes wrote: This is the first

Re: [PATCH] drm/fb-helper: fix leaks in error path of drm_fb_helper_fbdev_setup

2018-12-24 Thread Noralf Trønnes
Den 24.12.2018 00.10, skrev Peter Wu: On Sun, Dec 23, 2018 at 02:55:52PM +0100, Noralf Trønnes wrote: Den 23.12.2018 01.55, skrev Peter Wu: After drm_fb_helper_fbdev_setup calls drm_fb_helper_init, "dev->fb_helper" will be initialized (and thus drm_fb_helper_fini will hav

Re: [PATCH] drm/fb-helper: fix leaks in error path of drm_fb_helper_fbdev_setup

2018-12-23 Thread Noralf Trønnes
etup/teardown()") Reported-by: kernel test robot Cc: Noralf Trønnes Signed-off-by: Peter Wu --- drivers/gpu/drm/drm_fb_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index 9d64f874f965..432e

Re: [PATCH] drm/xen-front: Make shmem backed display buffer coherent

2018-12-19 Thread Noralf Trønnes
Den 19.12.2018 09.18, skrev Oleksandr Andrushchenko: On 12/18/18 9:20 PM, Noralf Trønnes wrote: Den 27.11.2018 11.32, skrev Oleksandr Andrushchenko: From: Oleksandr Andrushchenko When GEM backing storage is allocated with drm_gem_get_pages the backing pages may be cached, thus making

Re: [PATCH] drm/xen-front: Make shmem backed display buffer coherent

2018-12-18 Thread Noralf Trønnes
Den 27.11.2018 11.32, skrev Oleksandr Andrushchenko: From: Oleksandr Andrushchenko When GEM backing storage is allocated with drm_gem_get_pages the backing pages may be cached, thus making it possible that the backend sees only partial content of the buffer which may lead to screen artifacts.

Re: [Xen-devel][PATCH v2 2/3] drm/xen-front: Use Xen common shared buffer implementation

2018-12-18 Thread Noralf Trønnes
-by: Oleksandr Andrushchenko --- Reviewed-by: Noralf Trønnes ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] fbdev: fbcon: Fix unregister crash when more than one framebuffer

2018-12-12 Thread Noralf Trønnes
Den 12.12.2018 12.05, skrev Daniel Vetter: On Mon, Dec 10, 2018 at 08:02:55PM +0100, Noralf Trønnes wrote: When unregistering fbdev using unregister_framebuffer(), any bound console will unbind automatically. This is working fine if this is the only framebuffer, resulting in a switch

[PATCH] fbdev: fbcon: Fix unregister crash when more than one framebuffer

2018-12-10 Thread Noralf Trønnes
index. Fixes: cfafca8067c6 ("fbdev: fbcon: console unregistration from unregister_framebuffer") Signed-off-by: Noralf Trønnes Reviewed-by: Mikulas Patocka --- Mikulas, If you have forgotten about this, here's where you gave your r-b: https://lists.freedesktop.org/archives/dri-devel

Re: [PATCH -next] drm/tinydrm: Use kmemdup rather than duplicating its implementation in repaper_spi_transfer()

2018-12-04 Thread Noralf Trønnes
Den 29.11.2018 07.00, skrev YueHaibing: use kmemdup rather than duplicating its implementation Signed-off-by: YueHaibing --- Thanks, applied to drm-misc-next. Noralf. drivers/gpu/drm/tinydrm/repaper.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

Re: [Intel-gfx] [PATCH v5 4/5] drm: Add library for shmem backed GEM objects

2018-12-02 Thread Noralf Trønnes
wrote: Noralf Trønnes writes: +static void drm_gem_shmem_vm_close(struct vm_area_struct *vma) +{ + struct drm_gem_object *obj = vma->vm_private_data; + struct drm_gem_shmem_object *shmem = to_drm_gem_shmem_obj(obj); + + drm_gem_shmem_put_pages(shmem); + drm_gem_vm_close(

Re: [PATCH v3 3/5] drm/rcar-du: Use drm_fbdev_generic_setup()

2018-11-29 Thread Noralf Trønnes
Den 28.11.2018 22.27, skrev Noralf Trønnes: The CMA helper is already using the drm_fb_helper_generic_probe part of the generic fbdev emulation. This patch makes full use of the generic fbdev emulation by using its drm_client callbacks. This means that drm_mode_config_funcs->output_poll_chan

Re: [PATCH v3 4/5] drm/framebuffer: Include linux/sched.h in header file

2018-11-29 Thread Noralf Trønnes
Den 29.11.2018 10.35, skrev Daniel Vetter: On Wed, Nov 28, 2018 at 10:27:12PM +0100, Noralf Trønnes wrote: A cleanup of the includes in drm_fb_cma_helper resulted in: CC [M] drivers/gpu/drm/drm_fb_cma_helper.o In file included from drivers/gpu/drm/drm_fb_cma_helper.c:21:0: include/drm

[PATCH v3 3/5] drm/rcar-du: Use drm_fbdev_generic_setup()

2018-11-28 Thread Noralf Trønnes
driver, it is not part of the driver as such. If fbdev setup fails, an error is printed, but the driver succeeds probing. drm_fbdev_generic_setup() handles mode_config.num_connector being zero. In that case it retries fbdev setup on the next .output_poll_changed. Cc: Laurent Pinchart Signed-off-by: Noralf T

[PATCH v3 0/5] drm/cma-helper drivers: Use drm_fbdev_generic_setup()

2018-11-28 Thread Noralf Trønnes
Pinchart Noralf Trønnes (5): drm/hisilicon/kirin: Use drm_fbdev_generic_setup() drm/mxsfb: Use drm_fbdev_generic_setup() drm/rcar-du: Use drm_fbdev_generic_setup() drm/framebuffer: Include linux/sched.h in header file drm/cma-helper: Remove unused fbdev code drivers/gpu/drm/Kconfig

[PATCH v3 4/5] drm/framebuffer: Include linux/sched.h in header file

2018-11-28 Thread Noralf Trønnes
]; Fix it by including linux/sched.h. Signed-off-by: Noralf Trønnes --- include/drm/drm_framebuffer.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/drm/drm_framebuffer.h b/include/drm/drm_framebuffer.h index c94acedfb08e..d4ce58568fa6 100644 --- a/include/drm/drm_framebuffer.h +++ b

[PATCH v3 2/5] drm/mxsfb: Use drm_fbdev_generic_setup()

2018-11-28 Thread Noralf Trønnes
driver, it is not part of the driver as such. If fbdev setup fails, an error is printed, but the driver succeeds probing. Cc: Marek Vasut Signed-off-by: Noralf Trønnes Acked-by: Sam Ravnborg --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 26 ++ drivers/gpu/drm/mxsfb/mxsfb_drv.h | 1 - 2

[PATCH v3 5/5] drm/cma-helper: Remove unused fbdev code

2018-11-28 Thread Noralf Trønnes
CMA helper drivers have been converted to drm_fbdev_generic_setup() so the fbdev code can be removed. v2: Clean up the includes some more (Laurent) Cc: Laurent Pinchart Signed-off-by: Noralf Trønnes Acked-by: Sam Ravnborg Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/Kconfig

[PATCH v3 1/5] drm/hisilicon/kirin: Use drm_fbdev_generic_setup()

2018-11-28 Thread Noralf Trønnes
driver, it is not part of the driver as such. If fbdev setup fails, an error is printed, but the driver succeeds probing. struct kirin_drm_private can be removed now that driver doesn't have to store the fbdev pointer. Cc: Xinliang Liu Cc: Rongrong Zou Cc: Xinwei Kong Cc: Chen Feng Signed-off-by: Noralf T

Re: [PATCH v2 5/9] drm/rcar-du: Use drm_fbdev_generic_setup()

2018-11-28 Thread Noralf Trønnes
Den 25.10.2018 22.13, skrev Noralf Trønnes: The CMA helper is already using the drm_fb_helper_generic_probe part of the generic fbdev emulation. This patch makes full use of the generic fbdev emulation by using its drm_client callbacks. This means that drm_mode_config_funcs->output_poll_chan

Re: [PATCH v2] drm/fb-helper/generic: Only restore when in use

2018-11-27 Thread Noralf Trønnes
Den 26.11.2018 21.07, skrev Daniel Vetter: On Mon, Nov 26, 2018 at 04:38:48PM +0100, Noralf Trønnes wrote: On drm_driver->last_close the generic fbdev emulation will restore fbdev regardless of it being used or not. This is a problem for e-ink displays which don't want to be overwrit

[PATCH v2] drm/fb-helper/generic: Only restore when in use

2018-11-26 Thread Noralf Trønnes
hen to restore. v1: Avoid special-casing and move the check to drm_fbdev_client_restore() (Daniel Vetter) Signed-off-by: Noralf Trønnes --- I was tied up in my previous attempt to solve this which predated the generic emulation, so I failed to see that I could solve this within the sc

Re: [PATCH] drm/prime: Fix drm_gem_prime_mmap() stack use

2018-11-22 Thread Noralf Trønnes
Den 22.11.2018 10.06, skrev Daniel Vetter: On Wed, Nov 21, 2018 at 07:02:15PM +0100, Noralf Trønnes wrote: drivers/gpu/drm/drm_prime.c: In function 'drm_gem_prime_mmap': drivers/gpu/drm/drm_prime.c:688:1: warning: the frame size of 1592 bytes is larger than 1024 bytes [-Wframe-larger

[PATCH] drm/prime: Fix drm_gem_prime_mmap() stack use

2018-11-21 Thread Noralf Trønnes
mmap()") Reported-by: kbuild test robot Cc: Daniel Vetter Cc: Christian König Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_prime.c | 31 --- 1 file changed, 20 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu

[PATCH] drm/fb-helper/generic: Only restore when in use

2018-11-21 Thread Noralf Trønnes
pen() and drm_fbdev_fb_release() and use them. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_fb_helper.c | 25 +++-- include/drm/drm_fb_helper.h | 14 ++ 2 files changed, 37 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/

Re: [PATCH v2 5/9] drm/rcar-du: Use drm_fbdev_generic_setup()

2018-11-20 Thread Noralf Trønnes
Laurent, Den 25.10.2018 22.13, skrev Noralf Trønnes: The CMA helper is already using the drm_fb_helper_generic_probe part of the generic fbdev emulation. This patch makes full use of the generic fbdev emulation by using its drm_client callbacks. This means that drm_mode_config_funcs

Re: [PATCH 0/5] drm/gem: Add drm_gem_object_funcs

2018-11-20 Thread Noralf Trønnes
Den 10.11.2018 15.56, skrev Noralf Trønnes: This patchset adds a GEM object function table and makes use of it in the CMA helper. This was originally part of a shmem helper series[1] that didn't make it. Daniel and Christian showed interest in the vtable part so I have hooked it up to some

[PATCH 0/5] drm/gem: Add drm_gem_object_funcs

2018-11-10 Thread Noralf Trønnes
. The tinydrm refactoring is part of a long term plan to get rid of tinydrm.ko. Noralf. [1] https://patchwork.freedesktop.org/series/27184/ Noralf Trønnes (5): drm/driver: Add defaults for .gem_prime_export/import callbacks drm/prime: Add drm_gem_prime_mmap() drm/gem: Add drm_gem_object_funcs

[PATCH 3/5] drm/gem: Add drm_gem_object_funcs

2018-11-10 Thread Noralf Trønnes
first choice highlighting the fact that this the new default way of doing it (Daniel Vetter) Signed-off-by: Noralf Trønnes Acked-by: Daniel Vetter --- Documentation/gpu/todo.rst | 6 ++ drivers/gpu/drm/drm_client.c | 12 ++-- drivers/gpu/drm/drm_gem.c| 109 ---

[PATCH 4/5] drm/cma-helper: Add DRM_GEM_CMA_VMAP_DRIVER_OPS

2018-11-10 Thread Noralf Trønnes
all in drm_gem_cma_free_object() safe. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_gem_cma_helper.c | 86 include/drm/drm_gem_cma_helper.h | 24 ++ 2 files changed, 110 insertions(+) diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c b/drivers/gpu/

[PATCH 2/5] drm/prime: Add drm_gem_prime_mmap()

2018-11-10 Thread Noralf Trønnes
Add a generic PRIME GEM mmap function. v2: Fix link in docs (Daniel Vetter) Suggested-by: Daniel Vetter Signed-off-by: Noralf Trønnes Reviewed-by: Daniel Vetter --- drivers/gpu/drm/drm_prime.c | 37 + include/drm/drm_prime.h | 1 + 2 files changed, 38

[PATCH 5/5] drm/tinydrm: Use DRM_GEM_CMA_VMAP_DRIVER_OPS

2018-11-10 Thread Noralf Trønnes
The CMA helper now has the functionality to ensure a virtual address on imported buffer so use that. While touching all tinydrm drivers, remove the unnecessary inclusion of drm_fb_helper.h in some drivers. Cc: David Lechner Cc: Eric Anholt Signed-off-by: Noralf Trønnes --- drivers/gpu/drm

[PATCH 1/5] drm/driver: Add defaults for .gem_prime_export/import callbacks

2018-11-10 Thread Noralf Trønnes
The majority of drivers use drm_gem_prime_export() and drm_gem_prime_import() for these callbacks so let's make them the default. Signed-off-by: Noralf Trønnes Acked-by: Daniel Vetter --- Documentation/gpu/todo.rst | 7 +++ drivers/gpu/drm/drm_prime.c | 10 -- include/drm

Re: [PATCH v2 8/9] drm/tilcdc: Use drm_fbdev_generic_setup()

2018-11-01 Thread Noralf Trønnes
Den 29.10.2018 16.55, skrev Jyri Sarha: On 25/10/18 23:13, Noralf Trønnes wrote: The CMA helper is already using the drm_fb_helper_generic_probe part of the generic fbdev emulation. This patch makes full use of the generic fbdev emulation by using its drm_client callbacks. This means

Re: [PATCH v2 7/9] drm/sun4i: Use drm_fbdev_generic_setup()

2018-11-01 Thread Noralf Trønnes
Den 26.10.2018 10.27, skrev Maxime Ripard: On Thu, Oct 25, 2018 at 10:13:38PM +0200, Noralf Trønnes wrote: The CMA helper is already using the drm_fb_helper_generic_probe part of the generic fbdev emulation. This patch makes full use of the generic fbdev emulation by using its drm_client

Re: [PATCH v2 6/9] drm/atmel-hlcdc: Use drm_fbdev_generic_setup()

2018-11-01 Thread Noralf Trønnes
Den 25.10.2018 22.25, skrev Boris Brezillon: On Thu, 25 Oct 2018 22:13:37 +0200 Noralf Trønnes wrote: The CMA helper is already using the drm_fb_helper_generic_probe part of the generic fbdev emulation. This patch makes full use of the generic fbdev emulation by using its drm_client

Re: [PATCH v2 2/9] drm/fsl-dcu: Use drm_fbdev_generic_setup()

2018-11-01 Thread Noralf Trønnes
Den 25.10.2018 22.13, skrev Noralf Trønnes: The CMA helper is already using the drm_fb_helper_generic_probe part of the generic fbdev emulation. This patch makes full use of the generic fbdev emulation by using its drm_client callbacks. This means that drm_mode_config_funcs->output_poll_chan

Re: [PATCH v2 1/9] drm/arc: Use drm_fbdev_generic_setup()

2018-11-01 Thread Noralf Trønnes
Den 25.10.2018 22.13, skrev Noralf Trønnes: The CMA helper is already using the drm_fb_helper_generic_probe part of the generic fbdev emulation. This patch makes full use of the generic fbdev emulation by using its drm_client callbacks. This means that drm_mode_config_funcs->output_poll_chan

Re: [PATCH v5 3/5] drm/gem: Add drm_gem_object_funcs

2018-10-31 Thread Noralf Trønnes
Den 17.10.2018 15.04, skrev Noralf Trønnes: This adds an optional function table on GEM objects. The main benefit is for drivers that support more than one type of memory (shmem,vram,cma) for their buffers depending on the hardware it runs on. With the callbacks attached to the GEM object

Re: [Intel-gfx] [PATCH v5 5/5] drm/tinydrm: Switch from CMA to shmem buffers

2018-10-31 Thread Noralf Trønnes
Den 29.10.2018 10.07, skrev Daniel Vetter: On Sun, Oct 28, 2018 at 09:46:43PM +0100, Noralf Trønnes wrote: Den 28.10.2018 21.21, skrev David Lechner: On 10/26/2018 05:38 PM, Noralf Trønnes wrote: Den 17.10.2018 15.04, skrev Noralf Trønnes: This move makes tinydrm useful for more drivers

Re: [PATCH 0/3] drm: tinydrm driver for adafruit PiTFT 3.5" touchscreen

2018-10-31 Thread Noralf Trønnes
Den 25.10.2018 18.29, skrev Eric Anholt: Eric Anholt writes: I was going to start working on making the vc4 driver work with tinydrm panels, but it turned out tinydrm didn't have the panel I had previously bought. So, last night I ported the fbtft staging driver over to DRM. It seems to

Re: [PATCH v5 5/5] drm/tinydrm: Switch from CMA to shmem buffers

2018-10-28 Thread Noralf Trønnes
Den 28.10.2018 21.21, skrev David Lechner: On 10/26/2018 05:38 PM, Noralf Trønnes wrote: Den 17.10.2018 15.04, skrev Noralf Trønnes: This move makes tinydrm useful for more drivers. tinydrm doesn't need continuous memory, but at the time it was convenient to use the CMA library. The spi core

Re: [PATCH] drm/tinydrm: Advertise that we can do only DRM_FORMAT_MOD_LINEAR.

2018-10-27 Thread Noralf Trønnes
k look at the code seems to support this assumption. Format modifiers is something I've never looked at before. Acked-by: Noralf Trønnes static const struct drm_plane_helper_funcs drm_simple_kms_plane_helper_funcs = { .prepare_fb = drm_simple_kms_plane_prepare_fb, .clea

Re: [PATCH 2/3] drm: Add an hx8367d tinydrm driver.

2018-10-27 Thread Noralf Trønnes
++ b/drivers/gpu/drm/tinydrm/hx8357d.c @@ -0,0 +1,261 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * DRM driver for the HX8357D LCD controller + * + * Copyright 2018 Broadcom + * Copyright 2018 David Lechner + * Copyright 2016 Noralf Trønnes + * Copyright (C) 2015 Adafruit Industries + * Copyright

Re: [PATCH 3/3] drm/tinydrm: Fix setting of the column/page end addresses.

2018-10-27 Thread Noralf Trønnes
Den 24.10.2018 20.43, skrev Eric Anholt: If the clipped dirty region's x/y happened to align to 256, we would have set the top 8 bits wrong. Noticed by inspection, not by reproducing a bug. Signed-off-by: Eric Anholt --- Good catch. Reviewed-by: Noralf Trønnes drivers/gpu/drm/tinydrm

Re: [PATCH 1/3] dt-bindings: new binding for Himax HX8357D display panels

2018-10-27 Thread Noralf Trønnes
8357d/ The adafruit display has an AXP803 that resets the controller. Acked-by: Noralf Trønnes Signed-off-by: Eric Anholt --- .../bindings/display/himax,hx8357d.txt| 25 +++ 1 file changed, 25 insertions(+) create mode 100644 Documentation/devicetree/bindings/di

Re: [PATCH v5 5/5] drm/tinydrm: Switch from CMA to shmem buffers

2018-10-26 Thread Noralf Trønnes
Den 17.10.2018 15.04, skrev Noralf Trønnes: This move makes tinydrm useful for more drivers. tinydrm doesn't need continuous memory, but at the time it was convenient to use the CMA library. The spi core can do dma on is_vmalloc() addresses making this possible. Cc: David Lechner Signed-off

Re: [PATCH 0/3] drm: tinydrm driver for adafruit PiTFT 3.5" touchscreen

2018-10-26 Thread Noralf Trønnes
Den 26.10.2018 21.16, skrev Noralf Trønnes: Den 26.10.2018 04.30, skrev Eric Anholt: Noralf Trønnes writes: Den 25.10.2018 18.29, skrev Eric Anholt: Eric Anholt writes: I was going to start working on making the vc4 driver work with tinydrm panels, but it turned out tinydrm didn't have

Re: [PATCH 0/3] drm: tinydrm driver for adafruit PiTFT 3.5" touchscreen

2018-10-26 Thread Noralf Trønnes
Den 26.10.2018 04.30, skrev Eric Anholt: Noralf Trønnes writes: Den 25.10.2018 18.29, skrev Eric Anholt: Eric Anholt writes: I was going to start working on making the vc4 driver work with tinydrm panels, but it turned out tinydrm didn't have the panel I had previously bought. So, last

Re: [PATCH 0/3] drm: tinydrm driver for adafruit PiTFT 3.5" touchscreen

2018-10-25 Thread Noralf Trønnes
Den 25.10.2018 18.29, skrev Eric Anholt: Eric Anholt writes: I was going to start working on making the vc4 driver work with tinydrm panels, but it turned out tinydrm didn't have the panel I had previously bought. So, last night I ported the fbtft staging driver over to DRM. It seems to

[PATCH v2 8/9] drm/tilcdc: Use drm_fbdev_generic_setup()

2018-10-25 Thread Noralf Trønnes
driver, it is not part of the driver as such. If fbdev setup fails, an error is printed, but the driver succeeds probing. Cc: Jyri Sarha Cc: Tomi Valkeinen Signed-off-by: Noralf Trønnes Acked-by: Sam Ravnborg --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 11 ++- 1 file changed, 2 insertions(+), 9 del

[PATCH v2 6/9] drm/atmel-hlcdc: Use drm_fbdev_generic_setup()

2018-10-25 Thread Noralf Trønnes
driver, it is not part of the driver as such. If fbdev setup fails, an error is printed, but the driver succeeds probing. Cc: Boris Brezillon Signed-off-by: Noralf Trønnes Acked-by: Sam Ravnborg --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff

[PATCH v2 5/9] drm/rcar-du: Use drm_fbdev_generic_setup()

2018-10-25 Thread Noralf Trønnes
driver, it is not part of the driver as such. If fbdev setup fails, an error is printed, but the driver succeeds probing. drm_fbdev_generic_setup() handles mode_config.num_connector being zero. In that case it retries fbdev setup on the next .output_poll_changed. Cc: Laurent Pinchart Signed-off-by: Noralf T

[PATCH v2 7/9] drm/sun4i: Use drm_fbdev_generic_setup()

2018-10-25 Thread Noralf Trønnes
driver, it is not part of the driver as such. If fbdev setup fails, an error is printed, but the driver succeeds probing. Cc: Maxime Ripard Signed-off-by: Noralf Trønnes Acked-by: Sam Ravnborg --- drivers/gpu/drm/sun4i/sun4i_drv.c | 12 +++- drivers/gpu/drm/sun4i/sun4i_framebuffer.

[PATCH v2 9/9] drm/cma-helper: Remove unused fbdev code

2018-10-25 Thread Noralf Trønnes
CMA helper drivers have been converted to drm_fbdev_generic_setup() so the fbdev code can be removed. Cc: Laurent Pinchart Signed-off-by: Noralf Trønnes Acked-by: Sam Ravnborg --- Changes since version 1: - Rebased drivers/gpu/drm/Kconfig | 4 -- drivers/gpu/drm

[PATCH v2 2/9] drm/fsl-dcu: Use drm_fbdev_generic_setup()

2018-10-25 Thread Noralf Trønnes
driver, it is not part of the driver as such. If fbdev setup fails, an error is printed, but the driver succeeds probing. Cc: Stefan Agner Cc: Alison Wang Signed-off-by: Noralf Trønnes Acked-by: Sam Ravnborg Acked-by: Stefan Agner --- Changes since version 1: - Rebased drivers/gpu/drm/fsl-dcu/fsl_dcu_drm

[PATCH v2 3/9] drm/hisilicon/kirin: Use drm_fbdev_generic_setup()

2018-10-25 Thread Noralf Trønnes
driver, it is not part of the driver as such. If fbdev setup fails, an error is printed, but the driver succeeds probing. struct kirin_drm_private can be removed now that driver doesn't have to store the fbdev pointer. Cc: Xinliang Liu Cc: Rongrong Zou Cc: Xinwei Kong Cc: Chen Feng Signed-off-by: Noralf T

[PATCH v2 4/9] drm/mxsfb: Use drm_fbdev_generic_setup()

2018-10-25 Thread Noralf Trønnes
driver, it is not part of the driver as such. If fbdev setup fails, an error is printed, but the driver succeeds probing. Cc: Marek Vasut Signed-off-by: Noralf Trønnes Acked-by: Sam Ravnborg --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 26 ++ drivers/gpu/drm/mxsfb/mxsfb_drv.h | 1 - 2

[PATCH v2 0/9] drm/cma-helper drivers: Use drm_fbdev_generic_setup()

2018-10-25 Thread Noralf Trønnes
://patchwork.freedesktop.org/series/45848/ Noralf. Cc: Alexey Brodkin Cc: Stefan Agner Cc: Xinliang Liu Cc: Rongrong Zou Cc: Xinwei Kong Cc: Chen Feng Cc: Marek Vasut Cc: Laurent Pinchart Cc: Boris Brezillon Cc: Maxime Ripard Cc: Jyri Sarha Cc: Tomi Valkeinen Noralf Trønnes (9): drm/arc: Use

[PATCH v2 1/9] drm/arc: Use drm_fbdev_generic_setup()

2018-10-25 Thread Noralf Trønnes
driver, it is not part of the driver as such. If fbdev setup fails, an error is printed, but the driver succeeds probing. Cc: Alexey Brodkin Signed-off-by: Noralf Trønnes Acked-by: Sam Ravnborg Acked-by: Alexey Brodkin --- Changes since version 1: - Rebased drivers/gpu/drm/arc/arcpgu.h | 4 drive

Re: [PATCH 14/20] drm/stm: Use drm_fbdev_generic_setup()

2018-10-25 Thread Noralf Trønnes
Den 27.09.2018 13.45, skrev Yannick FERTRE: Hi Noralf, many thanks for your patch. Acked-by: Yannick Fertré Applied to drm-misc-next, thanks. Noralf. On 09/08/2018 03:46 PM, Noralf Trønnes wrote: The CMA helper is already using the drm_fb_helper_generic_probe part of the generic fbdev

Re: [PATCH 05/20] drm/meson: Use drm_fbdev_generic_setup()

2018-10-25 Thread Noralf Trønnes
Den 03.10.2018 21.24, skrev Neil Armstrong: Hi Noralf, Le 08/09/2018 15:46, Noralf Trønnes a écrit : The CMA helper is already using the drm_fb_helper_generic_probe part of the generic fbdev emulation. This patch makes full use of the generic fbdev emulation by using its drm_client callbacks

Re: [PATCH v5 4/5] drm: Add library for shmem backed GEM objects

2018-10-22 Thread Noralf Trønnes
Den 17.10.2018 17.46, skrev Daniel Vetter: On Wed, Oct 17, 2018 at 03:04:53PM +0200, Noralf Trønnes wrote: This adds a library for shmem backed GEM objects. v5: - Drop drm_gem_shmem_prime_mmap() (Daniel Vetter) - drm_gem_shmem_mmap(): Subtract drm_vma_node_start() to get the real vma

[PATCH v5 4/5] drm: Add library for shmem backed GEM objects

2018-10-17 Thread Noralf Trønnes
s (Thomas Hellstrom) - Add a GEM attached vtable v3: - Grammar (Sam Ravnborg) - s/drm_gem_shmem_put_pages_unlocked/drm_gem_shmem_put_pages_locked/ (Sam Ravnborg) - Add debug output in error path (Sam Ravnborg) Signed-off-by: Noralf Trønnes --- Documentation/gpu/drm-kms-helpers.rst | 12 + dr

[PATCH v5 1/5] drm/driver: Add defaults for .gem_prime_export/import callbacks

2018-10-17 Thread Noralf Trønnes
The majority of drivers use drm_gem_prime_export() and drm_gem_prime_import() for these callbacks so let's make them the default. Signed-off-by: Noralf Trønnes Acked-by: Daniel Vetter --- Documentation/gpu/todo.rst | 7 +++ drivers/gpu/drm/drm_prime.c | 10 -- include/drm

[PATCH v5 3/5] drm/gem: Add drm_gem_object_funcs

2018-10-17 Thread Noralf Trønnes
ing the fact that this the new default way of doing it (Daniel Vetter) Signed-off-by: Noralf Trønnes Acked-by: Daniel Vetter --- drivers/gpu/drm/drm_client.c | 12 ++-- drivers/gpu/drm/drm_gem.c| 109 --- drivers/gpu/drm/drm_prime.c | 34 ++- include/d

[PATCH v5 5/5] drm/tinydrm: Switch from CMA to shmem buffers

2018-10-17 Thread Noralf Trønnes
This move makes tinydrm useful for more drivers. tinydrm doesn't need continuous memory, but at the time it was convenient to use the CMA library. The spi core can do dma on is_vmalloc() addresses making this possible. Cc: David Lechner Signed-off-by: Noralf Trønnes Acked-by: David Lechner

[PATCH v5 2/5] drm/prime: Add drm_gem_prime_mmap()

2018-10-17 Thread Noralf Trønnes
Add a generic PRIME GEM mmap function. Suggested-by: Daniel Vetter Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_prime.c | 37 + include/drm/drm_prime.h | 1 + 2 files changed, 38 insertions(+) diff --git a/drivers/gpu/drm/drm_prime.c b/drivers

[PATCH v5 0/5] drm: Add shmem GEM library

2018-10-17 Thread Noralf Trønnes
re members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384 #834: FILE: include/drm/drm_gem_shmem_helper.h:84: + bool pages_mark_dirty_on_put; #841: FILE: include/drm/drm_gem_shmem_helper.h:91: + bool pages_mark_accessed_on_put; Noralf Trønnes (5): drm/dr

Re: [PATCH v4 3/4] drm: Add library for shmem backed GEM objects

2018-10-10 Thread Noralf Trønnes
Den 01.10.2018 09.46, skrev Daniel Vetter: On Wed, Sep 26, 2018 at 04:59:32PM +0200, Noralf Trønnes wrote: This adds a library for shmem backed GEM objects. Signed-off-by: Noralf Trønnes --- Changes since version 3: - Drop cache modes (Thomas Hellstrom) - Add a GEM attached vtable

Re: [PATCH] drm/imx: move 'legacyfb_depth' definition out of #ifdef

2018-10-05 Thread Noralf Trønnes
Den 04.10.2018 21.35, skrev Daniel Vetter: On Thu, Oct 04, 2018 at 05:04:21PM +0200, Arnd Bergmann wrote: On Thu, Oct 4, 2018 at 4:43 PM Noralf Trønnes wrote: Den 04.10.2018 09.48, skrev Daniel Vetter: On Wed, Oct 3, 2018 at 9:51 PM Arnd Bergmann wrote: On Wed, Oct 3, 2018 at 6:13 PM

Re: [PATCH] drm/imx: move 'legacyfb_depth' definition out of #ifdef

2018-10-04 Thread Noralf Trønnes
Den 04.10.2018 09.48, skrev Daniel Vetter: On Wed, Oct 3, 2018 at 9:51 PM Arnd Bergmann wrote: On Wed, Oct 3, 2018 at 6:13 PM Daniel Vetter wrote: On Wed, Oct 03, 2018 at 05:49:32PM +0200, Noralf Trønnes wrote: Den 02.10.2018 22.58, skrev Arnd Bergmann: The variable is now referenced

Re: [PATCH] drm/imx: move 'legacyfb_depth' definition out of #ifdef

2018-10-03 Thread Noralf Trønnes
Den 02.10.2018 22.58, skrev Arnd Bergmann: The variable is now referenced unconditionally, but still declared in an #ifdef: drivers/gpu/drm/imx/imx-drm-core.c: In function 'imx_drm_bind': drivers/gpu/drm/imx/imx-drm-core.c:264:6: error: 'legacyfb_depth' undeclared (first use in this

Re: [PATCH v3] drm/cma-helper: Fix crash in fbdev error path

2018-10-02 Thread Noralf Trønnes
Den 01.10.2018 21.45, skrev Noralf Trønnes: Sergey Suloev reported a crash happening in drm_client_dev_hotplug() when fbdev had failed to register. [9.124598] vc4_hdmi 3f902000.hdmi: ASoC: Failed to create component debugfs directory [9.147667] vc4_hdmi 3f902000.hdmi: vc4-hdmi-hifi

[PATCH v3] drm/cma-helper: Fix crash in fbdev error path

2018-10-01 Thread Noralf Trønnes
7f4b3e ("drm/cma-helper: Use the generic fbdev emulation") Reported-by: Sergey Suloev Cc: Stefan Wahren Cc: Eric Anholt Cc: Daniel Vetter Signed-off-by: Noralf Trønnes Reviewed-by: Daniel Vetter --- Changes since version 2: - Fix drm_client_new() ref in docs (Daniel) - Expand drm_c

Re: [PATCH v2] drm/cma-helper: Fix crash in fbdev error path

2018-10-01 Thread Noralf Trønnes
Den 01.10.2018 18.44, skrev Daniel Vetter: On Mon, Oct 01, 2018 at 04:57:32PM +0200, Noralf Trønnes wrote: Sergey Suloev reported a crash happening in drm_client_dev_hotplug() when fbdev had failed to register. [9.124598] vc4_hdmi 3f902000.hdmi: ASoC: Failed to create component debugfs

[PATCH v2] drm/cma-helper: Fix crash in fbdev error path

2018-10-01 Thread Noralf Trønnes
7f4b3e ("drm/cma-helper: Use the generic fbdev emulation") Reported-by: Sergey Suloev Cc: Stefan Wahren Cc: Eric Anholt Cc: Daniel Vetter Signed-off-by: Noralf Trønnes --- Changes since version 1: - Split drm_client_new() instead of letting drm_client hang around (Daniel) Just to m

Re: [PATCH] drm/rcar-du: Convert drm_atomic_helper_suspend/resume()

2018-10-01 Thread Noralf Trønnes
to merge it through drm-misc as it touches drm_fb_cma_helper.c ? I just realized that the same patch got supplied by Noralf Trønnes nearly a year ago, and was later superseded by https://patchwork.freedesktop.org/patch/247861/. I think we should thus apply Noralf's patches instead (once he sends v4 out

Re: [PATCH 02/20] drm/arc: Use drm_fbdev_generic_setup()

2018-10-01 Thread Noralf Trønnes
Den 01.10.2018 09.56, skrev Alexey Brodkin: Hi Noralf, On Fri, 2018-09-28 at 12:42 +0200, Noralf Trønnes wrote: Den 28.09.2018 09.34, skrev Alexey Brodkin: Hi Noralf, On Sat, 2018-09-08 at 15:46 +0200, Noralf Trønnes wrote: The CMA helper is already using the drm_fb_helper_generic_probe

Re: vc4: NULL pointer dereference in drm_client_dev_hotplug

2018-09-30 Thread Noralf Trønnes
framebuffer height 2880, should be >= 0 && <= 2048 [    3.001650] vc4-drm soc:gpu: [drm:drm_fb_helper_fbdev_setup [drm_kms_helper]] *ERROR* Failed to set fbdev configuration On 09/30/2018 03:29 PM, Noralf Trønnes wrote: Den 29.09.2018 22.52, skrev Sergey Suloev: Hi, the last

Re: vc4: NULL pointer dereference in drm_client_dev_hotplug

2018-09-30 Thread Noralf Trønnes
-August/186634.html Noralf. Sergey On 09/29/2018 08:14 PM, Noralf Trønnes wrote: Den 28.09.2018 23.01, skrev Stefan Wahren: Hi, Sergey Suloev already reported this NULL pointer dereference [1]. Now he was able to provide a Kernel config and i'm able to reproduce it with a Raspber

Re: vc4: NULL pointer dereference in drm_client_dev_hotplug

2018-09-29 Thread Noralf Trønnes
Den 28.09.2018 23.01, skrev Stefan Wahren: Hi, Sergey Suloev already reported this NULL pointer dereference [1]. Now he was able to provide a Kernel config and i'm able to reproduce it with a Raspberry Pi 3 (arm64) and Linux 4.19-rc5. It seems like a invalid config [2] for vc4, but

[PATCH] drm/cma-helper: Fix crash in fbdev error path

2018-09-29 Thread Noralf Trønnes
v emulation") Reported-by: Sergey Suloev Cc: Stefan Wahren Cc: Eric Anholt Cc: Daniel Vetter Signed-off-by: Noralf Trønnes --- This bug is in 4.19 so it should go into drm-misc-fixes right? (I have never applied a fix before) Noralf. drivers/gpu/drm/drm_fb_cma_helper.c | 19 +--

Re: [PATCH 03/20] drm/fsl-dcu: Use drm_fbdev_generic_setup()

2018-09-28 Thread Noralf Trønnes
Den 28.09.2018 16.11, skrev Stefan Agner: On 27.09.2018 23:23, Noralf Trønnes wrote: Den 27.09.2018 23.08, skrev Stefan Agner: On 08.09.2018 15:46, Noralf Trønnes wrote: The CMA helper is already using the drm_fb_helper_generic_probe part of the generic fbdev emulation. This patch makes full

Re: [PATCH 02/20] drm/arc: Use drm_fbdev_generic_setup()

2018-09-28 Thread Noralf Trønnes
Den 28.09.2018 09.34, skrev Alexey Brodkin: Hi Noralf, On Sat, 2018-09-08 at 15:46 +0200, Noralf Trønnes wrote: The CMA helper is already using the drm_fb_helper_generic_probe part of the generic fbdev emulation. This patch makes full use of the generic fbdev emulation by using its drm_client

Re: [PATCH 03/20] drm/fsl-dcu: Use drm_fbdev_generic_setup()

2018-09-27 Thread Noralf Trønnes
Den 27.09.2018 23.08, skrev Stefan Agner: On 08.09.2018 15:46, Noralf Trønnes wrote: The CMA helper is already using the drm_fb_helper_generic_probe part of the generic fbdev emulation. This patch makes full use of the generic fbdev emulation by using its drm_client callbacks. This means

Re: [PATCH v3 00/11] drm/cma-helper: Remove drm_fbdev_cma* functions

2018-09-27 Thread Noralf Trønnes
Den 08.12.2017 20.37, skrev Noralf Trønnes: These are the remaining patches not applied due to missing review and: - arm/hdlcd and rcar-du have started to use drm_fbdev_cma_set_suspend_unlocked() since last, so I have added patches converting them to drm_mode_config_helper_suspend/resume

Re: [PATCH v2 03/22] drm/arc: Use drm_fb_cma_fbdev_init/fini()

2018-09-27 Thread Noralf Trønnes
Den 27.09.2018 10.49, skrev Alexey Brodkin: Hi Noralf, On Wed, 2017-11-15 at 15:19 +0100, Noralf Trønnes wrote: Use drm_fb_cma_fbdev_init() and drm_fb_cma_fbdev_fini() which relies on the fact that drm_device holds a pointer to the drm_fb_helper structure. This means that the driver doesn't

<    7   8   9   10   11   12   13   14   15   16   >