Re: [PATCH 15/44] drm/udl: Use demv_drm_dev_alloc

2020-04-05 Thread Noralf Trønnes
Den 03.04.2020 15.57, skrev Daniel Vetter: > Also init the fbdev emulation before we register the device, that way > we can rely on the auto-cleanup and simplify the probe error code even > more. > > Signed-off-by: Daniel Vetter > Cc: Dave Airlie > Cc: Sean Paul > Cc: Thomas Zimmermann >

Re: [PATCH 39/44] drm/cirrus: Use devm_drm_dev_alloc

2020-04-05 Thread Noralf Trønnes
Den 03.04.2020 15.58, skrev Daniel Vetter: > Already using devm_drm_dev_init, so very simple replacment. > > Signed-off-by: Daniel Vetter > Cc: Dave Airlie > Cc: Gerd Hoffmann > Cc: Daniel Vetter > Cc: Sam Ravnborg > Cc: "Noralf Trønnes" > Cc: Rob H

Re: [PATCH 21/44] drm/ili9486: Use devm_drm_dev_alloc

2020-04-05 Thread Noralf Trønnes
Den 03.04.2020 15.58, skrev Daniel Vetter: > Already using devm_drm_dev_init, so very simple replacment. > > Signed-off-by: Daniel Vetter > Cc: Kamlesh Gurudasani > --- Acked-by: Noralf Trønnes ___ dri-devel mailing

Re: [PATCH 20/44] drm/mi0283qt: Use devm_drm_dev_alloc

2020-04-05 Thread Noralf Trønnes
Den 03.04.2020 15.58, skrev Daniel Vetter: > Already using devm_drm_dev_init, so very simple replacment. > > Signed-off-by: Daniel Vetter > Cc: "Noralf Trønnes" > --- Acked-by: Noralf Trønnes ___ dri-dev

Re: [PATCH 19/44] drm/repaper: Use devm_drm_dev_alloc

2020-04-05 Thread Noralf Trønnes
Den 03.04.2020 15.58, skrev Daniel Vetter: > Already using devm_drm_dev_init, so very simple replacment. > > Signed-off-by: Daniel Vetter > Cc: "Noralf Trønnes" > --- Acked-by: Noralf Trønnes ___ dri-dev

Re: [PATCH] drm/mipi-dbi: Make mipi_dbi_command_stackbuf() data parameter const

2020-03-20 Thread Noralf Trønnes
; > OK to merge? > Looks good to me and build did not break. Sure, I planned to look at it this weekend, but if you can apply it, great. Reviewed-by: Noralf Trønnes Noralf. > > Sam > >> --- >> drivers/gpu/drm/drm_mipi_dbi.c | 3 ++- >> include/drm/drm_mipi_

Re: [PATCH 2/2] drm/format_helper: Dual licence the header in GPL-2 and MIT

2020-03-20 Thread Noralf Trønnes
Den 20.03.2020 03.21, skrev Emmanuel Vadot: > Source file was dual licenced but the header was omitted, fix that. > Contributors for this file are: > Noralf Trønnes > Gerd Hoffmann > Thomas Gleixner > > Signed-off-by: Emmanuel Vadot > ---

Re: [PATCH 1/2] drm/client: Dual licence the header in GPL-2 and MIT

2020-03-20 Thread Noralf Trønnes
Den 20.03.2020 03.21, skrev Emmanuel Vadot: > Source file was dual licenced but the header was omitted, fix that. > Contributors for this file are: > Daniel Vetter > Matt Roper > Maxime Ripard > Noralf Trønnes > Thomas Zimmermann > > Signed-off-by: Emmanuel Vad

Re: [RFC 2/9] mfd: Add driver for Multifunction USB Device

2020-02-29 Thread Noralf Trønnes
Den 27.02.2020 10.09, skrev Lee Jones: > I'd really like someone from USB to have a look through this too. > > I'll do a quick first pass and provide some general comments though. > > On Sun, 16 Feb 2020, Noralf Trønnes wrote: >> A Multifunction USB Device is a device th

Re: [PATCH v2 1/2] drm/client: Dual licence the file in GPL-2 and MIT

2020-02-28 Thread Noralf Trønnes
l Vadot wrote: >>>>> From: Emmanuel Vadot >>>>> >>>>> Contributors for this file are : >>>>> Chris Wilson >>>>> Denis Efremov >>>>> Jani Nikula >>>>> Maxime Ripard >>>>> N

Re: [RFC 8/9] drm/client: Add drm_client_init_from_id() and drm_client_modeset_set()

2020-02-23 Thread Noralf Trønnes
Den 17.02.2020 10.38, skrev Daniel Vetter: > On Sun, Feb 16, 2020 at 06:21:16PM +0100, Noralf Trønnes wrote: >> drm_client_init_from_id() provides a way for clients to add a client based >> on the minor. drm_client_modeset_set() provides a way to set the modeset >> for

Re: [PATCH 26/51] drm: Manage drm_mode_config_init with drmm_

2020-02-23 Thread Noralf Trønnes
n fails, we'd be > missing some mutex_destroy and ida_cleanup otherwise (Laurent) > > v4: Add a drmm_add_action_or_reset (like devm_ has) to encapsulate this > pattern (Noralf). > > Cc: Laurent Pinchart > Cc: "Noralf Trønnes" > Cc: Sam Ravnborg > Cc: Thomas

Re: [PATCH 48/52] drm/mipi-dbi: Move drm_mode_config_init into mipi library

2020-02-20 Thread Noralf Trønnes
Den 19.02.2020 11.21, skrev Daniel Vetter: > 7/7 drivers agree that's the right choice, let's do this. > > This avoids duplicating the same old error checking code over all 7 > drivers, which is the motivation here. > > Signed-off-by: Daniel Vetter > --- Review

Re: [PATCH 49/52] drm/mipi-dbi: Drop explicit drm_mode_config_cleanup call

2020-02-20 Thread Noralf Trønnes
vid Airlie > Cc: Daniel Vetter > Cc: Eric Anholt > Cc: David Lechner > Cc: Kamlesh Gurudasani > Cc: "Noralf Trønnes" > Cc: Sam Ravnborg > --- Reviewed-by: Noralf Trønnes ___ dri-devel mailing list dri-devel@list

Re: [PATCH 47/52] drm/repaper: Drop explicit drm_mode_config_cleanup call

2020-02-20 Thread Noralf Trønnes
Den 19.02.2020 11.21, skrev Daniel Vetter: > Allows us to drop the drm_driver.release callback. > > Signed-off-by: Daniel Vetter > Cc: "Noralf Trønnes" > --- Reviewed-by: Noralf Trønnes ___ dri-devel mailing list dri-de

Re: [PATCH 16/52] drm/repaper: Use drmm_add_final_kfree

2020-02-20 Thread Noralf Trønnes
Den 19.02.2020 11.20, skrev Daniel Vetter: > With this we can drop the final kfree from the release function. > > Signed-off-by: Daniel Vetter > Cc: "Noralf Trønnes" > --- Reviewed-by: Noralf Trønnes ___ dri-dev

Re: [PATCH 05/52] drm/mipi_dbi: Use drmm_add_final_kfree in all drivers

2020-02-20 Thread Noralf Trønnes
ers, the first few lines around devm_drm_dev_init > are all the same (except for the drm_driver pointer). > > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Thomas Zimmermann > Cc: David Airlie > Cc: Daniel Vetter > Cc: Eric Anholt > Cc: David Lechner > Cc:

Re: [PATCH 27/52] drm: Manage drm_mode_config_init with drmm_

2020-02-19 Thread Noralf Trønnes
gt; devm_drm_dev_init(). >>>>> >>>>> Also with drmm_ explicit drm_driver->release hooks are kinda not the >>>>> best option, so deprecate that hook to discourage future users. >>>>> >>>>> v2: Fixup the example in the kernel

Re: [RFC 0/9] Regmap over USB for Multifunction USB Device (gpio, display, ...)

2020-02-18 Thread Noralf Trønnes
Den 18.02.2020 21.57, skrev Andy Shevchenko: > On Sun, Feb 16, 2020 at 7:30 PM Noralf Trønnes wrote: >> >> Hi, >> >> A while back I had the idea to turn a Raspberry Pi Zero into a $5 >> USB to HDMI/SDTV/DSI/DPI display adapter. >> >> Thinking about

Re: [RFC 1/9] regmap: Add USB support

2020-02-17 Thread Noralf Trønnes
Den 17.02.2020 22.39, skrev Mark Brown: > On Mon, Feb 17, 2020 at 10:33:58PM +0100, Noralf Trønnes wrote: >> Den 17.02.2020 13.11, skrev Mark Brown: > >>> This looks like you just don't support a straight write operation, if >>> you need to do this emulation pus

Re: [RFC 1/9] regmap: Add USB support

2020-02-17 Thread Noralf Trønnes
Den 17.02.2020 13.11, skrev Mark Brown: > On Sun, Feb 16, 2020 at 06:21:09PM +0100, Noralf Trønnes wrote: > >> Add support for regmap over USB for use with the Multifunction USB Device. >> Two endpoints IN/OUT are used. Up to 255 regmaps are supported on one USB >>

Re: [RFC 0/9] Regmap over USB for Multifunction USB Device (gpio, display, ...)

2020-02-17 Thread Noralf Trønnes
Den 17.02.2020 11.32, skrev Neil Armstrong: > Hi, > > On 16/02/2020 18:21, Noralf Trønnes wrote: >> Hi, >> >> A while back I had the idea to turn a Raspberry Pi Zero into a $5 >> USB to HDMI/SDTV/DSI/DPI display adapter. >> >> Thinking about how to r

[RFC 2/9] mfd: Add driver for Multifunction USB Device

2020-02-16 Thread Noralf Trønnes
A Multifunction USB Device is a device that supports functions like gpio and display or any other function that can be represented as a USB regmap. Interrupts over USB is also supported if such an endpoint is present. Signed-off-by: Noralf Trønnes --- drivers/mfd/Kconfig | 8 + drivers

[RFC 7/9] drm: Add Multifunction USB Device display driver

2020-02-16 Thread Noralf Trønnes
The Multifunction USB Device has optional support for displays. LZ4 compression is used if the device supports it. The driver is MIT licensed in the hope that parts of it can be used on the BSD's. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/Kconfig |2 + drivers/gpu/drm

[RFC 5/9] usb: gadget: function: mud: Add gpio support

2020-02-16 Thread Noralf Trønnes
Add optional gpio functionality to the Multifunction USB Device. Signed-off-by: Noralf Trønnes --- drivers/usb/gadget/Kconfig | 14 + drivers/usb/gadget/function/Makefile | 2 + drivers/usb/gadget/function/f_mud_pins.c | 962 +++ 3 files changed, 978

[RFC 3/9] usb: gadget: function: Add Multifunction USB Device support

2020-02-16 Thread Noralf Trønnes
This is the gadget side of the mfd host driver. It provides a USB function that drivers can hook into providing functions like gpio and display as regmaps to the host. These drivers are configured through configfs. Signed-off-by: Noralf Trønnes --- drivers/usb/gadget/Kconfig | 10

[RFC 8/9] drm/client: Add drm_client_init_from_id() and drm_client_modeset_set()

2020-02-16 Thread Noralf Trønnes
drm_client_init_from_id() provides a way for clients to add a client based on the minor. drm_client_modeset_set() provides a way to set the modeset for clients that handles connectors and display mode on their own. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_client.c | 37

[RFC 9/9] usb: gadget: function: mud: Add display support

2020-02-16 Thread Noralf Trønnes
Add optional display functionality to the Multifunction USB Device. The bulk of the code is placed in the drm subsystem since it's reaching into the drm internals. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/mud/Kconfig | 3 + drivers/gpu/drm/mud/Makefile| 1

[RFC 4/9] pinctrl: Add Multifunction USB Device pinctrl driver

2020-02-16 Thread Noralf Trønnes
The Multifunction USB Device has optional support for gpio and pin configuration. Interrupts are supported if the device supports it. Signed-off-by: Noralf Trønnes --- drivers/pinctrl/Kconfig | 9 + drivers/pinctrl/Makefile | 1 + drivers/pinctrl/pinctrl-mud.c | 657

[RFC 0/9] Regmap over USB for Multifunction USB Device (gpio, display, ...)

2020-02-16 Thread Noralf Trønnes
this with usb2 devices (Pi, BBB) so I should get myself a usb3 gadget capable board. My searching didn't turn up much, so this seems to be quite rare. ROCK960 has USB 3.0 type C OTG but the price is $139 which is a bit expensive for this hobby project. Does anyone know of a cheap board? Noralf. Noralf

[RFC 1/9] regmap: Add USB support

2020-02-16 Thread Noralf Trønnes
transfers. Signed-off-by: Noralf Trønnes --- drivers/base/regmap/Kconfig |8 +- drivers/base/regmap/Makefile |1 + drivers/base/regmap/regmap-usb.c | 1026 ++ include/linux/regmap.h | 23 + include/linux/regmap_usb.h | 97 +++ 5 files

[RFC 6/9] regmap: Speed up _regmap_raw_write_impl() for large buffers

2020-02-16 Thread Noralf Trønnes
When writing a 3MB buffer the unwritable check in _regmap_raw_write_impl() adds a ~20ms overhead on a Raspberry Pi 4. Amend this by avoiding the check if it's not necessary. Signed-off-by: Noralf Trønnes --- drivers/base/regmap/regmap.c | 10 ++ 1 file changed, 6 insertions(+), 4

Re: [PATCH v2 2/2] drm/format_helper: Dual licence the file in GPL 2 and MIT

2020-02-15 Thread Noralf Trønnes
Den 15.02.2020 19.09, skrev Emmanuel Vadot: > From: Emmanuel Vadot > > Contributors for this file are : > Gerd Hoffmann > Maxime Ripard > Noralf Trønnes > > Signed-off-by: Emmanuel Vadot > --- Acked-by: Noralf Trønnes __

Re: [PATCH v2 1/2] drm/client: Dual licence the file in GPL-2 and MIT

2020-02-15 Thread Noralf Trønnes
Den 15.02.2020 19.09, skrev Emmanuel Vadot: > From: Emmanuel Vadot > > Contributors for this file are : > Chris Wilson > Denis Efremov > Jani Nikula > Maxime Ripard > Noralf Trønnes > Sam Ravnborg > Thomas Zimmermann > > Signed-off-by: Emmanuel Va

Re: [PATCH v2 2/2] drm/qxl: add drm_driver.release callback.

2020-02-10 Thread Noralf Trønnes
(adding back Daniel) Den 10.02.2020 17.57, skrev Noralf Trønnes: > > > Den 10.02.2020 16.06, skrev Daniel Vetter: >> On Mon, Feb 10, 2020 at 12:37:52PM +0100, Gerd Hoffmann wrote: >>> Move final cleanups to qxl_drm_release() callback. >>> Add drm_atomic_helper_

Re: [PATCH v2 2/2] drm/qxl: add drm_driver.release callback.

2020-02-10 Thread Noralf Trønnes
Den 10.02.2020 16.06, skrev Daniel Vetter: > On Mon, Feb 10, 2020 at 12:37:52PM +0100, Gerd Hoffmann wrote: >> Move final cleanups to qxl_drm_release() callback. >> Add drm_atomic_helper_shutdown() call to qxl_pci_remove(). >> >> Signed-off-by: Gerd Hoffmann >> --- >>

Re: [PATCH 2/6] drm: Add drm_simple_encoder_{init,create}()

2020-02-07 Thread Noralf Trønnes
Den 07.02.2020 09.41, skrev Thomas Zimmermann: > The simple-encoder helpers initialize an encoder with an empty > implementation. This covers the requirements of most of the existing > DRM drivers. A call to drm_simple_encoder_create() allocates and > initializes an encoder instance, a call to

Re: fbtft: 5 years in staging

2020-02-02 Thread Noralf Trønnes
Den 02.02.2020 16.41, skrev Noralf Trønnes: > Hi, > > Since I'm the original author of fbtft I thought I'd highlight a couple > of issues that's probably not well known. > > Right after fbtft was added, fbdev was closed for new drivers[1] and > the fbdev maintainer w

fbtft: 5 years in staging

2020-02-02 Thread Noralf Trønnes
Hi, Since I'm the original author of fbtft I thought I'd highlight a couple of issues that's probably not well known. Right after fbtft was added, fbdev was closed for new drivers[1] and the fbdev maintainer wanted to remove fbtft as a consequence of that decision, but Greg KH said he'd keep

Re: [PATCH 3/5] drm/client: Rename _force to _locked

2020-01-29 Thread Noralf Trønnes
, the emphasis is now that "I hold the lock" right? > already" aspect, so rename the function to match. > > Suggested by Noralf. > > Cc: Noralf Trønnes > Signed-off-by: Daniel Vetter > --- Reviewed-by: Noralf Trønnes __

Re: [PATCH 2/4] drm/fbdev-helper: don't force restores

2020-01-28 Thread Noralf Trønnes
tatus. > > Also add a comment to the drm_client->restore hook that this is expected > going forward from all clients (there's currently just one). > > v2: Also drop the force in pan_display > > Cc: Noralf Trønnes > Signed-off-by: Daniel Vetter > --- > dri

Re: [PATCH v4 3/3] drm/tinydrm: add support for tft displays based on ilitek,ili9486

2020-01-27 Thread Noralf Trønnes
Den 27.01.2020 15.26, skrev Kamlesh Gurudasani: > This adds support fot ilitek,ili9486 based displays with shift register > in front of controller. > Ozzmaker,Piscreen and Waveshare,rpi-lcd-35 are such displays. > > Signed-off-by: Kamlesh Gurudasani > --- Reviewed-by: Nor

Re: [PATCH v2 2/2] drm/tinydrm: add support for tft displays based on ilitek,ili9486

2020-01-27 Thread Noralf Trønnes
Den 26.01.2020 18.42, skrev Kamlesh Gurudasani: > This adds support fot ilitek,ili9486 based displays with shift register > in front of controller. > Ozzmaker,Piscreen and Waveshare,rpi-lcd-35 are such displays. > > Signed-off-by: Kamlesh Gurudasani > --- Reviewed-by: Nor

Re: [PATCH 1/2] dt-bindings: add binding for Ilitek ili9486 based display panels

2020-01-25 Thread Noralf Trønnes
Den 25.01.2020 16.38, skrev Kamlesh Gurudasani: > Signed-off-by: Kamlesh Gurudasani > --- > .../devicetree/bindings/display/ilitek,ili9486.txt | 27 > ++ For version 2, send the patchset to the devicetree mailinglist as well. A DT maintainer has to review it. Send the

Re: [PATCH 2/2] drm/tinydrm: add support for ilitek,ili9486 based displays with regwidth=16

2020-01-25 Thread Noralf Trønnes
Hi Kamlesh, Nice to see this driver, this means I can now drop the piscreen driver from the out-of-tree tinydrm repo. Den 25.01.2020 16.38, skrev Kamlesh Gurudasani: > This adds support fot ilitek,ili9486 based display with shift register in > front s/fot/for/ > of controller, basically with

Re: [PATCH v2 3/5] drm/mipi_dbi: Add support for display offsets

2020-01-19 Thread Noralf Trønnes
hifted image. > > Add support for specifying these offsets. > > Signed-off-by: Geert Uytterhoeven > Reviewed-by: Sam Ravnborg > --- Acked-by: Noralf Trønnes ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.fr

Re: [PATCH] drm/mipi_dbi: Fix off-by-one bugs in mipi_dbi_blank()

2020-01-02 Thread Noralf Trønnes
Den 30.12.2019 14.06, skrev Geert Uytterhoeven: > When configuring the frame memory window, the last column and row > numbers are written to the column resp. page address registers. These > numbers are thus one less than the actual window width resp. height. > > While this is handled

Re: [PATCH v2 02/14] drm/fb-helper: don't preserve fb_ops across deferred IO use

2019-11-29 Thread Noralf Trønnes
Den 29.11.2019 11.29, skrev Jani Nikula: > Deferred IO now preserves the fb_ops. > > v2: Remove the no-op vfree, drop a local var (Noralf) > > Cc: Noralf Trønnes > Cc: dri-devel@lists.freedesktop.org > Reviewed-by: Daniel Vetter > Signed-off-by: Jani Nikula &g

Re: [PATCH v2 01/14] video: fb_defio: preserve user fb_ops

2019-11-29 Thread Noralf Trønnes
considerably by calling fb_deferred_io_mmap() directly > (Daniel, Ville) > > Cc: Jaya Kumar > Cc: linux-fb...@vger.kernel.org > Cc: Daniel Vetter > Cc: Ville Syrjälä > Signed-off-by: Jani Nikula > --- Nice simple solution: Acked-by: Noralf Trønnes __

Re: [Intel-gfx] [PATCH 02/13] drm/fb-helper: don't preserve fb_ops across deferred IO use

2019-11-28 Thread Noralf Trønnes
Den 28.11.2019 13.05, skrev Jani Nikula: > On Thu, 28 Nov 2019, Noralf Trønnes wrote: >> Den 27.11.2019 17.31, skrev Jani Nikula: >>> Deferred IO now preserves the fb_ops. >>> >>> Cc: Noralf Trønnes >>> Cc: dri-devel@lists.freedesktop.org >>

Re: [PATCH 02/13] drm/fb-helper: don't preserve fb_ops across deferred IO use

2019-11-28 Thread Noralf Trønnes
Den 27.11.2019 17.31, skrev Jani Nikula: > Deferred IO now preserves the fb_ops. > > Cc: Noralf Trønnes > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/drm_fb_helper.c | 18 ++ > 1 file changed, 2 ins

Re: [PATCH v1 3/5] fbtft: Drop useless #ifdef CONFIG_OF and dead code

2019-11-20 Thread Noralf Trønnes
Den 20.11.2019 15.43, skrev Noralf Trønnes: > > > Den 20.11.2019 10.57, skrev Andy Shevchenko: >> First of all there is no need to guard GPIO request by CONFIG_OF. >> It works for everybody independently on resource provider. While here, >> rename the fu

Re: [PATCH v1 3/5] fbtft: Drop useless #ifdef CONFIG_OF and dead code

2019-11-20 Thread Noralf Trønnes
Den 20.11.2019 10.57, skrev Andy Shevchenko: > First of all there is no need to guard GPIO request by CONFIG_OF. > It works for everybody independently on resource provider. While here, > rename the function to reflect the above. > > Moreover, since we have a global dependency to OF, the rest

Re: drm core/helpers and MIT license

2019-11-16 Thread Noralf Trønnes
Den 16.11.2019 12.57, skrev Emmanuel Vadot: > On Fri, 15 Nov 2019 15:33:46 +0100 > Noralf Trønnes wrote: > >> >> >> Den 15.11.2019 13.34, skrev Ville Syrjälä: >>> On Thu, Nov 14, 2019 at 08:01:32PM +, co...@sdf.org wrote: >>>> Hi Daniel, &g

Re: drm core/helpers and MIT license

2019-11-15 Thread Noralf Trønnes
Den 15.11.2019 13.34, skrev Ville Syrjälä: > On Thu, Nov 14, 2019 at 08:01:32PM +, co...@sdf.org wrote: >> Hi Daniel, >> >> I don't think we can make any complaints about GPL being more widely >> used in the DRM code. It's nice to have the code at all, the MIT license >> is a bonus. Thanks

Re: [PATCH v4 3/3] fbdev: Unexport unlink_framebuffer()

2019-11-13 Thread Noralf Trønnes
Den 13.11.2019 12.52, skrev Thomas Zimmermann: > There are no external callers of unlink_framebuffer() left. Make the > function an internal interface. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Noralf Trønnes ___ dr

Re: [PATCH v4 2/3] drm/fb-helper: Remove drm_fb_helper_unlink_fbi()

2019-11-13 Thread Noralf Trønnes
Den 13.11.2019 12.52, skrev Thomas Zimmermann: > There are no callers of drm_fb_helper_unlink_fbi() left. Remove the > function. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Noralf Trønnes ___ dri-devel mailing

Re: [PATCH v4 1/3] drm/udl: Replace fbdev code with generic emulation

2019-11-13 Thread Noralf Trønnes
udl_device *udl) > if (ret) > goto err; > > - ret = udl_fbdev_init(dev); > + ret = drm_fbdev_generic_setup(dev, 16); I suggest you put this after drm_dev_register() in _probe() since fbdev is a client, a user of the driver, not part of it as such.

Re: [PATCH 2/2] drm/fb-helper: refcount drm_device for generic support

2019-11-12 Thread Noralf Trønnes
t; Also, more reasons to switch drivers over to generic fbdev support. > > Since I had to re-review a pile of code also add a comment about why > drm_fbdev_client_unregister can't race. > > Cc: Gerd Hoffmann > Cc: Noralf Trønnes > Cc: Thomas Zimmermann > Signed-off-b

Re: [PATCH 1/2] drm/fb-helper: unexpoert drm_fb_helper_generic_probe

2019-11-12 Thread Noralf Trønnes
robe looks like a recipe for disaster. > > Cc: Gerd Hoffmann > Cc: Noralf Trønnes > Cc: Thomas Zimmermann > Signed-off-by: Daniel Vetter > --- This was needed during conversion of the cma-helper, and then I forgot... Reviewed-by: Noralf Trønnes

Re: [PATCH 1/4] drm/udl: Replace fbdev code with generic emulation

2019-11-08 Thread Noralf Trønnes
Den 08.11.2019 13.33, skrev Thomas Zimmermann: > The udl driver can use the generic fbdev implementation. Convert it. > > Signed-off-by: Thomas Zimmermann > --- > diff --git a/drivers/gpu/drm/udl/udl_drv.c b/drivers/gpu/drm/udl/udl_drv.c > index 563cc5809e56..55c0f9dfee29 100644 > ---

Re: [PATCH v2 1/2] drm/todo: Convert drivers to generic fbdev emulation

2019-11-06 Thread Noralf Trønnes
* keep a TODO item on drm_fb_helper_init() > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Noralf Trønnes ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 4/4] drm/udl: Remove struct udl_gem_object and functions

2019-11-06 Thread Noralf Trønnes
Den 06.11.2019 11.47, skrev Thomas Zimmermann: > Simply removes all the obsolete GEM code from udl. No functional > changes. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/udl/Makefile | 2 +- > drivers/gpu/drm/udl/udl_dmabuf.c | 254 --- >

Re: [PATCH 2/2] drm/fb-helper: Remove drm_fb_helper_fbdev_{setup,teardown}()

2019-10-30 Thread Noralf Trønnes
--- > include/drm/drm_fb_helper.h | 25 > 2 files changed, 1 insertion(+), 133 deletions(-) > Thanks for the cleanup: Reviewed-by: Noralf Trønnes ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/2] drm/todo: Convert drivers to generic fbdev emulation

2019-10-30 Thread Noralf Trønnes
Den 29.10.2019 08.06, skrev Thomas Zimmermann: > This replaces the orignal TODO item for drm_fb_helper_fbdev_setup() and > _teardown(), which are deprecated. > > Signed-off-by: Thomas Zimmermann > --- > Documentation/gpu/todo.rst | 15 +++ > 1 file changed, 7 insertions(+), 8

Re: [PATCH] drm/tinydrm: Fix memroy leak in hx8357d_probe

2019-10-29 Thread Noralf Trønnes
Hi Navid, Den 27.10.2019 18.32, skrev Navid Emamdoost: > In the implementation of hx8357d_probe() the allocated memory for dbidev > is leaked when an error happens. Release dbidev if any of the following > calls fail: devm_gpiod_get(), devm_of_find_backlight(), > mipi_dbi_spi_init(),

Re: [PATCH 2/2] drm/todo: Clarify situation around fbdev and defio

2019-10-25 Thread Noralf Trønnes
elf, which breaks shmem > +gem objects (and other things). To support defio, affected drivers require > +the use of a shadow buffer, which may add CPU and memory overhead. > Ah yes, there's a todo on this. Look good to me: Acked-by: Noralf Trønnes > Possible solution would be to w

Re: [PATCH 1/2] drm/fb-helper: Remove drm_fb_helper_defio_init() and update docs

2019-10-25 Thread Noralf Trønnes
of that function (the same with *_seup()). Would be nice if you just removed them. I made them before I embarked on the generic fbdev solution. I think it's better to try and make the generic emulation usable for "everyone" and avoid the need for drivers to have to do their own special stuf

Re: [PATCH 3/5] drm/udl: Add GEM object functions for free(), vmap(), and vunmap()

2019-10-25 Thread Noralf Trønnes
Den 25.10.2019 14.20, skrev Thomas Zimmermann: > (cc: Gerd) > > Hi > > Am 25.10.19 um 13:44 schrieb Noralf Trønnes: >> >> >> Den 25.10.2019 12.12, skrev Thomas Zimmermann: >>> Hi >>> >>> Am 25.10.19 um 11:28 schrieb Daniel Ve

Re: [PATCH 3/5] drm/udl: Add GEM object functions for free(), vmap(), and vunmap()

2019-10-25 Thread Noralf Trønnes
Den 25.10.2019 13.44, skrev Noralf Trønnes: > > > Den 25.10.2019 12.12, skrev Thomas Zimmermann: >> Hi >> >> Am 25.10.19 um 11:28 schrieb Daniel Vetter: >>> On Fri, Oct 25, 2019 at 9:59 AM Thomas Zimmermann >>> wrote >>>> >

Re: [PATCH 3/5] drm/udl: Add GEM object functions for free(), vmap(), and vunmap()

2019-10-25 Thread Noralf Trønnes
Den 25.10.2019 12.12, skrev Thomas Zimmermann: > Hi > > Am 25.10.19 um 11:28 schrieb Daniel Vetter: >> On Fri, Oct 25, 2019 at 9:59 AM Thomas Zimmermann wrote >>> >>> Hi >>> >>> Am 25.10.19 um 09:40 schrieb Daniel Vetter: On Thu, Oct 24, 2019 at 04:42:35PM +0200, Thomas Zimmermann wrote:

Re: [PATCH 5/5] drm/udl: Replace fbdev code with generic emulation

2019-10-25 Thread Noralf Trønnes
Den 25.10.2019 10.00, skrev Daniel Vetter: > On Fri, Oct 25, 2019 at 09:47:46AM +0200, Daniel Vetter wrote: >> On Thu, Oct 24, 2019 at 04:42:37PM +0200, Thomas Zimmermann wrote: >>> Signed-off-by: Thomas Zimmermann >>> --- >>> drivers/gpu/drm/udl/udl_drv.c | 3 + >>>

Re: [PATCH v1] drm/mipi_dbi: Use simple right shift instead of double negation

2019-10-22 Thread Noralf Trønnes
Den 17.10.2019 18.27, skrev Noralf Trønnes: > > > Den 17.10.2019 13.49, skrev Andy Shevchenko: >> GCC complains about dubious bitwise OR operand: >> >> drivers/gpu/drm/drm_mipi_dbi.c:1024:49: warning: dubious: x | !y >> CC [M] drivers/gpu/drm/drm_m

Re: [PATCH v1] drm/mipi_dbi: Use simple right shift instead of double negation

2019-10-17 Thread Noralf Trønnes
and returns the same for commands 04H and 09h which are the ones affected by this change. Reviewed-by: Noralf Trønnes Tested-by: Noralf Trønnes This patch hasn't shown up in dri-devel patchwork, I hope it's just a hiccup and it'll show up later since I apply patches from patchwork. I don't see it

Re: [PATCH] spi: pxa2xx: Set controller->max_transfer_size in dma mode

2019-10-16 Thread Noralf Trønnes
ransfer size to inform spi clients that they need > to do something smarter. > > This was uncovered by the drm_mipi_dbi spi panel code, which does > large spi transfers, but stopped splitting them after: > > commit e143364b4c1774f68e923a5a0bb0fca28ac25888 > Author: Noralf Trønn

Re: [PATCH v2 05/11] drm/tinydrm: Remove tinydrm_spi_max_transfer_size()

2019-10-15 Thread Noralf Trønnes
Den 15.10.2019 17.59, skrev Andy Shevchenko: > On Tue, Oct 15, 2019 at 05:41:53PM +0200, Noralf Trønnes wrote: >> Den 15.10.2019 16.32, skrev Andy Shevchenko: >>> On Fri, Jul 19, 2019 at 05:59:10PM +0200, Noralf Trønnes wrote: >>>> spi-bcm2835 can handle >64k

Re: [PATCH v2 05/11] drm/tinydrm: Remove tinydrm_spi_max_transfer_size()

2019-10-15 Thread Noralf Trønnes
Den 15.10.2019 16.32, skrev Andy Shevchenko: > On Fri, Jul 19, 2019 at 05:59:10PM +0200, Noralf Trønnes wrote: >> spi-bcm2835 can handle >64kB buffers now so there is no need to check >> ->max_dma_len. The tinydrm_spi_max_transfer_size() max_len argument is >>

Re: [PATCH] drm/tiny: Kconfig: Remove always-y THERMAL dep. from TINYDRM_REPAPER

2019-10-10 Thread Noralf Trønnes
Den 01.10.2019 12.58, skrev Noralf Trønnes: > > > Den 27.09.2019 19.42, skrev Ulf Magnusson: >> Commit 554b3529fe01 ("thermal/drivers/core: Remove the module Kconfig's >> option") changed the type of THERMAL from tristate to bool, so >> THERMAL || !THERMAL

Re: [1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM

2019-10-10 Thread Noralf Trønnes
Den 09.10.2019 15.31, skrev Maxime Ripard: > On Wed, Oct 09, 2019 at 02:48:20PM +0200, Noralf Trønnes wrote: >> Den 09.10.2019 12.45, skrev Daniel Vetter: >>> On Tue, Oct 01, 2019 at 04:07:38PM +0200, Noralf Trønnes wrote: >>>> Hi drm-misc maintainers, >>

Re: [1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM

2019-10-09 Thread Noralf Trønnes
Den 09.10.2019 12.45, skrev Daniel Vetter: > On Tue, Oct 01, 2019 at 04:07:38PM +0200, Noralf Trønnes wrote: >> Hi drm-misc maintainers, >> >> I have just applied a patch to drm-misc-next that as it turns out should >> have been applied to -fixes for this -rc cycle.

Re: [1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM

2019-10-01 Thread Noralf Trønnes
15.45, skrev Jason Gunthorpe: > On Tue, Oct 01, 2019 at 03:28:46PM +0200, Noralf Trønnes wrote: >> >> >> Den 01.10.2019 14.36, skrev Jason Gunthorpe: >>> On Thu, Jul 25, 2019 at 12:51:30PM +0200, Noralf Trønnes wrote: >>>> This makes the tiny drivers v

Re: [1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM

2019-10-01 Thread Noralf Trønnes
Den 01.10.2019 14.36, skrev Jason Gunthorpe: > On Thu, Jul 25, 2019 at 12:51:30PM +0200, Noralf Trønnes wrote: >> This makes the tiny drivers visible by default without having to enable a >> knob. >> >> Signed-off-by: Noralf Trønnes >> Reviewed-by: Hans de Goe

Re: [PATCH] drm/tiny: Kconfig: Remove always-y THERMAL dep. from TINYDRM_REPAPER

2019-10-01 Thread Noralf Trønnes
Den 27.09.2019 19.42, skrev Ulf Magnusson: > Commit 554b3529fe01 ("thermal/drivers/core: Remove the module Kconfig's > option") changed the type of THERMAL from tristate to bool, so > THERMAL || !THERMAL is now always y. Remove the redundant dependency. > > Discovered through Kconfiglib

Re: [PATCH 1/2] drm/fb-helper: Synchronize dirty worker with vblank

2019-09-17 Thread Noralf Trønnes
Den 17.09.2019 14.55, skrev Daniel Vetter: > On Tue, Sep 10, 2019 at 04:59:57PM +0200, Noralf Trønnes wrote: >> >> >> Den 10.09.2019 15.51, skrev Thomas Zimmermann: >>> Hi >>> >>> Am 10.09.19 um 15:34 schrieb Noralf Trønnes: >>>> >&

Re: Recent tinydrm -> tiny drm drivers rename causes kernel-doc problems

2019-09-15 Thread Noralf Trønnes
Hi Hans, Den 15.09.2019 16.32, skrev Hans de Goede: > Hi Noralf, > > While doing a "make htmldocs" I just noticed the following errors: > > Error: Cannot open file ./drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c > Error: Cannot open file ./drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c >

Re: [PATCH 1/2] drm/fb-helper: Synchronize dirty worker with vblank

2019-09-10 Thread Noralf Trønnes
Den 10.09.2019 15.51, skrev Thomas Zimmermann: > Hi > > Am 10.09.19 um 15:34 schrieb Noralf Trønnes: >> >> >> Den 10.09.2019 14.48, skrev Thomas Zimmermann: >>> Hi >>> >>> Am 10.09.19 um 13:52 schrieb Gerd Hoffmann: >>>>

Re: [PATCH 1/2] drm/fb-helper: Synchronize dirty worker with vblank

2019-09-10 Thread Noralf Trønnes
Den 10.09.2019 14.48, skrev Thomas Zimmermann: > Hi > > Am 10.09.19 um 13:52 schrieb Gerd Hoffmann: >> On Mon, Sep 09, 2019 at 04:06:32PM +0200, Thomas Zimmermann wrote: >>> Before updating the display from the console's shadow buffer, the dirty >>> worker now waits for vblank. This allows

Re: [PATCH] drm: Use EOPNOTSUPP, not ENOTSUPP

2019-09-04 Thread Noralf Trønnes
: Maxime Ripard > Cc: Sean Paul > Cc: Alex Deucher > Cc: Andres Rodriguez > Cc: Noralf Trønnes > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/drm_edid.c | 6 +++--- > drivers/gpu/drm/drm_mipi_dbi.c | 2 +- > 2 files changed, 4 insertions(+), 4 del

Re: [PATCH] drm/tinydrm: fix a loop in debugfs code

2019-08-26 Thread Noralf Trønnes
Den 21.08.2019 09.24, skrev Dan Carpenter: > This code will likely crash if we try to do a zero byte write. The code > looks like this: > > /* strip trailing whitespace */ > for (i = count - 1; i > 0; i--) > if (isspace(buf[i])) > ... > >

Re: [PATCH 1/4] drm/mipi-dbi: Support command mode panel drivers

2019-08-13 Thread Noralf Trønnes
Den 12.08.2019 20.49, skrev Sam Ravnborg: > Hi Noralf. > >>> - drm_panel has proper support for modes. >>> This is today duplicated in mipi_dbi. >>> Could we make it so that when a panel is used then the panel >>> has the mode info - as we then use the panel more in the way we do >>> in

Re: [PATCH 4/4] drm/panel/ili9341: Support DPI panels

2019-08-12 Thread Noralf Trønnes
Den 11.08.2019 19.02, skrev Sam Ravnborg: > Hi Noralf. > > On Thu, Aug 01, 2019 at 03:52:49PM +0200, Noralf Trønnes wrote: >> Add support for panels that use the DPI interface. >> ILI9341 has onboard RAM so the assumption made here is that all such >> panels su

Re: [PATCH 4/4] drm/panel/ili9341: Support DPI panels

2019-08-12 Thread Noralf Trønnes
Den 11.08.2019 18.41, skrev Sam Ravnborg: > Hi Noralf. > > On Thu, Aug 01, 2019 at 03:52:49PM +0200, Noralf Trønnes wrote: >> Add support for panels that use the DPI interface. >> ILI9341 has onboard RAM so the assumption made here is that all such >> panels su

Re: [PATCH 2/4] drm/tiny/ili9341: Move driver to drm/panel

2019-08-12 Thread Noralf Trønnes
Den 11.08.2019 17.24, skrev Sam Ravnborg: > Hi Noralf. > > Most feedback on this driver was covered in comment to 1/4. > Only a few things caught my eye. > > On Thu, Aug 01, 2019 at 03:52:47PM +0200, Noralf Trønnes wrote: >> Move the driver to drm/panel and take ad

Re: [PATCH 1/4] drm/mipi-dbi: Support command mode panel drivers

2019-08-12 Thread Noralf Trønnes
> I can fix that when I respin if those patches have landed by then. > Some more specific comments in the following. > > Sam > > On Thu, Aug 01, 2019 at 03:52:46PM +0200, Noralf Trønnes wrote: >> This adds a function that registers a DRM driver for u

Re: [PATCH v2 4/9] drm/panel: Add driver for the LG Philips LB035Q02 panel

2019-08-11 Thread Noralf Trønnes
Den 11.08.2019 18.49, skrev Sam Ravnborg: > Hi Noralf. > >>> +static int lb035q02_write(struct lb035q02_device *lcd, u16 reg, u16 val) >>> +{ >>> + struct spi_message msg; >>> + struct spi_transfer index_xfer = { >>> + .len= 3, >>> + .cs_change = 1, >>>

Re: [PATCH v2 4/9] drm/panel: Add driver for the LG Philips LB035Q02 panel

2019-08-11 Thread Noralf Trønnes
Hi Laurent, Den 11.08.2019 15.35, skrev Laurent Pinchart: > Hi Noralf, > > On Sun, Aug 11, 2019 at 03:19:13PM +0200, Noralf Trønnes wrote: >> Sam, >> >> Den 11.08.2019 01.10, skrev Laurent Pinchart: >>> This panel is used on the Gumstix Overo Palo35. >

Re: [PATCH v2 4/9] drm/panel: Add driver for the LG Philips LB035Q02 panel

2019-08-11 Thread Noralf Trønnes
Sam, Den 11.08.2019 01.10, skrev Laurent Pinchart: > This panel is used on the Gumstix Overo Palo35. > > The code is based on the omapdrm-specific panel-lgphilips-lb035q02 > driver. > > Signed-off-by: Laurent Pinchart > Reviewed-by: Sam Ravnborg > --- > diff --git

Re: [PATCH 6/6] drm: tiny: gdepaper: add driver for 2/3 color epaper displays

2019-08-06 Thread Noralf Trønnes
Hi Jan, A couple of drive by comments: Den 30.07.2019 15.48, skrev Jan Sebastian Götte: > These ePaper displays are made in b/w, b/w/red and b/w/yellow variations > by Good Display (www.e-paper-display.com) and sold on breakout boards by > waveshare (waveshare.com). > > This driver was tested

Re: [PATCH 2/4] drm/tiny/ili9341: Move driver to drm/panel

2019-08-02 Thread Noralf Trønnes
Den 01.08.2019 21.43, skrev David Lechner: > On 8/1/19 8:52 AM, Noralf Trønnes wrote: >> Move the driver to drm/panel and take advantage of the new panel support >> in drm_mipi_dbi. Change the file name to match the naming standard in >> drm/panel. The DRM driver name is

Re: [4/4] drm/panel/ili9341: Support DPI panels

2019-08-02 Thread Noralf Trønnes
Den 01.08.2019 21.10, skrev David Lechner: > On 8/1/19 8:52 AM, Noralf Trønnes wrote: >> Add support for panels that use the DPI interface. >> ILI9341 has onboard RAM so the assumption made here is that all such >> panels support pixel upload over DBI. >> >> T

<    1   2   3   4   5   6   7   8   9   10   >