[PATCH v5 18/24] amdkfd: Add device queue manager module

2014-11-08 Thread Oded Gabbay
to match latest KV firmware Add support for AQL queues creation to enable working with open-source HSA runtime Remove unused unmap_queue function Various fixes (Style, typos) Signed-off-by: Ben Goz Signed-off-by: Jay Cornwall Signed-off-by: Oded Gabbay --- drivers/gpu/drm/amd/amdkfd/Makefile

[PATCH v5 17/24] amdkfd: Add process queue manager module

2014-11-08 Thread Oded Gabbay
ecause of the queue per process limitation v5: Move amdkfd from drm/radeon/ to drm/amd/ Various fixes Signed-off-by: Ben Goz Signed-off-by: Oded Gabbay --- drivers/gpu/drm/amd/amdkfd/Makefile| 3 +- drivers/gpu/drm/amd/amdkfd/kfd_priv.h | 26 ++ drivers/gpu/drm/amd/

[PATCH v5 16/24] amdkfd: Add packet manager module

2014-11-08 Thread Oded Gabbay
iption over the number of queues. Various fixes (typos, style) Signed-off-by: Ben Goz Signed-off-by: Oded Gabbay --- drivers/gpu/drm/amd/amdkfd/Makefile | 2 +- drivers/gpu/drm/amd/amdkfd/kfd_packet_manager.c | 565 drivers/gpu/drm/amd/amdkfd/kfd_

[PATCH v5 15/24] amdkfd: Add module parameter of scheduling policy

2014-11-08 Thread Oded Gabbay
value and added documentation v5: Set default sched_policy to HWS as it is now supported by firmware Signed-off-by: Ben Goz Signed-off-by: Oded Gabbay --- drivers/gpu/drm/amd/amdkfd/kfd_module.c | 18 +++--- drivers/gpu/drm/amd/amdkfd/kfd_priv.h | 30 ++ 2

[PATCH v5 14/24] amdkfd: Add kernel queue module

2014-11-08 Thread Oded Gabbay
e size Various fixes Signed-off-by: Ben Goz Signed-off-by: Oded Gabbay --- drivers/gpu/drm/amd/amdkfd/Makefile| 3 +- .../gpu/drm/amd/amdkfd/kfd_device_queue_manager.h | 101 + drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue.c | 347 ++ drivers/gpu/drm/amd/

[PATCH v5 13/24] amdkfd: Add mqd_manager module

2014-11-08 Thread Oded Gabbay
ed-off-by: Ben Goz Signed-off-by: Oded Gabbay --- drivers/gpu/drm/amd/amdkfd/Makefile | 2 +- drivers/gpu/drm/amd/amdkfd/cik_regs.h| 221 + drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager.c | 346 +++ drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager.h

[PATCH v5 12/24] amdkfd: Add queue module

2014-11-08 Thread Oded Gabbay
ed-off-by: Oded Gabbay --- drivers/gpu/drm/amd/amdkfd/Makefile| 2 +- drivers/gpu/drm/amd/amdkfd/kfd_priv.h | 124 - drivers/gpu/drm/amd/amdkfd/kfd_queue.c | 85 ++ 3 files changed, 209 insertions(+), 2 deletions(-) create mode 100644 d

[PATCH v5 11/24] amdkfd: Add binding/unbinding calls to amd_iommu driver

2014-11-08 Thread Oded Gabbay
of the patchset. Signed-off-by: Oded Gabbay --- drivers/gpu/drm/amd/amdkfd/kfd_device.c | 90 +++- drivers/gpu/drm/amd/amdkfd/kfd_priv.h| 1 + drivers/gpu/drm/amd/amdkfd/kfd_process.c | 12 + 3 files changed, 102 insertions(+), 1 deletion(-) diff --git

[PATCH v5 10/24] amdkfd: Add basic modules to amdkfd

2014-11-08 Thread Oded Gabbay
structure Rename kfd_mem_obj structure's members Use delayed function for process tear-down Signed-off-by: Oded Gabbay --- drivers/gpu/drm/amd/amdkfd/Makefile | 4 +- drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 31 ++- drivers/gpu/drm/amd/amdkfd/kfd_device.c | 46 +++- drivers/gpu

[PATCH v5 09/24] amdkfd: Add topology module to amdkfd

2014-11-08 Thread Oded Gabbay
accessing it in the node_show function in kfd_topology.c This situation may occur when amdkfd is loaded and there is a GPU with a CRAT table, but that GPU isn't supported by amdkfd Signed-off-by: Evgeny Pinchuk Signed-off-by: Oded Gabbay --- drivers/gpu/drm/amd/amdkfd/Makefile |2 +- dr

[PATCH v5 08/24] amdkfd: Add amdkfd skeleton driver

2014-11-08 Thread Oded Gabbay
/amd and move amdkfd from drm/radeon/ to drm/amd/ Remove scheduler_class from kfd_priv.h as it was never used Add skeleton implementation of the Get Version IOCTL Signed-off-by: Oded Gabbay --- drivers/gpu/drm/Kconfig | 2 + drivers/gpu/drm/Makefile | 1

[PATCH v5 07/24] amdkfd: Add IOCTL set definitions of amdkfd

2014-11-08 Thread Oded Gabbay
to be the same size on 32/64 bit Signed-off-by: Oded Gabbay --- include/uapi/linux/kfd_ioctl.h | 154 + 1 file changed, 154 insertions(+) create mode 100644 include/uapi/linux/kfd_ioctl.h diff --git a/include/uapi/linux/kfd_ioctl.h b/include/uapi/linux

[PATCH v5 06/24] Update MAINTAINERS and CREDITS files with amdkfd info

2014-11-08 Thread Oded Gabbay
Signed-off-by: Oded Gabbay --- CREDITS | 7 +++ MAINTAINERS | 10 ++ 2 files changed, 17 insertions(+) diff --git a/CREDITS b/CREDITS index bb62788..c56d8aa 100644 --- a/CREDITS +++ b/CREDITS @@ -1197,6 +1197,13 @@ S: R. Tocantins, 89 - Cristo Rei S: 80050-430 - Curitiba

[PATCH v5 05/24] drm/radeon: Add radeon <--> amdkfd interface

2014-11-08 Thread Oded Gabbay
with open-source HSA runtime. Move generic kfd-->kgd interface and other generic kgd definitions to a generic header file that will be used by AMD's radeon and amdgpu drivers Signed-off-by: Oded Gabbay --- drivers/gpu/drm/amd/include/kgd_kfd_interface.h | 185 drivers/gpu/drm/radeon/Makef

[PATCH v5 04/24] drm/radeon: adding synchronization for GRBM GFX

2014-11-08 Thread Oded Gabbay
Implementing a lock for selecting and accessing shader engines and arrays. This lock will make sure that radeon and amdkfd are not colliding when accessing shader engines and arrays with GRBM_GFX_INDEX register. Reviewed-by: Alex Deucher Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon

[PATCH v5 03/24] drm/radeon: Report doorbell configuration to amdkfd

2014-11-08 Thread Oded Gabbay
radeon and amdkfd share the doorbell aperture. radeon sets it up, takes the doorbells required for its own rings and reports the setup to amdkfd. radeon reserved doorbells are at the start of the doorbell aperture. Reviewed-by: Alex Deucher Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon

[PATCH v5 02/24] drm/radeon/cik: Don't touch int of pipes 1-7

2014-11-08 Thread Oded Gabbay
amdkfd should set interrupts for pipes 1-7. Reviewed-by: Alex Deucher Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/cik.c | 71 +--- 1 file changed, 1 insertion(+), 70 deletions(-) diff --git a/drivers/gpu/drm/radeon/cik.c b/drivers/gpu/drm

[PATCH v5 01/24] drm/radeon: reduce number of free VMIDs and pipes in KV

2014-11-08 Thread Oded Gabbay
for static vmid allocation in radeon Reviewed-by: Alex Deucher Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/cik.c | 48 +-- drivers/gpu/drm/radeon/cikd.h | 2 ++ 2 files changed, 26 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/radeon

[PATCH v5 00/24] AMDKFD Kernel Driver

2014-11-08 Thread Oded Gabbay
ueue manager module Evgeny Pinchuk (2): amdkfd: Add topology module to amdkfd amdkfd: Implement the Get Clock Counters IOCTL Oded Gabbay (12): drm/radeon: reduce number of free VMIDs and pipes in KV drm/radeon/cik: Don't touch int of pipes 1-7 drm/radeon: Report doorbell configura

-next plans/status

2014-11-03 Thread Oded Gabbay
Hi Dave, I would like to add one more thing to your radar - amdkfd ;) We are going to release AMD's HSA Runtime library as Open Source in the next few days, and coupled with the modification that Thomas Stellard did for the r600 LLVM back-end, we are effectively releasing a _complete_

AMD GPU new API for new module

2014-10-12 Thread Oded Gabbay
On 11/10/14 21:30, Daniel Vetter wrote: > On Thu, Oct 9, 2014 at 8:33 PM, Oded Gabbay wrote: >> Thanks for the input. >> I do _not_ intend to fork IOCTLs for new H/W generations, if possible. >> i.e, our driver now supports 2 h/w generations with the exact same set >>

AMD GPU new API for new module

2014-10-09 Thread Oded Gabbay
55, Daniel Vetter wrote: > On Thu, Oct 9, 2014 at 12:15 PM, Oded Gabbay wrote: >> Well, I don't expect to reach 100 ioctls anytime soon, but I can tell >> you that for the features we have in the pipeline, I can see the IOCTL >> number go up to 20-30, just for the current H/W

AMD GPU new API for new module

2014-10-09 Thread Oded Gabbay
On 09/10/14 11:02, Jerome Glisse wrote: > On Thu, Oct 09, 2014 at 09:54:14AM +0300, Oded Gabbay wrote: >> Hi Jerome, >> >> Do you think your proposed change should also be applied to amdkfd's >> IOCTLs ? > > It might make sense it really depends on the lifespa

AMD GPU new API for new module

2014-10-09 Thread Oded Gabbay
Hi Jerome, Do you think your proposed change should also be applied to amdkfd's IOCTLs ? Oded On 08/10/14 19:00, Jerome Glisse wrote: > Hi, > > So if i do not start the discussion now it might be already too late. Given > plan to converge open source driver and closed source driver to

[PATCH v3 00/23] AMDKFD Kernel Driver

2014-09-26 Thread Oded Gabbay
On 05/08/14 21:35, Gabbay, Oded wrote: > > > On 05/08/14 20:11, David Herrmann wrote: >> Hi >> >> On Tue, Aug 5, 2014 at 5:30 PM, Oded Gabbay wrote: >>> Hi, >>> Here is the v3 patch set of amdkfd. >>> >>> This version contains

[PATCH v4 05/23] drm/radeon: Add radeon <--> amdkfd interface

2014-09-25 Thread Oded Gabbay
On 24/09/14 23:45, Oded Gabbay wrote: > This patch adds the interface between the radeon driver and the amdkfd driver. > The interface implementation is contained in radeon_kfd.c and radeon_kfd.h. > > The interface itself is represented by a pointer to struct > kfd_dev. The poi

[PATCH v4 23/23] amdkfd: Implement the Get Process Aperture IOCTL

2014-09-25 Thread Oded Gabbay
From: Alexey Skidanov <alexey.skida...@amd.com> v3: Fixed debug messages Signed-off-by: Alexey Skidanov Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/amdkfd/kfd_chardev.c | 47 - drivers/gpu/drm/radeon/amdkfd/kfd_priv.h| 5 +++ 2 files chang

[PATCH v4 22/23] amdkfd: Implement the Get Clock Counters IOCTL

2014-09-25 Thread Oded Gabbay
From: Evgeny Pinchuk <evgeny.pinc...@amd.com> Signed-off-by: Evgeny Pinchuk Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/amdkfd/kfd_chardev.c | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/amdkfd/kfd_cha

[PATCH v4 21/23] amdkfd: Implement the Set Memory Policy IOCTL

2014-09-25 Thread Oded Gabbay
From: Andrew Lewycky <andrew.lewy...@amd.com> Signed-off-by: Andrew Lewycky Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/amdkfd/kfd_chardev.c | 51 - 1 file changed, 50 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/amdkfd/kfd_cha

[PATCH v4 20/23] amdkfd: Implement the create/destroy/update queue IOCTLs

2014-09-25 Thread Oded Gabbay
ioctls in the future. Also fixed the check of the ring size argument. Signed-off-by: Ben Goz Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/amdkfd/kfd_chardev.c| 191 - drivers/gpu/drm/radeon/amdkfd/kfd_priv.h | 8 + .../drm/radeon/

[PATCH v4 19/23] amdkfd: Add interrupt handling module

2014-09-25 Thread Oded Gabbay
ssible for us to lose interrupts because we have no back-pressure to the hardware. v3: Change device init Made sure spin lock is taken only if init is complete Moved bool field to the end of the structure Signed-off-by: Andrew Lewycky Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/

[PATCH v4 18/23] amdkfd: Add device queue manager module

2014-09-25 Thread Oded Gabbay
P_CONTROL, because the size is specified as (log2(size_dwords)-1). The previous calculation assumed the size was specified in bytes, which caused interference between EOP queues when multiple MEC pipelines were active. Signed-off-by: Ben Goz Signed-off-by: Jay Cornwall Signed-off-by: Oded Gabbay

[PATCH v4 17/23] amdkfd: Add process queue manager module

2014-09-25 Thread Oded Gabbay
ecause of the queue per process limitation Signed-off-by: Ben Goz Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/amdkfd/Makefile | 3 +- drivers/gpu/drm/radeon/amdkfd/kfd_priv.h | 17 + drivers/gpu/drm/radeon/amdkfd/kfd_process.c| 16 + .../drm/radeon/

[PATCH v4 16/23] amdkfd: Add packet manager module

2014-09-25 Thread Oded Gabbay
cation functions Added documentation Signed-off-by: Ben Goz Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/amdkfd/Makefile | 2 +- drivers/gpu/drm/radeon/amdkfd/kfd_packet_manager.c | 495 + drivers/gpu/drm/radeon/amdkfd/kfd_priv.h | 72 +++ 3

[PATCH v4 15/23] amdkfd: Add module parameter of scheduling policy

2014-09-25 Thread Oded Gabbay
value and added documentation Signed-off-by: Ben Goz Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/amdkfd/kfd_module.c | 12 drivers/gpu/drm/radeon/amdkfd/kfd_priv.h | 29 + 2 files changed, 41 insertions(+) diff --git a/drivers/gpu/drm/radeon/

[PATCH v4 14/23] amdkfd: Add kernel queue module

2014-09-25 Thread Oded Gabbay
he new gart allocation functions v4: Fixed a miscalculation in kernel queue wrapping Signed-off-by: Ben Goz Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/amdkfd/Makefile | 3 +- .../drm/radeon/amdkfd/kfd_device_queue_manager.h | 101 +++ drivers/gpu/drm/radeon/

[PATCH v4 13/23] amdkfd: Add mqd_manager module

2014-09-25 Thread Oded Gabbay
n them, and thus the dispatched workload context kept consistent without any interrupts. Signed-off-by: Ben Goz Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/amdkfd/Makefile | 2 +- drivers/gpu/drm/radeon/amdkfd/cik_regs.h| 221 + drivers/gpu/drm/radeon/

[PATCH v4 12/23] amdkfd: Add queue module

2014-09-25 Thread Oded Gabbay
From: Ben Goz <ben@amd.com> The queue module enables allocating and initializing queues uniformly. v3: Removed typedef and redundant memset call. Broke long pr_debug print to one liners and Added documentation. Signed-off-by: Ben Goz Signed-off-by: Oded Gabbay --- drivers/gpu/drm/

[PATCH v4 11/23] amdkfd: Add binding/unbinding calls to amd_iommu driver

2014-09-25 Thread Oded Gabbay
of the patchset. Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/amdkfd/kfd_device.c | 86 - drivers/gpu/drm/radeon/amdkfd/kfd_priv.h| 1 + drivers/gpu/drm/radeon/amdkfd/kfd_process.c | 12 3 files changed, 98 insertions(+), 1 deletion(-) diff --git

[PATCH v4 10/23] amdkfd: Add basic modules to amdkfd

2014-09-25 Thread Oded Gabbay
or LDS in 32 bit Changed code to support mmap of doorbell pages from userspace Added documentation for apertures v4: Replaced RCU by SRCU for kfd_process list management Signed-off-by: Andrew Lewycky Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/amdkfd/Makefile | 4 +- drivers/g

[PATCH v4 09/23] amdkfd: Add topology module to amdkfd

2014-09-25 Thread Oded Gabbay
erties |--- 2/ | |--- properties |--- 3/ | |--- properties Signed-off-by: Evgeny Pinchuk Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/amdkfd/Ma

[PATCH v4 08/23] amdkfd: Add amdkfd skeleton driver

2014-09-25 Thread Oded Gabbay
This patch adds the amdkfd skeleton driver. The driver does nothing except define a /dev/kfd device. It returns -ENODEV on all amdkfd IOCTLs. v3: Move bool field to the end of structure, removed the pmc ioctls and added a meaningful error message for ioctl error. Signed-off-by: Oded Gabbay

[PATCH v4 07/23] amdkfd: Add IOCTL set definitions of amdkfd

2014-09-25 Thread Oded Gabbay
of the amdkfd device - KFD_IOC_UPDATE_QUEUE: Updates configuration of an existing usermode queue v3: Remove pragma pack and pmc ioctls. Added parameter for doorbell offset and a comment on counters Signed-off-by: Oded Gabbay --- include/uapi/linux/kfd_ioctl.h | 123

[PATCH v4 06/23] Update MAINTAINERS and CREDITS files with amdkfd info

2014-09-25 Thread Oded Gabbay
Signed-off-by: Oded Gabbay --- CREDITS | 7 +++ MAINTAINERS | 10 ++ 2 files changed, 17 insertions(+) diff --git a/CREDITS b/CREDITS index bb62788..c56d8aa 100644 --- a/CREDITS +++ b/CREDITS @@ -1197,6 +1197,13 @@ S: R. Tocantins, 89 - Cristo Rei S: 80050-430 - Curitiba

[PATCH v4 05/23] drm/radeon: Add radeon <--> amdkfd interface

2014-09-25 Thread Oded Gabbay
linux macros Add documentation for the interface v4: Change ptr field type in kgd_mem from uint32_t* to void* to match to type that is returned by radeon_sa_bo_cpu_addr Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/Makefile | 1 + drivers/gpu/drm/radeon/cik.c| 9

[PATCH v4 04/23] drm/radeon: adding synchronization for GRBM GFX

2014-09-25 Thread Oded Gabbay
Implementing a lock for selecting and accessing shader engines and arrays. This lock will make sure that radeon and amdkfd are not colliding when accessing shader engines and arrays with GRBM_GFX_INDEX register. Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/cik.c | 26

[PATCH v4 03/23] drm/radeon: Report doorbell configuration to amdkfd

2014-09-25 Thread Oded Gabbay
radeon and amdkfd share the doorbell aperture. radeon sets it up, takes the doorbells required for its own rings and reports the setup to amdkfd. radeon reserved doorbells are at the start of the doorbell aperture. Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/radeon.h| 4

[PATCH v4 02/23] drm/radeon/cik: Don't touch int of pipes 1-7

2014-09-25 Thread Oded Gabbay
amdkfd should set interrupts for pipes 1-7. Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/cik.c | 71 +--- 1 file changed, 1 insertion(+), 70 deletions(-) diff --git a/drivers/gpu/drm/radeon/cik.c b/drivers/gpu/drm/radeon/cik.c index 1530e37

[PATCH v4 01/23] drm/radeon: reduce number of free VMIDs and pipes in KV

2014-09-25 Thread Oded Gabbay
for static vmid allocation in radeon Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/cik.c | 48 +-- drivers/gpu/drm/radeon/cikd.h | 2 ++ 2 files changed, 26 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/radeon/cik.c b/drivers/gpu/drm

[PATCH v4 00/23] AMDKFD Kernel Driver

2014-09-25 Thread Oded Gabbay
/update queue IOCTLs Evgeny Pinchuk (2): amdkfd: Add topology module to amdkfd amdkfd: Implement the Get Clock Counters IOCTL Oded Gabbay (9): drm/radeon: reduce number of free VMIDs and pipes in KV drm/radeon/cik: Don't touch int of pipes 1-7 drm/radeon: Report doorbell configuration

GEM memory DOS (WAS Re: [PATCH 3/3] drm/ttm: under memory pressure minimize the size of memory pool)

2014-08-13 Thread Oded Gabbay
On 13/08/14 16:01, Daniel Vetter wrote: > On Wed, Aug 13, 2014 at 02:35:52PM +0200, Thomas Hellstrom wrote: >> On 08/13/2014 12:42 PM, Daniel Vetter wrote: >>> On Wed, Aug 13, 2014 at 11:06:25AM +0200, Thomas Hellstrom wrote: On 08/13/2014 05:52 AM, J?r?me Glisse wrote: > From: J?r?me

[PATCH v3 00/23] AMDKFD Kernel Driver

2014-08-05 Thread Oded Gabbay
On 05/08/14 20:11, David Herrmann wrote: > Hi > > On Tue, Aug 5, 2014 at 5:30 PM, Oded Gabbay wrote: >> Hi, >> Here is the v3 patch set of amdkfd. >> >> This version contains changes and fixes to code, as agreed on during the >> review >>

[PATCH v3 23/23] amdkfd: Implement the Get Process Aperture IOCTL

2014-08-05 Thread Oded Gabbay
From: Alexey Skidanov <alexey.skida...@amd.com> v3: fix debug msg Signed-off-by: Alexey Skidanov Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/amdkfd/kfd_chardev.c | 47 - drivers/gpu/drm/radeon/amdkfd/kfd_priv.h| 5 +++ 2 files changed, 51 inse

[PATCH v3 22/23] amdkfd: Implement the Get Clock Counters IOCTL

2014-08-05 Thread Oded Gabbay
From: Evgeny Pinchuk <evgeny.pinc...@amd.com> Signed-off-by: Evgeny Pinchuk Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/amdkfd/kfd_chardev.c | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/amdkfd/kfd_cha

[PATCH v3 21/23] amdkfd: Implement the Set Memory Policy IOCTL

2014-08-05 Thread Oded Gabbay
From: Andrew Lewycky <andrew.lewy...@amd.com> Signed-off-by: Andrew Lewycky Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/amdkfd/kfd_chardev.c | 51 - 1 file changed, 50 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/amdkfd/kfd_cha

[PATCH v3 20/23] amdkfd: Implement the create/destroy/update queue IOCTLs

2014-08-05 Thread Oded Gabbay
From: Ben Goz <ben@amd.com> v3: remove use of internal typedefs v3: fix debug prints v3: add checks for parameters v3: use doorbell address from user Signed-off-by: Ben Goz Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/amdkfd/kfd_chardev.c

[PATCH v3 19/23] amdkfd: Add interrupt handling module

2014-08-05 Thread Oded Gabbay
ssible for us to lose interrupts because we have no back-pressure to the hardware. v3: change device init v3: make sure spin lock is taken only if init is complete v3: move bool to end of struct Signed-off-by: Andrew Lewycky Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/amdkfd/Ma

[PATCH v3 18/23] amdkfd: Add device queue manager module

2014-08-05 Thread Oded Gabbay
t also supports suspend/resume operation. v3: change device_init v3: use new gart allocation functions v3: Add documentation Signed-off-by: Ben Goz Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/amdkfd/Makefile | 2 +- drivers/gpu/drm/radeon/amdkfd/kfd_device.c

[PATCH v3 17/23] amdkfd: Add process queue manager module

2014-08-05 Thread Oded Gabbay
limit queues per process instead of define v3: use doorbell address from user Signed-off-by: Ben Goz Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/amdkfd/Makefile | 3 +- drivers/gpu/drm/radeon/amdkfd/kfd_priv.h | 17 + drivers/gpu/drm/radeon/amdkfd/kfd_pro

[PATCH v3 16/23] amdkfd: Add packet manager module

2014-08-05 Thread Oded Gabbay
cation functions v3: add documentation Signed-off-by: Ben Goz Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/amdkfd/Makefile | 2 +- drivers/gpu/drm/radeon/amdkfd/kfd_packet_manager.c | 495 + drivers/gpu/drm/radeon/amdkfd/kfd_priv.h | 72 +++ 3

[PATCH v3 15/23] amdkfd: Add module parameter of scheduling policy

2014-08-05 Thread Oded Gabbay
ed-off-by: Ben Goz Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/amdkfd/kfd_module.c | 12 drivers/gpu/drm/radeon/amdkfd/kfd_priv.h | 29 + 2 files changed, 41 insertions(+) diff --git a/drivers/gpu/drm/radeon/amdkfd/kfd_module.c b/drivers/gpu/drm/

[PATCH v3 14/23] amdkfd: Add kernel queue module

2014-08-05 Thread Oded Gabbay
cation functions Signed-off-by: Ben Goz Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/amdkfd/Makefile | 3 +- .../drm/radeon/amdkfd/kfd_device_queue_manager.h | 101 +++ drivers/gpu/drm/radeon/amdkfd/kfd_kernel_queue.c | 330 ++ drivers/gpu/drm/radeon/

[PATCH v3 13/23] amdkfd: Add mqd_manager module

2014-08-05 Thread Oded Gabbay
per_32 calls to use linux macros v3: use new gart allocation functions v3: Add documentation Signed-off-by: Ben Goz Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/amdkfd/Makefile | 2 +- drivers/gpu/drm/radeon/amdkfd/cik_regs.h| 220 + drivers/gpu/drm/

[PATCH v3 12/23] amdkfd: Add queue module

2014-08-05 Thread Oded Gabbay
From: Ben Goz <ben@amd.com> The queue module enables allocating and initializing queues uniformly. v3: remove typedef v3: break pr_debug to one line v3: remove memset v3: add documentation Signed-off-by: Ben Goz Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/amdkfd/Ma

[PATCH v3 11/23] amdkfd: Add binding/unbinding calls to amd_iommu driver

2014-08-05 Thread Oded Gabbay
of the patchset. Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/amdkfd/kfd_device.c | 86 - drivers/gpu/drm/radeon/amdkfd/kfd_priv.h| 1 + drivers/gpu/drm/radeon/amdkfd/kfd_process.c | 12 3 files changed, 98 insertions(+), 1 deletion(-) diff --git

[PATCH v3 10/23] amdkfd: Add basic modules to amdkfd

2014-08-05 Thread Oded Gabbay
Change code to support mmap of doorbell pages from userspace v3: Add documentation for apertures Signed-off-by: Andrew Lewycky Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/amdkfd/Makefile | 4 +- drivers/gpu/drm/radeon/amdkfd/kfd_aperture.c | 350 +++ d

[PATCH v3 09/23] amdkfd: Add topology module to amdkfd

2014-08-05 Thread Oded Gabbay
(nodes which are compliant with the HSA spec). To recap, amdkfd exposes a different kind of topology than the one exposed by /sys/devices/system/cpu/cpu even though it may contain similar information. Signed-off-by: Evgeny Pinchuk Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/amdkfd/Ma

[PATCH v3 08/23] amdkfd: Add amdkfd skeleton driver

2014-08-05 Thread Oded Gabbay
This patch adds the amdkfd skeleton driver. The driver does nothing except define a /dev/kfd device. It returns -ENODEV on all amdkfd IOCTLs. (v3) move bool to end of struct (v3) remove pmc ioctls (v3) add meaningful error message for ioctl error Signed-off-by: Oded Gabbay --- drivers/gpu

[PATCH v3 07/23] amdkfd: Add IOCTL set definitions of amdkfd

2014-08-05 Thread Oded Gabbay
of the amdkfd device - KFD_IOC_UPDATE_QUEUE: Updates configuration of an existing usermode queue (v3) remove pragma pack (v3) remove pmc ioctls (v3) add parameter for doorbell offset (v3) add comment on counters Signed-off-by: Oded Gabbay --- include/uapi/linux/kfd_ioctl.h | 123

[PATCH v3 06/23] Update MAINTAINERS and CREDITS files with amdkfd info

2014-08-05 Thread Oded Gabbay
Signed-off-by: Oded Gabbay --- CREDITS | 7 +++ MAINTAINERS | 10 ++ 2 files changed, 17 insertions(+) diff --git a/CREDITS b/CREDITS index 28ee151..e9628d5 100644 --- a/CREDITS +++ b/CREDITS @@ -1197,6 +1197,13 @@ S: R. Tocantins, 89 - Cristo Rei S: 80050-430 - Curitiba

[PATCH v3 05/23] drm/radeon: Add radeon <--> amdkfd interface

2014-08-05 Thread Oded Gabbay
to use linux macros (v3) Add documentation for the interface Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/Makefile | 1 + drivers/gpu/drm/radeon/cik.c| 9 + drivers/gpu/drm/radeon/cik_reg.h| 65 + drivers/gpu/drm/radeon/cikd.h | 51 +++- drivers/gpu/drm

[PATCH v3 04/23] drm/radeon: adding synchronization for GRBM GFX

2014-08-05 Thread Oded Gabbay
Implementing a lock for selecting and accessing shader engines and arrays. This lock will make sure that radeon and amdkfd are not colliding when accessing shader engines and arrays with GRBM_GFX_INDEX register. Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/cik.c | 26

[PATCH v3 03/23] drm/radeon: Report doorbell configuration to amdkfd

2014-08-05 Thread Oded Gabbay
radeon and amdkfd share the doorbell aperture. radeon sets it up, takes the doorbells required for its own rings and reports the setup to amdkfd. radeon reserved doorbells are at the start of the doorbell aperture. Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/radeon.h| 4

[PATCH v3 02/23] drm/radeon/cik: Don't touch int of pipes 1-7

2014-08-05 Thread Oded Gabbay
amdkfd should set interrupts for pipes 1-7. Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/cik.c | 71 +--- 1 file changed, 1 insertion(+), 70 deletions(-) diff --git a/drivers/gpu/drm/radeon/cik.c b/drivers/gpu/drm/radeon/cik.c index 9571be8

[PATCH v3 01/23] drm/radeon: reduce number of free VMIDs and pipes in KV

2014-08-05 Thread Oded Gabbay
for static vmid allocation in radeon Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/cik.c | 48 +-- drivers/gpu/drm/radeon/cikd.h | 2 ++ 2 files changed, 26 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/radeon/cik.c b/drivers/gpu/drm

[PATCH v3 00/23] AMDKFD Kernel Driver

2014-08-05 Thread Oded Gabbay
Add packet manager module amdkfd: Add process queue manager module amdkfd: Add device queue manager module amdkfd: Implement the create/destroy/update queue IOCTLs Evgeny Pinchuk (2): amdkfd: Add topology module to amdkfd amdkfd: Implement the Get Clock Counters IOCTL Oded Gabbay (9):

[PATCH v2 06/25] drm/radeon: Add radeon <--> amdkfd interface

2014-08-03 Thread Oded Gabbay
On 20/07/14 20:35, Jerome Glisse wrote: > On Thu, Jul 17, 2014 at 04:29:13PM +0300, Oded Gabbay wrote: >> This patch adds the interface between the radeon driver and the amdkfd >> driver. >> The interface implementation is contained in radeon_kfd.c and radeon_kfd.h. >&

[PATCH v2 08/25] amdkfd: Add IOCTL set definitions of amdkfd

2014-08-03 Thread Oded Gabbay
On 20/07/14 19:54, Jerome Glisse wrote: > On Thu, Jul 17, 2014 at 04:29:15PM +0300, Oded Gabbay wrote: >> - KFD_IOC_GET_VERSION: >> Retrieves the interface version of amdkfd >> >> - KFD_IOC_CREATE_QUEUE: >> Creates a usermode queue t

[PATCH v2 09/25] amdkfd: Add amdkfd skeleton driver

2014-08-02 Thread Oded Gabbay
On 20/07/14 20:09, Jerome Glisse wrote: > On Thu, Jul 17, 2014 at 04:29:16PM +0300, Oded Gabbay wrote: >> This patch adds the amdkfd skeleton driver. The driver does nothing except >> define a /dev/kfd device. >> >> It returns -ENODEV on all amdkfd IOCTLs. >&

[PATCH v2 11/25] amdkfd: Add basic modules to amdkfd

2014-08-02 Thread Oded Gabbay
On 21/07/14 02:02, Jerome Glisse wrote: > On Thu, Jul 17, 2014 at 04:29:18PM +0300, Oded Gabbay wrote: >> From: Andrew Lewycky >> >> This patch adds the process module and 4 helper modules: >> >> - kfd_process, which handles process which open /dev/kfd >>

[PATCH v2 14/25] amdkfd: Add mqd_manager module

2014-08-02 Thread Oded Gabbay
On 21/07/14 05:33, Jerome Glisse wrote: > On Thu, Jul 17, 2014 at 04:29:21PM +0300, Oded Gabbay wrote: >> From: Ben Goz >> >> The mqd_manager module handles MQD data structures. MQD stands for Memory >> Queue Descriptor, which is used by the H/W to keep the usermod

[PATCH v2 10/25] amdkfd: Add topology module to amdkfd

2014-07-30 Thread Oded Gabbay
On 27/07/14 14:15, Oded Gabbay wrote: > On 21/07/14 01:37, Jerome Glisse wrote: >> On Thu, Jul 17, 2014 at 04:29:17PM +0300, Oded Gabbay wrote: >>> From: Evgeny Pinchuk >>> >>> This patch adds the topology module to the driver. The topology is exposed &g

[PATCH v2 10/25] amdkfd: Add topology module to amdkfd

2014-07-27 Thread Oded Gabbay
On 21/07/14 01:37, Jerome Glisse wrote: > On Thu, Jul 17, 2014 at 04:29:17PM +0300, Oded Gabbay wrote: >> From: Evgeny Pinchuk >> >> This patch adds the topology module to the driver. The topology is exposed to >> userspace through the sysfs. >> >> The c

[PATCH v2 10/25] amdkfd: Add topology module to amdkfd

2014-07-27 Thread Oded Gabbay
On 21/07/14 01:37, Jerome Glisse wrote: > On Thu, Jul 17, 2014 at 04:29:17PM +0300, Oded Gabbay wrote: >> From: Evgeny Pinchuk >> >> This patch adds the topology module to the driver. The topology is exposed to >> userspace through the sysfs. >> >> The c

[PATCH v2 12/25] amdkfd: Add binding/unbinding calls to amd_iommu driver

2014-07-27 Thread Oded Gabbay
On 21/07/14 02:04, Jerome Glisse wrote: > On Thu, Jul 17, 2014 at 04:29:19PM +0300, Oded Gabbay wrote: >> This patch adds the functions to bind and unbind pasid from a device through >> the amd_iommu driver. >> >> The unbind function is called when the mm_struct

[PATCH v2 13/25] amdkfd: Add queue module

2014-07-27 Thread Oded Gabbay
On 21/07/14 02:06, Jerome Glisse wrote: > On Thu, Jul 17, 2014 at 04:29:20PM +0300, Oded Gabbay wrote: >> From: Ben Goz >> >> The queue module enables allocating and initializing queues uniformly. >> >> Signed-off-by: Ben Goz >> Signed-off-by: Oded Gab

[PATCH v2 15/25] amdkfd: Add kernel queue module

2014-07-27 Thread Oded Gabbay
On 21/07/14 05:42, Jerome Glisse wrote: > On Thu, Jul 17, 2014 at 04:29:22PM +0300, Oded Gabbay wrote: >> From: Ben Goz >> >> The kernel queue module enables the amdkfd to establish kernel queues, not >> exposed to user space. >> >> The kernel queue

[PATCH v2 16/25] amdkfd: Add module parameter of scheduling policy

2014-07-27 Thread Oded Gabbay
On 21/07/14 05:45, Jerome Glisse wrote: > On Thu, Jul 17, 2014 at 04:29:23PM +0300, Oded Gabbay wrote: >> From: Ben Goz >> >> This patch adds a new parameter to the amdkfd driver. This parameter enables >> the user to select the scheduling policy of the CP. The choices

[PATCH v2 21/25] amdkfd: Implement the create/destroy/update queue IOCTLs

2014-07-27 Thread Oded Gabbay
On 21/07/14 02:09, Jerome Glisse wrote: > On Thu, Jul 17, 2014 at 04:29:28PM +0300, Oded Gabbay wrote: >> From: Ben Goz >> >> Signed-off-by: Ben Goz >> Signed-off-by: Oded Gabbay >> --- >> drivers/gpu/drm/radeon/amdkfd/kfd_chardev.c | 133 >>

[PATCH v2 00/25] AMDKFD kernel driver

2014-07-24 Thread Oded Gabbay
On 24/07/14 21:47, Jerome Glisse wrote: > On Thu, Jul 24, 2014 at 01:35:53PM -0400, Alex Deucher wrote: >> On Thu, Jul 24, 2014 at 11:44 AM, Jerome Glisse >> wrote: >>> On Thu, Jul 24, 2014 at 01:01:41AM +0300, Oded Gabbay wrote: >>>> On

[PATCH v2 00/25] AMDKFD kernel driver

2014-07-24 Thread Oded Gabbay
Vetter wrote: >>>>> On Mon, Jul 21, 2014 at 03:39:09PM +0200, Christian K?nig >>>>> wrote: >>>>>> Am 21.07.2014 14:36, schrieb Oded Gabbay: >>>>>>> On 20/07/14 20:46, Jerome Glisse wrote: >> >> [snip!!] >

[PATCH v2 00/25] AMDKFD kernel driver

2014-07-23 Thread Oded Gabbay
On 23/07/14 10:05, Daniel Vetter wrote: > On Wed, Jul 23, 2014 at 8:50 AM, Oded Gabbay wrote: >> On 22/07/14 14:15, Daniel Vetter wrote: >>> >>> On Tue, Jul 22, 2014 at 12:52:43PM +0300, Oded Gabbay wrote: >>>> >>>> On 22/07/14 12:21, Daniel Vett

[PATCH v2 00/25] AMDKFD kernel driver

2014-07-23 Thread Oded Gabbay
On 22/07/14 14:15, Daniel Vetter wrote: > On Tue, Jul 22, 2014 at 12:52:43PM +0300, Oded Gabbay wrote: >> On 22/07/14 12:21, Daniel Vetter wrote: >>> On Tue, Jul 22, 2014 at 10:19 AM, Oded Gabbay >>> wrote: >>>>> Exactly, just prevent users

[PATCH v2 00/25] AMDKFD kernel driver

2014-07-22 Thread Oded Gabbay
On 22/07/14 12:21, Daniel Vetter wrote: > On Tue, Jul 22, 2014 at 10:19 AM, Oded Gabbay wrote: >>> Exactly, just prevent userspace from submitting more. And if you have >>> misbehaving userspace that submits too much, reset the gpu and tell it >>> that you're sor

[PATCH v2 00/25] AMDKFD kernel driver

2014-07-22 Thread Oded Gabbay
On 22/07/14 10:40, Daniel Vetter wrote: > On Tue, Jul 22, 2014 at 09:28:51AM +0200, Daniel Vetter wrote: >> On Mon, Jul 21, 2014 at 03:03:07PM -0400, Jerome Glisse wrote: >>> On Mon, Jul 21, 2014 at 09:41:29PM +0300, Oded Gabbay wrote: >>>> On 21/07/14 21:22, Daniel V

[PATCH v2 00/25] AMDKFD kernel driver

2014-07-22 Thread Oded Gabbay
On 22/07/14 10:28, Daniel Vetter wrote: > On Mon, Jul 21, 2014 at 03:03:07PM -0400, Jerome Glisse wrote: >> On Mon, Jul 21, 2014 at 09:41:29PM +0300, Oded Gabbay wrote: >>> On 21/07/14 21:22, Daniel Vetter wrote: >>>> On Mon, Jul 21, 2014 at 7:28 PM, Oded Gabbay &

[PATCH v2 00/25] AMDKFD kernel driver

2014-07-22 Thread Oded Gabbay
On 22/07/14 10:23, Daniel Vetter wrote: > On Mon, Jul 21, 2014 at 10:23:43PM +0300, Oded Gabbay wrote: >> But Jerome, the core problem still remains in effect, even with your >> suggestion. If an application, either via userspace queue or via ioctl, >> submits a long-running

[PATCH v2 00/25] AMDKFD kernel driver

2014-07-22 Thread Oded Gabbay
On 22/07/14 02:05, Jerome Glisse wrote: > On Tue, Jul 22, 2014 at 12:56:13AM +0300, Oded Gabbay wrote: >> On 21/07/14 22:28, Jerome Glisse wrote: >>> On Mon, Jul 21, 2014 at 10:23:43PM +0300, Oded Gabbay wrote: >>>> On 21/07/14 21:59, Jerome Glisse wrote: >>&g

[PATCH v2 00/25] AMDKFD kernel driver

2014-07-22 Thread Oded Gabbay
On 21/07/14 22:28, Jerome Glisse wrote: > On Mon, Jul 21, 2014 at 10:23:43PM +0300, Oded Gabbay wrote: >> On 21/07/14 21:59, Jerome Glisse wrote: >>> On Mon, Jul 21, 2014 at 09:36:44PM +0300, Oded Gabbay wrote: >>>> On 21/07/14 21:14, Jerome Glisse wrote: >>&g

[PATCH v2 00/25] AMDKFD kernel driver

2014-07-21 Thread Oded Gabbay
On 21/07/14 21:59, Jerome Glisse wrote: > On Mon, Jul 21, 2014 at 09:36:44PM +0300, Oded Gabbay wrote: >> On 21/07/14 21:14, Jerome Glisse wrote: >>> On Mon, Jul 21, 2014 at 08:42:58PM +0300, Oded Gabbay wrote: >>>> On 21/07/14 18:54, Jerome Glisse wrote: >>&g

<    5   6   7   8   9   10   11   12   >