Re: [PATCH v2 0/3] drm: commit_work scheduling

2020-10-07 Thread Qais Yousef
longer preempt it. And you can manage the SF threads to be any value you want relative to 50 anyway without having to manage commit_work itself. I'm not sure if you have problems with RT tasks preempting important CFS tasks. My brain registered two conflicting statements. Thanks

Re: [PATCH v2 0/3] drm: commit_work scheduling

2020-10-07 Thread Qais Yousef
On 10/06/20 13:04, Rob Clark wrote: > On Tue, Oct 6, 2020 at 3:59 AM Qais Yousef wrote: > > > > On 10/05/20 16:24, Rob Clark wrote: > > > > [...] > > > > > > RT planning and partitioning is not easy task for sure. You might want > > > >

Re: [PATCH v2 0/3] drm: commit_work scheduling

2020-10-07 Thread Qais Yousef
, it might help to see if softirqs are affecting you. I know Android has issues with this under some circumstances. > traces. So far it seems like SF stomping on commit_work. (There is > the added complication that there are some chrome gpu-process tasks in > between SF and the display, including CrGpuMain (which really doesn't > want to be SCHED_FIFO when executing gl commands on behalf of > something unrelated to the compositor.. the deadline approach, IIUC, > might be the better option eventually for this?) If you meant sched_deadline + token approach, then yeah I think it'd be better. But as you said, we can't do this yet :/ But as Peter pointed out, this doesn't mean you can't use SCHED_DEADLINE at all if it does make sense. Thanks -- Qais Yousef ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 0/3] drm: commit_work scheduling

2020-10-06 Thread Qais Yousef
+CC Steve and Peter - they might be interested. On 10/02/20 11:07, Rob Clark wrote: > On Fri, Oct 2, 2020 at 4:01 AM Qais Yousef wrote: > > > > On 09/30/20 14:17, Rob Clark wrote: > > > From: Rob Clark > > > > > > The android userspace treats

Re: [PATCH v2 0/3] drm: commit_work scheduling

2020-10-03 Thread Qais Yousef
such that any task holding it will automatically be promoted to SCHED_FIFO and then demoted to CFS once it releases it. Haven't worked with display pipelines before, so hopefully this makes sense :-) Thanks -- Qais Yousef > > To handle this, convert non-blocking commit_work() to use per-CRTC >

Re: [PATCH 0/3] drm: commit_work scheduling

2020-09-25 Thread Qais Yousef
on names its threads to match this regex and get a free promotion to RT without having the capability to do so? Cheers -- Qais Yousef ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 0/3] drm: commit_work scheduling

2020-09-22 Thread Qais Yousef
s and/or sending > pageflip events, it could probably work ok to use a single priority > level for both commit-work and vblank-work. This is a function of num_cpus too. As long as nr_cpus > nr_running_rt_tasks you should be fine. Cheers -- Qais Yousef _