Add missing mutex unlock before returning from the error path in
cdns_mhdp_atomic_enable().

Fixes: 935a92a1c400 ("drm: bridge: cdns-mhdp8546: Fix possible null pointer 
dereference")
Reported-by: Hulk Robot <hul...@huawei.com>
Signed-off-by: Qi Xi <xi...@huawei.com>
---
 drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c 
b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c
index a614d1384f71..38726ae1bf15 100644
--- a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c
+++ b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c
@@ -1984,8 +1984,10 @@ static void cdns_mhdp_atomic_enable(struct drm_bridge 
*bridge,
        mhdp_state = to_cdns_mhdp_bridge_state(new_state);
 
        mhdp_state->current_mode = drm_mode_duplicate(bridge->dev, mode);
-       if (!mhdp_state->current_mode)
-               return;
+       if (!mhdp_state->current_mode) {
+               ret = -EINVAL;
+               goto out;
+       }
 
        drm_mode_set_name(mhdp_state->current_mode);
 
-- 
2.33.0

Reply via email to