Re: [PATCH 4/5] power: avs: smartreflex: Remove superfluous cast in debugfs_create_file() call

2019-11-13 Thread Rafael J. Wysocki
On Monday, October 21, 2019 4:51:48 PM CET Geert Uytterhoeven wrote: > There is no need to cast a typed pointer to a void pointer when calling > a function that accepts the latter. Remove it, as the cast prevents > further compiler checks. > > Signed-off-by: Geert Uytterhoeven > --- >

Re: [PATCH 4/5] power: avs: smartreflex: Remove superfluous cast in debugfs_create_file() call

2019-11-08 Thread Rafael J. Wysocki
On Monday, October 21, 2019 4:51:48 PM CET Geert Uytterhoeven wrote: > There is no need to cast a typed pointer to a void pointer when calling > a function that accepts the latter. Remove it, as the cast prevents > further compiler checks. > > Signed-off-by: Geert Uytterhoeven Greg, have you

Re: [Nouveau] [PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI string to enable dGPU direct output"

2019-10-21 Thread Rafael J. Wysocki
roached. OK, please let me know when the _OSI string in question can be dropped. > On Mon, Oct 21, 2019 at 10:14 AM Rafael J. Wysocki wrote: > > > > On Mon, Oct 21, 2019 at 4:14 AM Alex Hung wrote: > > > > > > We have done some tests on three of Intel + nVidia confi

Re: [Nouveau] [PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI string to enable dGPU direct output"

2019-10-21 Thread Rafael J. Wysocki
On Mon, Oct 21, 2019 at 4:14 AM Alex Hung wrote: > > We have done some tests on three of Intel + nVidia configuration > systems with OEM _OSI strings removed - while some bugs are still > observed, ex. one out of three has suspend/resume issues, no system > crashes were observed - the biggest

Re: [RFC PATCH] pci: prevent putting pcie devices into lower device states on certain intel bridges

2019-10-03 Thread Rafael J. Wysocki
On Tuesday, October 1, 2019 12:00:50 PM CEST Karol Herbst wrote: > On Tue, Oct 1, 2019 at 11:11 AM Mika Westerberg > wrote: > > > > On Tue, Oct 01, 2019 at 10:56:39AM +0200, Karol Herbst wrote: > > > On Tue, Oct 1, 2019 at 10:47 AM Mika Westerberg > > > wrote: > > > > > > > > On Mon, Sep 30,

Re: [RFC PATCH] pci: prevent putting pcie devices into lower device states on certain intel bridges

2019-10-02 Thread Rafael J. Wysocki
On Tue, Oct 1, 2019 at 9:34 PM Bjorn Helgaas wrote: > > On Tue, Oct 01, 2019 at 06:21:28PM +0200, Karol Herbst wrote: > > On Tue, Oct 1, 2019 at 3:27 PM Bjorn Helgaas wrote: > > > On Mon, Sep 30, 2019 at 06:36:12PM +0200, Karol Herbst wrote: > > > > On Mon, Sep 30, 2019 at 6:30 PM Mika

Re: [Nouveau] [PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI string to enable dGPU direct output"

2019-09-05 Thread Rafael J. Wysocki
Alex Hung and Mario need to answer this question I think. > On Mon, Aug 19, 2019 at 11:52 AM Rafael J. Wysocki wrote: > > > > On Thursday, August 15, 2019 12:47:35 AM CEST Dave Airlie wrote: > > > On Thu, 15 Aug 2019 at 07:31, Karol Herbst wrote: &g

Re: [Nouveau] [PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI string to enable dGPU direct output"

2019-08-19 Thread Rafael J. Wysocki
On Thursday, August 15, 2019 12:47:35 AM CEST Dave Airlie wrote: > On Thu, 15 Aug 2019 at 07:31, Karol Herbst wrote: > > > > This reverts commit 28586a51eea666d5531bcaef2f68e4abbd87242c. > > > > The original commit message didn't even make sense. AMD _does_ support it > > and > > it works with

Re: [PATCH 00/10] cpufreq: Migrate users of policy notifiers to QoS requests

2019-07-16 Thread Rafael J. Wysocki
On Tue, Jul 16, 2019 at 12:14 PM Viresh Kumar wrote: > > On 16-07-19, 12:06, Rafael J. Wysocki wrote: > > On Tue, Jul 16, 2019 at 11:49 AM Viresh Kumar > > wrote: > > > > > > Hello, > > > > > > Now that cpufreq core supports taking QoS re

Re: [PATCH 00/10] cpufreq: Migrate users of policy notifiers to QoS requests

2019-07-16 Thread Rafael J. Wysocki
On Tue, Jul 16, 2019 at 11:49 AM Viresh Kumar wrote: > > Hello, > > Now that cpufreq core supports taking QoS requests for min/max cpu > frequencies, lets migrate rest of the users to using them instead of the > policy notifiers. Technically, this still is linux-next only. :-) > The

Re: [PATCH 2/4] components: multiple components for a device

2019-02-07 Thread Rafael J. Wysocki
; - Remove redundant "This" from kerneldoc (also in the previous patch) > - Streamline the logic in find_component() a bit. > > Signed-off-by: Daniel Vetter (v1 code) > Signed-off-by: Ramalingam C (v1 commit message) > Cc: Ramalingam C > Cc: Greg Kroah-Hartman > Cc: R

Re: [PATCH 2/3] components: multiple components for a device

2019-02-07 Thread Rafael J. Wysocki
On Thu, Feb 7, 2019 at 11:40 PM Daniel Vetter wrote: > > On Wed, Feb 06, 2019 at 11:57:04PM +0100, Rafael J. Wysocki wrote: > > ) On Wed, Feb 6, 2019 at 5:46 PM Daniel Vetter > > wrote: > > > > > > Component framework is extended to support multiple

Re: [PATCH 2/3] components: multiple components for a device

2019-02-06 Thread Rafael J. Wysocki
(v1 code) > Signed-off-by: Ramalingam C (v1 commit message) > Cc: Ramalingam C > Cc: Greg Kroah-Hartman > Cc: Russell King > Cc: Rafael J. Wysocki > Cc: Jaroslav Kysela > Cc: Takashi Iwai > Cc: Rodrigo Vivi > Cc: Jani Nikula

Re: [PATCH] component: Add documentation

2019-02-06 Thread Rafael J. Wysocki
k/helper > - clarify the documentation for component_match_add functions. > > Cc: "C, Ramalingam" > Cc: Greg Kroah-Hartman > Cc: Russell King > Cc: Rafael J. Wysocki > Cc: Jaroslav Kysela > Cc: Takashi Iwai > Cc: Rodrigo Vivi > Cc: Jani Nikula &

Re: [PATCH 1/2] component: Add documentation

2019-02-05 Thread Rafael J. Wysocki
components. > > But that's way more than a quick doc typing exercise ... > > Thanks to Ram for commenting on an initial draft of these docs. Look goods to me overall (even though I'm not super-familiar with the component framework), but see below. > Cc: "C, Ramalingam" > Cc

Re: Armada DRM: bridge with componentized devices

2019-01-24 Thread Rafael J. Wysocki
On Friday, January 18, 2019 1:57:47 PM CET Daniel Vetter wrote: > On Fri, Jan 18, 2019 at 12:38 PM Rafael J. Wysocki wrote: > > > > On Fri, Jan 18, 2019 at 12:17 PM Rafael J. Wysocki > > wrote: > > > > > > On Fri, Jan 18, 2019 at 12:06 PM Daniel Vetter

Re: [PATCH v5 3/3] PM/runtime:Replace jiffies based accounting with ktime based accounting

2019-01-21 Thread Rafael J. Wysocki
On Mon, Jan 21, 2019 at 4:17 PM Vincent Guittot wrote: > > On Fri, 18 Jan 2019 at 13:08, Guenter Roeck wrote: > > > > On 1/18/19 3:05 AM, Rafael J. Wysocki wrote: > > > On Fri, Jan 18, 2019 at 11:53 AM Vincent Guittot > > > wrote: > > >> >

Re: Armada DRM: bridge with componentized devices

2019-01-18 Thread Rafael J. Wysocki
On Fri, Jan 18, 2019 at 12:17 PM Rafael J. Wysocki wrote: > > On Fri, Jan 18, 2019 at 12:06 PM Daniel Vetter wrote: > > > > On Fri, Jan 18, 2019 at 11:03 AM Rafael J. Wysocki > > wrote: > > > > > > On Fri, Jan 18, 2019 at 10:37 AM Lucas Stach >

Re: Armada DRM: bridge with componentized devices

2019-01-18 Thread Rafael J. Wysocki
On Fri, Jan 18, 2019 at 12:06 PM Daniel Vetter wrote: > > On Fri, Jan 18, 2019 at 11:03 AM Rafael J. Wysocki wrote: > > > > On Fri, Jan 18, 2019 at 10:37 AM Lucas Stach wrote: > > > > > > Am Donnerstag, den 17.01.2019, 13:20 +0100 schrieb Daniel Vetter: &

Re: [PATCH v5 3/3] PM/runtime:Replace jiffies based accounting with ktime based accounting

2019-01-18 Thread Rafael J. Wysocki
On Fri, Jan 18, 2019 at 11:53 AM Vincent Guittot wrote: > > On Fri, 18 Jan 2019 at 11:42, Vincent Guittot > wrote: > > > > Hi Guenter, > > > > Le Thursday 17 Jan 2019 à 14:16:28 (-0800), Guenter Roeck a écrit : > > > On Fri, Dec 21, 2018 at 11:33:56AM +0100, Vincent Guittot wrote: > > > > From:

Re: [PATCH v5 3/3] PM/runtime:Replace jiffies based accounting with ktime based accounting

2019-01-18 Thread Rafael J. Wysocki
On Thu, Jan 17, 2019 at 11:16 PM Guenter Roeck wrote: > > On Fri, Dec 21, 2018 at 11:33:56AM +0100, Vincent Guittot wrote: > > From: Thara Gopinath > > > > This patch replaces jiffies based accounting for runtime_active_time > > and runtime_suspended_time with ktime base accounting. This makes

Re: Armada DRM: bridge with componentized devices

2019-01-18 Thread Rafael J. Wysocki
On Fri, Jan 18, 2019 at 10:37 AM Lucas Stach wrote: > > Am Donnerstag, den 17.01.2019, 13:20 +0100 schrieb Daniel Vetter: > [...] > > > > > I don't think it is addressed here. > > > > > > Can anyone please explain to me what happens in more detail? > > > > My understanding (and this might be

Re: Armada DRM: bridge with componentized devices

2019-01-17 Thread Rafael J. Wysocki
On Thursday, January 17, 2019 6:26:25 PM CET Russell King - ARM Linux admin wrote: > On Tue, Jan 15, 2019 at 11:47:00PM +0100, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > Subject: [PATCH] driver core: Fix adding device links to probing suppliers > > > >

Re: Armada DRM: bridge with componentized devices

2019-01-16 Thread Rafael J. Wysocki
On Wednesday, January 16, 2019 7:42:45 PM CET Daniel Vetter wrote: > On Tue, Jan 15, 2019 at 11:47 PM Rafael J. Wysocki wrote: > > > > [CC Greg] > > > > On Tuesday, January 15, 2019 1:04:02 AM CET Rafael J. Wysocki wrote: > > > [CC Lukas and linux-pm] > &g

Re: [Intel-gfx] [PATCH v5 2/3] drm/i915: Move on the new pm runtime interface

2019-01-16 Thread Rafael J. Wysocki
On Monday, January 7, 2019 3:21:49 PM CET Rafael J. Wysocki wrote: > On Mon, Jan 7, 2019 at 3:04 PM Vincent Guittot > wrote: > > > > Hi Tvrtko, > > > > On Mon, 31 Dec 2018 at 13:32, Tvrtko Ursulin > > wrote: > > > > > > > > > On

Re: Armada DRM: bridge with componentized devices

2019-01-15 Thread Rafael J. Wysocki
[CC Greg] On Tuesday, January 15, 2019 1:04:02 AM CET Rafael J. Wysocki wrote: > [CC Lukas and linux-pm] > > On Mon, Jan 14, 2019 at 1:32 PM Rafael J. Wysocki wrote: > > > > On Fri, Jan 11, 2019 at 3:49 PM Russell King - ARM Linux > > wrote: > > [cut] > &

Re: Armada DRM: bridge with componentized devices

2019-01-14 Thread Rafael J. Wysocki
[CC Lukas and linux-pm] On Mon, Jan 14, 2019 at 1:32 PM Rafael J. Wysocki wrote: > > On Fri, Jan 11, 2019 at 3:49 PM Russell King - ARM Linux > wrote: [cut] > > > > This thread is discussing how to deal with Armada DRM, its use of the > > component h

Re: Armada DRM: bridge with componentized devices

2019-01-14 Thread Rafael J. Wysocki
On Fri, Jan 11, 2019 at 3:49 PM Russell King - ARM Linux wrote: > > On Fri, Jan 11, 2019 at 03:36:28PM +0100, Rafael J. Wysocki wrote: > > On Fri, Jan 11, 2019 at 3:32 PM Russell King - ARM Linux > > wrote: > > > > > > On Fri, Jan 11, 2019 at 03:26

Re: Armada DRM: bridge with componentized devices

2019-01-11 Thread Rafael J. Wysocki
On Fri, Jan 11, 2019 at 3:36 PM Daniel Vetter wrote: > > On Fri, Jan 11, 2019 at 3:32 PM Russell King - ARM Linux > wrote: > > On Fri, Jan 11, 2019 at 03:26:44PM +0100, Rafael J. Wysocki wrote: > > > On Fri, Jan 11, 2019 at 3:20 PM Daniel Vetter wrote: > > > &g

Re: Armada DRM: bridge with componentized devices

2019-01-11 Thread Rafael J. Wysocki
On Fri, Jan 11, 2019 at 3:32 PM Russell King - ARM Linux wrote: > > On Fri, Jan 11, 2019 at 03:26:44PM +0100, Rafael J. Wysocki wrote: > > On Fri, Jan 11, 2019 at 3:20 PM Daniel Vetter wrote: > > > > > > On Wed, Jan 9, 2019 at 10:31 AM Russell King - ARM Linux >

Re: Armada DRM: bridge with componentized devices

2019-01-11 Thread Rafael J. Wysocki
On Fri, Jan 11, 2019 at 3:20 PM Daniel Vetter wrote: > > On Wed, Jan 9, 2019 at 10:31 AM Russell King - ARM Linux > wrote: > > On Wed, Jan 09, 2019 at 10:24:01AM +0100, Rafael J. Wysocki wrote: > > > On Wed, Jan 9, 2019 at 10:13 AM Andrzej Hajda wrote: > > >

Re: Armada DRM: bridge with componentized devices

2019-01-09 Thread Rafael J. Wysocki
On Wed, Jan 9, 2019 at 10:13 AM Andrzej Hajda wrote: > > +CC: Rafael J. Wysocki > > On 08.01.2019 16:07, Russell King - ARM Linux wrote: > > On Tue, Jan 08, 2019 at 03:33:54PM +0100, Andrzej Hajda wrote: > >> On 08.01.2019 14:21, Russell King - ARM Linux wrote: >

Re: [Intel-gfx] [PATCH v5 2/3] drm/i915: Move on the new pm runtime interface

2019-01-07 Thread Rafael J. Wysocki
On Mon, Jan 7, 2019 at 3:04 PM Vincent Guittot wrote: > > Hi Tvrtko, > > On Mon, 31 Dec 2018 at 13:32, Tvrtko Ursulin > wrote: > > > > > > On 21/12/2018 13:26, Vincent Guittot wrote: > > > On Fri, 21 Dec 2018 at 12:33, Tvrtko Ursulin > > [snip] > > > >> > > >> If it is always monotonic, then

Re: [PATCH v4 03/11] vga-switcheroo: make PCI dependency explicit

2019-01-07 Thread Rafael J. Wysocki
On Mon, Jan 7, 2019 at 11:34 AM Daniel Vetter wrote: > > On Sun, Dec 30, 2018 at 07:56:04PM +, Sinan Kaya wrote: > > This driver depends on the PCI infrastructure but the dependency has not > > been explicitly called out. > > > > Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without

Re: [PATCH v4 3/3] PM/runtime:Replace jiffies based accounting with ktime based accounting

2018-12-21 Thread Rafael J. Wysocki
On Thu, Dec 20, 2018 at 11:03 PM Ulf Hansson wrote: > > On Thu, 20 Dec 2018 at 15:17, Vincent Guittot > wrote: > > > > From: Thara Gopinath > > > > This patch replaces jiffies based accounting for runtime_active_time > > and runtime_suspended_time with ktime base accounting. This makes the > >

Re: [PATCH] sysfs: Disable lockdep for driver bind/unbind files

2018-12-19 Thread Rafael J. Wysocki
around I've noticed that usb and i2c already handle similar > recursion problems, where a sysfs file can unbind the same type of > sysfs somewhere else in the hierarchy. Relevant commits are: > > commit 356c05d58af05d582e634b54b40050c73609617b > Author: Alan Stern > Date: Mon May 14 13:30:03 2012 -0400 > &

Re: [PATCH] sysfs: Disable lockdep for driver bind/unbind files

2018-12-19 Thread Rafael J. Wysocki
LAGS: 0246 ORIG_RAX: > > > 0001 > > > [12301.899282] RAX: ffda RBX: 000d RCX: > > > 7f452ac7f7a4 > > > [12301.899288] RDX: 000d RSI: 5612a1abf7c0 RDI: > > > 000000000001 > > > [1230

Re: [PATCH] sysfs: Disable lockdep for driver bind/unbind files

2018-12-19 Thread Rafael J. Wysocki
2301.899295] RBP: 5612a1abf7c0 R08: 000a R09: > > 5612a1c46730 > > [12301.899301] R10: 000a R11: 0246 R12: > > 000d > > [12301.899308] R13: 0001 R14: 00007f452af4a740 R15: > > 000d > > > >

Re: [PATCH] sysfs: Disable lockdep for driver bind/unbind files

2018-12-18 Thread Rafael J. Wysocki
5612a1abf7c0 R08: 0000000a R09: > 5612a1c46730 > [12301.899301] R10: 000a R11: 0246 R12: > 000d > [12301.899308] R13: 0001 R14: 7f452af4a740 R15: > 000d > > Locking around I've noticed that usb and i

Re: [PATCH v2 3/3] drm/i915: Move to new PM core fields

2018-12-18 Thread Rafael J. Wysocki
On Tue, Dec 18, 2018 at 10:58 AM Vincent Guittot wrote: > > On Tue, 18 Dec 2018 at 10:57, Rafael J. Wysocki wrote: > > > > On Mon, Dec 17, 2018 at 3:22 PM Vincent Guittot > > wrote: > > > > > > On Fri, 14 Dec 2018 at 15:36, Ulf Hansson wrote: &g

Re: [PATCH v2 3/3] drm/i915: Move to new PM core fields

2018-12-18 Thread Rafael J. Wysocki
On Mon, Dec 17, 2018 at 3:22 PM Vincent Guittot wrote: > > On Fri, 14 Dec 2018 at 15:36, Ulf Hansson wrote: > > > > On Fri, 14 Dec 2018 at 15:22, Vincent Guittot > > wrote: > > > > > > With jiffies been replaced by raw ns in PM core accounting, 915 driver is > > > updated to use this new time

Re: [PATCH] drivers/base: use a worker for sysfs unbind

2018-12-17 Thread Rafael J. Wysocki
On Mon, Dec 17, 2018 at 8:48 PM Daniel Vetter wrote: > > On Thu, Dec 13, 2018 at 07:09:15PM +0100, Rafael J. Wysocki wrote: > > On Thu, Dec 13, 2018 at 5:25 PM Daniel Vetter > > wrote: > > > > > > On Thu, Dec 13, 2018 at 5:18 PM Rafael J. Wysocki > &g

Re: [PATCH v4 2/3] ACPI / PMIC: Implement exec_mipi_pmic_seq_element for CHT Whiskey Cove PMIC

2018-12-14 Thread Rafael J. Wysocki
On Fri, Dec 14, 2018 at 12:05 PM Mika Westerberg wrote: > > On Fri, Dec 14, 2018 at 11:48:35AM +0100, Hans de Goede wrote: > > > > +#include > > > > > > Why is this include needed? > > > > It is no longer needed in v4, since the parsing of the raw > > MIPI sequence data (which needed this

Re: [PATCH] drivers/base: use a worker for sysfs unbind

2018-12-13 Thread Rafael J. Wysocki
On Thu, Dec 13, 2018 at 5:25 PM Daniel Vetter wrote: > > On Thu, Dec 13, 2018 at 5:18 PM Rafael J. Wysocki wrote: > > > > On Thu, Dec 13, 2018 at 1:36 PM Daniel Vetter > > wrote: [cut] > > > I can do the old code exactly, but afaict the non-NULL parent just &

Re: [PATCH] drivers/base: use a worker for sysfs unbind

2018-12-13 Thread Rafael J. Wysocki
On Thu, Dec 13, 2018 at 1:36 PM Daniel Vetter wrote: > > On Thu, Dec 13, 2018 at 11:23 AM Rafael J. Wysocki wrote: > > > > On Thu, Dec 13, 2018 at 10:58 AM Daniel Vetter wrote: > > > > > > On Thu, Dec 13, 2018 at 10:38:14AM +0100, Rafael J. Wysocki wrote: >

Re: [PATCH] drivers/base: use a worker for sysfs unbind

2018-12-13 Thread Rafael J. Wysocki
On Thu, Dec 13, 2018 at 11:23 AM Rafael J. Wysocki wrote: > > On Thu, Dec 13, 2018 at 10:58 AM Daniel Vetter wrote: [cut] > > > > - Most of these issues are never visible in normal usage, since normally > > driver bind/unbind is done from a kthread or mo

Re: [PATCH] drivers/base: use a worker for sysfs unbind

2018-12-13 Thread Rafael J. Wysocki
On Thu, Dec 13, 2018 at 10:58 AM Daniel Vetter wrote: > > On Thu, Dec 13, 2018 at 10:38:14AM +0100, Rafael J. Wysocki wrote: > > On Mon, Dec 10, 2018 at 9:47 AM Daniel Vetter > > wrote: > > > > > > Drivers might want to remove some sysfs files, which ne

Re: [PATCH] drivers/base: use a worker for sysfs unbind

2018-12-13 Thread Rafael J. Wysocki
On Mon, Dec 10, 2018 at 9:47 AM Daniel Vetter wrote: > > Drivers might want to remove some sysfs files, which needs the same > locks and ends up angering lockdep. Relevant snippet of the stack > trace: > > kernfs_remove_by_name_ns+0x3b/0x80 > bus_remove_driver+0x92/0xa0 >

Re: [PATCH 1/8] cpufreq: tegra186: don't pass GFP_DMA32 to dma_alloc_coherent

2018-10-17 Thread Rafael J. Wysocki
On Wed, Oct 17, 2018 at 9:19 AM Christoph Hellwig wrote: > > On Mon, Oct 15, 2018 at 09:43:04AM +0200, Rafael J. Wysocki wrote: > > On Sat, Oct 13, 2018 at 5:17 PM Christoph Hellwig wrote: > > > > > > The DMA API does its own zone decisions based on the coherent_dm

Re: [PATCH 1/8] cpufreq: tegra186: don't pass GFP_DMA32 to dma_alloc_coherent

2018-10-15 Thread Rafael J. Wysocki
On Sat, Oct 13, 2018 at 5:17 PM Christoph Hellwig wrote: > > The DMA API does its own zone decisions based on the coherent_dma_mask. > > Signed-off-by: Christoph Hellwig Acked-by: Rafael J. Wysocki > --- > drivers/cpufreq/tegra186-cpufreq.c | 2 +- > 1 file chang

Re: [Nouveau] [PATCH 1/5] drm/nouveau: Prevent RPM callback recursion in suspend/resume paths

2018-07-18 Thread Rafael J. Wysocki
On Wed, Jul 18, 2018 at 10:11 PM, Lyude Paul wrote: > On Wed, 2018-07-18 at 10:36 +0200, Lukas Wunner wrote: >> On Wed, Jul 18, 2018 at 10:25:05AM +0200, Lukas Wunner wrote: >> > The GPU contains an i2c subdevice for each connector with DDC lines. >> > I believe those are modelled as children of

Re: [Nouveau] [PATCH 1/5] drm/nouveau: Prevent RPM callback recursion in suspend/resume paths

2018-07-18 Thread Rafael J. Wysocki
On Wed, Jul 18, 2018 at 10:25 AM, Lukas Wunner wrote: > On Wed, Jul 18, 2018 at 09:38:41AM +0200, Rafael J. Wysocki wrote: >> On Tue, Jul 17, 2018 at 8:20 PM, Lukas Wunner wrote: >> > Okay, the PCI device is suspending and the nvkm_i2c_aux_acquire() >> > wants it in r

Re: [Nouveau] [PATCH 1/5] drm/nouveau: Prevent RPM callback recursion in suspend/resume paths

2018-07-18 Thread Rafael J. Wysocki
On Tue, Jul 17, 2018 at 8:34 PM, Lyude Paul wrote: > On Tue, 2018-07-17 at 20:32 +0200, Lukas Wunner wrote: >> On Tue, Jul 17, 2018 at 02:24:31PM -0400, Lyude Paul wrote: >> > On Tue, 2018-07-17 at 20:20 +0200, Lukas Wunner wrote: >> > > Okay, the PCI device is suspending and the

Re: [Nouveau] [PATCH 1/5] drm/nouveau: Prevent RPM callback recursion in suspend/resume paths

2018-07-18 Thread Rafael J. Wysocki
On Tue, Jul 17, 2018 at 8:20 PM, Lukas Wunner wrote: > On Tue, Jul 17, 2018 at 12:53:11PM -0400, Lyude Paul wrote: >> On Tue, 2018-07-17 at 09:16 +0200, Lukas Wunner wrote: >> > On Mon, Jul 16, 2018 at 07:59:25PM -0400, Lyude Paul wrote: >> > > In order to fix all of the spots that need to have

Re: [Nouveau] [PATCH 1/5] drm/nouveau: Prevent RPM callback recursion in suspend/resume paths

2018-07-17 Thread Rafael J. Wysocki
On Tue, Jul 17, 2018 at 9:16 AM, Lukas Wunner wrote: > [cc += linux-pm] > > Hi Lyude, > > First of all, thanks a lot for looking into this. > > On Mon, Jul 16, 2018 at 07:59:25PM -0400, Lyude Paul wrote: >> In order to fix all of the spots that need to have runtime PM get/puts() >> added, we need

Re: [PATCH] cpufreq: use for_each_if

2018-07-09 Thread Rafael J. Wysocki
On Mon, Jul 9, 2018 at 6:11 PM, Daniel Vetter wrote: > Avoids the inverted condition compared to the open coded version. > > Signed-off-by: Daniel Vetter > Cc: "Rafael J. Wysocki" > Cc: Viresh Kumar > Cc: linux...@vger.kernel.org > Cc: Eric Engestrom > -- >

Re: [PATCH v3 5/5] drm/arm/malidp: Added the late system pm functions

2018-05-16 Thread Rafael J. Wysocki
pm_runtime_set_active(dev); > + return 0; > +} > + > static const struct dev_pm_ops malidp_pm_ops = { > SET_SYSTEM_SLEEP_PM_OPS(malidp_pm_suspend, malidp_pm_resume) \ > + SET_LATE_SYSTEM_SLEEP_PM_OPS(malidp_pm_suspend_late, > malidp_pm_resume_early) \ > SET

Re: [PATCH v3 5/5] drm/arm/malidp: Added the late system pm functions

2018-05-15 Thread Rafael J. Wysocki
On 5/14/2018 12:01 PM, Ayan Halder wrote: On Wed, Apr 25, 2018 at 01:49:35PM +0200, Daniel Vetter wrote: Hi Daniel, On Wed, Apr 25, 2018 at 1:26 PM, Liviu Dudau wrote: On Wed, Apr 25, 2018 at 09:17:22AM +0200, Daniel Vetter wrote: On Tue, Apr 24, 2018 at 07:12:47PM

Re: [trivial PATCH V2] treewide: Align function definition open/close braces

2018-03-21 Thread Rafael J. Wysocki
drew Morton picks this up. > > V2: Remove fs/xfs/libxfs/xfs_alloc.c as it's updated and remerge the rest > > arch/x86/include/asm/atomic64_32.h | 2 +- > drivers/acpi/custom_method.c | 2 +- > drivers/acpi/fan.c |

Re: [PATCH 1/7] PCI: Restore BARs on runtime resume despite being unbound

2018-02-21 Thread Rafael J. Wysocki
On Wednesday, February 21, 2018 10:57:14 AM CET Rafael J. Wysocki wrote: > On Tue, Feb 20, 2018 at 10:29 PM, Bjorn Helgaas <helg...@kernel.org> wrote: > > On Sun, Feb 18, 2018 at 09:38:32AM +0100, Lukas Wunner wrote: > >> PCI devices not bound to a driver are suppo

Re: [PATCH 1/7] PCI: Restore BARs on runtime resume despite being unbound

2018-02-21 Thread Rafael J. Wysocki
ne for unbound devices. That is a fair point, but if you look at pci_pm_runtime_suspend(), it doesn't actually save anything for devices without drivers, so we'd just restore the original initial state for them every time. If we are to restore the entire state on runtime resume, pci_pm_runtime_suspend(

Re: [PATCH 1/7] PCI: Restore BARs on runtime resume despite being unbound

2018-02-19 Thread Rafael J. Wysocki
ove-mentioned use cases. Other use > cases might require a full-blown pci_save_state() / pci_restore_state() > or execution of fixups. We can add that once use cases materialize, > let's not inflate the code unnecessarily. > > Cc: Bjorn Helgaas <bhelg...@google.com> > Cc: Rafael J

Re: [PATCH v2] drm/i915/pmu: Fix sleep under atomic in RC6 readout

2018-02-07 Thread Rafael J. Wysocki
On 2/6/2018 10:54 PM, Imre Deak wrote: Hi Rafael, On Tue, Feb 06, 2018 at 09:11:02PM +, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-02-06 18:33:11) From: Tvrtko Ursulin We are not allowed to call intel_runtime_pm_get from the PMU counter read callback

Re: [PATCH v5 1/6] base: power: runtime: Export pm_runtime_get/put_suppliers

2018-01-12 Thread Rafael J. Wysocki
ier. But as discussed on the thread [1] about > ARM-SMMU runtime pm, we don't want to introduce runtime pm calls > in atomic path in arm_smmu_unmap. > > [1] https://patchwork.kernel.org/patch/9827825/ > > Signed-off-by: Vivek Gautam <vivek.gau...@codeaurora.org> Acked-by

Re: [PATCH v5 0/6] iommu/arm-smmu: Add runtime pm/sleep support

2018-01-09 Thread Rafael J. Wysocki
On Tuesday, January 9, 2018 11:01:43 AM CET Vivek Gautam wrote: > This series provides the support for turning on the arm-smmu's > clocks/power domains using runtime pm. This is done using the > recently introduced device links patches, which lets the smmu's > runtime to follow the master's

Re: [trivial PATCH] treewide: Align function definition open/close braces

2017-12-18 Thread Rafael J. Wysocki
t raid6_calls raid6_sse2x2 = { > raid6_sse22_gen_syndrome, > @@ -366,9 +366,9 @@ static void raid6_sse24_gen_syndrome(int disks, size_t > bytes, void **ptrs) > kernel_fpu_end(); > } > > - static void raid6_sse24_xor_syndrome(int disks, int start, int stop, > +static void raid6_sse24_xor_syndrome(int disks, int start, int stop, >size_t bytes, void **ptrs) > - { > +{ > u8 **dptr = (u8 **)ptrs; > u8 *p, *q; > int d, z, z0; > @@ -471,7 +471,7 @@ static void raid6_sse24_gen_syndrome(int disks, size_t > bytes, void **ptrs) > } > asm volatile("sfence" : : : "memory"); > kernel_fpu_end(); > - } > +} > > > const struct raid6_calls raid6_sse2x4 = { > diff --git a/sound/soc/fsl/fsl_dma.c b/sound/soc/fsl/fsl_dma.c > index 0c11f434a374..ec619f51d336 100644 > --- a/sound/soc/fsl/fsl_dma.c > +++ b/sound/soc/fsl/fsl_dma.c > @@ -879,7 +879,7 @@ static const struct snd_pcm_ops fsl_dma_ops = { > }; > > static int fsl_soc_dma_probe(struct platform_device *pdev) > - { > +{ > struct dma_object *dma; > struct device_node *np = pdev->dev.of_node; > struct device_node *ssi_np; > > -- Acked-by: Rafael J. Wysocki <rafael.j.wyso...@intel.com> for the ACPI part. Thanks! ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] PM / QoS: Fix default runtime_pm device resume latency

2017-11-02 Thread Rafael J. Wysocki
On Wed, Nov 1, 2017 at 11:28 AM, Tero Kristo <t-kri...@ti.com> wrote: > On 01/11/17 00:32, Rafael J. Wysocki wrote: >> >> On Tue, Oct 31, 2017 at 7:07 PM, Geert Uytterhoeven >> <ge...@linux-m68k.org> wrote: >>> >>> Hi Rafael, >>>

Re: [PATCH] PM / QoS: Fix default runtime_pm device resume latency

2017-11-02 Thread Rafael J. Wysocki
[cut] >> It seems the default values for pm_qos have changed with the patch, and that >> breaks genpd at least. I only fixed PM runtime initially, but you could try >> this diff to fix the genpd part also: >> >> diff --git a/include/linux/pm_qos.h b/include/linux/pm_qos.h >> index

Re: [PATCH] PM / QoS: Fix default runtime_pm device resume latency

2017-11-01 Thread Rafael J. Wysocki
Tue, Oct 31, 2017 at 2:09 PM, Geert Uytterhoeven >> <ge...@linux-m68k.org> wrote: >>> On Tue, Oct 31, 2017 at 12:27 AM, Rafael J. Wysocki <r...@rjwysocki.net> >>> wrote: >>>> On Monday, October 30, 2017 11:19:08 AM CET Rafael J. Wysocki wrote: >&

Re: [PATCH] PM / QoS: Fix default runtime_pm device resume latency

2017-11-01 Thread Rafael J. Wysocki
On Tue, Oct 31, 2017 at 7:07 PM, Geert Uytterhoeven <ge...@linux-m68k.org> wrote: > Hi Rafael, > > On Tue, Oct 31, 2017 at 6:22 PM, Rafael J. Wysocki <raf...@kernel.org> wrote: >> On Tue, Oct 31, 2017 at 2:55 PM, Geert Uytterhoeven >> <ge...@linux-m68k.org>

Re: [PATCH] PM / QoS: Fix default runtime_pm device resume latency

2017-11-01 Thread Rafael J. Wysocki
Uytterhoeven >> <ge...@linux-m68k.org> wrote: >>> CC linux-renesas-soc >>> >>> On Tue, Oct 31, 2017 at 2:09 PM, Geert Uytterhoeven >>> <ge...@linux-m68k.org> wrote: >>>> On Tue, Oct 31, 2017 at 12:27 AM, Rafael J. Wysocki <r...@rj

Re: [PATCH] pci: Fix a possible sleep-in-atomic bug in pci_set_power_state

2017-10-10 Thread Rafael J. Wysocki
On Mon, Oct 9, 2017 at 7:18 PM, Bjorn Helgaas wrote: > On Mon, Oct 09, 2017 at 12:15:17PM -0500, Bjorn Helgaas wrote: >> [+cc Rafael, linux-pm] >> >> Hi Jia-Ju, >> >> On Mon, Oct 09, 2017 at 04:16:20PM +0800, Jia-Ju Bai wrote: >> > The drivers vt6655 and gma500 call

Re: [PATCH 2/3] ACPI/DRM: rework ACPI_VIDEO Kconfig dependencies

2017-07-26 Thread Rafael J. Wysocki
; depends on INPUT > select THERMAL > + select BACKLIGHT_CLASS_DEVICE > + select BACKLIGHT_LCD_SUPPORT > + default y > help > This driver implements the ACPI Extensions For Display Adapters > for int

Re: [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn

2017-02-17 Thread Rafael J. Wysocki
On Fri, Feb 17, 2017 at 8:11 AM, Joe Perches wrote: > There are ~4300 uses of pr_warn and ~250 uses of the older > pr_warning in the kernel source tree. > > Make the use of pr_warn consistent across all kernel files. > > This excludes all files in tools/ as there is a separate >

[PATCH] acpi: video: Move ACPI_VIDEO_NOTIFY_* defines to acpi/video.h

2016-11-24 Thread Rafael J. Wysocki
On Wednesday, November 09, 2016 06:15:56 PM Hans de Goede wrote: > acpi_video.c passed the ACPI_VIDEO_NOTIFY_* defines as type code to > acpi_notifier_call_chain(). Move these defines to acpi/video.h so > that acpi_notifier listeners can check the type code using these > defines. > >

[PATCH v2 1/2] PM / Domains: Allow genpd to power on during the system PM phase

2016-05-12 Thread Rafael J. Wysocki
On Wed, May 11, 2016 at 10:00 AM, Ulf Hansson wrote: > If the PM domain is powered off when the first device in the domain starts > its system PM prepare phase, genpd prevents any further attempts to power > on the PM domain during the system PM phase. This constraint affects not > only the

[PATCH 1/2] vga_switcheroo: add power support for windows 10 machines.

2016-03-14 Thread Rafael J. Wysocki
On Mon, Mar 14, 2016 at 11:23 AM, Mika Westerberg wrote: > On Mon, Mar 14, 2016 at 07:47:39PM +1000, Dave Airlie wrote: >> > >> >> - if (pcie_port_runtime_suspend_allowed(dev)) >> >> + if (pcie_port_runtime_suspend_allowed(dev)) { >> >> + pm_runtime_allow(>dev); >> > >> > PCI

[PATCH 1/2] vga_switcheroo: add power support for windows 10 machines.

2016-03-11 Thread Rafael J. Wysocki
On Friday, March 11, 2016 12:58:15 PM Mika Westerberg wrote: > On Thu, Mar 10, 2016 at 09:57:09PM +0100, Rafael J. Wysocki wrote: > > > It doesn't seem to do any runtime PM, > > > I do wonder if pcieport should be doing it's own runtime PM handling, > > > but that i

[PATCH 1/2] vga_switcheroo: add power support for windows 10 machines.

2016-03-10 Thread Rafael J. Wysocki
On Thursday, March 10, 2016 07:56:41 AM Dave Airlie wrote: > On 9 March 2016 at 23:19, Rafael J. Wysocki wrote: > > On Wed, Mar 9, 2016 at 7:14 AM, Dave Airlie wrote: > >> From: Dave Airlie > >> > >> Windows 10 seems to have standardised power control for

[PATCH 2/2] nouveau: use new vga_switcheroo power domain.

2016-03-09 Thread Rafael J. Wysocki
On Wed, Mar 9, 2016 at 7:14 AM, Dave Airlie wrote: > From: Dave Airlie > > This fixes GPU auto powerdown on the Lenovo W541, > since we advertise Windows 2013 to the ACPI layer. > > Signed-off-by: Dave Airlie > --- > drivers/gpu/drm/nouveau/nouveau_vga.c | 10 +++--- > 1 file changed, 7

[PATCH 1/2] vga_switcheroo: add power support for windows 10 machines.

2016-03-09 Thread Rafael J. Wysocki
On Wed, Mar 9, 2016 at 7:14 AM, Dave Airlie wrote: > From: Dave Airlie > > Windows 10 seems to have standardised power control for the > optimus/powerxpress laptops using PR3 power resource hooks. > > I'm not sure this is definitely the correct place to be > doing this, but it works for me here.

[PATCH v1 06/10] device property: switch to use UUID API

2016-02-18 Thread Rafael J. Wysocki
On Wednesday, February 17, 2016 02:17:24 PM Andy Shevchenko wrote: > Switch to use a generic UUID API instead of custom approach. It allows to > define UUIDs, compare them, and validate. > > Signed-off-by: Andy Shevchenko > --- > drivers/acpi/property.c | 18 -- > 1 file

[PATCH v12 2/4] PM / Domains: add setter for dev.pm_domain

2016-02-08 Thread Rafael J. Wysocki
On Mon, Feb 8, 2016 at 10:44 PM, wrote: > On Fri, 29 Jan 2016 22:35:18 +0100, "Rafael J. Wysocki" said: >> > One more test unveils this one >> > >> > # modprobe -r sdhci-acpi >> > [ 1289.909441] [ cut here ] >> > [

[PATCH v12 2/4] PM / Domains: add setter for dev.pm_domain

2016-01-29 Thread Rafael J. Wysocki
On Friday, January 29, 2016 06:35:49 PM Andy Shevchenko wrote: > On Fri, Jan 29, 2016 at 5:51 PM, Andy Shevchenko > wrote: > > On Fri, Jan 29, 2016 at 5:38 PM, Andy Shevchenko > > wrote: > >> On Thu, Jan 7, 2016 at 5:46 PM, Tomeu Vizoso >> collabora.com> wrote: > >>> Adds a function that sets

[PATCH v11 2/4] PM / Domains: add setter for dev.pm_domain

2016-01-11 Thread Rafael J. Wysocki
6644] [] (pm_genpd_remove_device) from [] > (genpd_dev_pm_detach+0x30/0xac) > [ 15.195743] r8:c0b0f7f0 r7:c1379734 r6:0001 r5:c0b209c4 > r4:ef181410 r3: > [ 15.203694] [] (genpd_dev_pm_detach) from [] > (dev_pm_domain_detach+0x28/0x2c) > [ 15.212621] r10:ef1814

[PATCH v12 0/4] Allow USB devices to remain runtime-suspended when sleeping

2016-01-09 Thread Rafael J. Wysocki
; drivers/gpu/vga/vga_switcheroo.c | 11 ++- > drivers/misc/mei/pci-me.c | 5 +++-- > drivers/misc/mei/pci-txe.c| 5 +++-- > drivers/usb/core/port.c | 6 ++ > drivers/usb/core/usb.c| 8 +++- > include/linux/device.h

[PATCH v11 2/4] PM / Domains: add setter for dev.pm_domain

2016-01-08 Thread Rafael J. Wysocki
On Thursday, January 07, 2016 03:47:01 PM Tomeu Vizoso wrote: > On 10 November 2015 at 10:33, Daniel Kurtz wrote: > [snip] > > > > The problem appears to be that: > > * On boot, platform_drv_probe() calls dev_pm_domain_attach() before > > drv->probe(); thus, it calls dev_pm_domain_attach()

[PATCH v11 0/4] Allow USB devices to remain runtime-suspended when sleeping

2016-01-05 Thread Rafael J. Wysocki
On Monday, January 04, 2016 06:27:18 PM Derek Basehore wrote: > On Mon, Nov 02, 2015 at 02:50:40AM +0100, Rafael J. Wysocki wrote: > > > > I've queued up this series for the second half of the v4.4 merge window. > > &

[PATCH] tree wide: Use kvfree() than conditional kfree()/vfree()

2015-11-09 Thread Rafael J. Wysocki
On Monday, November 09, 2015 08:56:10 PM Tetsuo Handa wrote: > There are many locations that do > > if (memory_was_allocated_by_vmalloc) > vfree(ptr); > else > kfree(ptr); > > but kvfree() can handle both kmalloc()ed memory and vmalloc()ed memory > using is_vmalloc_addr(). Unless

[PATCH v11 0/4] Allow USB devices to remain runtime-suspended when sleeping

2015-11-02 Thread Rafael J. Wysocki
On Tuesday, October 27, 2015 03:38:47 PM Tomeu Vizoso wrote: > Hi, > > this is v11 of an attempt to make it easier for devices to remain in > runtime PM when the system goes to sleep, mainly to reduce the time > spent resuming devices. > > For this, we interpret the absence of all PM callback

[GIT PULL] On-demand device probing

2015-10-27 Thread Rafael J. Wysocki
On Tuesday, October 20, 2015 12:04:05 PM Alan Stern wrote: > On Tue, 20 Oct 2015, Mark Brown wrote: > > > On Tue, Oct 20, 2015 at 10:40:03AM -0400, Alan Stern wrote: > > > > > Furthermore, that applies only to devices that use synchronous suspend. > > > Async suspend is becoming common, and

[GIT PULL] On-demand device probing

2015-10-27 Thread Rafael J. Wysocki
On Mon, Oct 26, 2015 at 11:51 AM, Michael Turquette wrote: > Quoting Rafael J. Wysocki (2015-10-25 06:54:39) >> On Sun, Oct 25, 2015 at 12:06 AM, Mark Brown wrote: >> > On Sat, Oct 24, 2015 at 04:17:12PM +0200, Rafael J. Wysocki wrote: >> > >> >> Well,

[PATCH v10 2/4] PM / Domains: add setter for dev.pm_domain

2015-10-25 Thread Rafael J. Wysocki
On Wednesday, October 21, 2015 05:34:12 PM Tomeu Vizoso wrote: > Adds a function that sets the pointer to dev_pm_domain in struct device > and that warns if the device has already finished probing. The reason > why we want to enforce that is because in the general case that can > cause problems

[GIT PULL] On-demand device probing

2015-10-25 Thread Rafael J. Wysocki
On Sun, Oct 25, 2015 at 12:06 AM, Mark Brown wrote: > On Sat, Oct 24, 2015 at 04:17:12PM +0200, Rafael J. Wysocki wrote: > >> Well, I'm not quite sure why exactly everyone is so focused on probing here. > > Probe deferral is really noisy even if it's working fine on a give

[GIT PULL] On-demand device probing

2015-10-24 Thread Rafael J. Wysocki
On Friday, October 23, 2015 11:34:34 AM Rob Herring wrote: > On Fri, Oct 23, 2015 at 10:45 AM, Tim Bird wrote: > > On 10/22/2015 11:53 AM, Frank Rowand wrote: > >> On 10/22/2015 7:44 AM, Greg Kroah-Hartman wrote: > >>> > >>> > >>> On Thu, Oct 22, 2015 at 11:05:11AM

[GIT PULL] On-demand device probing

2015-10-22 Thread Rafael J. Wysocki
On Tuesday, October 20, 2015 06:21:55 PM Tomeu Vizoso wrote: > On 20 October 2015 at 18:04, Alan Stern wrote: > > On Tue, 20 Oct 2015, Mark Brown wrote: > > > >> On Tue, Oct 20, 2015 at 10:40:03AM -0400, Alan Stern wrote: > >> > >> > Furthermore, that applies only to devices that use synchronous

[GIT PULL] On-demand device probing

2015-10-22 Thread Rafael J. Wysocki
On Wednesday, October 21, 2015 10:55:14 AM Geert Uytterhoeven wrote: > Hi Rafael, > > On Wed, Oct 21, 2015 at 1:34 AM, Rafael J. Wysocki > wrote: > > On Tuesday, October 20, 2015 09:15:01 AM Rob Herring wrote: > >> On Tue, Oct 20, 2015 at 2:56 AM, Rafael J. Wysock

[GIT PULL] On-demand device probing

2015-10-21 Thread Rafael J. Wysocki
On Tuesday, October 20, 2015 08:35:28 PM Mark Brown wrote: > > --7fVr/IRGAG9sAW4J > Content-Type: text/plain; charset=us-ascii > Content-Disposition: inline > Content-Transfer-Encoding: quoted-printable > > On Tue, Oct 20, 2015 at 01:14:46PM -0400, Alan Stern wrote: > > On Tue, 20 Oct 2015,

[GIT PULL] On-demand device probing

2015-10-21 Thread Rafael J. Wysocki
On Tuesday, October 20, 2015 09:15:01 AM Rob Herring wrote: > On Tue, Oct 20, 2015 at 2:56 AM, Rafael J. Wysocki > wrote: > > On Monday, October 19, 2015 05:58:40 PM Rob Herring wrote: > >> On Mon, Oct 19, 2015 at 4:40 PM, Rafael J. Wysocki > >> wrote: > >&

[GIT PULL] On-demand device probing

2015-10-20 Thread Rafael J. Wysocki
On Monday, October 19, 2015 05:58:40 PM Rob Herring wrote: > On Mon, Oct 19, 2015 at 4:40 PM, Rafael J. Wysocki > wrote: > > On Monday, October 19, 2015 10:58:25 AM Rob Herring wrote: > >> On Mon, Oct 19, 2015 at 10:29 AM, David Woodhouse > >> wrote: > >&

<    1   2   3   4   5   6   >