On Mon, Jan 10, 2022 at 3:24 AM Hans de Goede wrote:
>
> Hi All,
>
> On 1/7/22 20:02, Rajat Jain wrote:
> > Allow a privacy screen provider to stash its private data pointer in the
> > drm_privacy_screen, and update the drm_privacy_screen_register() call to
> &g
user of
privacy screen today, to pass NULL for now to the updated API.
Signed-off-by: Rajat Jain
Reviewed-by: Hans de Goede
---
v5: Same as v4
v4: Added "Reviewed-by" from Hans
v3: Initial version. Came up due to review comments on v2 of other patches.
v2: No v2
v1: No v1
drive
orm driver actually registers the
privacy-screen: https://hansdegoede.livejournal.com/25948.html
Signed-off-by: Rajat Jain
---
v4: * Simplify the detect_chromeos_privacy_screen() function
* Don't change the existing print statement
v3: * Remove the pr_info() from detect_chromeos_privacy_screen(
screen in my personal experience.
In future if this probe deferral turns out to be an issue, we can
consider turning this ACPI driver into something that is probed
earlier than the drm drivers.
Signed-off-by: Rajat Jain
---
v4: Same as v3 (No changes)
v3: * Renamed everything chromeos_priv_scrn_
user of
privacy screen today, to pass NULL for now to the updated API.
Signed-off-by: Rajat Jain
---
v3: Initial version. Came up due to review comments on v2 of other patches.
v2: No v2
v1: No v1
drivers/gpu/drm/drm_privacy_screen.c| 5 -
drivers/platform/x86/thinkpad_acpi.c| 2
that is probed earlier
than the drm drivers.
Signed-off-by: Rajat Jain
---
This patch is rebased on top of linux-next/master
drivers/platform/chrome/Kconfig | 10 ++
drivers/platform/chrome/Makefile | 1 +
drivers/platform/chrome/chromeos_priv_scrn.c | 133
orm driver actually registers the
privacy-screen: https://hansdegoede.livejournal.com/25948.html
Signed-off-by: Rajat Jain
---
This patch is rebased on top of linux-next/master
drivers/gpu/drm/drm_privacy_screen_x86.c | 20
1 file changed, 20 insertions(+)
diff --git a/drive
n though it seems that we don't get any
> RRScreenChangeNotify on hotkey changes, and monitoring udev directly
> seems overkill. Anything should be adjusted at lower levels?
>
> Cheers
>
> On lug 13 2021, at 9:25 pm, Rajat Jain wrote:
>
> > Hello Hans, Marco, et al,
> >
>
Add helper functions that can allow i915 to detect and control
an integrated privacy screen via ACPI methods. These shall be used
in the next patch.
Signed-off-by: Rajat Jain
---
v9: same as v8
v8: Initial version. formed by refactoring the previous patch 4.
print the connector name
Add helper functions that can allow i915 to detect and control
an integrated privacy screen via ACPI methods. These shall be used
in the next patch.
Signed-off-by: Rajat Jain
---
v8: Initial version. formed by refactoring the previous patch 4.
print the connector name in the debug messages
Hi Jani,
On Mon, Mar 9, 2020 at 5:18 PM Rajat Jain wrote:
>
> Hi Jani,
>
> I have 1 question / need 1 help about this patch:
Kind ignore, I found the answer, and posted my new patchset here:
https://patchwork.freedesktop.org/series/74607/
I got a "failed to apply" email f
Hi Jani,
I have 1 question / need 1 help about this patch:
On Mon, Mar 9, 2020 at 5:06 PM Rajat Jain wrote:
>
> Add support for an ACPI based integrated privacy screen that is
> available on some systems.
>
> Signed-off-by: Rajat Jain
> ---
> v7: * Move the privacy
Add support for an ACPI based integrated privacy screen that is
available on some systems.
Signed-off-by: Rajat Jain
---
v7: * Move the privacy-screen property back into drm core.
* Do the actual HW EPS toggling at commit time.
* Provide a sample ACPI node for reference in comments.
v6
Hi Jani,
Thank you for the comments. Please see my responses inline.
On Thu, Mar 5, 2020 at 2:02 AM Jani Nikula wrote:
>
> On Wed, 04 Mar 2020, Rajat Jain wrote:
> > Certain laptops now come with panels that have integrated privacy
> > screens on them. This patch adds suppo
screen, and controlling it, is done
via ACPI _DSM methods.
Currently, this is done only for the Intel display ports. But in future,
this can be done for any other ports if the hardware becomes available
(e.g. external monitors supporting integrated privacy screens?).
Signed-off-by: Rajat Jain
screen, and controlling it, is done
via ACPI _DSM methods.
Currently, this is done only for the Intel display ports. But in future,
this can be done for any other ports if the hardware becomes available
(e.g. external monitors supporting integrated privacy screens?).
Signed-off-by: Rajat Jain
Hi Mark,
On Thu, Feb 20, 2020 at 11:03 AM Mark Pearson wrote:
>
> Hi Rajat,
>
> > -Original Message-
> > From: Rajat Jain
> > Sent: Thursday, February 20, 2020 1:39 PM
> > >
> > > For this particular issue what is the best way to contrib
On Fri, Jan 24, 2020 at 4:11 PM Guenter Roeck wrote:
>
> On Fri, Dec 20, 2019 at 12:03:53PM -0800, Rajat Jain wrote:
> > Certain laptops now come with panels that have integrated privacy
> > screens on them. This patch adds support for such panels by adding
> > a
Hello Jani,
On Fri, Dec 20, 2019 at 12:04 PM Rajat Jain wrote:
>
> Certain laptops now come with panels that have integrated privacy
> screens on them. This patch adds support for such panels by adding
> a privacy-screen property to the intel_connector for the panel, that
> th
Move the code that populates the ACPI device ID for devices, into
more appripriate intel_acpi.c. This is done in preparation for more
users of this code (in next patch).
Signed-off-by: Rajat Jain
---
v5: same as v4
v4: Same as v3
v3: * Renamed the function to intel_acpi_*
* Used forward
screen, and controlling it, is done
via ACPI _DSM methods.
Currently, this is done only for the Intel display ports. But in future,
this can be done for any other ports if the hardware becomes available
(e.g. external monitors supporting integrated privacy screens?).
Signed-off-by: Rajat Jain
HI Jani,
On Thu, Dec 5, 2019 at 1:34 AM Rajat Jain wrote:
>
> On Wed, Nov 20, 2019 at 7:04 AM Jani Nikula
> wrote:
> >
> > On Mon, 04 Nov 2019, Rajat Jain wrote:
> > > Certain laptops now come with panels that have integrated privacy
> > > s
screen, and controlling it, is done
via ACPI _DSM methods.
Currently, this is done only for the Intel display ports. But in future,
this can be done for any other ports if the hardware becomes available
(e.g. external monitors supporting integrated privacy screens?).
Signed-off-by: Rajat Jain
screen, and controlling it, is done
via ACPI _DSM methods.
Currently, this is done only for the Intel display ports. But in future,
this can be done for any other ports if the hardware becomes available
(e.g. external monitors supporting integrated privacy screens?).
Signed-off-by: Rajat Jain
On Thu, Dec 5, 2019 at 1:34 AM Rajat Jain wrote:
>
> Certain laptops now come with panels that have integrated privacy
> screens on them. This patch adds support for such panels by adding
> a privacy-screen property to the intel_connector for the panel, that
> the userspa
Move the code that populates the ACPI device ID for devices, into
more appripriate intel_acpi.c. This is done in preparation for more
users of this code (in next patch).
Signed-off-by: Rajat Jain
---
v3: * Renamed the function to intel_acpi_*
* Used forward declaration for structure instead
On Wed, Nov 20, 2019 at 6:51 AM Jani Nikula wrote:
>
> On Mon, 04 Nov 2019, Rajat Jain wrote:
> > Lookup and attach ACPI nodes for intel connectors. The lookup is done
> > in compliance with ACPI Spec 6.3
> > https://uefi.org/sites/default/files/resources/ACPI_6_3_final_J
Hi Jani,
Thanks for the review.
On Wed, Nov 20, 2019 at 6:41 AM Jani Nikula wrote:
>
> On Mon, 04 Nov 2019, Rajat Jain wrote:
> > Move the code that populates the ACPI device ID for devices, into
> > more appripriate intel_acpi.c. This is done in preparation for more
>
screen, and controlling it, is done
via ACPI _DSM methods.
Currently, this is done only for the Intel display ports. But in future,
this can be done for any other ports if the hardware becomes available
(e.g. external monitors supporting integrated privacy screens?).
Signed-off-by: Rajat Jain
for privacy screen in next patch).
Signed-off-by: Rajat Jain
---
v3: fold the code into existing acpi_device_id_update() function
v2: formed by splitting the original patch into ACPI lookup, and privacy
screen property. Also move it into i915 now that I found existing code
in i915 that can be re
On Wed, Nov 20, 2019 at 7:04 AM Jani Nikula wrote:
>
> On Mon, 04 Nov 2019, Rajat Jain wrote:
> > Certain laptops now come with panels that have integrated privacy
> > screens on them. This patch adds support for such panels by adding
> > a privacy-screen propert
Hi Jani,
On Wed, Nov 20, 2019 at 7:11 AM Jani Nikula wrote:
>
> On Tue, 12 Nov 2019, Rajat Jain wrote:
> > On Mon, Nov 4, 2019 at 11:41 AM Rajat Jain wrote:
> >>
> >> Certain laptops now come with panels that have integrated privacy
> >> screens on them.
On Mon, Nov 4, 2019 at 11:41 AM Rajat Jain wrote:
>
> Certain laptops now come with panels that have integrated privacy
> screens on them. This patch adds support for such panels by adding
> a privacy-screen property to the intel_connector for the panel, that
> the userspa
screen, and controlling it, is done
via ACPI _DSM methods.
Currently, this is done only for the Intel display ports. But in future,
this can be done for any other ports if the hardware becomes available
(e.g. external monitors supporting integrated privacy screens?).
Signed-off-by: Rajat Jain
Move the code that populates the ACPI device ID for devices, into
more appripriate intel_acpi.c. This is done in preparation for more
users of this code (in next patch).
Signed-off-by: Rajat Jain
Change-Id: Ifb3bd458734985c2a78ba682e6f0a2e63e0626ca
---
v2: v1 doesn't exist. Found existing code
for privacy screen in next patch).
Signed-off-by: Rajat Jain
Change-Id: I798e70714a4402554c8cd2a8e58268353f75814f
---
v2: formed by splitting the original patch into ACPI lookup, and privacy
screen property. Also move it into i915 now that I found existing code
in i915 that can be re-used.
drivers
On Fri, Oct 25, 2019 at 4:36 AM Thierry Reding wrote:
>
> On Thu, Oct 24, 2019 at 01:45:16PM -0700, Rajat Jain wrote:
> > Hi,
> >
> > Thanks for your review and comments. Please see inline below.
> >
> > On Thu, Oct 24, 2019 at 4:20 AM Thierry Reding
> &g
Hi,
Thanks for your review and comments. Please see inline below.
On Thu, Oct 24, 2019 at 4:20 AM Thierry Reding wrote:
>
> On Tue, Oct 22, 2019 at 05:12:06PM -0700, Rajat Jain wrote:
> > Certain laptops now come with panels that have integrated privacy
> > screens on the
Hi Folks,
On Mon, Oct 7, 2019 at 11:13 PM Jani Nikula
wrote:
> On Mon, 07 Oct 2019, Mat King wrote:
> > That makes sense; just to confirm can a property be added or removed
> > after the connector is registered?
>
> You need to create the property before registering the drm device. You
> can
On Tue, Oct 22, 2019 at 5:14 PM Rajat Jain wrote:
>
> Hi Folks,
>
> On Mon, Oct 7, 2019 at 11:13 PM Jani Nikula
> wrote:
>>
>> On Mon, 07 Oct 2019, Mat King wrote:
>> > That makes sense; just to confirm can a property be added or removed
>> > afte
cy screens?).
Also, this code can be extended in future to support non-ACPI methods
(e.g. using a kernel GPIO driver to toggle a gpio that controls the
privacy-screen).
Signed-off-by: Rajat Jain
---
drivers/gpu/drm/Makefile| 1 +
drivers/gpu/drm/drm_atomic_uapi.c | 5 +
drive
On Mon, Oct 7, 2019 at 9:19 AM Mat King wrote:
>
> On Mon, Oct 7, 2019 at 7:09 AM Sean Paul wrote:
> >
> > On Thu, Oct 3, 2019 at 3:57 PM Mat King wrote:
> > >
> > > On Thu, Oct 3, 2019 at 2:59 AM Jani Nikula
> > > wrote:
> > > >
> > > > On Wed, 02 Oct 2019, Mat King wrote:
> > > > > On Wed,
Hi,
Me and Mat are working on this together, and I had a followup to
something Mat asked earlier.
On Thu, Oct 3, 2019 at 12:57 PM Mat King wrote:
>
> On Thu, Oct 3, 2019 at 2:59 AM Jani Nikula
> wrote:
> >
> > On Wed, 02 Oct 2019, Mat King wrote:
> > > On Wed, Oct 2, 2019 at 4:46 AM Jani
43 matches
Mail list logo
